RE: [PATCH 1/2] eppic: vhost_net_buffers - Adopt to struct sk_buff changes
>On Monday 19 December 2016 01:04 PM, Atsushi Kumagai wrote: >> Hello Kamalesh, >> >> Thanks for taking care of the scripts. >> >> The current scripts are created based on the same kernel version: >> >> === >> Eppic scripts README >> == >> >> The eppic scripts are based on the fedora 19 kernel. >> >> So if you update a part of the scripts, the target kernel version of >> them will be complex and confusing. >> I don't think we need to update these scripts since they are just sample, >> the purpose is to tell users how to write a script. >> > >Thank you for the review. Agree, these scripts are guide on how to write >eppic >scripts. On the other hand, if the user tries to run these scripts on >the latest kernel + >supported makedumpfile for that release, they would fail. These scripts >are outdated, >when run on latest kernel due to data structure changes. I can take up the >responsibility of maintaining eppic scripts against kernel changes for >every makedumpfile >release. If you will maintain them after this, I have no reason to reject it. I don't think all of the kernel version should be covered by the samples, but it's better to keep existing scripts because users don't always use the latest kernel. For that reason, I want to clarify the correspondence between script file and kernel version at least for existing files like: vhost_net_buffers_2_6_18_to_2_6_32.c vhost_net_buffers_2_6_33_to_3_10.c vhost_net_buffers_3_11_to_4_8.c ... // just sample, not fact Of course writing the correspondence table into README is OK, any ideas are welcome. After this clean up, let's follow up newer kernel versions. Thanks, Atsushi Kumagai ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH 1/2] eppic: vhost_net_buffers - Adopt to struct sk_buff changes
On Monday 19 December 2016 01:04 PM, Atsushi Kumagai wrote: Hello Kamalesh, Thanks for taking care of the scripts. The current scripts are created based on the same kernel version: === Eppic scripts README == The eppic scripts are based on the fedora 19 kernel. So if you update a part of the scripts, the target kernel version of them will be complex and confusing. I don't think we need to update these scripts since they are just sample, the purpose is to tell users how to write a script. Thank you for the review. Agree, these scripts are guide on how to write eppic scripts. On the other hand, if the user tries to run these scripts on the latest kernel + supported makedumpfile for that release, they would fail. These scripts are outdated, when run on latest kernel due to data structure changes. I can take up the responsibility of maintaining eppic scripts against kernel changes for every makedumpfile release. -- cheers, Kamalesh. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
RE: [PATCH 1/2] eppic: vhost_net_buffers - Adopt to struct sk_buff changes
Hello Kamalesh,
Thanks for taking care of the scripts.
The current scripts are created based on the same kernel version:
===
Eppic scripts README
==
The eppic scripts are based on the fedora 19 kernel.
So if you update a part of the scripts, the target kernel version of
them will be complex and confusing.
I don't think we need to update these scripts since they are just sample,
the purpose is to tell users how to write a script.
Thanks,
Atsushi Kumagai
>Linux kernel commit 56b174256b69 ("net: add rbnode to struct sk_buff"),
>moves sk_buff->next into an union of sk_buff->{next/prev/tstamp/rb_node}.
>Introduce this structure member change, while traversing the socket
>buffer list.
>
>Signed-off-by: Kamalesh Babulal
>---
> eppic_scripts/vhost_net_buffers.c | 11 ---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
>diff --git a/eppic_scripts/vhost_net_buffers.c
>b/eppic_scripts/vhost_net_buffers.c
>index 39ae595..1260acb 100644
>--- a/eppic_scripts/vhost_net_buffers.c
>+++ b/eppic_scripts/vhost_net_buffers.c
>@@ -45,7 +45,10 @@ vhost_net(struct vhost_net *net)
> memset((char *)&(buff->data_len), 'L', 0x4);
> }
>
>- next = buff->next;
>+ /*
>+ * .next is the first entry.
>+ */
>+ next = (struct sk_buff *)(unsigned long)*buff;
> }
>
> head = (struct sk_buff_head *)&(sk->sk_write_queue);
>@@ -60,8 +63,10 @@ vhost_net(struct vhost_net *net)
> memset((char *)&(buff->data_len), 'L', 0x4);
> }
>
>- next = buff->next;
>-
>+ /*
>+ * .next is the first entry.
>+ */
>+ next = (struct sk_buff *)(unsigned long)*buff;
> }
> }
> }
>--
>2.7.4
>
>
>___
>kexec mailing list
>kexec@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/kexec
___
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
[PATCH 1/2] eppic: vhost_net_buffers - Adopt to struct sk_buff changes
Linux kernel commit 56b174256b69 ("net: add rbnode to struct sk_buff"),
moves sk_buff->next into an union of sk_buff->{next/prev/tstamp/rb_node}.
Introduce this structure member change, while traversing the socket
buffer list.
Signed-off-by: Kamalesh Babulal
---
eppic_scripts/vhost_net_buffers.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/eppic_scripts/vhost_net_buffers.c
b/eppic_scripts/vhost_net_buffers.c
index 39ae595..1260acb 100644
--- a/eppic_scripts/vhost_net_buffers.c
+++ b/eppic_scripts/vhost_net_buffers.c
@@ -45,7 +45,10 @@ vhost_net(struct vhost_net *net)
memset((char *)&(buff->data_len), 'L', 0x4);
}
- next = buff->next;
+ /*
+* .next is the first entry.
+*/
+ next = (struct sk_buff *)(unsigned long)*buff;
}
head = (struct sk_buff_head *)&(sk->sk_write_queue);
@@ -60,8 +63,10 @@ vhost_net(struct vhost_net *net)
memset((char *)&(buff->data_len), 'L', 0x4);
}
- next = buff->next;
-
+ /*
+* .next is the first entry.
+*/
+ next = (struct sk_buff *)(unsigned long)*buff;
}
}
}
--
2.7.4
___
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
