Re: [PATCH V5 0/2] Support VMCOREINFO export for RISCV64
On Wed, Dec 07, 2022 at 11:34:57AM +0800, Guo Ren wrote: > On Wed, Dec 7, 2022 at 7:05 AM Conor Dooley wrote: > > > > Hey Palmer, Xianting, > > > > On Fri, Dec 02, 2022 at 04:49:39PM -0800, Palmer Dabbelt wrote: > > > On Wed, 26 Oct 2022 22:42:06 +0800, Xianting Tian wrote: > > > > As disscussed in below patch set, the patch of 'describe VMCOREINFO > > > > export in Documentation' > > > > need to update according to Bagas's comments. > > > > https://lore.kernel.org/linux-riscv/22aaf52e-8cc8-4d11-99cb-88de4d113...@kernel.org/ > > > > > > > > As others patches in above patch set already applied, so this patch set > > > > only contains below two > > > > patches. > > > > > > > > [...] > > > > > > Applied, thanks! > > > > > > [1/2] RISC-V: Add arch_crash_save_vmcoreinfo support > > > https://git.kernel.org/palmer/c/649d6b1019a2 > > > > So this patch seems to be causing issues for the nommu build: > > https://lore.kernel.org/oe-kbuild-all/202212062250.tr0othcz-...@intel.com/ > > > > I had a bit of a poke at trying to see if there were some headers we > > could pull in before actually checking the .config only to see: > > # CONFIG_MMU is not set > > > > Do we have to wrap the whole thing in a `#ifdef CONFIG_MMU` to fix > > compilation here? > The problem does not belong to the patch. > > Could I send a fixup patch? like this? That seems like a sane dependancy, but did you build that config? This doesn't fix the problem for me :/ > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index ef8d66de5f38..d8c07999426c 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -512,6 +512,7 @@ config ARCH_HAS_KEXEC_PURGATORY > > config CRASH_DUMP > bool "Build kdump crash kernel" > + depends on KEXEC > help > Generate crash dump after being started by kexec. This should > be normally only set in special crash dump kernels which are > > > > > Thanks, > > Conor. > > > > > -- > Best Regards > Guo Ren signature.asc Description: PGP signature ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH V5 0/2] Support VMCOREINFO export for RISCV64
Hey Palmer, Xianting, On Fri, Dec 02, 2022 at 04:49:39PM -0800, Palmer Dabbelt wrote: > On Wed, 26 Oct 2022 22:42:06 +0800, Xianting Tian wrote: > > As disscussed in below patch set, the patch of 'describe VMCOREINFO export > > in Documentation' > > need to update according to Bagas's comments. > > https://lore.kernel.org/linux-riscv/22aaf52e-8cc8-4d11-99cb-88de4d113...@kernel.org/ > > > > As others patches in above patch set already applied, so this patch set > > only contains below two > > patches. > > > > [...] > > Applied, thanks! > > [1/2] RISC-V: Add arch_crash_save_vmcoreinfo support > https://git.kernel.org/palmer/c/649d6b1019a2 So this patch seems to be causing issues for the nommu build: https://lore.kernel.org/oe-kbuild-all/202212062250.tr0othcz-...@intel.com/ I had a bit of a poke at trying to see if there were some headers we could pull in before actually checking the .config only to see: # CONFIG_MMU is not set Do we have to wrap the whole thing in a `#ifdef CONFIG_MMU` to fix compilation here? Thanks, Conor. signature.asc Description: PGP signature ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH V5 0/2] Support VMCOREINFO export for RISCV64
On Wed, Dec 7, 2022 at 4:08 PM Conor Dooley wrote: > > On Wed, Dec 07, 2022 at 11:34:57AM +0800, Guo Ren wrote: > > On Wed, Dec 7, 2022 at 7:05 AM Conor Dooley wrote: > > > > > > Hey Palmer, Xianting, > > > > > > On Fri, Dec 02, 2022 at 04:49:39PM -0800, Palmer Dabbelt wrote: > > > > On Wed, 26 Oct 2022 22:42:06 +0800, Xianting Tian wrote: > > > > > As disscussed in below patch set, the patch of 'describe VMCOREINFO > > > > > export in Documentation' > > > > > need to update according to Bagas's comments. > > > > > https://lore.kernel.org/linux-riscv/22aaf52e-8cc8-4d11-99cb-88de4d113...@kernel.org/ > > > > > > > > > > As others patches in above patch set already applied, so this patch > > > > > set only contains below two > > > > > patches. > > > > > > > > > > [...] > > > > > > > > Applied, thanks! > > > > > > > > [1/2] RISC-V: Add arch_crash_save_vmcoreinfo support > > > > https://git.kernel.org/palmer/c/649d6b1019a2 > > > > > > So this patch seems to be causing issues for the nommu build: > > > https://lore.kernel.org/oe-kbuild-all/202212062250.tr0othcz-...@intel.com/ > > > > > > I had a bit of a poke at trying to see if there were some headers we > > > could pull in before actually checking the .config only to see: > > > # CONFIG_MMU is not set > > > > > > Do we have to wrap the whole thing in a `#ifdef CONFIG_MMU` to fix > > > compilation here? > > The problem does not belong to the patch. > > > > Could I send a fixup patch? like this? > > That seems like a sane dependancy, but did you build that config? > This doesn't fix the problem for me :/ Sorry, It's the wrong fixup. Here is the new version, and tested. Thx for the report. https://lore.kernel.org/linux-riscv/20221207091112.2258674-1-guo...@kernel.org/ > > > > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > > index ef8d66de5f38..d8c07999426c 100644 > > --- a/arch/riscv/Kconfig > > +++ b/arch/riscv/Kconfig > > @@ -512,6 +512,7 @@ config ARCH_HAS_KEXEC_PURGATORY > > > > config CRASH_DUMP > > bool "Build kdump crash kernel" > > + depends on KEXEC > > help > > Generate crash dump after being started by kexec. This should > > be normally only set in special crash dump kernels which are > > > > > > > > Thanks, > > > Conor. > > > > > > > > > -- > > Best Regards > > Guo Ren -- Best Regards Guo Ren ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH V5 0/2] Support VMCOREINFO export for RISCV64
On Wed, Dec 7, 2022 at 7:05 AM Conor Dooley wrote: > > Hey Palmer, Xianting, > > On Fri, Dec 02, 2022 at 04:49:39PM -0800, Palmer Dabbelt wrote: > > On Wed, 26 Oct 2022 22:42:06 +0800, Xianting Tian wrote: > > > As disscussed in below patch set, the patch of 'describe VMCOREINFO > > > export in Documentation' > > > need to update according to Bagas's comments. > > > https://lore.kernel.org/linux-riscv/22aaf52e-8cc8-4d11-99cb-88de4d113...@kernel.org/ > > > > > > As others patches in above patch set already applied, so this patch set > > > only contains below two > > > patches. > > > > > > [...] > > > > Applied, thanks! > > > > [1/2] RISC-V: Add arch_crash_save_vmcoreinfo support > > https://git.kernel.org/palmer/c/649d6b1019a2 > > So this patch seems to be causing issues for the nommu build: > https://lore.kernel.org/oe-kbuild-all/202212062250.tr0othcz-...@intel.com/ > > I had a bit of a poke at trying to see if there were some headers we > could pull in before actually checking the .config only to see: > # CONFIG_MMU is not set > > Do we have to wrap the whole thing in a `#ifdef CONFIG_MMU` to fix > compilation here? The problem does not belong to the patch. Could I send a fixup patch? like this? diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index ef8d66de5f38..d8c07999426c 100644 --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -512,6 +512,7 @@ config ARCH_HAS_KEXEC_PURGATORY config CRASH_DUMP bool "Build kdump crash kernel" + depends on KEXEC help Generate crash dump after being started by kexec. This should be normally only set in special crash dump kernels which are > > Thanks, > Conor. > -- Best Regards Guo Ren ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH V5 0/2] Support VMCOREINFO export for RISCV64
Hi Palmer, Here are another two fix-up patches of kdump for the crash tool. https://lore.kernel.org/linux-riscv/20221020141603.2856206-3-guo...@kernel.org/ https://lore.kernel.org/linux-riscv/20221020141603.2856206-2-guo...@kernel.org/ On Sat, Dec 3, 2022 at 8:56 AM Palmer Dabbelt wrote: > > On Wed, 26 Oct 2022 22:42:06 +0800, Xianting Tian wrote: > > As disscussed in below patch set, the patch of 'describe VMCOREINFO export > > in Documentation' > > need to update according to Bagas's comments. > > https://lore.kernel.org/linux-riscv/22aaf52e-8cc8-4d11-99cb-88de4d113...@kernel.org/ > > > > As others patches in above patch set already applied, so this patch set > > only contains below two > > patches. > > > > [...] > > Applied, thanks! > > [1/2] RISC-V: Add arch_crash_save_vmcoreinfo support > https://git.kernel.org/palmer/c/649d6b1019a2 > [2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64 > https://git.kernel.org/palmer/c/c5b4216929eb > > Best regards, > -- > Palmer Dabbelt -- Best Regards Guo Ren ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH V5 0/2] Support VMCOREINFO export for RISCV64
Hello: This series was applied to riscv/linux.git (for-next) by Palmer Dabbelt : On Wed, 26 Oct 2022 22:42:06 +0800 you wrote: > As disscussed in below patch set, the patch of 'describe VMCOREINFO export in > Documentation' > need to update according to Bagas's comments. > https://lore.kernel.org/linux-riscv/22aaf52e-8cc8-4d11-99cb-88de4d113...@kernel.org/ > > As others patches in above patch set already applied, so this patch set only > contains below two > patches. > > [...] Here is the summary with links: - [V5,1/2] RISC-V: Add arch_crash_save_vmcoreinfo support https://git.kernel.org/riscv/c/649d6b1019a2 - [V5,2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64 https://git.kernel.org/riscv/c/c5b4216929eb You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH V5 0/2] Support VMCOREINFO export for RISCV64
On Wed, 26 Oct 2022 22:42:06 +0800, Xianting Tian wrote: > As disscussed in below patch set, the patch of 'describe VMCOREINFO export in > Documentation' > need to update according to Bagas's comments. > https://lore.kernel.org/linux-riscv/22aaf52e-8cc8-4d11-99cb-88de4d113...@kernel.org/ > > As others patches in above patch set already applied, so this patch set only > contains below two > patches. > > [...] Applied, thanks! [1/2] RISC-V: Add arch_crash_save_vmcoreinfo support https://git.kernel.org/palmer/c/649d6b1019a2 [2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64 https://git.kernel.org/palmer/c/c5b4216929eb Best regards, -- Palmer Dabbelt ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH V5 0/2] Support VMCOREINFO export for RISCV64
Hi risc-v maintainers, On 10/26/22 at 10:42pm, Xianting Tian wrote: > As disscussed in below patch set, the patch of 'describe VMCOREINFO export in > Documentation' > need to update according to Bagas's comments. > https://lore.kernel.org/linux-riscv/22aaf52e-8cc8-4d11-99cb-88de4d113...@kernel.org/ > > As others patches in above patch set already applied, so this patch set only > contains below two > patches. Could you pick this patchset into risc-v tree since it has got acks and two Tested-by? Thanks Baoquan ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH V5 0/2] Support VMCOREINFO export for RISCV64
On 10/26/22 at 10:42pm, Xianting Tian wrote: > As disscussed in below patch set, the patch of 'describe VMCOREINFO export in > Documentation' > need to update according to Bagas's comments. > https://lore.kernel.org/linux-riscv/22aaf52e-8cc8-4d11-99cb-88de4d113...@kernel.org/ > > As others patches in above patch set already applied, so this patch set only > contains below two > patches. > > -- > Changes: >Fix commit message in patch 2: use "Document these RISCV64 exports above" > instead of >"This patch just add the description of VMCOREINFO export for RISCV64." > V1 -> V2: >Remove unnecessary overline above header text in patch 2. > V2 -> V3: >Fix commit message in patch 1,2; >Use 'space' instead of 'region' for vmemmap description in patch 2. > V3 -> V4: >Remove unnecessary kernel space export: >KASAN_SHADOW_START ~ KASAN_SHADOW_END, >ADDRESS_SPACE_END > V4 -> V5: >Remove IS_ENABLED() judgement for KERNEL_LINK_ADDR in patch 1. This series looks good to me, thanks. Acked-by: Baoquan He ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
[PATCH V5 0/2] Support VMCOREINFO export for RISCV64
As disscussed in below patch set, the patch of 'describe VMCOREINFO export in Documentation' need to update according to Bagas's comments. https://lore.kernel.org/linux-riscv/22aaf52e-8cc8-4d11-99cb-88de4d113...@kernel.org/ As others patches in above patch set already applied, so this patch set only contains below two patches. -- Changes: Fix commit message in patch 2: use "Document these RISCV64 exports above" instead of "This patch just add the description of VMCOREINFO export for RISCV64." V1 -> V2: Remove unnecessary overline above header text in patch 2. V2 -> V3: Fix commit message in patch 1,2; Use 'space' instead of 'region' for vmemmap description in patch 2. V3 -> V4: Remove unnecessary kernel space export: KASAN_SHADOW_START ~ KASAN_SHADOW_END, ADDRESS_SPACE_END V4 -> V5: Remove IS_ENABLED() judgement for KERNEL_LINK_ADDR in patch 1. Xianting Tian (2): RISC-V: Add arch_crash_save_vmcoreinfo support Documentation: kdump: describe VMCOREINFO export for RISCV64 .../admin-guide/kdump/vmcoreinfo.rst | 29 +++ arch/riscv/kernel/Makefile| 1 + arch/riscv/kernel/crash_core.c| 21 ++ 3 files changed, 51 insertions(+) create mode 100644 arch/riscv/kernel/crash_core.c -- 2.17.1 ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
