Re: [PATCH v3 05/22] firmware: move completing fw into a helper

[Kees Cook]

On Wed, Feb 3, 2016 at 11:06 AM, Mimi Zohar  wrote:
> From: "Luis R. Rodriguez" 
>
> This will be re-used later through a new extensible interface.
>
> Reviewed-by: Josh Boyer 
> Signed-off-by: Luis R. Rodriguez 
> Signed-off-by: Mimi Zohar 

Acked-by: Kees Cook 

-Kees

> ---
>  drivers/base/firmware_class.c | 14 ++
>  1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
> index 3358f5d..fb64814 100644
> --- a/drivers/base/firmware_class.c
> +++ b/drivers/base/firmware_class.c
> @@ -322,6 +322,15 @@ fail:
> return rc;
>  }
>
> +static void fw_finish_direct_load(struct device *device,
> + struct firmware_buf *buf)
> +{
> +   mutex_lock(_lock);
> +   set_bit(FW_STATUS_DONE, >status);
> +   complete_all(>completion);
> +   mutex_unlock(_lock);
> +}
> +
>  static int fw_get_filesystem_firmware(struct device *device,
>struct firmware_buf *buf)
>  {
> @@ -363,10 +372,7 @@ static int fw_get_filesystem_firmware(struct device 
> *device,
> if (!rc) {
> dev_dbg(device, "direct-loading %s\n",
> buf->fw_id);
> -   mutex_lock(_lock);
> -   set_bit(FW_STATUS_DONE, >status);
> -   complete_all(>completion);
> -   mutex_unlock(_lock);
> +   fw_finish_direct_load(device, buf);
> }
>
> return rc;
> --
> 2.1.0
>



-- 
Kees Cook
Chrome OS & Brillo Security

___
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

[PATCH v3 05/22] firmware: move completing fw into a helper

[Mimi Zohar]

From: "Luis R. Rodriguez" 

This will be re-used later through a new extensible interface.

Reviewed-by: Josh Boyer 
Signed-off-by: Luis R. Rodriguez 
Signed-off-by: Mimi Zohar 
---
 drivers/base/firmware_class.c | 14 ++
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index 3358f5d..fb64814 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -322,6 +322,15 @@ fail:
return rc;
 }
 
+static void fw_finish_direct_load(struct device *device,
+ struct firmware_buf *buf)
+{
+   mutex_lock(_lock);
+   set_bit(FW_STATUS_DONE, >status);
+   complete_all(>completion);
+   mutex_unlock(_lock);
+}
+
 static int fw_get_filesystem_firmware(struct device *device,
   struct firmware_buf *buf)
 {
@@ -363,10 +372,7 @@ static int fw_get_filesystem_firmware(struct device 
*device,
if (!rc) {
dev_dbg(device, "direct-loading %s\n",
buf->fw_id);
-   mutex_lock(_lock);
-   set_bit(FW_STATUS_DONE, >status);
-   complete_all(>completion);
-   mutex_unlock(_lock);
+   fw_finish_direct_load(device, buf);
}
 
return rc;
-- 
2.1.0


___
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec