[Kicad-developers] code minor improvements -- patch
Remove useless HK_* defines.
Use HK_DELETE instead of HK_DELETE_PIN.
Replace tabs with spaces in code
Regards,
--
Yury Khalyavin
=== modified file eeschema/hotkeys.cpp
--- eeschema/hotkeys.cpp 2010-07-20 11:58:23 +
+++ eeschema/hotkeys.cpp 2010-07-21 07:10:19 +
@@ -153,8 +153,6 @@
static Ki_HotkeyInfo HkInsertPin( wxT( "Repeat Pin" ), HK_REPEAT_LAST,
WXK_INSERT );
static Ki_HotkeyInfo HkMovePin( wxT( "Move Pin" ), HK_LIBEDIT_MOVE_GRAPHIC_ITEM, 'M' );
-static Ki_HotkeyInfo HkDeletePin( wxT( "Delete Pin" ), HK_DELETE_PIN,
- WXK_DELETE );
// List of common hotkey descriptors
@@ -205,7 +203,7 @@
&HkInsertPin,
&HkEdit,
&HkMovePin,
-&HkDeletePin,
+&HkDelete,
&HkRotate,
&HkDrag,
NULL
@@ -865,7 +863,7 @@
break;
}
-case HK_DELETE_PIN:
+case HK_DELETE:
m_drawItem = LocateItemUsingCursor();
if( m_drawItem )
=== modified file eeschema/hotkeys.h
--- eeschema/hotkeys.h 2010-07-20 11:47:31 +
+++ eeschema/hotkeys.h 2010-07-21 07:10:19 +
@@ -15,16 +15,13 @@
HK_FIND_ITEM,
HK_DELETE,
HK_REPEAT_LAST,
- HK_EDIT_PIN,
- HK_LIBEDIT_MOVE_GRAPHIC_ITEM,
- HK_LIBEDIT_ROTATE_PIN,
- HK_LIBEDIT_CREATE_PIN,
-HK_DELETE_PIN,
+HK_LIBEDIT_MOVE_GRAPHIC_ITEM,
+HK_LIBEDIT_CREATE_PIN,
HK_MOVEBLOCK_TO_DRAGBLOCK,
HK_ROTATE,
- HK_EDIT,
- HK_EDIT_COMPONENT_VALUE,
- HK_EDIT_COMPONENT_FOOTPRINT,
+HK_EDIT,
+HK_EDIT_COMPONENT_VALUE,
+HK_EDIT_COMPONENT_FOOTPRINT,
HK_MIRROR_X_COMPONENT,
HK_MIRROR_Y_COMPONENT,
HK_ORIENT_NORMAL_COMPONENT,
@@ -46,4 +43,4 @@
// List of hotkey descriptors for the lib browser only
extern struct Ki_HotkeyInfoSectionDescriptor s_Viewlib_Hokeys_Descr[];
-#endif // KOTKEYS_H
+#endif // KOTKEYS_H
=== modified file eeschema/libedit_onrightclick.cpp
--- eeschema/libedit_onrightclick.cpp 2010-07-20 11:58:23 +
+++ eeschema/libedit_onrightclick.cpp 2010-07-21 07:10:19 +
@@ -1,5 +1,5 @@
//
-/* EESchema - libedit_onrightclick.cpp */
+/* EESchema - libedit_onrightclick.cpp */
//
/* , In library editor, create the pop menu when clicking on mouse right button
@@ -85,21 +85,21 @@
HK_LIBEDIT_MOVE_GRAPHIC_ITEM );
ADD_MENUITEM( PopMenu, ID_POPUP_LIBEDIT_MOVE_ITEM_REQUEST,
msg, move_arc_xpm );
- msg = AddHotkeyName( _( "Drag Arc Size" ), s_Libedit_Hokeys_Descr,
- HK_DRAG );
- ADD_MENUITEM( PopMenu, ID_POPUP_LIBEDIT_MODIFY_ITEM,
+msg = AddHotkeyName( _( "Drag Arc Size" ), s_Libedit_Hokeys_Descr,
+ HK_DRAG );
+ADD_MENUITEM( PopMenu, ID_POPUP_LIBEDIT_MODIFY_ITEM,
msg, move_arc_xpm );
}
msg = AddHotkeyName( _( "Edit Arc Options" ), s_Libedit_Hokeys_Descr,
- HK_EDIT );
+ HK_EDIT );
ADD_MENUITEM( PopMenu, ID_POPUP_LIBEDIT_BODY_EDIT_ITEM,
msg, options_arc_xpm );
if( DrawEntry->m_Flags == 0 )
{
msg = AddHotkeyName( _( "Delete Arc " ), s_Libedit_Hokeys_Descr,
- HK_DELETE_PIN );
+ HK_DELETE );
ADD_MENUITEM( PopMenu, ID_POPUP_LIBEDIT_DELETE_ITEM,
msg, delete_arc_xpm );
}
@@ -115,22 +115,22 @@
}
if( DrawEntry->m_Flags == 0 )
- {
- msg = AddHotkeyName( _( "Drag Circle Outline" ), s_Libedit_Hokeys_Descr,
- HK_DRAG );
- ADD_MENUITEM( PopMenu, ID_POPUP_LIBEDIT_MODIFY_ITEM,
- msg, move_rectangle_xpm );
- }
+{
+msg = AddHotkeyName( _( "Drag Circle Outline" ), s_Libedit_Hokeys_Descr,
+ HK_DRAG );
+ADD_MENUITEM( PopMenu, ID_POPUP_LIBEDIT_MODIFY_ITEM,
+ msg, move_rectangle_xpm );
+}
msg = AddHotkeyName( _( "Edit Circle Options" ), s_Libedit_Hokeys_Descr,
- HK_EDIT );
+ HK_EDIT );
ADD_MENUITEM( PopMenu, ID_POPUP_LIBEDIT_BODY_EDIT_ITEM,
msg, options_circle_xpm );
if( DrawEntry->m_Flags == 0 )
{
msg = AddHotkeyName( _( "Delete Circle " ),
- s_Libedit_Hokeys_Descr, HK_DELETE_PIN );
+ s_Libedit_Hokeys_Descr, HK_DELETE );
ADD_MENUITEM( PopMenu, ID_POPUP_LIBEDIT_DELETE_ITEM,
msg, delete_circle_xpm );
}
@@ -146,22 +146,22 @@
}
msg = AddHotkeyName( _( "Edit Rectangle Options" ), s_Libedit_Hokeys_Descr,
- HK_EDIT );
+ HK_EDIT );
ADD_MENUITEM( PopMenu, ID_POPUP_LIBEDIT_BODY_EDIT_
[Kicad-developers] pcbnew module editor toolbar items now in menubar -- patch
Because almost all toolbar items are not in the menubar of the module editor I wrote a small patch. Maybe someone can take care of the few TODO's inside the patch which I was not able to get. The File -> Close needs a ID handler and need's to be fixed. And maybe some entries should not be selectable in some cases like undo,redo and the placement of components if there is no module loaded or new module created. Maybe all the *modedit* files can better be moved to a subdirectory if the code will be growing. And also moving the dialog_* files. Because we get already a nice amount of files and directories are handy to sort things up. See the attached patch, it applies to rev 2418 without problems. -- Kind Regards, Met vriendelijke groet, Jerry Jacobs - http://www.xor-gate.org pcbnew_module_editor_extended_menubar.patch Description: Binary data ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Show in eeschema window title full/short path to open file -- patch
On 21 July 2010 06:48, Yury Khalyavin wrote:
> On Tue, Jul 20, 2010 at 12:37:29PM -0500, Dick Hollenbeck wrote:
>> I DO like the concept of a title which shows the filename up near the
>> front, before a long path.
>>
>> I think:
>>
>> 1) we should be able to agree on a standard format and not go through
>> the trouble having this be a configuration option.
> Yes, I agree. But I think show full path to opened file is not
> best solution.
>
> May be do like vim: filename (path/to/filename-dir) ?
>
-title << GetScreen()->m_FileName << wxT( "] " ) << _( "Sheet" );
-title << wxT( " " ) << m_CurrentSheet->PathHumanReadable();
+if (g_TitleFullPath)
+{
+title << GetScreen()->m_FileName << wxT( "] " ) << _( "Sheet" );
+title << wxT( " " ) << m_CurrentSheet->PathHumanReadable();
+}
+else
+{
+wxFileName t(GetScreen()->m_FileName);
+title << t.GetName() << wxT( "] " ) << _( "Sheet" );
+}
The replacement adds the suffix Sheet, but not the sheet name. I think
it would be good to keep the sheet name. So perhaps something along
the lines of "filename/sheetname (/path/to/filename)"
Best Regards,
Brian.
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Show in eeschema window title full/short path to open file -- patch
Brian Sidebotham a écrit : The replacement adds the suffix Sheet, but not the sheet name. I think it would be good to keep the sheet name. So perhaps something along the lines of "filename/sheetname (/path/to/filename)" Best Regards, Brian. In complex hierachies, the sheet name is very important, because many sheets share the same file, and the same filename. JP Charras ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Show in eeschema window title full/short path to open file -- patch
On Wed, Jul 21, 2010 at 10:22:31AM +0100, Brian Sidebotham wrote:
> The replacement adds the suffix Sheet, but not the sheet name. I think
> it would be good to keep the sheet name. So perhaps something along
> the lines of "filename/sheetname (/path/to/filename)"
Done. But with little change:
[filename sheetname] (/path/to/filedir)
I use " " (space) between file name and sheet name instead of
"/". Reason is sheetname begin from "/" and in this way we get
not nice header "filename// or filename//sheetname".
Patch in attachment.
Regards,
--
Yury Khalyavin
=== modified file eeschema/eeredraw.cpp
--- eeschema/eeredraw.cpp 2010-03-18 20:35:29 +
+++ eeschema/eeredraw.cpp 2010-07-21 10:01:35 +
@@ -76,9 +76,15 @@
}
else
{
+/**
+ * Window title format:
+ * [filename sheetname] (/path/to/filedir)
+ */
+wxFileName t(GetScreen()->m_FileName);
title = wxT( "[" );
-title << GetScreen()->m_FileName << wxT( "] " ) << _( "Sheet" );
-title << wxT( " " ) << m_CurrentSheet->PathHumanReadable();
+title << t.GetName() << wxT( " " );
+title << m_CurrentSheet->PathHumanReadable() << wxT( "] " );
+title << wxT( "(" ) << t.GetPath() << wxT( ")" );
SetTitle( title );
}
}
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Show in eeschema window title full/short path to open file -- patch
On 07/21/2010 12:48 AM, Yury Khalyavin wrote:
> On Tue, Jul 20, 2010 at 12:37:29PM -0500, Dick Hollenbeck wrote:
>> I DO like the concept of a title which shows the filename up near the
>> front, before a long path.
>>
>> I think:
>>
>> 1) we should be able to agree on a standard format and not go through
>> the trouble having this be a configuration option.
> Yes, I agree. But I think show full path to opened file is not
> best solution.
Summary:
** I do not like the configuration option. We need to agree on one solution.
Please
orchestrate this discussion directly with Jean Pierre.
If you can make a proposal that thoroughly understands the notion of the sheet
path
(which is not a filename path) and puts things in the order of your importance,
you
have a fighting chance of getting a patch like this put in. But the final patch
should be not more than about 3 changed lines of code.
>
> May be do like vim: filename (path/to/filename-dir) ?
>>
>> 2) that your version of wxformbuilder is fairly old.
> Hm, I think I download new version :) My version is 3.0.57 --
> downloaded several days ago.
-// C++ code generated with wxFormBuilder (version Dec 21 2009)
+// C++ code generated with wxFormBuilder (version Apr 17 2008)
Then cay you say why your patch is showing Apr 17 2008?
And why your fbp file has removed the field validators, which also suggests
that it is
old. I am concerned about future patches, not this one, which as I said should
be
only about 3 lines long.
>>
>> 3) that the patch is showing lines of
>>
>> --- pcbnew/dialog_display_options_base.cpp 2010-03-01 11:25:08 +
>> +++ pcbnew/dialog_display_options_base.cpp 2010-07-13 12:53:39 +
>> @@ -12,139 +12,139 @@
>> DialogDisplayOptions_base::DialogDisplayOptions_base( wxWindow* parent,
>> wxWindowID id, const wxString& title, const wxPoint& pos, const wxSize&
>> size, long style ) : wxDialog( parent, id, title, pos, size, style )
>> {
>> this->SetSizeHints( wxDefaultSize, wxDefaultSize );
>> -
>> +
>> wxBoxSizer* bMainSizer;
>> bMainSizer = new wxBoxSizer( wxHORIZONTAL );
>> -
>> +
>>
>>
>> What are the -+ lines about?
> I think it removed spaces at new lines. I use vim, and configure
> it -- when I save file, vim before saving remove all useless
> spaces at the end of the strings.
Well done, I wanted to be sure the problem was in the old source, not the new.
Thanks
for tracking this down.
Dick
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Add hotkey shortcut 'Q' for "Add a no connected flag" action -- eeschema patch
On 07/21/2010 01:00 AM, Yury Khalyavin wrote: > Have a good day, > > After I done work on my scheme I`ll need mark pins without > connects, but not forund hotkey for it. This patch add hotkey > shortcut 'Q' for "Add a no connected flag" action. > > I think in near future we need to do special window for every > kicad application, where user can define hotkey for every > function -- like kde4 system settings -> keyboard -> hotkeys. > > What do you think about? > > Regards, > -- > Yury Khalyavin No objections here, I would commit it if others do not object. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] BZR for Developers
On 7/20/2010 4:05 PM, Dick Hollenbeck wrote: > On 07/12/2010 03:34 PM, Wayne Stambaugh wrote: >> On 7/12/2010 3:33 PM, Dick Hollenbeck wrote: >> >>> On 07/12/2010 01:46 PM, Wayne Stambaugh wrote: >>> On 7/12/2010 1:14 PM, Dick Hollenbeck wrote: > This page is the best I have found so far for regular developers: > > http://www.emacswiki.org/emacs/BzrForEmacsDevs > > It gives the information that is needed for a developer, someone who > contributes code. > > It is not particularly launchpad.net centric, and I am thinking about > reworking it to match our situation. Do people think this would be > helpful? > > I think it would be very useful. I particularly liked the section on creating a two way mirror. >>> >>> That might not be as magic as it seems. Could be a consequence of the >>> way they checked out the branch. I'd dig deeper into that. >>> >> I believe you're correct about this. Using bzr checkout would have likely >> preserved the link back to the main launchpad branch. >> > > http://doc.bazaar.canonical.com/latest/en/user-reference/configuration-help.html > > Learning more, I see from above that: > > *public_branch* is used only by "bzr send", so this would get set the > first time you use bzr send if you don't echo it into the > .bzr/branch/branch.conf file as shown. > > > *bound_location* is the link back to the branch that a checkout was > taken from. > > > Doing the echo only saves you a one time prompt on your first usage of > "bzr send". Thanks for taking the time to do the research on this. Wayne > > Dick > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Show exists hotkeys in eeschema menubar ("Place menu") -- patch
On 07/21/2010 01:07 AM, Yury Khalyavin wrote: > For easier remember hotkeys and know about new hotkey, I think > hotkey shortcut must be show in menus -- like "Open Ctrl-O". > > Regards, > -- > Yury Khalyavin Nice. I like the way you keep the actual mapping of the "key to the action" in only one place. The functionality is useful. I would commit it if there are no objections. Dick ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Graphics Abstraction Layer for KiCad
On a Qt related note. I don't know if anyone noticed, but there have been a bunch of wxQt commits to wxWidgets trunk over the past few weeks. I don't know how usable it will be for the first few releases but it looks like it will eventually be part of wxWidgets at some point in the future. Wayne On 7/20/2010 4:53 PM, Vesa Solonen wrote: > Stuff that may be interesting or not... > http://labs.trolltech.com/blogs/2010/05/18/a-qt-scenegraph/ > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Add close shortcut to Library Editor -- patch
On 07/21/2010 01:11 AM, Yury Khalyavin wrote:
> === modified file eeschema/libeditframe.cpp
> --- eeschema/libeditframe.cpp 2010-03-20 19:57:59 +
> +++ eeschema/libeditframe.cpp 2010-07-21 05:36:11 +
> @@ -116,6 +116,8 @@
> WinEDA_LibeditFrame::Process_Special_Functions )
>
> /* menubar commands */
> +EVT_MENU( wxID_EXIT,
> + WinEDA_LibeditFrame::CloseWindow )
> EVT_MENU( ID_LIBEDIT_SAVE_CURRENT_LIB_AS,
>WinEDA_LibeditFrame::SaveActiveLibrary )
> EVT_MENU( ID_LIBEDIT_GEN_PNG_FILE,
> @@ -307,6 +309,15 @@
>
>
> /**
> + * Call close event, which process by EVT_CLOSE
> + */
This comment should go in the header file, not in the C++ file, for the benefit
of
"one place of comment maintenance" and for access by doxygen. Doxygen
is configured to pick from the header file the function comments, as a higher
priority
than from the C++ file.
/**
* Function CloseWindow
* will close the window.
*/
Doxygen puts the above text in a single sentence which reads well.
"Function CloseWindow will close the window."
> +void WinEDA_LibeditFrame::CloseWindow( wxCommandEvent& WXUNUSED(event) )
> +{
> +Close();
> +}
> +
> +
> +/**
> * Save library editor frame specific configuration settings.
> *
> * Don't forget to call this base method from any derived classes or the
>
> === modified file eeschema/libeditframe.h
> --- eeschema/libeditframe.h 2010-03-28 14:46:49 +
> +++ eeschema/libeditframe.h 2010-07-21 05:36:11 +
> @@ -84,6 +84,7 @@
> void DisplayLibInfos();
> void RedrawActiveWindow( wxDC* DC, bool EraseBg );
> void OnCloseWindow( wxCloseEvent& Event );
> +void CloseWindow( wxCommandEvent& WXUNUSED(event) );
> void ReCreateHToolbar();
> void ReCreateVToolbar();
> void OnLeftClick( wxDC* DC, const wxPoint& MousePos );
>
> === modified file eeschema/menubar_libedit.cpp
> --- eeschema/menubar_libedit.cpp 2010-06-30 11:15:34 +
> +++ eeschema/menubar_libedit.cpp 2010-07-21 05:36:11 +
> @@ -68,6 +68,16 @@
> item->SetBitmap( plot_xpm );
> filesMenu->Append( item );
>
> +/* Quit on all platforms except WXMAC */
Please say why not a MAC, and use C++ comments for single line ones.
> +#if !defined(__WXMAC__)
> +
> +filesMenu->AppendSeparator();
> +item = new wxMenuItem( filesMenu, wxID_EXIT, _( "&Quit" ),
> + _( "Quit Library Editor" ) );
> +filesMenu->Append( item );
> +
> +#endif /* !defined( __WXMAC__) */
> +
> /**
> * Edit menu
> */
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] pcbnew module editor toolbar items now in menubar -- patch
On 07/21/2010 02:52 AM, Jerry Jacobs wrote: > Because almost all toolbar items are not in the menubar of the module > editor I wrote a small patch. > Maybe someone can take care of the few TODO's inside the patch which I > was not able to get. > > The File -> Close needs a ID handler and need's to be fixed. > And maybe some entries should not be selectable in some cases like > undo,redo and the placement of components if there is no module > loaded or new module created. > > Maybe all the *modedit* files can better be moved to a subdirectory if > the code will be growing. > And also moving the dialog_* files. Because we get > already a nice amount of files and directories are handy to sort things up. > > See the attached patch, it applies to rev 2418 without problems. For future patch attachments, can you keep your email client from base64 encoding these attachments? Thanks. This way we can see the patch without saving it to disk first. No need to resend this one, just tweak your settings please, if you can. The email content includes: === Kind Regards, Met vriendelijke groet, Jerry Jacobs - http://www.xor-gate.org --00151750e3b8a1e816048be1142d Content-Type: application/octet-stream; name="pcbnew_module_editor_extended_menubar.patch" Content-Disposition: attachment; filename="pcbnew_module_editor_extended_menubar.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gbvvjf330 PT09IG1vZGlmaWVkIGZpbGUgJ3BjYm5ldy9tZW51YmFyX21vZGVkaXQuY3BwJwotLS0gcGNibmV3 L21lbnViYXJfbW9kZWRpdC5jcHAJMjAxMC0wNC0yMCAxMToyMzo1OSArMDAwMAorKysgcGNibmV3 : : --00151750e3b8a1e816048be1142d Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Add close shortcut to Library Editor -- patch
> This comment should go in the header file, not in the C++ file, for the > benefit of > "one place of comment maintenance" and for access by doxygen. Doxygen > is configured to pick from the header file the function comments, as a higher > priority > than from the C++ file. > > > /** > * Function CloseWindow > * will close the window. > */ > > Doxygen puts the above text in a single sentence which reads well. > > "Function CloseWindow will close the window." For derived classes, where a virtual function is overloaded, the function comments are inherited by doxygen unless present and modified. This can save typing, and suggests that sometimes "reading the doxygen output can be more informative than reading the source code." Seems reasonable to assume that, else why doxygen? ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] pcbnew module editor toolbar items now in menubar -- patch
On 7/21/2010 3:52 AM, Jerry Jacobs wrote: > Because almost all toolbar items are not in the menubar of the module > editor I wrote a small patch. > Maybe someone can take care of the few TODO's inside the patch which I > was not able to get. Jerry, Most of your TODO's suggest creating new IDs for the module editor instead of reusing the IDs from PCBNew. Is there any technical reason to do this? As long as the ID is descriptive enough than I see no reason to create another ID specifically for the module editor. We already reuse wxID_CUT, wxID_COPY, wxID_PASTE, etc. I did some ID rationalization a while back that significantly reduced the number of redundant IDs and unnecessary recompiling. I would rather avoid adding new IDs unless there is a good reason to do so. > > The File -> Close needs a ID handler and need's to be fixed. > And maybe some entries should not be selectable in some cases like > undo,redo and the placement of components if there is no module > loaded or new module created. > > Maybe all the *modedit* files can better be moved to a subdirectory if > the code will be growing. > And also moving the dialog_* files. Because we get > already a nice amount of files and directories are handy to sort things up. This is good idea for the eeschema subdirectory as well as it is getting rather unwieldy. > > See the attached patch, it applies to rev 2418 without problems. Your patch has some code formatting issues. There are some indenting alignment problems. +item = new wxMenuItem( openSubmenu, +ID_MODEDIT_IMPORT_PART, +_( "from File" ), +_( "Import a footprint module from a existing file" ) ); should be +item = new wxMenuItem( openSubmenu, + ID_MODEDIT_IMPORT_PART, + _( "from File" ), + _( "Import a footprint module from a existing file" ) ); There is also some trailing white space as well. If your editor supports showing white space, you may want to turn it on. Uncrustify will also remove any trailing white space. Thanks, Wayne > > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] pcbnew module editor toolbar items now in menubar -- patch
> Maybe all the *modedit* files can better be moved to a subdirectory if the > code > will be growing. And also moving the dialog_* files. Because we get already > a nice > amount of files and directories are handy to sort things up. On this subject consider my vote to be weak one. But I am not in favor of adding directories at this time, and I would gladly defer this decision to the person currently making the most changes, since that person is the one most affected by it. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] feedback on launchpad
Are people happy with launchpad? 10 = extremely happy : : 1 = extremely dissatisfied ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] feedback on launchpad
On Wed, Jul 21, 2010 at 11:31 PM, Dick Hollenbeck wrote: > Are people happy with launchpad? > > 10 = extremely happy > : > : > 1 = extremely dissatisfied I think you mean in the context of the KiCad project hosted and maintained on launchpad system? For me i'm more happy and see more progress and better management than on the services sourceforge can give us. Only i'm not to happy with bzr for revision control and as a personal matter of taste I prefer Git. I give it a 8 = very happy. Keep it up guys, We are moving forward. (sorry Dick I need to reply to all instead of only to the one who put it on the mailinglist :-) ) ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Graphics Abstraction Layer for KiCad
"Torsten H?ter" wrote: > AFAIK the Radeon 200 is based on the X300 Mobility; which is older than > 5 years. It's true that there could be a better support for Linux, but > the newer products have a good OpenGL support - both ATI and NVIDIA > offer drivers, which have the same code base like their Windows variants. So is the idea that future versions of KiCad will require the installation of closed source drivers to be usable ? - Werner ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] feedback on launchpad
On Wed, 21 Jul 2010, Dick Hollenbeck wrote: Are people happy with launchpad? 10 = extremely happy : : 1 = extremely dissatisfied I'd give a 6, nothing particularly different from sourceforge or tracs, at the end... (while brz IMHO isn't really handy...) -- Lorenzo Marcantonio Logos Srl ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Graphics Abstraction Layer for KiCad
On Wed, 21 Jul 2010, Werner Almesberger wrote: So is the idea that future versions of KiCad will require the installation of closed source drivers to be usable ? That's what I'm fearing... -- Lorenzo Marcantonio Logos Srl ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
