[Kicad-developers] kicad-stable vs wxWidgets 3.x
I am wondering if the attached patch could be applied to the stable
branch. The reason is currently it does not compile with wxWidgets 3.x
at all or wxWidgets 2.x that are built without '--with-gnomeprint' or
'--with-gtkprint'. There are no wonders inside, just a few backported
changes from the product branch.
Regards,
Orson
=== modified file 'common/basicframe.cpp'
--- old/common/basicframe.cpp 2013-01-12 18:32:24.908999000 +0100
+++ new/common/basicframe.cpp 2014-02-10 08:59:50.362256003 +0100
@@ -458,8 +458,18 @@ void EDA_BASE_FRAME::AddHelpVersionInfoM
static inline const char* KICAD_BUILD_OPTIONS_SIGNATURE()
{
return
-" (" __WX_BO_UNICODE __ABI_VERSION __BO_COMPILER __WX_BO_STL
-__WX_BO_WXWIN_COMPAT_2_6 __WX_BO_WXWIN_COMPAT_2_8 ")"
+#ifdef __WXDEBUG__
+" (debug,"
+#else
+" (release,"
+#endif
+__WX_BO_UNICODE __ABI_VERSION __BO_COMPILER __WX_BO_STL
+
+#if !wxCHECK_VERSION( 3, 0, 0 )
+__WX_BO_WXWIN_COMPAT_2_6
+#endif
+
+__WX_BO_WXWIN_COMPAT_2_8 ")"
;
}
@@ -468,7 +478,11 @@ static inline const char* KICAD_BUILD_OP
static inline const char* KICAD_BUILD_OPTIONS_SIGNATURE()
{
return
-" (" __WX_BO_DEBUG ","
+#ifdef __WXDEBUG__
+" (debug,"
+#else
+" (release,"
+#endif
__WX_BO_UNICODE __ABI_VERSION __BO_COMPILER __WX_BO_STL
__WX_BO_WXWIN_COMPAT_2_4 __WX_BO_WXWIN_COMPAT_2_6 ")"
;
=== modified file 'common/common.cpp'
--- old/common/common.cpp 2013-03-30 13:54:49.36700 +0100
+++ new/common/common.cpp 2014-02-10 08:48:11.698929316 +0100
@@ -40,6 +40,16 @@
#include
+// Show warning if wxWidgets Gnome or GTK printing was not configured.
+// Since wxWidgets 3.0, this is no more needed (build in printing works!)
+#if defined( __WXGTK__ )
+#if !wxCHECK_VERSION( 3, 0, 0 )
+# if !wxUSE_LIBGNOMEPRINT && !wxUSE_GTKPRINT && !SWIG
+# warning "You must use '--with-gnomeprint' or '--with-gtkprint' in your wx library configuration for full print capabilities."
+# endif
+#endif
+#endif
+
/**
* Global variables definitions.
*
=== modified file 'common/edaappl.cpp'
--- old/common/edaappl.cpp 2013-01-30 17:15:45.08200 +0100
+++ new/common/edaappl.cpp 2014-02-10 08:30:18.555606190 +0100
@@ -451,7 +451,7 @@ bool EDA_APP::SetBinDir()
// Linux and Unix
#elif defined(__UNIX__)
-m_BinDir = wxStandardPaths().GetExecutablePath();
+m_BinDir = wxStandardPaths::Get().GetExecutablePath();
#else
m_BinDir = argv[0];
#endif // __UNIX__
=== modified file 'include/common.h'
--- old/include/common.h 2013-03-30 13:54:49.36700 +0100
+++ new/include/common.h 2014-02-10 08:48:03.118929397 +0100
@@ -42,16 +42,6 @@
#include
#include
-#if !wxUSE_PRINTING_ARCHITECTURE && !SWIG
-# error "You must use '--enable-printarch' in your wx library configuration."
-#endif
-
-#if defined( __WXGTK__ )
-# if !wxUSE_LIBGNOMEPRINT && !wxUSE_GTKPRINT && !SWIG
-# error "You must use '--with-gnomeprint' or '--with-gtkprint' in your wx library configuration."
-# endif
-#endif
-
class wxAboutDialogInfo;
=== modified file 'pcbnew/footprint_wizard_frame.cpp'
--- old/pcbnew/footprint_wizard_frame.cpp 2013-01-12 18:32:24.908999000 +0100
+++ new/pcbnew/footprint_wizard_frame.cpp 2014-02-10 08:37:33.975602049 +0100
@@ -77,9 +77,19 @@ BEGIN_EVENT_TABLE( FOOTPRINT_WIZARD_FRAM
EVT_TOOL( ID_FOOTPRINT_WIZARD_SHOW_3D_VIEW,
FOOTPRINT_WIZARD_FRAME::Show3D_Frame )
-/* listbox events */
+// listbox events
EVT_LISTBOX( ID_FOOTPRINT_WIZARD_PAGE_LIST, FOOTPRINT_WIZARD_FRAME::ClickOnPageList )
-EVT_GRID_CMD_CELL_CHANGE( ID_FOOTPRINT_WIZARD_PARAMETER_LIST, FOOTPRINT_WIZARD_FRAME::ParametersUpdated )
+
+#if wxCHECK_VERSION( 3, 0, 0 )
+EVT_GRID_CMD_CELL_CHANGED( ID_FOOTPRINT_WIZARD_PARAMETER_LIST,
+ FOOTPRINT_WIZARD_FRAME::ParametersUpdated )
+#else
+EVT_GRID_CMD_CELL_CHANGE( ID_FOOTPRINT_WIZARD_PARAMETER_LIST,
+ FOOTPRINT_WIZARD_FRAME::ParametersUpdated )
+#endif
+
+EVT_GRID_CMD_EDITOR_HIDDEN( ID_FOOTPRINT_WIZARD_PARAMETER_LIST,
+FOOTPRINT_WIZARD_FRAME::ParametersUpdated )
EVT_MENU( ID_SET_RELATIVE_OFFSET, FOOTPRINT_WIZARD_FRAME::OnSetRelativeOffset )
END_EVENT_TABLE()
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [path] very few icons reviewed
Le 10/02/2014 23:34, Fabrizio Tappero a écrit : > Hello Guys, > following up on the recent big icon update, I am sending here very few > icons, just a little improved, nothing major. I tried to include the > suggestions sent me by few of you. > > JP, I update the camera icons to bitmap2component icon. If you like me > to change it let me know, I am sending here this new one because it > seems to me that the one you make looks a little similar to the Cvpcb > one, but not a big deal. > > Miguel, the icon py_script is really waiting for the great python > scripting feature. no pressure... > > If there is any improvement that you like to see let me know, I'd be > happy to try to > Thank you > Fabrizio I committed your new icons, but bitmap2component icon (waiting for enhancements) Thanks. -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Fix typo in include guard
Le 11/02/2014 00:13, Sean Silva a écrit : > Hi, first time posting. Trivial patch attached fixing a header guard. > > Clang's -Wheader-guard warning caught this. > > > I apologize for the git-format-patch style patch (might need to pass > `-p1`). I spent about an hour or two trying to find a workable workflow > with bzr but wasn't able to find one. Skimming the archives it seems > like there is discussion about moving to git from bzr; hopefully this > can provide a data point for the discussion (I'd be glad to provide more > info it you're interested about what the main things I ran up against > were, how far I got working with bzr, etc.). > > -- Sean Silva No problem for the git-format-patch style. I committed you fix in the last commit. Thanks. -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] KiCad components library
Hi, I would like to install the KiCad components library but I can't. cd ~/build/kicad bzr checkout lp:~kicad-lib-committers/kicad/library kicad-library.bzr bzr: ERROR: Not a branch: "bzr+ssh://bazaar.launchpad.net/~kicad-lib-committers/kicad/library/" -- Alberto Medrano Telf: +58 416 681 3010 ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] KiCad components library
If you are using snapshots or your own builds of the product branch use: bzr checkout lp:~kicad-product-committers/kicad/library If you are using the stable branch use: bzr checkout lp:~dickelbeck/kicad/library-read-only On 2/11/2014 2:17 PM, Alberto Medrano (Gmail) wrote: > Hi, > > I would like to install the KiCad components library but I can't. > > cd ~/build/kicad > bzr checkout lp:~kicad-lib-committers/kicad/library kicad-library.bzr > > bzr: ERROR: Not a branch: > "bzr+ssh://bazaar.launchpad.net/~kicad-lib-committers/kicad/library/" > > -- > Alberto Medrano > Telf: +58 416 681 3010 > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] kicad-stable vs wxWidgets 3.x
Le 11/02/2014 17:58, Maciej Sumiński a écrit : > I am wondering if the attached patch could be applied to the stable > branch. The reason is currently it does not compile with wxWidgets 3.x > at all or wxWidgets 2.x that are built without '--with-gnomeprint' or > '--with-gtkprint'. There are no wonders inside, just a few backported > changes from the product branch. > > Regards, > Orson I committed you fix. Thanks. -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [path] very few icons reviewed
Hi JP, thank you for your help. I will think about it but I have to be honest sometimes with icons it is not really necessary to try to pack all the information that the software can do. In this case we are talking about a software to import images so I guess a camera would already express that. I think in this case it is more important to maintain a coherence between icons, with the current icon we are facing the problem that there are two similar icons. Nevertheless I will think about a cool icon. Regards Fabrizio On Tue, Feb 11, 2014 at 7:34 PM, jp charras wrote: > Le 10/02/2014 23:34, Fabrizio Tappero a écrit : > > Hello Guys, > > following up on the recent big icon update, I am sending here very few > > icons, just a little improved, nothing major. I tried to include the > > suggestions sent me by few of you. > > > > JP, I update the camera icons to bitmap2component icon. If you like me > > to change it let me know, I am sending here this new one because it > > seems to me that the one you make looks a little similar to the Cvpcb > > one, but not a big deal. > > > > Miguel, the icon py_script is really waiting for the great python > > scripting feature. no pressure... > > > > If there is any improvement that you like to see let me know, I'd be > > happy to try to > > Thank you > > Fabrizio > > I committed your new icons, but bitmap2component icon (waiting for > enhancements) > > Thanks. > > -- > Jean-Pierre CHARRAS > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] library problem in Cvpcb
Hi,
not really sure why but doing a fresh download and install procedure using
the proper linux install script, opening Pcbnew and looking at its libs I
get the following error:
Errors were encountered loading footprints
IO_ERROR: Unable to parse URL:
'${KIGITHUB}/Diodes_ThroughHole.pretty'
from /home/fabrizio/kicad_sources/kicad.bzr/pcbnew/github/github_plugin.cpp
: remote_get_zip() : line 507
IO_ERROR: Unable to parse URL:
'${KIGITHUB}/Discret.pretty'
from /home/fabrizio/kicad_sources/kicad.bzr/pcbnew/github/github_plugin.cpp
: remote_get_zip() : line 507
.
Steps:
- open pcbnew
- open module editor
- load module from library
- List All
seem strange that it is point at ~/kicad_sources
any suggestion?
regards
Fabrizio
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Moving field-texts with connecting line to component; potential patch
Hi Henner, Committed in BZR4686. Thanks again for your contribution. Best Regards, Brian. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] library problem in Cvpcb
The KIGITHUB environment variable is probably not set in the env you are
running pcbnew in. i.e. if you just installed on a clean system you have to
log out and in as the script states.
echo "Please logout and back in after this script completes for environment"
echo "variable to get set into environment."
2014-02-11 21:32 GMT+01:00 Fabrizio Tappero :
> Hi,
> not really sure why but doing a fresh download and install procedure using
> the proper linux install script, opening Pcbnew and looking at its libs I
> get the following error:
>
> Errors were encountered loading footprints
> IO_ERROR: Unable to parse URL:
> '${KIGITHUB}/Diodes_ThroughHole.pretty'
> from
> /home/fabrizio/kicad_sources/kicad.bzr/pcbnew/github/github_plugin.cpp :
> remote_get_zip() : line 507
> IO_ERROR: Unable to parse URL:
> '${KIGITHUB}/Discret.pretty'
> from
> /home/fabrizio/kicad_sources/kicad.bzr/pcbnew/github/github_plugin.cpp :
> remote_get_zip() : line 507
> .
>
> Steps:
> - open pcbnew
> - open module editor
> - load module from library
> - List All
>
> seem strange that it is point at ~/kicad_sources
>
> any suggestion?
>
> regards
> Fabrizio
>
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
[Kicad-developers] [PATCH] Fix wrong numbering in the QFP footprint wizard
Hello I was just playing around with the python scripts for the module editor and found that the pin numbering was wrong. QFP chips is always numbered in incrementing fashion on one circular direction. Attached is a patch. It basically adds some more coordinate swapping on the bottom and top, as is done for the left and right. In addition, I think that the default shape of the pads should be rectangular, that is "*oval": "False". I have never seen a datasheet suggesting oval pads for a QFP. I did not add that to the patch since that was not the problem I wanted to fix and it can be selected by the user anyway. If I am mistaken please let me know -- otherwise commit.. :) Regards Nick Østergaard === modified file 'pcbnew/scripting/plugins/qfp_wizard.py' --- pcbnew/scripting/plugins/qfp_wizard.py 2013-11-01 15:29:50 + +++ pcbnew/scripting/plugins/qfp_wizard.py 2014-02-11 22:03:06 + @@ -109,18 +109,22 @@ pad_size = pad_size_left_right pad_pos_x = -(pad_horizontal_pitch / 2) +pad_pos_y = (cur_pad % (num_pads / 4)) * pad_pitch - (side_length / 2) + if side == 2: pad_pos_x = -pad_pos_x +pad_pos_y = -pad_pos_y -pad_pos_y = (cur_pad % (num_pads / 4)) * pad_pitch - (side_length / 2) else: pad_size = pad_size_bottom_top pad_pos_x = (cur_pad % (num_pads / 4)) * pad_pitch - (side_length / 2) - pad_pos_y = -(pad_vertical_pitch / 2) + if side == 1: pad_pos_y = -pad_pos_y +else: +pad_pos_x = -pad_pos_x pad_pos = pcbnew.wxPoint(pad_pos_x, pad_pos_y) ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] library problem in Cvpcb
Hi Nick,
the problem seems to be more complicated. It looks like the kicad install
script has done its work ( correct /etc/profile.d/kicad.sh) but log out and
in does not solve the problem.
In the last Debian, starting the terminal does not start a bash shell. So
not kicad env variables get loaded. starting kicad from the top menu has
the same problem.
If I do bash --login in the terminal it does load all variables.
Any idea on how to fix this problem? Am I the only one with this problem?
Regards
Fabrizio
On Tue, Feb 11, 2014 at 11:13 PM, Nick Østergaard wrote:
> The KIGITHUB environment variable is probably not set in the env you are
> running pcbnew in. i.e. if you just installed on a clean system you have to
> log out and in as the script states.
>
> echo "Please logout and back in after this script completes for
> environment"
> echo "variable to get set into environment."
>
>
> 2014-02-11 21:32 GMT+01:00 Fabrizio Tappero :
>
>> Hi,
>> not really sure why but doing a fresh download and install procedure
>> using the proper linux install script, opening Pcbnew and looking at its
>> libs I get the following error:
>>
>> Errors were encountered loading footprints
>> IO_ERROR: Unable to parse URL:
>> '${KIGITHUB}/Diodes_ThroughHole.pretty'
>> from
>> /home/fabrizio/kicad_sources/kicad.bzr/pcbnew/github/github_plugin.cpp :
>> remote_get_zip() : line 507
>> IO_ERROR: Unable to parse URL:
>> '${KIGITHUB}/Discret.pretty'
>> from
>> /home/fabrizio/kicad_sources/kicad.bzr/pcbnew/github/github_plugin.cpp :
>> remote_get_zip() : line 507
>> .
>>
>> Steps:
>> - open pcbnew
>> - open module editor
>> - load module from library
>> - List All
>>
>> seem strange that it is point at ~/kicad_sources
>>
>> any suggestion?
>>
>> regards
>> Fabrizio
>>
>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help : https://help.launchpad.net/ListHelp
>>
>>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [path] very few icons reviewed
IMHO the old icon with the camera was not bad at all, but this "a" is very easy to distinguish from from the others which can also be an advantage. Regarding the py_script, I wonder why not simply use the python logo, maybe with the shell icon in the background as [1]. [1] http://www.linuxcandy.com/wp-content/uploads/2012/07/python-icon.jpg 2014-02-12 0:23 GMT+01:00 Fabrizio Tappero : > Hi JP, > I am very tempted to make an icon that simply tells what the app does > without really explaining that the output can be used for schematics as > well as pcb see attachment if you like. I kind of do. > > Fab. > > > > On Tue, Feb 11, 2014 at 8:56 PM, Fabrizio Tappero < > fabrizio.tapp...@gmail.com> wrote: > >> Hi JP, >> thank you for your help. I will think about it but I have to be honest >> sometimes with icons it is not really necessary to try to pack all the >> information that the software can do. In this case we are talking about a >> software to import images so I guess a camera would already express that. I >> think in this case it is more important to maintain a coherence between >> icons, with the current icon we are facing the problem that there are two >> similar icons. >> >> Nevertheless I will think about a cool icon. >> Regards >> Fabrizio >> >> >> >> On Tue, Feb 11, 2014 at 7:34 PM, jp charras wrote: >> >>> Le 10/02/2014 23:34, Fabrizio Tappero a écrit : >>> > Hello Guys, >>> > following up on the recent big icon update, I am sending here very few >>> > icons, just a little improved, nothing major. I tried to include the >>> > suggestions sent me by few of you. >>> > >>> > JP, I update the camera icons to bitmap2component icon. If you like me >>> > to change it let me know, I am sending here this new one because it >>> > seems to me that the one you make looks a little similar to the Cvpcb >>> > one, but not a big deal. >>> > >>> > Miguel, the icon py_script is really waiting for the great python >>> > scripting feature. no pressure... >>> > >>> > If there is any improvement that you like to see let me know, I'd be >>> > happy to try to >>> > Thank you >>> > Fabrizio >>> >>> I committed your new icons, but bitmap2component icon (waiting for >>> enhancements) >>> >>> Thanks. >>> >>> -- >>> Jean-Pierre CHARRAS >>> >> >> > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [path] very few icons reviewed
True, in fact I think it is important to have distinctive icons but all kind of homogeneous. Reusing elements of other icons (done for some) is not such a great idea. coping a whole already present icon and add a camera is maybe not such a good idea. it is a 26px by 26 pixel icon, you cant really fit much stuff in it. Current script icon is a terminal that suggest a scripting. Is it really necessary to tell that it is a python scripting? cheers Fabrizio On Wed, Feb 12, 2014 at 12:45 AM, Nick Østergaard wrote: > IMHO the old icon with the camera was not bad at all, but this "a" is very > easy to distinguish from from the others which can also be an advantage. > > Regarding the py_script, I wonder why not simply use the python logo, > maybe with the shell icon in the background as [1]. > > [1] http://www.linuxcandy.com/wp-content/uploads/2012/07/python-icon.jpg > > > 2014-02-12 0:23 GMT+01:00 Fabrizio Tappero : > >> Hi JP, >> I am very tempted to make an icon that simply tells what the app does >> without really explaining that the output can be used for schematics as >> well as pcb see attachment if you like. I kind of do. >> >> Fab. >> >> >> >> On Tue, Feb 11, 2014 at 8:56 PM, Fabrizio Tappero < >> fabrizio.tapp...@gmail.com> wrote: >> >>> Hi JP, >>> thank you for your help. I will think about it but I have to be honest >>> sometimes with icons it is not really necessary to try to pack all the >>> information that the software can do. In this case we are talking about a >>> software to import images so I guess a camera would already express that. I >>> think in this case it is more important to maintain a coherence between >>> icons, with the current icon we are facing the problem that there are two >>> similar icons. >>> >>> Nevertheless I will think about a cool icon. >>> Regards >>> Fabrizio >>> >>> >>> >>> On Tue, Feb 11, 2014 at 7:34 PM, jp charras wrote: >>> Le 10/02/2014 23:34, Fabrizio Tappero a écrit : > Hello Guys, > following up on the recent big icon update, I am sending here very few > icons, just a little improved, nothing major. I tried to include the > suggestions sent me by few of you. > > JP, I update the camera icons to bitmap2component icon. If you like me > to change it let me know, I am sending here this new one because it > seems to me that the one you make looks a little similar to the Cvpcb > one, but not a big deal. > > Miguel, the icon py_script is really waiting for the great python > scripting feature. no pressure... > > If there is any improvement that you like to see let me know, I'd be > happy to try to > Thank you > Fabrizio I committed your new icons, but bitmap2component icon (waiting for enhancements) Thanks. -- Jean-Pierre CHARRAS >>> >>> >> >> ___ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> >> > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Fix typo in include guard
On Tue, Feb 11, 2014 at 1:37 PM, jp charras wrote: > Le 11/02/2014 00:13, Sean Silva a écrit : > > Hi, first time posting. Trivial patch attached fixing a header guard. > > > > Clang's -Wheader-guard warning caught this. > > > > > > I apologize for the git-format-patch style patch (might need to pass > > `-p1`). I spent about an hour or two trying to find a workable workflow > > with bzr but wasn't able to find one. Skimming the archives it seems > > like there is discussion about moving to git from bzr; hopefully this > > can provide a data point for the discussion (I'd be glad to provide more > > info it you're interested about what the main things I ran up against > > were, how far I got working with bzr, etc.). > > > > -- Sean Silva > > No problem for the git-format-patch style. > I committed you fix in the last commit. > Thanks. -- Sean Silva > > Thanks. > > -- > Jean-Pierre CHARRAS > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [path] very few icons reviewed
Distinctive icons might indeed be better than more-accurate-store-telling-icons, which should influence the choice. It is not nessesary to tell that, but since it brings up the interpreter one might argue that the terminal shell icon is better. It was just a comment. 2014-02-12 0:51 GMT+01:00 Fabrizio Tappero : > True, in fact I think it is important to have distinctive icons but all > kind of homogeneous. Reusing elements of other icons (done for some) is not > such a great idea. coping a whole already present icon and add a camera is > maybe not such a good idea. > > it is a 26px by 26 pixel icon, you cant really fit much stuff in it. > Current script icon is a terminal that suggest a scripting. Is it really > necessary to tell that it is a python scripting? > > cheers > Fabrizio > > > On Wed, Feb 12, 2014 at 12:45 AM, Nick Østergaard wrote: > >> IMHO the old icon with the camera was not bad at all, but this "a" is >> very easy to distinguish from from the others which can also be an >> advantage. >> >> Regarding the py_script, I wonder why not simply use the python logo, >> maybe with the shell icon in the background as [1]. >> >> [1] http://www.linuxcandy.com/wp-content/uploads/2012/07/python-icon.jpg >> >> >> 2014-02-12 0:23 GMT+01:00 Fabrizio Tappero : >> >>> Hi JP, >>> I am very tempted to make an icon that simply tells what the app does >>> without really explaining that the output can be used for schematics as >>> well as pcb see attachment if you like. I kind of do. >>> >>> Fab. >>> >>> >>> >>> On Tue, Feb 11, 2014 at 8:56 PM, Fabrizio Tappero < >>> fabrizio.tapp...@gmail.com> wrote: >>> Hi JP, thank you for your help. I will think about it but I have to be honest sometimes with icons it is not really necessary to try to pack all the information that the software can do. In this case we are talking about a software to import images so I guess a camera would already express that. I think in this case it is more important to maintain a coherence between icons, with the current icon we are facing the problem that there are two similar icons. Nevertheless I will think about a cool icon. Regards Fabrizio On Tue, Feb 11, 2014 at 7:34 PM, jp charras wrote: > Le 10/02/2014 23:34, Fabrizio Tappero a écrit : > > Hello Guys, > > following up on the recent big icon update, I am sending here very > few > > icons, just a little improved, nothing major. I tried to include the > > suggestions sent me by few of you. > > > > JP, I update the camera icons to bitmap2component icon. If you like > me > > to change it let me know, I am sending here this new one because it > > seems to me that the one you make looks a little similar to the Cvpcb > > one, but not a big deal. > > > > Miguel, the icon py_script is really waiting for the great python > > scripting feature. no pressure... > > > > If there is any improvement that you like to see let me know, I'd be > > happy to try to > > Thank you > > Fabrizio > > I committed your new icons, but bitmap2component icon (waiting for > enhancements) > > Thanks. > > -- > Jean-Pierre CHARRAS > >>> >>> ___ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : kicad-developers@lists.launchpad.net >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> >>> >> > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Fix wrong numbering in the QFP footprint wizard
On Tue, Feb 11, 2014 at 11:40:29PM +0100, Nick Østergaard wrote: > In addition, I think that the default shape of the pads should be > rectangular, that is "*oval": "False". I have never seen a datasheet > suggesting oval pads for a QFP. I did not add that to the patch since that > was not the problem I wanted to fix and it can be selected by the user > anyway. There is a (somewhat involved) IPC rule defining if the pad should be rectangular or oval: in short if the pad have to be trimmed to keep side clearance or underfill it has to be rectangular, otherwise it should be oval (rationale: round corners have better mechanical properties, but if you trim you want to keep all the attachment surface available). So, more or less, if pitch is < 1 mm *or* standoff height (the A1 JEDEC dimension) is < 0,15 mm pads should be rectangular. In short every modern component has low standoff so it need to trim for underfill… However when/if IPC7351C become standard and widely applied there will be a resurgence of oval pads :D Even shorter explanation: if you don't do high reliability board, just use rectangular pads; otherwise that would be the SMALLER of your problems:D -- Lorenzo Marcantonio Logos Srl ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [path] very few icons reviewed
On Wed, Feb 12, 2014 at 08:30:01AM +0100, Nick Østergaard wrote: > Distinctive icons might indeed be better than > more-accurate-store-telling-icons, which should influence the choice. Talking of which... aren't actually open board and new board using the same icon? I'd expect new to use the 'blank sheet' like in eeschema (but anyway... is the new icon really needed on the toolbar? I *never* used the new function in my life :P) -- Lorenzo Marcantonio Logos Srl ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [path] very few icons reviewed
Le 12/02/2014 00:23, Fabrizio Tappero a écrit : > Hi JP, > I am very tempted to make an icon that simply tells what the app does > without really explaining that the output can be used for schematics as > well as pcb see attachment if you like. I kind of do. > > Fab. I like your new icon_bitmap2compoent. I committed this new one. Thanks. -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
