Re: [Kicad-developers] Stable release update.

2015-03-16 Thread Bernhard Stegmaier
Hi,

I don’t know how it fits together (I never get the direction of scripting 
right… outside of KiCad or inside), but…
if sys.platform.startswith('darwin'):
for singlepath in sys.path:
if os.path.isdir( os.path.join( singlepath, 'scripting', 'plugins') 
):
plugin_directories.append( os.path.join( singlepath, 
'scripting', 'plugins') )
shouldn’t this be the same/similar as set in pcbnew?
// User scripting folder (~/Library/Application 
Support/kicad/scripting/plugins)
pypath = GetOSXKicadUserDataDir() + wxT( "/scripting/plugins" );

// Machine scripting folder (/Library/Application 
Support/kicad/scripting/plugins)
pypath += wxT( ":" ) + GetOSXKicadMachineDataDir() + wxT( 
"/scripting/plugins" );

// Bundle scripting folder 
(/Contents/SharedSupport/scripting/plugins)
pypath += wxT( ":" ) + GetOSXKicadDataDir() + wxT( "/scripting/plugins" );
Instead of just using sys.path set somewhere else as base?


Regards,
Bernhard

> On 17 Mar 2015, at 07:12, Miguel Ángel Ajo  wrote:
> 
> Nice Adam!
> 
> I wonder what happens with the console, basically it fires up, but most 
> keystrokes are handled as shortcuts..
> 
> In the other hand plugin (footprint wizard) loading doesn’t show
> any wizard (and we bundle a few).
> 
> (Open footprint editor -> New footprint using wizard)
> check if we’re providing correct env vars, and if this code is valid enough 
> for our OS X bundling.
> http://bazaar.launchpad.net/~kicad-product-committers/kicad/product/view/head:/scripting/kicadplugins.i#L70
>  
> 
> 
> Otherwise we could extend the places were python looks for plugins at start 
> if that were necessary.
> 
> Best,
> Miguel Ángel.
> 
> Miguel Ángel Ajo
> 
> On Monday, 16 de March de 2015 at 19:34, Adam Wolf wrote:
> 
>> Hi folks,
>> 
>> There is a debug night build of Python scripting on OS X, thanks to Collin. 
>> I haven't switched it over because the scripting console is messed up.  I 
>> posted details on the list a few weeks ago, but here's the link.
>> 
>> http://downloads.kicad-pcb.org/osx/DEBUG/ 
>> 
>> 
>> If folks think I should switch it over to be the regular nightlies, I can do 
>> that no problem.
>> 
>> Adam Wolf
>> Cofounder and Engineer
>> W&L
>> 
>> 
>> On Mon, Mar 16, 2015 at 1:13 PM, Wayne Stambaugh > > wrote:
>>> I hope we can get Python scripting working on OSX before the stable
>>> release but I cannot guarantee it.  Building OSX binaries has been
>>> difficult to say the least but I think we're close.  The OSX devs can
>>> probably give you a better idea than I can.
>>> 
>>> On 3/14/2015 5:00 PM, Jean-Paul Louis wrote:
>>> > I still cannot build with Python Scripting enabled in OS X,
>>> > and the build made by Adam was not working (Python console unusable)
>>> >
>>> > Will that be fixed before stable release? I am not using it yet because 
>>> > of this.
>>> >
>>> > Just curious,
>>> > Jean-Paul
>>> > AC9GH
>>> >
>>> >
>>> >> On Mar 14, 2015, at 2:47 PM, Wayne Stambaugh >> >> > wrote:
>>> >>
>>> >> As you all know we are currently working towards a stable release.  I
>>> >> need to get and idea of what open items are left before I declare a
>>> >> feature freeze.  Here is the list of things I know about:
>>> >>
>>> >> * Environment variable path edit dialog (me, in progress).
>>> >> * Add bitmaps and missing entries to GAL canvas context menu (CERN).
>>> >> * Python API (Miguel).
>>> >> * OSX track pad (Garth).
>>> >>
>>> >> Are there any other features that are on the radar for the next stable
>>> >> release?  I will make exceptions on a case by case basis after the
>>> >> freeze but I don't want to get blind sided by any unexpected feature
>>> >> requests the week before the stable release.
>>> >>
>>> >> We need to go through the bug tracker and make sure we don't have any
>>> >> known severe bugs which cause crashes and/or data loss that have not
>>> >> been tagged fix committed and take the appropriate action.  This number
>>> >> will have to be zero before I will make the stable release.  Obviously I
>>> >> would like to get as many of non-critical bugs fixed as well.
>>> >>
>>> >> What is the current status of the documentation and it's CMake build
>>> >> configuration code?  Are we far enough along that we can move the repo
>>> >> to https://github.com/KiCad ?  I want all of 
>>> >> the "official" KiCad repos
>>> >> there for obvious reasons.  We also need to get this set up soon so the
>>> >> documentation for the new router features can be added which I'm
>>> >> guessing will take awhile.  I will give all of the necessary document
>>> >> developers commit access to that repo once it is set up.  I'm going to
>>> >> let the doc developers handle the pull requests so I can keep my
>>> >> involveme

Re: [Kicad-developers] Stable release update.

2015-03-16 Thread Miguel Ángel Ajo
Nice Adam!

I wonder what happens with the console, basically it fires up, but most  
keystrokes are handled as shortcuts..

In the other hand plugin (footprint wizard) loading doesn’t show
any wizard (and we bundle a few).

(Open footprint editor -> New footprint using wizard)
check if we’re providing correct env vars, and if this code is valid enough for 
our OS X bundling.
http://bazaar.launchpad.net/~kicad-product-committers/kicad/product/view/head:/scripting/kicadplugins.i#L70

Otherwise we could extend the places were python looks for plugins at start if 
that were necessary.

Best,
Miguel Ángel.


Miguel Ángel Ajo


On Monday, 16 de March de 2015 at 19:34, Adam Wolf wrote:

> Hi folks,
>  
> There is a debug night build of Python scripting on OS X, thanks to Collin. I 
> haven't switched it over because the scripting console is messed up.  I 
> posted details on the list a few weeks ago, but here's the link.
>  
> http://downloads.kicad-pcb.org/osx/DEBUG/
>  
> If folks think I should switch it over to be the regular nightlies, I can do 
> that no problem.
>  
> Adam Wolf
> Cofounder and Engineer
> W&L
>  
>  
> On Mon, Mar 16, 2015 at 1:13 PM, Wayne Stambaugh  (mailto:stambau...@gmail.com)> wrote:
> > I hope we can get Python scripting working on OSX before the stable
> > release but I cannot guarantee it.  Building OSX binaries has been
> > difficult to say the least but I think we're close.  The OSX devs can
> > probably give you a better idea than I can.
> >  
> > On 3/14/2015 5:00 PM, Jean-Paul Louis wrote:
> > > I still cannot build with Python Scripting enabled in OS X,
> > > and the build made by Adam was not working (Python console unusable)
> > >
> > > Will that be fixed before stable release? I am not using it yet because 
> > > of this.
> > >
> > > Just curious,
> > > Jean-Paul
> > > AC9GH
> > >
> > >
> > >> On Mar 14, 2015, at 2:47 PM, Wayne Stambaugh  > >> (mailto:stambau...@gmail.com)> wrote:
> > >>
> > >> As you all know we are currently working towards a stable release.  I
> > >> need to get and idea of what open items are left before I declare a
> > >> feature freeze.  Here is the list of things I know about:
> > >>
> > >> * Environment variable path edit dialog (me, in progress).
> > >> * Add bitmaps and missing entries to GAL canvas context menu (CERN).
> > >> * Python API (Miguel).
> > >> * OSX track pad (Garth).
> > >>
> > >> Are there any other features that are on the radar for the next stable
> > >> release?  I will make exceptions on a case by case basis after the
> > >> freeze but I don't want to get blind sided by any unexpected feature
> > >> requests the week before the stable release.
> > >>
> > >> We need to go through the bug tracker and make sure we don't have any
> > >> known severe bugs which cause crashes and/or data loss that have not
> > >> been tagged fix committed and take the appropriate action.  This number
> > >> will have to be zero before I will make the stable release.  Obviously I
> > >> would like to get as many of non-critical bugs fixed as well.
> > >>
> > >> What is the current status of the documentation and it's CMake build
> > >> configuration code?  Are we far enough along that we can move the repo
> > >> to https://github.com/KiCad?  I want all of the "official" KiCad repos
> > >> there for obvious reasons.  We also need to get this set up soon so the
> > >> documentation for the new router features can be added which I'm
> > >> guessing will take awhile.  I will give all of the necessary document
> > >> developers commit access to that repo once it is set up.  I'm going to
> > >> let the doc developers handle the pull requests so I can keep my
> > >> involvement to a minimum.  Also, what about nightly builds of the
> > >> documentation?  We will need them as well.
> > >>
> > >> I think we are in pretty good shape as far as nightly builds go for all
> > >> of the major platforms.  Thanks to all of you who have worked tirelessly
> > >> on this.  If we are missing anything in this regard, please help out if
> > >> you can so we can have as many bases covered as possible once the stable
> > >> release is out.
> > >>
> > >> Hopefully I can announce the feature freeze in the next few weeks so we
> > >> can start focusing on the stable release.
> > >>
> > >> Thank you all for efforts.  I hoping the next stable release of KiCad
> > >> will meet the needs of our users.
> > >>
> > >> Cheers,
> > >>
> > >> Wayne
> > >>
> > >> ___
> > >> Mailing list: https://launchpad.net/~kicad-developers
> > >> Post to : kicad-developers@lists.launchpad.net 
> > >> (mailto:kicad-developers@lists.launchpad.net)
> > >> Unsubscribe : https://launchpad.net/~kicad-developers
> > >> More help   : https://help.launchpad.net/ListHelp
> > >
> >  
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net 
> > (mailto:kicad-de

Re: [Kicad-developers] Kicad-5522 osx testing - miscellaneous errors

2015-03-16 Thread Adam Wolf
Hi Bob,

Did you add any patches?  If you didn't, there definitely won't be any
gesture/trackpad support.  It isn't ready for merging yet due to behavior
on other platforms.

Are you looking for issues or trying to get a usable KiCad?  If the latter,
I suggest the nightlies.  I, and quite a few other people, use them to make
real boards!  (There are even nightlies with Python support in the DEBUG
folder.)

Adam Wolf
Cofounder and Engineer
W&L


On Mon, Mar 16, 2015 at 11:46 PM, Bob Gustafson  wrote:

>  Application: kicad
> Version: (2015-03-16 BZR 5522)-product Debug build
> wxWidgets: Version 3.0.2 (debug,UTF-8,compiler with C++ ABI 1002,GCC
> 4.2.1,STL containers,compatible with 2.8)
> Platform: Mac OS X (Darwin 14.1.0 x86_64), 64 bit, Little endian, wxMac
> Boost version: 1.57.0
>  USE_WX_GRAPHICS_CONTEXT=OFF
>  USE_WX_OVERLAY=ON
>  KICAD_SCRIPTING=ON
>  KICAD_SCRIPTING_MODULES=ON
>  KICAD_SCRIPTING_WXPYTHON=ON
>  USE_FP_LIB_TABLE=HARD_CODED_ON
>  BUILD_GITHUB_PLUGIN=ON
>  KICAD_USE_WEBKIT=ON
>
>
> pcbnewinitPythonScripting() failed (error 0: Undefined error: 0)
>
> * Error importing the wxPython API! 20:43:52
> pcbnewinitPythonScripting() failed: (error 0: Undefined error: 0)
> 20:43:52
>
> 
>
> There are a number of other error conditions - see attached screen dumps
> and logs
>
> -
>
> I see that the Contents/Contents typo was removed somewhere in the
> 5513-5522 changes.
>
> -
>
> I am not able to pan anywhere using two finger gestures. When I try, the
> newPCB zooms in and out.
>
> Hope this is helpful
>
> Bob G
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Incorrect save-on-quit in pcbnew with unsaved board

2015-03-16 Thread Nick Østergaard
I have confirmed the behaivour, and the patch fixes the issue.

2015-03-16 21:12 GMT+01:00 Chris Pavlina :
> In pcbnew, if you exit with a new (totally unsaved, but not empty) board
> open, and click 'yes' in the save-on-exit box, an error is raised due to
> passing an empty filename string to the save routine. Correct behavior is to
> execute a 'save as' if the filename is still blank.
>
> Attached is a patch that does this.
>
> Chris
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


[Kicad-developers] [PATCH] Incorrect save-on-quit in pcbnew with unsaved board

2015-03-16 Thread Chris Pavlina
In pcbnew, if you exit with a new (totally unsaved, but not empty) board 
open, and click 'yes' in the save-on-exit box, an error is raised due to 
passing an empty filename string to the save routine. Correct behavior 
is to execute a 'save as' if the filename is still blank.


Attached is a patch that does this.

Chris

diff --git a/include/wxPcbStruct.h b/include/wxPcbStruct.h
index ecdf62f..7444f6d 100644
--- a/include/wxPcbStruct.h
+++ b/include/wxPcbStruct.h
@@ -848,6 +848,12 @@ public:
 void OnFileHistory( wxCommandEvent& event );
 
 /**
+ * Function Files_io_from_id
+ * command handler for read and write file commands; operates directly from event ID.
+ */
+void Files_io_from_id( int id );
+
+/**
  * Function Files_io
  * is the command event handler for read and write file commands.
  */
diff --git a/pcbnew/files.cpp b/pcbnew/files.cpp
index 5796d8f..939b58e 100644
--- a/pcbnew/files.cpp
+++ b/pcbnew/files.cpp
@@ -222,6 +222,11 @@ void PCB_EDIT_FRAME::OnFileHistory( wxCommandEvent& event )
 void PCB_EDIT_FRAME::Files_io( wxCommandEvent& event )
 {
 intid = event.GetId();
+Files_io_from_id( id );
+}
+
+void PCB_EDIT_FRAME::Files_io_from_id( int id )
+{
 wxString   msg;
 
 // If an edition is in progress, stop it.
diff --git a/pcbnew/pcbframe.cpp b/pcbnew/pcbframe.cpp
index 50af8f0..386972a 100644
--- a/pcbnew/pcbframe.cpp
+++ b/pcbnew/pcbframe.cpp
@@ -595,7 +595,14 @@ void PCB_EDIT_FRAME::OnCloseWindow( wxCloseEvent& Event )
 break;
 
 case wxID_YES:
-SavePcbFile( GetBoard()->GetFileName() );
+if( GetBoard()->GetFileName() == "" )
+{
+Files_io_from_id( ID_SAVE_BOARD_AS );
+}
+else
+{
+SavePcbFile( GetBoard()->GetFileName() );
+}
 break;
 }
 }
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Stable release update.

2015-03-16 Thread Adam Wolf
Hi folks,

There is a debug night build of Python scripting on OS X, thanks to Collin.
I haven't switched it over because the scripting console is messed up.  I
posted details on the list a few weeks ago, but here's the link.

http://downloads.kicad-pcb.org/osx/DEBUG/

If folks think I should switch it over to be the regular nightlies, I can
do that no problem.

Adam Wolf
Cofounder and Engineer
W&L


On Mon, Mar 16, 2015 at 1:13 PM, Wayne Stambaugh 
wrote:

> I hope we can get Python scripting working on OSX before the stable
> release but I cannot guarantee it.  Building OSX binaries has been
> difficult to say the least but I think we're close.  The OSX devs can
> probably give you a better idea than I can.
>
> On 3/14/2015 5:00 PM, Jean-Paul Louis wrote:
> > I still cannot build with Python Scripting enabled in OS X,
> > and the build made by Adam was not working (Python console unusable)
> >
> > Will that be fixed before stable release? I am not using it yet because
> of this.
> >
> > Just curious,
> > Jean-Paul
> > AC9GH
> >
> >
> >> On Mar 14, 2015, at 2:47 PM, Wayne Stambaugh 
> wrote:
> >>
> >> As you all know we are currently working towards a stable release.  I
> >> need to get and idea of what open items are left before I declare a
> >> feature freeze.  Here is the list of things I know about:
> >>
> >> * Environment variable path edit dialog (me, in progress).
> >> * Add bitmaps and missing entries to GAL canvas context menu (CERN).
> >> * Python API (Miguel).
> >> * OSX track pad (Garth).
> >>
> >> Are there any other features that are on the radar for the next stable
> >> release?  I will make exceptions on a case by case basis after the
> >> freeze but I don't want to get blind sided by any unexpected feature
> >> requests the week before the stable release.
> >>
> >> We need to go through the bug tracker and make sure we don't have any
> >> known severe bugs which cause crashes and/or data loss that have not
> >> been tagged fix committed and take the appropriate action.  This number
> >> will have to be zero before I will make the stable release.  Obviously I
> >> would like to get as many of non-critical bugs fixed as well.
> >>
> >> What is the current status of the documentation and it's CMake build
> >> configuration code?  Are we far enough along that we can move the repo
> >> to https://github.com/KiCad?  I want all of the "official" KiCad repos
> >> there for obvious reasons.  We also need to get this set up soon so the
> >> documentation for the new router features can be added which I'm
> >> guessing will take awhile.  I will give all of the necessary document
> >> developers commit access to that repo once it is set up.  I'm going to
> >> let the doc developers handle the pull requests so I can keep my
> >> involvement to a minimum.  Also, what about nightly builds of the
> >> documentation?  We will need them as well.
> >>
> >> I think we are in pretty good shape as far as nightly builds go for all
> >> of the major platforms.  Thanks to all of you who have worked tirelessly
> >> on this.  If we are missing anything in this regard, please help out if
> >> you can so we can have as many bases covered as possible once the stable
> >> release is out.
> >>
> >> Hopefully I can announce the feature freeze in the next few weeks so we
> >> can start focusing on the stable release.
> >>
> >> Thank you all for efforts.  I hoping the next stable release of KiCad
> >> will meet the needs of our users.
> >>
> >> Cheers,
> >>
> >> Wayne
> >>
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to : kicad-developers@lists.launchpad.net
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Stable release update.

2015-03-16 Thread Wayne Stambaugh
On 3/14/2015 5:43 PM, John Beard wrote:
> On Sat, 2015-03-14 at 14:47 -0400, Wayne Stambaugh wrote:
> 
>> What is the current status of the documentation and it's CMake build
>> configuration code?  Are we far enough along that we can move the repo
>> to https://github.com/KiCad?  I want all of the "official" KiCad repos
>> there for obvious reasons.  We also need to get this set up soon so the
>> documentation for the new router features can be added which I'm
>> guessing will take awhile.  I will give all of the necessary document
>> developers commit access to that repo once it is set up.  I'm going to
>> let the doc developers handle the pull requests so I can keep my
>> involvement to a minimum.  Also, what about nightly builds of the
>> documentation?  We will need them as well.
> 
> Good timing! I just 5 minutes ago filed a pull request for the last two
> chapters of the Pcbnew documentation, which I believe means all existing
> (English) documentation is now in Asciidoc format.
> 
> Writing the array tool documentation is next on my docs list.
> 
> Cheers,
> 
> John
> 

Excellent work!  I'll have to clone the repo an see if I can get the
documentation to build.  If we are this far along, we should be able to
get the GAL canvas, P&S router, and diff/pair router documentation
merged into the Pcbnew manual before too long.  Thank you doc devs for
all of your hard work.

Cheers,

Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Stable release update.

2015-03-16 Thread Wayne Stambaugh
I hope we can get Python scripting working on OSX before the stable
release but I cannot guarantee it.  Building OSX binaries has been
difficult to say the least but I think we're close.  The OSX devs can
probably give you a better idea than I can.

On 3/14/2015 5:00 PM, Jean-Paul Louis wrote:
> I still cannot build with Python Scripting enabled in OS X,
> and the build made by Adam was not working (Python console unusable)
> 
> Will that be fixed before stable release? I am not using it yet because of 
> this.
> 
> Just curious,
> Jean-Paul
> AC9GH
> 
> 
>> On Mar 14, 2015, at 2:47 PM, Wayne Stambaugh  wrote:
>>
>> As you all know we are currently working towards a stable release.  I
>> need to get and idea of what open items are left before I declare a
>> feature freeze.  Here is the list of things I know about:
>>
>> * Environment variable path edit dialog (me, in progress).
>> * Add bitmaps and missing entries to GAL canvas context menu (CERN).
>> * Python API (Miguel).
>> * OSX track pad (Garth).
>>
>> Are there any other features that are on the radar for the next stable
>> release?  I will make exceptions on a case by case basis after the
>> freeze but I don't want to get blind sided by any unexpected feature
>> requests the week before the stable release.
>>
>> We need to go through the bug tracker and make sure we don't have any
>> known severe bugs which cause crashes and/or data loss that have not
>> been tagged fix committed and take the appropriate action.  This number
>> will have to be zero before I will make the stable release.  Obviously I
>> would like to get as many of non-critical bugs fixed as well.
>>
>> What is the current status of the documentation and it's CMake build
>> configuration code?  Are we far enough along that we can move the repo
>> to https://github.com/KiCad?  I want all of the "official" KiCad repos
>> there for obvious reasons.  We also need to get this set up soon so the
>> documentation for the new router features can be added which I'm
>> guessing will take awhile.  I will give all of the necessary document
>> developers commit access to that repo once it is set up.  I'm going to
>> let the doc developers handle the pull requests so I can keep my
>> involvement to a minimum.  Also, what about nightly builds of the
>> documentation?  We will need them as well.
>>
>> I think we are in pretty good shape as far as nightly builds go for all
>> of the major platforms.  Thanks to all of you who have worked tirelessly
>> on this.  If we are missing anything in this regard, please help out if
>> you can so we can have as many bases covered as possible once the stable
>> release is out.
>>
>> Hopefully I can announce the feature freeze in the next few weeks so we
>> can start focusing on the stable release.
>>
>> Thank you all for efforts.  I hoping the next stable release of KiCad
>> will meet the needs of our users.
>>
>> Cheers,
>>
>> Wayne
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Fix for cancellation of duplicate in GAL mode

2015-03-16 Thread Maciej Sumiński
Hi John,

I have committed your patch in 5518, thank you!

Regards,
Orson

On 03/15/2015 02:09 AM, John Beard wrote:
> I have noticed a quirk when cancelling a duplicate in modedit under GAL.
> The duplicated item would be left in the same place as the original
> rather than being deleted.
> 
> This was caused by not handling the creation of the undo point correctly
> in modedit (the analogous case was already handled in pcbnew).
> 
> Please find attached a patch to fix this issue.
> 
> Thanks,
> 
> John
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 




signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp