Re: [Kicad-developers] Layer order in print setup

2015-06-22 Thread Nick Østergaard
I never noticed, because I never use the print dialog. But I will just
let you know that there is similar ordering in the plot dialog, except
that they are in one coloumn.

2015-06-23 0:53 GMT+02:00 Martin d'Allens :
> Hi all,
>
> Technical layers in print preview are displayed in pairs, with the Bottom
> coming before the Front.
> It is the reverse for copper layers. See screenshot.
> It bothered me when selecting the matching silkscreen for a copper layer,
> and I think other scenarios can be confusing.
>
> As I figure we are not going to change the LAYER_ID enum order before the
> stable release, should I write a patch for LSET::UIOrder() ?
>
> Martin
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] PATCH: remove intermediate modal message in creating NET file that needs annotation first

2015-06-22 Thread Henner Zeller
On 22 June 2015 at 11:25, Wayne Stambaugh  wrote:
>
> On 6/22/2015 1:05 PM, Henner Zeller wrote:
>> On 22 June 2015 at 09:39, Wayne Stambaugh  wrote:
>>> Henner,
>>>
>>> This patch fails to apply cleanly against your
>>> better-annotation-dialog-checkbox-messaging.diff patch.
>>
>> I think it conflicted with the "library rescue improvements" patch as
>> there were changes in the vicinity.
>>
>> Updated the patch. Can you try again ?
>>   
>> https://github.com/hzeller/kicad/compare/remove-unnecessary-intermediate-step.diff
>>
>> -h
>
> One small fix I would like to see on this patch is to hide the user
> message text control without the dead space at the top of the dialog
> box.  I believe if you put the static text control in it's own sizer,
> you can hide the sizer and the spacing will take care of itself.  Maybe
> you can just hide the static text control.  You may have to call one of
> the wxWindows fit functions to get this work properly but it would make
> for a nicer looking dialog.

Just hiding did the trick. Updated patch on
  
https://github.com/hzeller/kicad/compare/remove-unnecessary-intermediate-step.diff


>
>>
>>> Wayne
>>>
>>> On 6/20/2015 6:57 PM, Henner Zeller wrote:
 Hi,
 When writing a NET file, eeschema notices if not everything is
 annotated, so sends the user to annotate the schematic.

 However, it does so by asking this question in a modal dialog box
 first, and _then_ opens the annotation dialog, which is quite some
 annoying sequence.
 In particular if you go through it many times a day :)

 So I removed that superfluous message box, but instead added the
 message to the annotation dialog in that case. The user still can
 cancel there if they want.

 (See also my 'Possibly low-hanging fruit usability improvement' mail today)

 Patch is here:

 https://github.com/hzeller/kicad/compare/remove-unnecessary-intermediate-step.diff

 Suggested commit message
 ---
 Remove one unnecessary step in the workflow 'exporting NET file
 that requires annotation first'.
 ---

 -h

 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp

>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Fix segfault on quit

2015-06-22 Thread Chris Pavlina
Wayne, commit this one instead of the destroy() patch - found the 
problem. Also commit the second one, that's a separate (but similar) 
problem.


On Mon, Jun 22, 2015 at 07:41:24PM -0400, Wayne Stambaugh wrote:
> Is this in addition to or instead of your previous patch that removed
> destroy() from ~PGM_BASE()?
> 
> On 6/22/2015 7:04 PM, Chris Pavlina wrote:
> > Under certain (but not all) conditions, kicad applications segfault on 
> > quit. This has been reported:
> > 
> > https://bugs.launchpad.net/kicad/+bug/1431028
> > https://bugs.launchpad.net/kicad/+bug/1467221
> > 
> > It appears to be the case that Pgm().OnPgmExit() was called in the wrong 
> > place. This patch moves it from APP_SINGLE_TOP::OnRun() to 
> > APP_SINGLE_TOP::OnExit(), which appears to correct the issue.
> > 
> > --
> > Chris
> > 
> > 
> > 
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> > 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
commit 7360bdf3d29ff8af6070c9e4f8fdc84285974e68
Author: Chris Pavlina 
Date:   Mon Jun 22 20:56:03 2015 -0400

Add missing cleanup call to PGM_SINGLE_TOP::OnPgmInit

diff --git a/common/single_top.cpp b/common/single_top.cpp
index c1d8f17..dba849d 100644
--- a/common/single_top.cpp
+++ b/common/single_top.cpp
@@ -278,6 +278,11 @@ bool PGM_SINGLE_TOP::OnPgmInit( wxApp* aWxApp )
 // OpenProjectFiles() API asks that it report failure to the UI.
 // Nothing further to say here.
 
+// We've already initialized things at this point, but wx won't call OnExit if
+// we fail out. Call our own cleanup routine here to ensure the relevant resources
+// are freed at the right time (if they aren't, segfaults will occur).
+OnPgmExit();
+
 // Fail the process startup if the file could not be opened,
 // although this is an optional choice, one that can be reversed
 // also in the KIFACE specific OpenProjectFiles() return value.
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Fix segfault on quit

2015-06-22 Thread Chris Pavlina
Nope, looks like both patches are necessary. I'll investigate the first 
one further tonight, as that's just a workaround, but the second is 
definitely a fix.

On Mon, Jun 22, 2015 at 07:41:24PM -0400, Wayne Stambaugh wrote:
> Is this in addition to or instead of your previous patch that removed
> destroy() from ~PGM_BASE()?
> 
> On 6/22/2015 7:04 PM, Chris Pavlina wrote:
> > Under certain (but not all) conditions, kicad applications segfault on 
> > quit. This has been reported:
> > 
> > https://bugs.launchpad.net/kicad/+bug/1431028
> > https://bugs.launchpad.net/kicad/+bug/1467221
> > 
> > It appears to be the case that Pgm().OnPgmExit() was called in the wrong 
> > place. This patch moves it from APP_SINGLE_TOP::OnRun() to 
> > APP_SINGLE_TOP::OnExit(), which appears to correct the issue.
> > 
> > --
> > Chris
> > 
> > 
> > 
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> > 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Fix segfault on quit

2015-06-22 Thread Chris Pavlina
Actually this might also fix the other one too, don't know. But it won't
hurt to have both, so you might as well commit them for now. I'll finish
investigating the other one later tonight or tomorrow.
On Jun 22, 2015 19:43, "Chris Pavlina"  wrote:

> Addition. I still haven't tracked down the root cause of the other one,
> but this is unrelated.
> On Jun 22, 2015 19:41, "Wayne Stambaugh"  wrote:
>
>> Is this in addition to or instead of your previous patch that removed
>> destroy() from ~PGM_BASE()?
>>
>> On 6/22/2015 7:04 PM, Chris Pavlina wrote:
>> > Under certain (but not all) conditions, kicad applications segfault on
>> > quit. This has been reported:
>> >
>> > https://bugs.launchpad.net/kicad/+bug/1431028
>> > https://bugs.launchpad.net/kicad/+bug/1467221
>> >
>> > It appears to be the case that Pgm().OnPgmExit() was called in the wrong
>> > place. This patch moves it from APP_SINGLE_TOP::OnRun() to
>> > APP_SINGLE_TOP::OnExit(), which appears to correct the issue.
>> >
>> > --
>> > Chris
>> >
>> >
>> >
>> > ___
>> > Mailing list: https://launchpad.net/~kicad-developers
>> > Post to : kicad-developers@lists.launchpad.net
>> > Unsubscribe : https://launchpad.net/~kicad-developers
>> > More help   : https://help.launchpad.net/ListHelp
>> >
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Fix segfault on quit

2015-06-22 Thread Chris Pavlina
Addition. I still haven't tracked down the root cause of the other one, but
this is unrelated.
On Jun 22, 2015 19:41, "Wayne Stambaugh"  wrote:

> Is this in addition to or instead of your previous patch that removed
> destroy() from ~PGM_BASE()?
>
> On 6/22/2015 7:04 PM, Chris Pavlina wrote:
> > Under certain (but not all) conditions, kicad applications segfault on
> > quit. This has been reported:
> >
> > https://bugs.launchpad.net/kicad/+bug/1431028
> > https://bugs.launchpad.net/kicad/+bug/1467221
> >
> > It appears to be the case that Pgm().OnPgmExit() was called in the wrong
> > place. This patch moves it from APP_SINGLE_TOP::OnRun() to
> > APP_SINGLE_TOP::OnExit(), which appears to correct the issue.
> >
> > --
> > Chris
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Fix segfault on quit

2015-06-22 Thread Wayne Stambaugh
Is this in addition to or instead of your previous patch that removed
destroy() from ~PGM_BASE()?

On 6/22/2015 7:04 PM, Chris Pavlina wrote:
> Under certain (but not all) conditions, kicad applications segfault on 
> quit. This has been reported:
> 
> https://bugs.launchpad.net/kicad/+bug/1431028
> https://bugs.launchpad.net/kicad/+bug/1467221
> 
> It appears to be the case that Pgm().OnPgmExit() was called in the wrong 
> place. This patch moves it from APP_SINGLE_TOP::OnRun() to 
> APP_SINGLE_TOP::OnExit(), which appears to correct the issue.
> 
> --
> Chris
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Include open source boards as demo projects?

2015-06-22 Thread Wayne Stambaugh
On 6/22/2015 9:33 AM, Mário Luzeiro wrote:
> Hi,
> 
> My opinions / ideas about this:
> I prefer that non-source code stuff could move out from the source code 
> repository.
> Unless it is for example a test data (test board) to validate and test the 
> development.
> I see right now the demos/ folder is almost 8MB of data.
> 
> I am not sure about to add this demos to a release package, but I may prefer 
> or think that it would be amazing if this type of things could be keep online 
> in the appropriate webpage that users can find it easily and try it.
> Example: a demos page that anyone (from kicad dev) can update the demos and 
> the page to work as online show off and that people can download whatever 
> they way.
> Otherway, I believe adding this demos to a package (with all 3D and stuff)... 
> will start to increase a lot the package size.
> 
> Other idea but now easily possible would be to add a "welcome" tab in Kicad 
> where people can get some examples to play with.. but again, as a user I dont 
> like it much and I prefer a clean and tight software..

I share your views on source code.  I think moving the demos out of the
source is a good idea.  Although it likely would not happen until after
the stable release.  We could add a demos and samples section to
kicad-pcb.org and add link to the about dialog.  As long as we are not
violating any licensing issues, I see no reason not to add more high
quality projects to kicad-pcb.org.


> 
> My2cents!
> Mario Luzeiro
> 
> 
> From: Kicad-developers 
> [kicad-developers-bounces+mrluzeiro=ua...@lists.launchpad.net] on behalf of 
> Marcos Chaparro [nitrous...@gmail.com]
> Sent: 22 June 2015 06:16
> To: KiCad Developers
> Subject: [Kicad-developers] Include open source boards as demo projects?
> 
> Hi,
> A moment ago I had the idea of include open source projects in the demos/
> directory.
> 
> There are enough high quality open source projects out there, most of them
> would be happy to be included in kicad, its a way for them to get closer to
> the community. It is also a way for kicad to get closer to that community.
> 
> We were going to include just screenshots of these projects in the web
> page, maybe its a good chance to get that a bit further and let new users
> open what they see in the webpage.
> 
> I could get in contact with some hw developers to ask them if they want to
> be included in kicad, but its up to you guys to decide wether this is
> a,good idea or not.
> 
> Here are some screenshots of what we could gather from the internet so you
> can see the actual status. As you can see, most of them would need some 3D
> models and some revew to check if its well designed.
> 
> Unertooth
> [image: Inline image 1]
> HackRF
> [image: Inline image 3]
> VESC with walter's 3D models
> [image: Inline image 4]
> Saturn
> [image: Inline image 2]
> Rusefi
> 
> 
> Is this a good idea for the release?
> 
> 
> Marcos
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


[Kicad-developers] [PATCH] Fix segfault on quit

2015-06-22 Thread Chris Pavlina
Under certain (but not all) conditions, kicad applications segfault on 
quit. This has been reported:

https://bugs.launchpad.net/kicad/+bug/1431028
https://bugs.launchpad.net/kicad/+bug/1467221

It appears to be the case that Pgm().OnPgmExit() was called in the wrong 
place. This patch moves it from APP_SINGLE_TOP::OnRun() to 
APP_SINGLE_TOP::OnExit(), which appears to correct the issue.

--
Chris

commit 1fd47fa8a2bdb3daef67029ed076005e049737b7
Author: Chris Pavlina 
Date:   Mon Jun 22 19:01:12 2015 -0400

Move OnPgmExit to the correct place to avoid segfault

diff --git a/common/single_top.cpp b/common/single_top.cpp
index 8addf58..c1d8f17 100644
--- a/common/single_top.cpp
+++ b/common/single_top.cpp
@@ -143,6 +143,8 @@ struct APP_SINGLE_TOP : public wxApp
 
 int  OnExit()   // overload wxApp virtual
 {
+Pgm().OnPgmExit();
+
 return wxApp::OnExit();
 }
 
@@ -169,8 +171,6 @@ struct APP_SINGLE_TOP : public wxApp
 wxLogError( wxT( "Unhandled exception of unknown type" ) );
 }
 
-Pgm().OnPgmExit();
-
 return ret;
 }
 
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


[Kicad-developers] Layer order in print setup

2015-06-22 Thread Martin d'Allens
Hi all,

Technical layers in print preview are displayed in pairs, with the Bottom
coming before the Front.
It is the reverse for copper layers. See screenshot.
It bothered me when selecting the matching silkscreen for a copper layer,
and I think other scenarios can be confusing.

As I figure we are not going to change the LAYER_ID enum order before the
stable release, should I write a patch for LSET::UIOrder() ?

Martin
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Update the PCB from schematics in one click

2015-06-22 Thread Andy Peters

> On Jun 22, 2015, at 1:24 PM, Tomasz Wlostowski  
> wrote:
> 
> On 22.06.2015 19:47, Wayne Stambaugh wrote:
>> On 6/22/2015 1:45 PM, Andy Peters wrote:
>>> 
 On Jun 22, 2015, at 8:58 AM, Tomasz Wlostowski  
 wrote:
 
 Hi,
 
 One of the biggest annoyances of Kicad (to me) was the PCB forward
 annotation process. The attached patch set attempts to improve this by
 adding an "Update PCB From schematics" option in eeschema when Kicad is
 open in Project Manager mode. The way it works is:
 - press F9 (or select Tools->Update PCB From Schematics) in eeschema
 - a window with changes to be applied to PCB will appear
 - you can check for errors/warnings/review what is going to be change
 - click "Perform PCB update" or press Enter to proceed (or cancel).
 - netlist updates can be undone (Ctrl-Z restores PCB state after wrong
 netlist load).
>>> 
>>> I like this a lot, and I think this will go a long way towards stopping the 
>>> bitching and moaning by various people on various forums who for whatever 
>>> reason think it’s too many steps to export a netlist from eeschema and then 
>>> import it into pcbnew.
>> 
>> Are you willing to bet any money that the bitching and moaning will stop? :)
>> 
> Guys,
> 
> I wrote this patch upset by the amount of recent bitching and moaning in
> the web, so the the first person to ask "why this way and not another"
> received my whole anger.
> 
> @Nick, I owe you my apologies. Concerning your question, putting
> "update" feature in the schematic editor (and not in PCB) just seemed
> more logical (which pretty much falls into 'I like it this way'
> category) - after all you first draw the schematic, then design the PCB.
> I'm not opposed to having the same in PCBnew as long as it stays in the
> schematic editor too.

For what it’s worth, and not to say that Kicad should emulate everything they 
do, but Altium has the “Design -> Update PCB Document” menu item in the 
schematic editor, and “Design -> Import Changes from XX.PrjPCB” in the layout 
editor.

But I am with Tom. in AD I always update the layout from the schematic, and not 
the other way around, because I always edit the schematic to make design 
changes, not the layout. But if the button is in both places, that’s fine, and 
should satisfy everyone. 

Note the weasel word “should,” because there are those who suggest that the 
layout be automagically updated up each new addition to the schematic, or at 
least upon each schematic save.

(Ultiboard did something horrifying, which was if you deleted a footprint from 
the layout, it also deleted the associated symbol from the schematic, and in an 
undo-able fashion, too!)


> We should start a moan&groan hall of fame, maybe accompanied with a
> 'feature for the best/funnist/most ridiculous moan' program.
> 
> Reading the EEVblog forum, my current favourite is:
> 
> "What I don't understand is why CERN is investing in KiCAD.
> Why not just pay for a known working commercial product, and redirect
> the software engineers wages back to physicists?”

The answer to that question is “He who controls the spice controls the 
universe.”

Or maybe something a whole lot less evil.

Seriously, though, in the category of “most ridiculous moans” is the one that 
goes “Kicad needs to have a foundation that can fund the development,” yet 
there’s some wag who says that an organization willing to fund the development 
should instead get back it its core mission while misunderstanding the full 
scope of that core mission.

Party on,
-a



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Remove backtracking wires in eeschema

2015-06-22 Thread Nick Østergaard
I orginally pinged Chris about this bug and he friendly took up the
task. Thumbs up.

I have applied the patch and it fixes the issue.

On a side note:
There was once upon a time that one could draw backwards on a wire to
delete it, but one can't do that anymore.  (But I think that has been
impossible for quite some time now.)   Is this something I am dreaming
or was this really the case?

2015-06-22 22:50 GMT+02:00 Chris Pavlina :
> If you place a wire segment and then backtrack over it, you end up with
> a broken wire in the end:
>
> http://misc.c4757p.com/backtrack.mp4
>
> This is because the two segments are merged together, rather than the
> second *subtracting* from the first, even though the latter case is the
> way it's shown as you're drawing. This patch fixes that by adding a
> function to erase backtracks.
>
> --
> Chris
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


[Kicad-developers] Mouse offset block pcbnew regression?

2015-06-22 Thread Adam Wolf
Hi folks,

I have been wrapping up a board over the last few days, and have been using
both the Linux and OS X builds (I had switched to OS X almost exclusively
about a year ago, only using the Linux build again this weekend.)

I have been having some problems when moving blocks in pcbnew, and I'm
wondering if somehow this is intentional, or if I'm doing something wrong,
or if it's a bug.

I select a block with my mouse, and move the mouse (even one teensy pixel)
to drag the block--the block seems to jump quite a bit. Sometimes all the
way off the board, away from the page borders and everything.

If I exclusively use the keyboard keys, there are no weird jumps.

Just me?

Adam Wolf
Cofounder and Engineer
Wayne and Layne, LLC
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Update the PCB from schematics in one click

2015-06-22 Thread Javier Serrano
On Mon, Jun 22, 2015 at 10:33 PM, Nick Østergaard  wrote:
> Indeed there are some hilarious people/trolls in there, it is both fun
> at sad to see how some people is not knowing anything about something,
> but still persists to say that that something is crap, when 95% of
> their points are invald. But ohh well, some people just like to write
> about stuff that "don't really have their interrest".

I think that these forums do have wheat and chaff like all forums, but
they are ultimately invaluable sources of information. We're actually
very fortunate to have all these people trying KiCad and telling us
what they think should be improved. Up to us to decide what's most
important and make a coherent plan out of it. I recognized some of you
in the recent thread about EDA tools for OSHW [1], and I would like to
thank you because I think it's important that we communicate what
we're up to and what's next so that people have a good basis for their
opinions and suggestions.

Party on!

Javier

[1] 
http://www.eevblog.com/forum/eda/so-what%27s-the-future-standard-cad-tool-for-open-source-hw/

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


[Kicad-developers] [PATCH] Remove backtracking wires in eeschema

2015-06-22 Thread Chris Pavlina
If you place a wire segment and then backtrack over it, you end up with 
a broken wire in the end:

http://misc.c4757p.com/backtrack.mp4

This is because the two segments are merged together, rather than the 
second *subtracting* from the first, even though the latter case is the 
way it's shown as you're drawing. This patch fixes that by adding a 
function to erase backtracks.

--
Chris
commit d18fec08e34f7b509553fc72ee0616eeda6579a6
Author: Chris Pavlina 
Date:   Mon Jun 22 16:16:50 2015 -0400

Remove backtracking segments when drawing wires

diff --git a/eeschema/bus-wire-junction.cpp b/eeschema/bus-wire-junction.cpp
index a33f7b5..eb86ba5 100644
--- a/eeschema/bus-wire-junction.cpp
+++ b/eeschema/bus-wire-junction.cpp
@@ -43,6 +43,7 @@
 #include 
 #include 
 #include 
+#include 
 
 
 static void AbortCreateNewLine( EDA_DRAW_PANEL* aPanel, wxDC* aDC );
@@ -53,6 +54,45 @@ static DLIST< SCH_ITEM > s_wires;   // when creating a new set of wires,
 
 
 /**
+ * In a contiguous list of wires, remove wires that backtrack over the previous
+ * wire. Example:
+ *
+ * Wire is added:
+ * >
+ *
+ * A second wire backtracks over it:
+ * ---<>
+ *
+ * RemoveBacktracks is called:
+ * --->
+ */
+static void RemoveBacktracks( DLIST& aWires )
+{
+SCH_LINE* last_line = NULL;
+
+EDA_ITEM* first = aWires.GetFirst();
+for( EDA_ITEM* p = first; p; p = p->Next() )
+{
+SCH_LINE *line = dynamic_cast( p );
+
+if( p != first )
+{
+wxASSERT_MSG( last_line->GetEndPoint() == line->GetStartPoint(),
+"RemoveBacktracks() requires contiguous lines" );
+if( IsPointOnSegment( last_line->GetStartPoint(), line->GetStartPoint(),
+line->GetEndPoint() ) )
+{
+last_line->SetEndPoint( line->GetEndPoint() );
+delete s_wires.Remove( line );
+p = line;
+}
+}
+last_line = line;
+}
+}
+
+
+/**
  * Mouse capture callback for drawing line segments.
  */
 static void DrawSegment( EDA_DRAW_PANEL* aPanel, wxDC* aDC, const wxPoint& aPosition,
@@ -261,6 +301,9 @@ void SCH_EDIT_FRAME::EndSegment( wxDC* DC )
 
 SaveCopyInUndoList( oldItems, UR_WIRE_IMAGE );
 
+// Remove segments backtracking over others
+RemoveBacktracks( s_wires );
+
 // Add the new wires
 screen->Append( s_wires );
 
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Update the PCB from schematics in one click

2015-06-22 Thread Nick Østergaard
2015-06-22 22:24 GMT+02:00 Tomasz Wlostowski :
> On 22.06.2015 19:47, Wayne Stambaugh wrote:
>> On 6/22/2015 1:45 PM, Andy Peters wrote:
>>>
 On Jun 22, 2015, at 8:58 AM, Tomasz Wlostowski  
 wrote:

 Hi,

 One of the biggest annoyances of Kicad (to me) was the PCB forward
 annotation process. The attached patch set attempts to improve this by
 adding an "Update PCB From schematics" option in eeschema when Kicad is
 open in Project Manager mode. The way it works is:
 - press F9 (or select Tools->Update PCB From Schematics) in eeschema
 - a window with changes to be applied to PCB will appear
 - you can check for errors/warnings/review what is going to be change
 - click "Perform PCB update" or press Enter to proceed (or cancel).
 - netlist updates can be undone (Ctrl-Z restores PCB state after wrong
 netlist load).
>>>
>>> I like this a lot, and I think this will go a long way towards stopping the 
>>> bitching and moaning by various people on various forums who for whatever 
>>> reason think it’s too many steps to export a netlist from eeschema and then 
>>> import it into pcbnew.
>>
>> Are you willing to bet any money that the bitching and moaning will stop? :)
>>
> Guys,
>
> I wrote this patch upset by the amount of recent bitching and moaning in
> the web, so the the first person to ask "why this way and not another"
> received my whole anger.
>
> @Nick, I owe you my apologies. Concerning your question, putting
> "update" feature in the schematic editor (and not in PCB) just seemed
> more logical (which pretty much falls into 'I like it this way'
> category) - after all you first draw the schematic, then design the PCB.
> I'm not opposed to having the same in PCBnew as long as it stays in the
> schematic editor too.

You don't owe me anything. You already made lots of nice stuff for
KiCad that I like to use.

I was just wondering my immediate reactions, what, weehmm, that is
werid why do that form the schematic. I thought it made more sense to
"pull" from the schematis in pcbnew, instead of "pushing" to pcbnew.

I think it makes sense to have the similar ability to pull from
pcbnew, then the user can use whatever he likes, but I have no hard
opinions on this matter. But I don't mind if this is postproned to
after the release.

> We should start a moan&groan hall of fame, maybe accompanied with a
> 'feature for the best/funnist/most ridiculous moan' program.
>
> Reading the EEVblog forum, my current favourite is:
>
> "What I don't understand is why CERN is investing in KiCAD.
> Why not just pay for a known working commercial product, and redirect
> the software engineers wages back to physicists?"

Indeed there are some hilarious people/trolls in there, it is both fun
at sad to see how some people is not knowing anything about something,
but still persists to say that that something is crap, when 95% of
their points are invald. But ohh well, some people just like to write
about stuff that "don't really have their interrest".

> Tom
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Update the PCB from schematics in one click

2015-06-22 Thread Tomasz Wlostowski
On 22.06.2015 19:47, Wayne Stambaugh wrote:
> On 6/22/2015 1:45 PM, Andy Peters wrote:
>>
>>> On Jun 22, 2015, at 8:58 AM, Tomasz Wlostowski  
>>> wrote:
>>>
>>> Hi,
>>>
>>> One of the biggest annoyances of Kicad (to me) was the PCB forward
>>> annotation process. The attached patch set attempts to improve this by
>>> adding an "Update PCB From schematics" option in eeschema when Kicad is
>>> open in Project Manager mode. The way it works is:
>>> - press F9 (or select Tools->Update PCB From Schematics) in eeschema
>>> - a window with changes to be applied to PCB will appear
>>> - you can check for errors/warnings/review what is going to be change
>>> - click "Perform PCB update" or press Enter to proceed (or cancel).
>>> - netlist updates can be undone (Ctrl-Z restores PCB state after wrong
>>> netlist load).
>>
>> I like this a lot, and I think this will go a long way towards stopping the 
>> bitching and moaning by various people on various forums who for whatever 
>> reason think it’s too many steps to export a netlist from eeschema and then 
>> import it into pcbnew.
> 
> Are you willing to bet any money that the bitching and moaning will stop? :)
> 
Guys,

I wrote this patch upset by the amount of recent bitching and moaning in
the web, so the the first person to ask "why this way and not another"
received my whole anger.

@Nick, I owe you my apologies. Concerning your question, putting
"update" feature in the schematic editor (and not in PCB) just seemed
more logical (which pretty much falls into 'I like it this way'
category) - after all you first draw the schematic, then design the PCB.
I'm not opposed to having the same in PCBnew as long as it stays in the
schematic editor too.

We should start a moan&groan hall of fame, maybe accompanied with a
'feature for the best/funnist/most ridiculous moan' program.

Reading the EEVblog forum, my current favourite is:

"What I don't understand is why CERN is investing in KiCAD.
Why not just pay for a known working commercial product, and redirect
the software engineers wages back to physicists?"

Tom




___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] PATCH: remove intermediate modal message in creating NET file that needs annotation first

2015-06-22 Thread Henner Zeller
On 22 June 2015 at 11:25, Wayne Stambaugh  wrote:
>
> On 6/22/2015 1:05 PM, Henner Zeller wrote:
>> On 22 June 2015 at 09:39, Wayne Stambaugh  wrote:
>>> Henner,
>>>
>>> This patch fails to apply cleanly against your
>>> better-annotation-dialog-checkbox-messaging.diff patch.
>>
>> I think it conflicted with the "library rescue improvements" patch as
>> there were changes in the vicinity.
>>
>> Updated the patch. Can you try again ?
>>   
>> https://github.com/hzeller/kicad/compare/remove-unnecessary-intermediate-step.diff
>>
>> -h
>
> One small fix I would like to see on this patch is to hide the user
> message text control without the dead space at the top of the dialog
> box.  I believe if you put the static text control in it's own sizer,
> you can hide the sizer and the spacing will take care of itself.

Ok, I have to play with it tonight. I don't know much about wxWidgets,
so there might be some
trial- and error involved.

-h

> Maybe
> you can just hide the static text control.  You may have to call one of
> the wxWindows fit functions to get this work properly but it would make
> for a nicer looking dialog.
>
>>
>>> Wayne
>>>
>>> On 6/20/2015 6:57 PM, Henner Zeller wrote:
 Hi,
 When writing a NET file, eeschema notices if not everything is
 annotated, so sends the user to annotate the schematic.

 However, it does so by asking this question in a modal dialog box
 first, and _then_ opens the annotation dialog, which is quite some
 annoying sequence.
 In particular if you go through it many times a day :)

 So I removed that superfluous message box, but instead added the
 message to the annotation dialog in that case. The user still can
 cancel there if they want.

 (See also my 'Possibly low-hanging fruit usability improvement' mail today)

 Patch is here:

 https://github.com/hzeller/kicad/compare/remove-unnecessary-intermediate-step.diff

 Suggested commit message
 ---
 Remove one unnecessary step in the workflow 'exporting NET file
 that requires annotation first'.
 ---

 -h

 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp

>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


[Kicad-developers] Jenkins build is back to normal : kicad-noscript-fedora20 #425

2015-06-22 Thread Miguel Angel Ajo
See 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Fix build error from 5803

2015-06-22 Thread Chris Pavlina
Nice, I was just about to submit a second patch to fix that destructor. :)


On Mon, Jun 22, 2015 at 08:36:12PM +0200, jp charras wrote:
> Le 22/06/2015 20:17, Chris Pavlina a écrit :
> > Oh, wow. God, I'm a bloody idiot.
> > 
> > Third time's the charm?
> > 
> > 
> > On Mon, Jun 22, 2015 at 02:13:40PM -0400, Chris Pavlina wrote:
> >> Found the problem in the rescue update - left a couple unused variable 
> >> declarations behind, which were no longer valid. Not sure why clang was 
> >> okay with them, it shouldn't have been.
> >>
> >> --
> >> Chris
> 
> I committed your fix. Thanks.
> 
> To avoid a compil warning I also added a virtual destructor (which do
> nothing) in class RESCUE_CANDIDATE.
> 
> 
> -- 
> Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Update the PCB from schematics in one click

2015-06-22 Thread Wayne Stambaugh
On 6/22/2015 2:34 PM, Garth Corral wrote:
> 
>> On Jun 22, 2015, at 11:02 AM, Wayne Stambaugh > > wrote:
>>
>> On 6/22/2015 1:55 PM, Andy Peters wrote:
>>>
 On Jun 22, 2015, at 10:47 AM, Wayne Stambaugh >>> > wrote:

 On 6/22/2015 1:45 PM, Andy Peters wrote:
>
>> On Jun 22, 2015, at 8:58 AM, Tomasz Wlostowski
>> mailto:tomasz.wlostow...@cern.ch>> wrote:
>>
>> Hi,
>>
>> One of the biggest annoyances of Kicad (to me) was the PCB forward
>> annotation process. The attached patch set attempts to improve this by
>> adding an "Update PCB From schematics" option in eeschema when
>> Kicad is
>> open in Project Manager mode. The way it works is:
>> - press F9 (or select Tools->Update PCB From Schematics) in eeschema
>> - a window with changes to be applied to PCB will appear
>> - you can check for errors/warnings/review what is going to be changed
>> - click "Perform PCB update" or press Enter to proceed (or cancel).
>> - netlist updates can be undone (Ctrl-Z restores PCB state after wrong
>> netlist load).
>
> I like this a lot, and I think this will go a long way towards
> stopping the bitching and moaning by various people on various
> forums who for whatever reason think it’s too many steps to export
> a netlist from eeschema and then import it into pcbnew.

 Are you willing to bet any money that the bitching and moaning will
 stop? :)
>>>
>>> I think we all know the answer to that question :)
>>
>> Sorry!  I just couldn't help myself.  I guess I've been at this too long.
>>
>>>
>>> Party on, Wayne ..
>>
>> Too funny!  If only your first name was Garth.  I haven't heard than in
>> a long time along with "Wayne's World, Wayne's World, party time,
>> excellent", "Shwin", and "Way”.
>>
> Um…  Party on, Wayne.

Party on Garth...

You guys are killing me!

> 
> 
>>>
>>> -a
>>>
>>>
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> 
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Fix build error from 5803

2015-06-22 Thread jp charras
Le 22/06/2015 20:17, Chris Pavlina a écrit :
> Oh, wow. God, I'm a bloody idiot.
> 
> Third time's the charm?
> 
> 
> On Mon, Jun 22, 2015 at 02:13:40PM -0400, Chris Pavlina wrote:
>> Found the problem in the rescue update - left a couple unused variable 
>> declarations behind, which were no longer valid. Not sure why clang was 
>> okay with them, it shouldn't have been.
>>
>> --
>> Chris

I committed your fix. Thanks.

To avoid a compil warning I also added a virtual destructor (which do
nothing) in class RESCUE_CANDIDATE.


-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Update the PCB from schematics in one click

2015-06-22 Thread Garth Corral

> On Jun 22, 2015, at 11:02 AM, Wayne Stambaugh  wrote:
> 
> On 6/22/2015 1:55 PM, Andy Peters wrote:
>> 
>>> On Jun 22, 2015, at 10:47 AM, Wayne Stambaugh  wrote:
>>> 
>>> On 6/22/2015 1:45 PM, Andy Peters wrote:
 
> On Jun 22, 2015, at 8:58 AM, Tomasz Wlostowski 
>  wrote:
> 
> Hi,
> 
> One of the biggest annoyances of Kicad (to me) was the PCB forward
> annotation process. The attached patch set attempts to improve this by
> adding an "Update PCB From schematics" option in eeschema when Kicad is
> open in Project Manager mode. The way it works is:
> - press F9 (or select Tools->Update PCB From Schematics) in eeschema
> - a window with changes to be applied to PCB will appear
> - you can check for errors/warnings/review what is going to be changed
> - click "Perform PCB update" or press Enter to proceed (or cancel).
> - netlist updates can be undone (Ctrl-Z restores PCB state after wrong
> netlist load).
 
 I like this a lot, and I think this will go a long way towards stopping 
 the bitching and moaning by various people on various forums who for 
 whatever reason think it’s too many steps to export a netlist from 
 eeschema and then import it into pcbnew.
>>> 
>>> Are you willing to bet any money that the bitching and moaning will stop? :)
>> 
>> I think we all know the answer to that question :)
> 
> Sorry!  I just couldn't help myself.  I guess I've been at this too long.
> 
>> 
>> Party on, Wayne ..
> 
> Too funny!  If only your first name was Garth.  I haven't heard than in
> a long time along with "Wayne's World, Wayne's World, party time,
> excellent", "Shwin", and "Way”.
> 
Um…  Party on, Wayne.


>> 
>> -a
>> 
>> 
>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers 
>> 
>> Post to : kicad-developers@lists.launchpad.net 
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers 
>> 
>> More help   : https://help.launchpad.net/ListHelp 
>> 
>> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers 
> 
> Post to : kicad-developers@lists.launchpad.net 
> 
> Unsubscribe : https://launchpad.net/~kicad-developers 
> 
> More help   : https://help.launchpad.net/ListHelp 
> 


smime.p7s
Description: S/MIME cryptographic signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] PATCH: remove intermediate modal message in creating NET file that needs annotation first

2015-06-22 Thread Wayne Stambaugh

On 6/22/2015 1:05 PM, Henner Zeller wrote:
> On 22 June 2015 at 09:39, Wayne Stambaugh  wrote:
>> Henner,
>>
>> This patch fails to apply cleanly against your
>> better-annotation-dialog-checkbox-messaging.diff patch.
> 
> I think it conflicted with the "library rescue improvements" patch as
> there were changes in the vicinity.
> 
> Updated the patch. Can you try again ?
>   
> https://github.com/hzeller/kicad/compare/remove-unnecessary-intermediate-step.diff
> 
> -h

One small fix I would like to see on this patch is to hide the user
message text control without the dead space at the top of the dialog
box.  I believe if you put the static text control in it's own sizer,
you can hide the sizer and the spacing will take care of itself.  Maybe
you can just hide the static text control.  You may have to call one of
the wxWindows fit functions to get this work properly but it would make
for a nicer looking dialog.

> 
>> Wayne
>>
>> On 6/20/2015 6:57 PM, Henner Zeller wrote:
>>> Hi,
>>> When writing a NET file, eeschema notices if not everything is
>>> annotated, so sends the user to annotate the schematic.
>>>
>>> However, it does so by asking this question in a modal dialog box
>>> first, and _then_ opens the annotation dialog, which is quite some
>>> annoying sequence.
>>> In particular if you go through it many times a day :)
>>>
>>> So I removed that superfluous message box, but instead added the
>>> message to the annotation dialog in that case. The user still can
>>> cancel there if they want.
>>>
>>> (See also my 'Possibly low-hanging fruit usability improvement' mail today)
>>>
>>> Patch is here:
>>>
>>> https://github.com/hzeller/kicad/compare/remove-unnecessary-intermediate-step.diff
>>>
>>> Suggested commit message
>>> ---
>>> Remove one unnecessary step in the workflow 'exporting NET file
>>> that requires annotation first'.
>>> ---
>>>
>>> -h
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Fix build error from 5803

2015-06-22 Thread Chris Pavlina
Oh, wow. God, I'm a bloody idiot.

Third time's the charm?


On Mon, Jun 22, 2015 at 02:13:40PM -0400, Chris Pavlina wrote:
> Found the problem in the rescue update - left a couple unused variable 
> declarations behind, which were no longer valid. Not sure why clang was 
> okay with them, it shouldn't have been.
> 
> --
> Chris


commit 1ffd93a238adcec2ae485ab1eaf4fe0ffddf8d17
Author: Chris Pavlina 
Date:   Mon Jun 22 14:12:18 2015 -0400

Remove unused variables which caused build error

diff --git a/eeschema/project_rescue.cpp b/eeschema/project_rescue.cpp
index 7150928..fe5dbfd 100644
--- a/eeschema/project_rescue.cpp
+++ b/eeschema/project_rescue.cpp
@@ -487,10 +487,6 @@ void RESCUER::UndoRescues()
 
 bool SCH_EDIT_FRAME::RescueProject( bool aRunningOnDemand )
 {
-// Data that will be used throughout the operation
-std::vector   candidates;
-wxStringpart_name_suffix;
-
 RESCUER rescuer( *this, Prj() );
 
 rescuer.FindCandidates();
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Fix build error from 5803

2015-06-22 Thread Chris Pavlina
Uh, oops. Apparently I can't export a patch.

On Mon, Jun 22, 2015 at 02:13:40PM -0400, Chris Pavlina wrote:
> Found the problem in the rescue update - left a couple unused variable 
> declarations behind, which were no longer valid. Not sure why clang was 
> okay with them, it shouldn't have been.
> 
> --
> Chris


commit 1fdae20da0b75c5e5a96e181bc24748b7ad577e9
Merge: 3fa3c4b 1ffd93a
Author: Chris Pavlina 
Date:   Mon Jun 22 14:14:16 2015 -0400

Merge branch 'master' into field_autoplace

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


[Kicad-developers] Build failed in Jenkins: kicad-noscript-fedora20 #424

2015-06-22 Thread Miguel Angel Ajo
See 

--
[...truncated 24722 lines...]
:
 In instantiation of ‘void boost::checked_delete(T*) [with T = const 
RESCUE_CANDIDATE]’:
:56:27:
   required from ‘void boost::delete_clone(const T*) [with T = 
RESCUE_CANDIDATE]’
:74:29:
   required from ‘static void 
boost::heap_clone_allocator::deallocate_clone(const U*) [with U = 
RESCUE_CANDIDATE]’
:126:53:
   required from ‘static void 
boost::ptr_container_detail::reversible_ptr_container::null_clone_allocator::deallocate_clone(const
 Ty_*) [with bool allow_null_values = false; Config = 
boost::ptr_container_detail::sequence_config > >; CloneAllocator = 
boost::heap_clone_allocator; 
boost::ptr_container_detail::reversible_ptr_container::Ty_ = RESCUE_CANDIDATE]’
:276:51:
   required from ‘static void 
boost::ptr_container_detail::reversible_ptr_container::null_policy_deallocate_clone(const Ty_*) [with Config = 
boost::ptr_container_detail::sequence_config > >; CloneAllocator = 
boost::heap_clone_allocator; 
boost::ptr_container_detail::reversible_ptr_container::Ty_ = RESCUE_CANDIDATE]’
:250:72:
   required from ‘void 
boost::ptr_container_detail::reversible_ptr_container::remove(I) [with I = 
boost::void_ptr_iterator<__gnu_cxx::__normal_iterator > >, RESCUE_CANDIDATE>; Config = 
boost::ptr_container_detail::sequence_config > >; CloneAllocator = 
boost::heap_clone_allocator]’
:582:23:
   required from ‘boost::ptr_container_detail::reversible_ptr_container::iterator 
boost::ptr_container_detail::reversible_ptr_container::erase(boost::ptr_container_detail::reversible_ptr_container::iterator) [with Config = 
boost::ptr_container_detail::sequence_config > >; CloneAllocator = 
boost::heap_clone_allocator; 
boost::ptr_container_detail::reversible_ptr_container::iterator = 
boost::void_ptr_iterator<__gnu_cxx::__normal_iterator > >, RESCUE_CANDIDATE>]’
:213:45:
   required from here
:34:5:
 warning: deleting object of abstract class type ‘RESCUE_CANDIDATE’ which has 
non-virtual destructor will cause undefined behaviour 
[-Wdelete-non-virtual-dtor]
 delete x;
 ^
eeschema/CMakeFiles/eeschema_kiface.dir/build.make:2716: recipe for target 
'eeschema/CMakeFiles/eeschema_kiface.dir/project_rescue.cpp.o' failed
make[2]: *** [eeschema/CMakeFiles/eeschema_kiface.dir/project_rescue.cpp.o] 
Error 1
make[2]: *** Waiting for unfinished jobs
[ 80%] Building CXX object pcbnew/CMakeFiles/pcbnew_kiface.dir/pcbframe.cpp.o
CMakeFiles/Makefile2:973: recipe for target 
'eeschema/CMakeFiles/eeschema_kiface.dir/all' failed
make[1]: *** [eeschema/CMakeFiles/eeschema_kiface.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs
[ 80%] Building CXX object 
pcbnew/CMakeFiles/pcbnew_kiface.dir/pcb_base_edit_frame.cpp.o
[ 80%] Building CXX object 
pcbnew/CMakeFiles/pcbnew_kiface.dir/append_board_to_current.cpp.o
[ 80%] Building CXX object 
cvpcb/CMakeFiles/cvpcb_kiface.dir/__/pcbnew/dialogs/dialog_fp_lib_table_base.cpp.o
[ 80%] Building CXX object pcbnew/CMakeFiles/pcbnew_kiface.dir/attribut.cpp.o
[ 80%] Building CXX object 
cvpcb/CMakeFiles/cvpcb_kiface.dir/__/pcbnew/dialogs/dialog_fp_plugin_options.cpp.o
[ 81%] Building CXX object 
pcbnew/CMakeFiles/pcbnew_kiface.dir/board_items_to_polygon_shape_transform.cpp.o
[ 81%] Building CXX object 
pcbnew/CMakeFiles/pcbnew_kiface.dir/board_undo_redo.cpp.o
[ 81%] Building CXX object pcbnew/CMakeFiles/pcbnew_kiface.dir/block.cpp.o
[ 81%] Building CXX object 
cvpcb/CMakeFiles/cvpcb_kiface.dir/__/pcbnew/dialogs/dialog_fp_plugin_options_base.cpp.o
[ 81%] Building CXX object 
pcbnew/CMakeFiles/pcbnew_kiface.dir/block_module_editor.cpp.o
[ 81%] Building CXX object 
cvpcb/CMakeFiles/cvpcb_kiface.dir/__/pcbnew/dialogs/wizard_add_fplib_base.cpp.o
[ 81%] Building CXX object 
pcbnew/CMakeFiles/pcbnew_kiface.dir/build_BOM_from_board.cpp.o
[ 81%] Building CXX object 
pcbnew/CMakeFiles/pcbnew_kiface.dir/class_pcb_layer_widget.cpp.o
[ 

[Kicad-developers] [PATCH] Fix build error from 5803

2015-06-22 Thread Chris Pavlina
Found the problem in the rescue update - left a couple unused variable 
declarations behind, which were no longer valid. Not sure why clang was 
okay with them, it shouldn't have been.

--
Chris
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Update the PCB from schematics in one click

2015-06-22 Thread Wayne Stambaugh
On 6/22/2015 1:55 PM, Andy Peters wrote:
> 
>> On Jun 22, 2015, at 10:47 AM, Wayne Stambaugh  wrote:
>>
>> On 6/22/2015 1:45 PM, Andy Peters wrote:
>>>
 On Jun 22, 2015, at 8:58 AM, Tomasz Wlostowski  
 wrote:

 Hi,

 One of the biggest annoyances of Kicad (to me) was the PCB forward
 annotation process. The attached patch set attempts to improve this by
 adding an "Update PCB From schematics" option in eeschema when Kicad is
 open in Project Manager mode. The way it works is:
 - press F9 (or select Tools->Update PCB From Schematics) in eeschema
 - a window with changes to be applied to PCB will appear
 - you can check for errors/warnings/review what is going to be changed
 - click "Perform PCB update" or press Enter to proceed (or cancel).
 - netlist updates can be undone (Ctrl-Z restores PCB state after wrong
 netlist load).
>>>
>>> I like this a lot, and I think this will go a long way towards stopping the 
>>> bitching and moaning by various people on various forums who for whatever 
>>> reason think it’s too many steps to export a netlist from eeschema and then 
>>> import it into pcbnew.
>>
>> Are you willing to bet any money that the bitching and moaning will stop? :)
> 
> I think we all know the answer to that question :)

Sorry!  I just couldn't help myself.  I guess I've been at this too long.

> 
> Party on, Wayne ..

Too funny!  If only your first name was Garth.  I haven't heard than in
a long time along with "Wayne's World, Wayne's World, party time,
excellent", "Shwin", and "Way".

> 
> -a
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] OS X issues...

2015-06-22 Thread Nick Østergaard
2015-06-22 19:54 GMT+02:00 Andy Peters :
>
>> On Jun 22, 2015, at 5:00 AM, Johannes Maibaum  wrote:
>>
>> Hey OSX devs,
>>
>> And I just came across another minor UI glitch in pcbnew: When running the 
>> DRC, the dialog
>> window loses focus to the main window after the checks are finished. Since 
>> the main window is
>> usually bigger than the DRC dialog window this results in the dialog 
>> suddenly vanishing from
>> the screen. An unexperienced user might think that the checks failed and 
>> might try to click
>> the DRC button again. But since the dialog is still lurking behind the main 
>> window, nothing
>> happens.
>>
>> I think that there are two issues here, that both should be easy to fix:
>>
>> - DRC dialog window should keep focus after checks are finished.
>> - If the dialog has somehow lost focus (perhaps the user deliberately gave 
>> focus back to the
>> main window, leaving the dialog open), the next click on the DRC button/icon 
>> should bring the
>> dialog back to focus.
>>
>> However, with the DRC issue I am not sure, if this is OSX only and I have no 
>> Linux machine
>> near me now to verify.
>
> I have noticed this, too, and it’s been a long-standing annoyance. Is this an 
> OS X-only issue or does it affect all platforms.

The "DRC dialog window should keep focus after checks are
finished."-issue does not seem to be an issue on linux. But I also use
the i3 wm which might or might not affect this beahivour.

Se other issue with clicking the DRC button when the dialog is already
open... it won't brigh the window to the front either. I just tested
this, but I have never noticed this because it has never hid itself
for me.

Sorry for continuing this, I just realised this might have gone off
topic. So I remaned this email subject.

>
> -a
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] PATCH: better annotation dialog checkbox messaging

2015-06-22 Thread Wayne Stambaugh
On 6/22/2015 1:51 PM, Andy Peters wrote:
> 
>> On Jun 22, 2015, at 9:09 AM, Henner Zeller  wrote:
>>
>> On 22 June 2015 at 08:42, Wayne Stambaugh  wrote:
>>> On 6/20/2015 4:38 PM, Henner Zeller wrote:
 Hi,
 The checkbox labels in the annotation dialog are hard to understand
 because they are passive voice and not very clear (What does 'Silent
 mode' mean ?).
 Also, the default for the 'Automatically close dialog' (which is
 false) doesn't really make sense in regluar work. So I changed it.

 Patch
 https://github.com/hzeller/kicad/compare/better-annotation-dialog-checkbox-messaging.diff

 Suggested commit message:
 ---
 Change messaging in Dialog checkbox labelling in Annotation dialog
 to more easily digestable active speech
   - 'Silent mode' -> 'Always ask for confirmation'. Default on
 (Same behavior as before, though arguably, it is very annoying and
 should probably be default off)
   - 'Automatically close dialog' -> 'Keep this dialog open'
 Also changed the default to _not_ keep the dialog open (what is
 keeping it open even be useful for ?)
 

 (I wonder, is there ever a reason to keep the annotation dialog open ?
 This only really makes sense if this is a non-modal dialog).
>>>
>>> I don't understand why the annotation dialog would stay open as opposed
>>> to any other modal dialog.
>>
>> Exactly, this is why I made the change.
>>
>>> The annotate button should perform the
>>> annotation and close the dialog box.  I would have no problem with that
>>> change.
>>
>> I can't think of a reason why the user should want to keep the dialog
>> open at all (maybe there were historical reasons ? - someone on the
>> mailing list might know).
>> Are there ever non-modal invocations of this dialog ?
>>
>> If there are no such reasons, I think the next step is to get rid of
>> this option entirely.
> 
> The only reason I can see for not having the dialog close itself after the 
> annotation completes is if there was some sort of feedback to the user, 
> perhaps a list of changed annotations (similar to the Altium ECO thing).

If the annotation dialog displayed what change were made like the Pcbnew
netlist import dialog, then it would make sense to leave it open.  Until
something like that is implemented, I think we should close it.

> 
> And I think that feedback would be handy. Who hasn’t reannotated a schematic 
> only to discover that it chose something wacky for the multi-unit parts? (I 
> know that there’s an option in the annotation dialog which keeps those units 
> together, which is brilliant.)
> 
> -a
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Update the PCB from schematics in one click

2015-06-22 Thread Andy Peters

> On Jun 22, 2015, at 10:47 AM, Wayne Stambaugh  wrote:
> 
> On 6/22/2015 1:45 PM, Andy Peters wrote:
>> 
>>> On Jun 22, 2015, at 8:58 AM, Tomasz Wlostowski  
>>> wrote:
>>> 
>>> Hi,
>>> 
>>> One of the biggest annoyances of Kicad (to me) was the PCB forward
>>> annotation process. The attached patch set attempts to improve this by
>>> adding an "Update PCB From schematics" option in eeschema when Kicad is
>>> open in Project Manager mode. The way it works is:
>>> - press F9 (or select Tools->Update PCB From Schematics) in eeschema
>>> - a window with changes to be applied to PCB will appear
>>> - you can check for errors/warnings/review what is going to be changed
>>> - click "Perform PCB update" or press Enter to proceed (or cancel).
>>> - netlist updates can be undone (Ctrl-Z restores PCB state after wrong
>>> netlist load).
>> 
>> I like this a lot, and I think this will go a long way towards stopping the 
>> bitching and moaning by various people on various forums who for whatever 
>> reason think it’s too many steps to export a netlist from eeschema and then 
>> import it into pcbnew.
> 
> Are you willing to bet any money that the bitching and moaning will stop? :)

I think we all know the answer to that question :)

Party on, Wayne ..

-a



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] idea for post-release file manipulations

2015-06-22 Thread Andy Peters

> On Jun 22, 2015, at 5:00 AM, Johannes Maibaum  wrote:
> 
> Hey OSX devs,
> 
> And I just came across another minor UI glitch in pcbnew: When running the 
> DRC, the dialog
> window loses focus to the main window after the checks are finished. Since 
> the main window is
> usually bigger than the DRC dialog window this results in the dialog suddenly 
> vanishing from
> the screen. An unexperienced user might think that the checks failed and 
> might try to click
> the DRC button again. But since the dialog is still lurking behind the main 
> window, nothing
> happens.
> 
> I think that there are two issues here, that both should be easy to fix:
> 
> - DRC dialog window should keep focus after checks are finished.
> - If the dialog has somehow lost focus (perhaps the user deliberately gave 
> focus back to the
> main window, leaving the dialog open), the next click on the DRC button/icon 
> should bring the
> dialog back to focus.
> 
> However, with the DRC issue I am not sure, if this is OSX only and I have no 
> Linux machine
> near me now to verify.

I have noticed this, too, and it’s been a long-standing annoyance. Is this an 
OS X-only issue or does it affect all platforms.

-a


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] PATCH: better annotation dialog checkbox messaging

2015-06-22 Thread Andy Peters

> On Jun 22, 2015, at 9:09 AM, Henner Zeller  wrote:
> 
> On 22 June 2015 at 08:42, Wayne Stambaugh  wrote:
>> On 6/20/2015 4:38 PM, Henner Zeller wrote:
>>> Hi,
>>> The checkbox labels in the annotation dialog are hard to understand
>>> because they are passive voice and not very clear (What does 'Silent
>>> mode' mean ?).
>>> Also, the default for the 'Automatically close dialog' (which is
>>> false) doesn't really make sense in regluar work. So I changed it.
>>> 
>>> Patch
>>> https://github.com/hzeller/kicad/compare/better-annotation-dialog-checkbox-messaging.diff
>>> 
>>> Suggested commit message:
>>> ---
>>> Change messaging in Dialog checkbox labelling in Annotation dialog
>>> to more easily digestable active speech
>>>   - 'Silent mode' -> 'Always ask for confirmation'. Default on
>>> (Same behavior as before, though arguably, it is very annoying and
>>> should probably be default off)
>>>   - 'Automatically close dialog' -> 'Keep this dialog open'
>>> Also changed the default to _not_ keep the dialog open (what is
>>> keeping it open even be useful for ?)
>>> 
>>> 
>>> (I wonder, is there ever a reason to keep the annotation dialog open ?
>>> This only really makes sense if this is a non-modal dialog).
>> 
>> I don't understand why the annotation dialog would stay open as opposed
>> to any other modal dialog.
> 
> Exactly, this is why I made the change.
> 
>> The annotate button should perform the
>> annotation and close the dialog box.  I would have no problem with that
>> change.
> 
> I can't think of a reason why the user should want to keep the dialog
> open at all (maybe there were historical reasons ? - someone on the
> mailing list might know).
> Are there ever non-modal invocations of this dialog ?
> 
> If there are no such reasons, I think the next step is to get rid of
> this option entirely.

The only reason I can see for not having the dialog close itself after the 
annotation completes is if there was some sort of feedback to the user, perhaps 
a list of changed annotations (similar to the Altium ECO thing).

And I think that feedback would be handy. Who hasn’t reannotated a schematic 
only to discover that it chose something wacky for the multi-unit parts? (I 
know that there’s an option in the annotation dialog which keeps those units 
together, which is brilliant.)

-a
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Update the PCB from schematics in one click

2015-06-22 Thread Wayne Stambaugh
On 6/22/2015 1:45 PM, Andy Peters wrote:
> 
>> On Jun 22, 2015, at 8:58 AM, Tomasz Wlostowski  
>> wrote:
>>
>> Hi,
>>
>> One of the biggest annoyances of Kicad (to me) was the PCB forward
>> annotation process. The attached patch set attempts to improve this by
>> adding an "Update PCB From schematics" option in eeschema when Kicad is
>> open in Project Manager mode. The way it works is:
>> - press F9 (or select Tools->Update PCB From Schematics) in eeschema
>> - a window with changes to be applied to PCB will appear
>> - you can check for errors/warnings/review what is going to be changed
>> - click "Perform PCB update" or press Enter to proceed (or cancel).
>> - netlist updates can be undone (Ctrl-Z restores PCB state after wrong
>> netlist load).
> 
> I like this a lot, and I think this will go a long way towards stopping the 
> bitching and moaning by various people on various forums who for whatever 
> reason think it’s too many steps to export a netlist from eeschema and then 
> import it into pcbnew.

Are you willing to bet any money that the bitching and moaning will stop? :)

> 
> -a
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Update the PCB from schematics in one click

2015-06-22 Thread Andy Peters

> On Jun 22, 2015, at 8:58 AM, Tomasz Wlostowski  
> wrote:
> 
> Hi,
> 
> One of the biggest annoyances of Kicad (to me) was the PCB forward
> annotation process. The attached patch set attempts to improve this by
> adding an "Update PCB From schematics" option in eeschema when Kicad is
> open in Project Manager mode. The way it works is:
> - press F9 (or select Tools->Update PCB From Schematics) in eeschema
> - a window with changes to be applied to PCB will appear
> - you can check for errors/warnings/review what is going to be changed
> - click "Perform PCB update" or press Enter to proceed (or cancel).
> - netlist updates can be undone (Ctrl-Z restores PCB state after wrong
> netlist load).

I like this a lot, and I think this will go a long way towards stopping the 
bitching and moaning by various people on various forums who for whatever 
reason think it’s too many steps to export a netlist from eeschema and then 
import it into pcbnew.

-a
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


[Kicad-developers] Build failed in Jenkins: kicad-noscript-fedora20 #423

2015-06-22 Thread Miguel Angel Ajo
See 

Changes:

[jean-pierre charras] Dialog exchange modules: add a fp selection from the fp 
viewer
Fix also an issue on Windows, when using the footprint viewer or the component 
viewer in modal mode:
Reason: these frames (when run under the Kicad manager) have the Kicad manager 
as parent, and were built with wxFRAME_FLOAT_ON_PARENT style.
On windows, when the frame with style wxFRAME_FLOAT_ON_PARENT is displayed its 
parent frame is brought to the foreground, on the top of the calling frame.
and stays displayed when closing the frame in modal mode.
This issue does not happen on unix so we use now wxSTAY_ON_TOP on Windows, and 
wxFRAME_FLOAT_ON_PARENT on unix to simulate a dialog called by ShowModal.
This is not perfect, but at least it works.

--
Started by upstream project "kicad-full" build number 526
originally caused by:
 Started by an SCM change
Building remotely on fedora21 in workspace 

$ bzr revision-info -d 
info result: bzr revision-info -d 
 returned 0. Command 
output: "5804 stambau...@verizon.net-20150622155327-vueuzuskg3hez0vm
" stderr: ""
[kicad-noscript-fedora20] $ bzr pull --overwrite lp:kicad
You have not informed bzr of your Launchpad ID, and you must do this to
write to Launchpad or access private data.  See "bzr help launchpad-login".
http://bazaar.launchpad.net/~kicad-product-committers/kicad/product is 
permanently redirected to 
http://bazaar.launchpad.net/~kicad-product-committers/kicad/product/changes
You have not informed bzr of your Launchpad ID, and you must do this to
write to Launchpad or access private data.  See "bzr help launchpad-login".
 M  common/kiway_player.cpp
 M  eeschema/viewlib_frame.cpp
 M  pcbnew/dialogs/dialog_exchange_modules_base.cpp
 M  pcbnew/dialogs/dialog_exchange_modules_base.fbp
 M  pcbnew/dialogs/dialog_exchange_modules_base.h
 M  pcbnew/modview_frame.cpp
 M  pcbnew/xchgmod.cpp
All changes applied successfully.
Now on revision 5805.
[kicad-noscript-fedora20] $ bzr revert
$ bzr revision-info -d 
info result: bzr revision-info -d 
 returned 0. Command 
output: "5805 jp.char...@wanadoo.fr-20150622172300-2eluaalqa3v0fgnn
" stderr: ""
[kicad-noscript-fedora20] $ bzr log -v -r 
revid:stambau...@verizon.net-20150622155327-vueuzuskg3hez0vm..revid:jp.char...@wanadoo.fr-20150622172300-2eluaalqa3v0fgnn
 --long --show-ids
Getting local revision...
$ bzr revision-info -d 
info result: bzr revision-info -d 
 returned 0. Command 
output: "5805 jp.char...@wanadoo.fr-20150622172300-2eluaalqa3v0fgnn
" stderr: ""
RevisionState revno:5805 
revid:jp.char...@wanadoo.fr-20150622172300-2eluaalqa3v0fgnn
[kicad-noscript-fedora20] $ /bin/sh -xe /tmp/hudson2221313223497362121.sh
+ OPTS=' -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=OFF 
-DKICAD_SCRIPTING=OFF -DKICAD_SCRIPTING_MODULES=OFF 
-DKICAD_SCRIPTING_WXPYTHON=OFF 
-DwxWidgets_CONFIG_EXECUTABLE=/usr/bin/wx-config-3.0 -DKICAD_USE_WEBKIT=OFF'
+ '[' -d build ']'
+ cd build
+ /usr/bin/cmake .. -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=OFF 
-DKICAD_SCRIPTING=OFF -DKICAD_SCRIPTING_MODULES=OFF 
-DKICAD_SCRIPTING_WXPYTHON=OFF 
-DwxWidgets_CONFIG_EXECUTABLE=/usr/bin/wx-config-3.0 -DKICAD_USE_WEBKIT=OFF
-- Check for installed OpenGL -- found
-- Found Glew: /usr/lib64/libGLEW.so
-- Check for installed GLEW -- found
-- Check for installed Cairo -- found
-- Bazaar version control system version 2.6.0 found.
-- Kicad Bazaar build version: (2015-06-22 BZR 5805)
-- Configuring done
-- Generating done
-- Build files have been written to: 

+ rm -f pcbnew/scripting/pcbnewPYTHON_wrap.cxx.o
+ rm -f pcbnew/scripting/pcbnewPYTHON_wrap.cxx
+ make -j4
[  1%] Built target boost
[  1%] [  1%] Built target page_layout_lexer_source_files
Built target netlist_lexer_source_files
[  1%] Built target fp_lib_table_lexer_source_files
[  1%] [  1%] Built target pcb_lexer_source_files
Generating headers containing GLSL source code
[  1%] Headers are up-to-date
[  1%] Built target specctra_lexer_source_files
Built target pcb_plot_lexer_source_files
[  1%] Built target shader_headers
[  1%] [  1%] Built target cmp_library_lexer_source_files
Built target dialog_bom_cfg_lexer_source_files
[  1%] Built target field_template_lexer_source_files
[ 37%] Built target bitmaps
[ 38%] [ 38%] Built target potrace
Built target lib_dxf
[ 38%] Built target pcb_calculator_lexer_source_files
[ 38%] Built target idfcyl
[ 39%] Built target idfrect
[ 39%] Built target idf3
[ 39%] Built target lib-dependencies
[ 40

Re: [Kicad-developers] PATCH: remove intermediate modal message in creating NET file that needs annotation first

2015-06-22 Thread Henner Zeller
On 22 June 2015 at 09:39, Wayne Stambaugh  wrote:
> Henner,
>
> This patch fails to apply cleanly against your
> better-annotation-dialog-checkbox-messaging.diff patch.

I think it conflicted with the "library rescue improvements" patch as
there were changes in the vicinity.

Updated the patch. Can you try again ?
  
https://github.com/hzeller/kicad/compare/remove-unnecessary-intermediate-step.diff

-h

> Wayne
>
> On 6/20/2015 6:57 PM, Henner Zeller wrote:
>> Hi,
>> When writing a NET file, eeschema notices if not everything is
>> annotated, so sends the user to annotate the schematic.
>>
>> However, it does so by asking this question in a modal dialog box
>> first, and _then_ opens the annotation dialog, which is quite some
>> annoying sequence.
>> In particular if you go through it many times a day :)
>>
>> So I removed that superfluous message box, but instead added the
>> message to the annotation dialog in that case. The user still can
>> cancel there if they want.
>>
>> (See also my 'Possibly low-hanging fruit usability improvement' mail today)
>>
>> Patch is here:
>>
>> https://github.com/hzeller/kicad/compare/remove-unnecessary-intermediate-step.diff
>>
>> Suggested commit message
>> ---
>> Remove one unnecessary step in the workflow 'exporting NET file
>> that requires annotation first'.
>> ---
>>
>> -h
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Build failed in Jenkins: kicad-noscript-fedora20 #421

2015-06-22 Thread Chris Pavlina
Oh look, another stupid mistake. **hands in C++ card**

I'll get a patch in soon, working on fixing another bug right now. I see 
the problem.

--
Chris

On Mon, Jun 22, 2015 at 12:35:35PM -0400, Wayne Stambaugh wrote:
> Chris,
> 
> Would you please take a look at this when you get a chance?
> 
> Thanks,
> 
> Wayne
> 
> On 6/21/2015 7:51 PM, Miguel Angel Ajo wrote:
> > See 
> > 
> > Changes:
> > 
> > [Wayne Stambaugh] Eeschema: component library rescue improvements.
> > 
> > * Fix case sensitive component library name searches
> > * Factor out rescue code into a generic rescue project class.
> > 
> > --
> > Started by upstream project "kicad-full" build number 524
> > originally caused by:
> >  Started by an SCM change
> > Building remotely on fedora21 in workspace 
> > 
> > $ bzr revision-info -d 
> > 
> > info result: bzr revision-info -d 
> >  returned 0. 
> > Command output: "5802 
> > maciej.sumin...@cern.ch-20150622122440-f6j78o9jc867dl80
> > " stderr: ""
> > [kicad-noscript-fedora20] $ bzr pull --overwrite lp:kicad
> > You have not informed bzr of your Launchpad ID, and you must do this to
> > write to Launchpad or access private data.  See "bzr help launchpad-login".
> > http://bazaar.launchpad.net/~kicad-product-committers/kicad/product is 
> > permanently redirected to 
> > http://bazaar.launchpad.net/~kicad-product-committers/kicad/product/changes
> > You have not informed bzr of your Launchpad ID, and you must do this to
> > write to Launchpad or access private data.  See "bzr help launchpad-login".
> > +N  eeschema/project_rescue.cpp
> > +N  eeschema/project_rescue.h
> >  M  eeschema/CMakeLists.txt
> >  M  eeschema/class_library.cpp
> >  M  eeschema/dialogs/dialog_rescue_each.cpp
> >  M  eeschema/dialogs/dialog_rescue_each_base.cpp
> >  M  eeschema/dialogs/dialog_rescue_each_base.fbp
> >  M  eeschema/files-io.cpp
> >  M  eeschema/invoke_sch_dialog.h
> > -D  eeschema/lib_cache_rescue.cpp
> > -D  eeschema/lib_cache_rescue.h
> >  M  eeschema/menubar.cpp
> >  M  eeschema/schframe.cpp
> >  M  eeschema/schframe.h
> > All changes applied successfully.
> > Now on revision 5803.
> > [kicad-noscript-fedora20] $ bzr revert
> > $ bzr revision-info -d 
> > 
> > info result: bzr revision-info -d 
> >  returned 0. 
> > Command output: "5803 stambau...@verizon.net-20150622153854-a3gx0llvfwvg9n40
> > " stderr: ""
> > [kicad-noscript-fedora20] $ bzr log -v -r 
> > revid:maciej.sumin...@cern.ch-20150622122440-f6j78o9jc867dl80..revid:stambau...@verizon.net-20150622153854-a3gx0llvfwvg9n40
> >  --long --show-ids
> > Getting local revision...
> > $ bzr revision-info -d 
> > 
> > info result: bzr revision-info -d 
> >  returned 0. 
> > Command output: "5803 stambau...@verizon.net-20150622153854-a3gx0llvfwvg9n40
> > " stderr: ""
> > RevisionState revno:5803 
> > revid:stambau...@verizon.net-20150622153854-a3gx0llvfwvg9n40
> > [kicad-noscript-fedora20] $ /bin/sh -xe /tmp/hudson2998838704902014135.sh
> > + OPTS=' -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=OFF 
> > -DKICAD_SCRIPTING=OFF -DKICAD_SCRIPTING_MODULES=OFF 
> > -DKICAD_SCRIPTING_WXPYTHON=OFF 
> > -DwxWidgets_CONFIG_EXECUTABLE=/usr/bin/wx-config-3.0 -DKICAD_USE_WEBKIT=OFF'
> > + '[' -d build ']'
> > + cd build
> > + /usr/bin/cmake .. -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=OFF 
> > -DKICAD_SCRIPTING=OFF -DKICAD_SCRIPTING_MODULES=OFF 
> > -DKICAD_SCRIPTING_WXPYTHON=OFF 
> > -DwxWidgets_CONFIG_EXECUTABLE=/usr/bin/wx-config-3.0 -DKICAD_USE_WEBKIT=OFF
> > -- Check for installed OpenGL -- found
> > -- Found Glew: /usr/lib64/libGLEW.so
> > -- Check for installed GLEW -- found
> > -- Check for installed Cairo -- found
> > -- Bazaar version control system version 2.6.0 found.
> > -- Kicad Bazaar build version: (2015-06-22 BZR 5803)
> > -- Configuring done
> > -- Generating done
> > -- Build files have been written to: 
> > 
> > + rm -f pcbnew/scripting/pcbnewPYTHON_wrap.cxx.o
> > + rm -f pcbnew/scripting/pcbnewPYTHON_wrap.cxx
> > + make -j4
> > [  0%] [  1%] [  1%] Built target netlist_lexer_source_files
> > Built target page_layout_lexer_source_files
> > Built target boost
> > [  1%] [  1%] [  1%] Built target fp_lib_table_lexer_source_files
> > Built target pcb_lexer_source_files
> > Generating headers containing GLSL source code
> > [  1%] [  1%] Built target pcb_plot_lexer_source_files
> > Built target specctra_lexer_source_files
> > Headers are up-to-date
> > [  1%] Built target shader_headers
> > [

Re: [Kicad-developers] PATCH: remove intermediate modal message in creating NET file that needs annotation first

2015-06-22 Thread Wayne Stambaugh
Henner,

This patch fails to apply cleanly against your
better-annotation-dialog-checkbox-messaging.diff patch.

Wayne

On 6/20/2015 6:57 PM, Henner Zeller wrote:
> Hi,
> When writing a NET file, eeschema notices if not everything is
> annotated, so sends the user to annotate the schematic.
> 
> However, it does so by asking this question in a modal dialog box
> first, and _then_ opens the annotation dialog, which is quite some
> annoying sequence.
> In particular if you go through it many times a day :)
> 
> So I removed that superfluous message box, but instead added the
> message to the annotation dialog in that case. The user still can
> cancel there if they want.
> 
> (See also my 'Possibly low-hanging fruit usability improvement' mail today)
> 
> Patch is here:
> 
> https://github.com/hzeller/kicad/compare/remove-unnecessary-intermediate-step.diff
> 
> Suggested commit message
> ---
> Remove one unnecessary step in the workflow 'exporting NET file
> that requires annotation first'.
> ---
> 
> -h
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Build failed in Jenkins: kicad-noscript-fedora20 #421

2015-06-22 Thread Wayne Stambaugh
Chris,

Would you please take a look at this when you get a chance?

Thanks,

Wayne

On 6/21/2015 7:51 PM, Miguel Angel Ajo wrote:
> See 
> 
> Changes:
> 
> [Wayne Stambaugh] Eeschema: component library rescue improvements.
> 
> * Fix case sensitive component library name searches
> * Factor out rescue code into a generic rescue project class.
> 
> --
> Started by upstream project "kicad-full" build number 524
> originally caused by:
>  Started by an SCM change
> Building remotely on fedora21 in workspace 
> 
> $ bzr revision-info -d 
> 
> info result: bzr revision-info -d 
>  returned 0. Command 
> output: "5802 maciej.sumin...@cern.ch-20150622122440-f6j78o9jc867dl80
> " stderr: ""
> [kicad-noscript-fedora20] $ bzr pull --overwrite lp:kicad
> You have not informed bzr of your Launchpad ID, and you must do this to
> write to Launchpad or access private data.  See "bzr help launchpad-login".
> http://bazaar.launchpad.net/~kicad-product-committers/kicad/product is 
> permanently redirected to 
> http://bazaar.launchpad.net/~kicad-product-committers/kicad/product/changes
> You have not informed bzr of your Launchpad ID, and you must do this to
> write to Launchpad or access private data.  See "bzr help launchpad-login".
> +N  eeschema/project_rescue.cpp
> +N  eeschema/project_rescue.h
>  M  eeschema/CMakeLists.txt
>  M  eeschema/class_library.cpp
>  M  eeschema/dialogs/dialog_rescue_each.cpp
>  M  eeschema/dialogs/dialog_rescue_each_base.cpp
>  M  eeschema/dialogs/dialog_rescue_each_base.fbp
>  M  eeschema/files-io.cpp
>  M  eeschema/invoke_sch_dialog.h
> -D  eeschema/lib_cache_rescue.cpp
> -D  eeschema/lib_cache_rescue.h
>  M  eeschema/menubar.cpp
>  M  eeschema/schframe.cpp
>  M  eeschema/schframe.h
> All changes applied successfully.
> Now on revision 5803.
> [kicad-noscript-fedora20] $ bzr revert
> $ bzr revision-info -d 
> 
> info result: bzr revision-info -d 
>  returned 0. Command 
> output: "5803 stambau...@verizon.net-20150622153854-a3gx0llvfwvg9n40
> " stderr: ""
> [kicad-noscript-fedora20] $ bzr log -v -r 
> revid:maciej.sumin...@cern.ch-20150622122440-f6j78o9jc867dl80..revid:stambau...@verizon.net-20150622153854-a3gx0llvfwvg9n40
>  --long --show-ids
> Getting local revision...
> $ bzr revision-info -d 
> 
> info result: bzr revision-info -d 
>  returned 0. Command 
> output: "5803 stambau...@verizon.net-20150622153854-a3gx0llvfwvg9n40
> " stderr: ""
> RevisionState revno:5803 
> revid:stambau...@verizon.net-20150622153854-a3gx0llvfwvg9n40
> [kicad-noscript-fedora20] $ /bin/sh -xe /tmp/hudson2998838704902014135.sh
> + OPTS=' -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=OFF 
> -DKICAD_SCRIPTING=OFF -DKICAD_SCRIPTING_MODULES=OFF 
> -DKICAD_SCRIPTING_WXPYTHON=OFF 
> -DwxWidgets_CONFIG_EXECUTABLE=/usr/bin/wx-config-3.0 -DKICAD_USE_WEBKIT=OFF'
> + '[' -d build ']'
> + cd build
> + /usr/bin/cmake .. -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=OFF 
> -DKICAD_SCRIPTING=OFF -DKICAD_SCRIPTING_MODULES=OFF 
> -DKICAD_SCRIPTING_WXPYTHON=OFF 
> -DwxWidgets_CONFIG_EXECUTABLE=/usr/bin/wx-config-3.0 -DKICAD_USE_WEBKIT=OFF
> -- Check for installed OpenGL -- found
> -- Found Glew: /usr/lib64/libGLEW.so
> -- Check for installed GLEW -- found
> -- Check for installed Cairo -- found
> -- Bazaar version control system version 2.6.0 found.
> -- Kicad Bazaar build version: (2015-06-22 BZR 5803)
> -- Configuring done
> -- Generating done
> -- Build files have been written to: 
> 
> + rm -f pcbnew/scripting/pcbnewPYTHON_wrap.cxx.o
> + rm -f pcbnew/scripting/pcbnewPYTHON_wrap.cxx
> + make -j4
> [  0%] [  1%] [  1%] Built target netlist_lexer_source_files
> Built target page_layout_lexer_source_files
> Built target boost
> [  1%] [  1%] [  1%] Built target fp_lib_table_lexer_source_files
> Built target pcb_lexer_source_files
> Generating headers containing GLSL source code
> [  1%] [  1%] Built target pcb_plot_lexer_source_files
> Built target specctra_lexer_source_files
> Headers are up-to-date
> [  1%] Built target shader_headers
> [  1%] [  1%] Built target cmp_library_lexer_source_files
> Built target dialog_bom_cfg_lexer_source_files
> [ 37%] Built target bitmaps
> [ 37%] [ 37%] Built target field_template_lexer_source_files
> Built target lib_dxf
> [ 38%] Built target potrace
> [ 38%] [ 38%] Built target idfcyl
> Built target pcb_calculator_lexer_source_files
> [ 38%] Built target idf3
> [ 38%] Built target lib-dependencies
> [ 39%] Built target idfrect
> [ 40%

[Kicad-developers] Build failed in Jenkins: kicad-noscript-fedora20 #422

2015-06-22 Thread Miguel Angel Ajo
See 

Changes:

[Wayne Stambaugh] Eeschema: improve annotation dialog checkbox labeling

* Change 'Silent mode' -> 'Always ask for confirmation'.  Default on
(Same behavior as before, though arguably, it is very annoying and
should probably be default off)
* 'Automatically close dialog' -> 'Keep this dialog open'.  Also changed
the default to _not_ keep the dialog open (what is keeping it open even
useful for ?)

--
Started by upstream project "kicad-full" build number 525
originally caused by:
 Started by an SCM change
Building remotely on fedora21 in workspace 

$ bzr revision-info -d 
info result: bzr revision-info -d 
 returned 0. Command 
output: "5803 stambau...@verizon.net-20150622153854-a3gx0llvfwvg9n40
" stderr: ""
[kicad-noscript-fedora20] $ bzr pull --overwrite lp:kicad
You have not informed bzr of your Launchpad ID, and you must do this to
write to Launchpad or access private data.  See "bzr help launchpad-login".
http://bazaar.launchpad.net/~kicad-product-committers/kicad/product is 
permanently redirected to 
http://bazaar.launchpad.net/~kicad-product-committers/kicad/product/changes
You have not informed bzr of your Launchpad ID, and you must do this to
write to Launchpad or access private data.  See "bzr help launchpad-login".
 M  eeschema/dialogs/dialog_annotate.cpp
 M  eeschema/dialogs/dialog_annotate_base.cpp
 M  eeschema/dialogs/dialog_annotate_base.fbp
 M  eeschema/dialogs/dialog_annotate_base.h
All changes applied successfully.
Now on revision 5804.
[kicad-noscript-fedora20] $ bzr revert
$ bzr revision-info -d 
info result: bzr revision-info -d 
 returned 0. Command 
output: "5804 stambau...@verizon.net-20150622155327-vueuzuskg3hez0vm
" stderr: ""
[kicad-noscript-fedora20] $ bzr log -v -r 
revid:stambau...@verizon.net-20150622153854-a3gx0llvfwvg9n40..revid:stambau...@verizon.net-20150622155327-vueuzuskg3hez0vm
 --long --show-ids
Getting local revision...
$ bzr revision-info -d 
info result: bzr revision-info -d 
 returned 0. Command 
output: "5804 stambau...@verizon.net-20150622155327-vueuzuskg3hez0vm
" stderr: ""
RevisionState revno:5804 
revid:stambau...@verizon.net-20150622155327-vueuzuskg3hez0vm
[kicad-noscript-fedora20] $ /bin/sh -xe /tmp/hudson3699411366771441929.sh
+ OPTS=' -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=OFF 
-DKICAD_SCRIPTING=OFF -DKICAD_SCRIPTING_MODULES=OFF 
-DKICAD_SCRIPTING_WXPYTHON=OFF 
-DwxWidgets_CONFIG_EXECUTABLE=/usr/bin/wx-config-3.0 -DKICAD_USE_WEBKIT=OFF'
+ '[' -d build ']'
+ cd build
+ /usr/bin/cmake .. -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=OFF 
-DKICAD_SCRIPTING=OFF -DKICAD_SCRIPTING_MODULES=OFF 
-DKICAD_SCRIPTING_WXPYTHON=OFF 
-DwxWidgets_CONFIG_EXECUTABLE=/usr/bin/wx-config-3.0 -DKICAD_USE_WEBKIT=OFF
-- Check for installed OpenGL -- found
-- Found Glew: /usr/lib64/libGLEW.so
-- Check for installed GLEW -- found
-- Check for installed Cairo -- found
-- Bazaar version control system version 2.6.0 found.
-- Kicad Bazaar build version: (2015-06-22 BZR 5804)
-- Configuring done
-- Generating done
-- Build files have been written to: 

+ rm -f pcbnew/scripting/pcbnewPYTHON_wrap.cxx.o
+ rm -f pcbnew/scripting/pcbnewPYTHON_wrap.cxx
+ make -j4
[  0%] [  0%] [  1%] Built target netlist_lexer_source_files
Built target page_layout_lexer_source_files
Built target boost
[  1%] [  1%] [  1%] Built target fp_lib_table_lexer_source_files
Built target pcb_lexer_source_files
Generating headers containing GLSL source code
[  1%] [  1%] Built target pcb_plot_lexer_source_files
Built target specctra_lexer_source_files
Headers are up-to-date
[  1%] Built target shader_headers
[  1%] [  1%] Built target cmp_library_lexer_source_files
[  1%] Built target field_template_lexer_source_files
Built target dialog_bom_cfg_lexer_source_files
[  2%] Built target potrace
[  2%] Built target lib_dxf
[ 38%] Built target bitmaps
[ 38%] Built target pcb_calculator_lexer_source_files
[ 38%] Built target idf3
[ 38%] [ 38%] Built target lib-dependencies
Built target idfcyl
[ 39%] Built target idfrect
[ 40%] Built target dxf2idf
[ 40%] Built target idf2vrml
[ 41%] Built target gal
[ 41%] Built target polygon
Scanning dependencies of target common
[ 45%] Built target pcbcommon
[ 45%] Building CXX object common/CMakeFiles/common.dir/build_version.cpp.o
[ 46%] Built target 3d-viewer
[ 48%] Built target pcad2kicadpcb
[ 51%] Built target pnsrouter
Linking CXX static library libcommon.a
[ 59%] Built target common
Linking CXX shar

Re: [Kicad-developers] [PATCH] Update the PCB from schematics in one click

2015-06-22 Thread Tomasz Wlostowski
On 22.06.2015 18:16, Nick Østergaard wrote:
> This sounds good, but I wonder why this is not invoked from pcbnew
> instead.
I don't want it to be invoked from PCBnew *instead*. Of course adding
"import changes from SCH" in pcbnew is an option, it would require one
more KIWAY_EXPRESS message.

> Can you explain this design decision?

Just because I like it this way.

T.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Update the PCB from schematics in one click

2015-06-22 Thread Nick Østergaard
This sounds good, but I wonder why this is not invoked from pcbnew
instead. Can you explain this design decision?

(I have not tested the patches yet)

2015-06-22 17:58 GMT+02:00 Tomasz Wlostowski :
> Hi,
>
> One of the biggest annoyances of Kicad (to me) was the PCB forward
> annotation process. The attached patch set attempts to improve this by
> adding an "Update PCB From schematics" option in eeschema when Kicad is
> open in Project Manager mode. The way it works is:
> - press F9 (or select Tools->Update PCB From Schematics) in eeschema
> - a window with changes to be applied to PCB will appear
> - you can check for errors/warnings/review what is going to be changed
> - click "Perform PCB update" or press Enter to proceed (or cancel).
> - netlist updates can be undone (Ctrl-Z restores PCB state after wrong
> netlist load).
>
> Best,
> Tom
>
> PS. Henner, thanks for the inspiration by sending your UX improving
> patches ;)
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] PATCH: better annotation dialog checkbox messaging

2015-06-22 Thread Henner Zeller
On 22 June 2015 at 08:42, Wayne Stambaugh  wrote:
> On 6/20/2015 4:38 PM, Henner Zeller wrote:
>> Hi,
>> The checkbox labels in the annotation dialog are hard to understand
>> because they are passive voice and not very clear (What does 'Silent
>> mode' mean ?).
>> Also, the default for the 'Automatically close dialog' (which is
>> false) doesn't really make sense in regluar work. So I changed it.
>>
>> Patch
>> https://github.com/hzeller/kicad/compare/better-annotation-dialog-checkbox-messaging.diff
>>
>> Suggested commit message:
>> ---
>> Change messaging in Dialog checkbox labelling in Annotation dialog
>> to more easily digestable active speech
>>- 'Silent mode' -> 'Always ask for confirmation'. Default on
>>  (Same behavior as before, though arguably, it is very annoying and
>>  should probably be default off)
>>- 'Automatically close dialog' -> 'Keep this dialog open'
>>  Also changed the default to _not_ keep the dialog open (what is
>>  keeping it open even be useful for ?)
>> 
>>
>> (I wonder, is there ever a reason to keep the annotation dialog open ?
>> This only really makes sense if this is a non-modal dialog).
>
> I don't understand why the annotation dialog would stay open as opposed
> to any other modal dialog.

Exactly, this is why I made the change.

>  The annotate button should perform the
> annotation and close the dialog box.  I would have no problem with that
> change.

I can't think of a reason why the user should want to keep the dialog
open at all (maybe there were historical reasons ? - someone on the
mailing list might know).
Are there ever non-modal invocations of this dialog ?

If there are no such reasons, I think the next step is to get rid of
this option entirely.

-h

>
>>
>> -h
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


[Kicad-developers] [PATCH] Update the PCB from schematics in one click

2015-06-22 Thread Tomasz Wlostowski
Hi,

One of the biggest annoyances of Kicad (to me) was the PCB forward
annotation process. The attached patch set attempts to improve this by
adding an "Update PCB From schematics" option in eeschema when Kicad is
open in Project Manager mode. The way it works is:
- press F9 (or select Tools->Update PCB From Schematics) in eeschema
- a window with changes to be applied to PCB will appear
- you can check for errors/warnings/review what is going to be changed
- click "Perform PCB update" or press Enter to proceed (or cancel).
- netlist updates can be undone (Ctrl-Z restores PCB state after wrong
netlist load).

Best,
Tom

PS. Henner, thanks for the inspiration by sending your UX improving
patches ;)
>From 997390ebdd58a4827a2a52dab913a7345f2e2ae7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tomasz=20W=C5=82ostowski?= 
Date: Mon, 22 Jun 2015 14:24:34 +0200
Subject: [PATCH 1/5] lazy rendering mode for HTML reporter widget (improves
 speed for large reports)

---
 common/dialogs/wx_html_report_panel.cpp  | 49 
 common/dialogs/wx_html_report_panel.h| 18 ++
 common/dialogs/wx_html_report_panel_base.cpp |  7 ++--
 common/dialogs/wx_html_report_panel_base.fbp |  4 +--
 common/dialogs/wx_html_report_panel_base.h   |  1 +
 common/reporter.cpp  | 17 ++
 include/reporter.h   | 18 ++
 7 files changed, 95 insertions(+), 19 deletions(-)

diff --git a/common/dialogs/wx_html_report_panel.cpp b/common/dialogs/wx_html_report_panel.cpp
index c2eb05b..f9e8528 100644
--- a/common/dialogs/wx_html_report_panel.cpp
+++ b/common/dialogs/wx_html_report_panel.cpp
@@ -24,15 +24,16 @@
 #include 
 #include 
 
-WX_HTML_REPORT_PANEL::WX_HTML_REPORT_PANEL( wxWindow*  parent,
-wxWindowID id,
-const wxPoint& pos,
-const wxSize&  size,
-long   style ) :
+WX_HTML_REPORT_PANEL::WX_HTML_REPORT_PANEL( wxWindow* parent,
+wxWindowID id,
+const wxPoint& pos,
+const wxSize& size,
+long style ) :
 WX_HTML_REPORT_PANEL_BASE( parent, id, pos, size, style ),
 m_reporter( this ),
-m_severities( -1 ),
-m_showAll( true )
+m_severities ( -1 ),
+m_showAll ( true ),
+m_lazyUpdate ( false )
 {
 syncCheckboxes();
 }
@@ -56,10 +57,26 @@ void WX_HTML_REPORT_PANEL::Report( const wxString& aText, REPORTER::SEVERITY aSe
 line.severity = aSeverity;
 
 m_report.push_back( line );
-m_htmlView->AppendToPage( generateHtml( line ) );
-scrollToBottom();
+
+m_html += generateHtml ( line );
+
+if(!m_lazyUpdate)
+{
+m_htmlView->AppendToPage( generateHtml( line ) );
+scrollToBottom();
+}
+}
+
+void WX_HTML_REPORT_PANEL::SetLazyUpdate ( bool aLazyUpdate )
+{
+m_lazyUpdate = aLazyUpdate;
 }
 
+void WX_HTML_REPORT_PANEL::Flush()
+{
+m_htmlView->SetPage( m_html );
+scrollToBottom();
+}
 
 void WX_HTML_REPORT_PANEL::scrollToBottom()
 {
@@ -135,13 +152,13 @@ void WX_HTML_REPORT_PANEL::onCheckBoxShowAll( wxCommandEvent& event )
 
 void WX_HTML_REPORT_PANEL::syncCheckboxes()
 {
-m_checkBoxShowWarnings->Enable( !m_showAll );
+m_checkBoxShowWarnings->Enable( ! m_showAll );
 m_checkBoxShowWarnings->SetValue( m_severities & REPORTER::RPT_WARNING );
-m_checkBoxShowErrors->Enable( !m_showAll );
+m_checkBoxShowErrors->Enable( ! m_showAll );
 m_checkBoxShowErrors->SetValue( m_severities & REPORTER::RPT_ERROR );
-m_checkBoxShowInfos->Enable( !m_showAll );
+m_checkBoxShowInfos->Enable( ! m_showAll );
 m_checkBoxShowInfos->SetValue( m_severities & REPORTER::RPT_INFO );
-m_checkBoxShowActions->Enable( !m_showAll );
+m_checkBoxShowActions->Enable( ! m_showAll );
 m_checkBoxShowActions->SetValue( m_severities & REPORTER::RPT_ACTION );
 }
 
@@ -228,5 +245,11 @@ void WX_HTML_REPORT_PANEL::onBtnSaveToFile( wxCommandEvent& event )
 
 void WX_HTML_REPORT_PANEL::Clear()
 {
+m_html.clear();
 m_report.clear();
 }
+
+void WX_HTML_REPORT_PANEL::SetLabel ( const wxString& aLabel )
+{
+m_box->GetStaticBox()->SetLabel ( aLabel );
+}
diff --git a/common/dialogs/wx_html_report_panel.h b/common/dialogs/wx_html_report_panel.h
index 9fe23fb..140ca29 100644
--- a/common/dialogs/wx_html_report_panel.h
+++ b/common/dialogs/wx_html_report_panel.h
@@ -55,6 +55,20 @@ public:
 ///> clears the report panel
 void Clear();
 
+///> sets the frame label
+void SetLabel ( const wxString& aLabel );
+
+void SetLazyUpdate ( bool aLazyUpdate );
+
+void Flush();
+
+void SetVisibleSeverities( int aSeverities )
+{
+m_showAll = false;
+m_sev

[Kicad-developers] Build failed in Jenkins: kicad-noscript-fedora20 #421

2015-06-22 Thread Miguel Angel Ajo
See 

Changes:

[Wayne Stambaugh] Eeschema: component library rescue improvements.

* Fix case sensitive component library name searches
* Factor out rescue code into a generic rescue project class.

--
Started by upstream project "kicad-full" build number 524
originally caused by:
 Started by an SCM change
Building remotely on fedora21 in workspace 

$ bzr revision-info -d 
info result: bzr revision-info -d 
 returned 0. Command 
output: "5802 maciej.sumin...@cern.ch-20150622122440-f6j78o9jc867dl80
" stderr: ""
[kicad-noscript-fedora20] $ bzr pull --overwrite lp:kicad
You have not informed bzr of your Launchpad ID, and you must do this to
write to Launchpad or access private data.  See "bzr help launchpad-login".
http://bazaar.launchpad.net/~kicad-product-committers/kicad/product is 
permanently redirected to 
http://bazaar.launchpad.net/~kicad-product-committers/kicad/product/changes
You have not informed bzr of your Launchpad ID, and you must do this to
write to Launchpad or access private data.  See "bzr help launchpad-login".
+N  eeschema/project_rescue.cpp
+N  eeschema/project_rescue.h
 M  eeschema/CMakeLists.txt
 M  eeschema/class_library.cpp
 M  eeschema/dialogs/dialog_rescue_each.cpp
 M  eeschema/dialogs/dialog_rescue_each_base.cpp
 M  eeschema/dialogs/dialog_rescue_each_base.fbp
 M  eeschema/files-io.cpp
 M  eeschema/invoke_sch_dialog.h
-D  eeschema/lib_cache_rescue.cpp
-D  eeschema/lib_cache_rescue.h
 M  eeschema/menubar.cpp
 M  eeschema/schframe.cpp
 M  eeschema/schframe.h
All changes applied successfully.
Now on revision 5803.
[kicad-noscript-fedora20] $ bzr revert
$ bzr revision-info -d 
info result: bzr revision-info -d 
 returned 0. Command 
output: "5803 stambau...@verizon.net-20150622153854-a3gx0llvfwvg9n40
" stderr: ""
[kicad-noscript-fedora20] $ bzr log -v -r 
revid:maciej.sumin...@cern.ch-20150622122440-f6j78o9jc867dl80..revid:stambau...@verizon.net-20150622153854-a3gx0llvfwvg9n40
 --long --show-ids
Getting local revision...
$ bzr revision-info -d 
info result: bzr revision-info -d 
 returned 0. Command 
output: "5803 stambau...@verizon.net-20150622153854-a3gx0llvfwvg9n40
" stderr: ""
RevisionState revno:5803 
revid:stambau...@verizon.net-20150622153854-a3gx0llvfwvg9n40
[kicad-noscript-fedora20] $ /bin/sh -xe /tmp/hudson2998838704902014135.sh
+ OPTS=' -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=OFF 
-DKICAD_SCRIPTING=OFF -DKICAD_SCRIPTING_MODULES=OFF 
-DKICAD_SCRIPTING_WXPYTHON=OFF 
-DwxWidgets_CONFIG_EXECUTABLE=/usr/bin/wx-config-3.0 -DKICAD_USE_WEBKIT=OFF'
+ '[' -d build ']'
+ cd build
+ /usr/bin/cmake .. -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=OFF 
-DKICAD_SCRIPTING=OFF -DKICAD_SCRIPTING_MODULES=OFF 
-DKICAD_SCRIPTING_WXPYTHON=OFF 
-DwxWidgets_CONFIG_EXECUTABLE=/usr/bin/wx-config-3.0 -DKICAD_USE_WEBKIT=OFF
-- Check for installed OpenGL -- found
-- Found Glew: /usr/lib64/libGLEW.so
-- Check for installed GLEW -- found
-- Check for installed Cairo -- found
-- Bazaar version control system version 2.6.0 found.
-- Kicad Bazaar build version: (2015-06-22 BZR 5803)
-- Configuring done
-- Generating done
-- Build files have been written to: 

+ rm -f pcbnew/scripting/pcbnewPYTHON_wrap.cxx.o
+ rm -f pcbnew/scripting/pcbnewPYTHON_wrap.cxx
+ make -j4
[  0%] [  1%] [  1%] Built target netlist_lexer_source_files
Built target page_layout_lexer_source_files
Built target boost
[  1%] [  1%] [  1%] Built target fp_lib_table_lexer_source_files
Built target pcb_lexer_source_files
Generating headers containing GLSL source code
[  1%] [  1%] Built target pcb_plot_lexer_source_files
Built target specctra_lexer_source_files
Headers are up-to-date
[  1%] Built target shader_headers
[  1%] [  1%] Built target cmp_library_lexer_source_files
Built target dialog_bom_cfg_lexer_source_files
[ 37%] Built target bitmaps
[ 37%] [ 37%] Built target field_template_lexer_source_files
Built target lib_dxf
[ 38%] Built target potrace
[ 38%] [ 38%] Built target idfcyl
Built target pcb_calculator_lexer_source_files
[ 38%] Built target idf3
[ 38%] Built target lib-dependencies
[ 39%] Built target idfrect
[ 40%] Built target dxf2idf
[ 40%] Built target idf2vrml
[ 41%] Built target gal
[ 41%] Built target polygon
[ 45%] Built target pcbcommon
Scanning dependencies of target common
[ 45%] Building CXX object common/CMakeFiles/common.dir/build_version.cpp.o
[ 48%] Built target pnsrouter
[ 49%] Built target 3d-viewer
[ 51%] Built target pcad2kicadpcb
Linking CXX

Re: [Kicad-developers] PATCH: better annotation dialog checkbox messaging

2015-06-22 Thread Wayne Stambaugh
On 6/20/2015 4:38 PM, Henner Zeller wrote:
> Hi,
> The checkbox labels in the annotation dialog are hard to understand
> because they are passive voice and not very clear (What does 'Silent
> mode' mean ?).
> Also, the default for the 'Automatically close dialog' (which is
> false) doesn't really make sense in regluar work. So I changed it.
> 
> Patch
> https://github.com/hzeller/kicad/compare/better-annotation-dialog-checkbox-messaging.diff
> 
> Suggested commit message:
> ---
> Change messaging in Dialog checkbox labelling in Annotation dialog
> to more easily digestable active speech
>- 'Silent mode' -> 'Always ask for confirmation'. Default on
>  (Same behavior as before, though arguably, it is very annoying and
>  should probably be default off)
>- 'Automatically close dialog' -> 'Keep this dialog open'
>  Also changed the default to _not_ keep the dialog open (what is
>  keeping it open even be useful for ?)
> 
> 
> (I wonder, is there ever a reason to keep the annotation dialog open ?
> This only really makes sense if this is a non-modal dialog).

I don't understand why the annotation dialog would stay open as opposed
to any other modal dialog.  The annotate button should perform the
annotation and close the dialog box.  I would have no problem with that
change.

> 
> -h
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


[Kicad-developers] [PATCH] Update dangling ends when adding no-connect

2015-06-22 Thread Chris Pavlina
Since my recent change to hide dangling ends also responds to no-connect 
markers, SCH_NO_CONNECT should be changed to correctly update dangling 
ends after it is placed. This patch accomplishes that.

--
Chris
commit 32d30d6b24bc75bdfa300153d5e4430a15234456
Author: Chris Pavlina 
Date:   Mon Jun 22 11:23:50 2015 -0400

Update dangling ends when adding no-connect

diff --git a/eeschema/bus-wire-junction.cpp b/eeschema/bus-wire-junction.cpp
index 62141bd..a33f7b5 100644
--- a/eeschema/bus-wire-junction.cpp
+++ b/eeschema/bus-wire-junction.cpp
@@ -379,14 +379,10 @@ SCH_NO_CONNECT* SCH_EDIT_FRAME::AddNoConnect( wxDC* aDC, const wxPoint& aPositio
 SCH_NO_CONNECT* no_connect = new SCH_NO_CONNECT( aPosition );
 
 SetRepeatItem( no_connect );
-
-m_canvas->CrossHairOff( aDC ); // Erase schematic cursor
-no_connect->Draw( m_canvas, aDC, wxPoint( 0, 0 ), GR_DEFAULT_DRAWMODE );
-
-m_canvas->CrossHairOn( aDC );  // Display schematic cursor
-
 GetScreen()->Append( no_connect );
+GetScreen()->SchematicCleanUp( m_canvas, aDC );
 OnModify();
+m_canvas->Refresh();
 SaveCopyInUndoList( no_connect, UR_NEW );
 return no_connect;
 }
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Include open source boards as demo projects?

2015-06-22 Thread Marcos Chaparro
For some reason the images are displayed in my inbox but not in the
launchpad website. See below:

https://www.flickr.com/gp/mrkindustries/t62h47

I agree about moving the demos out of the source code, but its a long shot
for me to suggest that, I don't know what its the best way to have the
projects available for the packagers. It could be a git repo for packagers
or a URL for the user to download the projects.





Marcos

On Mon, Jun 22, 2015 at 10:50 AM, Nick Østergaard  wrote:

> I think it is a good idea to have easily accessible demo projects in
> kicad, but I do also agree that they don't nessesarely in the source
> repo, they could be kept somewhere else for the packagers to package.
>
> 2015-06-22 15:33 GMT+02:00 Mário Luzeiro :
> > Hi,
> >
> > My opinions / ideas about this:
> > I prefer that non-source code stuff could move out from the source code
> repository.
> > Unless it is for example a test data (test board) to validate and test
> the development.
> > I see right now the demos/ folder is almost 8MB of data.
> >
> > I am not sure about to add this demos to a release package, but I may
> prefer or think that it would be amazing if this type of things could be
> keep online in the appropriate webpage that users can find it easily and
> try it.
> > Example: a demos page that anyone (from kicad dev) can update the demos
> and the page to work as online show off and that people can download
> whatever they way.
> > Otherway, I believe adding this demos to a package (with all 3D and
> stuff)... will start to increase a lot the package size.
> >
> > Other idea but now easily possible would be to add a "welcome" tab in
> Kicad where people can get some examples to play with.. but again, as a
> user I dont like it much and I prefer a clean and tight software..
> >
> > My2cents!
> > Mario Luzeiro
> >
> > 
> > From: Kicad-developers [kicad-developers-bounces+mrluzeiro=
> ua...@lists.launchpad.net] on behalf of Marcos Chaparro [
> nitrous...@gmail.com]
> > Sent: 22 June 2015 06:16
> > To: KiCad Developers
> > Subject: [Kicad-developers] Include open source boards as demo projects?
> >
> > Hi,
> > A moment ago I had the idea of include open source projects in the demos/
> > directory.
> >
> > There are enough high quality open source projects out there, most of
> them
> > would be happy to be included in kicad, its a way for them to get closer
> to
> > the community. It is also a way for kicad to get closer to that
> community.
> >
> > We were going to include just screenshots of these projects in the web
> > page, maybe its a good chance to get that a bit further and let new users
> > open what they see in the webpage.
> >
> > I could get in contact with some hw developers to ask them if they want
> to
> > be included in kicad, but its up to you guys to decide wether this is
> > a,good idea or not.
> >
> > Here are some screenshots of what we could gather from the internet so
> you
> > can see the actual status. As you can see, most of them would need some
> 3D
> > models and some revew to check if its well designed.
> >
> > Unertooth
> > [image: Inline image 1]
> > HackRF
> > [image: Inline image 3]
> > VESC with walter's 3D models
> > [image: Inline image 4]
> > Saturn
> > [image: Inline image 2]
> > Rusefi
> >
> >
> > Is this a good idea for the release?
> >
> >
> > Marcos
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Include open source boards as demo projects?

2015-06-22 Thread Nick Østergaard
I think it is a good idea to have easily accessible demo projects in
kicad, but I do also agree that they don't nessesarely in the source
repo, they could be kept somewhere else for the packagers to package.

2015-06-22 15:33 GMT+02:00 Mário Luzeiro :
> Hi,
>
> My opinions / ideas about this:
> I prefer that non-source code stuff could move out from the source code 
> repository.
> Unless it is for example a test data (test board) to validate and test the 
> development.
> I see right now the demos/ folder is almost 8MB of data.
>
> I am not sure about to add this demos to a release package, but I may prefer 
> or think that it would be amazing if this type of things could be keep online 
> in the appropriate webpage that users can find it easily and try it.
> Example: a demos page that anyone (from kicad dev) can update the demos and 
> the page to work as online show off and that people can download whatever 
> they way.
> Otherway, I believe adding this demos to a package (with all 3D and stuff)... 
> will start to increase a lot the package size.
>
> Other idea but now easily possible would be to add a "welcome" tab in Kicad 
> where people can get some examples to play with.. but again, as a user I dont 
> like it much and I prefer a clean and tight software..
>
> My2cents!
> Mario Luzeiro
>
> 
> From: Kicad-developers 
> [kicad-developers-bounces+mrluzeiro=ua...@lists.launchpad.net] on behalf of 
> Marcos Chaparro [nitrous...@gmail.com]
> Sent: 22 June 2015 06:16
> To: KiCad Developers
> Subject: [Kicad-developers] Include open source boards as demo projects?
>
> Hi,
> A moment ago I had the idea of include open source projects in the demos/
> directory.
>
> There are enough high quality open source projects out there, most of them
> would be happy to be included in kicad, its a way for them to get closer to
> the community. It is also a way for kicad to get closer to that community.
>
> We were going to include just screenshots of these projects in the web
> page, maybe its a good chance to get that a bit further and let new users
> open what they see in the webpage.
>
> I could get in contact with some hw developers to ask them if they want to
> be included in kicad, but its up to you guys to decide wether this is
> a,good idea or not.
>
> Here are some screenshots of what we could gather from the internet so you
> can see the actual status. As you can see, most of them would need some 3D
> models and some revew to check if its well designed.
>
> Unertooth
> [image: Inline image 1]
> HackRF
> [image: Inline image 3]
> VESC with walter's 3D models
> [image: Inline image 4]
> Saturn
> [image: Inline image 2]
> Rusefi
>
>
> Is this a good idea for the release?
>
>
> Marcos
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Include open source boards as demo projects?

2015-06-22 Thread Mário Luzeiro
Hi,

My opinions / ideas about this:
I prefer that non-source code stuff could move out from the source code 
repository.
Unless it is for example a test data (test board) to validate and test the 
development.
I see right now the demos/ folder is almost 8MB of data.

I am not sure about to add this demos to a release package, but I may prefer or 
think that it would be amazing if this type of things could be keep online in 
the appropriate webpage that users can find it easily and try it.
Example: a demos page that anyone (from kicad dev) can update the demos and the 
page to work as online show off and that people can download whatever they way.
Otherway, I believe adding this demos to a package (with all 3D and stuff)... 
will start to increase a lot the package size.

Other idea but now easily possible would be to add a "welcome" tab in Kicad 
where people can get some examples to play with.. but again, as a user I dont 
like it much and I prefer a clean and tight software..

My2cents!
Mario Luzeiro


From: Kicad-developers 
[kicad-developers-bounces+mrluzeiro=ua...@lists.launchpad.net] on behalf of 
Marcos Chaparro [nitrous...@gmail.com]
Sent: 22 June 2015 06:16
To: KiCad Developers
Subject: [Kicad-developers] Include open source boards as demo projects?

Hi,
A moment ago I had the idea of include open source projects in the demos/
directory.

There are enough high quality open source projects out there, most of them
would be happy to be included in kicad, its a way for them to get closer to
the community. It is also a way for kicad to get closer to that community.

We were going to include just screenshots of these projects in the web
page, maybe its a good chance to get that a bit further and let new users
open what they see in the webpage.

I could get in contact with some hw developers to ask them if they want to
be included in kicad, but its up to you guys to decide wether this is
a,good idea or not.

Here are some screenshots of what we could gather from the internet so you
can see the actual status. As you can see, most of them would need some 3D
models and some revew to check if its well designed.

Unertooth
[image: Inline image 1]
HackRF
[image: Inline image 3]
VESC with walter's 3D models
[image: Inline image 4]
Saturn
[image: Inline image 2]
Rusefi


Is this a good idea for the release?


Marcos
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Include open source boards as demo projects?

2015-06-22 Thread Nick Østergaard
The images are missing.

2015-06-22 6:16 GMT+02:00 Marcos Chaparro :
> Hi,
> A moment ago I had the idea of include open source projects in the demos/
> directory.
>
> There are enough high quality open source projects out there, most of them
> would be happy to be included in kicad, its a way for them to get closer to
> the community. It is also a way for kicad to get closer to that community.
>
> We were going to include just screenshots of these projects in the web
> page, maybe its a good chance to get that a bit further and let new users
> open what they see in the webpage.
>
> I could get in contact with some hw developers to ask them if they want to
> be included in kicad, but its up to you guys to decide wether this is
> a,good idea or not.
>
> Here are some screenshots of what we could gather from the internet so you
> can see the actual status. As you can see, most of them would need some 3D
> models and some revew to check if its well designed.
>
> Unertooth
> [image: Inline image 1]
> HackRF
> [image: Inline image 3]
> VESC with walter's 3D models
> [image: Inline image 4]
> Saturn
> [image: Inline image 2]
> Rusefi
>
>
> Is this a good idea for the release?
>
>
> Marcos
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] lib-cache-rescue upgrade

2015-06-22 Thread Chris Pavlina
No - I attached another in response to JP's recent mail about Coverity.
Here it is again:
Chris,

Is this patch good to go?  I'm having trouble keeping up with the patch
volume so I want to make sure before I commit it.

Thanks,

Wayne

On 6/18/2015 3:07 PM, Chris Pavlina wrote:
> Hi all,
>
> It's come to my attention that we have another old project compatibility
> issue:
>
>
https://forum.kicad.info/t/exisiting-schematic-component-not-being-found-in-library-error/976
>
> The behavior when loading a very old project with case-insensitive part
> names isn't nice at all, there's no easy way to change them over. It
> gives suggestions for new part names, but you still have to change them
> one by one.
>
> I adapted lib-cache-rescue into a more generic project-rescue, which can
> handle multiple types of rescue cases, and added one for missing symbols
> with differently cased versions available.
>
> It looks roughly like this now (though I've changed the descriptive text
> at the top since taking that screenshot):
>
> http://misc.c4757p.com/newrescue.png
>
> Please, as many people as possible, try this out.
>
> --
> Chris
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp
diff --git a/eeschema/CMakeLists.txt b/eeschema/CMakeLists.txt
index 0982735..d6cc1cd 100644
--- a/eeschema/CMakeLists.txt
+++ b/eeschema/CMakeLists.txt
@@ -114,7 +114,6 @@ set( EESCHEMA_SRCS
 libedit_undo_redo.cpp
 lib_arc.cpp
 lib_bezier.cpp
-lib_cache_rescue.cpp
 lib_circle.cpp
 lib_collectors.cpp
 lib_draw_item.cpp
@@ -139,6 +138,7 @@ set( EESCHEMA_SRCS
 plot_schematic_PS.cpp
 plot_schematic_PDF.cpp
 plot_schematic_SVG.cpp
+project_rescue.cpp
 sch_base_frame.cpp
 sch_bitmap.cpp
 sch_bus_entry.cpp
diff --git a/eeschema/class_library.cpp b/eeschema/class_library.cpp
index 4fac061..bbda657 100644
--- a/eeschema/class_library.cpp
+++ b/eeschema/class_library.cpp
@@ -38,7 +38,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 //#include 
 
 #include 
diff --git a/eeschema/dialogs/dialog_rescue_each.cpp b/eeschema/dialogs/dialog_rescue_each.cpp
index 8b896f4..31c424a 100644
--- a/eeschema/dialogs/dialog_rescue_each.cpp
+++ b/eeschema/dialogs/dialog_rescue_each.cpp
@@ -32,7 +32,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 
 class DIALOG_RESCUE_EACH: public DIALOG_RESCUE_EACH_BASE
@@ -43,24 +43,19 @@ public:
  * This dialog asks the user which rescuable, cached parts he wants to rescue.
  * Any rejects will be pruned from aCandidates.
  * @param aCaller - the SCH_EDIT_FRAME calling this
- * @param aCandidates - the list of RESCUE_CANDIDATES
- * @param aComponents - a vector of all the components in the schematic
+ * @param aRescuer - the active RESCUER instance
  * @param aAskShowAgain - if true, a "Never Show Again" button will be included
  */
-DIALOG_RESCUE_EACH( SCH_EDIT_FRAME* aParent, std::vector& aCandidates,
-std::vector& aComponents, bool aAskShowAgain );
+DIALOG_RESCUE_EACH( SCH_EDIT_FRAME* aParent, RESCUER& aRescuer, bool aAskShowAgain );
 
 ~DIALOG_RESCUE_EACH();
 
 private:
 SCH_EDIT_FRAME* m_Parent;
 wxConfigBase*   m_Config;
-std::vector* m_Candidates;
-std::vector* m_Components;
+RESCUER*m_Rescuer;
 boolm_AskShowAgain;
 
-bool m_insideUpdateEvent;
-
 bool TransferDataToWindow();
 bool TransferDataFromWindow();
 void PopulateConflictList();
@@ -75,31 +70,22 @@ private:
 };
 
 
-DIALOG_RESCUE_EACH::DIALOG_RESCUE_EACH( SCH_EDIT_FRAME* aParent, std::vector& aCandidates,
-std::vector& aComponents, bool aAskShowAgain )
-
+DIALOG_RESCUE_EACH::DIALOG_RESCUE_EACH( SCH_EDIT_FRAME* aParent, RESCUER& aRescuer,
+bool aAskShowAgain )
 : DIALOG_RESCUE_EACH_BASE( aParent ),
   m_Parent( aParent ),
-  m_Candidates( &aCandidates ),
-  m_Components( &aComponents ),
-  m_AskShowAgain( aAskShowAgain ),
-  m_insideUpdateEvent( false )
+  m_Rescuer( &aRescuer ),
+  m_AskShowAgain( aAskShowAgain )
 {
 m_Config = Kiface().KifaceSettings();
 m_stdButtonsOK->SetDefault();
 
 // Set the info message, customized to include the proper suffix.
-wxString info_message;
-info_message.Printf(
-_( "This project uses symbols that no longer match the ones in the system libraries.\n"
-   "Using this tool, you can rescue these cached symbols into a new library.\n"
-   "\n"
-   "Choose \"Re

Re: [Kicad-developers] [PATCH] lib-cache-rescue upgrade

2015-06-22 Thread Wayne Stambaugh
Chris,

Is this patch good to go?  I'm having trouble keeping up with the patch
volume so I want to make sure before I commit it.

Thanks,

Wayne

On 6/18/2015 3:07 PM, Chris Pavlina wrote:
> Hi all,
> 
> It's come to my attention that we have another old project compatibility 
> issue:
> 
> https://forum.kicad.info/t/exisiting-schematic-component-not-being-found-in-library-error/976
> 
> The behavior when loading a very old project with case-insensitive part 
> names isn't nice at all, there's no easy way to change them over. It 
> gives suggestions for new part names, but you still have to change them 
> one by one.
> 
> I adapted lib-cache-rescue into a more generic project-rescue, which can 
> handle multiple types of rescue cases, and added one for missing symbols 
> with differently cased versions available.
> 
> It looks roughly like this now (though I've changed the descriptive text 
> at the top since taking that screenshot):
> 
> http://misc.c4757p.com/newrescue.png
> 
> Please, as many people as possible, try this out.
> 
> --
> Chris
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Use new footprint selector for "Change Footprints"

2015-06-22 Thread Wayne Stambaugh
On 6/22/2015 1:20 AM, jp charras wrote:
> Le 21/06/2015 22:24, Wayne Stambaugh a écrit :
>> Does anyone else have an opinion on this?  Is there any objection to
>> getting rid of the search dialog or do you prefer adding both a search
>> (current dialog) and a browse (Chris's patch) option to select the
>> footprint.  I'm fine with either option.  I want to be sure before I
>> commit this patch.
>>
> 
> 
> I have in my working copy a version with both a search and a browse option.
> I need a bit of time to be sure there is no issue on Windows and Linux.
> 
> (Usually on Windows, when using the fp viewer in modal mode, when
> closing the Kicad manager window is raised, and this is annoying).
> 

Thanks JP!  I'll let you commit the change to avoid any duplication.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


[Kicad-developers] Include open source boards as demo projects?

2015-06-22 Thread Marcos Chaparro
Hi,
A moment ago I had the idea of include open source projects in the demos/
directory.

There are enough high quality open source projects out there, most of them
would be happy to be included in kicad, its a way for them to get closer to
the community. It is also a way for kicad to get closer to that community.

We were going to include just screenshots of these projects in the web
page, maybe its a good chance to get that a bit further and let new users
open what they see in the webpage.

I could get in contact with some hw developers to ask them if they want to
be included in kicad, but its up to you guys to decide wether this is
a,good idea or not.

Here are some screenshots of what we could gather from the internet so you
can see the actual status. As you can see, most of them would need some 3D
models and some revew to check if its well designed.

Unertooth
[image: Inline image 1]
HackRF
[image: Inline image 3]
VESC with walter's 3D models
[image: Inline image 4]
Saturn
[image: Inline image 2]
Rusefi


Is this a good idea for the release?


Marcos
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] idea for post-release file manipulations

2015-06-22 Thread Johannes Maibaum
Hey OSX devs,

great to hear that some of those UI issues will possibly be addressed before 
the stable
release!

As far as I can tell the combo box/drop-down menu bug in pcbnew only affects 
the menus listed
by Jean-Paul: Track Width, Via Diameter, Grid Size, Zoom Size. The Active Layer 
Switch drop
down menu in the toolbar above for example works as expected.

There seems to be no bug report for this. I would open one if this helps the 
devs?

And I just came across another minor UI glitch in pcbnew: When running the DRC, 
the dialog
window loses focus to the main window after the checks are finished. Since the 
main window is
usually bigger than the DRC dialog window this results in the dialog suddenly 
vanishing from
the screen. An unexperienced user might think that the checks failed and might 
try to click
the DRC button again. But since the dialog is still lurking behind the main 
window, nothing
happens.

I think that there are two issues here, that both should be easy to fix:

- DRC dialog window should keep focus after checks are finished.
- If the dialog has somehow lost focus (perhaps the user deliberately gave 
focus back to the
main window, leaving the dialog open), the next click on the DRC button/icon 
should bring the
dialog back to focus.

However, with the DRC issue I am not sure, if this is OSX only and I have no 
Linux machine
near me now to verify.

I could open a bug report for this, too, if you want.


Best,

Johannes

> Am 22.06.2015 um 07:33 schrieb Bernhard Stegmaier :
> 
> It is only about the comboboxes in the main window, right?
> Does anybody know any other comboboxes not working?
> 
> I played around with that already some while back, but didn’t find anything 
> wrong wrt how those are created.
> I can try again over the upcoming weekend…
> 
> 
> Regards,
> Bernhard
> 
>> On 22 Jun 2015, at 01:57, louijp  wrote:
>> 
>> I agree with Adam, this has been on and off for at least a year. But nobody 
>> came up with a plan to fix it. Now it seems that we have more OS X 
>> developers, so I hope someone will take the ball and run with it.
>> 
>> Jean-Paul
>> AC9GH
>> 
>> 
>> 
>> Sent from my Verizon Wireless 4G LTE smartphone
>> 
>> 
>>  Original message 
>> From: Adam Wolf 
>> Date: 2015/06/21 2:38 PM (GMT-05:00)
>> To: Nick Østergaard 
>> Cc: kicad-developers@lists.launchpad.net, Jean-Paul Louis 
>> Subject: Re: [Kicad-developers] idea for post-release file manipulations
>> 
>> That is a legitimate bug.  Not sure if it is on the tracker yet, but it has 
>> been discussed on the list.
>> 
>> There are plenty of OS X UI issues that should be evaluated before the 
>> stable release.  I suspect moat of then are wxwidgets issues.  *sigh*
>> 
>> Adam Wolf
>> 
>> Adam Wolf
>> 
>> On Jun 21, 2015 1:07 PM, "Nick Østergaard"  wrote:
>> Where is the bug listed in the bug tracker Jean-Paul?
>> 
>> 2015-06-21 19:46 GMT+02:00 Jean-Paul Louis :
>> > Are we going to the stable release with all the drop-down items broken on 
>> > pcbnew OSX?
>> >
>> > I cannot use the mouse or the track-pad to select any of the items on the 
>> > four drop-down menus for Track size, Via size, Grid size and Zoom 
>> > selection.
>> >
>> > I reported this several times, but nobody seems to acknowledge it. Is it 
>> > an issue with my setting? or it is a real issue?
>> >
>> > Thanks for letting me know.
>> >
>> > A very frustrated Jean-Paul
>> > AC9GH
>> >
>> >> On Jun 21, 2015, at 1:22 PM, Adam Wolf  
>> >> wrote:
>> >>
>> >> Simon,
>> >>
>> >> A group of us have talked about making a git plugin that will be 
>> >> compatible w the github plugin, but will use git on the user's system and 
>> >> won't do network io on its own.
>> >>
>> >> We have basically always pushed it off until after the stable release, 
>> >> but as soon as things quiet down i think we should see who is interested 
>> >> and make a roadmap and get buy-in from the lead team.
>> >>
>> >> Adam Wolf
>> >>
>> >> On Jun 21, 2015 11:46 AM, "Wayne Stambaugh"  wrote:
>> >> See include/richio.h
>> >>
>> >> Our I/O objects already support wxInputStream and wxOutputStream.
>> >> Although there is no reason you couldn't add objects that use
>> >> std::istream and std::ostream or the boost::iostreams.  I believe the
>> >> wxIoStreams already support support archives so all you would have to do
>> >> is create the stream and pass it too the proper LINE_READER or
>> >> OUTPUT_FORMATTER object.  You would automagically have archive stream
>> >> support for board file and footprint libraries.
>> >>
>> >> On 6/21/2015 8:55 AM, Simon Richter wrote:
>> >> > Hi,
>> >> >
>> >> > Am 21.06.2015 um 03:06 schrieb Cirilo Bernardo:
>> >> >
>> >> >> a. Abstracting a stream class which can magically support
>> >> >> file retrieval by http, local files, and perhaps github (I know
>> >> >> next to nothing about how github works) and local file
>> >> >> writing.
>> >> >
>> >> > std::istream?
>> >> >
>> >> >> b. The stream class can automatically inflate *.gz fi