[Kicad-developers] [PATCH] Add zoom-to-selection tool

[Chris Pavlina]

This patch adds a zoom-to-selection tool to the eeschema, libedit, pcbnew, and
modedit canvases, both legacy and GAL. It is my planned replacement for the
middle-button zoom that only works on legacy, as discussed earlier.

Because this patch only adds features, and relatively small ones, I'm going to
go ahead and push it tomorrow - just wanted to give everybody a heads-up since
it does touch a lot of files. I do want to push it in though to get some
testing exposure.

Please let me know if you have any issues, other than ones mentioned below.

Known issues, to be addressed:

- OSX has a centering problem. This isn't stricly in my new code, but in old
  code I'm calling. I'm going to have an OSX box of my own by the end of the
  week (got it specifically for kicad development :), so I'll look into it then
  - though if anyone else sees what the problem is, feel free to beat me to it
  ;)

- The vertical toolbar is getting a bit long, particularly in eeschema. I'm
  going to let this be for now, since I still plan to address this in the
  future. Simon Wells has a patch in the pipeline that adds a menu to the
  toolbars to hold any icons that don't fit, which should work well as an
  interim fix until I can get around to fixing the "too damn many buttons"
  issue at the root.

- I'm not too fond of the default hotkey ('@'), but we're a bit short on new
  default hotkeys...

- Doesn't work in gerbview or pl_editor. These tools have very different UIs
  from the others and it was nontrivial to patch them in. I'll look at adding
  it to them as well, which may require a bit of effort to unify block behavior
  between them a bit.

-- 
Chris
>From c8a70168845a2873251127664328cc8d5297792a Mon Sep 17 00:00:00 2001
From: Chris Pavlina 
Date: Tue, 7 Jun 2016 17:07:45 -0400
Subject: [PATCH] Add zoom-to-selection tool

---
 common/draw_frame.cpp|   8 ++-
 common/draw_panel.cpp|   4 +-
 eeschema/hotkeys.cpp |   5 +-
 eeschema/libeditframe.cpp|   8 ++-
 eeschema/schedit.cpp |   6 +-
 eeschema/schframe.cpp|   2 +
 eeschema/tool_lib.cpp|   5 +-
 eeschema/tool_sch.cpp|   5 +-
 include/draw_frame.h |   8 ++-
 include/hotkeys_basic.h  |   3 +-
 include/id.h |   1 +
 pcbnew/CMakeLists.txt|   1 +
 pcbnew/edit.cpp  |   6 ++
 pcbnew/hotkeys.cpp   |   3 +-
 pcbnew/hotkeys_board_editor.cpp  |   4 ++
 pcbnew/hotkeys_module_editor.cpp |   7 ++-
 pcbnew/modedit.cpp   |   6 +-
 pcbnew/moduleframe.cpp   |   6 +-
 pcbnew/onleftclick.cpp   |   3 +-
 pcbnew/onrightclick.cpp  |   4 +-
 pcbnew/pcbframe.cpp  |   4 +-
 pcbnew/tool_modedit.cpp  |   5 +-
 pcbnew/tool_pcb.cpp  |   6 +-
 pcbnew/tools/common_actions.cpp  |   8 +++
 pcbnew/tools/common_actions.h|   2 +
 pcbnew/tools/tools_common.cpp|   5 +-
 pcbnew/tools/zoom_tool.cpp   | 132 +++
 pcbnew/tools/zoom_tool.h |  48 ++
 28 files changed, 283 insertions(+), 22 deletions(-)
 create mode 100644 pcbnew/tools/zoom_tool.cpp
 create mode 100644 pcbnew/tools/zoom_tool.h

diff --git a/common/draw_frame.cpp b/common/draw_frame.cpp
index 442e110..e73a293 100644
--- a/common/draw_frame.cpp
+++ b/common/draw_frame.cpp
@@ -799,14 +799,18 @@ wxString EDA_DRAW_FRAME::LengthDoubleToString( double aValue, bool aConvertToMil
 }
 
 
-bool EDA_DRAW_FRAME::HandleBlockBegin( wxDC* aDC, EDA_KEY aKey, const wxPoint& aPosition )
+bool EDA_DRAW_FRAME::HandleBlockBegin( wxDC* aDC, EDA_KEY aKey, const wxPoint& aPosition,
+   int aExplicitCommand )
 {
 BLOCK_SELECTOR* block = ()->m_BlockLocate;
 
 if( ( block->GetCommand() != BLOCK_IDLE ) || ( block->GetState() != STATE_NO_BLOCK ) )
 return false;
 
-block->SetCommand( (BLOCK_COMMAND_T) BlockCommand( aKey ) );
+if( aExplicitCommand == 0 )
+block->SetCommand( (BLOCK_COMMAND_T) BlockCommand( aKey ) );
+else
+block->SetCommand( (BLOCK_COMMAND_T) aExplicitCommand );
 
 if( block->GetCommand() == 0 )
 return false;
diff --git a/common/draw_panel.cpp b/common/draw_panel.cpp
index 1455ca5..75ebb7a 100644
--- a/common/draw_panel.cpp
+++ b/common/draw_panel.cpp
@@ -1323,7 +1323,9 @@ void EDA_DRAW_PANEL::OnMouseEvent( wxMouseEvent& event )
 m_minDragEventCount++;
 else
 {
-if( !GetParent()->HandleBlockBegin( , cmd_type, m_CursorStartPos ) )
+auto cmd = (GetParent()->GetToolId() == ID_ZOOM_SELECTION) ? BLOCK_ZOOM : 0;
+
+if( !GetParent()->HandleBlockBegin( , cmd_type, m_CursorStartPos, cmd ) )
 {
 // should not occur: error
 GetParent()->DisplayToolMsg(
diff --git a/eeschema/hotkeys.cpp b/eeschema/hotkeys.cpp

Re: [Kicad-developers] [PATCH 02/16] Add missing dependency github_plugin -> pcbcommon

[Wayne Stambaugh]

Committed in product branch r6897.  Thanks.

On 6/7/2016 3:54 PM, Simon Richter wrote:
> 
> The GitHub plugin needs the generated PCB parser code, so introduce an
> artificial dependency.
> ---
>  pcbnew/CMakeLists.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH 01/16] Fix spelling "propage" -> "propagate"

[Wayne Stambaugh]

Patch committed in product branch r6896.  Thanks.

On 6/7/2016 3:54 PM, Simon Richter wrote:
> ---
>  eeschema/class_netlist_object.h |  2 +-
>  eeschema/netlist.cpp| 16 
>  2 files changed, 9 insertions(+), 9 deletions(-)
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH 07/16] Kill unused NETLIST_EXPORTER_GENERIC::writeListOfNets

[Simon Richter]

This function is unused, and looks similar to the tree builder above, so it
might likely be left over from a refactoring effort.
---
 .../netlist_exporters/netlist_exporter_generic.cpp | 73 --
 .../netlist_exporters/netlist_exporter_generic.h   |  7 ---
 2 files changed, 80 deletions(-)

diff --git a/eeschema/netlist_exporters/netlist_exporter_generic.cpp b/eeschema/netlist_exporters/netlist_exporter_generic.cpp
index 420d8e3..398e62f 100644
--- a/eeschema/netlist_exporters/netlist_exporter_generic.cpp
+++ b/eeschema/netlist_exporters/netlist_exporter_generic.cpp
@@ -489,79 +489,6 @@ XNODE* NETLIST_EXPORTER_GENERIC::makeListOfNets()
 }
 
 
-bool NETLIST_EXPORTER_GENERIC::writeListOfNets( FILE* f, NETLIST_OBJECT_LIST& aObjectsList )
-{
-int ret = 0;
-int netCode;
-int lastNetCode = -1;
-int sameNetcodeCount = 0;
-wxStringnetName;
-wxStringref;
-wxStringnetcodeName;
-charfirstItemInNet[256];
-
-for( unsigned ii = 0; ii < aObjectsList.size(); ii++ )
-{
-SCH_COMPONENT*  comp;
-NETLIST_OBJECT* nitem = aObjectsList[ii];
-
-// New net found, write net id;
-if( ( netCode = nitem->GetNet() ) != lastNetCode )
-{
-sameNetcodeCount = 0;  // Items count for this net
-netName = nitem->GetNetName();
-
-netcodeName.Printf( wxT( "Net %d " ), netCode );
-netcodeName << wxT( "\"" ) << netName << wxT( "\"" );
-
-// Add the netname without prefix, in cases we need only the
-// "short" netname
-netcodeName += wxT( " \"" ) + nitem->GetShortNetName() + wxT( "\"" );
-lastNetCode  = netCode;
-}
-
-if( nitem->m_Type != NET_PIN )
-continue;
-
-if( nitem->m_Flag != 0 ) // Redundant pin, skip it
-continue;
-
-comp = nitem->GetComponentParent();
-
-// Get the reference for the net name and the main parent component
-ref = comp->GetRef( >m_SheetPath );
-if( ref[0] == wxChar( '#' ) )
-continue; // Pseudo component (Like Power symbol)
-
-// Print the pin list for this net, use special handling if
-// 2 or more items are connected:
-
-// if first item for this net found, defer printing this connection
-// until a second item will is found
-if( ++sameNetcodeCount == 1 )
-{
-snprintf( firstItemInNet, sizeof(firstItemInNet), " %s %.4s\n",
-  TO_UTF8( ref ),
-  (const char*) [ii]->m_PinNum );
-}
-
-// Second item for this net found, print the Net name, and the
-// first item
-if( sameNetcodeCount == 2 )
-{
-ret |= fprintf( f, "%s\n", TO_UTF8( netcodeName ) );
-ret |= fputs( firstItemInNet, f );
-}
-
-if( sameNetcodeCount >= 2 )
-ret |= fprintf( f, " %s %.4s\n", TO_UTF8( ref ),
- (const char*) >m_PinNum );
-}
-
-return ret >= 0;
-}
-
-
 XNODE* NETLIST_EXPORTER_GENERIC::node( const wxString& aName, const wxString& aTextualContent /* = wxEmptyString*/ )
 {
 XNODE* n = new XNODE( wxXML_ELEMENT_NODE, aName );
diff --git a/eeschema/netlist_exporters/netlist_exporter_generic.h b/eeschema/netlist_exporters/netlist_exporter_generic.h
index 89d57d5..71d3e51 100644
--- a/eeschema/netlist_exporters/netlist_exporter_generic.h
+++ b/eeschema/netlist_exporters/netlist_exporter_generic.h
@@ -80,13 +80,6 @@ protected:
 XNODE* node( const wxString& aName, const wxString& aTextualContent = wxEmptyString );
 
 /**
- * Function writeGENERICListOfNets
- * writes out nets (ranked by Netcode), and elements that are
- * connected as part of that net.
- */
-bool writeListOfNets( FILE* f, NETLIST_OBJECT_LIST& aObjectsList );
-
-/**
  * Function makeGenericRoot
  * builds the entire document tree for the generic export.  This is factored
  * out here so we can write the tree in either S-expression file format
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH 09/16] Replace boost::shared_ptr with std::shared_ptr

[Simon Richter]

This is a simple 1:1 replacement for all cases where shared_ptr is not used
to point at an array (array handling is not in C++11).
---
 3d-viewer/3d_mesh_model.h  |  4 ++--
 common/gal/opengl/opengl_gal.cpp   |  2 +-
 common/geometry/hetriang.cpp   | 34 +-
 eeschema/class_libentry.h  |  7 +++
 eeschema/sch_component.h   |  5 ++---
 include/gal/cairo/cairo_gal.h  |  5 +++--
 include/gal/opengl/opengl_gal.h|  4 ++--
 include/gal/opengl/vertex_manager.h|  6 +++---
 include/painter.h  |  2 +-
 include/ttl/halfedge/hetriang.h|  9 -
 pcbnew/class_board_connected_item.h|  2 +-
 pcbnew/class_netclass.cpp  |  6 ++
 pcbnew/class_netclass.h|  5 +++--
 pcbnew/dialogs/dialog_design_rules.cpp |  4 +---
 pcbnew/drc_stuff.h |  4 ++--
 pcbnew/legacy_plugin.cpp   |  4 +---
 pcbnew/legacy_plugin.h |  4 +++-
 pcbnew/pcb_painter.h   |  3 ++-
 pcbnew/pcb_parser.cpp  |  4 +---
 pcbnew/ratsnest_data.cpp   | 13 ++---
 pcbnew/ratsnest_data.h |  4 ++--
 pcbnew/router/pns_optimizer.h  |  2 +-
 pcbnew/specctra.h  |  5 +++--
 pcbnew/tools/edit_points.h |  9 +
 pcbnew/tools/point_editor.cpp  |  5 ++---
 pcbnew/tools/point_editor.h|  9 +
 pcbnew/tools/selection_tool.cpp|  2 +-
 27 files changed, 79 insertions(+), 84 deletions(-)

diff --git a/3d-viewer/3d_mesh_model.h b/3d-viewer/3d_mesh_model.h
index 734789f..bc35e43 100644
--- a/3d-viewer/3d_mesh_model.h
+++ b/3d-viewer/3d_mesh_model.h
@@ -31,7 +31,6 @@
 #define __3D_MESH_MODEL_H__
 
 #include 
-#include 
 #include 
 #define GLM_FORCE_RADIANS
 #include 
@@ -39,10 +38,11 @@
 #include "3d_material.h"
 #include "3d_rendering/3d_render_raytracing/shapes3D/cbbox.h"
 
+
 class S3D_MESH;
 
 /** A smart pointer to an S3D_MESH object */
-typedef boost::shared_ptr S3D_MESH_PTR;
+typedef std::shared_ptr S3D_MESH_PTR;
 
 /** A container of smar S3D_MESH object pointers */
 typedef std::vector S3D_MESH_PTRS;
diff --git a/common/gal/opengl/opengl_gal.cpp b/common/gal/opengl/opengl_gal.cpp
index ed462b7..77d51a7 100644
--- a/common/gal/opengl/opengl_gal.cpp
+++ b/common/gal/opengl/opengl_gal.cpp
@@ -1034,7 +1034,7 @@ int OPENGL_GAL::BeginGroup()
 {
 isGrouping = true;
 
-boost::shared_ptr newItem( new VERTEX_ITEM( *cachedManager ) );
+std::shared_ptr newItem = std::make_shared( *cachedManager );
 int groupNumber = getNewGroupNumber();
 groups.insert( std::make_pair( groupNumber, newItem ) );
 
diff --git a/common/geometry/hetriang.cpp b/common/geometry/hetriang.cpp
index e5cf26c..8383a8e 100644
--- a/common/geometry/hetriang.cpp
+++ b/common/geometry/hetriang.cpp
@@ -46,8 +46,8 @@
 #include 
 #include 
 #include 
-#include 
 #include 
+#include 
 
 using namespace hed;
 
@@ -127,22 +127,22 @@ EDGE_PTR TRIANGULATION::InitTwoEnclosingTriangles( NODES_CONTAINER::iterator aFi
 double dx = ( xmax - xmin ) / fac;
 double dy = ( ymax - ymin ) / fac;
 
-NODE_PTR n1 = boost::make_shared( xmin - dx, ymin - dy );
-NODE_PTR n2 = boost::make_shared( xmax + dx, ymin - dy );
-NODE_PTR n3 = boost::make_shared( xmax + dx, ymax + dy );
-NODE_PTR n4 = boost::make_shared( xmin - dx, ymax + dy );
+NODE_PTR n1 = std::make_shared( xmin - dx, ymin - dy );
+NODE_PTR n2 = std::make_shared( xmax + dx, ymin - dy );
+NODE_PTR n3 = std::make_shared( xmax + dx, ymax + dy );
+NODE_PTR n4 = std::make_shared( xmin - dx, ymax + dy );
 
 // diagonal
-EDGE_PTR e1d = boost::make_shared();
-EDGE_PTR e2d = boost::make_shared();
+EDGE_PTR e1d = std::make_shared();
+EDGE_PTR e2d = std::make_shared();
 
 // lower triangle
-EDGE_PTR e11 = boost::make_shared();
-EDGE_PTR e12 = boost::make_shared();
+EDGE_PTR e11 = std::make_shared();
+EDGE_PTR e12 = std::make_shared();
 
 // upper triangle
-EDGE_PTR e21 = boost::make_shared();
-EDGE_PTR e22 = boost::make_shared();
+EDGE_PTR e21 = std::make_shared();
+EDGE_PTR e22 = std::make_shared();
 
 // lower triangle
 e1d->SetSourceNode( n3 );
@@ -453,12 +453,12 @@ EDGE_PTR TRIANGULATION::SplitTriangle( EDGE_PTR& aEdge, const NODE_PTR& aPoint )
 EDGE_PTR e3( e2->GetNextEdgeInFace() );
 NODE_PTR n3( e3->GetSourceNode() );
 
-EDGE_PTR e1_n = boost::make_shared();
-EDGE_PTR e11_n = boost::make_shared();
-EDGE_PTR e2_n = boost::make_shared();
-EDGE_PTR e22_n = boost::make_shared();
-EDGE_PTR e3_n = boost::make_shared();
-EDGE_PTR e33_n = boost::make_shared();
+EDGE_PTR e1_n = std::make_shared();
+EDGE_PTR e11_n = std::make_shared();
+EDGE_PTR e2_n = std::make_shared();
+EDGE_PTR e22_n = std::make_shared();
+EDGE_PTR e3_n = std::make_shared();
+EDGE_PTR e33_n 

[Kicad-developers] [PATCH 16/16] Clean up warnings from exception handlers

[Simon Richter]

The exception objects caught are either not referenced at all, or only in
debug builds. This avoids the warnings for the unused variables.
---
 eeschema/class_libentry.cpp| 2 +-
 eeschema/class_library.cpp | 4 ++--
 eeschema/cross-probing.cpp | 2 +-
 eeschema/dialogs/dialog_bom.cpp| 2 +-
 eeschema/eeschema_config.cpp   | 6 +++---
 eeschema/lib_export.cpp| 2 +-
 eeschema/project_rescue.cpp| 4 ++--
 eeschema/schframe.cpp  | 2 +-
 eeschema/symbedit.cpp  | 2 +-
 pcb_calculator/datafile_read_write.cpp | 2 +-
 pcbnew/class_module.cpp| 2 +-
 pcbnew/dialogs/wizard_add_fplib.cpp| 2 +-
 pcbnew/moduleframe.cpp | 8 
 utils/idftools/idf_parser.cpp  | 8 
 14 files changed, 24 insertions(+), 24 deletions(-)

diff --git a/eeschema/class_libentry.cpp b/eeschema/class_libentry.cpp
index eba64bd..31a629a 100644
--- a/eeschema/class_libentry.cpp
+++ b/eeschema/class_libentry.cpp
@@ -141,7 +141,7 @@ bool LIB_ALIAS::SaveDoc( OUTPUTFORMATTER& aFormatter )
 
 aFormatter.Print( 0, "$ENDCMP\n" );
 }
-catch( const IO_ERROR& ioe )
+catch( const IO_ERROR& )
 {
 return false;
 }
diff --git a/eeschema/class_library.cpp b/eeschema/class_library.cpp
index 31372db..b48c004 100644
--- a/eeschema/class_library.cpp
+++ b/eeschema/class_library.cpp
@@ -740,7 +740,7 @@ bool PART_LIB::Save( OUTPUTFORMATTER& aFormatter )
 
 aFormatter.Print( 0, "#\n#End Library\n" );
 }
-catch( const IO_ERROR& ioe )
+catch( const IO_ERROR& )
 {
 success = false;
 }
@@ -765,7 +765,7 @@ bool PART_LIB::SaveDocs( OUTPUTFORMATTER& aFormatter )
 
 aFormatter.Print( 0, "#\n#End Doc Library\n" );
 }
-catch( const IO_ERROR& ioe )
+catch( const IO_ERROR& )
 {
 success = false;
 }
diff --git a/eeschema/cross-probing.cpp b/eeschema/cross-probing.cpp
index 9c8a160..fd20144 100644
--- a/eeschema/cross-probing.cpp
+++ b/eeschema/cross-probing.cpp
@@ -210,7 +210,7 @@ void SCH_EDIT_FRAME::KiwayMailIn( KIWAY_EXPRESS& mail )
 {
 backAnnotateFootprints( payload );
 }
-catch( const IO_ERROR& ioe )
+catch( const IO_ERROR& DBG( ioe ) )
 {
 DBG( printf( "%s: ioe:%s\n", __func__, TO_UTF8( ioe.errorText ) );)
 }
diff --git a/eeschema/dialogs/dialog_bom.cpp b/eeschema/dialogs/dialog_bom.cpp
index 41bd13a..7cfc2f7 100644
--- a/eeschema/dialogs/dialog_bom.cpp
+++ b/eeschema/dialogs/dialog_bom.cpp
@@ -298,7 +298,7 @@ void DIALOG_BOM::installPluginsList()
 {
 cfg_parser.Parse();
 }
-catch( const IO_ERROR& ioe )
+catch( const IO_ERROR& )
 {
 //wxLogMessage( ioe.errorText );
 }
diff --git a/eeschema/eeschema_config.cpp b/eeschema/eeschema_config.cpp
index 89a72d8..db1c398 100644
--- a/eeschema/eeschema_config.cpp
+++ b/eeschema/eeschema_config.cpp
@@ -138,7 +138,7 @@ void LIB_EDIT_FRAME::InstallConfigFrame( wxCommandEvent& event )
 {
 PART_LIBS::LibNamesAndPaths( prj, false, _paths, _names );
 }
-catch( const IO_ERROR& ioe )
+catch( const IO_ERROR& DBG( ioe ) )
 {
 DBG(printf( "%s: %s\n", __func__, TO_UTF8( ioe.errorText ) );)
 return;
@@ -198,7 +198,7 @@ void SCH_EDIT_FRAME::InstallConfigFrame( wxCommandEvent& event )
 {
 PART_LIBS::LibNamesAndPaths( prj, false, _paths, _names );
 }
-catch( const IO_ERROR& ioe )
+catch( const IO_ERROR& DBG( ioe ) )
 {
 DBG(printf( "%s: %s\n", __func__, TO_UTF8( ioe.errorText ) );)
 return;
@@ -665,7 +665,7 @@ void SCH_EDIT_FRAME::LoadSettings( wxConfigBase* aCfg )
 {
 m_TemplateFieldNames.Parse(  );
 }
-catch( const IO_ERROR& e )
+catch( const IO_ERROR& DBG( e ) )
 {
 // @todo show error msg
 DBG( printf( "templatefieldnames parsing error: '%s'\n",
diff --git a/eeschema/lib_export.cpp b/eeschema/lib_export.cpp
index d4d5c1d..5f58cc2 100644
--- a/eeschema/lib_export.cpp
+++ b/eeschema/lib_export.cpp
@@ -66,7 +66,7 @@ void LIB_EDIT_FRAME::OnImportPart( wxCommandEvent& event )
 std::auto_ptr new_lib( PART_LIB::LoadLibrary( fn.GetFullPath() ) );
 lib = new_lib;
 }
-catch( const IO_ERROR& ioe )
+catch( const IO_ERROR& )
 {
 wxString msg = wxString::Format( _(
 "Unable to import library '%s'.  Error:\n"
diff --git a/eeschema/project_rescue.cpp b/eeschema/project_rescue.cpp
index f1fdd4e..86b1be0 100644
--- a/eeschema/project_rescue.cpp
+++ b/eeschema/project_rescue.cpp
@@ -132,12 +132,12 @@ static bool insert_library( PROJECT *aProject, PART_LIB *aLibrary, size_t aIndex
 {
 libs->LoadAllLibraries( aProject );
 }
-catch( const PARSE_ERROR& e )
+catch( const PARSE_ERROR& )
 {
 // Some libraries were not 

[Kicad-developers] [PATCH 15/16] Avoid switch with only default case

[Simon Richter]

These switch statements only have a single "default" case, so they are unneeded.
---
 bitmap2component/bitmap2cmp_gui.cpp | 10 +-
 pcb_calculator/pcb_calculator.cpp   | 12 +---
 2 files changed, 2 insertions(+), 20 deletions(-)

diff --git a/bitmap2component/bitmap2cmp_gui.cpp b/bitmap2component/bitmap2cmp_gui.cpp
index 5caa7a6..99ad647 100644
--- a/bitmap2component/bitmap2cmp_gui.cpp
+++ b/bitmap2component/bitmap2cmp_gui.cpp
@@ -672,15 +672,7 @@ static struct IFACE : public KIFACE_I
 
 wxWindow* CreateWindow( wxWindow* aParent, int aClassId, KIWAY* aKiway, int aCtlBits = 0 )
 {
-switch( aClassId )
-{
-
-default:
-{
-KIWAY_PLAYER* frame = new BM2CMP_FRAME( aKiway, aParent );
-return frame;
-}
-}
+return new BM2CMP_FRAME( aKiway, aParent );
 }
 
 /**
diff --git a/pcb_calculator/pcb_calculator.cpp b/pcb_calculator/pcb_calculator.cpp
index 6a9f970..384bc8e 100644
--- a/pcb_calculator/pcb_calculator.cpp
+++ b/pcb_calculator/pcb_calculator.cpp
@@ -61,17 +61,7 @@ static struct IFACE : public KIFACE_I
 
 wxWindow* CreateWindow( wxWindow* aParent, int aClassId, KIWAY* aKiway, int aCtlBits = 0 )
 {
-switch( aClassId )
-{
-default:
-{
-PCB_CALCULATOR_FRAME* frame = new PCB_CALCULATOR_FRAME( aKiway, aParent );
-return frame;
-}
-break;
-}
-
-return NULL;
+return new PCB_CALCULATOR_FRAME( aKiway, aParent );
 }
 
 /**
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH 08/16] Drop extra copy ctors from IFSG_NODE

[Simon Richter]

This is unnecessary -- explicitly specifying the regular copy ctor will
inhibit any generated versions anyway.
---
 include/plugins/3dapi/ifsg_node.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/plugins/3dapi/ifsg_node.h b/include/plugins/3dapi/ifsg_node.h
index 6b3641e..f949c80 100644
--- a/include/plugins/3dapi/ifsg_node.h
+++ b/include/plugins/3dapi/ifsg_node.h
@@ -62,9 +62,6 @@ public:
 
 // deleted operators
 IFSG_NODE( const IFSG_NODE& aParent ) = delete;
-IFSG_NODE( IFSG_NODE& aParent ) = delete;
-IFSG_NODE( volatile const IFSG_NODE& aParent ) = delete;
-IFSG_NODE( volatile IFSG_NODE& aParent ) = delete;
 IFSG_NODE& operator= ( const IFSG_NODE& ) = delete;
 
 /**
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] New stable version.

[Adam Wolf]

I really do appreciate user feedback but Apple's got me pulling my own hair
out this last month :)

On Tue, Jun 7, 2016, 2:56 PM Jean-Paul Louis  wrote:

> Thanks Adam and Simon,
>
> I was just spoiled with the nightly builds, and I should stop whining.
>
> Thanks for all the great work.
>
> I’ll check the testing folder and report if I find an issue
>
> Jean-Paul
> N1JPL
>
>
> > On Jun 7, 2016, at 1:55 PM, Simon Wells  wrote:
> >
> > there is a single one from june 2nd in the testing folder due to c++11
> > issues, They should resume past that soon though, just solving issues
> > with stable builds
> >
> > On Wed, Jun 8, 2016 at 5:50 AM, Jean-Paul Louis 
> wrote:
> >> Hi Adam,
> >>
> >> Yesterday, I wanted to update my OS X Kicad with the lated nightly, and
> I could not find
> >> anything more recent than May 6th.
> >>
> >> What happened to the nightlies?
> >>
> >> Just curious,
> >> Jean-Paul
> >> N1JPL
> >>
> >>
> >>
> >>> On Jun 7, 2016, at 1:02 PM, Adam Wolf 
> wrote:
> >>>
> >>> There's still at least a minor problem--the extras DMG has an invalid
> checksum.  We're close!
> >>>
> >>> On Tue, Jun 7, 2016 at 10:57 AM, Simon Wells 
> wrote:
> >>> do we want stable compatible with newer versions of cmake or is it not
> worth it?
> >>>
> >>> Also Adam are you able to test those python patches i sent through as
> >>> i would love to get the wxpython fix if not the python bundler in
> >>> 4.0.3
> >>>
> >>> thanks
> >>>
> >>> Simon
> >>>
> >>> On Wed, Jun 8, 2016 at 2:53 AM, Adam Wolf <
> adamw...@feelslikeburning.com> wrote:
>  Hi folks,
> 
>  I have finally gotten this to build.  There is a test build using the
> 4.0.2
>  artifacts and labeled 4.0.3-rc1, here:
>  http://downloads.kicad-pcb.org/osx/stable/kicad-4.0.3-rc1.dmg
> 
>  I updated from CMake 3.1.2 in order to build the C++11 stuff with the
>  nightlies.  I upgraded to CMake 3.5.2.  Upgrading to CMake 3.5.2
> breaks the
>  stable branch on OS X.  I downgraded to CMake 3.1.2 for this build,
> and...
>  
> 
>  Adam Wolf
>  Cofounder and Engineer
>  W
> 
>  On Thu, Jun 2, 2016 at 4:14 PM, Simon Wells 
> wrote:
> >
> > Sorry this was meant to be sent to the list not just to Adam
> >
> > Simon Asked:
> > which bug was it that required upgrading? is it one that may need to
> > up the minimum cmake version required in CMakeLists.txt?
> > -
> >
> > Adam Responded:
> >
> > I think so, especially on OS X.
> >
> > https://cmake.org/Bug/view.php?id=15355
> >
> > On Fri, Jun 3, 2016 at 5:29 AM, Adam Wolf <
> adamw...@feelslikeburning.com>
> > wrote:
> >> This is being hairy.
> >>
> >> I had to upgrade cmake on the system in order to get the nightly
> builds
> >> to
> >> continue working, due to a known bug in CMake, and now I'm having
> issues
> >> getting stable to build.  We're working through the issues, but it
> might
> >> be
> >> a bit longer.
> >>
> >> Adam Wolf
> >>
> >> On Fri, May 27, 2016 at 6:20 PM, Wayne Stambaugh <
> stambau...@gmail.com>
> >> wrote:
> >>>
> >>> Thanks Adam.
> >>>
> >>> On 5/27/2016 7:16 PM, Adam Wolf wrote:
>  I will try running a build this weekend.
> 
>  On Fri, May 27, 2016 at 3:59 PM, Wayne Stambaugh
>    > wrote:
> 
> I would like to push a 4.0.3 stable release in the couple of
>  weeks.
> Would one of our OSX devs please make sure the latest version
>  (r6281) of
> the stable 4 branch compiles and runs OK on OSX?  Once I have
>  some
> feedback, I'll create a source archive and make the
> announcement.
> 
> Thanks,
> 
> Wayne
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> >>>
> >>
> >>
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to : kicad-developers@lists.launchpad.net
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> >>
> 
> 
> >>>
> >>> ___
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to : kicad-developers@lists.launchpad.net
> >>> Unsubscribe : 

Re: [Kicad-developers] New stable version.

[Jean-Paul Louis]

Thanks Adam and Simon,

I was just spoiled with the nightly builds, and I should stop whining.

Thanks for all the great work.

I’ll check the testing folder and report if I find an issue

Jean-Paul
N1JPL


> On Jun 7, 2016, at 1:55 PM, Simon Wells  wrote:
> 
> there is a single one from june 2nd in the testing folder due to c++11
> issues, They should resume past that soon though, just solving issues
> with stable builds
> 
> On Wed, Jun 8, 2016 at 5:50 AM, Jean-Paul Louis  wrote:
>> Hi Adam,
>> 
>> Yesterday, I wanted to update my OS X Kicad with the lated nightly, and I 
>> could not find
>> anything more recent than May 6th.
>> 
>> What happened to the nightlies?
>> 
>> Just curious,
>> Jean-Paul
>> N1JPL
>> 
>> 
>> 
>>> On Jun 7, 2016, at 1:02 PM, Adam Wolf  wrote:
>>> 
>>> There's still at least a minor problem--the extras DMG has an invalid 
>>> checksum.  We're close!
>>> 
>>> On Tue, Jun 7, 2016 at 10:57 AM, Simon Wells  wrote:
>>> do we want stable compatible with newer versions of cmake or is it not 
>>> worth it?
>>> 
>>> Also Adam are you able to test those python patches i sent through as
>>> i would love to get the wxpython fix if not the python bundler in
>>> 4.0.3
>>> 
>>> thanks
>>> 
>>> Simon
>>> 
>>> On Wed, Jun 8, 2016 at 2:53 AM, Adam Wolf  
>>> wrote:
 Hi folks,
 
 I have finally gotten this to build.  There is a test build using the 4.0.2
 artifacts and labeled 4.0.3-rc1, here:
 http://downloads.kicad-pcb.org/osx/stable/kicad-4.0.3-rc1.dmg
 
 I updated from CMake 3.1.2 in order to build the C++11 stuff with the
 nightlies.  I upgraded to CMake 3.5.2.  Upgrading to CMake 3.5.2 breaks the
 stable branch on OS X.  I downgraded to CMake 3.1.2 for this build, and...
 
 
 Adam Wolf
 Cofounder and Engineer
 W
 
 On Thu, Jun 2, 2016 at 4:14 PM, Simon Wells  wrote:
> 
> Sorry this was meant to be sent to the list not just to Adam
> 
> Simon Asked:
> which bug was it that required upgrading? is it one that may need to
> up the minimum cmake version required in CMakeLists.txt?
> -
> 
> Adam Responded:
> 
> I think so, especially on OS X.
> 
> https://cmake.org/Bug/view.php?id=15355
> 
> On Fri, Jun 3, 2016 at 5:29 AM, Adam Wolf 
> wrote:
>> This is being hairy.
>> 
>> I had to upgrade cmake on the system in order to get the nightly builds
>> to
>> continue working, due to a known bug in CMake, and now I'm having issues
>> getting stable to build.  We're working through the issues, but it might
>> be
>> a bit longer.
>> 
>> Adam Wolf
>> 
>> On Fri, May 27, 2016 at 6:20 PM, Wayne Stambaugh 
>> wrote:
>>> 
>>> Thanks Adam.
>>> 
>>> On 5/27/2016 7:16 PM, Adam Wolf wrote:
 I will try running a build this weekend.
 
 On Fri, May 27, 2016 at 3:59 PM, Wayne Stambaugh
 > wrote:
 
I would like to push a 4.0.3 stable release in the couple of
 weeks.
Would one of our OSX devs please make sure the latest version
 (r6281) of
the stable 4 branch compiles and runs OK on OSX?  Once I have
 some
feedback, I'll create a source archive and make the announcement.
 
Thanks,
 
Wayne
 
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net

Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp
 
 
>>> 
>> 
>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>> 
 
 
>>> 
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH 13/16] Avoid static variable in wire merge

[Simon Richter]

There is little to no reason why this variable should be static, given that
it is cleared after each iteration.
---
 eeschema/sch_line.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/eeschema/sch_line.cpp b/eeschema/sch_line.cpp
index 72efb5c..050b786 100644
--- a/eeschema/sch_line.cpp
+++ b/eeschema/sch_line.cpp
@@ -346,8 +346,7 @@ bool SCH_LINE::MergeOverlap( SCH_LINE* aLine )
 // for horizontal segments the uppermost and the lowest point
 if( colinear )
 {
-static std::vector  candidates;
-candidates.clear();
+std::vector  candidates;
 candidates.push_back( _start );
 candidates.push_back( _end );
 candidates.push_back( >m_start );
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH 14/16] Reserve appropriate space in local vector

[Simon Richter]

This is just a speed optimization -- preallocate four items to avoid 
reallocations.
---
 eeschema/sch_line.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/eeschema/sch_line.cpp b/eeschema/sch_line.cpp
index 050b786..6d86b5d 100644
--- a/eeschema/sch_line.cpp
+++ b/eeschema/sch_line.cpp
@@ -347,6 +347,7 @@ bool SCH_LINE::MergeOverlap( SCH_LINE* aLine )
 if( colinear )
 {
 std::vector  candidates;
+candidates.reserve(4);
 candidates.push_back( _start );
 candidates.push_back( _end );
 candidates.push_back( >m_start );
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH 11/16] Clarify ownership semantics

[Simon Richter]

SCREEN objects are typically owned by the DRAW_FRAME they are attached to.

SCH_SCREEN objects may additionally be shared between one DRAW_FRAME, and
multiple SCH_SHEET objects, so they are reference counted.

To make this distinction more obvious, and avoid potential errors, move the
pointer into the derived DRAW_FRAME, with an appropriate smart pointer
type. This also avoids a few C-style casts and replaces them by compile
time checks.
---
 common/draw_frame.cpp   |  6 +
 eeschema/class_sch_screen.h | 32 --
 eeschema/sch_base_frame.cpp |  5 
 eeschema/sch_base_frame.h   |  6 -
 eeschema/sch_screen.cpp |  2 ++
 eeschema/sch_sheet.cpp  | 46 -
 eeschema/sch_sheet.h| 11 -
 eeschema/sheet.cpp  |  4 ++--
 gerbview/gerbview_frame.h   |  5 
 include/draw_frame.h|  6 +
 include/wxBasePcbFrame.h|  6 -
 pagelayout_editor/pl_editor_frame.h |  8 +++
 12 files changed, 64 insertions(+), 73 deletions(-)

diff --git a/common/draw_frame.cpp b/common/draw_frame.cpp
index b28e63d..fc6907e 100644
--- a/common/draw_frame.cpp
+++ b/common/draw_frame.cpp
@@ -141,7 +141,6 @@ EDA_DRAW_FRAME::EDA_DRAW_FRAME( KIWAY* aKiway, wxWindow* aParent,
 m_toolManager = NULL;
 m_toolDispatcher  = NULL;
 m_messagePanel= NULL;
-m_currentScreen   = NULL;
 m_toolId  = ID_NO_TOOL_SELECTED;
 m_lastDrawToolId  = ID_NO_TOOL_SELECTED;
 m_showAxis= false;  // true to draw axis.
@@ -214,9 +213,6 @@ EDA_DRAW_FRAME::~EDA_DRAW_FRAME()
 delete m_toolDispatcher;
 delete m_galCanvas;
 
-delete m_currentScreen;
-m_currentScreen = NULL;
-
 m_auimgr.UnInit();
 
 ReleaseFile();
@@ -553,7 +549,7 @@ wxPoint EDA_DRAW_FRAME::GetGridPosition( const wxPoint& aPosition ) const
 {
 wxPoint pos = aPosition;
 
-if( m_currentScreen != NULL && m_snapToGrid )
+if( GetScreen() != NULL && m_snapToGrid )
 pos = GetNearestGridPosition( aPosition );
 
 return pos;
diff --git a/eeschema/class_sch_screen.h b/eeschema/class_sch_screen.h
index 2fb4043..a6715f0 100644
--- a/eeschema/class_sch_screen.h
+++ b/eeschema/class_sch_screen.h
@@ -97,6 +97,15 @@ private:
  */
 void addConnectedItemsToBlock( const wxPoint& aPosition );
 
+~SCH_SCREEN();
+
+void DecRefCount();
+
+void IncRefCount();
+
+friend void intrusive_ptr_add_ref( SCH_SCREEN* );
+friend void intrusive_ptr_release( SCH_SCREEN* );
+
 public:
 
 /**
@@ -104,7 +113,10 @@ public:
  */
 SCH_SCREEN( KIWAY* aKiway );
 
-~SCH_SCREEN();
+bool IsShared() const
+{
+return m_refCount > 1;
+}
 
 virtual wxString GetClass() const
 {
@@ -125,12 +137,6 @@ public:
 //TITLE_BLOCK& GetTitleBlock() const  { return (TITLE_BLOCK&) m_titles; }
 void SetTitleBlock( const TITLE_BLOCK& aTitleBlock ){ m_titles = aTitleBlock; }
 
-void DecRefCount();
-
-void IncRefCount();
-
-int GetRefCount() const { return m_refCount; }
-
 /**
  * Function GetDrawItems().
  * @return - A pointer to the first item in the linked list of draw items.
@@ -526,6 +532,18 @@ public:
 };
 
 
+inline void intrusive_ptr_add_ref( SCH_SCREEN *a_screen )
+{
+a_screen->IncRefCount();
+}
+
+
+inline void intrusive_ptr_release( SCH_SCREEN *a_screen )
+{
+a_screen->DecRefCount();
+}
+
+
 /**
  * Class SCH_SCREENS
  * is a container class that holds multiple SCH_SCREENs in a hierarchy.
diff --git a/eeschema/sch_base_frame.cpp b/eeschema/sch_base_frame.cpp
index 52898e8..fb5ed60 100644
--- a/eeschema/sch_base_frame.cpp
+++ b/eeschema/sch_base_frame.cpp
@@ -75,11 +75,6 @@ void SCH_BASE_FRAME::SetDrawBgColor( EDA_COLOR_T aColor)
 }
 
 
-SCH_SCREEN* SCH_BASE_FRAME::GetScreen() const
-{
-return (SCH_SCREEN*) EDA_DRAW_FRAME::GetScreen();
-}
-
 const wxString SCH_BASE_FRAME::GetZoomLevelIndicator() const
 {
 return EDA_DRAW_FRAME::GetZoomLevelIndicator();
diff --git a/eeschema/sch_base_frame.h b/eeschema/sch_base_frame.h
index c99e1a6..4ec7509 100644
--- a/eeschema/sch_base_frame.h
+++ b/eeschema/sch_base_frame.h
@@ -27,6 +27,8 @@
 #include 
 #include 
 
+#include 
+
 class PAGE_INFO;
 class TITLE_BLOCK;
 class LIB_VIEW_FRAME;
@@ -53,6 +55,7 @@ protected:
 int  m_repeatDeltaLabel;///< the increment value of labels like bus members
 ///< when they are repeated
 
+boost::intrusive_ptr   m_screen;
 
 public:
 SCH_BASE_FRAME( KIWAY* aKiway, wxWindow* aParent,
@@ -61,7 +64,8 @@ public:
 const wxPoint& aPosition, const wxSize& aSize,
 long aStyle, const wxString & aFrameName );
 
-SCH_SCREEN* GetScreen() const;  // overload EDA_DRAW_FRAME
+

[Kicad-developers] [PATCH 10/16] Replace unshared boost::shared_array with std::unique_ptr

[Simon Richter]

These are never shared, so std::unique_ptr works fine, and std::unique_ptr
has a specialisation for array types that uses "operator delete[]", so this
is still correct.
---
 common/gal/opengl/opengl_gal.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/gal/opengl/opengl_gal.cpp b/common/gal/opengl/opengl_gal.cpp
index 77d51a7..c3fbfee 100644
--- a/common/gal/opengl/opengl_gal.cpp
+++ b/common/gal/opengl/opengl_gal.cpp
@@ -633,7 +633,7 @@ void OPENGL_GAL::DrawPolygon( const std::deque& aPointList )
 gluTessBeginPolygon( tesselator,  );
 gluTessBeginContour( tesselator );
 
-boost::shared_array points( new GLdouble[3 * aPointList.size()] );
+std::unique_ptr points( new GLdouble[ 3 * aPointList.size() ] );
 int v = 0;
 
 for( std::deque::const_iterator it = aPointList.begin(); it != aPointList.end(); ++it )
@@ -666,7 +666,7 @@ void OPENGL_GAL::DrawPolygon( const VECTOR2D aPointList[], int aListSize )
 gluTessBeginPolygon( tesselator,  );
 gluTessBeginContour( tesselator );
 
-boost::shared_array points( new GLdouble[3 * aListSize] );
+std::unique_ptr points( new GLdouble[3 * aListSize] );
 int v = 0;
 const VECTOR2D* ptr = aPointList;
 
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH 12/16] Make NETLIST_OBJECT::GetConnectionType() const

[Simon Richter]

This function does not need to modify object state.
---
 eeschema/class_netlist_object.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eeschema/class_netlist_object.h b/eeschema/class_netlist_object.h
index 9608f90..403bade 100644
--- a/eeschema/class_netlist_object.h
+++ b/eeschema/class_netlist_object.h
@@ -156,7 +156,7 @@ public:
 m_ConnectionType = aFlg;
 }
 
-NET_CONNECTION_T GetConnectionType()
+NET_CONNECTION_T GetConnectionType() const
 {
 return m_ConnectionType;
 }
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH 00/16] Simple patches

[Simon Richter]

Hi,

this is a stack of simple patches that should not actually have much of an
effect on the generated code -- these are mostly cleanups and readability
improvements.

These should be ready to be merged, given that I've been using a build with
these included for quite some time now.

   Simon

Simon Richter (16):
  Fix spelling "propage" -> "propagate"
  Add missing dependency github_plugin -> pcbcommon
  Clarify ERC: we're iterating netlist items, not nets
  Explain how ERC works.
  Cache netlist item during ERC
  Check sorting of netlist during ERC
  Kill unused NETLIST_EXPORTER_GENERIC::writeListOfNets
  Drop extra copy ctors from IFSG_NODE
  Replace boost::shared_ptr with std::shared_ptr
  Replace unshared boost::shared_array with std::unique_ptr
  Clarify ownership semantics
  Make NETLIST_OBJECT::GetConnectionType() const
  Avoid static variable in wire merge
  Reserve appropriate space in local vector
  Avoid switch with only default case
  Clean up warnings from exception handlers

 3d-viewer/3d_mesh_model.h  |  4 +-
 bitmap2component/bitmap2cmp_gui.cpp| 10 +--
 common/draw_frame.cpp  |  6 +-
 common/gal/opengl/opengl_gal.cpp   |  6 +-
 common/geometry/hetriang.cpp   | 34 +-
 eeschema/class_libentry.cpp|  2 +-
 eeschema/class_libentry.h  |  7 +--
 eeschema/class_library.cpp |  4 +-
 eeschema/class_netlist_object.h|  4 +-
 eeschema/class_sch_screen.h| 32 +++---
 eeschema/cross-probing.cpp |  2 +-
 eeschema/dialogs/dialog_bom.cpp|  2 +-
 eeschema/dialogs/dialog_erc.cpp| 47 +-
 eeschema/eeschema_config.cpp   |  6 +-
 eeschema/lib_export.cpp|  2 +-
 eeschema/netlist.cpp   | 16 ++---
 .../netlist_exporters/netlist_exporter_generic.cpp | 73 --
 .../netlist_exporters/netlist_exporter_generic.h   |  7 ---
 eeschema/project_rescue.cpp|  4 +-
 eeschema/sch_base_frame.cpp|  5 --
 eeschema/sch_base_frame.h  |  6 +-
 eeschema/sch_component.h   |  5 +-
 eeschema/sch_line.cpp  |  4 +-
 eeschema/sch_screen.cpp|  2 +
 eeschema/sch_sheet.cpp | 46 +++---
 eeschema/sch_sheet.h   | 11 ++--
 eeschema/schframe.cpp  |  2 +-
 eeschema/sheet.cpp |  4 +-
 eeschema/symbedit.cpp  |  2 +-
 gerbview/gerbview_frame.h  |  5 ++
 include/draw_frame.h   |  6 +-
 include/gal/cairo/cairo_gal.h  |  5 +-
 include/gal/opengl/opengl_gal.h|  4 +-
 include/gal/opengl/vertex_manager.h|  6 +-
 include/painter.h  |  2 +-
 include/plugins/3dapi/ifsg_node.h  |  3 -
 include/ttl/halfedge/hetriang.h|  9 ++-
 include/wxBasePcbFrame.h   |  6 +-
 pagelayout_editor/pl_editor_frame.h|  8 +--
 pcb_calculator/datafile_read_write.cpp |  2 +-
 pcb_calculator/pcb_calculator.cpp  | 12 +---
 pcbnew/CMakeLists.txt  |  2 +
 pcbnew/class_board_connected_item.h|  2 +-
 pcbnew/class_module.cpp|  2 +-
 pcbnew/class_netclass.cpp  |  6 +-
 pcbnew/class_netclass.h|  5 +-
 pcbnew/dialogs/dialog_design_rules.cpp |  4 +-
 pcbnew/dialogs/wizard_add_fplib.cpp|  2 +-
 pcbnew/drc_stuff.h |  4 +-
 pcbnew/legacy_plugin.cpp   |  4 +-
 pcbnew/legacy_plugin.h |  4 +-
 pcbnew/moduleframe.cpp |  8 +--
 pcbnew/pcb_painter.h   |  3 +-
 pcbnew/pcb_parser.cpp  |  4 +-
 pcbnew/ratsnest_data.cpp   | 13 ++--
 pcbnew/ratsnest_data.h |  4 +-
 pcbnew/router/pns_optimizer.h  |  2 +-
 pcbnew/specctra.h  |  5 +-
 pcbnew/tools/edit_points.h |  9 +--
 pcbnew/tools/point_editor.cpp  |  5 +-
 pcbnew/tools/point_editor.h|  9 +--
 pcbnew/tools/selection_tool.cpp|  2 +-
 utils/idftools/idf_parser.cpp  |  8 +--
 63 files changed, 218 insertions(+), 312 deletions(-)

-- 
2.1.4

___
Mailing list: 

[Kicad-developers] [PATCH 03/16] Clarify ERC: we're iterating netlist items, not nets

[Simon Richter]

This renames the "net", "lastNet" and "nextNet" variables to "item",
"lastItem" and "nextItem", respectively, because these refer to netlist
items, not nets.
---
 eeschema/dialogs/dialog_erc.cpp | 26 +-
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/eeschema/dialogs/dialog_erc.cpp b/eeschema/dialogs/dialog_erc.cpp
index c709c15..2f9a1f2 100644
--- a/eeschema/dialogs/dialog_erc.cpp
+++ b/eeschema/dialogs/dialog_erc.cpp
@@ -492,21 +492,21 @@ void DIALOG_ERC::TestErc( wxArrayString* aMessagesList )
 // Reset the connection type indicator
 objectsConnectedList->ResetConnectionsType();
 
-unsigned lastNet;
-unsigned nextNet = lastNet = 0;
+unsigned lastItem;
+unsigned nextItem = lastItem = 0;
 int MinConn= NOC;
 
-for( unsigned net = 0; net < objectsConnectedList->size(); net++ )
+for( unsigned item = 0; item < objectsConnectedList->size(); item++ )
 {
-if( objectsConnectedList->GetItemNet( lastNet ) !=
-objectsConnectedList->GetItemNet( net ) )
+if( objectsConnectedList->GetItemNet( lastItem ) !=
+objectsConnectedList->GetItemNet( item ) )
 {
 // New net found:
 MinConn= NOC;
-nextNet   = net;
+nextItem   = item;
 }
 
-switch( objectsConnectedList->GetItemType( net ) )
+switch( objectsConnectedList->GetItemType( item ) )
 {
 // These items do not create erc problems
 case NET_ITEM_UNSPECIFIED:
@@ -526,11 +526,11 @@ void DIALOG_ERC::TestErc( wxArrayString* aMessagesList )
 // ERC problems when pin sheets do not match hierarchical labels.
 // Each pin sheet must match a hierarchical label
 // Each hierarchical label must match a pin sheet
-objectsConnectedList->TestforNonOrphanLabel( net, nextNet );
+objectsConnectedList->TestforNonOrphanLabel( item, nextItem );
 break;
 case NET_GLOBLABEL:
 if( m_tstUniqueGlobalLabels )
-objectsConnectedList->TestforNonOrphanLabel( net, nextNet );
+objectsConnectedList->TestforNonOrphanLabel( item, nextItem );
 break;
 
 case NET_NOCONNECT:
@@ -538,19 +538,19 @@ void DIALOG_ERC::TestErc( wxArrayString* aMessagesList )
 // ERC problems when a noconnect symbol is connected to more than one pin.
 MinConn = NET_NC;
 
-if( objectsConnectedList->CountPinsInNet( nextNet ) > 1 )
-Diagnose( objectsConnectedList->GetItem( net ), NULL, MinConn, UNC );
+if( objectsConnectedList->CountPinsInNet( nextItem ) > 1 )
+Diagnose( objectsConnectedList->GetItem( item ), NULL, MinConn, UNC );
 
 break;
 
 case NET_PIN:
 
 // Look for ERC problems between pins:
-TestOthersItems( objectsConnectedList.get(), net, nextNet,  );
+TestOthersItems( objectsConnectedList.get(), item, nextItem,  );
 break;
 }
 
-lastNet = net;
+lastItem = item;
 }
 
 // Test similar labels (i;e. labels which are identical when
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH 02/16] Add missing dependency github_plugin -> pcbcommon

[Simon Richter]

The GitHub plugin needs the generated PCB parser code, so introduce an
artificial dependency.
---
 pcbnew/CMakeLists.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/pcbnew/CMakeLists.txt b/pcbnew/CMakeLists.txt
index e77cbd9..aea5469 100644
--- a/pcbnew/CMakeLists.txt
+++ b/pcbnew/CMakeLists.txt
@@ -534,6 +534,8 @@ add_subdirectory( pcad2kicadpcb_plugin )
 if( BUILD_GITHUB_PLUGIN )
 add_subdirectory( github )
 add_dependencies( github_plugin lib-dependencies )
+# github_plugin depends on make_lexer outputs in common
+add_dependencies( github_plugin pcbcommon )
 endif()
 
 
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH 04/16] Explain how ERC works.

[Simon Richter]

This is just a comment explaining the use of the local variables.
---
 eeschema/dialogs/dialog_erc.cpp | 9 +
 1 file changed, 9 insertions(+)

diff --git a/eeschema/dialogs/dialog_erc.cpp b/eeschema/dialogs/dialog_erc.cpp
index 2f9a1f2..7323a64 100644
--- a/eeschema/dialogs/dialog_erc.cpp
+++ b/eeschema/dialogs/dialog_erc.cpp
@@ -496,6 +496,15 @@ void DIALOG_ERC::TestErc( wxArrayString* aMessagesList )
 unsigned nextItem = lastItem = 0;
 int MinConn= NOC;
 
+/** The netlist generated by SCH_EDIT_FRAME::BuildNetListBase is sorted
+ * by net number, which means we can group netlist items into ranges
+ * that live in the same net. The range from nextItem to the current
+ * item (exclusive) needs to be checked against the current item. The
+ * lastItem variable is used as a helper to pass the last item's number
+ * from one loop iteration to the next, which simplifies the initial
+ * pass.
+ */
+
 for( unsigned item = 0; item < objectsConnectedList->size(); item++ )
 {
 if( objectsConnectedList->GetItemNet( lastItem ) !=
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH 06/16] Check sorting of netlist during ERC

[Simon Richter]

The ERC code depends on netlist items to be sorted by net code, so verify
that in debug builds. While this condition is stricter than necessary, it
should still hold with the current code, and provide a good canary if a
change to the sorting code might break ERC.
---
 eeschema/dialogs/dialog_erc.cpp | 10 +-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/eeschema/dialogs/dialog_erc.cpp b/eeschema/dialogs/dialog_erc.cpp
index 90ff1e9..db4596b 100644
--- a/eeschema/dialogs/dialog_erc.cpp
+++ b/eeschema/dialogs/dialog_erc.cpp
@@ -49,6 +49,9 @@
 #include 
 #include 
 
+#include 
+
+
 extern int   DiagErc[PINTYPE_COUNT][PINTYPE_COUNT];
 extern int   DefaultDiagErc[PINTYPE_COUNT][PINTYPE_COUNT];
 
@@ -510,7 +513,12 @@ void DIALOG_ERC::TestErc( wxArrayString* aMessagesList )
 auto item = objectsConnectedList->GetItem( item_idx );
 auto lastItem = objectsConnectedList->GetItem( lastItem_idx );
 
-if( lastItem->GetNet() != item->GetNet() )
+auto lastNet = lastItem->GetNet();
+auto net = item->GetNet();
+
+wxASSERT_MSG( lastNet <= net, wxT( "Netlist not correctly ordered" ) );
+
+if( lastNet != net )
 {
 // New net found:
 MinConn  = NOC;
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH 05/16] Cache netlist item during ERC

[Simon Richter]

This adds a suffix "_idx" to the indexes into the list, and introduces local
copies of the pointers to the objects we are looking at, in order to have a
shorter way of addressing them.
---
 eeschema/dialogs/dialog_erc.cpp | 30 --
 1 file changed, 16 insertions(+), 14 deletions(-)

diff --git a/eeschema/dialogs/dialog_erc.cpp b/eeschema/dialogs/dialog_erc.cpp
index 7323a64..90ff1e9 100644
--- a/eeschema/dialogs/dialog_erc.cpp
+++ b/eeschema/dialogs/dialog_erc.cpp
@@ -492,8 +492,8 @@ void DIALOG_ERC::TestErc( wxArrayString* aMessagesList )
 // Reset the connection type indicator
 objectsConnectedList->ResetConnectionsType();
 
-unsigned lastItem;
-unsigned nextItem = lastItem = 0;
+unsigned lastItem_idx;
+unsigned nextItem_idx = lastItem_idx = 0;
 int MinConn= NOC;
 
 /** The netlist generated by SCH_EDIT_FRAME::BuildNetListBase is sorted
@@ -505,17 +505,19 @@ void DIALOG_ERC::TestErc( wxArrayString* aMessagesList )
  * pass.
  */
 
-for( unsigned item = 0; item < objectsConnectedList->size(); item++ )
+for( unsigned item_idx = 0; item_idx < objectsConnectedList->size(); item_idx++ )
 {
-if( objectsConnectedList->GetItemNet( lastItem ) !=
-objectsConnectedList->GetItemNet( item ) )
+auto item = objectsConnectedList->GetItem( item_idx );
+auto lastItem = objectsConnectedList->GetItem( lastItem_idx );
+
+if( lastItem->GetNet() != item->GetNet() )
 {
 // New net found:
-MinConn= NOC;
-nextItem   = item;
+MinConn  = NOC;
+nextItem_idx = item_idx;
 }
 
-switch( objectsConnectedList->GetItemType( item ) )
+switch( item->m_Type )
 {
 // These items do not create erc problems
 case NET_ITEM_UNSPECIFIED:
@@ -535,11 +537,11 @@ void DIALOG_ERC::TestErc( wxArrayString* aMessagesList )
 // ERC problems when pin sheets do not match hierarchical labels.
 // Each pin sheet must match a hierarchical label
 // Each hierarchical label must match a pin sheet
-objectsConnectedList->TestforNonOrphanLabel( item, nextItem );
+objectsConnectedList->TestforNonOrphanLabel( item_idx, nextItem_idx );
 break;
 case NET_GLOBLABEL:
 if( m_tstUniqueGlobalLabels )
-objectsConnectedList->TestforNonOrphanLabel( item, nextItem );
+objectsConnectedList->TestforNonOrphanLabel( item_idx, nextItem_idx );
 break;
 
 case NET_NOCONNECT:
@@ -547,19 +549,19 @@ void DIALOG_ERC::TestErc( wxArrayString* aMessagesList )
 // ERC problems when a noconnect symbol is connected to more than one pin.
 MinConn = NET_NC;
 
-if( objectsConnectedList->CountPinsInNet( nextItem ) > 1 )
-Diagnose( objectsConnectedList->GetItem( item ), NULL, MinConn, UNC );
+if( objectsConnectedList->CountPinsInNet( nextItem_idx ) > 1 )
+Diagnose( item, NULL, MinConn, UNC );
 
 break;
 
 case NET_PIN:
 
 // Look for ERC problems between pins:
-TestOthersItems( objectsConnectedList.get(), item, nextItem,  );
+TestOthersItems( objectsConnectedList.get(), item_idx, nextItem_idx,  );
 break;
 }
 
-lastItem = item;
+lastItem_idx = item_idx;
 }
 
 // Test similar labels (i;e. labels which are identical when
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Python build options

[Wayne Stambaugh]

I always thought the Phoenix project was just the name given to the
python 3 port of wxPython but maybe they are renaming it.  I didn't see
a package for it in Debain Sid so I wont hold my breath for it to be
packaged any time soon.  I'm not sure I want to spend the time to see if
I can get it to build on with mingw32 or mingw64.  At this point, the
3.0.2 version suites our needs just fine.  Hopefully they will keep up
with the wxWidgets development and have a release around the same time
as wxWidgets 3.2.

On 6/7/2016 3:02 PM, Simon Wells wrote:
> well i THINK wxpython is being replaced with
> https://github.com/wxWidgets/Phoenix which seems to be realtively
> active
> 
> On Wed, Jun 8, 2016 at 6:55 AM, jp charras  wrote:
>> Le 07/06/2016 à 20:31, Wayne Stambaugh a écrit :
>>> wxPython is (was?) the problem child.  When the python scripting was
>>> originally written, wxPython wasn't always provided in a usable form on
>>> all platforms (think Windows with native python) so we had to be able to
>>> provide a python pcbnew library without wxPython support.  Since the
>>> advent of the msys2 project, this is much less of an issue.  I'm not
>>> sure merging these all into a single build option is completely risk free.
>>
>> Yes, wxPython support is a serious problem, not only on Windows, but on all 
>> platforms.
>>
>> To be able to build Kicad without wxPython support is *mandatory*, for 
>> instance to be able to try
>> new versions of wxWidgets, or fix a wxWidgets issue (it happens sometimes 
>> ...), and rebuild
>> wxWidgets (obviously without wxPython support, because it does not exist).
>>
>> But only 2 options (DKICAD_SCRIPTING=ON/OFF (with modules generation) and
>> -DKICAD_SCRIPTING_WXPYTHON=ON/OFF) could be enough for me.
>> ( building Kicad without python support is also mandatory, because it is 
>> *really* faster, and useful
>> for testing purposes)
>>
>> Currently I am using:
>> KICAD_SCRIPTING_MODULES=ON or OFF (ON for usual build, OFF for testing 
>> builds)
>> and
>> -DKICAD_SCRIPTING_WXPYTHON=ON (sometimes) or OFF (usually).
>>
>>
>>>
>>> On 6/7/2016 2:25 PM, Nick Østergaard wrote:
 What about one that just enables all three, for example -DKICAD_PYTHON?

 And it would enable?
 -DKICAD_SCRIPTING=ON -DKICAD_SCRIPTING_MODULES=ON 
 -DKICAD_SCRIPTING_WXPYTHON=ON


 2016-06-07 20:24 GMT+02:00 Simon Wells :
> Is there anyone who doesn't use All or None of the python build
> options? As with how codependent a lot of the code has become it seems
> pointless still having the 3 build options. Would it not be better to
> just have one saying -DKICAD_PYTHON or -DKICAD_SCRIPTING?
>
> Simon
>>>
>>
>>
>> --
>> Jean-Pierre CHARRAS
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Python build options

[Simon Wells]

well i THINK wxpython is being replaced with
https://github.com/wxWidgets/Phoenix which seems to be realtively
active

On Wed, Jun 8, 2016 at 6:55 AM, jp charras  wrote:
> Le 07/06/2016 à 20:31, Wayne Stambaugh a écrit :
>> wxPython is (was?) the problem child.  When the python scripting was
>> originally written, wxPython wasn't always provided in a usable form on
>> all platforms (think Windows with native python) so we had to be able to
>> provide a python pcbnew library without wxPython support.  Since the
>> advent of the msys2 project, this is much less of an issue.  I'm not
>> sure merging these all into a single build option is completely risk free.
>
> Yes, wxPython support is a serious problem, not only on Windows, but on all 
> platforms.
>
> To be able to build Kicad without wxPython support is *mandatory*, for 
> instance to be able to try
> new versions of wxWidgets, or fix a wxWidgets issue (it happens sometimes 
> ...), and rebuild
> wxWidgets (obviously without wxPython support, because it does not exist).
>
> But only 2 options (DKICAD_SCRIPTING=ON/OFF (with modules generation) and
> -DKICAD_SCRIPTING_WXPYTHON=ON/OFF) could be enough for me.
> ( building Kicad without python support is also mandatory, because it is 
> *really* faster, and useful
> for testing purposes)
>
> Currently I am using:
> KICAD_SCRIPTING_MODULES=ON or OFF (ON for usual build, OFF for testing builds)
> and
> -DKICAD_SCRIPTING_WXPYTHON=ON (sometimes) or OFF (usually).
>
>
>>
>> On 6/7/2016 2:25 PM, Nick Østergaard wrote:
>>> What about one that just enables all three, for example -DKICAD_PYTHON?
>>>
>>> And it would enable?
>>> -DKICAD_SCRIPTING=ON -DKICAD_SCRIPTING_MODULES=ON 
>>> -DKICAD_SCRIPTING_WXPYTHON=ON
>>>
>>>
>>> 2016-06-07 20:24 GMT+02:00 Simon Wells :
 Is there anyone who doesn't use All or None of the python build
 options? As with how codependent a lot of the code has become it seems
 pointless still having the 3 build options. Would it not be better to
 just have one saying -DKICAD_PYTHON or -DKICAD_SCRIPTING?

 Simon
>>
>
>
> --
> Jean-Pierre CHARRAS
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Python build options

[jp charras]

Le 07/06/2016 à 20:31, Wayne Stambaugh a écrit :
> wxPython is (was?) the problem child.  When the python scripting was
> originally written, wxPython wasn't always provided in a usable form on
> all platforms (think Windows with native python) so we had to be able to
> provide a python pcbnew library without wxPython support.  Since the
> advent of the msys2 project, this is much less of an issue.  I'm not
> sure merging these all into a single build option is completely risk free.

Yes, wxPython support is a serious problem, not only on Windows, but on all 
platforms.

To be able to build Kicad without wxPython support is *mandatory*, for instance 
to be able to try
new versions of wxWidgets, or fix a wxWidgets issue (it happens sometimes ...), 
and rebuild
wxWidgets (obviously without wxPython support, because it does not exist).

But only 2 options (DKICAD_SCRIPTING=ON/OFF (with modules generation) and
-DKICAD_SCRIPTING_WXPYTHON=ON/OFF) could be enough for me.
( building Kicad without python support is also mandatory, because it is 
*really* faster, and useful
for testing purposes)

Currently I am using:
KICAD_SCRIPTING_MODULES=ON or OFF (ON for usual build, OFF for testing builds)
and
-DKICAD_SCRIPTING_WXPYTHON=ON (sometimes) or OFF (usually).


> 
> On 6/7/2016 2:25 PM, Nick Østergaard wrote:
>> What about one that just enables all three, for example -DKICAD_PYTHON?
>>
>> And it would enable?
>> -DKICAD_SCRIPTING=ON -DKICAD_SCRIPTING_MODULES=ON 
>> -DKICAD_SCRIPTING_WXPYTHON=ON
>>
>>
>> 2016-06-07 20:24 GMT+02:00 Simon Wells :
>>> Is there anyone who doesn't use All or None of the python build
>>> options? As with how codependent a lot of the code has become it seems
>>> pointless still having the 3 build options. Would it not be better to
>>> just have one saying -DKICAD_PYTHON or -DKICAD_SCRIPTING?
>>>
>>> Simon
>


-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Python build options

[Wayne Stambaugh]

I wasn't a matter of finding the interpreter.  It was a matter of
building wxPython with mingw.  Once Brian wrote the kicad-winbuilder,
there was a way to build python and wxpython with mingw that could be
used to build kicad on windows.  Up to that point, Linux was the only
platform where kicad could be built with wxPython support.  On windows
and I believe early OSX builds, wxPython was not an option.  It took a
Herculean effort to get wxPython in a form that was useful to build kicad.

To be honest, I'm not sure wxPython is even being developed anymore.
AFAIK, it still hasn't been ported to python 3 and the last release was
3.0.2 in November of 2014.

On 6/7/2016 2:37 PM, Simon Wells wrote:
> is that not what all the mingw stuff in the FindPythonInterp.cmake
> script was for? or is it different again?
> 
> On Wed, Jun 8, 2016 at 6:31 AM, Wayne Stambaugh  wrote:
>> wxPython is (was?) the problem child.  When the python scripting was
>> originally written, wxPython wasn't always provided in a usable form on
>> all platforms (think Windows with native python) so we had to be able to
>> provide a python pcbnew library without wxPython support.  Since the
>> advent of the msys2 project, this is much less of an issue.  I'm not
>> sure merging these all into a single build option is completely risk free.
>>
>> On 6/7/2016 2:25 PM, Nick Østergaard wrote:
>>> What about one that just enables all three, for example -DKICAD_PYTHON?
>>>
>>> And it would enable?
>>> -DKICAD_SCRIPTING=ON -DKICAD_SCRIPTING_MODULES=ON 
>>> -DKICAD_SCRIPTING_WXPYTHON=ON
>>>
>>>
>>> 2016-06-07 20:24 GMT+02:00 Simon Wells :
 Is there anyone who doesn't use All or None of the python build
 options? As with how codependent a lot of the code has become it seems
 pointless still having the 3 build options. Would it not be better to
 just have one saying -DKICAD_PYTHON or -DKICAD_SCRIPTING?

 Simon

 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Python build options

[Simon Wells]

is that not what all the mingw stuff in the FindPythonInterp.cmake
script was for? or is it different again?

On Wed, Jun 8, 2016 at 6:31 AM, Wayne Stambaugh  wrote:
> wxPython is (was?) the problem child.  When the python scripting was
> originally written, wxPython wasn't always provided in a usable form on
> all platforms (think Windows with native python) so we had to be able to
> provide a python pcbnew library without wxPython support.  Since the
> advent of the msys2 project, this is much less of an issue.  I'm not
> sure merging these all into a single build option is completely risk free.
>
> On 6/7/2016 2:25 PM, Nick Østergaard wrote:
>> What about one that just enables all three, for example -DKICAD_PYTHON?
>>
>> And it would enable?
>> -DKICAD_SCRIPTING=ON -DKICAD_SCRIPTING_MODULES=ON 
>> -DKICAD_SCRIPTING_WXPYTHON=ON
>>
>>
>> 2016-06-07 20:24 GMT+02:00 Simon Wells :
>>> Is there anyone who doesn't use All or None of the python build
>>> options? As with how codependent a lot of the code has become it seems
>>> pointless still having the 3 build options. Would it not be better to
>>> just have one saying -DKICAD_PYTHON or -DKICAD_SCRIPTING?
>>>
>>> Simon
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Python build options

[Wayne Stambaugh]

wxPython is (was?) the problem child.  When the python scripting was
originally written, wxPython wasn't always provided in a usable form on
all platforms (think Windows with native python) so we had to be able to
provide a python pcbnew library without wxPython support.  Since the
advent of the msys2 project, this is much less of an issue.  I'm not
sure merging these all into a single build option is completely risk free.

On 6/7/2016 2:25 PM, Nick Østergaard wrote:
> What about one that just enables all three, for example -DKICAD_PYTHON?
> 
> And it would enable?
> -DKICAD_SCRIPTING=ON -DKICAD_SCRIPTING_MODULES=ON 
> -DKICAD_SCRIPTING_WXPYTHON=ON
> 
> 
> 2016-06-07 20:24 GMT+02:00 Simon Wells :
>> Is there anyone who doesn't use All or None of the python build
>> options? As with how codependent a lot of the code has become it seems
>> pointless still having the 3 build options. Would it not be better to
>> just have one saying -DKICAD_PYTHON or -DKICAD_SCRIPTING?
>>
>> Simon
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Python build options

[Nick Østergaard]

What about one that just enables all three, for example -DKICAD_PYTHON?

And it would enable?
-DKICAD_SCRIPTING=ON -DKICAD_SCRIPTING_MODULES=ON -DKICAD_SCRIPTING_WXPYTHON=ON


2016-06-07 20:24 GMT+02:00 Simon Wells :
> Is there anyone who doesn't use All or None of the python build
> options? As with how codependent a lot of the code has become it seems
> pointless still having the 3 build options. Would it not be better to
> just have one saying -DKICAD_PYTHON or -DKICAD_SCRIPTING?
>
> Simon
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Python build options

[Simon Wells]

Is there anyone who doesn't use All or None of the python build
options? As with how codependent a lot of the code has become it seems
pointless still having the 3 build options. Would it not be better to
just have one saying -DKICAD_PYTHON or -DKICAD_SCRIPTING?

Simon

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] New stable version.

[Simon Wells]

there is a single one from june 2nd in the testing folder due to c++11
issues, They should resume past that soon though, just solving issues
with stable builds

On Wed, Jun 8, 2016 at 5:50 AM, Jean-Paul Louis  wrote:
> Hi Adam,
>
> Yesterday, I wanted to update my OS X Kicad with the lated nightly, and I 
> could not find
> anything more recent than May 6th.
>
> What happened to the nightlies?
>
> Just curious,
> Jean-Paul
> N1JPL
>
>
>
>> On Jun 7, 2016, at 1:02 PM, Adam Wolf  wrote:
>>
>> There's still at least a minor problem--the extras DMG has an invalid 
>> checksum.  We're close!
>>
>> On Tue, Jun 7, 2016 at 10:57 AM, Simon Wells  wrote:
>> do we want stable compatible with newer versions of cmake or is it not worth 
>> it?
>>
>> Also Adam are you able to test those python patches i sent through as
>> i would love to get the wxpython fix if not the python bundler in
>> 4.0.3
>>
>> thanks
>>
>> Simon
>>
>> On Wed, Jun 8, 2016 at 2:53 AM, Adam Wolf  
>> wrote:
>> > Hi folks,
>> >
>> > I have finally gotten this to build.  There is a test build using the 4.0.2
>> > artifacts and labeled 4.0.3-rc1, here:
>> > http://downloads.kicad-pcb.org/osx/stable/kicad-4.0.3-rc1.dmg
>> >
>> > I updated from CMake 3.1.2 in order to build the C++11 stuff with the
>> > nightlies.  I upgraded to CMake 3.5.2.  Upgrading to CMake 3.5.2 breaks the
>> > stable branch on OS X.  I downgraded to CMake 3.1.2 for this build, and...
>> > 
>> >
>> > Adam Wolf
>> > Cofounder and Engineer
>> > W
>> >
>> > On Thu, Jun 2, 2016 at 4:14 PM, Simon Wells  wrote:
>> >>
>> >> Sorry this was meant to be sent to the list not just to Adam
>> >>
>> >> Simon Asked:
>> >> which bug was it that required upgrading? is it one that may need to
>> >> up the minimum cmake version required in CMakeLists.txt?
>> >> -
>> >>
>> >> Adam Responded:
>> >>
>> >> I think so, especially on OS X.
>> >>
>> >> https://cmake.org/Bug/view.php?id=15355
>> >>
>> >> On Fri, Jun 3, 2016 at 5:29 AM, Adam Wolf 
>> >> wrote:
>> >> > This is being hairy.
>> >> >
>> >> > I had to upgrade cmake on the system in order to get the nightly builds
>> >> > to
>> >> > continue working, due to a known bug in CMake, and now I'm having issues
>> >> > getting stable to build.  We're working through the issues, but it might
>> >> > be
>> >> > a bit longer.
>> >> >
>> >> > Adam Wolf
>> >> >
>> >> > On Fri, May 27, 2016 at 6:20 PM, Wayne Stambaugh 
>> >> > wrote:
>> >> >>
>> >> >> Thanks Adam.
>> >> >>
>> >> >> On 5/27/2016 7:16 PM, Adam Wolf wrote:
>> >> >> > I will try running a build this weekend.
>> >> >> >
>> >> >> > On Fri, May 27, 2016 at 3:59 PM, Wayne Stambaugh
>> >> >> > > >> >> > > wrote:
>> >> >> >
>> >> >> > I would like to push a 4.0.3 stable release in the couple of
>> >> >> > weeks.
>> >> >> > Would one of our OSX devs please make sure the latest version
>> >> >> > (r6281) of
>> >> >> > the stable 4 branch compiles and runs OK on OSX?  Once I have
>> >> >> > some
>> >> >> > feedback, I'll create a source archive and make the announcement.
>> >> >> >
>> >> >> > Thanks,
>> >> >> >
>> >> >> > Wayne
>> >> >> >
>> >> >> > ___
>> >> >> > Mailing list: https://launchpad.net/~kicad-developers
>> >> >> > Post to : kicad-developers@lists.launchpad.net
>> >> >> > 
>> >> >> > Unsubscribe : https://launchpad.net/~kicad-developers
>> >> >> > More help   : https://help.launchpad.net/ListHelp
>> >> >> >
>> >> >> >
>> >> >>
>> >> >
>> >> >
>> >> > ___
>> >> > Mailing list: https://launchpad.net/~kicad-developers
>> >> > Post to : kicad-developers@lists.launchpad.net
>> >> > Unsubscribe : https://launchpad.net/~kicad-developers
>> >> > More help   : https://help.launchpad.net/ListHelp
>> >> >
>> >
>> >
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] New stable version.

[Adam Wolf]

Jean-Paul,

There were issues when we switched to C++11.  I had to change things on the
nightly server in order to make this work.  Those changes broke the stable
build.  I have "rechanged" things back so I can debug the stable build.

There is at least one new nightly in the testing/ folder.  Once more people
test it, I'll post them back to the nightlies folder.

Adam Wolf


On Tue, Jun 7, 2016 at 12:50 PM, Jean-Paul Louis  wrote:

> Hi Adam,
>
> Yesterday, I wanted to update my OS X Kicad with the lated nightly, and I
> could not find
> anything more recent than May 6th.
>
> What happened to the nightlies?
>
> Just curious,
> Jean-Paul
> N1JPL
>
>
>
> > On Jun 7, 2016, at 1:02 PM, Adam Wolf 
> wrote:
> >
> > There's still at least a minor problem--the extras DMG has an invalid
> checksum.  We're close!
> >
> > On Tue, Jun 7, 2016 at 10:57 AM, Simon Wells  wrote:
> > do we want stable compatible with newer versions of cmake or is it not
> worth it?
> >
> > Also Adam are you able to test those python patches i sent through as
> > i would love to get the wxpython fix if not the python bundler in
> > 4.0.3
> >
> > thanks
> >
> > Simon
> >
> > On Wed, Jun 8, 2016 at 2:53 AM, Adam Wolf 
> wrote:
> > > Hi folks,
> > >
> > > I have finally gotten this to build.  There is a test build using the
> 4.0.2
> > > artifacts and labeled 4.0.3-rc1, here:
> > > http://downloads.kicad-pcb.org/osx/stable/kicad-4.0.3-rc1.dmg
> > >
> > > I updated from CMake 3.1.2 in order to build the C++11 stuff with the
> > > nightlies.  I upgraded to CMake 3.5.2.  Upgrading to CMake 3.5.2
> breaks the
> > > stable branch on OS X.  I downgraded to CMake 3.1.2 for this build,
> and...
> > > 
> > >
> > > Adam Wolf
> > > Cofounder and Engineer
> > > W
> > >
> > > On Thu, Jun 2, 2016 at 4:14 PM, Simon Wells  wrote:
> > >>
> > >> Sorry this was meant to be sent to the list not just to Adam
> > >>
> > >> Simon Asked:
> > >> which bug was it that required upgrading? is it one that may need to
> > >> up the minimum cmake version required in CMakeLists.txt?
> > >> -
> > >>
> > >> Adam Responded:
> > >>
> > >> I think so, especially on OS X.
> > >>
> > >> https://cmake.org/Bug/view.php?id=15355
> > >>
> > >> On Fri, Jun 3, 2016 at 5:29 AM, Adam Wolf <
> adamw...@feelslikeburning.com>
> > >> wrote:
> > >> > This is being hairy.
> > >> >
> > >> > I had to upgrade cmake on the system in order to get the nightly
> builds
> > >> > to
> > >> > continue working, due to a known bug in CMake, and now I'm having
> issues
> > >> > getting stable to build.  We're working through the issues, but it
> might
> > >> > be
> > >> > a bit longer.
> > >> >
> > >> > Adam Wolf
> > >> >
> > >> > On Fri, May 27, 2016 at 6:20 PM, Wayne Stambaugh <
> stambau...@gmail.com>
> > >> > wrote:
> > >> >>
> > >> >> Thanks Adam.
> > >> >>
> > >> >> On 5/27/2016 7:16 PM, Adam Wolf wrote:
> > >> >> > I will try running a build this weekend.
> > >> >> >
> > >> >> > On Fri, May 27, 2016 at 3:59 PM, Wayne Stambaugh
> > >> >> >  > >> >> > > wrote:
> > >> >> >
> > >> >> > I would like to push a 4.0.3 stable release in the couple of
> > >> >> > weeks.
> > >> >> > Would one of our OSX devs please make sure the latest version
> > >> >> > (r6281) of
> > >> >> > the stable 4 branch compiles and runs OK on OSX?  Once I have
> > >> >> > some
> > >> >> > feedback, I'll create a source archive and make the
> announcement.
> > >> >> >
> > >> >> > Thanks,
> > >> >> >
> > >> >> > Wayne
> > >> >> >
> > >> >> > ___
> > >> >> > Mailing list: https://launchpad.net/~kicad-developers
> > >> >> > Post to : kicad-developers@lists.launchpad.net
> > >> >> > 
> > >> >> > Unsubscribe : https://launchpad.net/~kicad-developers
> > >> >> > More help   : https://help.launchpad.net/ListHelp
> > >> >> >
> > >> >> >
> > >> >>
> > >> >
> > >> >
> > >> > ___
> > >> > Mailing list: https://launchpad.net/~kicad-developers
> > >> > Post to : kicad-developers@lists.launchpad.net
> > >> > Unsubscribe : https://launchpad.net/~kicad-developers
> > >> > More help   : https://help.launchpad.net/ListHelp
> > >> >
> > >
> > >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] New stable version.

[Jean-Paul Louis]

Hi Adam,

Yesterday, I wanted to update my OS X Kicad with the lated nightly, and I could 
not find
anything more recent than May 6th.

What happened to the nightlies?

Just curious,
Jean-Paul
N1JPL



> On Jun 7, 2016, at 1:02 PM, Adam Wolf  wrote:
> 
> There's still at least a minor problem--the extras DMG has an invalid 
> checksum.  We're close!
> 
> On Tue, Jun 7, 2016 at 10:57 AM, Simon Wells  wrote:
> do we want stable compatible with newer versions of cmake or is it not worth 
> it?
> 
> Also Adam are you able to test those python patches i sent through as
> i would love to get the wxpython fix if not the python bundler in
> 4.0.3
> 
> thanks
> 
> Simon
> 
> On Wed, Jun 8, 2016 at 2:53 AM, Adam Wolf  
> wrote:
> > Hi folks,
> >
> > I have finally gotten this to build.  There is a test build using the 4.0.2
> > artifacts and labeled 4.0.3-rc1, here:
> > http://downloads.kicad-pcb.org/osx/stable/kicad-4.0.3-rc1.dmg
> >
> > I updated from CMake 3.1.2 in order to build the C++11 stuff with the
> > nightlies.  I upgraded to CMake 3.5.2.  Upgrading to CMake 3.5.2 breaks the
> > stable branch on OS X.  I downgraded to CMake 3.1.2 for this build, and...
> > 
> >
> > Adam Wolf
> > Cofounder and Engineer
> > W
> >
> > On Thu, Jun 2, 2016 at 4:14 PM, Simon Wells  wrote:
> >>
> >> Sorry this was meant to be sent to the list not just to Adam
> >>
> >> Simon Asked:
> >> which bug was it that required upgrading? is it one that may need to
> >> up the minimum cmake version required in CMakeLists.txt?
> >> -
> >>
> >> Adam Responded:
> >>
> >> I think so, especially on OS X.
> >>
> >> https://cmake.org/Bug/view.php?id=15355
> >>
> >> On Fri, Jun 3, 2016 at 5:29 AM, Adam Wolf 
> >> wrote:
> >> > This is being hairy.
> >> >
> >> > I had to upgrade cmake on the system in order to get the nightly builds
> >> > to
> >> > continue working, due to a known bug in CMake, and now I'm having issues
> >> > getting stable to build.  We're working through the issues, but it might
> >> > be
> >> > a bit longer.
> >> >
> >> > Adam Wolf
> >> >
> >> > On Fri, May 27, 2016 at 6:20 PM, Wayne Stambaugh 
> >> > wrote:
> >> >>
> >> >> Thanks Adam.
> >> >>
> >> >> On 5/27/2016 7:16 PM, Adam Wolf wrote:
> >> >> > I will try running a build this weekend.
> >> >> >
> >> >> > On Fri, May 27, 2016 at 3:59 PM, Wayne Stambaugh
> >> >> >  >> >> > > wrote:
> >> >> >
> >> >> > I would like to push a 4.0.3 stable release in the couple of
> >> >> > weeks.
> >> >> > Would one of our OSX devs please make sure the latest version
> >> >> > (r6281) of
> >> >> > the stable 4 branch compiles and runs OK on OSX?  Once I have
> >> >> > some
> >> >> > feedback, I'll create a source archive and make the announcement.
> >> >> >
> >> >> > Thanks,
> >> >> >
> >> >> > Wayne
> >> >> >
> >> >> > ___
> >> >> > Mailing list: https://launchpad.net/~kicad-developers
> >> >> > Post to : kicad-developers@lists.launchpad.net
> >> >> > 
> >> >> > Unsubscribe : https://launchpad.net/~kicad-developers
> >> >> > More help   : https://help.launchpad.net/ListHelp
> >> >> >
> >> >> >
> >> >>
> >> >
> >> >
> >> > ___
> >> > Mailing list: https://launchpad.net/~kicad-developers
> >> > Post to : kicad-developers@lists.launchpad.net
> >> > Unsubscribe : https://launchpad.net/~kicad-developers
> >> > More help   : https://help.launchpad.net/ListHelp
> >> >
> >
> >
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] New stable version.

[Adam Wolf]

There's still at least a minor problem--the extras DMG has an invalid
checksum.  We're close!

On Tue, Jun 7, 2016 at 10:57 AM, Simon Wells  wrote:

> do we want stable compatible with newer versions of cmake or is it not
> worth it?
>
> Also Adam are you able to test those python patches i sent through as
> i would love to get the wxpython fix if not the python bundler in
> 4.0.3
>
> thanks
>
> Simon
>
> On Wed, Jun 8, 2016 at 2:53 AM, Adam Wolf 
> wrote:
> > Hi folks,
> >
> > I have finally gotten this to build.  There is a test build using the
> 4.0.2
> > artifacts and labeled 4.0.3-rc1, here:
> > http://downloads.kicad-pcb.org/osx/stable/kicad-4.0.3-rc1.dmg
> >
> > I updated from CMake 3.1.2 in order to build the C++11 stuff with the
> > nightlies.  I upgraded to CMake 3.5.2.  Upgrading to CMake 3.5.2 breaks
> the
> > stable branch on OS X.  I downgraded to CMake 3.1.2 for this build,
> and...
> > 
> >
> > Adam Wolf
> > Cofounder and Engineer
> > W
> >
> > On Thu, Jun 2, 2016 at 4:14 PM, Simon Wells  wrote:
> >>
> >> Sorry this was meant to be sent to the list not just to Adam
> >>
> >> Simon Asked:
> >> which bug was it that required upgrading? is it one that may need to
> >> up the minimum cmake version required in CMakeLists.txt?
> >> -
> >>
> >> Adam Responded:
> >>
> >> I think so, especially on OS X.
> >>
> >> https://cmake.org/Bug/view.php?id=15355
> >>
> >> On Fri, Jun 3, 2016 at 5:29 AM, Adam Wolf <
> adamw...@feelslikeburning.com>
> >> wrote:
> >> > This is being hairy.
> >> >
> >> > I had to upgrade cmake on the system in order to get the nightly
> builds
> >> > to
> >> > continue working, due to a known bug in CMake, and now I'm having
> issues
> >> > getting stable to build.  We're working through the issues, but it
> might
> >> > be
> >> > a bit longer.
> >> >
> >> > Adam Wolf
> >> >
> >> > On Fri, May 27, 2016 at 6:20 PM, Wayne Stambaugh <
> stambau...@gmail.com>
> >> > wrote:
> >> >>
> >> >> Thanks Adam.
> >> >>
> >> >> On 5/27/2016 7:16 PM, Adam Wolf wrote:
> >> >> > I will try running a build this weekend.
> >> >> >
> >> >> > On Fri, May 27, 2016 at 3:59 PM, Wayne Stambaugh
> >> >> >  >> >> > > wrote:
> >> >> >
> >> >> > I would like to push a 4.0.3 stable release in the couple of
> >> >> > weeks.
> >> >> > Would one of our OSX devs please make sure the latest version
> >> >> > (r6281) of
> >> >> > the stable 4 branch compiles and runs OK on OSX?  Once I have
> >> >> > some
> >> >> > feedback, I'll create a source archive and make the
> announcement.
> >> >> >
> >> >> > Thanks,
> >> >> >
> >> >> > Wayne
> >> >> >
> >> >> > ___
> >> >> > Mailing list: https://launchpad.net/~kicad-developers
> >> >> > Post to : kicad-developers@lists.launchpad.net
> >> >> > 
> >> >> > Unsubscribe : https://launchpad.net/~kicad-developers
> >> >> > More help   : https://help.launchpad.net/ListHelp
> >> >> >
> >> >> >
> >> >>
> >> >
> >> >
> >> > ___
> >> > Mailing list: https://launchpad.net/~kicad-developers
> >> > Post to : kicad-developers@lists.launchpad.net
> >> > Unsubscribe : https://launchpad.net/~kicad-developers
> >> > More help   : https://help.launchpad.net/ListHelp
> >> >
> >
> >
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] New stable version.

[Simon Wells]

do we want stable compatible with newer versions of cmake or is it not worth it?

Also Adam are you able to test those python patches i sent through as
i would love to get the wxpython fix if not the python bundler in
4.0.3

thanks

Simon

On Wed, Jun 8, 2016 at 2:53 AM, Adam Wolf  wrote:
> Hi folks,
>
> I have finally gotten this to build.  There is a test build using the 4.0.2
> artifacts and labeled 4.0.3-rc1, here:
> http://downloads.kicad-pcb.org/osx/stable/kicad-4.0.3-rc1.dmg
>
> I updated from CMake 3.1.2 in order to build the C++11 stuff with the
> nightlies.  I upgraded to CMake 3.5.2.  Upgrading to CMake 3.5.2 breaks the
> stable branch on OS X.  I downgraded to CMake 3.1.2 for this build, and...
> 
>
> Adam Wolf
> Cofounder and Engineer
> W
>
> On Thu, Jun 2, 2016 at 4:14 PM, Simon Wells  wrote:
>>
>> Sorry this was meant to be sent to the list not just to Adam
>>
>> Simon Asked:
>> which bug was it that required upgrading? is it one that may need to
>> up the minimum cmake version required in CMakeLists.txt?
>> -
>>
>> Adam Responded:
>>
>> I think so, especially on OS X.
>>
>> https://cmake.org/Bug/view.php?id=15355
>>
>> On Fri, Jun 3, 2016 at 5:29 AM, Adam Wolf 
>> wrote:
>> > This is being hairy.
>> >
>> > I had to upgrade cmake on the system in order to get the nightly builds
>> > to
>> > continue working, due to a known bug in CMake, and now I'm having issues
>> > getting stable to build.  We're working through the issues, but it might
>> > be
>> > a bit longer.
>> >
>> > Adam Wolf
>> >
>> > On Fri, May 27, 2016 at 6:20 PM, Wayne Stambaugh 
>> > wrote:
>> >>
>> >> Thanks Adam.
>> >>
>> >> On 5/27/2016 7:16 PM, Adam Wolf wrote:
>> >> > I will try running a build this weekend.
>> >> >
>> >> > On Fri, May 27, 2016 at 3:59 PM, Wayne Stambaugh
>> >> > > >> > > wrote:
>> >> >
>> >> > I would like to push a 4.0.3 stable release in the couple of
>> >> > weeks.
>> >> > Would one of our OSX devs please make sure the latest version
>> >> > (r6281) of
>> >> > the stable 4 branch compiles and runs OK on OSX?  Once I have
>> >> > some
>> >> > feedback, I'll create a source archive and make the announcement.
>> >> >
>> >> > Thanks,
>> >> >
>> >> > Wayne
>> >> >
>> >> > ___
>> >> > Mailing list: https://launchpad.net/~kicad-developers
>> >> > Post to : kicad-developers@lists.launchpad.net
>> >> > 
>> >> > Unsubscribe : https://launchpad.net/~kicad-developers
>> >> > More help   : https://help.launchpad.net/ListHelp
>> >> >
>> >> >
>> >>
>> >
>> >
>> > ___
>> > Mailing list: https://launchpad.net/~kicad-developers
>> > Post to : kicad-developers@lists.launchpad.net
>> > Unsubscribe : https://launchpad.net/~kicad-developers
>> > More help   : https://help.launchpad.net/ListHelp
>> >
>
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Legacy: delete and force middle button pan for GAL consistency

[Nick Østergaard]

I am looking forward to "better" things :)

2016-06-07 17:12 GMT+02:00 Chris Pavlina :
> Heh :)
>
> I'm working on the replacement feature. There is definitely a strong argument
> in favor of writing the replacement before removing the original, so I'm going
> to do that. Could be a couple days, I have to spread it out with Real Work 
> now.
> I promise it'll be better than what we had :)
>
> On Tue, Jun 07, 2016 at 05:08:29PM +0200, Marco Ciampa wrote:
>> On Tue, Jun 07, 2016 at 10:20:56AM -0400, Chris Pavlina wrote:
>> > Also, I really feel like I should point out - it's not feasible to gather 
>> > user
>> > input for _every change_. That's how we got to the point we're at, really -
>> > lots of "this would be useful for _me_", so it gets thrown in, and then we 
>> > have
>> > a hodgepodge of incoherent "features" each used by one person too fond of 
>> > it to
>> > remove it.
>> >
>>
>> Sorry, couldn't resist: https://xkcd.com/1172/
>>
>> --
>>
>>
>> Marco Ciampa
>>
>> I know a joke about UDP, but you might not get it.
>>
>> 
>>
>>  GNU/Linux User #78271
>>  FSFE fellow #364
>>
>> 
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Legacy: delete and force middle button pan for GAL consistency

[Chris Pavlina]

Heh :)

I'm working on the replacement feature. There is definitely a strong argument
in favor of writing the replacement before removing the original, so I'm going
to do that. Could be a couple days, I have to spread it out with Real Work now.
I promise it'll be better than what we had :)

On Tue, Jun 07, 2016 at 05:08:29PM +0200, Marco Ciampa wrote:
> On Tue, Jun 07, 2016 at 10:20:56AM -0400, Chris Pavlina wrote:
> > Also, I really feel like I should point out - it's not feasible to gather 
> > user
> > input for _every change_. That's how we got to the point we're at, really -
> > lots of "this would be useful for _me_", so it gets thrown in, and then we 
> > have
> > a hodgepodge of incoherent "features" each used by one person too fond of 
> > it to
> > remove it.
> > 
> 
> Sorry, couldn't resist: https://xkcd.com/1172/
> 
> --
> 
> 
> Marco Ciampa
> 
> I know a joke about UDP, but you might not get it.
> 
> 
> 
>  GNU/Linux User #78271
>  FSFE fellow #364
> 
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Legacy: delete and force middle button pan for GAL consistency

[Marco Ciampa]

On Tue, Jun 07, 2016 at 10:20:56AM -0400, Chris Pavlina wrote:
> Also, I really feel like I should point out - it's not feasible to gather user
> input for _every change_. That's how we got to the point we're at, really -
> lots of "this would be useful for _me_", so it gets thrown in, and then we 
> have
> a hodgepodge of incoherent "features" each used by one person too fond of it 
> to
> remove it.
> 

Sorry, couldn't resist: https://xkcd.com/1172/

--


Marco Ciampa

I know a joke about UDP, but you might not get it.



 GNU/Linux User #78271
 FSFE fellow #364




___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] New stable version.

[Adam Wolf]

Hi folks,

I have finally gotten this to build.  There is a test build using the 4.0.2
artifacts and labeled 4.0.3-rc1, here:
http://downloads.kicad-pcb.org/osx/stable/kicad-4.0.3-rc1.dmg

I updated from CMake 3.1.2 in order to build the C++11 stuff with the
nightlies.  I upgraded to CMake 3.5.2.  Upgrading to CMake 3.5.2 breaks the
stable branch on OS X.  I downgraded to CMake 3.1.2 for this build, and...


Adam Wolf
Cofounder and Engineer
W

On Thu, Jun 2, 2016 at 4:14 PM, Simon Wells  wrote:

> Sorry this was meant to be sent to the list not just to Adam
>
> Simon Asked:
> which bug was it that required upgrading? is it one that may need to
> up the minimum cmake version required in CMakeLists.txt?
> -
>
> Adam Responded:
>
> I think so, especially on OS X.
>
> https://cmake.org/Bug/view.php?id=15355
>
> On Fri, Jun 3, 2016 at 5:29 AM, Adam Wolf 
> wrote:
> > This is being hairy.
> >
> > I had to upgrade cmake on the system in order to get the nightly builds
> to
> > continue working, due to a known bug in CMake, and now I'm having issues
> > getting stable to build.  We're working through the issues, but it might
> be
> > a bit longer.
> >
> > Adam Wolf
> >
> > On Fri, May 27, 2016 at 6:20 PM, Wayne Stambaugh 
> > wrote:
> >>
> >> Thanks Adam.
> >>
> >> On 5/27/2016 7:16 PM, Adam Wolf wrote:
> >> > I will try running a build this weekend.
> >> >
> >> > On Fri, May 27, 2016 at 3:59 PM, Wayne Stambaugh <
> stambau...@gmail.com
> >> > > wrote:
> >> >
> >> > I would like to push a 4.0.3 stable release in the couple of
> weeks.
> >> > Would one of our OSX devs please make sure the latest version
> >> > (r6281) of
> >> > the stable 4 branch compiles and runs OK on OSX?  Once I have some
> >> > feedback, I'll create a source archive and make the announcement.
> >> >
> >> > Thanks,
> >> >
> >> > Wayne
> >> >
> >> > ___
> >> > Mailing list: https://launchpad.net/~kicad-developers
> >> > Post to : kicad-developers@lists.launchpad.net
> >> > 
> >> > Unsubscribe : https://launchpad.net/~kicad-developers
> >> > More help   : https://help.launchpad.net/ListHelp
> >> >
> >> >
> >>
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Legacy: delete and force middle button pan for GAL consistency

[Chris Pavlina]

Also, I really feel like I should point out - it's not feasible to gather user
input for _every change_. That's how we got to the point we're at, really -
lots of "this would be useful for _me_", so it gets thrown in, and then we have
a hodgepodge of incoherent "features" each used by one person too fond of it to
remove it.

In case you haven't been following along, my master plan here is to pare down
the incoherent bits between legacy and GAL, and then do some serious UI
reworking to fit it all back together nicely. I plan on getting significant
user involvement with the latter bit - that's part of why I got us that
Balsamiq account recently, it's a good way to share and get feedback on UI
mockups.

I really don't want each individual piece to become a battle ground by itself,
though. Trust me, I have no plans on removing all of KiCad's features and
making it useless ;)

On Tue, Jun 07, 2016 at 08:56:35AM -0500, Moses McKnight wrote:
> I'm not sure removing features like this is wise without at least asking the
> /users/ (not just developers) first - and give them a little time to notice
> and respond as well.  I personally use nothing but middle button pan, but I
> know what it is like to be quite used to a feature and then the next stable
> release (of whatever software it is) has removed that feature (especially
> when there is no suitable replacement for it!).
> 
> On 06/07/2016 08:33 AM, Chris Pavlina wrote:
> >Yeah, this is the last call for disagreement, I'm going to push this tomorrow
> >if nobody speaks up.
> >
> >On Tue, Jun 07, 2016 at 03:23:45PM +0200, Maciej Sumiński wrote:
> >>I, for one, support the patch. I see it is not a hot topic with an
> >>endless discussion, so perhaps it is safe to commit. I hope this message
> >>is a gentle reminder to people who would vote against, if there are any.
> >>
> >>Regards,
> >>Orson
> >>
> >>On 06/04/2016 09:30 PM, Chris Pavlina wrote:
> >>>This is one of the legacy/GAL consistency bits that we discussed a while 
> >>>ago.
> >>>Legacy allows middle button pan to be disabled in favor of a middle button
> >>>zoom. GAL doesn't. This patch removes "Use middle button to pan" (forcing 
> >>>it
> >>>True for existing configs), and removes "Limit panning to scroll size" 
> >>>(forcing
> >>>it False for existing configs).
> >>>
> >>>I don't want to commit this without giving a chance for discussion, but I
> >>>really do think we should commit this. Perhaps there are a few users who 
> >>>like
> >>>the feature, but I doubt there are many. So far nobody has complained 
> >>>about it
> >>>being missing in GAL, and it's a win for both maintainability and interface
> >>>simplicity.
> >>>
> >>>I'm not averse to having this feature, but I don't think it should be
> >>>implemented this way. Other tools provide "zoom into selection" as a 
> >>>separate
> >>>tool, for example GIMP [1]. I'd support implementing it this way instead, 
> >>>and
> >>>can probably do that next if we want. Thoughts?
> >>>
> >>>[1] https://en.wikibooks.org/wiki/GIMP/Zoom_Tool
> >>>
> >>>
> >>>
> >>>___
> >>>Mailing list: https://launchpad.net/~kicad-developers
> >>>Post to : kicad-developers@lists.launchpad.net
> >>>Unsubscribe : https://launchpad.net/~kicad-developers
> >>>More help   : https://help.launchpad.net/ListHelp
> >>>
> >>
> >>
> >
> >
> >___
> >Mailing list: https://launchpad.net/~kicad-developers
> >Post to : kicad-developers@lists.launchpad.net
> >Unsubscribe : https://launchpad.net/~kicad-developers
> >More help   : https://help.launchpad.net/ListHelp
> >
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Legacy: delete and force middle button pan for GAL consistency

[Chris Pavlina]

Sure, but I did propose a replacement for it, and even volunteered to implement
it. Any opinions on my proposed replacement?

Perhaps I'll implement the replacement *first*, that should keep people happy.

On Tue, Jun 07, 2016 at 08:56:35AM -0500, Moses McKnight wrote:
> I'm not sure removing features like this is wise without at least
> asking the /users/ (not just developers) first - and give them a
> little time to notice and respond as well.  I personally use
> nothing but middle button pan, but I know what it is like to be
> quite used to a feature and then the next stable release (of
> whatever software it is) has removed that feature (especially
> when there is no suitable replacement for it!).
> 
> On 06/07/2016 08:33 AM, Chris Pavlina wrote:
> >Yeah, this is the last call for disagreement, I'm going to push this tomorrow
> >if nobody speaks up.
> >
> >On Tue, Jun 07, 2016 at 03:23:45PM +0200, Maciej Sumiński wrote:
> >>I, for one, support the patch. I see it is not a hot topic with an
> >>endless discussion, so perhaps it is safe to commit. I hope this message
> >>is a gentle reminder to people who would vote against, if there are any.
> >>
> >>Regards,
> >>Orson
> >>
> >>On 06/04/2016 09:30 PM, Chris Pavlina wrote:
> >>>This is one of the legacy/GAL consistency bits that we discussed a while 
> >>>ago.
> >>>Legacy allows middle button pan to be disabled in favor of a middle button
> >>>zoom. GAL doesn't. This patch removes "Use middle button to pan" (forcing 
> >>>it
> >>>True for existing configs), and removes "Limit panning to scroll size" 
> >>>(forcing
> >>>it False for existing configs).
> >>>
> >>>I don't want to commit this without giving a chance for discussion, but I
> >>>really do think we should commit this. Perhaps there are a few users who 
> >>>like
> >>>the feature, but I doubt there are many. So far nobody has complained 
> >>>about it
> >>>being missing in GAL, and it's a win for both maintainability and interface
> >>>simplicity.
> >>>
> >>>I'm not averse to having this feature, but I don't think it should be
> >>>implemented this way. Other tools provide "zoom into selection" as a 
> >>>separate
> >>>tool, for example GIMP [1]. I'd support implementing it this way instead, 
> >>>and
> >>>can probably do that next if we want. Thoughts?
> >>>
> >>>[1] https://en.wikibooks.org/wiki/GIMP/Zoom_Tool
> >>>
> >>>
> >>>
> >>>___
> >>>Mailing list: https://launchpad.net/~kicad-developers
> >>>Post to : kicad-developers@lists.launchpad.net
> >>>Unsubscribe : https://launchpad.net/~kicad-developers
> >>>More help   : https://help.launchpad.net/ListHelp
> >>>
> >>
> >>
> >
> >
> >___
> >Mailing list: https://launchpad.net/~kicad-developers
> >Post to : kicad-developers@lists.launchpad.net
> >Unsubscribe : https://launchpad.net/~kicad-developers
> >More help   : https://help.launchpad.net/ListHelp
> >
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] mode openGL issues after latest updates

[Maciej Sumiński]

On 06/07/2016 03:41 PM, jp charras wrote:
> Le 07/06/2016 à 15:14, Maciej Sumiński a écrit :
>> On 06/03/2016 05:26 PM, jp charras wrote:
>>> The 3D viewer does not crash.
>>>
>>> Only Opengl crashes if I switch to cairo, or when exiting pcbnew if I am in 
>>> legacy mode, and if I
>>> used the opengl canvas during the session.
>>> When exiting, if pcbnew is in opengl mode, no crash.
>>
>> Hi Jean-Pierre,
>>
>> I have just pushed a few more patches, one of them is meant to fix the
>> OpenGL issue. I hope this is the last required change and now everything
>> will be fine. I look forward to your feedback.
>>
>> Regards,
>> Orson
>>
>>
> 
> It works now for me!
> Good work, Orson!
> I know is is very difficult to fix a bug when it does not happen on your 
> computer...
> 
> Thanks.

Whew, great to hear that! Thank you for all help you provided, it was
very valuable.

Regards,
Orson




signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] mode openGL issues after latest updates

[jp charras]

Le 07/06/2016 à 15:14, Maciej Sumiński a écrit :
> On 06/03/2016 05:26 PM, jp charras wrote:
>> The 3D viewer does not crash.
>>
>> Only Opengl crashes if I switch to cairo, or when exiting pcbnew if I am in 
>> legacy mode, and if I
>> used the opengl canvas during the session.
>> When exiting, if pcbnew is in opengl mode, no crash.
> 
> Hi Jean-Pierre,
> 
> I have just pushed a few more patches, one of them is meant to fix the
> OpenGL issue. I hope this is the last required change and now everything
> will be fine. I look forward to your feedback.
> 
> Regards,
> Orson
> 
> 

It works now for me!
Good work, Orson!
I know is is very difficult to fix a bug when it does not happen on your 
computer...

Thanks.

-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Legacy: delete and force middle button pan for GAL consistency

[Chris Pavlina]

Yeah, this is the last call for disagreement, I'm going to push this tomorrow
if nobody speaks up.

On Tue, Jun 07, 2016 at 03:23:45PM +0200, Maciej Sumiński wrote:
> I, for one, support the patch. I see it is not a hot topic with an
> endless discussion, so perhaps it is safe to commit. I hope this message
> is a gentle reminder to people who would vote against, if there are any.
> 
> Regards,
> Orson
> 
> On 06/04/2016 09:30 PM, Chris Pavlina wrote:
> > This is one of the legacy/GAL consistency bits that we discussed a while 
> > ago.
> > Legacy allows middle button pan to be disabled in favor of a middle button
> > zoom. GAL doesn't. This patch removes "Use middle button to pan" (forcing it
> > True for existing configs), and removes "Limit panning to scroll size" 
> > (forcing
> > it False for existing configs).
> > 
> > I don't want to commit this without giving a chance for discussion, but I
> > really do think we should commit this. Perhaps there are a few users who 
> > like
> > the feature, but I doubt there are many. So far nobody has complained about 
> > it
> > being missing in GAL, and it's a win for both maintainability and interface
> > simplicity.
> > 
> > I'm not averse to having this feature, but I don't think it should be
> > implemented this way. Other tools provide "zoom into selection" as a 
> > separate
> > tool, for example GIMP [1]. I'd support implementing it this way instead, 
> > and
> > can probably do that next if we want. Thoughts?
> > 
> > [1] https://en.wikibooks.org/wiki/GIMP/Zoom_Tool
> > 
> > 
> > 
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> > 
> 
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Legacy: delete and force middle button pan for GAL consistency

[Maciej Sumiński]

I, for one, support the patch. I see it is not a hot topic with an
endless discussion, so perhaps it is safe to commit. I hope this message
is a gentle reminder to people who would vote against, if there are any.

Regards,
Orson

On 06/04/2016 09:30 PM, Chris Pavlina wrote:
> This is one of the legacy/GAL consistency bits that we discussed a while ago.
> Legacy allows middle button pan to be disabled in favor of a middle button
> zoom. GAL doesn't. This patch removes "Use middle button to pan" (forcing it
> True for existing configs), and removes "Limit panning to scroll size" 
> (forcing
> it False for existing configs).
> 
> I don't want to commit this without giving a chance for discussion, but I
> really do think we should commit this. Perhaps there are a few users who like
> the feature, but I doubt there are many. So far nobody has complained about it
> being missing in GAL, and it's a win for both maintainability and interface
> simplicity.
> 
> I'm not averse to having this feature, but I don't think it should be
> implemented this way. Other tools provide "zoom into selection" as a separate
> tool, for example GIMP [1]. I'd support implementing it this way instead, and
> can probably do that next if we want. Thoughts?
> 
> [1] https://en.wikibooks.org/wiki/GIMP/Zoom_Tool
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 




signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] mode openGL issues after latest updates

[Maciej Sumiński]

On 06/03/2016 05:26 PM, jp charras wrote:
> The 3D viewer does not crash.
> 
> Only Opengl crashes if I switch to cairo, or when exiting pcbnew if I am in 
> legacy mode, and if I
> used the opengl canvas during the session.
> When exiting, if pcbnew is in opengl mode, no crash.

Hi Jean-Pierre,

I have just pushed a few more patches, one of them is meant to fix the
OpenGL issue. I hope this is the last required change and now everything
will be fine. I look forward to your feedback.

Regards,
Orson




signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp