[Kicad-developers] 3D viewer broken on 32 bit windows.
I think this may be the same issue as JP is seeing but every time I launch the 3D viewer on 32 bit windows builds (msys2/ming32), it either hangs indefinitely with a blank canvas and a busy cursor on 64 bit Windows 7 or crashes almost immediately after being launched with the same blank canvas and busy cursor on 64 bit windows 10. This situation really needs to be addressed. Can one of our resident 3D viewer experts please take a look at this? Thanks, Wayne ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation
I think you should test another thing on windows too. I just tested with 6112 on both windows and linux. On linux this thing is good, but on windows it is not so nice. Be in opengal rendering mode. I guess that the render thickness should be enabled. Hit the oneshot raytrace button. Then the opengl picture seems to refresk every time there is a new raytrace thing refreshing. It looks like the opengl image is switching between the render with thickness image and render without thickness. 2016-06-23 0:22 GMT+02:00 Nick Østergaard : > 2016-06-23 0:07 GMT+02:00 Mário Luzeiro : >> Hi Nick, >> >> I cannot experience that on Linux, I will try on Windows latter. > > I tested on archlinux. > >> >>> to avoid this transient artifact? >> that means it is a transient ? It recover back? Or does it stays all the >> time after that black? >> Does the GAL still works and the 3D-viewer windows? >> What if you open another footprint? > > I guess I forgot to add after "...that was in pcbnew itself." That it > will render the proper 3d image after about a second or so. The same > amount of time it takes to switch to the 3D settings tab initially. > >> >> What is your system? ;) (Windows? wxwidget version?) > > Archlinux, wx 3.0.2 > >> >> Thanks for reporting, >> Mario >> >> From: Nick Østergaard [oe.n...@gmail.com] >> Sent: 22 June 2016 22:20 >> To: Mário Luzeiro >> Cc: kicad-developers@lists.launchpad.net >> Subject: Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation >> >> Hi Mario >> >> I have noticed someting new. >> >> When I hit edit on a footprint, then switch to the 3D Settings tab it >> will freeze briefly until the 3D preview is assembled. Ok. Then I >> close the dialog on cancel. Then I open it again on the same footprint >> and it now shows the 3D Settings tab directly instead of the >> Properties tab, but now it is seen that the content in the 3D preview >> is the image on the screen from the Opengal (GAL) canvas that was in >> pcbnew itself. Maybe the 3D preview need to initialize a black canvas >> to avoid this transient artifact? >> >> Nick ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation
2016-06-23 0:07 GMT+02:00 Mário Luzeiro : > Hi Nick, > > I cannot experience that on Linux, I will try on Windows latter. I tested on archlinux. > >> to avoid this transient artifact? > that means it is a transient ? It recover back? Or does it stays all the time > after that black? > Does the GAL still works and the 3D-viewer windows? > What if you open another footprint? I guess I forgot to add after "...that was in pcbnew itself." That it will render the proper 3d image after about a second or so. The same amount of time it takes to switch to the 3D settings tab initially. > > What is your system? ;) (Windows? wxwidget version?) Archlinux, wx 3.0.2 > > Thanks for reporting, > Mario > > From: Nick Østergaard [oe.n...@gmail.com] > Sent: 22 June 2016 22:20 > To: Mário Luzeiro > Cc: kicad-developers@lists.launchpad.net > Subject: Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation > > Hi Mario > > I have noticed someting new. > > When I hit edit on a footprint, then switch to the 3D Settings tab it > will freeze briefly until the 3D preview is assembled. Ok. Then I > close the dialog on cancel. Then I open it again on the same footprint > and it now shows the 3D Settings tab directly instead of the > Properties tab, but now it is seen that the content in the 3D preview > is the image on the screen from the Opengal (GAL) canvas that was in > pcbnew itself. Maybe the 3D preview need to initialize a black canvas > to avoid this transient artifact? > > Nick ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation
Ohh ok, can we have tooltips on the buttons? 2016-06-23 0:03 GMT+02:00 Mário Luzeiro : > Hi Nick, > > sorry I didn't get. You mean that button in the Footprint->3D settings > preview? > That "refresh" button.. is for Reload the preview board. > For example if (lets say..) the footprint was changed or for example the 3D > models (external files) were changed and need to be reloaded. > It may be useful if someone is external editing the 3D files at same time > that is making changes there. > > Mario > > > From: Nick Østergaard [oe.n...@gmail.com] > Sent: 22 June 2016 22:21 > To: Mário Luzeiro > Cc: kicad-developers@lists.launchpad.net > Subject: Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation > > Additionally I can't figure out what the bottom left button is for the > preview. It is rendered as two circular arrows on my screen. i can't > see the view changing when I click it. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation
Hi Nick, I cannot experience that on Linux, I will try on Windows latter. > to avoid this transient artifact? that means it is a transient ? It recover back? Or does it stays all the time after that black? Does the GAL still works and the 3D-viewer windows? What if you open another footprint? What is your system? ;) (Windows? wxwidget version?) Thanks for reporting, Mario From: Nick Østergaard [oe.n...@gmail.com] Sent: 22 June 2016 22:20 To: Mário Luzeiro Cc: kicad-developers@lists.launchpad.net Subject: Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation Hi Mario I have noticed someting new. When I hit edit on a footprint, then switch to the 3D Settings tab it will freeze briefly until the 3D preview is assembled. Ok. Then I close the dialog on cancel. Then I open it again on the same footprint and it now shows the 3D Settings tab directly instead of the Properties tab, but now it is seen that the content in the 3D preview is the image on the screen from the Opengal (GAL) canvas that was in pcbnew itself. Maybe the 3D preview need to initialize a black canvas to avoid this transient artifact? Nick ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation
Hi Nick, sorry I didn't get. You mean that button in the Footprint->3D settings preview? That "refresh" button.. is for Reload the preview board. For example if (lets say..) the footprint was changed or for example the 3D models (external files) were changed and need to be reloaded. It may be useful if someone is external editing the 3D files at same time that is making changes there. Mario From: Nick Østergaard [oe.n...@gmail.com] Sent: 22 June 2016 22:21 To: Mário Luzeiro Cc: kicad-developers@lists.launchpad.net Subject: Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation Additionally I can't figure out what the bottom left button is for the preview. It is rendered as two circular arrows on my screen. i can't see the view changing when I click it. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation
Additionally I can't figure out what the bottom left button is for the preview. It is rendered as two circular arrows on my screen. i can't see the view changing when I click it. 2016-06-22 23:20 GMT+02:00 Nick Østergaard : > Hi Mario > > I have noticed someting new. > > When I hit edit on a footprint, then switch to the 3D Settings tab it > will freeze briefly until the 3D preview is assembled. Ok. Then I > close the dialog on cancel. Then I open it again on the same footprint > and it now shows the 3D Settings tab directly instead of the > Properties tab, but now it is seen that the content in the 3D preview > is the image on the screen from the Opengal (GAL) canvas that was in > pcbnew itself. Maybe the 3D preview need to initialize a black canvas > to avoid this transient artifact? > > Nick > > 2016-06-19 22:36 GMT+02:00 Nick Østergaard : >> 2016-06-19 20:09 GMT+02:00 Mário Luzeiro : >>> Hi Nick, >>> >>> Thanks for the comments. >>> >>> It seems that it cannot abort while performing the post processing shader. >>> >>> True, but.. What CPU do you have? >> >> Intel(R) Core(TM) i5 CPU M 540 @ 2.53GHz >> >> That is a two core cpu with hyperthreading of 4. >> >>> It should take just hundreds of ms ... up to <1s depending on many cores >>> you have. >>> >> >> It takes about a second. If I time it manually I get about 1.4 to 1.5 >> seconds, by looking at the status bar. I can even make it three to >> five seconds. Same board, just zoomed in. It is not a complex board, >> it just contains a few footprints, a three VRML models and a STEP >> model. >> >>> When in opengl mode and you hit the render button, it will show the lowres raytrace. I think it might be better to keep showing the last opengl image instead of the lowres raytrace, maybe. >>> >>> I implemented that suggestion, check my latest branch updates. >>> >> >> That feels way better. >> >>> Also, there is a black border when in raytracing mode. When I resize the window it will short of change in jumps. I assume this is because you have a "discrete" size for the image itself. Is this something you plan to change/fix? >>> >>> At this moment it is not an easy change. >>> But with your previous suggestion and some other changes I did (in >>> raytracing mode preview) it may looks more OK. >>> >>> The render is optimized in ray packages. One possible solution will be in >>> future to render to a bigger than screen buffer resolution, then draw that >>> buffer on the windows. That will waste some computation but should be OK. >>> >> >> I think that will be a sane solution. I don't mind too much, I just >> noticed the behaivour. >> >>> Anyway... a black frame is something that increase the value price of your >>> picture ;) >> >> I think it needs to be a frame of gold leafs. :P >> >>> >>> Mario >>> >>> >>> From: Nick Østergaard [oe.n...@gmail.com] >>> Sent: 18 June 2016 13:08 >>> To: Mário Luzeiro >>> Cc: Cirilo Bernardo; Chris Pavlina; kicad-developers@lists.launchpad.net >>> Subject: Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation >>> >>> Hi Mario, >>> >>> I just tried to test this, and I will comment a bit. >>> >>> It seems that it cannot abort while performing the post processing shader. >>> >>> When in opengl mode and you hit the render button, it will show the lowres >>> raytrace. I think it might be better to keep showing the last opengl image >>> instead of the lowres raytrace, maybe. >>> >>> Also, there is a black border when in raytracing mode. When I resize the >>> window it will short of change in jumps. I assume this is because you have >>> a "discrete" size for the image itself. Is this something you plan to >>> change/fix? ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation
Hi Mario I have noticed someting new. When I hit edit on a footprint, then switch to the 3D Settings tab it will freeze briefly until the 3D preview is assembled. Ok. Then I close the dialog on cancel. Then I open it again on the same footprint and it now shows the 3D Settings tab directly instead of the Properties tab, but now it is seen that the content in the 3D preview is the image on the screen from the Opengal (GAL) canvas that was in pcbnew itself. Maybe the 3D preview need to initialize a black canvas to avoid this transient artifact? Nick 2016-06-19 22:36 GMT+02:00 Nick Østergaard : > 2016-06-19 20:09 GMT+02:00 Mário Luzeiro : >> Hi Nick, >> >> Thanks for the comments. >> >> >>> It seems that it cannot abort while performing the post processing shader. >> >> True, but.. What CPU do you have? > > Intel(R) Core(TM) i5 CPU M 540 @ 2.53GHz > > That is a two core cpu with hyperthreading of 4. > >> It should take just hundreds of ms ... up to <1s depending on many cores you >> have. >> > > It takes about a second. If I time it manually I get about 1.4 to 1.5 > seconds, by looking at the status bar. I can even make it three to > five seconds. Same board, just zoomed in. It is not a complex board, > it just contains a few footprints, a three VRML models and a STEP > model. > >> >>> When in opengl mode and you hit the render button, it will show the lowres >>> raytrace. >>> I think it might be better to keep showing the last opengl image instead of >>> the lowres raytrace, maybe. >> >> I implemented that suggestion, check my latest branch updates. >> > > That feels way better. > >> >>> Also, there is a black border when in raytracing mode. >>> When I resize the window it will short of change in jumps. >>> I assume this is because you have a "discrete" size for the image itself. >>> Is this something you plan to change/fix? >> >> At this moment it is not an easy change. >> But with your previous suggestion and some other changes I did (in >> raytracing mode preview) it may looks more OK. >> >> The render is optimized in ray packages. One possible solution will be in >> future to render to a bigger than screen buffer resolution, then draw that >> buffer on the windows. That will waste some computation but should be OK. >> > > I think that will be a sane solution. I don't mind too much, I just > noticed the behaivour. > >> Anyway... a black frame is something that increase the value price of your >> picture ;) > > I think it needs to be a frame of gold leafs. :P > >> >> Mario >> >> >> From: Nick Østergaard [oe.n...@gmail.com] >> Sent: 18 June 2016 13:08 >> To: Mário Luzeiro >> Cc: Cirilo Bernardo; Chris Pavlina; kicad-developers@lists.launchpad.net >> Subject: Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation >> >> Hi Mario, >> >> I just tried to test this, and I will comment a bit. >> >> It seems that it cannot abort while performing the post processing shader. >> >> When in opengl mode and you hit the render button, it will show the lowres >> raytrace. I think it might be better to keep showing the last opengl image >> instead of the lowres raytrace, maybe. >> >> Also, there is a black border when in raytracing mode. When I resize the >> window it will short of change in jumps. I assume this is because you have a >> "discrete" size for the image itself. Is this something you plan to >> change/fix? ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] PATCH: OS X copy/close bug fix
On 6/22/2016 10:33 AM, Collin Anderson wrote: > I just discovered that OS X does in fact have similar behavior for buttons. > In most dialog windows, hitting command and the first letter of the text will > 'click' the button, but this only works when the letter doesn't conflict with > other shortcuts (like command-c or command-v for example). > > To get around that, it just remaps close/cancel to command-period (command-.) > instead of command-C. > > Something weird is going on with how wxWidgets handles this. I think the > above behavior is done deep in the Cocoa API or something, and is not > something any program needs to specifically implement. I say this because > certain windows in KiCad actually have this correct behavior, even the first > letter activating the button. > > More troubling though is I just noticed that in windows where this behavior > is not working, other things are broken too. In OS X, you can use tab and > the arrow keys to highlight widgets like buttons, text fields, whatever. > Additional capabilities can be enabled in the accessibility section of system > preferences, and for many vision or motor impaired users, this ability to > highlight widgets is vital to them being able to use software. For example, > you can have text-to-speech enabled such that it will read the text of a > button currently highlighted. > > Anyway, this functionality is completely absent in any window where button > shortcut behavior is also broken. It is actually impossible to high light or > operate the GUI without a mouse in these windows. > > HOWEVER, all of that works flawlessly in the windows with the shortcuts > working. > > This seems completely separate from the command-c closing issue, and adding > or removing the "&" to the button string does not influence it. I think its > probably something to do with the window type. > > Examples of windows with correct behavior: > > Preferences in pcbnew > Most of the dimension dialogs in pcbnew > Color selection window for layers (you can also hit command-A and it > will click apply) > > Non-working windows: > Preferences in eeschema > most more complex windows (component library editor, paths editor, > netlist import/export, etc). I looked at some of the dialogs you've listed and they are all are derived from DIALOG_SHIM so it's not that. It may be worth looking at each dialog to see what events we are intercepting and whether or not that is the issue. The fact that some dialogs work properly and others do not makes me think that it could be an issue with our dialog design rather than an issue with wxWidgets. > > > > I suppose the 'proper' solution would be to disable wx's direct handling of > button shortcuts for OS X, while figuring out whatever it is that is letting > OS X perform native behavior in some windows or not others. > > > Sorry, this is all just observational stuff, I can't really be of much help > until or if I get a better handle on wx. > > That said, as an OS X user, I didn't even notice any of this until today, and > I've been using KiCad for a year+ now. So its hardly mission critical. I > also doubt there is anyone who is vision or motor impaired who is doing EDA > tasks with KiCad. > > Still odd though. > It may not be that odd. Some of this is due to wxGrid (and I suspect wxListCtlr and wxListView) behavior. wxGrid intercepts the usual return key behavior when you are editing a grid cell so the default button (OK) never receives the return key. This isn't that unusual. I've tested other non-wxWidgets applications with grids in dialog boxes and the behavior is similar. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] PATCH: OS X copy/close bug fix
I just discovered that OS X does in fact have similar behavior for buttons. In most dialog windows, hitting command and the first letter of the text will 'click' the button, but this only works when the letter doesn't conflict with other shortcuts (like command-c or command-v for example). To get around that, it just remaps close/cancel to command-period (command-.) instead of command-C. Something weird is going on with how wxWidgets handles this. I think the above behavior is done deep in the Cocoa API or something, and is not something any program needs to specifically implement. I say this because certain windows in KiCad actually have this correct behavior, even the first letter activating the button. More troubling though is I just noticed that in windows where this behavior is not working, other things are broken too. In OS X, you can use tab and the arrow keys to highlight widgets like buttons, text fields, whatever. Additional capabilities can be enabled in the accessibility section of system preferences, and for many vision or motor impaired users, this ability to highlight widgets is vital to them being able to use software. For example, you can have text-to-speech enabled such that it will read the text of a button currently highlighted. Anyway, this functionality is completely absent in any window where button shortcut behavior is also broken. It is actually impossible to high light or operate the GUI without a mouse in these windows. HOWEVER, all of that works flawlessly in the windows with the shortcuts working. This seems completely separate from the command-c closing issue, and adding or removing the "&" to the button string does not influence it. I think its probably something to do with the window type. Examples of windows with correct behavior: Preferences in pcbnew Most of the dimension dialogs in pcbnew Color selection window for layers (you can also hit command-A and it will click apply) Non-working windows: Preferences in eeschema most more complex windows (component library editor, paths editor, netlist import/export, etc). I suppose the 'proper' solution would be to disable wx's direct handling of button shortcuts for OS X, while figuring out whatever it is that is letting OS X perform native behavior in some windows or not others. Sorry, this is all just observational stuff, I can't really be of much help until or if I get a better handle on wx. That said, as an OS X user, I didn't even notice any of this until today, and I've been using KiCad for a year+ now. So its hardly mission critical. I also doubt there is anyone who is vision or motor impaired who is doing EDA tasks with KiCad. Still odd though. -- "Violence is the last refuge of the incompetent." - Isaac Asimov > On Jun 22, 2016, at 6:59 AM, Bernhard Stegmaier > wrote: > > On 22.06.2016 14:44, Collin Anderson wrote: >> I have been using a version of wx patched with my hacky patch for >> about a month or so, and haven't run into any issues. So I think the >> mechanism (removing the & in the start of the button string) is pretty >> safe. > > I looked around a bit in GUI guidelines and other OS X applications back then > and it seems that OS X never uses such hot-keys/shortcuts for buttons (or > whatever it is called). > I wanted to check if it is possible somewhere in a common button class to > just filter out "&" completely... to avoid that any user defined button > defines maybe other problematic shortcuts. > Unfortuantely, not much time lately to spend on this. > > > Regards, > Bernhard ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] PATCH: OS X copy/close bug fix
On 22.06.2016 14:44, Collin Anderson wrote: I have been using a version of wx patched with my hacky patch for about a month or so, and haven't run into any issues. So I think the mechanism (removing the & in the start of the button string) is pretty safe. I looked around a bit in GUI guidelines and other OS X applications back then and it seems that OS X never uses such hot-keys/shortcuts for buttons (or whatever it is called). I wanted to check if it is possible somewhere in a common button class to just filter out "&" completely... to avoid that any user defined button defines maybe other problematic shortcuts. Unfortuantely, not much time lately to spend on this. Regards, Bernhard ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] PATCH: OS X copy/close bug fix
> On Jun 19, 2016, at 4:05 PM, Chris Pavlina wrote: > > God I hate wx. > Me too. Time to migrate KiCad to Qt, perhaps? I'm joking of course. ;) Anyway, thanks for being willing to patch wx a little more, and to Mr. Staumbaugh for approving it. I (somewhat grumpily) tried to get my quick and dirty fix, but really don't know what I am doing when it comes to wx and I think the patch was just a #ifdef block, very hacky. Or something like that. May is too far back to remember :). I am glad someone is finally going to hopefully do it properly. I have been using a version of wx patched with my hacky patch for about a month or so, and haven't run into any issues. So I think the mechanism (removing the & in the start of the button string) is pretty safe. -- "Violence is the last refuge of the incompetent." - Isaac Asimov > On Jun 19, 2016, at 4:05 PM, Chris Pavlina wrote: > > God I hate wx. > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation
Le 22/06/2016 à 10:37, Mário Luzeiro a écrit : > Hi JP, > >> for instance, when changing material options, the 3D board is not redrawn, >> giving the >> impression of an unresponsive command > > You mean when changing options in the Preferences? It is true that some > commands are not updating > / reload the view, I didn't made yet a proper logic behavior on that because > some of the reasons > explained below related with reloading. > >> 1 - your rev 6066 (Do not redraw the 3D viewer after a change in pcbnew) is >> not good. > >> I saw the comment: // This function is used by moduleframe.cpp // while >> editing the pcb board, >> so it will not redraw to not slow the pcbnew But if the user displays the 3D >> view during an >> edition, he expects to see the changes (on my computer, a change in >> footprint editor takes less >> than 0.1 sec to be redrawn in the 3D viewer) > > As you see in the comment, it was firstly implemented that way: Any change on > pcbnew it will > reload the 3D-Viewer and redraw. But after some user feedback (Maurice) and I > try it my self, on > complex boards (eg: with fill zones) it will take longer (eg: the video demo, > depending on the 3D > options, can take 2 .. 10 seconds) Yes, I missed the board editor. Perhaps (as a first approach) it could be worth to separate the 3D view rebuild when the rebuild comes from the 3D viewer, or the board/component editor. (perhaps for now an option like bool aRebuildNow in a reload request). > > During that time, the 3D-viewer will use as much as possible the CPU to > reload the board and it > is not practical to make changes during that time on pcbnew. Everytime you > change a footprint or > track.. etc. How does the stable 3d-viewer behaves? I understood that it was > not updating until > you click on the windows. I was trying to follow the same behavior. > > > This is all related with some of my initial idea just before start working on > this new 3D viewer, > I was expecting that the changes on pcbnew could be fast updated on 3D-viewer > - almost realtime. > At this moment, I didn't implemented it yet because I was looking for changes > on pcbnew that will > be needed. For instance, the pcbnew is just flagging that the 3D viewer needs > to be reload, but I > was looking for a way that it could tell with more precision what changed. So > it will be possible > to tell if it was a footprint change, what layers were effected, if the fill > zones changed, > etc.. > > that way, it would be possible to just change that specific part and quickly > update the > 3d-viewer. > > That is way I didn't yet implement properly the updates while changing > parameters (Preferences) > because I was looking for some general way to flag with precision the > 3d-viewer on what changed. > > Any suggestions? Would it be possible to do on pcbnew? Clearly, flagging that the 3D viewer needs to rebuild the view needs a finer info than just rebuild the 3D view. At least, the footprint editor can ask for an immediate rebuild, and the board editor a rebuild only when the 3D viewer has the focus. I do not see any problem to modify/optimize Pcbnew for that. We can even use a more sophisticated communication between the 3D viewer and pcbnew (based on messages, like cross-probing between Eeschema and Pcbnew). > > >> 2 - A minor other issue: if you rotate the view from the toolbar icons, >> there is a strange mix >> of raytracing and opengl mode, until you change the view from the mouse. > > Yeah there are still some strange states, I will have a look... > >> Thanks, Mário, for your hard work. > > Thanks for your valuable testing! Mario > Thanks. -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation
Hi JP, > for instance, when changing material options, the 3D board is not redrawn, > giving the impression of an unresponsive command You mean when changing options in the Preferences? It is true that some commands are not updating / reload the view, I didn't made yet a proper logic behavior on that because some of the reasons explained below related with reloading. > 1 - your rev 6066 (Do not redraw the 3D viewer after a change in pcbnew) is > not good. > I saw the comment: > // This function is used by moduleframe.cpp > // while editing the pcb board, so it will not redraw to not slow the > pcbnew > But if the user displays the 3D view during an edition, he expects to see the > changes > (on my computer, a change in footprint editor takes less than 0.1 sec to be > redrawn in the 3D viewer) As you see in the comment, it was firstly implemented that way: Any change on pcbnew it will reload the 3D-Viewer and redraw. But after some user feedback (Maurice) and I try it my self, on complex boards (eg: with fill zones) it will take longer (eg: the video demo, depending on the 3D options, can take 2 .. 10 seconds) During that time, the 3D-viewer will use as much as possible the CPU to reload the board and it is not practical to make changes during that time on pcbnew. Everytime you change a footprint or track.. etc. How does the stable 3d-viewer behaves? I understood that it was not updating until you click on the windows. I was trying to follow the same behavior. This is all related with some of my initial idea just before start working on this new 3D viewer, I was expecting that the changes on pcbnew could be fast updated on 3D-viewer - almost realtime. At this moment, I didn't implemented it yet because I was looking for changes on pcbnew that will be needed. For instance, the pcbnew is just flagging that the 3D viewer needs to be reload, but I was looking for a way that it could tell with more precision what changed. So it will be possible to tell if it was a footprint change, what layers were effected, if the fill zones changed, etc.. that way, it would be possible to just change that specific part and quickly update the 3d-viewer. That is way I didn't yet implement properly the updates while changing parameters (Preferences) because I was looking for some general way to flag with precision the 3d-viewer on what changed. Any suggestions? Would it be possible to do on pcbnew? > 2 - A minor other issue: > if you rotate the view from the toolbar icons, there is a strange mix of > raytracing and opengl > mode, until you change the view from the mouse. Yeah there are still some strange states, I will have a look... > Thanks, Mário, for your hard work. Thanks for your valuable testing! Mario From: jp charras [jp.char...@wanadoo.fr] Sent: 22 June 2016 07:33 To: Mário Luzeiro; kicad-developers@lists.launchpad.net Subject: Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation Le 21/06/2016 à 19:07, Mário Luzeiro a écrit : >> I think there are other tweaks to be made but they can wait. :) > About tweaks, I found 2 minor issues: 1 - your rev 6066 (Do not redraw the 3D viewer after a change in pcbnew) is not good. It has side effects: for instance, when changing material options, the 3D board is not redrawn, giving the impression of an unresponsive command. I saw the comment: // This function is used by moduleframe.cpp // while editing the pcb board, so it will not redraw to not slow the pcbnew But if the user displays the 3D view during an edition, he expects to see the changes (on my computer, a change in footprint editor takes less than 0.1 sec to be redrawn in the 3D viewer) 2 - A minor other issue: in Opengl render, if you click on the thirst icon of the toolbar, you run the raytracing only once. This is true if you change the zoo, orientation ... from the mouse. But if you rotate the view from the toolbar icons, there is a strange mix of raytracing and opengl mode, until you change the view from the mouse. Thanks, Mário, for your hard work. -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
