Re: [Kicad-developers] Dialog SetFocus && SetSelection patch

[José Ignacio]

You need to use wxformbuilder, otherwise someone else editing the
dialog would overwrite your changes.

On Thu, Sep 1, 2016 at 6:51 PM, Diogo Condeço  wrote:
> Hi all,
>
> I've attached a patch to correct some dialog behaviour in kicad. Tested on
> mac os x and windows...
>
> Affected dialogs are:
>
> pcbnew > find component - set focus and selection
> pcbnew > pad properties - set focus and selection
> eeschema > add component - only set focus
>
> IMHO the correct behaviour should be set focus to the first or most relevant
> field and select the text in it for prompt replacement... In some cases this
> might be different like eeschema add component, where the cursor goes to the
> text field but the selection goes the the last one used (if it exists).
>
> I've also managed to get edit field in eeschema (edit reference/value field
> dialog) to work on mac os x, but in windows it isn't working 100%, so I will
> release it later... Since this dialog is shared for different values, it is
> a little bit trickier...
>
> The patch is quite simple just add the OnDialogInit event to take care of
> the setfocus and setselection operation.
>
> I don't have wxformbuilder to edit the generated files, so I did it by
> hand... so forgive me for not caring about the // PLEASE DO "NOT" EDIT THIS
> FILE! note
>
> Please test it and let me know the result... Also if you find more
> problematic dialogs let me know and I can change them. I am 1% sure
> there are more with setfocus problems... it's just a question of find them.
>
> Once the other dialog is working I will post the patch.
>
> --
> Diogo Condeço
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] OCE plugin for 3D viewer

[Chris Pavlina]

Okay, this is friggin awesome. I can finally have models of
*everything*, it's so nice! :)

Sexy PCB shot: https://misc.c4757p.com/12091-motherboard.png

Thanks Cirilo!

On Thu, Sep 01, 2016 at 04:45:33PM -0400, Wayne Stambaugh wrote:
> 
> 
> On 9/1/2016 4:18 PM, Chris Pavlina wrote:
> > On Thu, Sep 01, 2016 at 04:10:13PM -0400, Wayne Stambaugh wrote:
> >> On 9/1/2016 2:29 PM, José Ignacio wrote:
> >>> On Thu, Sep 1, 2016 at 12:02 PM, Wayne Stambaugh  
> >>> wrote:
>  Sorry it took so long.  I took a look at Cirilo's changes an it looks
>  good.  We still need a PKGBUILD file for msys2 with JPs patch so we
>  don't have to build oce from source.
> 
>  When I merge Cirilo's 3d-plugin branch and I had to create a commit
>  message which made me the commit author.  This seems brain dead to me.
>  Here is the new commit log entry:
> 
>  commit 12c26047bffd54ccbb88348acfe7f653556450da
>  Merge: fcedef8 b656a81
>  Author: Wayne Stambaugh 
>  Date:   Thu Sep 1 11:59:44 2016 -0400
> 
>  Merge remote-tracking branch 'cirilo/3d-plugin'
> 
>  I really only want to show Cirilo's commit log entries as a new commit.
>  WTF! I'm liking git less every time I use it.  What do I need to do to
>  get the correct commit history from Cirlo's 3d-plugin branch?
> 
> >>>
> >>> Cirilo's commit history remains intact in the merged branch, you just
> >>> need to walk through that branch instead of master when reading the
> >>> commit logs. If cirilo's branch was rebased to the current master you
> >>> could do a fast-forward merge, which would graft his commits into the
> >>> master branch and make his last commit the "new master". In either
> >>> case the history is perfectly readable.
> >>>
> >>
> >> Yes but before I got chance to push my branch, Chris pushed a change so
> >> when I pulled his changes, git conveniently created yet another commit
> >> message.  Do we really want all this extra cruft in the commit log or do
> >> we want to rebase against the kicad master?
> > 
> > Start using git pull --rebase like I suggested earlier, it would avoid
> > that.
> > 
> 
> I pushed Cirilo's OCE changes so hopefully I didn't fsck up the main
> repo too badly.  Thank you Cirilo for the OCE plugin work.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Dialog SetFocus && SetSelection patch

[Chris Pavlina]

I don't have time to test this right now, but I may later. In any case,
you HAVE to use wxformbuilder, we will not accept a patch that edits
them directly. If you edit them directly, any edits will be lost in the
figure if anyone else tries to use wxformbuilder on them. Please, just
download it.

On Fri, Sep 02, 2016 at 12:51:30AM +0100, Diogo Condeço wrote:
> Hi all,
> 
> I've attached a patch to correct some dialog behaviour in kicad. Tested on
> mac os x and windows...
> 
> Affected dialogs are:
> 
> pcbnew > find component - set focus and selection
> pcbnew > pad properties - set focus and selection
> eeschema > add component - only set focus
> 
> IMHO the correct behaviour should be set focus to the first or most
> relevant field and select the text in it for prompt replacement... In some
> cases this might be different like eeschema add component, where the cursor
> goes to the text field but the selection goes the the last one used (if it
> exists).
> 
> I've also managed to get edit field in eeschema (edit reference/value field
> dialog) to work on mac os x, but in windows it isn't working 100%, so I
> will release it later... Since this dialog is shared for different values,
> it is a little bit trickier...
> 
> The patch is quite simple just add the OnDialogInit event to take care of
> the setfocus and setselection operation.
> 
> I don't have wxformbuilder to edit the generated files, so I did it by
> hand... so forgive me for not caring about the // PLEASE DO "NOT" EDIT THIS
> FILE! note
> 
> Please test it and let me know the result... Also if you find more
> problematic dialogs let me know and I can change them. I am 1% sure
> there are more with setfocus problems... it's just a question of find them.
> 
> Once the other dialog is working I will post the patch.
> 
> --
> Diogo Condeço


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Dialog SetFocus && SetSelection patch

[Diogo Condeço]

Hi all,

I've attached a patch to correct some dialog behaviour in kicad. Tested on
mac os x and windows...

Affected dialogs are:

pcbnew > find component - set focus and selection
pcbnew > pad properties - set focus and selection
eeschema > add component - only set focus

IMHO the correct behaviour should be set focus to the first or most
relevant field and select the text in it for prompt replacement... In some
cases this might be different like eeschema add component, where the cursor
goes to the text field but the selection goes the the last one used (if it
exists).

I've also managed to get edit field in eeschema (edit reference/value field
dialog) to work on mac os x, but in windows it isn't working 100%, so I
will release it later... Since this dialog is shared for different values,
it is a little bit trickier...

The patch is quite simple just add the OnDialogInit event to take care of
the setfocus and setselection operation.

I don't have wxformbuilder to edit the generated files, so I did it by
hand... so forgive me for not caring about the // PLEASE DO "NOT" EDIT THIS
FILE! note

Please test it and let me know the result... Also if you find more
problematic dialogs let me know and I can change them. I am 1% sure
there are more with setfocus problems... it's just a question of find them.

Once the other dialog is working I will post the patch.

--
Diogo Condeço


0001-Dialogs-SetFocus-SetSelection.patch
Description: Binary data
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] OCE plugin for 3D viewer

[Chris Pavlina]

On Thu, Sep 01, 2016 at 04:45:33PM -0400, Wayne Stambaugh wrote:
> 
> 
> On 9/1/2016 4:18 PM, Chris Pavlina wrote:
> > On Thu, Sep 01, 2016 at 04:10:13PM -0400, Wayne Stambaugh wrote:
> >> On 9/1/2016 2:29 PM, José Ignacio wrote:
> >>> On Thu, Sep 1, 2016 at 12:02 PM, Wayne Stambaugh  
> >>> wrote:
>  Sorry it took so long.  I took a look at Cirilo's changes an it looks
>  good.  We still need a PKGBUILD file for msys2 with JPs patch so we
>  don't have to build oce from source.
> 
>  When I merge Cirilo's 3d-plugin branch and I had to create a commit
>  message which made me the commit author.  This seems brain dead to me.
>  Here is the new commit log entry:
> 
>  commit 12c26047bffd54ccbb88348acfe7f653556450da
>  Merge: fcedef8 b656a81
>  Author: Wayne Stambaugh 
>  Date:   Thu Sep 1 11:59:44 2016 -0400
> 
>  Merge remote-tracking branch 'cirilo/3d-plugin'
> 
>  I really only want to show Cirilo's commit log entries as a new commit.
>  WTF! I'm liking git less every time I use it.  What do I need to do to
>  get the correct commit history from Cirlo's 3d-plugin branch?
> 
> >>>
> >>> Cirilo's commit history remains intact in the merged branch, you just
> >>> need to walk through that branch instead of master when reading the
> >>> commit logs. If cirilo's branch was rebased to the current master you
> >>> could do a fast-forward merge, which would graft his commits into the
> >>> master branch and make his last commit the "new master". In either
> >>> case the history is perfectly readable.
> >>>
> >>
> >> Yes but before I got chance to push my branch, Chris pushed a change so
> >> when I pulled his changes, git conveniently created yet another commit
> >> message.  Do we really want all this extra cruft in the commit log or do
> >> we want to rebase against the kicad master?
> > 
> > Start using git pull --rebase like I suggested earlier, it would avoid
> > that.
> > 
> 
> I pushed Cirilo's OCE changes so hopefully I didn't fsck up the main
> repo too badly.  Thank you Cirilo for the OCE plugin work.

Looks good to me, no fscking visible from here :)

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] OCE plugin for 3D viewer

[Wayne Stambaugh]

On 9/1/2016 4:18 PM, Chris Pavlina wrote:
> On Thu, Sep 01, 2016 at 04:10:13PM -0400, Wayne Stambaugh wrote:
>> On 9/1/2016 2:29 PM, José Ignacio wrote:
>>> On Thu, Sep 1, 2016 at 12:02 PM, Wayne Stambaugh  
>>> wrote:
 Sorry it took so long.  I took a look at Cirilo's changes an it looks
 good.  We still need a PKGBUILD file for msys2 with JPs patch so we
 don't have to build oce from source.

 When I merge Cirilo's 3d-plugin branch and I had to create a commit
 message which made me the commit author.  This seems brain dead to me.
 Here is the new commit log entry:

 commit 12c26047bffd54ccbb88348acfe7f653556450da
 Merge: fcedef8 b656a81
 Author: Wayne Stambaugh 
 Date:   Thu Sep 1 11:59:44 2016 -0400

 Merge remote-tracking branch 'cirilo/3d-plugin'

 I really only want to show Cirilo's commit log entries as a new commit.
 WTF! I'm liking git less every time I use it.  What do I need to do to
 get the correct commit history from Cirlo's 3d-plugin branch?

>>>
>>> Cirilo's commit history remains intact in the merged branch, you just
>>> need to walk through that branch instead of master when reading the
>>> commit logs. If cirilo's branch was rebased to the current master you
>>> could do a fast-forward merge, which would graft his commits into the
>>> master branch and make his last commit the "new master". In either
>>> case the history is perfectly readable.
>>>
>>
>> Yes but before I got chance to push my branch, Chris pushed a change so
>> when I pulled his changes, git conveniently created yet another commit
>> message.  Do we really want all this extra cruft in the commit log or do
>> we want to rebase against the kicad master?
> 
> Start using git pull --rebase like I suggested earlier, it would avoid
> that.
> 

I pushed Cirilo's OCE changes so hopefully I didn't fsck up the main
repo too badly.  Thank you Cirilo for the OCE plugin work.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Git transition

[Nick Østergaard]

I think the mirror should be working again now, we will see when
something is pushed to lp.

2016-08-25 7:40 GMT+02:00 Nick Østergaard :
> I will try to make the mirror be synced from launchpad, at latest on friday.
>
> 2016-08-24 5:39 GMT+02:00 kinichiro inoguchi :
>> Hi,
>>
>> I hope mirror on GitHub keeps refreshing from new git repo on Launchpad.
>> https://github.com/KiCad/kicad-source-mirror
>>
>> For GUI translators task,
>> we need to download source code tarball to obtain strings in the GUI.
>>
>> On GitHub, we could download every committed rev as tarball by one click.
>> On Launchpad, it seems that only tagged rev can be downloaded.
>>
>> If POT file for GUI is provided for every commits, maybe, GUI translators do
>> not need to access mirror, though.
>>
>> Best regards
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] OCE plugin for 3D viewer

[Chris Pavlina]

On Thu, Sep 01, 2016 at 04:10:13PM -0400, Wayne Stambaugh wrote:
> On 9/1/2016 2:29 PM, José Ignacio wrote:
> > On Thu, Sep 1, 2016 at 12:02 PM, Wayne Stambaugh  
> > wrote:
> >> Sorry it took so long.  I took a look at Cirilo's changes an it looks
> >> good.  We still need a PKGBUILD file for msys2 with JPs patch so we
> >> don't have to build oce from source.
> >>
> >> When I merge Cirilo's 3d-plugin branch and I had to create a commit
> >> message which made me the commit author.  This seems brain dead to me.
> >> Here is the new commit log entry:
> >>
> >> commit 12c26047bffd54ccbb88348acfe7f653556450da
> >> Merge: fcedef8 b656a81
> >> Author: Wayne Stambaugh 
> >> Date:   Thu Sep 1 11:59:44 2016 -0400
> >>
> >> Merge remote-tracking branch 'cirilo/3d-plugin'
> >>
> >> I really only want to show Cirilo's commit log entries as a new commit.
> >> WTF! I'm liking git less every time I use it.  What do I need to do to
> >> get the correct commit history from Cirlo's 3d-plugin branch?
> >>
> > 
> > Cirilo's commit history remains intact in the merged branch, you just
> > need to walk through that branch instead of master when reading the
> > commit logs. If cirilo's branch was rebased to the current master you
> > could do a fast-forward merge, which would graft his commits into the
> > master branch and make his last commit the "new master". In either
> > case the history is perfectly readable.
> > 
> 
> Yes but before I got chance to push my branch, Chris pushed a change so
> when I pulled his changes, git conveniently created yet another commit
> message.  Do we really want all this extra cruft in the commit log or do
> we want to rebase against the kicad master?

Start using git pull --rebase like I suggested earlier, it would avoid
that.

> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] OCE plugin for 3D viewer

[Wayne Stambaugh]

On 9/1/2016 2:29 PM, José Ignacio wrote:
> On Thu, Sep 1, 2016 at 12:02 PM, Wayne Stambaugh  wrote:
>> Sorry it took so long.  I took a look at Cirilo's changes an it looks
>> good.  We still need a PKGBUILD file for msys2 with JPs patch so we
>> don't have to build oce from source.
>>
>> When I merge Cirilo's 3d-plugin branch and I had to create a commit
>> message which made me the commit author.  This seems brain dead to me.
>> Here is the new commit log entry:
>>
>> commit 12c26047bffd54ccbb88348acfe7f653556450da
>> Merge: fcedef8 b656a81
>> Author: Wayne Stambaugh 
>> Date:   Thu Sep 1 11:59:44 2016 -0400
>>
>> Merge remote-tracking branch 'cirilo/3d-plugin'
>>
>> I really only want to show Cirilo's commit log entries as a new commit.
>> WTF! I'm liking git less every time I use it.  What do I need to do to
>> get the correct commit history from Cirlo's 3d-plugin branch?
>>
> 
> Cirilo's commit history remains intact in the merged branch, you just
> need to walk through that branch instead of master when reading the
> commit logs. If cirilo's branch was rebased to the current master you
> could do a fast-forward merge, which would graft his commits into the
> master branch and make his last commit the "new master". In either
> case the history is perfectly readable.
> 

Yes but before I got chance to push my branch, Chris pushed a change so
when I pulled his changes, git conveniently created yet another commit
message.  Do we really want all this extra cruft in the commit log or do
we want to rebase against the kicad master?

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] PNS router patches batch #1

[Michael Steinberg]

Hello

Oh, thank you for noticing. No that was purely my stupidity. :(

I created a new branch "pnsbranch" rebased on master without this 
problem. ( git clone -b pnsbranch https://git.launchpad.net/~decimad/kicad )


@Tom:
Its commit hashes will obviously not match the patch hashes anymore. 
Should I create a new patch set?


Michael

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] PNS router patches batch #1

[Clemens Koller]

Hello, Michael!

Is there a git branch which can be pulled to test your patches?

By a quick look, I was wondering if you intentionally kept backup
copies (or temporary files) of some files or if that's was a mistake?

See: 1-move-pns-into-namespace-pns.patch, line 1451ff

-8<-
diff --git a/pcbnew/router/pns_node.cpp.orig b/pcbnew/router/pns_node.cpp.orig
new file mode 100644
index 000..8fe69ff
--- /dev/null
+++ b/pcbnew/router/pns_node.cpp.orig
@@ -0,0 +1,1340 @@
+/*
+ * KiRouter - a push-and-(sometimes-)shove PCB router
+ *
+ * Copyright (C) 2013-2014 CERN
-8<-

And we have some unresolved merge conflicts in the .orig file.
See: 1-move-pns-into-namespace-pns.patch, line 1995ff
-8<-
+<<< HEAD
+addSolid( aSolid.release() );
+===
+aSolid->SetOwner( this );
+addSolidIndex( aSolid.release() );
+>>> 0371f40... remove garbage items functionality (delete removed items 
early)
+}
+
+void NODE::addViaIndex( VIA* aVia )
+{
+linkJoint( aVia->Pos(), aVia->Layers(), aVia->Net(), aVia );
+m_index->Add( aVia );
+}
+
+void NODE::Add( std::unique_ptr< VIA > aVia )
+{
+<<< HEAD
+addVia( aVia.release() );
+===
+aVia->SetOwner( this );
-8<-

This should not be necessary when we have SCM.
You might want to clean up your patches...

Regards,

Clemens


On 2016-09-01 18:12, Michael Steinberg wrote:
> Hello,
> 
> as part of my efforts on the pns-router some refactoring patches are 
> attached. Prefix-numbers indicate the patch order.
> The router is moved into namespace PNS, some places are decorated with 
> unique_ptr usage, some code quality improvements and then some 
> refactorings in preparation for future improvements which are in the 
> pipeline.
> A batch of experimental patches will follow shortly. My sincere hopes of 
> not breaking anything are attached implicitly.
> 
> Cheers!
> Michael
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] OCE plugin for 3D viewer

[Chris Pavlina]

On Thu, Sep 01, 2016 at 01:02:53PM -0400, Wayne Stambaugh wrote:
> Sorry it took so long.  I took a look at Cirilo's changes an it looks
> good.  We still need a PKGBUILD file for msys2 with JPs patch so we
> don't have to build oce from source.
> 
> When I merge Cirilo's 3d-plugin branch and I had to create a commit
> message which made me the commit author.  This seems brain dead to me.
> Here is the new commit log entry:
> 
> commit 12c26047bffd54ccbb88348acfe7f653556450da
> Merge: fcedef8 b656a81
> Author: Wayne Stambaugh 
> Date:   Thu Sep 1 11:59:44 2016 -0400
> 
> Merge remote-tracking branch 'cirilo/3d-plugin'
> 
> I really only want to show Cirilo's commit log entries as a new commit.
> WTF! I'm liking git less every time I use it.  What do I need to do to
> get the correct commit history from Cirlo's 3d-plugin branch?

Uh... calm down, don't blame git, you're just misunderstanding it :P

YOU ARE the author of the MERGE COMMIT. You did the merge. The authors
of the commits that were merged should remain the same. If you don't
want a merge commit to appear, look up "fast-forward merge", though
those are often discouraged in this case.

> 
> On 9/1/2016 7:35 AM, Nick Østergaard wrote:
> > I would also like to see this merged (I have only tested the out of
> > tree plugin), but I suggest that the build switch is named something
> > prefixed with "KICAD_" like most other kicad specific build switches
> > are, except for the github plugin.  Maybe KICAD_USE_OCE.
> 
> For the sake of consistency, we probably should prefix everything with
> KICAD_.  I always liked the autotools --with- and --enable- prefixes for
> config options.  There is no consistency as far as cmake goes.  CMake
> should have adopted a standard prefix naming convention for options.
> 
> > 
> > And to that I will add that Documentation/development/compiling.md
> > should be updated too to reflect the usage for that compile switch, :)
> 
> Yes, we need to be keeping these up to date.
> 
> > 
> > Nick
> > 
> > 2016-09-01 11:39 GMT+02:00 Tomasz Wlostowski :
> >> On 01.09.2016 10:30, Cirilo Bernardo wrote:
> >>> Just a ping to remind devs of a branch introducing the OCE plugin:
> >>>
> >>> https://code.launchpad.net/~cirilo-bernardo/kicad/+git/kicad-oce/+merge/303513
> >>>
> >>> Since the OCE plugin code must be activated with -DUSE_OCE=ON
> >>> when configuring with CMake, I think it's safe to include this code. 
> >>> Having
> >>> the code in the main base will make it easier for other volunteers to help
> >>> sort out build and deployment issues of the OCE plugin on Windows and
> >>> OSX.
> >>
> >> Hi Cirilo,
> >>
> >> I fully agree to merge the OCE plug-in code. Users have been desperately
> >> asking for ages for STEP & IGES support in the 3d-viewer ;-)
> >>
> >> @Wayne/@Orson: since this is optional, are there any obstacles for the
> >> merge?
> >>
> >> Cheers,
> >> Tom
> >>
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to : kicad-developers@lists.launchpad.net
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> > 
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> > 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] OCE plugin for 3D viewer

[Wayne Stambaugh]

Sorry it took so long.  I took a look at Cirilo's changes an it looks
good.  We still need a PKGBUILD file for msys2 with JPs patch so we
don't have to build oce from source.

When I merge Cirilo's 3d-plugin branch and I had to create a commit
message which made me the commit author.  This seems brain dead to me.
Here is the new commit log entry:

commit 12c26047bffd54ccbb88348acfe7f653556450da
Merge: fcedef8 b656a81
Author: Wayne Stambaugh 
Date:   Thu Sep 1 11:59:44 2016 -0400

Merge remote-tracking branch 'cirilo/3d-plugin'

I really only want to show Cirilo's commit log entries as a new commit.
WTF! I'm liking git less every time I use it.  What do I need to do to
get the correct commit history from Cirlo's 3d-plugin branch?

On 9/1/2016 7:35 AM, Nick Østergaard wrote:
> I would also like to see this merged (I have only tested the out of
> tree plugin), but I suggest that the build switch is named something
> prefixed with "KICAD_" like most other kicad specific build switches
> are, except for the github plugin.  Maybe KICAD_USE_OCE.

For the sake of consistency, we probably should prefix everything with
KICAD_.  I always liked the autotools --with- and --enable- prefixes for
config options.  There is no consistency as far as cmake goes.  CMake
should have adopted a standard prefix naming convention for options.

> 
> And to that I will add that Documentation/development/compiling.md
> should be updated too to reflect the usage for that compile switch, :)

Yes, we need to be keeping these up to date.

> 
> Nick
> 
> 2016-09-01 11:39 GMT+02:00 Tomasz Wlostowski :
>> On 01.09.2016 10:30, Cirilo Bernardo wrote:
>>> Just a ping to remind devs of a branch introducing the OCE plugin:
>>>
>>> https://code.launchpad.net/~cirilo-bernardo/kicad/+git/kicad-oce/+merge/303513
>>>
>>> Since the OCE plugin code must be activated with -DUSE_OCE=ON
>>> when configuring with CMake, I think it's safe to include this code. Having
>>> the code in the main base will make it easier for other volunteers to help
>>> sort out build and deployment issues of the OCE plugin on Windows and
>>> OSX.
>>
>> Hi Cirilo,
>>
>> I fully agree to merge the OCE plug-in code. Users have been desperately
>> asking for ages for STEP & IGES support in the 3d-viewer ;-)
>>
>> @Wayne/@Orson: since this is optional, are there any obstacles for the
>> merge?
>>
>> Cheers,
>> Tom
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] PNS router experimental patches

[Michael Steinberg]

Hi all,
attached are experimental patches for the pns router. The intent is 
refactoring how revisions are handled and thereby improving the peak 
memory footprint on deep springback stacks considerably. Other 
advantages would include a self-contained spatial state without 
complicating interrelations between a set of nodes.
I'd be really grateful for anybody testing this, Chris was already to so 
kind to give it a run during his last session.


Cheers!
Michael
>From 16f4a4cc0c59a244defa49719de4a64ef9bdd702 Mon Sep 17 00:00:00 2001
From: decimad 
Date: Wed, 31 Aug 2016 22:44:00 +0200
Subject: [PATCH] Reimplement PNS::NODE revisioning by means of the the class
 PNS::REVISION

Many changes, still largely untested, this is no patch to be applied without further testing and fixing
---
 pcbnew/router/CMakeLists.txt  |   1 +
 pcbnew/router/length_tuner_tool.cpp   |   4 +-
 pcbnew/router/pns_diff_pair_placer.cpp|  98 +++
 pcbnew/router/pns_diff_pair_placer.h  |  13 +-
 pcbnew/router/pns_dp_meander_placer.cpp   |  42 +--
 pcbnew/router/pns_dp_meander_placer.h |  14 +-
 pcbnew/router/pns_dragger.cpp |  57 ++--
 pcbnew/router/pns_dragger.h   |   9 +-
 pcbnew/router/pns_index.cpp   | 133 +
 pcbnew/router/pns_index.h | 117 +---
 pcbnew/router/pns_kicad_iface.cpp |  12 +-
 pcbnew/router/pns_kicad_iface.h   |   4 +-
 pcbnew/router/pns_line.cpp|   8 +-
 pcbnew/router/pns_line_placer.cpp | 109 
 pcbnew/router/pns_line_placer.h   |  17 +-
 pcbnew/router/pns_meander_placer.cpp  |  46 ++--
 pcbnew/router/pns_meander_placer.h|  12 +-
 pcbnew/router/pns_meander_skew_placer.cpp |  11 +-
 pcbnew/router/pns_node.cpp| 437 ++
 pcbnew/router/pns_node.h  | 203 +-
 pcbnew/router/pns_placement_algo.h|  11 +-
 pcbnew/router/pns_revision.cpp|  34 ++-
 pcbnew/router/pns_revision.h  |  19 +-
 pcbnew/router/pns_router.cpp  |  60 ++--
 pcbnew/router/pns_router.h|  22 +-
 pcbnew/router/pns_shove.cpp   | 161 ++-
 pcbnew/router/pns_shove.h |   7 +-
 pcbnew/router/pns_tool_base.cpp   |   6 +-
 pcbnew/router/pns_topology.cpp|   8 +-
 pcbnew/router/router_tool.cpp |   8 +-
 30 files changed, 883 insertions(+), 800 deletions(-)
 create mode 100644 pcbnew/router/pns_index.cpp

diff --git a/pcbnew/router/CMakeLists.txt b/pcbnew/router/CMakeLists.txt
index 12de287..776476e 100644
--- a/pcbnew/router/CMakeLists.txt
+++ b/pcbnew/router/CMakeLists.txt
@@ -28,6 +28,7 @@ set( PCBNEW_PNS_SRCS
 pns_meander_placer_base.cpp
 pns_meander_skew_placer.cpp
 pns_revision.cpp
+	pns_index.cpp
 pns_node.cpp
 pns_optimizer.cpp
 pns_router.cpp
diff --git a/pcbnew/router/length_tuner_tool.cpp b/pcbnew/router/length_tuner_tool.cpp
index e7cc806..b3ae89c 100644
--- a/pcbnew/router/length_tuner_tool.cpp
+++ b/pcbnew/router/length_tuner_tool.cpp
@@ -196,12 +196,12 @@ void LENGTH_TUNER_TOOL::performTuning()
 }
 else if( evt->IsClick( BUT_LEFT ) )
 {
-if( m_router->FixRoute( evt->Position(), NULL ) )
+if( m_router->CommitRoute( evt->Position(), NULL ) )
 break;
 }
 else if( evt->IsAction( _EndTuning ) )
 {
-if( m_router->FixRoute( end, NULL ) )
+if( m_router->CommitRoute( end, NULL ) )
 break;
 }
 else if( evt->IsAction( _AmplDecrease ) )
diff --git a/pcbnew/router/pns_diff_pair_placer.cpp b/pcbnew/router/pns_diff_pair_placer.cpp
index 7c05ddc..0adc06f 100644
--- a/pcbnew/router/pns_diff_pair_placer.cpp
+++ b/pcbnew/router/pns_diff_pair_placer.cpp
@@ -46,10 +46,8 @@ DIFF_PAIR_PLACER::DIFF_PAIR_PLACER( ROUTER* aRouter ) :
 m_netP = 0;
 m_netN = 0;
 m_iteration = 0;
-m_world = NULL;
-m_shove = NULL;
-m_currentNode = NULL;
-m_lastNode = NULL;
+m_shove = nullptr;
+m_node  = nullptr;
 m_placingVia = false;
 m_viaDiameter = 0;
 m_viaDrill = 0;
@@ -73,7 +71,7 @@ DIFF_PAIR_PLACER::~DIFF_PAIR_PLACER()
 
 void DIFF_PAIR_PLACER::setWorld( NODE* aWorld )
 {
-m_world = aWorld;
+m_node = aWorld;
 }
 
 const VIA DIFF_PAIR_PLACER::makeVia( const VECTOR2I& aP, int aNet )
@@ -112,8 +110,8 @@ bool DIFF_PAIR_PLACER::rhMarkObstacles( const VECTOR2I& aP )
 if( !routeHead( aP ) )
 return false;
 
-bool collP = static_cast( m_currentNode->CheckColliding( _currentTrace.PLine() ) );
-bool collN = static_cast( m_currentNode->CheckColliding( _currentTrace.NLine() ) );
+bool collP = static_cast( m_node->CheckColliding( _currentTrace.PLine() ) );
+bool collN = static_cast( m_node->CheckColliding( _currentTrace.NLine() ) );
 
 m_fitOk = !( collP || collN ) ;
 
@@ -148,7 

[Kicad-developers] RFC: use of DXF files

[Cirilo Bernardo]

Hi Folks,

 DXF Import seems to be popular enough that we have the
occasional questions and complaints about how to use it
for a specific task. The items I can think of include:

1. being able to process Layers and associate a named
DXF Layer with a specific KiCad Layer.

2. "I can't import Feature X". This one comes up now and then;
the most popular is "why doesn't kicad support DXF filled
regions?" More recently someone was asking about importing
a DXF Point (what that would represent in KiCad is anyone's guess).

In the past I put a little work into a few minor fixes and adding
PolyLine support for outlines, but I haven't done anything more
since there seems to be no long-term plan for DXF. Does anyone
think some effort should go into a grand plan for how DXF can
interact with KiCad, especially on the Import side? If it is a
useful enough tool and we can come up with a sensible scheme
which general users would find useful I can put in a little time to
code it.

- Cirilo
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] OCE plugin for 3D viewer

[Tomasz Wlostowski]

On 01.09.2016 10:30, Cirilo Bernardo wrote:
> Just a ping to remind devs of a branch introducing the OCE plugin:
> 
> https://code.launchpad.net/~cirilo-bernardo/kicad/+git/kicad-oce/+merge/303513
> 
> Since the OCE plugin code must be activated with -DUSE_OCE=ON
> when configuring with CMake, I think it's safe to include this code. Having
> the code in the main base will make it easier for other volunteers to help
> sort out build and deployment issues of the OCE plugin on Windows and
> OSX.

Hi Cirilo,

I fully agree to merge the OCE plug-in code. Users have been desperately
asking for ages for STEP & IGES support in the 3d-viewer ;-)

@Wayne/@Orson: since this is optional, are there any obstacles for the
merge?

Cheers,
Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] OCE plugin for 3D viewer

[Cirilo Bernardo]

Just a ping to remind devs of a branch introducing the OCE plugin:

https://code.launchpad.net/~cirilo-bernardo/kicad/+git/kicad-oce/+merge/303513

Since the OCE plugin code must be activated with -DUSE_OCE=ON
when configuring with CMake, I think it's safe to include this code. Having
the code in the main base will make it easier for other volunteers to help
sort out build and deployment issues of the OCE plugin on Windows and
OSX. I don't believe there are too many issues at the moment since a
number of volunteers have been able to successfully build and use the
OCE plugin on Windows and OSX.

- Cirilo
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp