[Kicad-developers] small typo

[Marco Ciampa]

eeschema/lib_export.cpp:160

"Write permissions are requured to save library '%s'."

TIA

--


Marco Ciampa

I know a joke about UDP, but you might not get it.



 GNU/Linux User #78271
 FSFE fellow #364




___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Fix for 3D model offset

[Oliver Walters]

Wayne,

Another potential spanner in the works - the footprint files do not store
the file version information. (should they?)

Thus, footprint files cannot be parsed differently based on their file
version. Changing "at" between mm and inches will work for the pcb but not
for the individual footprint files.

On Sun, Nov 12, 2017 at 7:47 AM, Wayne Stambaugh 
wrote:

> I misunderstood the intention of this patch.  I though it had nothing to
> do with the units change patch.  I will revert it.  Please send me the
> file format change patch when you get a chance and I merge them both at
> the same time.  Sorry about the mix up.
>
> On 11/11/2017 03:34 PM, Oliver Walters wrote:
> > Wayne,
> >
> > I had not yet made any changes to the file parser. Have you done this
> > according to your new file-version approach? Or do you want me to submit
> > a further patch implementing that?
> >
> > On 12 Nov 2017 07:16, "Wayne Stambaugh"  > > wrote:
> >
> > Oliver,
> >
> > I committed your patch to the KiCad development branch.
> >
> > Thanks,
> >
> > Wayne
> >
> > On 11/08/2017 05:05 AM, Oliver Walters wrote:
> > > Attached is a patch that fixes the problems I found in my 3D model
> > array
> > > investigation. As discussion on that is stalled for now, this patch
> > > simply fixes the model offset issues.
> > >
> > > 1. Display offset units in 3D preview window
> > >
> > > - Offset units are displayed (either inches or mm)
> > >
> > > 2. Fix offset in 3D rendering
> > >
> > > - It appears that the internal units for 3D model offset (mm) were
> > being
> > > multiplied by 25.4 incorrectly
> > > - Fixed rendering in OGL and Raytracing
> > >
> > > 3. Fix offset in 3D export
> > >
> > > - VRML export
> > > - STEP export
> > >
> > > Oliver
> > >
> > >
> > > ___
> > > Mailing list: https://launchpad.net/~kicad-developers
> > 
> > > Post to : kicad-developers@lists.launchpad.net
> > 
> > > Unsubscribe : https://launchpad.net/~kicad-developers
> > 
> > > More help   : https://help.launchpad.net/ListHelp
> > 
> > >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > 
> > Post to : kicad-developers@lists.launchpad.net
> > 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > 
> > More help   : https://help.launchpad.net/ListHelp
> > 
> >
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Testing New eagle import, problems

[Russell Oliver]

Hi Lachlan,

I was the main developer of the Eagle schematic import plugin and I know
the layout of the Pcbnew Eagle import code pretty well. So If you can
describe further the errors you are seeing that would be great, even if its
just links to the original Eagle files and screen shots of the offending
areas.

Wayne: I'm thinking we to start with to change the text of the Import
Project menu option from "Eagle Cad" to something like "Eagle CAD 6.x+
XML".

Kind Regards
Russell

On Sat, Nov 11, 2017 at 11:58 AM Wayne Stambaugh 
wrote:

> Lachlan,
>
> It looks like your attachment got blocked.  Is there another way to get
> it to us?
>
> Cheers,
>
> Wayne
>
> On 11/10/2017 7:26 PM, Lachlan Audas wrote:
> > A few quick test show the Eagle import has some problems, on the
> Developers
> > version.
> >
> > I would  suggest you do a binary file check,  on sch/pcb files,   and
> warn
> > the user,   that Kicad only supports XML, 6.0+ instead of giving
> confusing
> > passer error messages when it finds a binary file. Example:
> >
> https://github.com/OLIMEX/OLINUXINO/tree/master/HARDWARE/RT5350F/RT5350F-
> > OLinuXino/RT5350F_OLinuXino_Rev_E
> >
> > Others  from OLIMEX  also show up the a number of problems with text
> > showing when they should not, and not displaying text when they should.
> > Example:  Attached.   Sorry for the file size,  But I'm not sure if the
> > mailing list server will block compressed files.
> >
> > Lachlan
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH] Fix wildcard for Eagle XML files.

[Константин Барановский]

--- a/common/wildcards_and_files_ext.cpp
+++ b/common/wildcards_and_files_ext.cpp
@@ -139,7 +139,8 @@ wxString EagleSchematicFileWildcard()

 wxString EagleFilesWildcard()
 {
-return _( "Eagle XML files (*.sch *.brd)|*.sch;*." ) +
FormatWildcardExt( "brd" );
+return _( "Eagle XML files (*.sch *.brd)|*." ) +
+   FormatWildcardExt( "sch" ) + ";*." + FormatWildcardExt( "brd" );
 }
From df1e78d4320873465f0db482086cd3878712f6a9 Mon Sep 17 00:00:00 2001
From: Baranovskiy Konstantin 
Date: Sun, 12 Nov 2017 14:11:50 +0200
Subject: [PATCH] Fix wildcard for Eagle XML files.

---
 common/wildcards_and_files_ext.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/common/wildcards_and_files_ext.cpp b/common/wildcards_and_files_ext.cpp
index 81d8e94dc..9c3990872 100644
--- a/common/wildcards_and_files_ext.cpp
+++ b/common/wildcards_and_files_ext.cpp
@@ -139,7 +139,8 @@ wxString EagleSchematicFileWildcard()
 
 wxString EagleFilesWildcard()
 {
-return _( "Eagle XML files (*.sch *.brd)|*.sch;*." ) + FormatWildcardExt( "brd" );
+return _( "Eagle XML files (*.sch *.brd)|*." ) +
+   FormatWildcardExt( "sch" ) + ";*." + FormatWildcardExt( "brd" );
 }
 
 
-- 
2.15.0

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH] Remove inappropriate tooltip

[Константин Барановский]

Remove inappropriate tooltip "Unload the selected library" from Remove
button of Equ files dialog in CvPcb.
From 05410b907dfdbc37c4558ce2c8d0d4039a7fd41d Mon Sep 17 00:00:00 2001
From: Baranovskiy Konstantin 
Date: Sun, 12 Nov 2017 14:17:20 +0200
Subject: [PATCH] Remove inappropriate tooltip from Remove button of Equ files
 dialog of CvPcb.

---
 cvpcb/dialogs/dialog_config_equfiles_base.cpp | 2 --
 cvpcb/dialogs/dialog_config_equfiles_base.fbp | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/cvpcb/dialogs/dialog_config_equfiles_base.cpp b/cvpcb/dialogs/dialog_config_equfiles_base.cpp
index 84a6f7100..e8c1ae0e6 100644
--- a/cvpcb/dialogs/dialog_config_equfiles_base.cpp
+++ b/cvpcb/dialogs/dialog_config_equfiles_base.cpp
@@ -37,8 +37,6 @@ DIALOG_CONFIG_EQUFILES_BASE::DIALOG_CONFIG_EQUFILES_BASE( wxWindow* parent, wxWi
 	bSizerButtons->Add( m_buttonAddEqu, 0, wxALIGN_CENTER_HORIZONTAL|wxEXPAND|wxBOTTOM|wxRIGHT|wxLEFT, 5 );
 	
 	m_buttonRemoveEqu = new wxButton( sbEquivChoiceSizer->GetStaticBox(), ID_REMOVE_EQU, _("Remove"), wxDefaultPosition, wxDefaultSize, 0 );
-	m_buttonRemoveEqu->SetToolTip( _("Unload the selected library") );
-	
 	bSizerButtons->Add( m_buttonRemoveEqu, 0, wxALIGN_CENTER_HORIZONTAL|wxEXPAND|wxBOTTOM|wxRIGHT|wxLEFT, 5 );
 	
 	m_buttonMoveUp = new wxButton( sbEquivChoiceSizer->GetStaticBox(), ID_EQU_UP, _("Move Up"), wxDefaultPosition, wxDefaultSize, 0 );
diff --git a/cvpcb/dialogs/dialog_config_equfiles_base.fbp b/cvpcb/dialogs/dialog_config_equfiles_base.fbp
index bf12b5a87..aa7137f88 100644
--- a/cvpcb/dialogs/dialog_config_equfiles_base.fbp
+++ b/cvpcb/dialogs/dialog_config_equfiles_base.fbp
@@ -356,7 +356,7 @@
 
 
 0
-Unload the selected library
+
 
 wxFILTER_NONE
 wxDefaultValidator
-- 
2.15.0

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] small typo

[Wayne Stambaugh]

Marco,

Thanks for the heads up.  I just pushed the fix.

Cheers,

Wayne

On 11/12/2017 05:30 AM, Marco Ciampa wrote:
> eeschema/lib_export.cpp:160
> 
> "Write permissions are requured to save library '%s'."
> 
> TIA
> 
> --
> 
> 
> Marco Ciampa
> 
> I know a joke about UDP, but you might not get it.
> 
> 
> 
>  GNU/Linux User #78271
>  FSFE fellow #364
> 
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Fix wildcard for Eagle XML files.

[Wayne Stambaugh]

Константин,

I merged your patch into the development branch.  Thank you for your
contribution to KiCad.

Cheers,

Wayne

On 11/12/2017 07:20 AM, Константин Барановский wrote:
> --- a/common/wildcards_and_files_ext.cpp
> +++ b/common/wildcards_and_files_ext.cpp
> @@ -139,7 +139,8 @@ wxString EagleSchematicFileWildcard()
>  
>  wxString EagleFilesWildcard()
>  {
> -    return _( "Eagle XML files (*.sch *.brd)|*.sch;*." ) +
> FormatWildcardExt( "brd" );
> +    return _( "Eagle XML files (*.sch *.brd)|*." ) +
> +           FormatWildcardExt( "sch" ) + ";*." + FormatWildcardExt( "brd" );
>  }
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Asciidoc question.

[Mark Roszko]

FYI, here's how you add icons

https://github.com/KiCad/kicad-website/commit/893c902228c5d0a0d6fdbcdf783878cbbd439f6e

Never did figure out how to make hugo set global asciidoc parameters

On Fri, Nov 10, 2017 at 2:28 PM, Wayne Stambaugh 
wrote:

> I was hoping the icon would draw user's attention to the warning to the
> obvious backup your files statement but maybe I was being a bit
> optimistic.  I'm fine with it the way it is.  I just wanted to be sure I
> didn't do anything wrong.
>
> On 11/10/2017 08:48 AM, Nick Østergaard wrote:
> > The source and generated code looks correct. It just seems like we don't
> > have any definition for the admonitionblock div classes for the icons in
> > the CSS. I guess this is a matter of taste, on whether one likes icons
> > or text. I guess icons was not implemented because we didn't use many of
> > these admonition blocks at the time of devising the new site template.
> >
> > 2017-11-10 14:20 GMT+01:00 Wayne Stambaugh  > >:
> >
> > Maybe one of our resident asciidoc experts can help me out.  I used a
> > WARNING admonition in the kicad website symbol library table blog
> > post[1].  I was expecting to see the warning icon per the asciidoc
> > documentation[2] but I only see a "WARNING" string where I expected
> the
> > icon.  Am I doing something wrong here[3] or do we not have our
> asciidoc
> > generator configured to use the icons for admonitions?  Thanks in
> > advance for the help.
> >
> > Cheers,
> >
> > Wayne
> >
> > [1]: http://kicad-pcb.org/post/symbol-lib-table/
> > 
> > [2]: http://asciidoc.org/userguide.html#X22
> > 
> > [3]:
> > https://raw.githubusercontent.com/KiCad/kicad-website/
> master/content/post/symbol-lib-table.adoc
> >  kicad-website/master/content/post/symbol-lib-table.adoc>
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > 
> > Post to : kicad-developers@lists.launchpad.net
> > 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > 
> > More help   : https://help.launchpad.net/ListHelp
> > 
> >
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>



-- 
Mark
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Asciidoc question.

[Wayne Stambaugh]

Thanks Mark!  I'll file this away for future reference.

On 11/12/2017 10:07 AM, Mark Roszko wrote:
> FYI, here's how you add icons
> 
> https://github.com/KiCad/kicad-website/commit/893c902228c5d0a0d6fdbcdf783878cbbd439f6e
> 
> Never did figure out how to make hugo set global asciidoc parameters
> 
> On Fri, Nov 10, 2017 at 2:28 PM, Wayne Stambaugh  > wrote:
> 
> I was hoping the icon would draw user's attention to the warning to the
> obvious backup your files statement but maybe I was being a bit
> optimistic.  I'm fine with it the way it is.  I just wanted to be sure I
> didn't do anything wrong.
> 
> On 11/10/2017 08:48 AM, Nick Østergaard wrote:
> > The source and generated code looks correct. It just seems like we don't
> > have any definition for the admonitionblock div classes for the icons in
> > the CSS. I guess this is a matter of taste, on whether one likes icons
> > or text. I guess icons was not implemented because we didn't use many of
> > these admonition blocks at the time of devising the new site template.
> >
> > 2017-11-10 14:20 GMT+01:00 Wayne Stambaugh  
> > >>:
> >
> >     Maybe one of our resident asciidoc experts can help me out.  I used 
> a
> >     WARNING admonition in the kicad website symbol library table blog
> >     post[1].  I was expecting to see the warning icon per the asciidoc
> >     documentation[2] but I only see a "WARNING" string where I expected 
> the
> >     icon.  Am I doing something wrong here[3] or do we not have our 
> asciidoc
> >     generator configured to use the icons for admonitions?  Thanks in
> >     advance for the help.
> >
> >     Cheers,
> >
> >     Wayne
> >
> >     [1]: http://kicad-pcb.org/post/symbol-lib-table/
> 
> >      >
> >     [2]: http://asciidoc.org/userguide.html#X22
> 
> >      >
> >     [3]:
> >     
> https://raw.githubusercontent.com/KiCad/kicad-website/master/content/post/symbol-lib-table.adoc
> 
> 
> >     
>  
> >
> >
> >     ___
> >     Mailing list: https://launchpad.net/~kicad-developers
> 
> >      >
> >     Post to     : kicad-developers@lists.launchpad.net
> 
> >      >
> >     Unsubscribe : https://launchpad.net/~kicad-developers
> 
> >      >
> >     More help   : https://help.launchpad.net/ListHelp
> 
> >      >
> >
> >
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> 
> 
> -- 
> Mark

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] KiCad Libraries (again)

[Diego Herranz]

Hi,

I've just submitted a pull request (
https://github.com/KiCad/kicad-website/pull/236) trying to make a bit more
clear when/why you need to update the libraries. Also adding links to
github lib repos. Comments welcome :)

Thanks,
Diego

On Sun, Nov 5, 2017 at 10:33 PM, Diego Herranz <
diegoherr...@diegoherranz.com> wrote:

> Thanks, Rene
>
> On 4 Nov 2017 4:06 pm, "Rene Pöschl"  wrote:
>
> On 03/11/17 21:34, Diego Herranz wrote:
>
>> First of all, I think all the recent work around the libraries is great!
>> Thanks to everyone involved. I think sometimes libraries are underestimated
>> (not just in KiCad). If KiCad manages to have extensive, high-quality and
>> clearly arranged libraries, many more users will end up using it.
>>
>> Having said that, I've used Kicad for some time and even contributed some
>> code but still can't fully understand how all the library stuff works. It
>> is the most common complaint I read about KiCad by newbies and somehow I
>> feel myself in a similar situation.
>>
>> So, I've reviewed http://kicad-pcb.org/libraries/download/ <
>> http://kicad-pcb.org/libraries/download/> with my lack of library
>> understanding and will try to provide some feedback from that view:
>>
>>
>> - It seems to imply that the user needs to download the libraries from
>> there. However they come with the installer, don't they?
>>
> A user might want do download an older or newer version of the lib than is
> offered with their software version. (Maybe because they want to open a
> project designed with this version of the lib.)
>
> And there is talk about giving users the option to get a small installer
> without libs. (Some users have data constrains. The installer is now nearly
> 1GB including all the 3d model libs.)
> It might also be a good idea to decouple the library release cycle from
> the software release cycle.
>
> I understand. We may want to explain that not to make users think they
> *need* to download them. I may submit a patch.
>
>
>
>
> - It says "Users who wish to keep their libraries up to date with the
>> latest additions should clone the library repositories using Git.". But,
>> does that apply to footprint libraries? I think my installs have always
>> gone to github for those. Is that true? Do they grab the latest or a
>> specific tag?
>>
> The github plugin in general is a bad idea. It grabs the current master
> head and downloads everything in every session. (At least everytime it
> needs information about footprints for the first time in this session.) It
> does not even use git but pulls a zip archive.
>
> Another problem of having the github plugin is that the libs of the user
> get out of sync. So the symbol libs and 3d model libs stay at the version
> they where at the release of the installed software version. But the
> footprint libs get every change we make in the repos. (This means that if
> we rename a footprint, the footprint filters defined in the symbol might no
> longer work. Or if we change the scaling of the 3d model this will produce
> wrongly scaled results in the 3d viewer until the user manually downloads
> newer 3d models.)
>
> Because we decided to kill the one repo per footprint lib nonsense for the
> v5 release the current github plugin will no longer work there. (So you
> could say the download page is already prepared for the v5 release.)
> Unless of course someone fixes the github plugin such that it supports one
> large repo that holds all footprint libs. (But i would not suggest to use
> it as the default option, because it has the major drawbacks mentioned
> above.)
>
> Thanks, I understand it a bit better now.
>
>
>
>
>
> - I would explain the differences between schematic (old style,
>> per project) and layout libraries (new table style, per project or global).
>> Also in "Future of the Libraries" explain the new symbol table, etc.
>>
> If i read the conversations on the mailing list correctly then kicad 5
> will include a symbol table for managing symbols.
> We could of course add a pointer to the documentation of this stuff. But i
> don't really know where it would fit.
>
>
> - I would maybe mention kicad-packages3d-source (maybe in brackets)
>>
> good idea
>
> Again, I may submit a patch.
>
>
>
> - I would add links to the repos in "Future of the Libraries"
>>
> I think oliver is already designing a better version of the download page.
> Have a look at the other library related conversation here on the mailing
> list.
> https://lists.launchpad.net/kicad-developers/msg31312.html
>
> I think that's different from the landing download page, but not sure how
> both would interact.
>
>
>
> - If anything of what I said doesn't make sense or it's wrong, please let
>> me know. I'd love to understand it better.
>>
> done
>
> mfg Rene Pöschl
>
>
> Many thanks for your help, Rene.
> Diego
>
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubs

Re: [Kicad-developers] Testing New eagle import, problems

[Wayne Stambaugh]

On 11/12/2017 07:13 AM, Russell Oliver wrote:
> Hi Lachlan, 
> 
> I was the main developer of the Eagle schematic import plugin and I know
> the layout of the Pcbnew Eagle import code pretty well. So If you can
> describe further the errors you are seeing that would be great, even if
> its just links to the original Eagle files and screen shots of the
> offending areas. 
> 
> Wayne: I'm thinking we to start with to change the text of the Import
> Project menu option from "Eagle Cad" to something like "Eagle CAD 6.x+
> XML".  

Hi Russel,

This would probably be a good start.  Please note that I moved the Eagle
file wildcard to the common/wildcards_and_files_ext.cpp file as part of
my GTK+ file dialog case sensitivity fix so it is no longer in the
kicad/import_project.cpp file.  There also was a bug report about some
of the Eagle importer error messages being confusing so I would
appreciate if you take a look at them as well.  Just send the patches to
the dev mailing list and I will get them merged as soon as possible.  By
the way, nice job on the Eagle importer.  It really seems to work well.

Cheers,

Wayne

> 
> Kind Regards
> Russell 
> 
> On Sat, Nov 11, 2017 at 11:58 AM Wayne Stambaugh  > wrote:
> 
> Lachlan,
> 
> It looks like your attachment got blocked.  Is there another way to get
> it to us?
> 
> Cheers,
> 
> Wayne
> 
> On 11/10/2017 7:26 PM, Lachlan Audas wrote:
> > A few quick test show the Eagle import has some problems, on the
> Developers
> > version.
> >
> > I would  suggest you do a binary file check,  on sch/pcb files, 
>  and warn
> > the user,   that Kicad only supports XML, 6.0+ instead of giving
> confusing
> > passer error messages when it finds a binary file. Example:
> >
> https://github.com/OLIMEX/OLINUXINO/tree/master/HARDWARE/RT5350F/RT5350F-
> > OLinuXino/RT5350F_OLinuXino_Rev_E
> >
> > Others  from OLIMEX  also show up the a number of problems with text
> > showing when they should not, and not displaying text when they
> should.
> > Example:  Attached.   Sorry for the file size,  But I'm not sure
> if the
> > mailing list server will block compressed files.
> >
> > Lachlan
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@lists.launchpad.net
> 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [RFC] redesign of Library Table dialog

[Tomasz Wlostowski]

On 12/11/17 01:44, Oliver Walters wrote:

Hi Olivier,

Many thanks for your comments, my answers below:

> Regarding the "advanced options" button, why not have an extra button
> (next to Add / Remove / etc) which says "Edit". Clicking on this brings
> up a dialog for the selected library with all extra options...

I would keep the current library table dialog as it is under the
advanced button, so that the users who already got used to it remain
happy. It's also less coding work for us.

> 
> Should the footprints / symbols / etc / all appear in the same list? I
> like the idea of a single library preferences dialog, but what if the
> various library types were separated by a panel on the left hand side,
> as is common in many preferences windows?  I'm thinking of Eclipse as an
> example.
My idea was to have a structured table using wxDataView (as in [1]), but
I'm not opposed to have a tree control to select between SCH/PCB/other
(e.g. SPICE) libraries.


> 
> Here is an example of something I have in a development branch (that has
> been wanting my attention for some time). The core code to make this
> dialog style is pretty solid, so I could share that part with you i> think 
> this is a good idea.

I like it. What options would you put in the "library options" section?

Cheers,
Tom


[1]
https://www.google.fr/url?sa=i&rct=j&q=&esrc=s&source=images&cd=&cad=rja&uact=8&ved=0ahUKEwj1jp7n-LnXAhUHOxoKHdxgCMAQjRwIBw&url=https%3A%2F%2Fwxpython.org%2FPhoenix%2Fdocs%2Fhtml%2Fwx.dataview.DataViewCtrl.html&psig=AOvVaw2ALsZb-bFXnvvx9LumvJkd&ust=1510607285812822

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [RFC] redesign of Library Table dialog

[Wayne Stambaugh]

Tom,

Are planning on this being part of the stable 5 release?  If so, you
have until Orson finishes up his symbol library editor work.  Once that
is merged, I'm announcing the feature freeze.

On 11/12/2017 04:10 PM, Tomasz Wlostowski wrote:
> On 12/11/17 01:44, Oliver Walters wrote:
> 
> Hi Olivier,
> 
> Many thanks for your comments, my answers below:
> 
>> Regarding the "advanced options" button, why not have an extra button
>> (next to Add / Remove / etc) which says "Edit". Clicking on this brings
>> up a dialog for the selected library with all extra options...
> 
> I would keep the current library table dialog as it is under the
> advanced button, so that the users who already got used to it remain
> happy. It's also less coding work for us.

One thing that would make current dialogs more useful was if the copy
and paste feature was integrated.  It looks like it was started but
never finished.  That would make life a lot easier for users right now.

> 
>>
>> Should the footprints / symbols / etc / all appear in the same list? I
>> like the idea of a single library preferences dialog, but what if the
>> various library types were separated by a panel on the left hand side,
>> as is common in many preferences windows?  I'm thinking of Eclipse as an
>> example.
> My idea was to have a structured table using wxDataView (as in [1]), but
> I'm not opposed to have a tree control to select between SCH/PCB/other
> (e.g. SPICE) libraries.
> 
> 
>>
>> Here is an example of something I have in a development branch (that has
>> been wanting my attention for some time). The core code to make this
>> dialog style is pretty solid, so I could share that part with you i> think 
>> this is a good idea.
> 
> I like it. What options would you put in the "library options" section?
> 
> Cheers,
> Tom
> 
> 
> [1]
> https://www.google.fr/url?sa=i&rct=j&q=&esrc=s&source=images&cd=&cad=rja&uact=8&ved=0ahUKEwj1jp7n-LnXAhUHOxoKHdxgCMAQjRwIBw&url=https%3A%2F%2Fwxpython.org%2FPhoenix%2Fdocs%2Fhtml%2Fwx.dataview.DataViewCtrl.html&psig=AOvVaw2ALsZb-bFXnvvx9LumvJkd&ust=1510607285812822
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH] LIB_PART coherency

[Maciej Suminski]

Hi,

I think this is a question to Wayne, but if others have any idea what
may go wrong, do not hesitate to reply.

I have noticed that part name and library values are duplicated in a few
places in LIB_PART class and it is possible to set them individually. It
means there is a way to set each of them to a different value,
potentially causing more problems.

With the attached patches, there is only one method to set all fields to
the same value. It is called in all places where the fields were
modified directly.

My main concern is related to LIB_ID: are there any cases where the
LIB_ID name/library fields should be different than what is stored in
the LIB_PART fields?

Regards,
Orson
>From 9f0cea0c3dc73c73e034aacf16db2efca33975f3 Mon Sep 17 00:00:00 2001
From: Maciej Suminski 
Date: Sun, 12 Nov 2017 21:49:38 +0100
Subject: [PATCH 1/4] Unified way of setting LIB_PART name

LIB_PART name is stored in three places that might be changed
independently:
- the first LIB_ALIAS in m_aliases
- LIB_FIELD with VALUE ID
- m_name wxString field

This is potentially leads to an incoherent LIB_PART state. To prevent
this, all fields are changed using only one method: LIB_PART::SetName().

LIB_PART::m_name has been removed as the same information is available
in two other variables.
---
 eeschema/class_libentry.cpp| 34 ++
 eeschema/class_libentry.h  |  3 +--
 eeschema/sch_legacy_plugin.cpp | 15 +--
 3 files changed, 16 insertions(+), 36 deletions(-)

diff --git a/eeschema/class_libentry.cpp b/eeschema/class_libentry.cpp
index 44f95588b..7cba8ac47 100644
--- a/eeschema/class_libentry.cpp
+++ b/eeschema/class_libentry.cpp
@@ -180,7 +180,6 @@ LIB_PART::LIB_PART( const wxString& aName, PART_LIB* aLibrary ) :
 EDA_ITEM( LIB_PART_T ),
 m_me( this, null_deleter() )
 {
-m_name= aName;
 m_library = aLibrary;
 m_dateModified= 0;
 m_unitCount   = 1;
@@ -190,21 +189,16 @@ LIB_PART::LIB_PART( const wxString& aName, PART_LIB* aLibrary ) :
 m_showPinNumbers  = true;
 m_showPinNames= true;
 
-m_libId.SetLibItemName( aName, false );
-
-// Create the default alias if the name parameter is not empty.
-if( !aName.IsEmpty() )
-m_aliases.push_back( new LIB_ALIAS( aName, this ) );
+wxASSERT( !aName.IsEmpty() );
 
 // Add the MANDATORY_FIELDS in RAM only.  These are assumed to be present
 // when the field editors are invoked.
-LIB_FIELD* value = new LIB_FIELD( this, VALUE );
-value->SetText( aName );
-m_drawings[LIB_FIELD_T].push_back( value );
-
+m_drawings[LIB_FIELD_T].push_back( new LIB_FIELD( this, VALUE ) );
 m_drawings[LIB_FIELD_T].push_back( new LIB_FIELD( this, REFERENCE ) );
 m_drawings[LIB_FIELD_T].push_back( new LIB_FIELD( this, FOOTPRINT ) );
 m_drawings[LIB_FIELD_T].push_back( new LIB_FIELD( this, DATASHEET ) );
+
+SetName( aName );
 }
 
 
@@ -215,7 +209,6 @@ LIB_PART::LIB_PART( LIB_PART& aPart, PART_LIB* aLibrary ) :
 LIB_ITEM* newItem;
 
 m_library = aLibrary;
-m_name= aPart.m_name;
 m_FootprintList   = aPart.m_FootprintList;
 m_unitCount   = aPart.m_unitCount;
 m_unitsLocked = aPart.m_unitsLocked;
@@ -305,7 +298,6 @@ wxString LIB_PART::SubReference( int aUnit, bool aAddSeparator )
 
 void LIB_PART::SetName( const wxString& aName )
 {
-m_name = aName;
 GetValueField().SetText( aName );
 
 // The LIB_ALIAS that is the LIB_PART name has to be created so create it.
@@ -897,23 +889,16 @@ bool LIB_PART::Load( LINE_READER& aLineReader, wxString& aErrorMsg )
 m_showPinNames = ( drawname == 'N' ) ? false : true;
 
 // Copy part name and prefix.
-LIB_FIELD& value = GetValueField();
-
 if( componentName[0] != '~' )
 {
-m_name = FROM_UTF8( componentName );
-value.SetText( m_name );
+SetName( FROM_UTF8( componentName ) );
 }
 else
 {
-m_name = FROM_UTF8( &componentName[1] );
-value.SetText( m_name );
-value.SetVisible( false );
+SetName( FROM_UTF8( &componentName[1] ) );
+GetValueField().SetVisible( false );
 }
 
-// Add the root alias to the alias list.
-m_aliases.push_back( new LIB_ALIAS( m_name, this ) );
-
 LIB_FIELD& reference = GetReferenceField();
 
 if( strcmp( prefix, "~" ) == 0 )
@@ -,7 +1096,7 @@ bool LIB_PART::LoadField( LINE_READER& aLineReader, wxString& aErrorMsg )
 *fixedField = *field;
 
 if( field->GetId() == VALUE )
-m_name = field->GetText();
+SetName( field->GetText() );
 
 delete field;
 }
@@ -1708,6 +1693,7 @@ void LIB_PART::SetAliases( const wxArrayString& aAliasList )
 {
 wxCHECK_RET( !m_library,
  wxT( "Part aliases cannot be changed when they are owned by a library." ) );
+wxCHECK_RET( !aAliasList.IsEmpty(), wxT( "Alias list cannot be empty

Re: [Kicad-developers] [PATCH] LIB_PART coherency

[Wayne Stambaugh]

Hey Orson,

Keep in mind that the symbol does not know which library it is in.  That
is determined when the library is parsed in SYMBOL_LIB_TABLE.  As long
as you don't break that, I cannot think of a reason not to unify the
symbol name but then again there are some quirks in the schematic code
that still jump up an bite me from time to time.

Cheers,

Wayne

On 11/12/2017 06:00 PM, Maciej Suminski wrote:
> Hi,
> 
> I think this is a question to Wayne, but if others have any idea what
> may go wrong, do not hesitate to reply.
> 
> I have noticed that part name and library values are duplicated in a few
> places in LIB_PART class and it is possible to set them individually. It
> means there is a way to set each of them to a different value,
> potentially causing more problems.
> 
> With the attached patches, there is only one method to set all fields to
> the same value. It is called in all places where the fields were
> modified directly.
> 
> My main concern is related to LIB_ID: are there any cases where the
> LIB_ID name/library fields should be different than what is stored in
> the LIB_PART fields?
> 
> Regards,
> Orson
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [RFC] redesign of Library Table dialog

[Oliver Walters]

>
>
> I like it. What options would you put in the "library options" section?


I'm not sure. I include it only with the thought that perhaps in the future
we will have global library options. It would probably not be present in
the initial version of the dialog.

On Mon, Nov 13, 2017 at 8:10 AM, Tomasz Wlostowski <
tomasz.wlostow...@cern.ch> wrote:

> On 12/11/17 01:44, Oliver Walters wrote:
>
> Hi Olivier,
>
> Many thanks for your comments, my answers below:
>
> > Regarding the "advanced options" button, why not have an extra button
> > (next to Add / Remove / etc) which says "Edit". Clicking on this brings
> > up a dialog for the selected library with all extra options...
>
> I would keep the current library table dialog as it is under the
> advanced button, so that the users who already got used to it remain
> happy. It's also less coding work for us.
>
> >
> > Should the footprints / symbols / etc / all appear in the same list? I
> > like the idea of a single library preferences dialog, but what if the
> > various library types were separated by a panel on the left hand side,
> > as is common in many preferences windows?  I'm thinking of Eclipse as an
> > example.
> My idea was to have a structured table using wxDataView (as in [1]), but
> I'm not opposed to have a tree control to select between SCH/PCB/other
> (e.g. SPICE) libraries.
>
>
> >
> > Here is an example of something I have in a development branch (that has
> > been wanting my attention for some time). The core code to make this
> > dialog style is pretty solid, so I could share that part with you i>
> think this is a good idea.
>
> I like it. What options would you put in the "library options" section?
>
> Cheers,
> Tom
>
>
> [1]
> https://www.google.fr/url?sa=i&rct=j&q=&esrc=s&source=
> images&cd=&cad=rja&uact=8&ved=0ahUKEwj1jp7n-LnXAhUHOxoKHdxgCMAQjRwIBw&url=
> https%3A%2F%2Fwxpython.org%2FPhoenix%2Fdocs%2Fhtml%2Fwx.
> dataview.DataViewCtrl.html&psig=AOvVaw2ALsZb-bFXnvvx9LumvJkd&ust=
> 1510607285812822
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] LIB_PART coherency

[Maciej Suminski]

Hi Wayne,

I see the fragment code you mentioned, it is untouched. I will keep the
patches as a part of the library manager branch, so they get some extra
testing.

Cheers,
Orson

On 11/13/2017 12:05 AM, Wayne Stambaugh wrote:
> Hey Orson,
> 
> Keep in mind that the symbol does not know which library it is in.  That
> is determined when the library is parsed in SYMBOL_LIB_TABLE.  As long
> as you don't break that, I cannot think of a reason not to unify the
> symbol name but then again there are some quirks in the schematic code
> that still jump up an bite me from time to time.
> 
> Cheers,
> 
> Wayne
> 
> On 11/12/2017 06:00 PM, Maciej Suminski wrote:
>> Hi,
>>
>> I think this is a question to Wayne, but if others have any idea what
>> may go wrong, do not hesitate to reply.
>>
>> I have noticed that part name and library values are duplicated in a few
>> places in LIB_PART class and it is possible to set them individually. It
>> means there is a way to set each of them to a different value,
>> potentially causing more problems.
>>
>> With the attached patches, there is only one method to set all fields to
>> the same value. It is called in all places where the fields were
>> modified directly.
>>
>> My main concern is related to LIB_ID: are there any cases where the
>> LIB_ID name/library fields should be different than what is stored in
>> the LIB_PART fields?
>>
>> Regards,
>> Orson
>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp