Re: [Kicad-developers] Strange strings for translation.

[Adam Wolf]

Wow!  My tree was in a very weird state due to trying to my script
trying to apply the STEP patch I sent to the list, and instead of
crashing, it didn't update to the latest master.  The script is fixed
on my end now, and shouldn't happen again.  Sorry for the false
positive!

Adam
On Mon, Jun 18, 2018 at 1:59 PM Wayne Stambaugh  wrote:
>
> On 6/18/2018 2:53 PM, jp charras wrote:
> > Le 18/06/2018 à 20:45, Adam Wolf a écrit :
> >> Is there something in particular you want tested on macOS?  It still
> >> builds, and the export STEP dialog seems OK.
> >>
> >> Adam
> >
> > It compiles?
> >
> > Strange:
> > this line
> > " e   appK2S.AppendDir( "MacOS" );"
> > (dialog_export_step.cpp, line 261)
> > has a typo, and should not compile.
>
> Grrr!  I did fat finger it.  It's fixed now.  Like JP, I'm surprised it
> compiled with this typo.
>
> >
> >
> >> On Mon, Jun 18, 2018 at 11:20 AM Wayne Stambaugh  
> >> wrote:
> >>>
> >>> I just pushed the fix for this.  Would one of our macos devs please test
> >>> this to make sure I didn't break anything?
> >>>
> >>> Thanks,
> >>>
> >>> Wayne
> >>>
> >>> On 6/18/2018 10:59 AM, Константин Барановский wrote:
>  After adding one of the last commits the next strings is appears for
>  translation:
> 
>  #: pcbnew/dialogs/dialog_export_step.cpp:254
>  msgid "/Contents/Applications/pcbnew.app/Contents/MacOS"
>  msgstr ""
> 
>  #: pcbnew/dialogs/dialog_export_step.cpp:256
>  #: pcbnew/dialogs/dialog_export_step.cpp:257
>  #: pcbnew/dialogs/dialog_export_step.cpp:258
>  #: pcbnew/dialogs/dialog_export_step.cpp:259
>  msgid ".."
>  msgstr ""
> 
>  #: pcbnew/dialogs/dialog_export_step.cpp:260
>  msgid "MacOS"
>  msgstr ""
> 
>  #: pcbnew/pcb_edit_frame.cpp:521
>  msgid "pcbnew.app"
>  msgstr ""
> 
>  Is it realy must be translated or it is result of some typos?
> 
> 
>  ___
>  Mailing list: https://launchpad.net/~kicad-developers
>  Post to : kicad-developers@lists.launchpad.net
>  Unsubscribe : https://launchpad.net/~kicad-developers
>  More help   : https://help.launchpad.net/ListHelp
> 
> >>>
> >>> ___
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to : kicad-developers@lists.launchpad.net
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
> >>
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to : kicad-developers@lists.launchpad.net
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> >>
> >
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Strange strings for translation.

[Wayne Stambaugh]

On 6/18/2018 2:53 PM, jp charras wrote:
> Le 18/06/2018 à 20:45, Adam Wolf a écrit :
>> Is there something in particular you want tested on macOS?  It still
>> builds, and the export STEP dialog seems OK.
>>
>> Adam
> 
> It compiles?
> 
> Strange:
> this line
> " e   appK2S.AppendDir( "MacOS" );"
> (dialog_export_step.cpp, line 261)
> has a typo, and should not compile.

Grrr!  I did fat finger it.  It's fixed now.  Like JP, I'm surprised it
compiled with this typo.

> 
> 
>> On Mon, Jun 18, 2018 at 11:20 AM Wayne Stambaugh  
>> wrote:
>>>
>>> I just pushed the fix for this.  Would one of our macos devs please test
>>> this to make sure I didn't break anything?
>>>
>>> Thanks,
>>>
>>> Wayne
>>>
>>> On 6/18/2018 10:59 AM, Константин Барановский wrote:
 After adding one of the last commits the next strings is appears for
 translation:

 #: pcbnew/dialogs/dialog_export_step.cpp:254
 msgid "/Contents/Applications/pcbnew.app/Contents/MacOS"
 msgstr ""

 #: pcbnew/dialogs/dialog_export_step.cpp:256
 #: pcbnew/dialogs/dialog_export_step.cpp:257
 #: pcbnew/dialogs/dialog_export_step.cpp:258
 #: pcbnew/dialogs/dialog_export_step.cpp:259
 msgid ".."
 msgstr ""

 #: pcbnew/dialogs/dialog_export_step.cpp:260
 msgid "MacOS"
 msgstr ""

 #: pcbnew/pcb_edit_frame.cpp:521
 msgid "pcbnew.app"
 msgstr ""

 Is it realy must be translated or it is result of some typos?


 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp

>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Strange strings for translation.

[jp charras]

Le 18/06/2018 à 20:45, Adam Wolf a écrit :
> Is there something in particular you want tested on macOS?  It still
> builds, and the export STEP dialog seems OK.
> 
> Adam

It compiles?

Strange:
this line
" e   appK2S.AppendDir( "MacOS" );"
(dialog_export_step.cpp, line 261)
has a typo, and should not compile.


> On Mon, Jun 18, 2018 at 11:20 AM Wayne Stambaugh  wrote:
>>
>> I just pushed the fix for this.  Would one of our macos devs please test
>> this to make sure I didn't break anything?
>>
>> Thanks,
>>
>> Wayne
>>
>> On 6/18/2018 10:59 AM, Константин Барановский wrote:
>>> After adding one of the last commits the next strings is appears for
>>> translation:
>>>
>>> #: pcbnew/dialogs/dialog_export_step.cpp:254
>>> msgid "/Contents/Applications/pcbnew.app/Contents/MacOS"
>>> msgstr ""
>>>
>>> #: pcbnew/dialogs/dialog_export_step.cpp:256
>>> #: pcbnew/dialogs/dialog_export_step.cpp:257
>>> #: pcbnew/dialogs/dialog_export_step.cpp:258
>>> #: pcbnew/dialogs/dialog_export_step.cpp:259
>>> msgid ".."
>>> msgstr ""
>>>
>>> #: pcbnew/dialogs/dialog_export_step.cpp:260
>>> msgid "MacOS"
>>> msgstr ""
>>>
>>> #: pcbnew/pcb_edit_frame.cpp:521
>>> msgid "pcbnew.app"
>>> msgstr ""
>>>
>>> Is it realy must be translated or it is result of some typos?
>>>
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Strange strings for translation.

[Wayne Stambaugh]

That should do it.  It was a fairly simple change but most of the
changes were between #ifdef/#endif statement so I just want to be sure I
didn't fat finger anything.

Cheers,

Wayne

On 6/18/2018 2:45 PM, Adam Wolf wrote:
> Is there something in particular you want tested on macOS?  It still
> builds, and the export STEP dialog seems OK.
> 
> Adam
> On Mon, Jun 18, 2018 at 11:20 AM Wayne Stambaugh  wrote:
>>
>> I just pushed the fix for this.  Would one of our macos devs please test
>> this to make sure I didn't break anything?
>>
>> Thanks,
>>
>> Wayne
>>
>> On 6/18/2018 10:59 AM, Константин Барановский wrote:
>>> After adding one of the last commits the next strings is appears for
>>> translation:
>>>
>>> #: pcbnew/dialogs/dialog_export_step.cpp:254
>>> msgid "/Contents/Applications/pcbnew.app/Contents/MacOS"
>>> msgstr ""
>>>
>>> #: pcbnew/dialogs/dialog_export_step.cpp:256
>>> #: pcbnew/dialogs/dialog_export_step.cpp:257
>>> #: pcbnew/dialogs/dialog_export_step.cpp:258
>>> #: pcbnew/dialogs/dialog_export_step.cpp:259
>>> msgid ".."
>>> msgstr ""
>>>
>>> #: pcbnew/dialogs/dialog_export_step.cpp:260
>>> msgid "MacOS"
>>> msgstr ""
>>>
>>> #: pcbnew/pcb_edit_frame.cpp:521
>>> msgid "pcbnew.app"
>>> msgstr ""
>>>
>>> Is it realy must be translated or it is result of some typos?
>>>
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Strange strings for translation.

[Adam Wolf]

Is there something in particular you want tested on macOS?  It still
builds, and the export STEP dialog seems OK.

Adam
On Mon, Jun 18, 2018 at 11:20 AM Wayne Stambaugh  wrote:
>
> I just pushed the fix for this.  Would one of our macos devs please test
> this to make sure I didn't break anything?
>
> Thanks,
>
> Wayne
>
> On 6/18/2018 10:59 AM, Константин Барановский wrote:
> > After adding one of the last commits the next strings is appears for
> > translation:
> >
> > #: pcbnew/dialogs/dialog_export_step.cpp:254
> > msgid "/Contents/Applications/pcbnew.app/Contents/MacOS"
> > msgstr ""
> >
> > #: pcbnew/dialogs/dialog_export_step.cpp:256
> > #: pcbnew/dialogs/dialog_export_step.cpp:257
> > #: pcbnew/dialogs/dialog_export_step.cpp:258
> > #: pcbnew/dialogs/dialog_export_step.cpp:259
> > msgid ".."
> > msgstr ""
> >
> > #: pcbnew/dialogs/dialog_export_step.cpp:260
> > msgid "MacOS"
> > msgstr ""
> >
> > #: pcbnew/pcb_edit_frame.cpp:521
> > msgid "pcbnew.app"
> > msgstr ""
> >
> > Is it realy must be translated or it is result of some typos?
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Strange strings for translation.

[Wayne Stambaugh]

I just pushed the fix for this.  Would one of our macos devs please test
this to make sure I didn't break anything?

Thanks,

Wayne

On 6/18/2018 10:59 AM, Константин Барановский wrote:
> After adding one of the last commits the next strings is appears for
> translation:
> 
> #: pcbnew/dialogs/dialog_export_step.cpp:254
> msgid "/Contents/Applications/pcbnew.app/Contents/MacOS"
> msgstr ""
> 
> #: pcbnew/dialogs/dialog_export_step.cpp:256
> #: pcbnew/dialogs/dialog_export_step.cpp:257
> #: pcbnew/dialogs/dialog_export_step.cpp:258
> #: pcbnew/dialogs/dialog_export_step.cpp:259
> msgid ".."
> msgstr ""
> 
> #: pcbnew/dialogs/dialog_export_step.cpp:260
> msgid "MacOS"
> msgstr ""
> 
> #: pcbnew/pcb_edit_frame.cpp:521
> msgid "pcbnew.app"
> msgstr ""
> 
> Is it realy must be translated or it is result of some typos?
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Strange strings for translation.

[Wayne Stambaugh]

Sorry about that.  When I reviewed the patch, I missed that these
strings should not be translated.  I'll fix it today.  Thanks for the
heads up.

On 6/18/2018 10:59 AM, Константин Барановский wrote:
> After adding one of the last commits the next strings is appears for
> translation:
> 
> #: pcbnew/dialogs/dialog_export_step.cpp:254
> msgid "/Contents/Applications/pcbnew.app/Contents/MacOS"
> msgstr ""
> 
> #: pcbnew/dialogs/dialog_export_step.cpp:256
> #: pcbnew/dialogs/dialog_export_step.cpp:257
> #: pcbnew/dialogs/dialog_export_step.cpp:258
> #: pcbnew/dialogs/dialog_export_step.cpp:259
> msgid ".."
> msgstr ""
> 
> #: pcbnew/dialogs/dialog_export_step.cpp:260
> msgid "MacOS"
> msgstr ""
> 
> #: pcbnew/pcb_edit_frame.cpp:521
> msgid "pcbnew.app"
> msgstr ""
> 
> Is it realy must be translated or it is result of some typos?
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Strange strings for translation.

[Константин Барановский]

After adding one of the last commits the next strings is appears for
translation:

#: pcbnew/dialogs/dialog_export_step.cpp:254
msgid "/Contents/Applications/pcbnew.app/Contents/MacOS"
msgstr ""

#: pcbnew/dialogs/dialog_export_step.cpp:256
#: pcbnew/dialogs/dialog_export_step.cpp:257
#: pcbnew/dialogs/dialog_export_step.cpp:258
#: pcbnew/dialogs/dialog_export_step.cpp:259
msgid ".."
msgstr ""

#: pcbnew/dialogs/dialog_export_step.cpp:260
msgid "MacOS"
msgstr ""

#: pcbnew/pcb_edit_frame.cpp:521
msgid "pcbnew.app"
msgstr ""

Is it realy must be translated or it is result of some typos?
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Upgrading from V4 to V5 resources?

[Wayne Stambaugh]

As soon as I have the rough draft completed, I will post a link to it
for review before I commit it.

On 6/18/2018 9:09 AM, Rene Pöschl wrote:
> Another pitfall seems to be that users do not expect that they need to
> update their fp-lib-table after installing kicad 5.
> 
> Either they need to update the fp-lib-table to get the footprint library
> to the state of v5 or they would need to manually install the version 4
> symbol and 3d model libs to stay at the version 4 library.
> 
> 
> On 17/06/18 19:05, Wayne Stambaugh wrote:
>> Adam,
>>
>> AFAIK, there is not an upgrading reference but we should probably create
>> one.  Since the biggest change that has the potential to confuse users
>> is the symbol remapping, I will write a short document and add it to the
>> end of the KiCad users manual.
>>
>> Cheers,
>>
>> Wayne
>>
>>
>> On 06/17/2018 12:03 PM, Adam Wolf wrote:
>>> Hi folks!
>>>
>>> Do we have a good reference for users upgrading from V4 to V5, telling
>>> them any important precautions they'll need to take, and maybe even
>>> what they can expect to be different?  I would love to help to write
>>> this for V6 but for V5 I am too swamped with macOS (but still
>>> optimistic we can hit Wayne's current schedule).
>>>
>>> If so, I would like to refer to this in the macOS README.
>>>
>>> Adam
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Upgrading from V4 to V5 resources?

[Rene Pöschl]

Another pitfall seems to be that users do not expect that they need to 
update their fp-lib-table after installing kicad 5.


Either they need to update the fp-lib-table to get the footprint library 
to the state of v5 or they would need to manually install the version 4 
symbol and 3d model libs to stay at the version 4 library.



On 17/06/18 19:05, Wayne Stambaugh wrote:

Adam,

AFAIK, there is not an upgrading reference but we should probably create
one.  Since the biggest change that has the potential to confuse users
is the symbol remapping, I will write a short document and add it to the
end of the KiCad users manual.

Cheers,

Wayne


On 06/17/2018 12:03 PM, Adam Wolf wrote:

Hi folks!

Do we have a good reference for users upgrading from V4 to V5, telling
them any important precautions they'll need to take, and maybe even
what they can expect to be different?  I would love to help to write
this for V6 but for V5 I am too swamped with macOS (but still
optimistic we can hit Wayne's current schedule).

If so, I would like to refer to this in the macOS README.

Adam

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp




___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Add logo to documentation

[Nick Østergaard]

Mmm, I think I would prefer the Ki logo

man. 18. jun. 2018 10.11 skrev John Beard :

> In that case, here is the patch with the 48px app logo in the top left.
> Doxygen recommends 55px max height, so 48px seems a handy size.
>
> Screenshot for reference.
>
> Cheers,
>
> John
>
> On Sun, Jun 17, 2018 at 5:58 PM, Wayne Stambaugh 
> wrote:
>
>> I'm OK with the short logo image.  This would probably look better than
>> the redundant KiCad.
>>
>> On 06/17/2018 08:53 AM, John Beard wrote:
>> > Sadly I don't think there is a way to set the logo alt text in doxygen
>> > (so it would still read "KiCad" when the image is not displayed, for
>> > screen readers, when copy-pasted and it when search engines index it).
>> >
>> > Alternatively, use the square icon rather than the text logo and keep
>> > the title as it is?
>> >
>> > Cheers,
>> >
>> > John
>> >
>> > On Wed, Jun 13, 2018 at 11:18 PM, Wayne Stambaugh > > > wrote:
>> >
>> > I agree.  The double KiCad does look a bit odd but I do like the
>> > KiCad logo embedded in the docs.
>> >
>> > On 06/13/2018 06:00 PM, Nick Østergaard wrote:
>> >
>> > Maybe we need to remove the word KiCad from the title, as  it
>> > essentially reads  "[KiCad] KiCad Pcbnew Python Scripting"
>> >
>> >
>> > 2018-06-13 21:12 GMT+02:00 John Beard > >  > > >>:
>> >
>> > Sorry, I had a line commented in a local commit to avoid a
>> > costly
>> > re-build of the docstrings when I didn't need them to be
>> > (the doc
>> > dependencies aren't managed by CMake, it just always runs
>> the
>> > targets, which is fine for CI).
>> >
>> > The attached should be better (difference is a lack of a "#
>> > " before
>> > DEPENDS xml-to-docstrings)
>> >
>> > Cheers,
>> >
>> > John
>> >
>> > On Wed, Jun 13, 2018 at 8:04 PM, Wayne Stambaugh
>> > mailto:stambau...@gmail.com>
>> > >>
>> wrote:
>> >
>> > John,
>> >
>> > I am getting the following error when I try to apply
>> > your patch:
>> >
>> > $ git am --ignore-whitespace <
>> >
>> >
>>  
>> /c/Users/wstambaugh/Documents/Archive/temp/kicad/patches/0001-Documentation-add-logo-to-Doxygen-pages.patch
>> > Applying: Documentation: add logo to Doxygen pages
>> > error: patch failed: pcbnew/CMakeLists.txt:533
>> > error: pcbnew/CMakeLists.txt: patch does not apply
>> > Patch failed at 0001 Documentation: add logo to Doxygen
>> > pages
>> > Use 'git am --show-current-patch' to see the failed
>> patch
>> > When you have resolved this problem, run "git am
>> > --continue".
>> > If you prefer to skip this patch, run "git am --skip"
>> > instead.
>> > To restore the original branch and stop patching, run
>> > "git am
>> > --abort".
>> >
>> > It appears to be choking on the pcbnew/CMakeFile.txt.
>> Is it
>> > possible
>> > that you have other changes to this file that are not
>> in the
>> > master branch?
>> >
>> > Cheers,
>> >
>> > Wayne
>> >
>> > On 6/13/2018 1:50 PM, John Beard wrote:
>> >  > Hi,
>> >  >
>> >  > This patch adds a small KiCad logo to the three
>> doxygen
>> > documentation
>> >  > targets (C++, dev docs and Python docs) for a little
>> > bit more
>> > flair.
>> >  >
>> >  > The image itself is put in the /Documentation dir,
>> > but it's
>> > not really
>> >  > important to the process where it goes.
>> >  >
>> >  > Cheers,
>> >  >
>> >  > John
>> >  >
>> >  >
>> >  > ___
>> >  > Mailing list:
>> https://launchpad.net/~kicad-developers
>> > 
>> > > > >
>> >  > Post to : kicad-developers@lists.launchpad.net
>> > 
>> > > > >
>> >  > Unsubscribe :
>> https://launchpad.net/~kicad-developers
>> > 

Re: [Kicad-developers] [PATCH] Add logo to documentation

[Marco Ciampa]

On Mon, Jun 18, 2018 at 09:10:49AM +0100, John Beard wrote:
> In that case, here is the patch with the 48px app logo in the top left.
> Doxygen recommends 55px max height, so 48px seems a handy size.
> 
> Screenshot for reference.
> 
> Cheers,
> 
> John
> 

Nice,
would you mind adding a small transparent border around it?
I think it would look better...

TIA

-- 


Marco Ciampa

I know a joke about UDP, but you might not get it.



 GNU/Linux User #78271
 FSFE fellow #364




___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Add logo to documentation

[John Beard]

In that case, here is the patch with the 48px app logo in the top left.
Doxygen recommends 55px max height, so 48px seems a handy size.

Screenshot for reference.

Cheers,

John

On Sun, Jun 17, 2018 at 5:58 PM, Wayne Stambaugh 
wrote:

> I'm OK with the short logo image.  This would probably look better than
> the redundant KiCad.
>
> On 06/17/2018 08:53 AM, John Beard wrote:
> > Sadly I don't think there is a way to set the logo alt text in doxygen
> > (so it would still read "KiCad" when the image is not displayed, for
> > screen readers, when copy-pasted and it when search engines index it).
> >
> > Alternatively, use the square icon rather than the text logo and keep
> > the title as it is?
> >
> > Cheers,
> >
> > John
> >
> > On Wed, Jun 13, 2018 at 11:18 PM, Wayne Stambaugh  > > wrote:
> >
> > I agree.  The double KiCad does look a bit odd but I do like the
> > KiCad logo embedded in the docs.
> >
> > On 06/13/2018 06:00 PM, Nick Østergaard wrote:
> >
> > Maybe we need to remove the word KiCad from the title, as  it
> > essentially reads  "[KiCad] KiCad Pcbnew Python Scripting"
> >
> >
> > 2018-06-13 21:12 GMT+02:00 John Beard  >   > >>:
> >
> > Sorry, I had a line commented in a local commit to avoid a
> > costly
> > re-build of the docstrings when I didn't need them to be
> > (the doc
> > dependencies aren't managed by CMake, it just always runs the
> > targets, which is fine for CI).
> >
> > The attached should be better (difference is a lack of a "#
> > " before
> > DEPENDS xml-to-docstrings)
> >
> > Cheers,
> >
> > John
> >
> > On Wed, Jun 13, 2018 at 8:04 PM, Wayne Stambaugh
> > mailto:stambau...@gmail.com>
> > >>
> wrote:
> >
> > John,
> >
> > I am getting the following error when I try to apply
> > your patch:
> >
> > $ git am --ignore-whitespace <
> >
> > /c/Users/wstambaugh/Documents/Archive/temp/kicad/patches/
> 0001-Documentation-add-logo-to-Doxygen-pages.patch
> > Applying: Documentation: add logo to Doxygen pages
> > error: patch failed: pcbnew/CMakeLists.txt:533
> > error: pcbnew/CMakeLists.txt: patch does not apply
> > Patch failed at 0001 Documentation: add logo to Doxygen
> > pages
> > Use 'git am --show-current-patch' to see the failed patch
> > When you have resolved this problem, run "git am
> > --continue".
> > If you prefer to skip this patch, run "git am --skip"
> > instead.
> > To restore the original branch and stop patching, run
> > "git am
> > --abort".
> >
> > It appears to be choking on the pcbnew/CMakeFile.txt.
> Is it
> > possible
> > that you have other changes to this file that are not in
> the
> > master branch?
> >
> > Cheers,
> >
> > Wayne
> >
> > On 6/13/2018 1:50 PM, John Beard wrote:
> >  > Hi,
> >  >
> >  > This patch adds a small KiCad logo to the three
> doxygen
> > documentation
> >  > targets (C++, dev docs and Python docs) for a little
> > bit more
> > flair.
> >  >
> >  > The image itself is put in the /Documentation dir,
> > but it's
> > not really
> >  > important to the process where it goes.
> >  >
> >  > Cheers,
> >  >
> >  > John
> >  >
> >  >
> >  > ___
> >  > Mailing list: https://launchpad.net/~kicad-developers
> > 
> >  > >
> >  > Post to : kicad-developers@lists.launchpad.net
> > 
> >  > >
> >  > Unsubscribe : https://launchpad.net/~kicad-developers
> > 
> >  > >
> >  > More help   : https://help.launchpad.net/ListHelp
> >