[Kicad-developers] List of bugs
Hi all, I was getting some work done on kicad and noticed quite a few bugs in the symbol editor... I don't really have time to report all on launchpad tonight but I will do it tomorrow. This is just a heads-up... Most of them seem wx related... Don't know if any of them are reported already... sorry 1. Zoom to fit doesn't seem to take into account for example the designator... Replicate by moving the designated far from the component, and zoom in the component area... zoom to fit won't show it! 2. The copy command in the action menu doesn't do anything... Replicate by trying to copy a block with: right click -> copy... The keyboard shortcuts are working... 3. Doing a move and pressing zoom to fit while moving something will "hide" the toolbar once you move the mouse. Replicate by moving something > pressing the zoom to fit button on the toolbar > and moving the mouse... 4. right click on a component of a library to duplicate it won't work... you need to first left click on the library list of components to make it active and then you can right click it... Replicate by right clicking on a component... an action menu will only display new or add library... 5. This one happened some times, but I don't really know how to replicate it... drawing a line after drawing a rectangle would make the rectangle briefly appear on the screen... like a graphic artifact... 6. Rotate block will deselect the selection block... I remember a while back Wayne fixed this one... It is happening again... System info: MACOS 10.13.2 Application: kicad Version: (2018-02-05 revision d1a45d1)-master, release build Libraries: wxWidgets 3.0.4 libcurl/7.54.0 LibreSSL/2.0.20 zlib/1.2.11 nghttp2/1.24.0 Platform: Mac OS X (Darwin 17.3.0 x86_64), 64 bit, Little endian, wxMac Build Info: wxWidgets: 3.0.4 (UTF-8,STL containers,compatible with 2.8) Boost: 1.61.0 Curl: 7.43.0 Compiler: Clang 7.3.0 with C++ ABI 1002 Build settings: USE_WX_GRAPHICS_CONTEXT=ON USE_WX_OVERLAY=ON KICAD_SCRIPTING=ON KICAD_SCRIPTING_MODULES=ON KICAD_SCRIPTING_WXPYTHON=ON KICAD_SCRIPTING_ACTION_MENU=ON BUILD_GITHUB_PLUGIN=ON KICAD_USE_OCE=ON KICAD_SPICE=ON Best regards, -- Diogo Condeço ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] disable icons in menus by default on osx
While personally I won't use icons in the menus if that option is available to me, I can see why someone would like to use them. I can see it being useful to identify actions visually, but with that in mind, I can't understand why having icons and reusing them on different functions would help anyone. I've attached a screenshot where the same icon is used for 3 different actions BR, Diogo On Thu, Sep 7, 2017 at 3:59 PM, Miguel Angel Ajo Pelayo <majop...@redhat.com > wrote: > I personally (as a user) find the icons visually more intuitive. Specially > for newcomers and better adoption of KiCad. > > I know it's out of some guidelines, but this is a very complex software. > > My feeling is that it's better with a "on" by default setting, as long as > people already used to the software, or not liking icons could disable them. > > On Thu, Sep 7, 2017 at 4:34 PM, Michael Kavanagh < > mich...@michaelkavanagh.me> wrote: > >> Hi, >> >> Sorry to bring this up again, but for me icons are still enabled by >> default on macOS (and Windows unsurprisingly). I deleted >> /Library/Application Support/kicad, ~/Library/Preferences/kicad and >> /Applications/Kicad, reinstalled from most recent nightly (07-Sep-2017) >> and the icons were there upon startup. >> >> I think the problem was the default value was true when the key wasn't >> found (ie for new install), see http://docs.wxwidgets.org/ >> trunk/classwx_config_base.html#a93b700301e0b73f1b42f14497f2e6bc7 >> >> I have attached a patch to turn icons off by default on all platforms >> (doing away with "ugly" #if defined()/#endif). I think this would be >> preferable as per both the macOS and Windows guidelines. I am >> unfamiliar with Linux UI's but if Linux users want the icons enabled by >> default the #if will have to be added again. >> >> Cheers, >> Michael >> >> >> On 13 April 2017 at 18:51, Wayne Stambaugh <stambau...@gmail.com> wrote: >> >>> Simon, >>> >>> I committed your patch since osx expects the icons to be disabled by >>> default. >>> >>> Thanks, >>> >>> Wayne >>> >>> On 4/8/2017 6:42 AM, Simon Wells wrote: >>> > Please see attached patch to disable icons in the menus by default on >>> osx >>> > >>> > >>> > >>> > ___ >>> > Mailing list: https://launchpad.net/~kicad-developers >>> > Post to : kicad-developers@lists.launchpad.net >>> > Unsubscribe : https://launchpad.net/~kicad-developers >>> > More help : https://help.launchpad.net/ListHelp >>> > >>> >>> ___ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : kicad-developers@lists.launchpad.net >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> >> >> >> _______ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> >> > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > > -- Diogo Condeço ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Trying to build locally - OS X Sierra
Hi Miron, There are some scripts... I use these: https://github.com/xzcvczx/kicad-app For incremental builds: ./kicad-app.sh kicad_build >From scratch: ./kicad-app.sh kicad_rebuild BR On Mon, Feb 27, 2017 at 7:22 PM, Miron Iancu <mia...@asign.ro> wrote: > Thank you all. > > How do you build OS X distributions ? Boxed, i.e. for example in a XCode > IDE or command-line based ? > I am trying to figure out the best practices you embrace which might make > a bit easier for me to set it up locally. > > The documentation is not quite straightforward but I assume one is not > using XCode at all. > > Another question -> for Nick: "kicad cmake scripts..." inside CMakeModules > ? > > > BR > Miron > > > Pe 27 feb. 2017, la 17:00, Nick Østergaard <oe.n...@gmail.com> a scris: > > > > Usually, on linux it does build fine without openmp... but it is a > > long time since I have tried that. Maybe there is a bad check in the > > kicad cmake scripts handling that on osx? > > > > 2017-02-27 15:58 GMT+01:00 Mário Luzeiro <mrluze...@ua.pt>: > >> AFAIK if OpenMP is not present (or not enabled..etc), the source code > (based on OpenMP #pragmas) can still be buidable. > >> > >> Maybe you can try to force disable it? > >> > >> Mario > >> > >> From: Kicad-developers [kicad-developers-bounces+mrluzeiro=ua.pt@lists. > launchpad.net] on behalf of Miron Iancu [mia...@asign.ro] > >> Sent: 27 February 2017 14:42 > >> To: KiCad Developers > >> Subject: [Kicad-developers] Trying to build locally - OS X Sierra > >> > >> Dear All, > >> > >> I am trying to do a local build on a Mac OS X Sierra (10.12.3) based > on the instructions found here but cmake fails with > >> > >> -- Try OpenMP C flag = [-fopenmp=libomp] > >> -- Performing Test OpenMP_FLAG_DETECTED > >> -- Performing Test OpenMP_FLAG_DETECTED - Failed > >> > >> AFAIK since OS X Maverick, clang does not support omp anymore. > >> > >> Can you, please, provide a bit of support ? > >> > >> Thank you in advance. > >> > >> Regards, > >> > >> Miron > >> > >> > >> ___ > >> Mailing list: https://launchpad.net/~kicad-developers > >> Post to : kicad-developers@lists.launchpad.net > >> Unsubscribe : https://launchpad.net/~kicad-developers > >> More help : https://help.launchpad.net/ListHelp > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > -- Diogo Condeço ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support
Hi Jon, Thanks that was the issue... Attached is a patch for this issue... Please credit Jon with it... Thanks, Diogo On Wed, Feb 22, 2017 at 7:01 PM, Jon Evans <j...@craftyjon.com> wrote: > Thanks Chris. > That line was hidden inside an #if block that only compiles for Mac, so > it's possible there are others that also need to be fixed -- anywhere > expecting a wxColour will now get COLOR4D and needs the ".ToColour()" > added. Unfortunately I can't search through the code right now, but will > also be more available in ~6 hours > > -Jon > > On Wed, Feb 22, 2017 at 1:59 PM, Chris Pavlina <pavlina.ch...@gmail.com> > wrote: > >> I'll have a look at MacOS build tonight if Diogo doesn't figure it out >> first. >> >> On Feb 22, 2017 1:57 PM, "Jon Evans" <j...@craftyjon.com> wrote: >> >>> Hi Diogo, >>> >>> Unfortunately I cannot test on Mac OS at all, and can't test on any >>> platform this minute. >>> But, I think you have to change that line to: >>> >>> wxPen pen( GetParent()->GetGridColor().ToColour(), h ); >>> >>> -Jon >>> >>> On Wed, Feb 22, 2017 at 1:05 PM, Diogo Condeço <diogocond...@gmail.com> >>> wrote: >>> >>>> Hi Jon, >>>> >>>> Your patch 0001 on this thread introduced a bug which makes kicad >>>> unable to build... >>>> >>>> a52250a91e24733ce798ad8baa4597032d49d11e this was the commit. >>>> >>>> kicad/common/draw_panel.cpp:757:15: error: no matching constructor for >>>> initialization of 'wxPen' >>>> wxPen pen( GetParent()->GetGridColor(), h ); >>>> >>>> >>>> This is on a macos machine with clang. >>>> >>>> Thanks, >>>> >>>> Diogo >>>> >>>> >>>> On Wed, Feb 22, 2017 at 4:56 PM, Maciej Sumiński < >>>> maciej.sumin...@cern.ch> wrote: >>>> >>>>> Great, so now they are in the master repository. Thank you for the >>>>> patches. >>>>> >>>>> Regards, >>>>> Orson >>>>> >>>>> On 02/22/2017 02:10 PM, Jon Evans wrote: >>>>> > Yes, they are ready to merge. >>>>> > >>>>> > Best, >>>>> > Jon >>>>> > >>>>> > On Feb 22, 2017 03:37, "Maciej Sumiński" <maciej.sumin...@cern.ch> >>>>> wrote: >>>>> > >>>>> >> I got a response from Wayne saying he is ok with the changes (I >>>>> suppose >>>>> >> the mail was meant to be sent here). Do you think the patches ready >>>>> to >>>>> >> be merged? They seem complete to me, but I just want to confirm. >>>>> >> >>>>> >> Regards, >>>>> >> Orson >>>>> >> >>>>> >> On 02/20/2017 06:55 PM, Jon Evans wrote: >>>>> >>> Thanks Orson, no I don't mind changing to static consts! >>>>> >>> >>>>> >>> Best, >>>>> >>> Jon >>>>> >>> >>>>> >>> On Mon, Feb 20, 2017 at 12:50 PM, Maciej Sumiński < >>>>> >> maciej.sumin...@cern.ch> >>>>> >>> wrote: >>>>> >>> >>>>> >>>> Hi Jon, >>>>> >>>> >>>>> >>>> I have just tested the patch, and I really like it. I just need >>>>> to test >>>>> >>>> it a bit longer, as there are numerous changes, but I am in favor >>>>> of >>>>> >>>> merging the patch. >>>>> >>>> >>>>> >>>> I also applied one more patch changing a few defines (UNSPECIFIED, >>>>> >>>> BLACK, WHITE) to static consts, I hope you do not mind. >>>>> >>>> >>>>> >>>> If there are other people interested in testing, I have rebased >>>>> the >>>>> >>>> changes [1] on the current master. There are also a few minor code >>>>> >>>> formatting fixes. >>>>> >>>> >>>>> >>>> Regards, >>>>> >>>> Orson >>>>> >>>> >>>>> >>>> 1. https://code.launchpa
Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support
Still regarding the above issue... It seems one of two issues: 1- either wrong number of arguments; or 2- wrong type of arguments for the wxPen constructor... Or it could be a mix of both. :) Thanks, Diogo On Wed, Feb 22, 2017 at 6:05 PM, Diogo Condeço <diogocond...@gmail.com> wrote: > Hi Jon, > > Your patch 0001 on this thread introduced a bug which makes kicad unable > to build... > > a52250a91e24733ce798ad8baa4597032d49d11e this was the commit. > > kicad/common/draw_panel.cpp:757:15: error: no matching constructor for > initialization of 'wxPen' > wxPen pen( GetParent()->GetGridColor(), h ); > > > This is on a macos machine with clang. > > Thanks, > > Diogo > > > On Wed, Feb 22, 2017 at 4:56 PM, Maciej Sumiński <maciej.sumin...@cern.ch> > wrote: > >> Great, so now they are in the master repository. Thank you for the >> patches. >> >> Regards, >> Orson >> >> On 02/22/2017 02:10 PM, Jon Evans wrote: >> > Yes, they are ready to merge. >> > >> > Best, >> > Jon >> > >> > On Feb 22, 2017 03:37, "Maciej Sumiński" <maciej.sumin...@cern.ch> >> wrote: >> > >> >> I got a response from Wayne saying he is ok with the changes (I suppose >> >> the mail was meant to be sent here). Do you think the patches ready to >> >> be merged? They seem complete to me, but I just want to confirm. >> >> >> >> Regards, >> >> Orson >> >> >> >> On 02/20/2017 06:55 PM, Jon Evans wrote: >> >>> Thanks Orson, no I don't mind changing to static consts! >> >>> >> >>> Best, >> >>> Jon >> >>> >> >>> On Mon, Feb 20, 2017 at 12:50 PM, Maciej Sumiński < >> >> maciej.sumin...@cern.ch> >> >>> wrote: >> >>> >> >>>> Hi Jon, >> >>>> >> >>>> I have just tested the patch, and I really like it. I just need to >> test >> >>>> it a bit longer, as there are numerous changes, but I am in favor of >> >>>> merging the patch. >> >>>> >> >>>> I also applied one more patch changing a few defines (UNSPECIFIED, >> >>>> BLACK, WHITE) to static consts, I hope you do not mind. >> >>>> >> >>>> If there are other people interested in testing, I have rebased the >> >>>> changes [1] on the current master. There are also a few minor code >> >>>> formatting fixes. >> >>>> >> >>>> Regards, >> >>>> Orson >> >>>> >> >>>> 1. https://code.launchpad.net/~orsonmmz/kicad/+git/kicad/+ref/colors >> >>>> >> >>>> On 02/18/2017 09:24 PM, Jon Evans wrote: >> >>>>> Hi all, >> >>>>> >> >>>>> Attached is a follow-up patch to the COLOR4D change above -- I >> reverted >> >>>>> from using wxColourPickerCtrl back to wxBitmapButton in the eeschema >> >>>> color >> >>>>> config, because I finally got my Windows 10 testing environment set >> up, >> >>>> and >> >>>>> found out that for some reason wxColourPickerCtrl looks really ugly >> in >> >>>>> Windows 10. >> >>>>> >> >>>>> Best, >> >>>>> Jon >> >>>>> >> >>>>> On Fri, Feb 10, 2017 at 8:43 PM, Jon Evans <j...@craftyjon.com> >> wrote: >> >>>>> >> >>>>>> Hi all, >> >>>>>> >> >>>>>> Attached is a (rather large!) patch that changes the internal color >> >>>>>> representation to COLOR4D across the codebase (except for places >> that >> >>>>>> directly deal with wx, where wxColour is used). >> >>>>>> >> >>>>>> This patch also enables arbitrary color selection for schematic and >> >>>> symbol >> >>>>>> library editor, as well as pcbnew in the GAL canvas. GerbView and >> >>>> pcbnew >> >>>>>> legacy canvas still use the old color picker. Colors will be >> coerced >> >>>> into >> >>>>>> the legacy palette when switching from GAL to legacy, in a way that >> >>>> tries >> >>>>>> t
Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support
Hi Jon, Your patch 0001 on this thread introduced a bug which makes kicad unable to build... a52250a91e24733ce798ad8baa4597032d49d11e this was the commit. kicad/common/draw_panel.cpp:757:15: error: no matching constructor for initialization of 'wxPen' wxPen pen( GetParent()->GetGridColor(), h ); This is on a macos machine with clang. Thanks, Diogo On Wed, Feb 22, 2017 at 4:56 PM, Maciej Sumiński <maciej.sumin...@cern.ch> wrote: > Great, so now they are in the master repository. Thank you for the patches. > > Regards, > Orson > > On 02/22/2017 02:10 PM, Jon Evans wrote: > > Yes, they are ready to merge. > > > > Best, > > Jon > > > > On Feb 22, 2017 03:37, "Maciej Sumiński" <maciej.sumin...@cern.ch> > wrote: > > > >> I got a response from Wayne saying he is ok with the changes (I suppose > >> the mail was meant to be sent here). Do you think the patches ready to > >> be merged? They seem complete to me, but I just want to confirm. > >> > >> Regards, > >> Orson > >> > >> On 02/20/2017 06:55 PM, Jon Evans wrote: > >>> Thanks Orson, no I don't mind changing to static consts! > >>> > >>> Best, > >>> Jon > >>> > >>> On Mon, Feb 20, 2017 at 12:50 PM, Maciej Sumiński < > >> maciej.sumin...@cern.ch> > >>> wrote: > >>> > >>>> Hi Jon, > >>>> > >>>> I have just tested the patch, and I really like it. I just need to > test > >>>> it a bit longer, as there are numerous changes, but I am in favor of > >>>> merging the patch. > >>>> > >>>> I also applied one more patch changing a few defines (UNSPECIFIED, > >>>> BLACK, WHITE) to static consts, I hope you do not mind. > >>>> > >>>> If there are other people interested in testing, I have rebased the > >>>> changes [1] on the current master. There are also a few minor code > >>>> formatting fixes. > >>>> > >>>> Regards, > >>>> Orson > >>>> > >>>> 1. https://code.launchpad.net/~orsonmmz/kicad/+git/kicad/+ref/colors > >>>> > >>>> On 02/18/2017 09:24 PM, Jon Evans wrote: > >>>>> Hi all, > >>>>> > >>>>> Attached is a follow-up patch to the COLOR4D change above -- I > reverted > >>>>> from using wxColourPickerCtrl back to wxBitmapButton in the eeschema > >>>> color > >>>>> config, because I finally got my Windows 10 testing environment set > up, > >>>> and > >>>>> found out that for some reason wxColourPickerCtrl looks really ugly > in > >>>>> Windows 10. > >>>>> > >>>>> Best, > >>>>> Jon > >>>>> > >>>>> On Fri, Feb 10, 2017 at 8:43 PM, Jon Evans <j...@craftyjon.com> > wrote: > >>>>> > >>>>>> Hi all, > >>>>>> > >>>>>> Attached is a (rather large!) patch that changes the internal color > >>>>>> representation to COLOR4D across the codebase (except for places > that > >>>>>> directly deal with wx, where wxColour is used). > >>>>>> > >>>>>> This patch also enables arbitrary color selection for schematic and > >>>> symbol > >>>>>> library editor, as well as pcbnew in the GAL canvas. GerbView and > >>>> pcbnew > >>>>>> legacy canvas still use the old color picker. Colors will be > coerced > >>>> into > >>>>>> the legacy palette when switching from GAL to legacy, in a way that > >>>> tries > >>>>>> to preserve the hue and value. > >>>>>> > >>>>>> Colors are serialized to the settings in CSS format, because it > >> supports > >>>>>> alpha and represents color components the same way COLOR4D does (as > >>>>>> floating-point values from 0 to 1) > >>>>>> > >>>>>> Tested on Linux. Can't test on Windows or Mac yet, sorry. > >>>>>> I realize this is a large changeset and might take a while to > review, > >> so > >>>>>> just ping me if it stops applying on master and I'll update it. > >>>>>> > >>>>>> Best, > >>>>>
Re: [Kicad-developers] Copper Zone Minimum width vs spoke width
Yes the patch is not really working... sorry too many builds :D On Fri, Feb 3, 2017 at 5:49 PM, jp charras <jp.char...@wanadoo.fr> wrote: > Le 03/02/2017 à 18:29, Diogo Condeço a écrit : > > Is there any objection to change the dialog validation of the spoke > width to allow it to be greater > > or _*equal*_ than the minimum width? Currently it has to be greater... > But if you allow for that > > minimum width one would assume you could use it in the spokes width... > > > > If there isn't an objection the following patch should do it. Also the > message is updated. > > > > Thanks > > -- > > Diogo Condeço > > > Filling algorithm needs a spoke width > minimum width, not >= minimum > width. > > > -- > Jean-Pierre CHARRAS > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > -- Diogo Condeço ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] Copper Zone Minimum width vs spoke width
Is there any objection to change the dialog validation of the spoke width to allow it to be greater or *equal* than the minimum width? Currently it has to be greater... But if you allow for that minimum width one would assume you could use it in the spokes width... If there isn't an objection the following patch should do it. Also the message is updated. Thanks -- Diogo Condeço 0001-Zone-properties-patch-to-allow-spoked-width-be-equal.patch Description: Binary data ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Changed the 3d model previewer to use spinboxes
Just a side note... This is working 100% in macos... The focus is working just fine... on 3D preview it zooms in and out... On Tue, Jan 31, 2017 at 8:03 PM, Wayne Stambaugh <stambau...@gmail.com> wrote: > Better but there is still a problem on windows. Once an edit control > has the mouse event focus, you can no longer use the mouse wheel to zoom > the model preview pane. Left button clicking or double-clicking in the > 3D model preview pane makes no difference. On windows it's pretty > typical albeit annoying to left click in a window so it will receive the > mouse events. I have to click on the one of the isometric view buttons > to restore the mouse wheel zoom of the model preview pane. You could > possibly use EVT_ENTER_WINDOW and EVT_LEAVE_WINDOW events to provide > hover focus for the edit controls but this could be rather challenging > on windows. > > Other than that it seems reasonable. I think some of the increment > sizes could be a bit smaller. Perhaps 5° for angles and 0.02" for offsets. > > On 1/31/2017 8:03 AM, Kristoffer Ödmark wrote: > > The real motivation for doing this was the functionality of the > > scrollwheel. Which I got for free in the spinctrldouble, only in linux > > though. > > > > But since the implementation of spinctrls was horrible on other os, I > > stuck with the textctrl and instead catch the mouse events and also the > > keyevents pgup/pgdown and subtract/add. > > > > I did not implement the arrowbuttons, but the increment functionality is > > there if anyone wants/cares for the up/down arrowbuttons. > > > > tested on windows and linux. > > > > - Kristoffer > > > > On 2017-01-31 10:01, Mário Luzeiro wrote: > >> Just and idea: > >> What about, somehow, this could be implemented with a second pair of > >> widgets? > >> i.e: keep the line entries as before, and somehow, catching the scroll > >> mouse events on that line entry.. and may add arrow buttons on the > >> side, to work as a spinbox? :S > >> > >> My 2 cents, > >> Mario Luzeiro > >> > >> From: Kicad-developers > >> [kicad-developers-bounces+mrluzeiro=ua...@lists.launchpad.net] on > >> behalf of Wayne Stambaugh [stambau...@gmail.com] > >> Sent: 31 January 2017 01:30 > >> To: kicad-developers@lists.launchpad.net > >> Subject: Re: [Kicad-developers] [PATCH] Changed the 3d model previewer > >> to use spinboxes > >> > >> Manual entry now works on windows but you changed the behavior. > >> Currently, as you enter a number in the edit control, the changes update > >> instantly. With your patch, you have to tab to the next control before > >> the change is made. IMO, this is a step backwards from the current > >> behavior at least on windows. I'm not sure I'm good with this > >> regression. Anyone else have any thoughts on this. > >> > >> ___ > >> Mailing list: https://launchpad.net/~kicad-developers > >> Post to : kicad-developers@lists.launchpad.net > >> Unsubscribe : https://launchpad.net/~kicad-developers > >> More help : https://help.launchpad.net/ListHelp > >> > > > > > > ___ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : kicad-developers@lists.launchpad.net > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > -- Diogo Condeço ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Eeschema one_field_edit dialog setselection patch
Hopefully both problems are corrected in this patch... Sorry for the code formatting but I'm not that used to this particular format... and sometimes I'll give an extra space... I will try to be more careful next time. Thanks, Diogo On Tue, Jan 31, 2017 at 7:30 PM, Wayne Stambaugh <stambau...@gmail.com> wrote: > Diogo, > > Please pay attention to you code formatting. I saw: > > if ( ... ) > > instead of: > > if( ... ) > > more than once in your patch. > > Thanks, > > Wayne > > On 1/31/2017 2:13 PM, Chris Pavlina wrote: > > /home/cmp/git/kicad/eeschema/dialogs/dialog_edit_one_field.cpp: In > member function ‘virtual bool DIALOG_EDIT_ONE_FIELD:: > TransferDataToWindow()’: > > /home/cmp/git/kicad/eeschema/dialogs/dialog_edit_one_field.cpp:174:42: > warning: comparison between signed and unsigned integer expressions > [-Wsign-compare] > > if ( m_text.find_first_of( '?' ) != -1 ) > >^ > > > > wxString::find_first_of returns size_t, so that comparison will always > > be false. > > > > Fix this and I'll merge it - I've been wanting this for a while now :) > > > > On Tue, Jan 31, 2017 at 06:46:05PM +, Diogo Condeço wrote: > >> Hi all, > >> > >> This patch selects the text in the dialog. > >> For references the text selected is either the number or the ? (for > >> unannotated symbols). > >> > >> For the other cases the entire text is selected. > >> > >> This has been tested in windows ( > >> http://downloads.kicad-pcb.org/windows/testing/patched/ > kicad-patched-540-35fc1f3-x86_64.exe) > >> and osx. > >> A previous version was also tested in linux so it also should be working > >> since only the data selection changed. > >> > >> Thanks > >> > >> -- > >> Diogo Condeço > > > > > > ___ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : kicad-developers@lists.launchpad.net > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > -- Diogo Condeço 0001-Eeschema-one-field-dialog-text-selection.patch Description: Binary data ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] Eeschema one_field_edit dialog setselection patch
Hi all, This patch selects the text in the dialog. For references the text selected is either the number or the ? (for unannotated symbols). For the other cases the entire text is selected. This has been tested in windows ( http://downloads.kicad-pcb.org/windows/testing/patched/kicad-patched-540-35fc1f3-x86_64.exe) and osx. A previous version was also tested in linux so it also should be working since only the data selection changed. Thanks -- Diogo Condeço 0001-Eeschema-one-field-dialog-text-selection.patch Description: Binary data ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Modedit graphical item properties dialog patch
Hi all, As we discussed attached is a patch to correct SetFocus issues and the CancelButtonIssue. SetFocus requires DLGSHIM_USE_SETFOCUS to be set, which is only set when __WXMAC__ is defined. I've tested this on my system and it is working -> example is the eeschema edit reference value dialog which was still not working... FixCancelButtonIssue() is now called from DIALOG_SHIM::Show and was removed from all the dialogs. Should it be made private? This is working for all the created dialogs, apart from the wxTextEntryDialog default dialogs... Although the issue can be fixed by the same trick. I've also noticed the pcbnew/dialog_track_via_properties is not autoresizing well in every system... Like the graphical lines is... This is not related with this patch... Should this also be addressed? There are also some SetFocus optimisations I will work on. Like track_vias and graphical items to select the first coordinate. And also SetSelection to select the text... BR, Diogo On Thu, Jan 26, 2017 at 4:13 PM, Wayne Stambaugh <stambau...@gmail.com> wrote: > On 1/26/2017 10:06 AM, Diogo Condeço wrote: > > @Orson yes moving it into Show seems to work. I will remove the > > FixOSXCancelButtonIssue() call from other dialogs to test it further... > > > > The only dialog I found this doesn't work is the new input for a new > > footprint on the module editor... > > > > @Wayne this is the cancel (cmd-c) button issue... I don't see how the > > SetFocus can be resolved in this DIALOG_SHIM since the field to have > > focus is different from dialog to dialog... > > If a control (wxWindow) has the focus set in the dialog constructor, I'm > guessing that wxWindow::FindFocus() will return that window called from > Show() so you do not need direct access to the pointer to the control. > I could be wrong but it should be fairly easy to test. > > > > > On Thu, Jan 26, 2017 at 2:26 PM, Wayne Stambaugh <stambau...@gmail.com > > <mailto:stambau...@gmail.com>> wrote: > > > > On 1/26/2017 2:52 AM, Maciej Sumiński wrote: > > > On 01/25/2017 08:14 PM, Diogo Condeço wrote: > > >> Hi all, > > >> > > >> This patch corrects the CMD+C cancel dialog bug on macos... There > are still > > >> some both in the footprint editor, and the board editor. I will > try to > > >> patch them once i can get some free time. > > > > > > I wonder if FixOSXCancelButtonIssue() call could be moved to OnShow > > > event handler in DIALOG_SHIM. This way it would be invoked > automatically > > > for every dialog inheriting from DIALOG_SHIM (and I guess this > covers > > > majority of cases) without manually fixing them one by one. > > > > > >> There is still the setfocus issue, which I will try to get later > on... But > > >> I would like to go through the code, since I don't really know if > there is > > >> the need to have two different classes for > graphical_item_properties... One > > >> for the FP editor another for the Board Editor... << Any input on > this? > > > > > > There is a lot of repeated code, but also a few subtle > differences. If > > > everything could be covered by the same code, I am for it. > > > > I was thinking the same thing as each of these patches has very > similar > > code. This is why DIALOG_SHIM exists to provide features and fixes > to > > wxDialog. If they osx focus fix can be handled in DIALOG_SHIM, than > I > > would prefer it be fixed there rather than every single dialog > > source file. > > > > > > > > Regards, > > > Orson > > > > > >> Thanks, > > >> > > >> > > >> > > >> ___ > > >> Mailing list: https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > >> Post to : kicad-developers@lists.launchpad.net > > <mailto:kicad-developers@lists.launchpad.net> > > >> Unsubscribe : https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > >> More help : https://help.launchpad.net/ListHelp > > <https://help.launchpad.net/ListHelp> > > >> > > > > > > > > > > > > > > > ___ > > > Mailing list: https://launchpad.net/~kicad-dev
Re: [Kicad-developers] Modedit graphical item properties dialog patch
@Orson yes moving it into Show seems to work. I will remove the FixOSXCancelButtonIssue() call from other dialogs to test it further... The only dialog I found this doesn't work is the new input for a new footprint on the module editor... @Wayne this is the cancel (cmd-c) button issue... I don't see how the SetFocus can be resolved in this DIALOG_SHIM since the field to have focus is different from dialog to dialog... On Thu, Jan 26, 2017 at 2:26 PM, Wayne Stambaugh <stambau...@gmail.com> wrote: > On 1/26/2017 2:52 AM, Maciej Sumiński wrote: > > On 01/25/2017 08:14 PM, Diogo Condeço wrote: > >> Hi all, > >> > >> This patch corrects the CMD+C cancel dialog bug on macos... There are > still > >> some both in the footprint editor, and the board editor. I will try to > >> patch them once i can get some free time. > > > > I wonder if FixOSXCancelButtonIssue() call could be moved to OnShow > > event handler in DIALOG_SHIM. This way it would be invoked automatically > > for every dialog inheriting from DIALOG_SHIM (and I guess this covers > > majority of cases) without manually fixing them one by one. > > > >> There is still the setfocus issue, which I will try to get later on... > But > >> I would like to go through the code, since I don't really know if there > is > >> the need to have two different classes for graphical_item_properties... > One > >> for the FP editor another for the Board Editor... << Any input on this? > > > > There is a lot of repeated code, but also a few subtle differences. If > > everything could be covered by the same code, I am for it. > > I was thinking the same thing as each of these patches has very similar > code. This is why DIALOG_SHIM exists to provide features and fixes to > wxDialog. If they osx focus fix can be handled in DIALOG_SHIM, than I > would prefer it be fixed there rather than every single dialog source file. > > > > > Regards, > > Orson > > > >> Thanks, > >> > >> > >> > >> ___ > >> Mailing list: https://launchpad.net/~kicad-developers > >> Post to : kicad-developers@lists.launchpad.net > >> Unsubscribe : https://launchpad.net/~kicad-developers > >> More help : https://help.launchpad.net/ListHelp > >> > > > > > > > > > > ___ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : kicad-developers@lists.launchpad.net > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > -- Diogo Condeço ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] Modedit graphical item properties dialog patch
Hi all, This patch corrects the CMD+C cancel dialog bug on macos... There are still some both in the footprint editor, and the board editor. I will try to patch them once i can get some free time. There is still the setfocus issue, which I will try to get later on... But I would like to go through the code, since I don't really know if there is the need to have two different classes for graphical_item_properties... One for the FP editor another for the Board Editor... << Any input on this? Thanks, -- Diogo Condeço 0001-MACOS-CMD-C-fix-on-Module-Editor-graphical-items-pro.patch Description: Binary data ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Dialog SetFocus patches for OSX
Once I've finished the edit value/reference dialog in eeschema, I will try to get back to it. Thanks. On Mon, Jan 23, 2017 at 3:10 PM, Wayne Stambaugh <stambau...@gmail.com> wrote: > The focus loss doesn't happen on windows so this must be an osx specific > behavior. I'll apply the patches since they address the initial focus > issue on osx. > > On 1/23/2017 10:01 AM, Simon Wells wrote: > > Just a comment on the pad properties dialog, it works fine on init but > > the field loses focus when i mouse over the "preview" part of the > > dialog... is there a way to prevent this? (it should really only lose > > focus if someone clicks in the preview area) although i am unsure of > > the intricacies of wx and osx as to whether you unfocused zooming and > > panning and such work. > > > > On 23 January 2017 at 12:34, Wayne Stambaugh <stambau...@gmail.com> > wrote: > >> Would one of our osx devs test these patches and let me know if I should > >> commit them. I don't see any coding policy violations so as long as > >> they fix the problems on osx then I will commit them. > >> > >> Thanks, > >> > >> Wayne > >> > >> On 1/22/2017 5:52 PM, Diogo Condeço wrote: > >>> Hi all, > >>> > >>> I've attached 2 patches for some SetFocus optimisations on Macos. > Tested > >>> also on Linux where there wasn't the issue, and it is still ok. This > was > >>> a macos specific problem... > >>> > >>> 0001 fixes the find dialog and pad_properties dialog on pcbnew > >>> 0002 fixes add_component dialog on eeschema > >>> > >>> I've used the recommended wxFB3.5-RC1 > >>> (https://github.com/marekr/wxFormBuilder.git > >>> <https://github.com/marekr/wxFormBuilder.git>) to modify the dialogs. > >>> Which isn't also working on macos making it hard to use it... > >>> > >>> > >>> > >>> -- > >>> Diogo Condeço > >>> > >>> > >>> ___ > >>> Mailing list: https://launchpad.net/~kicad-developers > >>> Post to : kicad-developers@lists.launchpad.net > >>> Unsubscribe : https://launchpad.net/~kicad-developers > >>> More help : https://help.launchpad.net/ListHelp > >>> > >> > >> > >> _______ > >> Mailing list: https://launchpad.net/~kicad-developers > >> Post to : kicad-developers@lists.launchpad.net > >> Unsubscribe : https://launchpad.net/~kicad-developers > >> More help : https://help.launchpad.net/ListHelp > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > -- Diogo Condeço ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] Dialog SetFocus patches for OSX
Hi all, I've attached 2 patches for some SetFocus optimisations on Macos. Tested also on Linux where there wasn't the issue, and it is still ok. This was a macos specific problem... 0001 fixes the find dialog and pad_properties dialog on pcbnew 0002 fixes add_component dialog on eeschema I've used the recommended wxFB3.5-RC1 (https://github.com/marekr/ wxFormBuilder.git) to modify the dialogs. Which isn't also working on macos making it hard to use it... -- Diogo Condeço 0001-Macos-SetFocus-and-SetSelection-moved-into-OnInitDia.patch Description: Binary data 0002-eeschema-add_component-setfocus-moved-into-OnInitDia.patch Description: Binary data ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] Dialog SetFocus && SetSelection patch
Hi all, I've attached a patch to correct some dialog behaviour in kicad. Tested on mac os x and windows... Affected dialogs are: pcbnew > find component - set focus and selection pcbnew > pad properties - set focus and selection eeschema > add component - only set focus IMHO the correct behaviour should be set focus to the first or most relevant field and select the text in it for prompt replacement... In some cases this might be different like eeschema add component, where the cursor goes to the text field but the selection goes the the last one used (if it exists). I've also managed to get edit field in eeschema (edit reference/value field dialog) to work on mac os x, but in windows it isn't working 100%, so I will release it later... Since this dialog is shared for different values, it is a little bit trickier... The patch is quite simple just add the OnDialogInit event to take care of the setfocus and setselection operation. I don't have wxformbuilder to edit the generated files, so I did it by hand... so forgive me for not caring about the // PLEASE DO "NOT" EDIT THIS FILE! note Please test it and let me know the result... Also if you find more problematic dialogs let me know and I can change them. I am 1% sure there are more with setfocus problems... it's just a question of find them. Once the other dialog is working I will post the patch. -- Diogo Condeço 0001-Dialogs-SetFocus-SetSelection.patch Description: Binary data ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
