[Kicad-developers] [PATCH] Allow hierarchy navigator to stay open

2019-10-24 Thread franck . jullien 
From: Franck Jullien 

Signed-off-by: Franck Jullien 
---
 eeschema/dialogs/panel_eeschema_settings.cpp  |   6 +-
 .../dialogs/panel_eeschema_settings_base.cpp  |   6 +-
 .../dialogs/panel_eeschema_settings_base.fbp  | 575 +++---
 .../dialogs/panel_eeschema_settings_base.h|   5 +-
 eeschema/eeschema_config.cpp  |   9 +-
 eeschema/hierarch.cpp |   6 +-
 eeschema/sch_edit_frame.h |   4 +
 7 files changed, 104 insertions(+), 507 deletions(-)

diff --git a/eeschema/dialogs/panel_eeschema_settings.cpp 
b/eeschema/dialogs/panel_eeschema_settings.cpp
index d50b8a373..bf6788b07 100644
--- a/eeschema/dialogs/panel_eeschema_settings.cpp
+++ b/eeschema/dialogs/panel_eeschema_settings.cpp
@@ -46,7 +46,8 @@ bool PANEL_EESCHEMA_SETTINGS::TransferDataToWindow()
 
 m_checkHVOrientation->SetValue( m_frame->GetForceHVLines() );
 m_footprintPreview->SetValue( m_frame->GetShowFootprintPreviews() );
-
+m_navigatorStaysOpen->SetValue( m_frame->GetNavigatorStaysOpen() );
+
 m_checkAutoplaceFields->SetValue( m_frame->GetAutoplaceFields() );
 m_checkAutoplaceJustify->SetValue( m_frame->GetAutoplaceJustify() );
 m_checkAutoplaceAlign->SetValue( m_frame->GetAutoplaceAlign() );
@@ -75,7 +76,8 @@ bool PANEL_EESCHEMA_SETTINGS::TransferDataFromWindow()
 
 m_frame->SetForceHVLines( m_checkHVOrientation->GetValue() );
 m_frame->SetShowFootprintPreviews( m_footprintPreview->GetValue() );
-
+m_frame->SetNavigatorStaysOpen( m_navigatorStaysOpen->GetValue() );
+
 m_frame->SetAutoplaceFields( m_checkAutoplaceFields->GetValue() );
 m_frame->SetAutoplaceJustify( m_checkAutoplaceJustify->GetValue() );
 m_frame->SetAutoplaceAlign( m_checkAutoplaceAlign->GetValue() );
diff --git a/eeschema/dialogs/panel_eeschema_settings_base.cpp 
b/eeschema/dialogs/panel_eeschema_settings_base.cpp
index 84c6470b1..ea5656291 100644
--- a/eeschema/dialogs/panel_eeschema_settings_base.cpp
+++ b/eeschema/dialogs/panel_eeschema_settings_base.cpp
@@ -1,5 +1,5 @@
 ///
-// C++ code generated with wxFormBuilder (version Dec 30 2017)
+// C++ code generated with wxFormBuilder (version Oct 24 2019)
 // http://www.wxformbuilder.org/
 //
 // PLEASE DO *NOT* EDIT THIS FILE!
@@ -123,7 +123,9 @@ PANEL_EESCHEMA_SETTINGS_BASE::PANEL_EESCHEMA_SETTINGS_BASE( 
wxWindow* parent, wx

m_footprintPreview = new wxCheckBox( this, wxID_ANY, _("Show footprint 
previews in symbol chooser"), wxDefaultPosition, wxDefaultSize, 0 );
bSizer9->Add( m_footprintPreview, 0, wxBOTTOM|wxLEFT|wxRIGHT, 5 );
-   
+
+   m_navigatorStaysOpen = new wxCheckBox( this, wxID_ANY, _("Allow 
hierarchy navigator to stay open"), wxDefaultPosition, wxDefaultSize, 0 );
+   bSizer9->Add( m_navigatorStaysOpen, 0, wxALL, 5 );  

bLeftColumn->Add( bSizer9, 0, wxTOP|wxBOTTOM|wxRIGHT, 5 );

diff --git a/eeschema/dialogs/panel_eeschema_settings_base.fbp 
b/eeschema/dialogs/panel_eeschema_settings_base.fbp
index 6bc9b6da1..6bbd79fec 100644
--- a/eeschema/dialogs/panel_eeschema_settings_base.fbp
+++ b/eeschema/dialogs/panel_eeschema_settings_base.fbp
@@ -1,6 +1,6 @@
 
 
-
+
 
 
 C++
@@ -14,6 +14,8 @@
 panel_eeschema_settings_base
 1000
 none
+
+
 1
 PanelEeschemaSettingsBase
 
@@ -24,6 +26,7 @@
 1
 1
 UI
+0
 1
 0
 
@@ -48,36 +51,6 @@
 
 
 wxTAB_TRAVERSAL
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
 
 
 bPanelSizer
@@ -141,6 +114,7 @@
 0
 wxID_ANY
 &Measurement units:
+0
 
 0
 
@@ -166,29 +140,6 @@

Re: [Kicad-developers] [PATCH] Allow hierarchy navigator to stay open

2019-10-24 Thread Franck Jullien 
As discussed on the forum, it can be handy to let the navigator open
while working on a project.
I don't know if I choose the best place to add the new checkbox.

Franck.

Le jeu. 24 oct. 2019 à 19:25,  a écrit :
>
> From: Franck Jullien 
>
> Signed-off-by: Franck Jullien 
> ---
>  eeschema/dialogs/panel_eeschema_settings.cpp  |   6 +-
>  .../dialogs/panel_eeschema_settings_base.cpp  |   6 +-
>  .../dialogs/panel_eeschema_settings_base.fbp  | 575 +++---
>  .../dialogs/panel_eeschema_settings_base.h|   5 +-
>  eeschema/eeschema_config.cpp  |   9 +-
>  eeschema/hierarch.cpp |   6 +-
>  eeschema/sch_edit_frame.h |   4 +
>  7 files changed, 104 insertions(+), 507 deletions(-)
>
> diff --git a/eeschema/dialogs/panel_eeschema_settings.cpp 
> b/eeschema/dialogs/panel_eeschema_settings.cpp
> index d50b8a373..bf6788b07 100644
> --- a/eeschema/dialogs/panel_eeschema_settings.cpp
> +++ b/eeschema/dialogs/panel_eeschema_settings.cpp
> @@ -46,7 +46,8 @@ bool PANEL_EESCHEMA_SETTINGS::TransferDataToWindow()
>
>  m_checkHVOrientation->SetValue( m_frame->GetForceHVLines() );
>  m_footprintPreview->SetValue( m_frame->GetShowFootprintPreviews() );
> -
> +m_navigatorStaysOpen->SetValue( m_frame->GetNavigatorStaysOpen() );
> +
>  m_checkAutoplaceFields->SetValue( m_frame->GetAutoplaceFields() );
>  m_checkAutoplaceJustify->SetValue( m_frame->GetAutoplaceJustify() );
>  m_checkAutoplaceAlign->SetValue( m_frame->GetAutoplaceAlign() );
> @@ -75,7 +76,8 @@ bool PANEL_EESCHEMA_SETTINGS::TransferDataFromWindow()
>
>  m_frame->SetForceHVLines( m_checkHVOrientation->GetValue() );
>  m_frame->SetShowFootprintPreviews( m_footprintPreview->GetValue() );
> -
> +m_frame->SetNavigatorStaysOpen( m_navigatorStaysOpen->GetValue() );
> +
>  m_frame->SetAutoplaceFields( m_checkAutoplaceFields->GetValue() );
>  m_frame->SetAutoplaceJustify( m_checkAutoplaceJustify->GetValue() );
>  m_frame->SetAutoplaceAlign( m_checkAutoplaceAlign->GetValue() );
> diff --git a/eeschema/dialogs/panel_eeschema_settings_base.cpp 
> b/eeschema/dialogs/panel_eeschema_settings_base.cpp
> index 84c6470b1..ea5656291 100644
> --- a/eeschema/dialogs/panel_eeschema_settings_base.cpp
> +++ b/eeschema/dialogs/panel_eeschema_settings_base.cpp
> @@ -1,5 +1,5 @@
>  ///
> -// C++ code generated with wxFormBuilder (version Dec 30 2017)
> +// C++ code generated with wxFormBuilder (version Oct 24 2019)
>  // http://www.wxformbuilder.org/
>  //
>  // PLEASE DO *NOT* EDIT THIS FILE!
> @@ -123,7 +123,9 @@ 
> PANEL_EESCHEMA_SETTINGS_BASE::PANEL_EESCHEMA_SETTINGS_BASE( wxWindow* parent, 
> wx
>
> m_footprintPreview = new wxCheckBox( this, wxID_ANY, _("Show 
> footprint previews in symbol chooser"), wxDefaultPosition, wxDefaultSize, 0 );
> bSizer9->Add( m_footprintPreview, 0, wxBOTTOM|wxLEFT|wxRIGHT, 5 );
> -
> +
> +   m_navigatorStaysOpen = new wxCheckBox( this, wxID_ANY, _("Allow 
> hierarchy navigator to stay open"), wxDefaultPosition, wxDefaultSize, 0 );
> +   bSizer9->Add( m_navigatorStaysOpen, 0, wxALL, 5 );
>
> bLeftColumn->Add( bSizer9, 0, wxTOP|wxBOTTOM|wxRIGHT, 5 );
>
> diff --git a/eeschema/dialogs/panel_eeschema_settings_base.fbp 
> b/eeschema/dialogs/panel_eeschema_settings_base.fbp
> index 6bc9b6da1..6bbd79fec 100644
> --- a/eeschema/dialogs/panel_eeschema_settings_base.fbp
> +++ b/eeschema/dialogs/panel_eeschema_settings_base.fbp
> @@ -1,6 +1,6 @@
>  
>  
> -
> +
>  
>  
>  C++
> @@ -14,6 +14,8 @@
>  panel_eeschema_settings_base
>  1000
>  none
> +
> +
>  1
>  PanelEeschemaSettingsBase
>  
> @@ -24,6 +26,7 @@
>  1
>  1
>  UI
> +0
>  1
>  0
>  
> @@ -48,36 +51,6 @@
>  
>  
>  wxTAB_TRAVERSAL
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
>  
&

Re: [Kicad-developers] [PATCH] Allow hierarchy navigator to stay open

2019-10-24 Thread Franck Jullien 
Forget this, wrong patch.
Sorry for the noise.

I'm sending the new one.

Le jeu. 24 oct. 2019 à 19:27, Franck Jullien
 a écrit :
>
> As discussed on the forum, it can be handy to let the navigator open
> while working on a project.
> I don't know if I choose the best place to add the new checkbox.
>
> Franck.
>
> Le jeu. 24 oct. 2019 à 19:25,  a écrit :
> >
> > From: Franck Jullien 
> >
> > Signed-off-by: Franck Jullien 
> > ---
> >  eeschema/dialogs/panel_eeschema_settings.cpp  |   6 +-
> >  .../dialogs/panel_eeschema_settings_base.cpp  |   6 +-
> >  .../dialogs/panel_eeschema_settings_base.fbp  | 575 +++---
> >  .../dialogs/panel_eeschema_settings_base.h|   5 +-
> >  eeschema/eeschema_config.cpp  |   9 +-
> >  eeschema/hierarch.cpp |   6 +-
> >  eeschema/sch_edit_frame.h |   4 +
> >  7 files changed, 104 insertions(+), 507 deletions(-)
> >
> > diff --git a/eeschema/dialogs/panel_eeschema_settings.cpp 
> > b/eeschema/dialogs/panel_eeschema_settings.cpp
> > index d50b8a373..bf6788b07 100644
> > --- a/eeschema/dialogs/panel_eeschema_settings.cpp
> > +++ b/eeschema/dialogs/panel_eeschema_settings.cpp
> > @@ -46,7 +46,8 @@ bool PANEL_EESCHEMA_SETTINGS::TransferDataToWindow()
> >
> >  m_checkHVOrientation->SetValue( m_frame->GetForceHVLines() );
> >  m_footprintPreview->SetValue( m_frame->GetShowFootprintPreviews() );
> > -
> > +m_navigatorStaysOpen->SetValue( m_frame->GetNavigatorStaysOpen() );
> > +
> >  m_checkAutoplaceFields->SetValue( m_frame->GetAutoplaceFields() );
> >  m_checkAutoplaceJustify->SetValue( m_frame->GetAutoplaceJustify() );
> >  m_checkAutoplaceAlign->SetValue( m_frame->GetAutoplaceAlign() );
> > @@ -75,7 +76,8 @@ bool PANEL_EESCHEMA_SETTINGS::TransferDataFromWindow()
> >
> >  m_frame->SetForceHVLines( m_checkHVOrientation->GetValue() );
> >  m_frame->SetShowFootprintPreviews( m_footprintPreview->GetValue() );
> > -
> > +m_frame->SetNavigatorStaysOpen( m_navigatorStaysOpen->GetValue() );
> > +
> >  m_frame->SetAutoplaceFields( m_checkAutoplaceFields->GetValue() );
> >  m_frame->SetAutoplaceJustify( m_checkAutoplaceJustify->GetValue() );
> >  m_frame->SetAutoplaceAlign( m_checkAutoplaceAlign->GetValue() );
> > diff --git a/eeschema/dialogs/panel_eeschema_settings_base.cpp 
> > b/eeschema/dialogs/panel_eeschema_settings_base.cpp
> > index 84c6470b1..ea5656291 100644
> > --- a/eeschema/dialogs/panel_eeschema_settings_base.cpp
> > +++ b/eeschema/dialogs/panel_eeschema_settings_base.cpp
> > @@ -1,5 +1,5 @@
> >  ///
> > -// C++ code generated with wxFormBuilder (version Dec 30 2017)
> > +// C++ code generated with wxFormBuilder (version Oct 24 2019)
> >  // http://www.wxformbuilder.org/
> >  //
> >  // PLEASE DO *NOT* EDIT THIS FILE!
> > @@ -123,7 +123,9 @@ 
> > PANEL_EESCHEMA_SETTINGS_BASE::PANEL_EESCHEMA_SETTINGS_BASE( wxWindow* 
> > parent, wx
> >
> > m_footprintPreview = new wxCheckBox( this, wxID_ANY, _("Show 
> > footprint previews in symbol chooser"), wxDefaultPosition, wxDefaultSize, 0 
> > );
> > bSizer9->Add( m_footprintPreview, 0, wxBOTTOM|wxLEFT|wxRIGHT, 5 );
> > -
> > +
> > +   m_navigatorStaysOpen = new wxCheckBox( this, wxID_ANY, _("Allow 
> > hierarchy navigator to stay open"), wxDefaultPosition, wxDefaultSize, 0 );
> > +   bSizer9->Add( m_navigatorStaysOpen, 0, wxALL, 5 );
> >
> > bLeftColumn->Add( bSizer9, 0, wxTOP|wxBOTTOM|wxRIGHT, 5 );
> >
> > diff --git a/eeschema/dialogs/panel_eeschema_settings_base.fbp 
> > b/eeschema/dialogs/panel_eeschema_settings_base.fbp
> > index 6bc9b6da1..6bbd79fec 100644
> > --- a/eeschema/dialogs/panel_eeschema_settings_base.fbp
> > +++ b/eeschema/dialogs/panel_eeschema_settings_base.fbp
> > @@ -1,6 +1,6 @@
> >  
> >  
> > -
> > +
> >  
> >  
> >  C++
> > @@ -14,6 +14,8 @@
> >  panel_eeschema_settings_base
> >  1000
> >  none
> > +
> > +
> >  1
> >  PanelEeschemaSettingsBase
> >  
> > @@ -24,6 +26,7 @@
> >  1
> >  1
> >  UI
> > +0
> >  1
> >  0
> >  
> >

[Kicad-developers] [PATCH] eeschema: Allow hierarchy navigator to stay open

2019-10-24 Thread franck . jullien 
From: Franck Jullien 

Signed-off-by: Franck Jullien 
---
 eeschema/dialogs/panel_eeschema_settings.cpp  |  2 +
 .../dialogs/panel_eeschema_settings_base.cpp  |  2 +
 .../dialogs/panel_eeschema_settings_base.fbp  | 88 +++
 .../dialogs/panel_eeschema_settings_base.h|  3 +-
 eeschema/eeschema_config.cpp  |  3 +
 eeschema/hierarch.cpp |  6 +-
 eeschema/sch_edit_frame.h |  4 +
 7 files changed, 104 insertions(+), 4 deletions(-)

diff --git a/eeschema/dialogs/panel_eeschema_settings.cpp 
b/eeschema/dialogs/panel_eeschema_settings.cpp
index d50b8a373..3ad650d18 100644
--- a/eeschema/dialogs/panel_eeschema_settings.cpp
+++ b/eeschema/dialogs/panel_eeschema_settings.cpp
@@ -46,6 +46,7 @@ bool PANEL_EESCHEMA_SETTINGS::TransferDataToWindow()
 
 m_checkHVOrientation->SetValue( m_frame->GetForceHVLines() );
 m_footprintPreview->SetValue( m_frame->GetShowFootprintPreviews() );
+m_navigatorStaysOpen->SetValue( m_frame->GetNavigatorStaysOpen() );
 
 m_checkAutoplaceFields->SetValue( m_frame->GetAutoplaceFields() );
 m_checkAutoplaceJustify->SetValue( m_frame->GetAutoplaceJustify() );
@@ -75,6 +76,7 @@ bool PANEL_EESCHEMA_SETTINGS::TransferDataFromWindow()
 
 m_frame->SetForceHVLines( m_checkHVOrientation->GetValue() );
 m_frame->SetShowFootprintPreviews( m_footprintPreview->GetValue() );
+m_frame->SetNavigatorStaysOpen( m_navigatorStaysOpen->GetValue() );
 
 m_frame->SetAutoplaceFields( m_checkAutoplaceFields->GetValue() );
 m_frame->SetAutoplaceJustify( m_checkAutoplaceJustify->GetValue() );
diff --git a/eeschema/dialogs/panel_eeschema_settings_base.cpp 
b/eeschema/dialogs/panel_eeschema_settings_base.cpp
index 84c6470b1..7553170b0 100644
--- a/eeschema/dialogs/panel_eeschema_settings_base.cpp
+++ b/eeschema/dialogs/panel_eeschema_settings_base.cpp
@@ -124,6 +124,8 @@ PANEL_EESCHEMA_SETTINGS_BASE::PANEL_EESCHEMA_SETTINGS_BASE( 
wxWindow* parent, wx
m_footprintPreview = new wxCheckBox( this, wxID_ANY, _("Show footprint 
previews in symbol chooser"), wxDefaultPosition, wxDefaultSize, 0 );
bSizer9->Add( m_footprintPreview, 0, wxBOTTOM|wxLEFT|wxRIGHT, 5 );

+   m_navigatorStaysOpen = new wxCheckBox( this, wxID_ANY, _("Allow 
hierarchy navigator to stay open"), wxDefaultPosition, wxDefaultSize, 0 );
+   bSizer9->Add( m_navigatorStaysOpen, 0, wxBOTTOM|wxLEFT|wxRIGHT, 5 );

bLeftColumn->Add( bSizer9, 0, wxTOP|wxBOTTOM|wxRIGHT, 5 );

diff --git a/eeschema/dialogs/panel_eeschema_settings_base.fbp 
b/eeschema/dialogs/panel_eeschema_settings_base.fbp
index 6bc9b6da1..a8996f56f 100644
--- a/eeschema/dialogs/panel_eeschema_settings_base.fbp
+++ b/eeschema/dialogs/panel_eeschema_settings_base.fbp
@@ -1810,6 +1810,94 @@
 
 
 
+
+5
+wxALL
+0
+
+1
+1
+1
+1
+
+
+
+
+
+
+
+1
+0
+1
+1
+
+1
+0
+Dock
+0
+Left
+1
+
+1
+
+0
+0
+wxID_ANY
+Allow hierarchy 
navigator to stay open
+
+0
+
+
+0
+
+1
+m_navigatorStaysOpen
+1
+
+
+

Re: [Kicad-developers] [PATCH] eeschema: Allow hierarchy navigator to stay open

2019-11-03 Thread Franck Jullien 
Le jeu. 24 oct. 2019 à 19:29,  a écrit :
>
> From: Franck Jullien 
>
> Signed-off-by: Franck Jullien 
> ---
>  eeschema/dialogs/panel_eeschema_settings.cpp  |  2 +
>  .../dialogs/panel_eeschema_settings_base.cpp  |  2 +
>  .../dialogs/panel_eeschema_settings_base.fbp  | 88 +++
>  .../dialogs/panel_eeschema_settings_base.h|  3 +-
>  eeschema/eeschema_config.cpp  |  3 +
>  eeschema/hierarch.cpp |  6 +-
>  eeschema/sch_edit_frame.h |  4 +
>  7 files changed, 104 insertions(+), 4 deletions(-)
>
> diff --git a/eeschema/dialogs/panel_eeschema_settings.cpp 
> b/eeschema/dialogs/panel_eeschema_settings.cpp
> index d50b8a373..3ad650d18 100644
> --- a/eeschema/dialogs/panel_eeschema_settings.cpp
> +++ b/eeschema/dialogs/panel_eeschema_settings.cpp
> @@ -46,6 +46,7 @@ bool PANEL_EESCHEMA_SETTINGS::TransferDataToWindow()
>
>  m_checkHVOrientation->SetValue( m_frame->GetForceHVLines() );
>  m_footprintPreview->SetValue( m_frame->GetShowFootprintPreviews() );
> +m_navigatorStaysOpen->SetValue( m_frame->GetNavigatorStaysOpen() );
>
>  m_checkAutoplaceFields->SetValue( m_frame->GetAutoplaceFields() );
>  m_checkAutoplaceJustify->SetValue( m_frame->GetAutoplaceJustify() );
> @@ -75,6 +76,7 @@ bool PANEL_EESCHEMA_SETTINGS::TransferDataFromWindow()
>
>  m_frame->SetForceHVLines( m_checkHVOrientation->GetValue() );
>  m_frame->SetShowFootprintPreviews( m_footprintPreview->GetValue() );
> +m_frame->SetNavigatorStaysOpen( m_navigatorStaysOpen->GetValue() );
>
>  m_frame->SetAutoplaceFields( m_checkAutoplaceFields->GetValue() );
>  m_frame->SetAutoplaceJustify( m_checkAutoplaceJustify->GetValue() );
> diff --git a/eeschema/dialogs/panel_eeschema_settings_base.cpp 
> b/eeschema/dialogs/panel_eeschema_settings_base.cpp
> index 84c6470b1..7553170b0 100644
> --- a/eeschema/dialogs/panel_eeschema_settings_base.cpp
> +++ b/eeschema/dialogs/panel_eeschema_settings_base.cpp
> @@ -124,6 +124,8 @@ 
> PANEL_EESCHEMA_SETTINGS_BASE::PANEL_EESCHEMA_SETTINGS_BASE( wxWindow* parent, 
> wx
> m_footprintPreview = new wxCheckBox( this, wxID_ANY, _("Show 
> footprint previews in symbol chooser"), wxDefaultPosition, wxDefaultSize, 0 );
> bSizer9->Add( m_footprintPreview, 0, wxBOTTOM|wxLEFT|wxRIGHT, 5 );
>
> +   m_navigatorStaysOpen = new wxCheckBox( this, wxID_ANY, _("Allow 
> hierarchy navigator to stay open"), wxDefaultPosition, wxDefaultSize, 0 );
> +   bSizer9->Add( m_navigatorStaysOpen, 0, wxBOTTOM|wxLEFT|wxRIGHT, 5 );
>
> bLeftColumn->Add( bSizer9, 0, wxTOP|wxBOTTOM|wxRIGHT, 5 );
>
> diff --git a/eeschema/dialogs/panel_eeschema_settings_base.fbp 
> b/eeschema/dialogs/panel_eeschema_settings_base.fbp
> index 6bc9b6da1..a8996f56f 100644
> --- a/eeschema/dialogs/panel_eeschema_settings_base.fbp
> +++ b/eeschema/dialogs/panel_eeschema_settings_base.fbp
> @@ -1810,6 +1810,94 @@
>  
>  
>  
> +
> +5
> +wxALL
> +0
> +
> + name="BottomDockable">1
> + name="LeftDockable">1
> + name="RightDockable">1
> + name="TopDockable">1
> + name="aui_layer">
> +
> + name="aui_position">
> +
> + name="best_size">
> +
> +
> + name="caption_visible">1
> + name="center_pane">0
> +1
> + name="close_button">1
> + name="context_help">
> + name="context_menu">1
> + name="default_pane">0
> +Dock
> +

[Kicad-developers] [PATCH v2] eeschema: Allow hierarchy navigator to stay open

2019-11-04 Thread franck . jullien 
From: Franck Jullien 

Signed-off-by: Franck Jullien 
---
 eeschema/dialogs/panel_eeschema_settings.cpp  |  2 +
 .../dialogs/panel_eeschema_settings_base.cpp  |  2 +
 .../dialogs/panel_eeschema_settings_base.fbp  | 88 +++
 .../dialogs/panel_eeschema_settings_base.h|  3 +-
 eeschema/eeschema_config.cpp  |  3 +
 eeschema/hierarch.cpp |  6 +-
 eeschema/sch_edit_frame.h |  4 +
 7 files changed, 104 insertions(+), 4 deletions(-)

diff --git a/eeschema/dialogs/panel_eeschema_settings.cpp 
b/eeschema/dialogs/panel_eeschema_settings.cpp
index d50b8a373..3ad650d18 100644
--- a/eeschema/dialogs/panel_eeschema_settings.cpp
+++ b/eeschema/dialogs/panel_eeschema_settings.cpp
@@ -46,6 +46,7 @@ bool PANEL_EESCHEMA_SETTINGS::TransferDataToWindow()
 
 m_checkHVOrientation->SetValue( m_frame->GetForceHVLines() );
 m_footprintPreview->SetValue( m_frame->GetShowFootprintPreviews() );
+m_navigatorStaysOpen->SetValue( m_frame->GetNavigatorStaysOpen() );
 
 m_checkAutoplaceFields->SetValue( m_frame->GetAutoplaceFields() );
 m_checkAutoplaceJustify->SetValue( m_frame->GetAutoplaceJustify() );
@@ -75,6 +76,7 @@ bool PANEL_EESCHEMA_SETTINGS::TransferDataFromWindow()
 
 m_frame->SetForceHVLines( m_checkHVOrientation->GetValue() );
 m_frame->SetShowFootprintPreviews( m_footprintPreview->GetValue() );
+m_frame->SetNavigatorStaysOpen( m_navigatorStaysOpen->GetValue() );
 
 m_frame->SetAutoplaceFields( m_checkAutoplaceFields->GetValue() );
 m_frame->SetAutoplaceJustify( m_checkAutoplaceJustify->GetValue() );
diff --git a/eeschema/dialogs/panel_eeschema_settings_base.cpp 
b/eeschema/dialogs/panel_eeschema_settings_base.cpp
index 84c6470b1..7553170b0 100644
--- a/eeschema/dialogs/panel_eeschema_settings_base.cpp
+++ b/eeschema/dialogs/panel_eeschema_settings_base.cpp
@@ -124,6 +124,8 @@ PANEL_EESCHEMA_SETTINGS_BASE::PANEL_EESCHEMA_SETTINGS_BASE( 
wxWindow* parent, wx
m_footprintPreview = new wxCheckBox( this, wxID_ANY, _("Show footprint 
previews in symbol chooser"), wxDefaultPosition, wxDefaultSize, 0 );
bSizer9->Add( m_footprintPreview, 0, wxBOTTOM|wxLEFT|wxRIGHT, 5 );

+   m_navigatorStaysOpen = new wxCheckBox( this, wxID_ANY, _("Allow 
hierarchy navigator to stay open"), wxDefaultPosition, wxDefaultSize, 0 );
+   bSizer9->Add( m_navigatorStaysOpen, 0, wxBOTTOM|wxLEFT|wxRIGHT, 5 );

bLeftColumn->Add( bSizer9, 0, wxTOP|wxBOTTOM|wxRIGHT, 5 );

diff --git a/eeschema/dialogs/panel_eeschema_settings_base.fbp 
b/eeschema/dialogs/panel_eeschema_settings_base.fbp
index 6bc9b6da1..a8996f56f 100644
--- a/eeschema/dialogs/panel_eeschema_settings_base.fbp
+++ b/eeschema/dialogs/panel_eeschema_settings_base.fbp
@@ -1810,6 +1810,94 @@
 
 
 
+
+5
+wxALL
+0
+
+1
+1
+1
+1
+
+
+
+
+
+
+
+1
+0
+1
+1
+
+1
+0
+Dock
+0
+Left
+1
+
+1
+
+0
+0
+wxID_ANY
+Allow hierarchy 
navigator to stay open
+
+0
+
+
+0
+
+1
+m_navigatorStaysOpen
+1
+
+
+

Re: [Kicad-developers] [PATCH v2] eeschema: Allow hierarchy navigator to stay open

2019-11-04 Thread Franck Jullien 
Le lun. 4 nov. 2019 à 13:19, Wayne Stambaugh  a écrit :
>
> Hi Franck,
>
> There is a memory leak with your code.  The Destroy() method is never
> called when the hierarchy navigation dialog is closed.  When using
> modeless dialogs, you are responsible for cleaning up the dialog created
> on the heap.  The schematic editor Find/Replace dialog is modeless so
> you can use that as an example of how to handle modeless dialogs.
>
> Cheers,
>
> Wayne
>

Hi Wayne,

Good catch. Thanks for the review.
I'll do a v3 when I have some time.

Franck.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH v3] [NEW] eeschema: Allow hierarchy navigator to stay open

2019-11-07 Thread franck . jullien 
From: Franck Jullien 

User can now decide to keep the hierarchy navigator open while working
on a schematic. This behavior can be configured in
eeschema->preferences->eeschema->Editing options.

Signed-off-by: Franck Jullien 
---

v2: fix coding style
v3: fix memory leak after Wayne review

 eeschema/dialogs/panel_eeschema_settings.cpp  |  2 +
 .../dialogs/panel_eeschema_settings_base.cpp  |  2 +
 .../dialogs/panel_eeschema_settings_base.fbp  | 88 +
 .../dialogs/panel_eeschema_settings_base.h|  3 +-
 eeschema/eeschema_config.cpp  |  3 +
 eeschema/hierarch.cpp | 76 +++
 eeschema/hierarch.h   | 97 +++
 eeschema/sch_edit_frame.cpp   | 22 +
 eeschema/sch_edit_frame.h | 16 +++
 eeschema/tools/sch_editor_control.cpp |  5 +
 10 files changed, 248 insertions(+), 66 deletions(-)
 create mode 100644 eeschema/hierarch.h

diff --git a/eeschema/dialogs/panel_eeschema_settings.cpp 
b/eeschema/dialogs/panel_eeschema_settings.cpp
index d50b8a373..3ad650d18 100644
--- a/eeschema/dialogs/panel_eeschema_settings.cpp
+++ b/eeschema/dialogs/panel_eeschema_settings.cpp
@@ -46,6 +46,7 @@ bool PANEL_EESCHEMA_SETTINGS::TransferDataToWindow()
 
 m_checkHVOrientation->SetValue( m_frame->GetForceHVLines() );
 m_footprintPreview->SetValue( m_frame->GetShowFootprintPreviews() );
+m_navigatorStaysOpen->SetValue( m_frame->GetNavigatorStaysOpen() );
 
 m_checkAutoplaceFields->SetValue( m_frame->GetAutoplaceFields() );
 m_checkAutoplaceJustify->SetValue( m_frame->GetAutoplaceJustify() );
@@ -75,6 +76,7 @@ bool PANEL_EESCHEMA_SETTINGS::TransferDataFromWindow()
 
 m_frame->SetForceHVLines( m_checkHVOrientation->GetValue() );
 m_frame->SetShowFootprintPreviews( m_footprintPreview->GetValue() );
+m_frame->SetNavigatorStaysOpen( m_navigatorStaysOpen->GetValue() );
 
 m_frame->SetAutoplaceFields( m_checkAutoplaceFields->GetValue() );
 m_frame->SetAutoplaceJustify( m_checkAutoplaceJustify->GetValue() );
diff --git a/eeschema/dialogs/panel_eeschema_settings_base.cpp 
b/eeschema/dialogs/panel_eeschema_settings_base.cpp
index 84c6470b1..7553170b0 100644
--- a/eeschema/dialogs/panel_eeschema_settings_base.cpp
+++ b/eeschema/dialogs/panel_eeschema_settings_base.cpp
@@ -124,6 +124,8 @@ PANEL_EESCHEMA_SETTINGS_BASE::PANEL_EESCHEMA_SETTINGS_BASE( 
wxWindow* parent, wx
m_footprintPreview = new wxCheckBox( this, wxID_ANY, _("Show footprint 
previews in symbol chooser"), wxDefaultPosition, wxDefaultSize, 0 );
bSizer9->Add( m_footprintPreview, 0, wxBOTTOM|wxLEFT|wxRIGHT, 5 );

+   m_navigatorStaysOpen = new wxCheckBox( this, wxID_ANY, _("Allow 
hierarchy navigator to stay open"), wxDefaultPosition, wxDefaultSize, 0 );
+   bSizer9->Add( m_navigatorStaysOpen, 0, wxBOTTOM|wxLEFT|wxRIGHT, 5 );

bLeftColumn->Add( bSizer9, 0, wxTOP|wxBOTTOM|wxRIGHT, 5 );

diff --git a/eeschema/dialogs/panel_eeschema_settings_base.fbp 
b/eeschema/dialogs/panel_eeschema_settings_base.fbp
index 6bc9b6da1..a8996f56f 100644
--- a/eeschema/dialogs/panel_eeschema_settings_base.fbp
+++ b/eeschema/dialogs/panel_eeschema_settings_base.fbp
@@ -1810,6 +1810,94 @@
 
 
 
+
+5
+wxALL
+0
+
+1
+1
+1
+1
+
+
+
+
+
+
+
+1
+0
+1
+1
+
+1
+0
+Dock
+0
+Left
+1
+
+1
+
+0
+0
+wxID_ANY
+Allow hierarchy 
navigator

Re: [Kicad-developers] [PATCH v3] [NEW] eeschema: Allow hierarchy navigator to stay open

2019-11-10 Thread Franck Jullien 
Le jeu. 7 nov. 2019 à 21:51,  a écrit :
>
> From: Franck Jullien 
>
> User can now decide to keep the hierarchy navigator open while working
> on a schematic. This behavior can be configured in
> eeschema->preferences->eeschema->Editing options.
>
> Signed-off-by: Franck Jullien 
> ---
>
> v2: fix coding style
> v3: fix memory leak after Wayne review

I need to work on it again. If the navigator stays open and you add a
new page, the hierarchy is not updated.
I'll be back with a v4 :)

Franck.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH v3] [NEW] eeschema: Allow hierarchy navigator to stay open

2019-11-10 Thread Franck Jullien 
Le dim. 10 nov. 2019 à 18:29, jp charras  a écrit :
>
> Le 10/11/2019 à 17:33, Franck Jullien a écrit :
> > Le jeu. 7 nov. 2019 à 21:51,  a écrit :
> >>
> >> From: Franck Jullien 
> >>
> >> User can now decide to keep the hierarchy navigator open while working
> >> on a schematic. This behavior can be configured in
> >> eeschema->preferences->eeschema->Editing options.
> >>
> >> Signed-off-by: Franck Jullien 
> >> ---
> >>
> >> v2: fix coding style
> >> v3: fix memory leak after Wayne review
> >
> > I need to work on it again. If the navigator stays open and you add a
> > new page, the hierarchy is not updated.
> > I'll be back with a v4 :)
> >
> > Franck.
>
> Hi Franck,
>
> This is the main problem with not modal dialogs: they have to take in
> account changes made in an other frame, and this is not always easy.
>
> (Here: adding/renaming/deleting a hierarchical sheet)
>
> Remember: your patches must be in a attached file.
> Patch texts inside a mail cannot be used (are broken for patch utilities).

I didn't know patch must be attached. Moving to gitlab will be awsome :)
I'm sending a v4 now. Hopefully this is the last one.

Merci.

Franck.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH v4] [NEW] eeschema: Allow hierarchy navigator to stay open

2019-11-10 Thread Franck Jullien 
Hi,

This is version 4 of this patch.
Navigator now updates in real time when sheets are edited/removed/added.

Franck.
From 550f88483d598df41f38114fb4b24191f1442330 Mon Sep 17 00:00:00 2001
From: Franck Jullien 
Date: Thu, 24 Oct 2019 19:07:01 +0200
Subject: [PATCH v4] [NEW] eeschema: Allow hierarchy navigator to stay open

User can now decide to keep the hierarchy navigator open while working
on a schematic. This behavior can be configured in
eeschema->preferences->eeschema->Editing options.

Signed-off-by: Franck Jullien 
---

v2: fix coding style
v3: fix memory leak after Wayne review
v4: handle adding/renaming/deleting a hierarchical sheet while navigator is open

 eeschema/dialogs/panel_eeschema_settings.cpp  |  2 +
 .../dialogs/panel_eeschema_settings_base.cpp  |  2 +
 .../dialogs/panel_eeschema_settings_base.fbp  | 88 +
 .../dialogs/panel_eeschema_settings_base.h|  3 +-
 eeschema/eeschema_config.cpp  |  3 +
 eeschema/hierarch.cpp | 76 +++
 eeschema/hierarch.h   | 97 +++
 eeschema/sch_edit_frame.cpp   | 22 +
 eeschema/sch_edit_frame.h | 18 
 eeschema/tools/sch_drawing_tools.cpp  |  2 +
 eeschema/tools/sch_edit_tool.cpp  |  8 ++
 eeschema/tools/sch_editor_control.cpp | 11 +++
 12 files changed, 266 insertions(+), 66 deletions(-)
 create mode 100644 eeschema/hierarch.h

diff --git a/eeschema/dialogs/panel_eeschema_settings.cpp b/eeschema/dialogs/panel_eeschema_settings.cpp
index d50b8a373..3ad650d18 100644
--- a/eeschema/dialogs/panel_eeschema_settings.cpp
+++ b/eeschema/dialogs/panel_eeschema_settings.cpp
@@ -46,6 +46,7 @@ bool PANEL_EESCHEMA_SETTINGS::TransferDataToWindow()
 
 m_checkHVOrientation->SetValue( m_frame->GetForceHVLines() );
 m_footprintPreview->SetValue( m_frame->GetShowFootprintPreviews() );
+m_navigatorStaysOpen->SetValue( m_frame->GetNavigatorStaysOpen() );
 
 m_checkAutoplaceFields->SetValue( m_frame->GetAutoplaceFields() );
 m_checkAutoplaceJustify->SetValue( m_frame->GetAutoplaceJustify() );
@@ -75,6 +76,7 @@ bool PANEL_EESCHEMA_SETTINGS::TransferDataFromWindow()
 
 m_frame->SetForceHVLines( m_checkHVOrientation->GetValue() );
 m_frame->SetShowFootprintPreviews( m_footprintPreview->GetValue() );
+m_frame->SetNavigatorStaysOpen( m_navigatorStaysOpen->GetValue() );
 
 m_frame->SetAutoplaceFields( m_checkAutoplaceFields->GetValue() );
 m_frame->SetAutoplaceJustify( m_checkAutoplaceJustify->GetValue() );
diff --git a/eeschema/dialogs/panel_eeschema_settings_base.cpp b/eeschema/dialogs/panel_eeschema_settings_base.cpp
index 84c6470b1..7553170b0 100644
--- a/eeschema/dialogs/panel_eeschema_settings_base.cpp
+++ b/eeschema/dialogs/panel_eeschema_settings_base.cpp
@@ -124,6 +124,8 @@ PANEL_EESCHEMA_SETTINGS_BASE::PANEL_EESCHEMA_SETTINGS_BASE( wxWindow* parent, wx
 	m_footprintPreview = new wxCheckBox( this, wxID_ANY, _("Show footprint previews in symbol chooser"), wxDefaultPosition, wxDefaultSize, 0 );
 	bSizer9->Add( m_footprintPreview, 0, wxBOTTOM|wxLEFT|wxRIGHT, 5 );
 	
+	m_navigatorStaysOpen = new wxCheckBox( this, wxID_ANY, _("Allow hierarchy navigator to stay open"), wxDefaultPosition, wxDefaultSize, 0 );
+	bSizer9->Add( m_navigatorStaysOpen, 0, wxBOTTOM|wxLEFT|wxRIGHT, 5 );
 	
 	bLeftColumn->Add( bSizer9, 0, wxTOP|wxBOTTOM|wxRIGHT, 5 );
 	
diff --git a/eeschema/dialogs/panel_eeschema_settings_base.fbp b/eeschema/dialogs/panel_eeschema_settings_base.fbp
index 6bc9b6da1..a8996f56f 100644
--- a/eeschema/dialogs/panel_eeschema_settings_base.fbp
+++ b/eeschema/dialogs/panel_eeschema_settings_base.fbp
@@ -1810,6 +1810,94 @@
 
 
 
+
+5
+wxALL
+0
+
+1
+1
+1
+1
+
+
+
+
+
+
+
+1
+0
+1
+1
+
+1
+0
+Dock
+

Re: [Kicad-developers] [PATCH v3] [NEW] eeschema: Allow hierarchy navigator to stay open

2019-11-11 Thread Franck Jullien 
Too late :( I'll do that in a v5.

I thought tag should be in subject. I misread the instructions.

Franck.

Le lun. 11 nov. 2019 à 14:57, Maciej Suminski
 a écrit :
>
> Hi Franck,
>
> Please remember to add changelog tags [1] when sending patch v4. Thanks!
>
> Cheers,
> Orson
>
> 1. http://docs.kicad-pcb.org/doxygen/commit_messages.html
>
> On 11/10/19 7:36 PM, Franck Jullien wrote:
> > Le dim. 10 nov. 2019 à 18:29, jp charras  a écrit :
> >>
> >> Le 10/11/2019 à 17:33, Franck Jullien a écrit :
> >>> Le jeu. 7 nov. 2019 à 21:51,  a écrit :
> >>>>
> >>>> From: Franck Jullien 
> >>>>
> >>>> User can now decide to keep the hierarchy navigator open while working
> >>>> on a schematic. This behavior can be configured in
> >>>> eeschema->preferences->eeschema->Editing options.
> >>>>
> >>>> Signed-off-by: Franck Jullien 
> >>>> ---
> >>>>
> >>>> v2: fix coding style
> >>>> v3: fix memory leak after Wayne review
> >>>
> >>> I need to work on it again. If the navigator stays open and you add a
> >>> new page, the hierarchy is not updated.
> >>> I'll be back with a v4 :)
> >>>
> >>> Franck.
> >>
> >> Hi Franck,
> >>
> >> This is the main problem with not modal dialogs: they have to take in
> >> account changes made in an other frame, and this is not always easy.
> >>
> >> (Here: adding/renaming/deleting a hierarchical sheet)
> >>
> >> Remember: your patches must be in a attached file.
> >> Patch texts inside a mail cannot be used (are broken for patch utilities).
> >
> > I didn't know patch must be attached. Moving to gitlab will be awsome :)
> > I'm sending a v4 now. Hopefully this is the last one.
> >
> > Merci.
> >
> > Franck.
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH v5] eeschema: Allow hierarchy navigator to stay open

2019-11-11 Thread Franck Jullien 
Hi again !

I now have fixed the commit message to include a tag (ADD).

Franck.
From 350f5fc0ad7c128c3d152317297468a7b9516e62 Mon Sep 17 00:00:00 2001
From: Franck Jullien 
Date: Thu, 24 Oct 2019 19:07:01 +0200
Subject: [PATCH v5] eeschema: Allow hierarchy navigator to stay open

ADD: User can now decide to keep the hierarchy navigator open while working
on a schematic.

This behavior can be configured in eeschema->preferences->eeschema->Editing options.

Signed-off-by: Franck Jullien 
---

v2: fix coding style
v3: fix memory leak after Wayne review
v4: handle adding/renaming/deleting a hierarchical sheet while navigator is open
v5: add tag to commit message

 eeschema/dialogs/panel_eeschema_settings.cpp  |  2 +
 .../dialogs/panel_eeschema_settings_base.cpp  |  2 +
 .../dialogs/panel_eeschema_settings_base.fbp  | 88 +
 .../dialogs/panel_eeschema_settings_base.h|  3 +-
 eeschema/eeschema_config.cpp  |  3 +
 eeschema/hierarch.cpp | 76 +++
 eeschema/hierarch.h   | 97 +++
 eeschema/sch_edit_frame.cpp   | 22 +
 eeschema/sch_edit_frame.h | 18 
 eeschema/tools/sch_drawing_tools.cpp  |  2 +
 eeschema/tools/sch_edit_tool.cpp  |  8 ++
 eeschema/tools/sch_editor_control.cpp | 11 +++
 12 files changed, 266 insertions(+), 66 deletions(-)
 create mode 100644 eeschema/hierarch.h

diff --git a/eeschema/dialogs/panel_eeschema_settings.cpp b/eeschema/dialogs/panel_eeschema_settings.cpp
index d50b8a373..3ad650d18 100644
--- a/eeschema/dialogs/panel_eeschema_settings.cpp
+++ b/eeschema/dialogs/panel_eeschema_settings.cpp
@@ -46,6 +46,7 @@ bool PANEL_EESCHEMA_SETTINGS::TransferDataToWindow()
 
 m_checkHVOrientation->SetValue( m_frame->GetForceHVLines() );
 m_footprintPreview->SetValue( m_frame->GetShowFootprintPreviews() );
+m_navigatorStaysOpen->SetValue( m_frame->GetNavigatorStaysOpen() );
 
 m_checkAutoplaceFields->SetValue( m_frame->GetAutoplaceFields() );
 m_checkAutoplaceJustify->SetValue( m_frame->GetAutoplaceJustify() );
@@ -75,6 +76,7 @@ bool PANEL_EESCHEMA_SETTINGS::TransferDataFromWindow()
 
 m_frame->SetForceHVLines( m_checkHVOrientation->GetValue() );
 m_frame->SetShowFootprintPreviews( m_footprintPreview->GetValue() );
+m_frame->SetNavigatorStaysOpen( m_navigatorStaysOpen->GetValue() );
 
 m_frame->SetAutoplaceFields( m_checkAutoplaceFields->GetValue() );
 m_frame->SetAutoplaceJustify( m_checkAutoplaceJustify->GetValue() );
diff --git a/eeschema/dialogs/panel_eeschema_settings_base.cpp b/eeschema/dialogs/panel_eeschema_settings_base.cpp
index 84c6470b1..7553170b0 100644
--- a/eeschema/dialogs/panel_eeschema_settings_base.cpp
+++ b/eeschema/dialogs/panel_eeschema_settings_base.cpp
@@ -124,6 +124,8 @@ PANEL_EESCHEMA_SETTINGS_BASE::PANEL_EESCHEMA_SETTINGS_BASE( wxWindow* parent, wx
 	m_footprintPreview = new wxCheckBox( this, wxID_ANY, _("Show footprint previews in symbol chooser"), wxDefaultPosition, wxDefaultSize, 0 );
 	bSizer9->Add( m_footprintPreview, 0, wxBOTTOM|wxLEFT|wxRIGHT, 5 );
 	
+	m_navigatorStaysOpen = new wxCheckBox( this, wxID_ANY, _("Allow hierarchy navigator to stay open"), wxDefaultPosition, wxDefaultSize, 0 );
+	bSizer9->Add( m_navigatorStaysOpen, 0, wxBOTTOM|wxLEFT|wxRIGHT, 5 );
 	
 	bLeftColumn->Add( bSizer9, 0, wxTOP|wxBOTTOM|wxRIGHT, 5 );
 	
diff --git a/eeschema/dialogs/panel_eeschema_settings_base.fbp b/eeschema/dialogs/panel_eeschema_settings_base.fbp
index 6bc9b6da1..a8996f56f 100644
--- a/eeschema/dialogs/panel_eeschema_settings_base.fbp
+++ b/eeschema/dialogs/panel_eeschema_settings_base.fbp
@@ -1810,6 +1810,94 @@
 
 
 
+
+5
+wxALL
+0
+
+1
+1
+1
+1
+
+
+
+
+
+
+
+1
+0
+1
+1
+
+1
+0
+Dock
+

Re: [Kicad-developers] [PATCH v5] eeschema: Allow hierarchy navigator to stay open

2019-11-20 Thread Franck Jullien 
Le lun. 11 nov. 2019 à 16:59, Franck Jullien
 a écrit :
>
> Hi again !
>
> I now have fixed the commit message to include a tag (ADD).
>
> Franck.

If it can help the review, you can find this patch on github:

https://github.com/fjullien/kicad/commit/350f5fc0ad7c128c3d152317297468a7b9516e62

Franck.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH v5] eeschema: Allow hierarchy navigator to stay open

2019-11-21 Thread Franck Jullien 
Le mer. 20 nov. 2019 à 21:52, Franck Jullien
 a écrit :
>
> Le lun. 11 nov. 2019 à 16:59, Franck Jullien
>  a écrit :
> >
> > Hi again !
> >
> > I now have fixed the commit message to include a tag (ADD).
> >
> > Franck.
>
> If it can help the review, you can find this patch on github:
>
> https://github.com/fjullien/kicad/commit/350f5fc0ad7c128c3d152317297468a7b9516e62
>
> Franck.

After a review from Seth, here is a v6 of this patch:

https://github.com/fjullien/kicad/commit/12eda616f6f0e48117ad50db5c935274ee1886db

Franck.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] GitLab issues

2019-11-26 Thread Franck Jullien 
Hi,

I can't find this issue on GitLab: https://bugs.launchpad.net/kicad/+bug/1849376

Can you help me ?

Franck.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] GitLab issues

2019-11-26 Thread Franck Jullien 
I know, but I thought all issues have been moved.

Sorry for the noise.

Franck.

Le mar. 26 nov. 2019 à 10:40, Ian McInerney  a écrit :
>
> We have not officially migrated to GitLab yet, until we announce otherwise 
> the current platforms (Launchpad for bug reports/code, GitHub for 
> libraries/docs/translations) should be used. An announcement about the 
> transition will be made before it happens.
>
> -Ian
>
> On Tue, Nov 26, 2019 at 8:14 AM Franck Jullien  
> wrote:
>>
>> Hi,
>>
>> I can't find this issue on GitLab: 
>> https://bugs.launchpad.net/kicad/+bug/1849376
>>
>> Can you help me ?
>>
>> Franck.
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] GitLab issues

2019-11-26 Thread Franck Jullien 
Thanks. I did search here: https://gitlab.com/groups/kicad/-/issues
Not the same GitLab account.
Which one should we use ?

Franck.

Le mar. 26 nov. 2019 à 12:57, Maciej Suminski
 a écrit :
>
> Hi Franck,
>
> It is here: https://gitlab.com/orsonmmz/kicad-bug-tracker/issues/11175
> The easiest way to find a Launchpad bug report in Gitlab is to type the
> Launchpad bug id in the search box.
>
> Cheers,
> Orson
>
> On 11/26/19 9:14 AM, Franck Jullien wrote:
> > Hi,
> >
> > I can't find this issue on GitLab: 
> > https://bugs.launchpad.net/kicad/+bug/1849376
> >
> > Can you help me ?
> >
> > Franck.
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] GitLab issues

2019-11-26 Thread Franck Jullien 
Ok, thanks for the update.

Le mar. 26 nov. 2019 à 13:26, Maciej Suminski
 a écrit :
>
> We have not migrated to Gitlab yet, so the issues in
> orsonmmz/kicad-bug-tracker is just a test of the bug tracker migration
> script.
> For the moment, please continue to use Launchpad. We will announce the
> migration date (hopefully soon). The official group will be available
> under https://gitlab.com/kicad.
>
> Cheers,
> Orson
>
> On 11/26/19 1:01 PM, Franck Jullien wrote:
> > Thanks. I did search here: https://gitlab.com/groups/kicad/-/issues
> > Not the same GitLab account.
> > Which one should we use ?
> >
> > Franck.
> >
> > Le mar. 26 nov. 2019 à 12:57, Maciej Suminski
> >  a écrit :
> >>
> >> Hi Franck,
> >>
> >> It is here: https://gitlab.com/orsonmmz/kicad-bug-tracker/issues/11175
> >> The easiest way to find a Launchpad bug report in Gitlab is to type the
> >> Launchpad bug id in the search box.
> >>
> >> Cheers,
> >> Orson
> >>
> >> On 11/26/19 9:14 AM, Franck Jullien wrote:
> >>> Hi,
> >>>
> >>> I can't find this issue on GitLab: 
> >>> https://bugs.launchpad.net/kicad/+bug/1849376
> >>>
> >>> Can you help me ?
> >>>
> >>> Franck.
> >>>
> >>> ___
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to : kicad-developers@lists.launchpad.net
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
> >>>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Fix lp:1849376

2019-11-26 Thread Franck Jullien 
Hi,

Here attached you'll find a patch to correct issue 1849376 on launchpad.
When a component is placed, action addNeededJunctions is now triggered.

If some of you have some spare time, I also have two branches with
patches you can review and/or test. The first allows the hierarchy
navigator to stay open:

https://github.com/fjullien/kicad/tree/navigator_v6

The second branch as a patch adding a function to insert intersheets
references attached to global labels:

https://github.com/fjullien/kicad/tree/iref

Thanks in advance.

Franck.
From 6e2788c5153eaab4e312decd361b4fa9914b1eb5 Mon Sep 17 00:00:00 2001
From: Franck Jullien 
Date: Tue, 26 Nov 2019 22:03:19 +0100
Subject: [PATCH] eechema: add junction if needed when component is placed

Fixes: lp:1849376
* https://bugs.launchpad.net/kicad/+bug/1849376
---
 eeschema/tools/sch_drawing_tools.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/eeschema/tools/sch_drawing_tools.cpp b/eeschema/tools/sch_drawing_tools.cpp
index 05d6a0a04..35a3db363 100644
--- a/eeschema/tools/sch_drawing_tools.cpp
+++ b/eeschema/tools/sch_drawing_tools.cpp
@@ -191,6 +191,9 @@ int SCH_DRAWING_TOOLS::PlaceComponent(  const TOOL_EVENT& aEvent  )
 m_view->ClearPreview();
 m_frame->AddItemToScreenAndUndoList( component );
 
+m_toolMgr->RunAction( EE_ACTIONS::addNeededJunctions, true, component );
+m_frame->OnModify();
+
 if( m_frame->GetUseAllUnits() || m_frame->GetRepeatComponent() )
 {
 int new_unit = component->GetUnit();
-- 
2.17.1

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Fix lp:1849376

2019-11-27 Thread Franck Jullien 
> I took a look at the intersheet reference patch and it looks like a nice
> addition.  It will need to wait until after the schematic file format
> has been updated as it does introduce new functionality to the format.
> We won't be adding new functionality to the existing, legacy schematic
> file format.  So hold on to the patch for now and after the new format
> has been merged and the dust settles a bit, you can re-propose it.
>

Ok, no problem.

> A couple things to change in it when you do:
> - Please add CC-BY-SA-4.0 license to SVG you've created.  This goes in
> the metadata and is an option in newer Inkscapes.

Do we have someone good at icon design ?
Because I think this icon should be redraw. I'm not an artist :)

> - Code style places a space before the if-blocks
>

Ok. However, I ran check_coding.sh and it didn't find this particular problem.

> I haven't had a chance to look over the navigator yet but I may be able
> to get to it next week unless someone else has time first.
>

No problem.

Thanks for your time.

Franck.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] GitLab Jobs output

2019-12-05 Thread Franck Jullien 
Hi,

I'm exploring GitLab.

Here you can see a job marked "passed" with a strange output:

https://gitlab.com/j_liljedahl/kicad/-/jobs/368453258

36 $ ./tools/check_coding.sh --diff --commit $CI_COMMIT_BEFORE_SHA
37 fatal: bad object 
38 no modified files to format
43 Job succeeded

Is it an expected behaviour ?

Franck.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] GitLab Jobs output

2019-12-05 Thread Franck Jullien 
Ok, thanks.

Le jeu. 5 déc. 2019 à 11:55, Ian McInerney  a écrit :
>
> That was when we were first trying to figure out how to do the formatting 
> checks in the CI environment. It should be fixed in the current CI script in 
> master.
>
> -Ian
>
> On Thu, Dec 5, 2019 at 10:41 AM Franck Jullien  
> wrote:
>>
>> Hi,
>>
>> I'm exploring GitLab.
>>
>> Here you can see a job marked "passed" with a strange output:
>>
>> https://gitlab.com/j_liljedahl/kicad/-/jobs/368453258
>>
>> 36 $ ./tools/check_coding.sh --diff --commit $CI_COMMIT_BEFORE_SHA
>> 37 fatal: bad object 
>> 38 no modified files to format
>> 43 Job succeeded
>>
>> Is it an expected behaviour ?
>>
>> Franck.
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Help needed

2020-09-25 Thread Franck Jullien 
Hi,

I'm working on the intersheets references functionality and I'm
struggling with a segfault.
Until now, I didn't try to remove iref from sheets. Now, I do this with:

void SCH_EDIT_FRAME::RemoveAllIntersheetsRefs()
{
SCH_SHEET_LIST sheets = Schematic().GetSheets();
SCH_GLOBALLABEL* gLabel;

m_labelTable.clear();

for( const SCH_SHEET_PATH& sheet : sheets )
{
SCH_SCREEN* screen = sheet.LastScreen();

for( SCH_ITEM* item : screen->Items() )
{

if( item->Type() == SCH_GLOBAL_LABEL_T )
{
gLabel = (SCH_GLOBALLABEL*)( item );
SCH_IREF* iref = gLabel->GetIref();

if( iref )
{
gLabel->SetIref( nullptr );
gLabel->SetIrefSavedPosition( wxDefaultPosition );
screen->DeleteItem( iref );
}
}
}
}
}

As soon as I call DeleteItem (or RemoveFromScreen) I get a crash.
Is there something obvious I don't see ?

I still need to get familiar with screens, sheets, frames, canvas, views

Thanks in advance.

Franck.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Help needed

2020-09-25 Thread Franck Jullien 
Thanks for the tip, I didn't know we could run ASAN with Kicad easily.
This is what I get:

==7559==ERROR: AddressSanitizer: heap-use-after-free on address
0x612403c4 at pc 0x7f1ec5130bb9 bp 0x7ffe8351d540 sp
0x7ffe8351d530
READ of size 4 at 0x612403c4 thread T0
#0 0x7f1ec5130bb8 in RTree::Node::IsLeaf() ../kicad/thirdparty/rtree/geometry/rtree.h:481
#1 0x7f1ec51311d9 in RTree::Iterator::FindNextData()
../kicad/thirdparty/rtree/geometry/rtree.h:353
#2 0x7f1ec512f08d in RTree::Iterator::operator++()
../kicad/thirdparty/rtree/geometry/rtree.h:316
#3 0x7f1ec5938152 in SCH_EDIT_FRAME::RemoveAllIntersheetsRefs()
../kicad/eeschema/sch_edit_frame.cpp:1284
#4 0x7f1ec5938599 in SCH_EDIT_FRAME::CommonSettingsChanged(bool,
bool) ../kicad/eeschema/sch_edit_frame.cpp:1315
.

I'll take a look.

Le ven. 25 sept. 2020 à 16:32, Jon Evans  a écrit :
>
> Can you run with ASAN on (KICAD_SANITIZE in CMake) and see if you get some 
> info about why you get a segfault?
>
> On Fri, Sep 25, 2020 at 10:28 AM Franck Jullien  
> wrote:
>>
>> Hi,
>>
>> I'm working on the intersheets references functionality and I'm
>> struggling with a segfault.
>> Until now, I didn't try to remove iref from sheets. Now, I do this with:
>>
>> void SCH_EDIT_FRAME::RemoveAllIntersheetsRefs()
>> {
>> SCH_SHEET_LIST sheets = Schematic().GetSheets();
>> SCH_GLOBALLABEL* gLabel;
>>
>> m_labelTable.clear();
>>
>> for( const SCH_SHEET_PATH& sheet : sheets )
>> {
>> SCH_SCREEN* screen = sheet.LastScreen();
>>
>> for( SCH_ITEM* item : screen->Items() )
>> {
>>
>> if( item->Type() == SCH_GLOBAL_LABEL_T )
>> {
>> gLabel = (SCH_GLOBALLABEL*)( item );
>> SCH_IREF* iref = gLabel->GetIref();
>>
>> if( iref )
>> {
>> gLabel->SetIref( nullptr );
>> gLabel->SetIrefSavedPosition( wxDefaultPosition );
>> screen->DeleteItem( iref );
>> }
>> }
>> }
>> }
>> }
>>
>> As soon as I call DeleteItem (or RemoveFromScreen) I get a crash.
>> Is there something obvious I don't see ?
>>
>> I still need to get familiar with screens, sheets, frames, canvas, views
>>
>> Thanks in advance.
>>
>> Franck.
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Help needed

2020-09-25 Thread Franck Jullien 
Thank you Seth, it works now.

@Jean-Pierre : I'll do what you suggested and iterate over screens
instead of sheets.

Franck.

Le ven. 25 sept. 2020 à 19:10, Seth Hillbrand  a écrit :
>
> Hi Franck-
>
> You cannot delete items from the rtree while iterating over it, the 
> references are invalidated.  You will need to collect the items to delete in 
> a separate vector and delete them outside of the loop.
>
> Seth
>
> On Fri, Sep 25, 2020, 7:29 AM Franck Jullien  wrote:
>>
>> Hi,
>>
>> I'm working on the intersheets references functionality and I'm
>> struggling with a segfault.
>> Until now, I didn't try to remove iref from sheets. Now, I do this with:
>>
>> void SCH_EDIT_FRAME::RemoveAllIntersheetsRefs()
>> {
>> SCH_SHEET_LIST sheets = Schematic().GetSheets();
>> SCH_GLOBALLABEL* gLabel;
>>
>> m_labelTable.clear();
>>
>> for( const SCH_SHEET_PATH& sheet : sheets )
>> {
>> SCH_SCREEN* screen = sheet.LastScreen();
>>
>> for( SCH_ITEM* item : screen->Items() )
>> {
>>
>> if( item->Type() == SCH_GLOBAL_LABEL_T )
>> {
>> gLabel = (SCH_GLOBALLABEL*)( item );
>> SCH_IREF* iref = gLabel->GetIref();
>>
>> if( iref )
>> {
>> gLabel->SetIref( nullptr );
>> gLabel->SetIrefSavedPosition( wxDefaultPosition );
>> screen->DeleteItem( iref );
>> }
>> }
>> }
>> }
>> }
>>
>> As soon as I call DeleteItem (or RemoveFromScreen) I get a crash.
>> Is there something obvious I don't see ?
>>
>> I still need to get familiar with screens, sheets, frames, canvas, views
>>
>> Thanks in advance.
>>
>> Franck.
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp