Re: [Kicad-developers] DRC - detecting acute angles
Someone commented that teardrops are important for flexible PCBs. Maybe sharp angles also affect flex pcbs? And may be useful for people etching at home? As a hobbyist sending boards to be made at the cheapest fab I can find, it'd be nice not to have sharp angles just so I don't have to think about the issue, but my expertise re angles and corners is low. That last article you link to mentions "you can effectively ignore this problem unless you are working with a typical Chinese manufacturer". Josh On Mon, Jul 20, 2020 at 11:38 AM Andrew Zonenberg < azonenb...@drawersteak.com> wrote: > Hi, > > I guess the other question is, do we even *want* to be doing this check? > It's not the 1980s anymore. > > At the very least it should be able to be disabled for those of us who > aren't working with a PCB shop stuck in last century. > > > https://resources.ema-eda.com/blog/are-acid-traps-still-a-problem-for-pcbs-in-2019 > > > https://electronics.stackexchange.com/questions/115653/are-acid-traps-real-2014 > > https://resources.altium.com/p/7-common-misconceptions-about-pcb-design > > > https://www.nwengineeringllc.com/article/right-angle-pcb-traces-its-time-to-kill-the-myths.php > > Andrew > > On 7/20/20 8:29 AM, Tomasz Wlostowski wrote: > > On 18/07/2020 23:47, Joshua Redstone wrote: > >> Thanks, that link's a helpful starting point. > >> Josh > > > > Hi Joshua, > > > > If you could figure out the algorithm for robust acute angle detection > > (your input is a set of BOARD_ITEMs), I can integrate it with the new > > KiCad DRC engine. > > > > Tom > > > > > >> > >> On Fri, Jul 17, 2020 at 7:40 PM Seth Hillbrand >> <mailto:s...@kipro-pcb.com>> wrote: > >> > >> Please have a look over the open issues on GitLab. Until the new > >> DRC code has been merged into master, it's not a good candidate for > >> a new developer. > >> > >> Here's a link with open issues for the feature-freeze that have not > >> yet been assigned. Please do note that any feature-development work > >> should have a documented implementation plan that the lead > >> developers sign off on before you begin coding. This can help to > >> avoid problems where you do a lot of work that doesn't get accepted > >> because it doesn't fit in the larger plan. > >> > >> > https://gitlab.com/kicad/code/kicad/-/issues?scope=all&utf8=%E2%9C%93&state=opened&milestone_title=6.0%20Feature%20Freeze&assignee_id=None > >> > >> I would also strongly encourage you (as we do for all developers > >> starting to work on KiCad) to look at fixing small issues first. > >> They are not nearly as appealing as a feature implementation but > >> they are more manageable and will help you learn the general layout > >> and workings of the system. > >> > >> Best- > >> Seth > >> > >> KiCad Services Corporation KiCad Services Corporation Logo > >> Seth Hillbrand > >> *Lead Developer* > >> +1-530-302-5483 > >> Davis, CA > >> www.kipro-pcb.com <https://www.kipro-pcb.com/> > i...@kipro-pcb.com > >> <mailto:i...@kipro-pcb.com> > >> https://twitter.com/KiProEDA <https://twitter.com/KiProEDA> > >> https://www.linkedin.com/company/kicad > >> <https://www.linkedin.com/company/kicad> > >> > >> > >> On 2020-07-17 16:13, Joshua Redstone wrote: > >> > >>> Hi all, > >>> I was wondering what's the state of the pcbnew DRC work and what > >>> are the todos left to be done? > >>> I have a bit of time while waiting for a board to be assembled. I > >>> was thinking of exploring DRC changes to either detect acute > >>> angles in copper or detect silkscreen text that intersects vias / > >>> pads, but I'm also curious to know what else needs doing. > >>> Cheers, > >>> Josh > >>> > >>> > >>> ___ > >>> Mailing list: https://launchpad.net/~kicad-developers > >>> Post to : kicad-developers@lists.launchpad.net > >>> <mailto:kicad-developers@lists.launchpad.net> > >>> Unsubscribe : https://launchpad.net/~kicad-developers > >>> More help : https://help.launch
Re: [Kicad-developers] DRC - detecting acute angles
Hi Tom, Thanks for the suggestion - that sounds like a fun problem. But I just started working on named groups (after an email exchange with Seth). Cheers, Josh On Mon, Jul 20, 2020 at 11:29 AM Tomasz Wlostowski < tomasz.wlostow...@cern.ch> wrote: > On 18/07/2020 23:47, Joshua Redstone wrote: > > Thanks, that link's a helpful starting point. > > Josh > > Hi Joshua, > > If you could figure out the algorithm for robust acute angle detection > (your input is a set of BOARD_ITEMs), I can integrate it with the new > KiCad DRC engine. > > Tom > > > > > > On Fri, Jul 17, 2020 at 7:40 PM Seth Hillbrand > <mailto:s...@kipro-pcb.com>> wrote: > > > > Please have a look over the open issues on GitLab. Until the new > > DRC code has been merged into master, it's not a good candidate for > > a new developer. > > > > Here's a link with open issues for the feature-freeze that have not > > yet been assigned. Please do note that any feature-development work > > should have a documented implementation plan that the lead > > developers sign off on before you begin coding. This can help to > > avoid problems where you do a lot of work that doesn't get accepted > > because it doesn't fit in the larger plan. > > > > > https://gitlab.com/kicad/code/kicad/-/issues?scope=all&utf8=%E2%9C%93&state=opened&milestone_title=6.0%20Feature%20Freeze&assignee_id=None > > > > I would also strongly encourage you (as we do for all developers > > starting to work on KiCad) to look at fixing small issues first. > > They are not nearly as appealing as a feature implementation but > > they are more manageable and will help you learn the general layout > > and workings of the system. > > > > Best- > > Seth > > > > KiCad Services Corporation KiCad Services Corporation Logo > > Seth Hillbrand > > *Lead Developer* > > +1-530-302-5483 > > Davis, CA > > www.kipro-pcb.com <https://www.kipro-pcb.com/>i...@kipro-pcb.com > > <mailto:i...@kipro-pcb.com> > > https://twitter.com/KiProEDA <https://twitter.com/KiProEDA> > > https://www.linkedin.com/company/kicad > > <https://www.linkedin.com/company/kicad> > > > > > > On 2020-07-17 16:13, Joshua Redstone wrote: > > > >> Hi all, > >> I was wondering what's the state of the pcbnew DRC work and what > >> are the todos left to be done? > >> I have a bit of time while waiting for a board to be assembled. I > >> was thinking of exploring DRC changes to either detect acute > >> angles in copper or detect silkscreen text that intersects vias / > >> pads, but I'm also curious to know what else needs doing. > >> Cheers, > >> Josh > >> > >> > >> ___ > >> Mailing list: https://launchpad.net/~kicad-developers > >> Post to : kicad-developers@lists.launchpad.net > >> <mailto:kicad-developers@lists.launchpad.net> > >> Unsubscribe : https://launchpad.net/~kicad-developers > >> More help : https://help.launchpad.net/ListHelp > > ___ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : kicad-developers@lists.launchpad.net > > <mailto:kicad-developers@lists.launchpad.net> > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > > > > > > ___ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : kicad-developers@lists.launchpad.net > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > > > > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] DRC - detecting acute angles
Thanks, that link's a helpful starting point. Josh On Fri, Jul 17, 2020 at 7:40 PM Seth Hillbrand wrote: > Please have a look over the open issues on GitLab. Until the new DRC code > has been merged into master, it's not a good candidate for a new developer. > > Here's a link with open issues for the feature-freeze that have not yet > been assigned. Please do note that any feature-development work should > have a documented implementation plan that the lead developers sign off on > before you begin coding. This can help to avoid problems where you do a > lot of work that doesn't get accepted because it doesn't fit in the larger > plan. > > > https://gitlab.com/kicad/code/kicad/-/issues?scope=all&utf8=%E2%9C%93&state=opened&milestone_title=6.0%20Feature%20Freeze&assignee_id=None > > I would also strongly encourage you (as we do for all developers starting > to work on KiCad) to look at fixing small issues first. They are not > nearly as appealing as a feature implementation but they are more > manageable and will help you learn the general layout and workings of the > system. > > Best- > Seth > KiCad Services Corporation [image: KiCad Services Corporation Logo] > Seth Hillbrand > *Lead Developer* > +1-530-302-5483 <+12126039372> > Davis, CA > www.kipro-pcb.comi...@kipro-pcb.com > https://twitter.com/KiProEDA <https://twitter.com/KiProEDA> > https://www.linkedin.com/company/kicad > <https://www.linkedin.com/company/kicad> > > > On 2020-07-17 16:13, Joshua Redstone wrote: > > Hi all, > I was wondering what's the state of the pcbnew DRC work and what are the > todos left to be done? > I have a bit of time while waiting for a board to be assembled. I was > thinking of exploring DRC changes to either detect acute angles in copper > or detect silkscreen text that intersects vias / pads, but I'm also curious > to know what else needs doing. > Cheers, > Josh > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] DRC - detecting acute angles
Hi all, I was wondering what's the state of the pcbnew DRC work and what are the todos left to be done? I have a bit of time while waiting for a board to be assembled. I was thinking of exploring DRC changes to either detect acute angles in copper or detect silkscreen text that intersects vias / pads, but I'm also curious to know what else needs doing. Cheers, Josh ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Error creating merge request for 1st diff
Thanks Andrew and Jon - that helped me figure it out. I think I just successfully submitted my first merge request (# 282). -Josh On Mon, Jul 13, 2020 at 1:09 PM Jon Evans wrote: > Good point, Andrew. > > I normally have my fork as "origin" (which will be the default when > doing push/pull operations). > > I set the main KiCad repository as a remote called "upstream" (this > name is just my personal choice, it can be anything) > > That way by default I am just interacting with my fork, but I can > specify the upstream remote if I am rebasing my changes on top of the > latest in the main repository. > > Some more detail here on how to add, view and rename remotes: > > https://git-scm.com/book/en/v2/Git-Basics-Working-with-Remotes > > -Jon > > On Mon, Jul 13, 2020 at 12:58 PM Andrew Lutsenko > wrote: > > > > Hi, > > > > You are probably trying to push to kicad repo instead of your fork. > > Instead of doing "git push" you should do "git push corresponding to your fork>" unless your fork remote is "origin". > > Once you have pushed to your fork git client will give you a direct link > to create a merge request from that branch. > > > > Best, > > Andrew > > > > On Mon, Jul 13, 2020 at 9:25 AM Joshua Redstone > wrote: > >> > >> Hi, > >> I've prepared a diff for the raytracing engine in 3d-viewer. It more > conservatively clips silkscreen around vias to the edge of the outer > annular ring rather than edge of the copper plating. > >> I wanted to get some feedback on it, but when I tried creating a merge > request by doing a git-push, I got the "You are not allowed to push code to > this project." error. > >> > >> Is there another way I should proceed to get feedback on the diff? > >> One question on the diff I had was I wasn't sure where / if / how to > hook up the flag enabling the change. > >> > >> Thanks, > >> Josh > >> > >> ___ > >> Mailing list: https://launchpad.net/~kicad-developers > >> Post to : kicad-developers@lists.launchpad.net > >> Unsubscribe : https://launchpad.net/~kicad-developers > >> More help : https://help.launchpad.net/ListHelp > > > > ___ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : kicad-developers@lists.launchpad.net > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] Error creating merge request for 1st diff
Hi, I've prepared a diff for the raytracing engine in 3d-viewer. It more conservatively clips silkscreen around vias to the edge of the outer annular ring rather than edge of the copper plating. I wanted to get some feedback on it, but when I tried creating a merge request by doing a git-push, I got the "You are not allowed to push code to this project." error. Is there another way I should proceed to get feedback on the diff? One question on the diff I had was I wasn't sure where / if / how to hook up the flag enabling the change. Thanks, Josh ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] 3d-viewer: via diameter calculation off?
Ah, ok. Thanks, Jeff and Seth. At least I'm reading the code correctly. Josh On Wed, Jul 8, 2020 at 6:04 PM Jeff Young wrote: > Our usage of “drill” in the terminology is pretty misleading. As far as > I’m aware the vast majority of board houses treat it as “finish hole” > diameter. > > Cheers, > Jeff. > > > On 8 Jul 2020, at 23:00, Seth Hillbrand wrote: > > That really depends on the manufacturer. Many manufacturers will > overdrill and expand the size of their bits to account for the plating. If > you are thinking of making a change like this, it would need to be an > optional preference. > > Best- > Seth > KiCad Services Corporation [image: KiCad Services Corporation Logo] > Seth Hillbrand > *Lead Developer* > +1-530-302-5483 <+12126039372> > Davis, CA > www.kipro-pcb.comi...@kipro-pcb.com > https://twitter.com/KiProEDA <https://twitter.com/KiProEDA> > https://www.linkedin.com/company/kicad > <https://www.linkedin.com/company/kicad> > > > On 2020-07-08 14:47, Joshua Redstone wrote: > > Hi, > I'm a bit new to pcbs and Kicad, but I thought that the effective diameter > of a through-hole is the drill diameter minus copper plating thickness > (since plating is done after drilling). > In the 3d-viewer code, it looks like it's increasing the drill diameter to > account for the plating so the plated hole is the drill diameter rather > than the unplated hole, which seems odd. > > I was thinking of doing a diff to fix that, but wanted to check if I'm > reading the code correctly. > Specifically, in 3d-viewer/3d_canvas/create_layer_items.cpp > the calculation of a hole's inner diameter is (hole_inner_radius) rather > than (hole_inner_radius - [plating_]thickness). And there's a > corresponding offset in the calc of the outer diameter. > > An example: > https://gitlab.com/kicad/code/kicad/-/blob/master/3d-viewer/3d_canvas/create_layer_items.cpp#L306 > > I played around with rendering some test circuits and confirmed that the > rendering seems to be producing holes that are too big. > > Am I reading this right? > > Thanks, > Josh > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > > > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] 3d-viewer: via diameter calculation off?
Hi, I'm a bit new to pcbs and Kicad, but I thought that the effective diameter of a through-hole is the drill diameter minus copper plating thickness (since plating is done after drilling). In the 3d-viewer code, it looks like it's increasing the drill diameter to account for the plating so the plated hole is the drill diameter rather than the unplated hole, which seems odd. I was thinking of doing a diff to fix that, but wanted to check if I'm reading the code correctly. Specifically, in 3d-viewer/3d_canvas/create_layer_items.cpp the calculation of a hole's inner diameter is (hole_inner_radius) rather than (hole_inner_radius - [plating_]thickness). And there's a corresponding offset in the calc of the outer diameter. An example: https://gitlab.com/kicad/code/kicad/-/blob/master/3d-viewer/3d_canvas/create_layer_items.cpp#L306 I played around with rendering some test circuits and confirmed that the rendering seems to be producing holes that are too big. Am I reading this right? Thanks, Josh ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] Improve detection of silkscreen over vias
Hi, I was thinking of looking into making KiCad better at alerting when silkscreen markings are over a via (since it won't show up when fab'd), and was wondering where might be a good place to start. I also heard from one fab to not silkscreen over annular rings, so was thinking of adding a config option to filter those intersections out as well. Some options, perhaps in increasing order of difficulty: 1. Add an option to the raytracer to clip silkscreen over annular rings (it already can filter out silkscreen over vias). 2. Improve the OpenGL renderer to clip text over vias & annular rings. 3. Add a DRC check to detect silkscreen intersecting vias / annular rings. Any thoughts or recommendations? -Josh ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
