Re: [Kicad-developers] Why has my name been removed from the translators-Other credits?
Done. -Mikolaj ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Why has my name been removed from the translators-Other credits?
David, I've restored the Translator-Other section, along with your name, in 6.0 and master branches. It shouldn't have been removed in the first place. Unfortunately indeed this will only appear in stable versions once 6.0.1 is out. Sorry about that. -Mikolaj ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] New lead developer announcement
Thank you! Thanks for the badge Chris. I would have never expected that someone will compliment my avatar. :) -Mikolaj ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Help needed to configure gdb
KiCad loads symbols dynamically on runtime. So Gdb may not see them until KiCad starts running. Setting breakpoints works for me if I reply "y" to the "Make breakpoint pending on future shared library load? (y or [n])" prompt when the source file is not found. Gdb should also be able to find the source file if you set the breakpoint after running then interrupting KiCad. Best, Mikołaj On Wed, Jul 7, 2021 at 3:49 PM pradeepa.kck wrote: > Thanks Jon. I tried that and in that case gdb launched kicad, but it > couldn't find the source file to set a breakpoint. > > If someone can give me an example of setting the breakpoint that would be > great. I tried relative path and full path, but still couldn't set the > breakpoint in copper_zone_dialog.cpp. > > - Pradeepa > > Sent on the go with Vodafone > > > Original message > From: Jon Evans > Date: 7/7/21 11:28 pm (GMT+10:00) > To: Pradeepa Senanayake > Cc: KiCad Developers > Subject: Re: [Kicad-developers] Help needed to configure gdb > > gdb ./kicad/kicad is starting KiCad from the build directory. > > This isn't a fully-supported way of debugging KiCad, but if you want to do > this, you must set the environment variable > > KICAD_RUN_FROM_BUILD_DIR=1 > > Alternatively, since you are running `make install` above, you can use gdb > to debug KiCad at the installed location, rather than inside the build > directory. > > This will probably be a more reliable mechanism. > > -Jon > > On Wed, Jul 7, 2021 at 9:24 AM Pradeepa Senanayake > wrote: > >> Hello All, >> >> Sorry for the long mail. >> >> I'm trying to debug one of my changes using gdb and I've run into a >> roadblock. >> >> This is what I did so far, >> >> >> Built KiCAD using following commands >> >> cmake -DCMAKE_BUILD_TYPE=Debug >> -G "MSYS Makefiles" >> -DCMAKE_PREFIX_PATH=/mingw64 >>-DCMAKE_INSTALL_PREFIX=/mingw64 >>-DDEFAULT_INSTALL_PATH=/mingw64 >>-DOCC_INCLUDE_DIR=/mingw64/include/opencascade >>-DPYTHON_INCLUDE_DIR=/mingw64/include/python3.8 >>../../ >> make -j 4 install >> >> >> Started gdb using the following command >> >> $: gdb ./kicad/kicad >> >> ... >> ... >> Reading symbols from ./kicad/kicad.exe... >> (gdb) run >> Starting program: >> I:\msys64\home\Pradeepa\kicad-source\build\debug\kicad\kicad.exe >> [New Thread 16296.0x41b0] >> [New Thread 16296.0x3e0c] >> [New Thread 16296.0x2130] >> Python path configuration: >> PYTHONHOME = (not set) >> PYTHONPATH = (not set) >> program name = 'python3' >> isolated = 0 >> environment = 1 >> user site = 1 >> import site = 1 >> sys._base_executable = >> 'I:/msys64/home/Pradeepa/kicad-source/build/debug/kicad/kicad.exe' >> sys.base_prefix = 'D:/a/_temp/msys/msys64/mingw64' >> sys.base_exec_prefix = 'D:/a/_temp/msys/msys64/mingw64' >> sys.executable = >> 'I:/msys64/home/Pradeepa/kicad-source/build/debug/kicad/kicad.exe' >> sys.prefix = 'D:/a/_temp/msys/msys64/mingw64' >> sys.exec_prefix = 'D:/a/_temp/msys/msys64/mingw64' >> sys.path = [ >> 'D:/a/_temp/msys/msys64/mingw64/lib/python38.zip', >> 'D:/a/_temp/msys/msys64/mingw64/lib/python3.8', >> 'D:/a/_temp/msys/msys64/mingw64/lib/python3.8', >> 'D:/a/_temp/msys/msys64/mingw64/lib/lib-dynload', >> ] >> Could not find platform independent libraries >> Could not find platform dependent libraries >> Consider setting $PYTHONHOME to [:] >> Fatal Python error: init_fs_encoding: failed to get the Python codec of >> the filesystem encoding >> Python runtime state: core initialized >> ModuleNotFoundError: No module named 'encodings' >> >> Current thread 0x3154 (most recent call first): >> >> warning: Fatal Python error: >> warning: failed to get the Python codec of the filesystem encoding >> warning: >> [Thread 16296.0x3e0c exited with code 1] >> [Thread 16296.0x2130 exited with code 1] >> [Thread 16296.0x41b0 exited with code 1] >> [Inferior 1 (process 16296) exited with code 01] >> (gdb) >> >> I've set the PYTHONHOME to /mingw64 >> >> Now I can launch KiCad in gdb. However, it now gives many errors, >> >> Ex: can't open file >> I:\msys64\home\Pradeepa\kicad-source\build\debug\share\kicad\resources\images.tar.gz >> >> I feel that it's something to do with paths, however, it's hard to figure >> out without knowing how everything fits together. >> >> Can someone please give me a hand? >> >> Thanks! >> Best Regards, >> Pradeepa Senanayake. >> ___ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp >
[Kicad-developers] Merge request: add "Select All" in schematic & layout disambiguation popup menu
Hi, Could anyone please take a look on my merge request below? https://gitlab.com/kicad/code/kicad/-/merge_requests/155 There hasn't been any response for 3 weeks since I submitted a revised version. I think this is ready to be merged. Best regards, Mikołaj Wielgus ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Project manager: Recurse into dirs added via fs watcher handlers
I'm unable to submit a merge request, probably because I'm not a member of the KiCad Gitlab group. I've submitted an access request. FYI kicad-pcb.org says that patches are submitted through the mailing list (or alternatively through Launchpad), and I followed that. Perhaps an update is needed? Best regards, Mikołaj Wielgus On Fri, Dec 20, 2019 at 2:01 AM Seth Hillbrand wrote: > On 2019-12-19 16:47, Mikołaj Wielgus wrote: > > > I'm attaching a new version of this patch, which fixes this problem on > > my 64-bit Debian build under VM. > > > > The thread related to this bug can be found here: > > https://gitlab.com/kicad/code/kicad/issues/1945 > > > > Best regards, > > Mikołaj Wielgus > > > https://webmail.eu.com/roundcube/?_task=mail&_action=compose&_id=7477704365dfc1d35268c4# > > On Sun, Nov 17, 2019 at 4:58 PM Mikołaj Wielgus > > wrote: > > > >> Hi, > >> > >> In order for the newly created directory'scontents to be shown, the > >> directory itself has to be marked as populated. Directories may be > >> copied along with all of their contents, so it shouldn't be assumed > >> that they are empty. > >> > >> Best regards, > >> Mikołaj Wielgus > > > > Hi Mikołaj- > > Would you mind submitting this as a merge request on GitLab? We are > using the CI/CD tools there to help speed the patch approval process. > > Best- > Seth > > Seth Hillbrand > KiCad Services Corporation > https://www.kipro-pcb.com > +1 530 302 5483 | +1 212 603 9372 > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Project manager: Recurse into dirs added via fs watcher handlers
I'm attaching a new version of this patch, which fixes this problem on my 64-bit Debian build under VM. The thread related to this bug can be found here: https://gitlab.com/kicad/code/kicad/issues/1945 Best regards, Mikołaj Wielgus On Sun, Nov 17, 2019 at 4:58 PM Mikołaj Wielgus wrote: > Hi, > > In order for the newly created directory'scontents to be shown, the > directory itself has to be marked as populated. Directories may be copied > along with all of their contents, so it shouldn't be assumed that they are > empty. > > Best regards, > Mikołaj Wielgus > 0001-Project-manager-fix-files-in-nested-dir-not-being-ad.patch Description: Binary data ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] [PATCH] Project manager: Recurse into dirs added via fs watcher handlers
Hi, In order for the newly created directory'scontents to be shown, the directory itself has to be marked as populated. Directories may be copied along with all of their contents, so it shouldn't be assumed that they are empty. Best regards, Mikołaj Wielgus 0001-Recurse-into-dirs-added-via-fs-watcher-handlers.patch Description: Binary data ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Kicad: project manager: Do not reconstruct entire project tree when renaming file to different dir
Ian, Your patch is working, the new node is selected after rename as it is expected now. While testing your patch I found yet another bug in the project manager (most likely unrelated to this patch), I'll report it later. Thank you for your kind words. Best regards, Mikołaj Wielgus On Sun, Nov 17, 2019 at 2:13 AM Ian McInerney wrote: > Ok, I have pushed the fixes for the rename tree update, and an attempt to > fix the item selection after rename. Since Gtk uses the rename event, I > can't test the add code path easily (it is probably time I actually tried > to set up my mac and Windows build environments). It would be good to > verify that code path on Windows and mac now (the GTK path works). > > Mikołaj, thanks for pointing this out, helping to track down the problem, > and testing. It really helped! > > -Ian > > On Sat, 16 Nov 2019, 21:01 Mikołaj Wielgus, > wrote: > >> I've tested Ian's patch on Windows 10 and it works correctly for me, with >> exception to the same selection problem, as well. >> >> I've done simple logging and found out that the rename event routine is >> not executed during rename, but the delete and create event routines are, >> in this order. >> >> Interestingly, the wxWidgets v3.0.4 reference manual states: >> "Implementation limitations: this class is currently implemented for MSW, >> OS X and GTK ports but doesn't detect all changes correctly everywhere: >> under MSW accessing the file is not detected (only modifying it is) and >> under OS X neither accessing nor modifying is detected (only creating and >> deleting files is). Moreover, OS X version doesn't currently collapse pairs >> of create/delete events in a rename event, unlike the other ones.". >> >> The phrase "unlike the other ones" means that the Windows port should >> collapse create/delete events into a rename event, which is not the case on >> my build. >> >> Best regards, >> Mikołaj Wielgus >> >> >> On Sat, Nov 16, 2019 at 5:21 PM Ian McInerney >> wrote: >> >>> Thanks for testing. I had noticed the selection issue on GTK as well, so >>> I will fix it up before I push it. >>> >>> The file system watcher is a finiky creature. GTK for sure uses the >>> rename events (I traced those through the logic last night), but according >>> to the docs ( >>> https://docs.wxwidgets.org/3.1/classwx_file_system_watcher.html) OSX >>> can't create a rename event, so we get a delete and create event >>> separately. The selection issue is easy to fix in the rename event, since I >>> just need to select the new item there. It is slightly more difficult for >>> OSX though, since we don't always want to have a newly create file be >>> selected. I can probably work around it though. >>> >>> I will let you know when I push the change so you can test it. >>> >>> -Ian >>> >>> On Sat, 16 Nov 2019, 2:24 p.m. Jeff Young, wrote: >>> >>>> How bizarre. Make you wonder how it worked on Mac and Windows. (Hmmm… >>>> I wonder if GTK goes through wxFSW_EVENT_RENAME and Mac and Windows go >>>> through wxFSW_EVENT_DELETE and wxFSW_EVENT_CREATE?) >>>> >>>> Your patch works on OSX except for one thing: it doesn’t get the >>>> selection right (selecting the next item in the moved-from location rather >>>> than keeping the moved item selected). >>>> >>>> Cheers, >>>> Jeff. >>>> >>>> >>>> On 16 Nov 2019, at 01:57, Ian McInerney >>>> wrote: >>>> >>>> Ok, so I dug into this some more and first of all, the changes that >>>> Jeff pushed still didn't work on GTK. >>>> >>>> The root cause of this doesn't appear to be our file system watcher, >>>> but was instead the fact that the tree was being improperly updated. First >>>> of all, we were renaming the old node with the new filename which was >>>> causing the deletion routine in the rename fswatcher handler to never find >>>> it and remove it. Second of all, we were adding the new file into the same >>>> directory as the original file, so it was looking like it was never >>>> leaving. >>>> >>>> I believe these two patches address the issues, and they work on my GTK >>>> box for both a rename moving directories and a rename inside the same >>>> directory. The first set just reverts the changes that Jeff made to the >>>> code to get it back to the state it
Re: [Kicad-developers] [PATCH] Kicad: project manager: Do not reconstruct entire project tree when renaming file to different dir
I've tested Ian's patch on Windows 10 and it works correctly for me, with exception to the same selection problem, as well. I've done simple logging and found out that the rename event routine is not executed during rename, but the delete and create event routines are, in this order. Interestingly, the wxWidgets v3.0.4 reference manual states: "Implementation limitations: this class is currently implemented for MSW, OS X and GTK ports but doesn't detect all changes correctly everywhere: under MSW accessing the file is not detected (only modifying it is) and under OS X neither accessing nor modifying is detected (only creating and deleting files is). Moreover, OS X version doesn't currently collapse pairs of create/delete events in a rename event, unlike the other ones.". The phrase "unlike the other ones" means that the Windows port should collapse create/delete events into a rename event, which is not the case on my build. Best regards, Mikołaj Wielgus On Sat, Nov 16, 2019 at 5:21 PM Ian McInerney wrote: > Thanks for testing. I had noticed the selection issue on GTK as well, so I > will fix it up before I push it. > > The file system watcher is a finiky creature. GTK for sure uses the rename > events (I traced those through the logic last night), but according to the > docs (https://docs.wxwidgets.org/3.1/classwx_file_system_watcher.html) > OSX can't create a rename event, so we get a delete and create event > separately. The selection issue is easy to fix in the rename event, since I > just need to select the new item there. It is slightly more difficult for > OSX though, since we don't always want to have a newly create file be > selected. I can probably work around it though. > > I will let you know when I push the change so you can test it. > > -Ian > > On Sat, 16 Nov 2019, 2:24 p.m. Jeff Young, wrote: > >> How bizarre. Make you wonder how it worked on Mac and Windows. (Hmmm… I >> wonder if GTK goes through wxFSW_EVENT_RENAME and Mac and Windows go >> through wxFSW_EVENT_DELETE and wxFSW_EVENT_CREATE?) >> >> Your patch works on OSX except for one thing: it doesn’t get the >> selection right (selecting the next item in the moved-from location rather >> than keeping the moved item selected). >> >> Cheers, >> Jeff. >> >> >> On 16 Nov 2019, at 01:57, Ian McInerney wrote: >> >> Ok, so I dug into this some more and first of all, the changes that Jeff >> pushed still didn't work on GTK. >> >> The root cause of this doesn't appear to be our file system watcher, but >> was instead the fact that the tree was being improperly updated. First of >> all, we were renaming the old node with the new filename which was causing >> the deletion routine in the rename fswatcher handler to never find it and >> remove it. Second of all, we were adding the new file into the same >> directory as the original file, so it was looking like it was never leaving. >> >> I believe these two patches address the issues, and they work on my GTK >> box for both a rename moving directories and a rename inside the same >> directory. The first set just reverts the changes that Jeff made to the >> code to get it back to the state it was originally, and the second is the >> actual new changeset. @Jeff and @Mikolaj, if you could both test these >> changes on Windows and OSX to see how they behave that would be good. If >> they work for both of you I will push them. >> >> -Ian >> >> On Sat, Nov 16, 2019 at 1:00 AM Mikołaj Wielgus >> wrote: >> >>> Jeff, >>> >>> your new version appears to be working well on my computer on Windows. >>> >>> Best regards, >>> Mikołaj Wielgus >>> >>> >>> On Sat, Nov 16, 2019 at 1:02 AM Jeff Young wrote: >>> >>>> I pushed a smarter version of my original fix. @Mikolaj & @Ian if you >>>> could test it on Windows and GTK that would be great. >>>> >>>> Cheers, >>>> Jeff. >>>> >>>> >>>> On 15 Nov 2019, at 22:27, Ian McInerney >>>> wrote: >>>> >>>> Scratch my last. It is GTK with the problems. When I rename the file to >>>> a new directory with this patch, the tree never seems to update. I have to >>>> manually refresh it in order for the file to appear in the correct place. >>>> >>>> -Ian >>>> >>>> On Fri, Nov 15, 2019 at 10:21 PM Mikołaj Wielgus < >>>> wielgusmiko...@gmail.com> wrote: >>>> >>>>> Yes, I'm on Windows (the details are in the linked related bug report). >>
Re: [Kicad-developers] [PATCH] Kicad: project manager: Do not reconstruct entire project tree when renaming file to different dir
Jeff, your new version appears to be working well on my computer on Windows. Best regards, Mikołaj Wielgus On Sat, Nov 16, 2019 at 1:02 AM Jeff Young wrote: > I pushed a smarter version of my original fix. @Mikolaj & @Ian if you > could test it on Windows and GTK that would be great. > > Cheers, > Jeff. > > > On 15 Nov 2019, at 22:27, Ian McInerney wrote: > > Scratch my last. It is GTK with the problems. When I rename the file to a > new directory with this patch, the tree never seems to update. I have to > manually refresh it in order for the file to appear in the correct place. > > -Ian > > On Fri, Nov 15, 2019 at 10:21 PM Mikołaj Wielgus > wrote: > >> Yes, I'm on Windows (the details are in the linked related bug report). >> >> Sorry for the return value problem -- I failed to notice the warnings in >> console. >> >> Best regards, >> Mikołaj Wielgus >> >> >> On Fri, Nov 15, 2019 at 11:07 PM Ian McInerney >> wrote: >> >>> I'll give it a test on GTK once my build here finishes, but I don't >>> think I have seen any issues with file watcher on GTK in the past. >>> >>> -Ian >>> >>> On Fri, Nov 15, 2019 at 10:03 PM Jeff Young wrote: >>> >>>> Hi Mikolaj, >>>> >>>> The Mac compiler doesn’t like Rename() returning values when the return >>>> type is void. However, after fixing that it works fine on Mac. >>>> >>>> I remember however something about the file watcher not working on all >>>> platforms. I thought the problem platform was Windows, though, so maybe >>>> I’m not remembering it correctly (as you’re on Windows, right?). >>>> >>>> Can someone validate that this works on GTK? >>>> >>>> Cheers, >>>> Jeff. >>>> >>>> >>>> On 15 Nov 2019, at 21:05, Mikołaj Wielgus >>>> wrote: >>>> >>>> Hi, >>>> >>>> Renaming file to a different directory causes the entire project tree >>>> to be recreated, which causes all subdirectories to collapse, unexpectedly >>>> to the user. >>>> >>>> This patch solves the problem by deleting the original node after >>>> moving the file. Then the file watcher raises an event whose handler >>>> constructs a new node in the new location. >>>> >>>> This issue comes from the fix to this bug: >>>> https://bugs.launchpad.net/kicad/+bug/1852431 >>>> >>>> Best Regards, >>>> Mikołaj Wielgus >>>> <0001-Do-not-reconstruct-proj-tree-on-rename-to-diff-dir.patch> >>>> ___ >>>> Mailing list: https://launchpad.net/~kicad-developers >>>> Post to : kicad-developers@lists.launchpad.net >>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>> More help : https://help.launchpad.net/ListHelp >>>> >>>> >>>> ___ >>>> Mailing list: https://launchpad.net/~kicad-developers >>>> Post to : kicad-developers@lists.launchpad.net >>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>> More help : https://help.launchpad.net/ListHelp >>>> >>> > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Pcbnew drill sizes statistics & Project manager multiple selection options
- Project manager multiple selection options: It appears that implementing these enchancements would require significant changes to the project manager code, since much of the actions is implemented in TREEPROJECT_ITEM class itself, hence a significant portion of the actions implementation would have to be placed somewhere else (most likely to TREE_PROJECT_FRAME class). In addition, KICAD_MANAGER_CONTROL::Execute would have to be modified to allow passing several arguments. Since I'm not very experienced with the codebase yet, and these issues are minor, and implementing them can potentially cause a lot of issues, I would like to request pulling the patch as it currently is for the time being. This will make it easier for me to implement these features later (in the next patch). Best regards, Mikołaj Wielgus On Mon, Nov 11, 2019 at 12:01 PM Ian McInerney wrote: > Thanks for this. Note though that when passing the functions into the > Connect method in wxWidgets, you should specify the fully qualified name > (including the class) of the function. When this is not specified, a build > error happens on my wxWidgets 3.0.4 Linux build. I have pushed a fix for > this to master. > > -Ian > > On Mon, Nov 11, 2019 at 8:37 AM jp charras wrote: > >> Le 11/11/2019 à 01:04, Mikołaj Wielgus a écrit : >> > - Pcbnew drill sizes statistics: >> > I've modified the filter and also made the last two columns expand to >> > fit the remaining space during grid creation and window resizing. >> > >> > As for the column sizes: they are assigned with the wxGrid::AutoSize() >> > method built-into WxWidgets. Because of that, I'm reluctant to add any >> > arbitrary values to the column sizes. Also, it's not uncommon for column >> > widths to be partially concealed in GUI applications (they sometimes >> > take a lot more space than the table values themselves). The grid is >> > resizable, so if the user wants to check the label, they will be able to >> > resize it easily. >> > >> > Furthermore, on my operating system, I don't have my column labels >> > concealed when sorted. >> > >> > Because of this, I think it will be better if you tweak the column >> > widths yourself to make them work as desired in your environment (if you >> > aren't convinced by my argument). This can be done easily by iterating >> > over all columns and adding a constant to each one's width right after >> > the m_gridDrills->AutoSize(); line. >> > >> > Please let me know if you have any better idea how to address this. >> > >> > Best Regards, >> > Mikołaj Wielgus >> > >> >> Hi Mikołaj, >> >> Thanks for your contribution. >> >> I committed your patch (with a minor change to avoid a wxWidgets alert). >> >> AFAIK, we always have some issues with column sizing in wxGrid >> (depending on the platform and wxWidgets version) >> >> In this case, this sizing problem is a minor issue. >> >> > >> > On Thu, Nov 7, 2019 at 3:37 PM jp charras > > <mailto:jp.char...@wanadoo.fr>> wrote: >> > >> > Le 06/11/2019 à 23:18, Mikołaj Wielgus a écrit : >> > > Hello, >> > > >> > > I have submitted two patches on Launchpad some time ago. I would >> > like to >> > > ask for feedback. >> > > >> > > Links: >> > > https://bugs.launchpad.net/kicad/+bug/1841144 >> > > https://bugs.launchpad.net/kicad/+bug/1016464 >> > > >> > > Best Regards, >> > > Mikołaj Wielgus >> > >> > Hi Mikołaj, >> > >> > First, thanks for your contribution. >> > >> > I had a look into your patches. >> > >> > I do not seen big problems, but I suggest a few enhancements: >> > - Project manager multiple selection options: >> > When deleting a list of files, a confirmation is asked for each >> file. >> > Only one confirmation is enough. >> > When deleting a list of files, a instance of the editor is opened >> for >> > each file. >> > All editors are able to open more than one file, so I suggest only >> one >> > instance of the editor opening all files. >> > >> > - Pcbnew drill sizes statistics: >> > It display pads with no holes. The filter to select pads: >> > if( pad->GetAttribute() != PAD_ATTRIB_SMD ) >> > is incorrect >> > (other pads can have no hole). >>
Re: [Kicad-developers] [PATCH] Kicad: project manager: Do not reconstruct entire project tree when renaming file to different dir
Yes, I'm on Windows (the details are in the linked related bug report). Sorry for the return value problem -- I failed to notice the warnings in console. Best regards, Mikołaj Wielgus On Fri, Nov 15, 2019 at 11:07 PM Ian McInerney wrote: > I'll give it a test on GTK once my build here finishes, but I don't think > I have seen any issues with file watcher on GTK in the past. > > -Ian > > On Fri, Nov 15, 2019 at 10:03 PM Jeff Young wrote: > >> Hi Mikolaj, >> >> The Mac compiler doesn’t like Rename() returning values when the return >> type is void. However, after fixing that it works fine on Mac. >> >> I remember however something about the file watcher not working on all >> platforms. I thought the problem platform was Windows, though, so maybe >> I’m not remembering it correctly (as you’re on Windows, right?). >> >> Can someone validate that this works on GTK? >> >> Cheers, >> Jeff. >> >> >> On 15 Nov 2019, at 21:05, Mikołaj Wielgus >> wrote: >> >> Hi, >> >> Renaming file to a different directory causes the entire project tree to >> be recreated, which causes all subdirectories to collapse, unexpectedly to >> the user. >> >> This patch solves the problem by deleting the original node after moving >> the file. Then the file watcher raises an event whose handler constructs a >> new node in the new location. >> >> This issue comes from the fix to this bug: >> https://bugs.launchpad.net/kicad/+bug/1852431 >> >> Best Regards, >> Mikołaj Wielgus >> <0001-Do-not-reconstruct-proj-tree-on-rename-to-diff-dir.patch> >> ___ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> >> >> ___ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] [PATCH] Kicad: project manager: Do not reconstruct entire project tree when renaming file to different dir
Hi, Renaming file to a different directory causes the entire project tree to be recreated, which causes all subdirectories to collapse, unexpectedly to the user. This patch solves the problem by deleting the original node after moving the file. Then the file watcher raises an event whose handler constructs a new node in the new location. This issue comes from the fix to this bug: https://bugs.launchpad.net/kicad/+bug/1852431 Best Regards, Mikołaj Wielgus 0001-Do-not-reconstruct-proj-tree-on-rename-to-diff-dir.patch Description: Binary data ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] [PATCH] Pcbnew drill sizes statistics & Project manager multiple selection options
Hello, I have submitted two patches on Launchpad some time ago. I would like to ask for feedback. Links: https://bugs.launchpad.net/kicad/+bug/1841144 https://bugs.launchpad.net/kicad/+bug/1016464 Best Regards, Mikołaj Wielgus ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
