Re: [Kicad-developers] /include/xnode.h giving warnings

[Alexander Lunev]

In line 121. I'm sorry, I had too little sleep last night.



 From: Alexander Lunev 
To: KiCad Developers  
Sent: Thursday, June 13, 2013 12:46 PM
Subject: Re: [Kicad-developers] /include/xnode.h giving warnings
 


Yes, it's my fault.
Would somebody with a write access add 'return' in line 118 of xnode.h?

Best regards,
Alexander



 From: Edwin van den Oetelaar 
To: KiCad Developers  
Sent: Thursday, June 13, 2013 11:28 AM
Subject: [Kicad-developers] /include/xnode.h giving warnings
 

I am still on Wx 2.8 and building gave me lots of warnings about no
return() from non void function.
Possible fix here.

Greetings,
Edwin van den Oetelaar


bzr diff include/
=== modified file 'include/xnode.h'
--- include/xnode.h 2013-06-12 19:43:22 +
+++ include/xnode.h 2013-06-13 07:25:23 +
@@ -118,7 +118,7 @@
     }
     bool DeleteAttribute( const wxString& attrName )
     {
-        DeleteProperty( attrName );
+        return DeleteProperty( attrName );
     }
     wxXmlProperty* GetAttributes() const
     {

___
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



___
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] /include/xnode.h giving warnings

[Alexander Lunev]

Yes, it's my fault.
Would somebody with a write access add 'return' in line 118 of xnode.h?

Best regards,
Alexander



 From: Edwin van den Oetelaar 
To: KiCad Developers  
Sent: Thursday, June 13, 2013 11:28 AM
Subject: [Kicad-developers] /include/xnode.h giving warnings
 

I am still on Wx 2.8 and building gave me lots of warnings about no
return() from non void function.
Possible fix here.

Greetings,
Edwin van den Oetelaar


bzr diff include/
=== modified file 'include/xnode.h'
--- include/xnode.h 2013-06-12 19:43:22 +
+++ include/xnode.h 2013-06-13 07:25:23 +
@@ -118,7 +118,7 @@
     }
     bool DeleteAttribute( const wxString& attrName )
     {
-        DeleteProperty( attrName );
+        return DeleteProperty( attrName );
     }
     wxXmlProperty* GetAttributes() const
     {

___
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] /include/xnode.h giving warnings

[Edwin van den Oetelaar]

I am still on Wx 2.8 and building gave me lots of warnings about no
return() from non void function.
Possible fix here.

Greetings,
Edwin van den Oetelaar


bzr diff include/
=== modified file 'include/xnode.h'
--- include/xnode.h 2013-06-12 19:43:22 +
+++ include/xnode.h 2013-06-13 07:25:23 +
@@ -118,7 +118,7 @@
 }
 bool DeleteAttribute( const wxString& attrName )
 {
-DeleteProperty( attrName );
+return DeleteProperty( attrName );
 }
 wxXmlProperty* GetAttributes() const
 {

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp