Re: [Kicad-developers] [FEATURE] Component table viewer

[Oliver Walters]

Thanks for the positive feedback everyone.

I have a couple of further improvements planned (but not much time atm).

A) left alignment of text (I agree)

B) ability to open footprint selector (perhaps using right-click context
menu). If someone with better knowledge of Kiway wants to do this one,
great.

C) Data filtering - ability to filter per row

D) context menu to quickly hide column, etc

Oliver


On 12 May 2017 20:50, "Clemens Koller"  wrote:

I am impressed!

This seems to be the first step towards what is called "Table Based Design
Entry" in some other tools.
The next step towards that would be to allow editing of pins and netnames
of the components (which are arranged in a hierarchical tree view).
And - the tricky part - update the visual representation of the connections
in the schematics (updating netnames of existing connections and by adding
netnames/labels to pins for new connections).

Thank you for your great work!

Clemens

On 2017-05-12 10:23, Steven Johnson wrote:
> To answer 3. Its a component field editor/viewer.  It allows you to
edit/view your component fields much easier than right clicking on each and
every symbol to see what the fields are set to.
>
> Its not really a BoM tool although it makes getting your BoM in order
much easier.
>
> For example a 10K resistor doesnt necessarily specify the
manufacturer/part number like a BoM would need to, although it can.  How
you use the fields is up to you the designer.
>
>
> On May 12, 2017 15:16, "Fabrizio Tappero" mailto:fabrizio.tapp...@gmail.com>> wrote:
>
> Hello,
> great work! this is a good BOM preview, but I am not really sure why
the BOM icon does not activate this table (like in Altium).
> I have done some testing and this is my feedback.
> 1) left alignment is advisable.  The current center alignment makes
the table hard to read.
> 2) for a reason I do not know, the current version (today nightly
built) has problem to group the "Description" field. Very strange
> 3) What exactly is this table? a "Generate quick BOM"? The current
pop up hint text says "Component table view" which I guess is incorrect
since you can edit fields. This would help me to make a better icon?
>
> Inline image 1
>
> Really great work. I love this new feature.
>
> cheers
> Fabrizio
>
>
> On Sat, May 6, 2017 at 7:28 AM, Strontium mailto:strnty...@gmail.com>> wrote:
>
> Hi Oliver,
>
> On 06/05/17 12:13, Oliver Walters wrote:
>>
>> And it just so happens that in this schematic NO components
have been edited to include these default fields/values, so, they don't
show up in the component table.
>>
>>
>> I have a patch to fix this now - if a field is empty and a
template value exists, that is placed there instead.
>>
>>
>> Also, editing Multipart components is a little quirky, If
you change a field for a multi-part component, all "parts" update to that
value, but if any parts have different values, only one is shown in the
table and its not clear that the underlying multipart field is inconsistent.
>>
>>
>> This is a hard one as really, multi-part components should /not/
have different values in various fields! I had thought about adding another
level (with an arrow as you suggest) but I think it becomes too complicated.
> Yes, I agree with you on this, Its confusing that KiCad doesn't
synchronise those fields.  BUT I think maybe its done that way to help
facilitate swapping parts between multiple multi-part components.
>
> Maybe a developer who knows more about this can weigh in?  Is
having different field value/fields in a single multi-part component a
"Feature" or a "Quirk"?  And if a "Feature" what's its purpose?
>
> Steven
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers <
https://launchpad.net/~kicad-developers>
> Post to : kicad-developers@lists.launchpad.net 
> Unsubscribe : https://launchpad.net/~kicad-developers <
https://launchpad.net/~kicad-developers>
> More help   : https://help.launchpad.net/ListHelp <
https://help.launchpad.net/ListHelp>
>
>
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Clemens Koller]

I am impressed!

This seems to be the first step towards what is called "Table Based Design 
Entry" in some other tools.
The next step towards that would be to allow editing of pins and netnames of 
the components (which are arranged in a hierarchical tree view).
And - the tricky part - update the visual representation of the connections in 
the schematics (updating netnames of existing connections and by adding 
netnames/labels to pins for new connections).

Thank you for your great work!

Clemens

On 2017-05-12 10:23, Steven Johnson wrote:
> To answer 3. Its a component field editor/viewer.  It allows you to edit/view 
> your component fields much easier than right clicking on each and every 
> symbol to see what the fields are set to. 
> 
> Its not really a BoM tool although it makes getting your BoM in order much 
> easier.   
> 
> For example a 10K resistor doesnt necessarily specify the manufacturer/part 
> number like a BoM would need to, although it can.  How you use the fields is 
> up to you the designer. 
> 
> 
> On May 12, 2017 15:16, "Fabrizio Tappero"  > wrote:
> 
> Hello,
> great work! this is a good BOM preview, but I am not really sure why the 
> BOM icon does not activate this table (like in Altium). 
> I have done some testing and this is my feedback.
> 1) left alignment is advisable.  The current center alignment makes the 
> table hard to read.
> 2) for a reason I do not know, the current version (today nightly built) 
> has problem to group the "Description" field. Very strange
> 3) What exactly is this table? a "Generate quick BOM"? The current pop up 
> hint text says "Component table view" which I guess is incorrect since you 
> can edit fields. This would help me to make a better icon?
> 
> Inline image 1
> 
> Really great work. I love this new feature.
> 
> cheers
> Fabrizio
> 
> 
> On Sat, May 6, 2017 at 7:28 AM, Strontium  > wrote:
> 
> Hi Oliver,
> 
> On 06/05/17 12:13, Oliver Walters wrote:
>>
>> And it just so happens that in this schematic NO components have 
>> been edited to include these default fields/values, so, they don't show up 
>> in the component table.  
>>
>>
>> I have a patch to fix this now - if a field is empty and a template 
>> value exists, that is placed there instead.
>>  
>>
>> Also, editing Multipart components is a little quirky, If you 
>> change a field for a multi-part component, all "parts" update to that value, 
>> but if any parts have different values, only one is shown in the table and 
>> its not clear that the underlying multipart field is inconsistent.
>>
>>
>> This is a hard one as really, multi-part components should /not/ 
>> have different values in various fields! I had thought about adding another 
>> level (with an arrow as you suggest) but I think it becomes too complicated.
> Yes, I agree with you on this, Its confusing that KiCad doesn't 
> synchronise those fields.  BUT I think maybe its done that way to help 
> facilitate swapping parts between multiple multi-part components. 
> 
> Maybe a developer who knows more about this can weigh in?  Is having 
> different field value/fields in a single multi-part component a "Feature" or 
> a "Quirk"?  And if a "Feature" what's its purpose?
> 
> Steven
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers 
> 
> Post to : kicad-developers@lists.launchpad.net 
> 
> Unsubscribe : https://launchpad.net/~kicad-developers 
> 
> More help   : https://help.launchpad.net/ListHelp 
> 
> 
> 
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Strontium]

Hi Oliver,

On 06/05/17 12:13, Oliver Walters wrote:


And it just so happens that in this schematic NO components have
been edited to include these default fields/values, so, they don't
show up in the component table. 



I have a patch to fix this now - if a field is empty and a template 
value exists, that is placed there instead.


Also, editing Multipart components is a little quirky, If you
change a field for a multi-part component, all "parts" update to
that value, but if any parts have different values, only one is
shown in the table and its not clear that the underlying multipart
field is inconsistent.


This is a hard one as really, multi-part components should /not/ have 
different values in various fields! I had thought about adding another 
level (with an arrow as you suggest) but I think it becomes too 
complicated.
Yes, I agree with you on this, Its confusing that KiCad doesn't 
synchronise those fields.  BUT I think maybe its done that way to help 
facilitate swapping parts between multiple multi-part components.


Maybe a developer who knows more about this can weigh in?  Is having 
different field value/fields in a single multi-part component a 
"Feature" or a "Quirk"?  And if a "Feature" what's its purpose?


Steven


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Oliver Walters]

>
> Perhaps one feature request regarding custom fields would be (if possible)
> to select which field is used for grouping components, instead of just the
> value field. Either a custom field or one of the standard ones like
> footprint name or symbol name. Think editing all 0402 resistors, or all the
> connectors with the same footprint but different value, etc.


The default behaviour is that *all* fields must match for two components to
be considered "equal".

I have added an option for each column to be removed from this check, so
you can specify as many (or as few) columns as you like.

On Fri, May 5, 2017 at 11:50 PM, José Ignacio  wrote:

> Perhaps one feature request regarding custom fields would be (if possible)
> to select which field is used for grouping components, instead of just the
> value field. Either a custom field or one of the standard ones like
> footprint name or symbol name. Think editing all 0402 resistors, or all the
> connectors with the same footprint but different value, etc.
>
> Thank you very much for your excellent work!
> Jose
>
> On Fri, May 5, 2017 at 7:56 AM, Oliver Walters <
> oliver.henry.walt...@gmail.com> wrote:
>
>> Steven,
>>
>> Unless you mean something different to what I think "custom fields"
>> means, then this is already the case - any extra fields (beyond REFERENCE /
>> FOOTPRINT / DATSHEET / VALUE) are preesnt to be edited in the table...
>>
>> On Fri, May 5, 2017 at 10:51 PM, Strontium  wrote:
>>
>>> Hi Oliver,
>>>
>>> Just had a chance to check out your component table viewer, its nice.
>>> Great work.
>>>
>>> Is it on your roadmap to be able to view/edit a components custom fields?
>>>
>>> Regards,
>>> Steven
>>>
>>> On 03/05/17 05:35, Oliver Walters wrote:
>>>
 Wayne,

 Thanks for merging!

 I will address those points at some stage - there are other ideas I
 have too but I thought it was better to get the first iteration done and
 make incremental improvements.

 Regards,
 Oliver

>>>
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Oliver Walters]

>
> And it just so happens that in this schematic NO components have been
> edited to include these default fields/values, so, they don't show up in
> the component table.


I have a patch to fix this now - if a field is empty and a template value
exists, that is placed there instead.


> Also, editing Multipart components is a little quirky, If you change a
> field for a multi-part component, all "parts" update to that value, but if
> any parts have different values, only one is shown in the table and its not
> clear that the underlying multipart field is inconsistent.


This is a hard one as really, multi-part components should *not* have
different values in various fields! I had thought about adding another
level (with an arrow as you suggest) but I think it becomes too
complicated.

On Fri, May 5, 2017 at 11:46 PM, Strontium  wrote:

> Oliver,
>
> This is one of my components:
> http://i.imgur.com/QXyCXXt.png
>
> This is the component table:
> http://i.imgur.com/F2WTRC2.png
>
> The MFG, MPN or EQUIVOK fields in the component aren't shown in the table!
>
> And in doing that I worked out my problem :)
>
> I have MFG/MPN/EQUIVOK defined as "Default Fields" with default values.
> And because the component hasn't been edited, I can edit it and SEE the
> default fields and default values BUT unless I change something they are
> not saved with the component.  And it just so happens that in this
> schematic NO components have been edited to include these default
> fields/values, so, they don't show up in the component table.
>
> It would be nice if the "Default Fields" and their default values show in
> the table if they weren't defined for the component, maybe highlighted in
> some way (Italic, light grey, or something) to indicate they are defaulted
> and not actually set. But now I know why I couldn't see them its not a big
> deal so consider this an Enhancement request.
>
> Also, editing Multipart components is a little quirky, If you change a
> field for a multi-part component, all "parts" update to that value, but if
> any parts have different values, only one is shown in the table and its not
> clear that the underlying multipart field is inconsistent.  Again its not a
> big deal, I just noticed it.  Maybe multipart components should work like
> grouped components, i.e. you can click an arrow and see all the parts and
> edit them individually, or edit the top level component and set them all to
> the same value?  I'm not really sure if this is a good idea or not.
>
> I'm working on an external BOM management tool. It reads a schematic live
> while you edit it in Kicad, and costs it from octopart and/or a database of
> locally defined components, updating in real time.  This tool you have made
> is going to save me an enormous amount of time editing schematics and
> getting all the field metadata consistent.  Thank you.
>
> Two more enhancement ideas:
> 1. A way to update the schematic from edits without closing the table view.
> 2. A way to revert the last edit (undo)
>
> Steven
>
>
> On 05/05/17 20:56, Oliver Walters wrote:
>
> Steven,
>
> Unless you mean something different to what I think "custom fields" means,
> then this is already the case - any extra fields (beyond REFERENCE /
> FOOTPRINT / DATSHEET / VALUE) are preesnt to be edited in the table...
>
> On Fri, May 5, 2017 at 10:51 PM, Strontium  wrote:
>
>> Hi Oliver,
>>
>> Just had a chance to check out your component table viewer, its nice.
>> Great work.
>>
>> Is it on your roadmap to be able to view/edit a components custom fields?
>>
>> Regards,
>> Steven
>>
>> On 03/05/17 05:35, Oliver Walters wrote:
>>
>>> Wayne,
>>>
>>> Thanks for merging!
>>>
>>> I will address those points at some stage - there are other ideas I have
>>> too but I thought it was better to get the first iteration done and make
>>> incremental improvements.
>>>
>>> Regards,
>>> Oliver
>>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Thomas Kindler]

Hi Oliver!

I also tried the new component table viewer, and think that it looks very
promising! I'm switching over from Altium which makes extensive use of List and
Property dock panels, so I would like to provide some feedback:


* There should be a warning if there are uncommitted changes. Right now, it's
very easy to loose work by accidentially hitting ESC.

* The text columns should be left-aligned for readability. Numerical columns
(Quantity..) should be right-aligned (easier to compare numbers).

* The side bar takes up a lot of space on small displays. The field selection
could be replaced by a context menu, like in Windows Explorer or Nautilus.

  * This would also be a good place for "Group by this column", "Size column to
fit", and "Size all columns to fit" menu entries.

* It would be nice to be able to edit the Reference column.

* Field selection and column sizes should be saved and restored when reopening
the dialog, possibly across program restarts.

* Column reordering by dragging the column title (I don't know, if wx provides
that feature).



Also, I think making the dialog non-modal would be useful:

* No need for a custom "Apply/Cancel/Revert all Changes" workflow.
All edits could be done on the fly, and use the normal undo/redo functionality.

* Row Selection could be synchronized with sheet object selection (and vice 
versa).

* There could be a "Zoom to selected object" context menu entry.

* In Altium, the schematic list view can show all types of objects (Nets, Pins,
etc.), and also work in the library abd PCB editor. It's often possible to e.g.
select all 144 pins of a microcontroller, and set the signal names by copy and
paste from a spreadsheet.


Woohoo, a lot of points ;) I'm new on the mailing list -- is this the right way
to give feedback? I'm always afraid of sounding rude or demanding, especially
because english is not my native language.

best regards,
Thomas

On 05.05.2017 14:56, Oliver Walters wrote:
> Steven,
> 
> Unless you mean something different to what I think "custom fields" means, 
> then
> this is already the case - any extra fields (beyond REFERENCE / FOOTPRINT /
> DATSHEET / VALUE) are preesnt to be edited in the table...
> 
> On Fri, May 5, 2017 at 10:51 PM, Strontium  > wrote:
> 
> Hi Oliver,
> 
> Just had a chance to check out your component table viewer, its nice.  
> Great
> work.
> 
> Is it on your roadmap to be able to view/edit a components custom fields?
> 
> Regards,
> Steven
> 
> On 03/05/17 05:35, Oliver Walters wrote:
> 
> Wayne,
> 
> Thanks for merging!
> 
> I will address those points at some stage - there are other ideas I 
> have
> too but I thought it was better to get the first iteration done and 
> make
> incremental improvements.
> 
> Regards,
> Oliver
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Marcos Chaparro]

I would add a separate "Apply" button. I could spend an hour just filling
part numbers and descriptions, and it makes me uncomfortable to have all
those changes stored only in RAM. I can hit "Ok" to close and apply
changes, but then I have to open the viewer again.

And a minor quirk, after a "Regroup components"it should remember the last
sort setting. If I was sorting by value, after a regroup it falls back to
the default reference sorting, and its a bit disorienting.

Great work Oliver





Marcos

On Fri, May 5, 2017 at 10:50 AM, José Ignacio  wrote:

> Perhaps one feature request regarding custom fields would be (if possible)
> to select which field is used for grouping components, instead of just the
> value field. Either a custom field or one of the standard ones like
> footprint name or symbol name. Think editing all 0402 resistors, or all the
> connectors with the same footprint but different value, etc.
>
> Thank you very much for your excellent work!
> Jose
>
> On Fri, May 5, 2017 at 7:56 AM, Oliver Walters <
> oliver.henry.walt...@gmail.com> wrote:
>
>> Steven,
>>
>> Unless you mean something different to what I think "custom fields"
>> means, then this is already the case - any extra fields (beyond REFERENCE /
>> FOOTPRINT / DATSHEET / VALUE) are preesnt to be edited in the table...
>>
>> On Fri, May 5, 2017 at 10:51 PM, Strontium  wrote:
>>
>>> Hi Oliver,
>>>
>>> Just had a chance to check out your component table viewer, its nice.
>>> Great work.
>>>
>>> Is it on your roadmap to be able to view/edit a components custom fields?
>>>
>>> Regards,
>>> Steven
>>>
>>> On 03/05/17 05:35, Oliver Walters wrote:
>>>
 Wayne,

 Thanks for merging!

 I will address those points at some stage - there are other ideas I
 have too but I thought it was better to get the first iteration done and
 make incremental improvements.

 Regards,
 Oliver

>>>
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[José Ignacio]

Perhaps one feature request regarding custom fields would be (if possible)
to select which field is used for grouping components, instead of just the
value field. Either a custom field or one of the standard ones like
footprint name or symbol name. Think editing all 0402 resistors, or all the
connectors with the same footprint but different value, etc.

Thank you very much for your excellent work!
Jose

On Fri, May 5, 2017 at 7:56 AM, Oliver Walters <
oliver.henry.walt...@gmail.com> wrote:

> Steven,
>
> Unless you mean something different to what I think "custom fields" means,
> then this is already the case - any extra fields (beyond REFERENCE /
> FOOTPRINT / DATSHEET / VALUE) are preesnt to be edited in the table...
>
> On Fri, May 5, 2017 at 10:51 PM, Strontium  wrote:
>
>> Hi Oliver,
>>
>> Just had a chance to check out your component table viewer, its nice.
>> Great work.
>>
>> Is it on your roadmap to be able to view/edit a components custom fields?
>>
>> Regards,
>> Steven
>>
>> On 03/05/17 05:35, Oliver Walters wrote:
>>
>>> Wayne,
>>>
>>> Thanks for merging!
>>>
>>> I will address those points at some stage - there are other ideas I have
>>> too but I thought it was better to get the first iteration done and make
>>> incremental improvements.
>>>
>>> Regards,
>>> Oliver
>>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Strontium]

Oliver,

This is one of my components:
http://i.imgur.com/QXyCXXt.png

This is the component table:
http://i.imgur.com/F2WTRC2.png

The MFG, MPN or EQUIVOK fields in the component aren't shown in the table!

And in doing that I worked out my problem :)

I have MFG/MPN/EQUIVOK defined as "Default Fields" with default values.
And because the component hasn't been edited, I can edit it and SEE the 
default fields and default values BUT unless I change something they are 
not saved with the component.  And it just so happens that in this 
schematic NO components have been edited to include these default 
fields/values, so, they don't show up in the component table.


It would be nice if the "Default Fields" and their default values show 
in the table if they weren't defined for the component, maybe 
highlighted in some way (Italic, light grey, or something) to indicate 
they are defaulted and not actually set. But now I know why I couldn't 
see them its not a big deal so consider this an Enhancement request.


Also, editing Multipart components is a little quirky, If you change a 
field for a multi-part component, all "parts" update to that value, but 
if any parts have different values, only one is shown in the table and 
its not clear that the underlying multipart field is inconsistent.  
Again its not a big deal, I just noticed it.  Maybe multipart components 
should work like grouped components, i.e. you can click an arrow and see 
all the parts and edit them individually, or edit the top level 
component and set them all to the same value?  I'm not really sure if 
this is a good idea or not.


I'm working on an external BOM management tool. It reads a schematic 
live while you edit it in Kicad, and costs it from octopart and/or a 
database of locally defined components, updating in real time.  This 
tool you have made is going to save me an enormous amount of time 
editing schematics and getting all the field metadata consistent.  Thank 
you.


Two more enhancement ideas:
1. A way to update the schematic from edits without closing the table view.
2. A way to revert the last edit (undo)

Steven

On 05/05/17 20:56, Oliver Walters wrote:

Steven,

Unless you mean something different to what I think "custom fields" 
means, then this is already the case - any extra fields (beyond 
REFERENCE / FOOTPRINT / DATSHEET / VALUE) are preesnt to be edited in 
the table...


On Fri, May 5, 2017 at 10:51 PM, Strontium > wrote:


Hi Oliver,

Just had a chance to check out your component table viewer, its
nice.  Great work.

Is it on your roadmap to be able to view/edit a components custom
fields?

Regards,
Steven

On 03/05/17 05:35, Oliver Walters wrote:

Wayne,

Thanks for merging!

I will address those points at some stage - there are other
ideas I have too but I thought it was better to get the first
iteration done and make incremental improvements.

Regards,
Oliver



___
Mailing list: https://launchpad.net/~kicad-developers

Post to : kicad-developers@lists.launchpad.net

Unsubscribe : https://launchpad.net/~kicad-developers

More help   : https://help.launchpad.net/ListHelp





___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Oliver Walters]

Steven,

Unless you mean something different to what I think "custom fields" means,
then this is already the case - any extra fields (beyond REFERENCE /
FOOTPRINT / DATSHEET / VALUE) are preesnt to be edited in the table...

On Fri, May 5, 2017 at 10:51 PM, Strontium  wrote:

> Hi Oliver,
>
> Just had a chance to check out your component table viewer, its nice.
> Great work.
>
> Is it on your roadmap to be able to view/edit a components custom fields?
>
> Regards,
> Steven
>
> On 03/05/17 05:35, Oliver Walters wrote:
>
>> Wayne,
>>
>> Thanks for merging!
>>
>> I will address those points at some stage - there are other ideas I have
>> too but I thought it was better to get the first iteration done and make
>> incremental improvements.
>>
>> Regards,
>> Oliver
>>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Strontium]

Hi Oliver,

Just had a chance to check out your component table viewer, its nice.  
Great work.


Is it on your roadmap to be able to view/edit a components custom fields?

Regards,
Steven

On 03/05/17 05:35, Oliver Walters wrote:

Wayne,

Thanks for merging!

I will address those points at some stage - there are other ideas I 
have too but I thought it was better to get the first iteration done 
and make incremental improvements.


Regards,
Oliver



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Oliver Walters]

Wayne,

Thanks for merging!

I will address those points at some stage - there are other ideas I have
too but I thought it was better to get the first iteration done and make
incremental improvements.

Regards,
Oliver

On 3 May 2017 03:25, "Wayne Stambaugh"  wrote:

> Oliver,
>
> This is looking pretty good so I merged your patches into the master
> branch.  I do have a few minor changes that I would like you to make at
> some point:
>
> * Move the OK and Cancel buttons to the bottom of the dialog using a
> wxStdDialogButtonSizer.
>
> * Use dialog style wxDEFAULT_DIALOG_STYLE | wxRESIZE_BORDER.  This will
> remove the stay on top option from the dialog style and add the close
> button decorator to the title bar.
>
> * Set the initial column widths based on their contents rather than
> using a fixed width.
>
> This is a good start but hopefully over time this tool will be extended
> to become a component properties editor rather than just a component
> field editor.  This would be a lot more convenient than opening the
> component properties dialog for every component to edit component
> properties.
>
> Thank you for your contribution to KiCad.
>
> Cheers,
>
> Wayne
>
>
> On 4/25/2017 4:22 AM, Oliver Walters wrote:
> > Wayne,
> >
> > I have reattached all patches including a new one which does the
> following:
> >
> > a) Removes BOM export
> > b) Removes Save/Cancel dialog as per JP's request
> > c) Fixes speed issue as per JP's request
> > d) Small bugfix
> >
> > These should apply directly to latest master branch.
> >
> > Cheers
> >
> > On Tue, Apr 25, 2017 at 12:43 AM, Wayne Stambaugh  > > wrote:
> >
> > Oliver,
> >
> > Thank you for your understanding on this issue.  Once you include the
> > patch to remove the BOM code, I will merge this into the master
> branch.
> >
> > Cheers,
> >
> > Wayne
> >
> > On 4/23/2017 5:41 PM, Oliver Walters wrote:
> > > Wayne,
> > >
> > > I tend to agree actually, as I have been developing this the less I
> > > think having a BoM export is appropriate:
> > >
> > > 1. Separation of tasks - it's simpler and cleaner just as an
> editing table
> > > 2. Python (etc) is way better at data manipulation
> > > 3. External scripts are by design much more flexible.
> > >
> > > I have some ideas for improving BOM output but I am now thinking
> they
> > > would be best served not integrated here.
> > >
> > > I will remove the buttons and leave those thoughts for another
> conversation.
> > >
> > > Oliver
> > >
> > > On 24 Apr 2017 01:47, "Wayne Stambaugh"  
> > > >>
> wrote:
> > >
> > > Oliver,
> > >
> > > I finally got a chance to test your patch set and was a bit
> > surprised
> > > what I saw after following the conversation on the mailing
> > list.  I was
> > > under the impression that this was a generic component
> properties
> > > editing grid not a BOM tool which is what it really is.  I
> > like the idea
> > > of being able to edit component fields in table form.  I'm
> > less thrilled
> > > about the BOM export options.  For those of you who haven't
> > been around
> > > very long, Eeschema used to have a BOM dialog.  It didn't
> > allow for
> > > editing field values but it contained options for various BOM
> > output
> > > types.  Initially this dialog was simple and contained only a
> > few BOM
> > > output types and options.  Of course everyone has their own
> > idea of how
> > > a BOM should be formatted so gradually over time, the BOM
> > dialog and the
> > > underlying BOM output code became a huge mess.  It was finally
> > decided
> > > that the design was no longer maintainable and removed.  It
> > was replaced
> > > by the current system along with samples that provided all of
> > the same
> > > BOM output options from the old BOM dialog.  Except for the
> field
> > > editing grid, your dialog and BOM code looks a lot like the
> > original BOM
> > > dialog.  I can see the same thing happening all over again.
> > Why no use
> > > the existing BOM generation code in your dialog rather than
> > re-implement
> > > code that does the exact same thing?  I'm not opposed to field
> > editing
> > > part of the dialog, but I see the BOM output part heading the
> same
> > > direction as the old BOM dialog.
> > >
> > > On 4/20/2017 1:59 AM, Oliver Walters wrote:
> > > > Wayne,
> > > >
> > > > Is the behaviour I have implemented acceptable?
> > > >
> > > > Regards,
> > > > Oliver
> > > >
> > > > On Wed, Apr 19, 2017 at 12:13 AM, Oliver Walters
> >  

Re: [Kicad-developers] [FEATURE] Component table viewer

[Wayne Stambaugh]

Oliver,

This is looking pretty good so I merged your patches into the master
branch.  I do have a few minor changes that I would like you to make at
some point:

* Move the OK and Cancel buttons to the bottom of the dialog using a
wxStdDialogButtonSizer.

* Use dialog style wxDEFAULT_DIALOG_STYLE | wxRESIZE_BORDER.  This will
remove the stay on top option from the dialog style and add the close
button decorator to the title bar.

* Set the initial column widths based on their contents rather than
using a fixed width.

This is a good start but hopefully over time this tool will be extended
to become a component properties editor rather than just a component
field editor.  This would be a lot more convenient than opening the
component properties dialog for every component to edit component
properties.

Thank you for your contribution to KiCad.

Cheers,

Wayne


On 4/25/2017 4:22 AM, Oliver Walters wrote:
> Wayne,
> 
> I have reattached all patches including a new one which does the following:
> 
> a) Removes BOM export
> b) Removes Save/Cancel dialog as per JP's request
> c) Fixes speed issue as per JP's request
> d) Small bugfix
> 
> These should apply directly to latest master branch.
> 
> Cheers
> 
> On Tue, Apr 25, 2017 at 12:43 AM, Wayne Stambaugh  > wrote:
> 
> Oliver,
> 
> Thank you for your understanding on this issue.  Once you include the
> patch to remove the BOM code, I will merge this into the master branch.
> 
> Cheers,
> 
> Wayne
> 
> On 4/23/2017 5:41 PM, Oliver Walters wrote:
> > Wayne,
> >
> > I tend to agree actually, as I have been developing this the less I
> > think having a BoM export is appropriate:
> >
> > 1. Separation of tasks - it's simpler and cleaner just as an editing 
> table
> > 2. Python (etc) is way better at data manipulation
> > 3. External scripts are by design much more flexible.
> >
> > I have some ideas for improving BOM output but I am now thinking they
> > would be best served not integrated here.
> >
> > I will remove the buttons and leave those thoughts for another 
> conversation.
> >
> > Oliver
> >
> > On 24 Apr 2017 01:47, "Wayne Stambaugh"  
> > >> wrote:
> >
> > Oliver,
> >
> > I finally got a chance to test your patch set and was a bit
> surprised
> > what I saw after following the conversation on the mailing
> list.  I was
> > under the impression that this was a generic component properties
> > editing grid not a BOM tool which is what it really is.  I
> like the idea
> > of being able to edit component fields in table form.  I'm
> less thrilled
> > about the BOM export options.  For those of you who haven't
> been around
> > very long, Eeschema used to have a BOM dialog.  It didn't
> allow for
> > editing field values but it contained options for various BOM
> output
> > types.  Initially this dialog was simple and contained only a
> few BOM
> > output types and options.  Of course everyone has their own
> idea of how
> > a BOM should be formatted so gradually over time, the BOM
> dialog and the
> > underlying BOM output code became a huge mess.  It was finally
> decided
> > that the design was no longer maintainable and removed.  It
> was replaced
> > by the current system along with samples that provided all of
> the same
> > BOM output options from the old BOM dialog.  Except for the field
> > editing grid, your dialog and BOM code looks a lot like the
> original BOM
> > dialog.  I can see the same thing happening all over again. 
> Why no use
> > the existing BOM generation code in your dialog rather than
> re-implement
> > code that does the exact same thing?  I'm not opposed to field
> editing
> > part of the dialog, but I see the BOM output part heading the same
> > direction as the old BOM dialog.
> >
> > On 4/20/2017 1:59 AM, Oliver Walters wrote:
> > > Wayne,
> > >
> > > Is the behaviour I have implemented acceptable?
> > >
> > > Regards,
> > > Oliver
> > >
> > > On Wed, Apr 19, 2017 at 12:13 AM, Oliver Walters
> > >  
> >  >
> >  
> >   > > wrote:
> > >
> > > Wayne,
> > >
> > > I have now fixed this such that UNDO actions are pushed to the
>   

Re: [Kicad-developers] [FEATURE] Component table viewer

[José Ignacio]

I've done a bit of testing on this branch and it works great for me, it cut
the time it takes to release a board to production significantly.

Thanks!
Jose

On Mon, May 1, 2017 at 7:42 AM, Wayne Stambaugh 
wrote:

> Hey Oliver,
>
> I just need to find the time to test and review your changes.  I will
> let you know as soon as I can.
>
> Cheers,
>
> Wayne
>
> On 4/30/2017 5:41 PM, Oliver Walters wrote:
> > Hi Wayne,
> >
> > Anything else you need me to do here?
> >
> > Cheers
> >
> > On 25 Apr 2017 18:22, "Oliver Walters"  > > wrote:
> >
> > Wayne,
> >
> > I have reattached all patches including a new one which does the
> > following:
> >
> > a) Removes BOM export
> > b) Removes Save/Cancel dialog as per JP's request
> > c) Fixes speed issue as per JP's request
> > d) Small bugfix
> >
> > These should apply directly to latest master branch.
> >
> > Cheers
> >
> > On Tue, Apr 25, 2017 at 12:43 AM, Wayne Stambaugh
> > mailto:stambau...@gmail.com>> wrote:
> >
> > Oliver,
> >
> > Thank you for your understanding on this issue.  Once you
> > include the
> > patch to remove the BOM code, I will merge this into the master
> > branch.
> >
> > Cheers,
> >
> > Wayne
> >
> > On 4/23/2017 5:41 PM, Oliver Walters wrote:
> > > Wayne,
> > >
> > > I tend to agree actually, as I have been developing this the
> less I
> > > think having a BoM export is appropriate:
> > >
> > > 1. Separation of tasks - it's simpler and cleaner just as an
> editing table
> > > 2. Python (etc) is way better at data manipulation
> > > 3. External scripts are by design much more flexible.
> > >
> > > I have some ideas for improving BOM output but I am now
> thinking they
> > > would be best served not integrated here.
> > >
> > > I will remove the buttons and leave those thoughts for another
> conversation.
> > >
> > > Oliver
> > >
> > > On 24 Apr 2017 01:47, "Wayne Stambaugh"  
> > > >>
> > wrote:
> > >
> > > Oliver,
> > >
> > > I finally got a chance to test your patch set and was a
> > bit surprised
> > > what I saw after following the conversation on the mailing
> > list.  I was
> > > under the impression that this was a generic component
> > properties
> > > editing grid not a BOM tool which is what it really is.  I
> > like the idea
> > > of being able to edit component fields in table form.  I'm
> > less thrilled
> > > about the BOM export options.  For those of you who
> > haven't been around
> > > very long, Eeschema used to have a BOM dialog.  It didn't
> > allow for
> > > editing field values but it contained options for various
> > BOM output
> > > types.  Initially this dialog was simple and contained
> > only a few BOM
> > > output types and options.  Of course everyone has their
> > own idea of how
> > > a BOM should be formatted so gradually over time, the BOM
> > dialog and the
> > > underlying BOM output code became a huge mess.  It was
> > finally decided
> > > that the design was no longer maintainable and removed.
> > It was replaced
> > > by the current system along with samples that provided all
> > of the same
> > > BOM output options from the old BOM dialog.  Except for
> > the field
> > > editing grid, your dialog and BOM code looks a lot like
> > the original BOM
> > > dialog.  I can see the same thing happening all over
> > again.  Why no use
> > > the existing BOM generation code in your dialog rather
> > than re-implement
> > > code that does the exact same thing?  I'm not opposed to
> > field editing
> > > part of the dialog, but I see the BOM output part heading
> > the same
> > > direction as the old BOM dialog.
> > >
> > > On 4/20/2017 1:59 AM, Oliver Walters wrote:
> > > > Wayne,
> > > >
> > > > Is the behaviour I have implemented acceptable?
> > > >
> > > > Regards,
> > > > Oliver
> > > >
> > > > On Wed, Apr 19, 2017 at 12:13 AM, Oliver Walters
> > > >  > 
> > >  > >
> > >  >  

Re: [Kicad-developers] [FEATURE] Component table viewer

[Wayne Stambaugh]

Hey Oliver,

I just need to find the time to test and review your changes.  I will
let you know as soon as I can.

Cheers,

Wayne

On 4/30/2017 5:41 PM, Oliver Walters wrote:
> Hi Wayne,
> 
> Anything else you need me to do here?
> 
> Cheers
> 
> On 25 Apr 2017 18:22, "Oliver Walters"  > wrote:
> 
> Wayne,
> 
> I have reattached all patches including a new one which does the
> following:
> 
> a) Removes BOM export
> b) Removes Save/Cancel dialog as per JP's request
> c) Fixes speed issue as per JP's request
> d) Small bugfix
> 
> These should apply directly to latest master branch.
> 
> Cheers
> 
> On Tue, Apr 25, 2017 at 12:43 AM, Wayne Stambaugh
> mailto:stambau...@gmail.com>> wrote:
> 
> Oliver,
> 
> Thank you for your understanding on this issue.  Once you
> include the
> patch to remove the BOM code, I will merge this into the master
> branch.
> 
> Cheers,
> 
> Wayne
> 
> On 4/23/2017 5:41 PM, Oliver Walters wrote:
> > Wayne,
> >
> > I tend to agree actually, as I have been developing this the less I
> > think having a BoM export is appropriate:
> >
> > 1. Separation of tasks - it's simpler and cleaner just as an 
> editing table
> > 2. Python (etc) is way better at data manipulation
> > 3. External scripts are by design much more flexible.
> >
> > I have some ideas for improving BOM output but I am now thinking 
> they
> > would be best served not integrated here.
> >
> > I will remove the buttons and leave those thoughts for another 
> conversation.
> >
> > Oliver
> >
> > On 24 Apr 2017 01:47, "Wayne Stambaugh"  
> > >>
> wrote:
> >
> > Oliver,
> >
> > I finally got a chance to test your patch set and was a
> bit surprised
> > what I saw after following the conversation on the mailing
> list.  I was
> > under the impression that this was a generic component
> properties
> > editing grid not a BOM tool which is what it really is.  I
> like the idea
> > of being able to edit component fields in table form.  I'm
> less thrilled
> > about the BOM export options.  For those of you who
> haven't been around
> > very long, Eeschema used to have a BOM dialog.  It didn't
> allow for
> > editing field values but it contained options for various
> BOM output
> > types.  Initially this dialog was simple and contained
> only a few BOM
> > output types and options.  Of course everyone has their
> own idea of how
> > a BOM should be formatted so gradually over time, the BOM
> dialog and the
> > underlying BOM output code became a huge mess.  It was
> finally decided
> > that the design was no longer maintainable and removed. 
> It was replaced
> > by the current system along with samples that provided all
> of the same
> > BOM output options from the old BOM dialog.  Except for
> the field
> > editing grid, your dialog and BOM code looks a lot like
> the original BOM
> > dialog.  I can see the same thing happening all over
> again.  Why no use
> > the existing BOM generation code in your dialog rather
> than re-implement
> > code that does the exact same thing?  I'm not opposed to
> field editing
> > part of the dialog, but I see the BOM output part heading
> the same
> > direction as the old BOM dialog.
> >
> > On 4/20/2017 1:59 AM, Oliver Walters wrote:
> > > Wayne,
> > >
> > > Is the behaviour I have implemented acceptable?
> > >
> > > Regards,
> > > Oliver
> > >
> > > On Wed, Apr 19, 2017 at 12:13 AM, Oliver Walters
> > >  
> >  >
> >  
> >   > > wrote:
> > >
> > > Wayne,
> > >
> > > I have now fixed this such that UNDO actions are pushed 
> to the
> > UNDO
> > > stack for the associated sheet. All UNDO actions for a 
> given sheet
> 

Re: [Kicad-developers] [FEATURE] Component table viewer

[Oliver Walters]

Hi Wayne,

Anything else you need me to do here?

Cheers

On 25 Apr 2017 18:22, "Oliver Walters" 
wrote:

> Wayne,
>
> I have reattached all patches including a new one which does the following:
>
> a) Removes BOM export
> b) Removes Save/Cancel dialog as per JP's request
> c) Fixes speed issue as per JP's request
> d) Small bugfix
>
> These should apply directly to latest master branch.
>
> Cheers
>
> On Tue, Apr 25, 2017 at 12:43 AM, Wayne Stambaugh 
> wrote:
>
>> Oliver,
>>
>> Thank you for your understanding on this issue.  Once you include the
>> patch to remove the BOM code, I will merge this into the master branch.
>>
>> Cheers,
>>
>> Wayne
>>
>> On 4/23/2017 5:41 PM, Oliver Walters wrote:
>> > Wayne,
>> >
>> > I tend to agree actually, as I have been developing this the less I
>> > think having a BoM export is appropriate:
>> >
>> > 1. Separation of tasks - it's simpler and cleaner just as an editing
>> table
>> > 2. Python (etc) is way better at data manipulation
>> > 3. External scripts are by design much more flexible.
>> >
>> > I have some ideas for improving BOM output but I am now thinking they
>> > would be best served not integrated here.
>> >
>> > I will remove the buttons and leave those thoughts for another
>> conversation.
>> >
>> > Oliver
>> >
>> > On 24 Apr 2017 01:47, "Wayne Stambaugh" > > > wrote:
>> >
>> > Oliver,
>> >
>> > I finally got a chance to test your patch set and was a bit
>> surprised
>> > what I saw after following the conversation on the mailing list.  I
>> was
>> > under the impression that this was a generic component properties
>> > editing grid not a BOM tool which is what it really is.  I like the
>> idea
>> > of being able to edit component fields in table form.  I'm less
>> thrilled
>> > about the BOM export options.  For those of you who haven't been
>> around
>> > very long, Eeschema used to have a BOM dialog.  It didn't allow for
>> > editing field values but it contained options for various BOM output
>> > types.  Initially this dialog was simple and contained only a few
>> BOM
>> > output types and options.  Of course everyone has their own idea of
>> how
>> > a BOM should be formatted so gradually over time, the BOM dialog
>> and the
>> > underlying BOM output code became a huge mess.  It was finally
>> decided
>> > that the design was no longer maintainable and removed.  It was
>> replaced
>> > by the current system along with samples that provided all of the
>> same
>> > BOM output options from the old BOM dialog.  Except for the field
>> > editing grid, your dialog and BOM code looks a lot like the
>> original BOM
>> > dialog.  I can see the same thing happening all over again.  Why no
>> use
>> > the existing BOM generation code in your dialog rather than
>> re-implement
>> > code that does the exact same thing?  I'm not opposed to field
>> editing
>> > part of the dialog, but I see the BOM output part heading the same
>> > direction as the old BOM dialog.
>> >
>> > On 4/20/2017 1:59 AM, Oliver Walters wrote:
>> > > Wayne,
>> > >
>> > > Is the behaviour I have implemented acceptable?
>> > >
>> > > Regards,
>> > > Oliver
>> > >
>> > > On Wed, Apr 19, 2017 at 12:13 AM, Oliver Walters
>> > > > > 
>> > > > >>
>> > > wrote:
>> > >
>> > > Wayne,
>> > >
>> > > I have now fixed this such that UNDO actions are pushed to the
>> > UNDO
>> > > stack for the associated sheet. All UNDO actions for a given
>> sheet
>> > > are grouped so a single Ctrl-Z will undo all components
>> changed in
>> > > the table (for the given sheet).
>> > >
>> > > Please find patch _007 attached (must be appli ed atop all
>> > previous
>> > > patches).
>> > >
>> > > Let me know if you see any other pressing issues.
>> > >
>> > > Regards,
>> > > Oliver
>> > >
>> > > On Tue, Apr 18, 2017 at 6:30 AM, Wayne Stambaugh
>> > > mailto:stambau...@gmail.com>
>> > >> wrote:
>> > >
>> > > On 4/17/2017 4:18 PM, Oliver Walters wrote:
>> > > > So how do we proceed here? Is there a 'global' undo
>> > stack? If not:
>> > >
>> > > Unfortunately there is no global undo stack.  Undo stacks
>> are
>> > > maintained
>> > > for each unique SCH_SCREEN (schematic file) object.
>> > >
>> > > >
>> > > > A) don't allow changes made in the component table
>> > viewer to be undone
>> > > > B) Make an undo entry for each sheet that has changed
>> > symbols
>> > > >
>> > > > A) is easier but the user would

Re: [Kicad-developers] [FEATURE] Component table viewer

[Wayne Stambaugh]

Oliver,

Thank you for your understanding on this issue.  Once you include the
patch to remove the BOM code, I will merge this into the master branch.

Cheers,

Wayne

On 4/23/2017 5:41 PM, Oliver Walters wrote:
> Wayne,
> 
> I tend to agree actually, as I have been developing this the less I
> think having a BoM export is appropriate:
> 
> 1. Separation of tasks - it's simpler and cleaner just as an editing table 
> 2. Python (etc) is way better at data manipulation
> 3. External scripts are by design much more flexible. 
> 
> I have some ideas for improving BOM output but I am now thinking they
> would be best served not integrated here.
> 
> I will remove the buttons and leave those thoughts for another conversation.
> 
> Oliver
> 
> On 24 Apr 2017 01:47, "Wayne Stambaugh"  > wrote:
> 
> Oliver,
> 
> I finally got a chance to test your patch set and was a bit surprised
> what I saw after following the conversation on the mailing list.  I was
> under the impression that this was a generic component properties
> editing grid not a BOM tool which is what it really is.  I like the idea
> of being able to edit component fields in table form.  I'm less thrilled
> about the BOM export options.  For those of you who haven't been around
> very long, Eeschema used to have a BOM dialog.  It didn't allow for
> editing field values but it contained options for various BOM output
> types.  Initially this dialog was simple and contained only a few BOM
> output types and options.  Of course everyone has their own idea of how
> a BOM should be formatted so gradually over time, the BOM dialog and the
> underlying BOM output code became a huge mess.  It was finally decided
> that the design was no longer maintainable and removed.  It was replaced
> by the current system along with samples that provided all of the same
> BOM output options from the old BOM dialog.  Except for the field
> editing grid, your dialog and BOM code looks a lot like the original BOM
> dialog.  I can see the same thing happening all over again.  Why no use
> the existing BOM generation code in your dialog rather than re-implement
> code that does the exact same thing?  I'm not opposed to field editing
> part of the dialog, but I see the BOM output part heading the same
> direction as the old BOM dialog.
> 
> On 4/20/2017 1:59 AM, Oliver Walters wrote:
> > Wayne,
> >
> > Is the behaviour I have implemented acceptable?
> >
> > Regards,
> > Oliver
> >
> > On Wed, Apr 19, 2017 at 12:13 AM, Oliver Walters
> >  
>  >>
> > wrote:
> >
> > Wayne,
> >
> > I have now fixed this such that UNDO actions are pushed to the
> UNDO
> > stack for the associated sheet. All UNDO actions for a given sheet
> > are grouped so a single Ctrl-Z will undo all components changed in
> > the table (for the given sheet).
> >
> > Please find patch _007 attached (must be appli ed atop all
> previous
> > patches).
> >
> > Let me know if you see any other pressing issues.
> >
> > Regards,
> > Oliver
> >
> > On Tue, Apr 18, 2017 at 6:30 AM, Wayne Stambaugh
> > mailto:stambau...@gmail.com>
> >> wrote:
> >
> > On 4/17/2017 4:18 PM, Oliver Walters wrote:
> > > So how do we proceed here? Is there a 'global' undo
> stack? If not:
> >
> > Unfortunately there is no global undo stack.  Undo stacks are
> > maintained
> > for each unique SCH_SCREEN (schematic file) object.
> >
> > >
> > > A) don't allow changes made in the component table
> viewer to be undone
> > > B) Make an undo entry for each sheet that has changed
> symbols
> > >
> > > A) is easier but the user would need to
> quit-without-save to undo changes
> >
> > This is less than desirable
> >
> > >
> > > B) is more difficult and doesn't solve the undo
> operations getting out
> > > of order either, as the user could inject another
> operation on a given
> > > sheet.
> >
> > This would be my preference.  Out of order operations are
> already an
> > issue so this solution doesn't make that issue any worse.
> > Undo/redo is
> > only available for the current sheet so the user would have to
> > change
> > sheets in order to undo anything changed in the component
> > properties table.
> >
> > >
> > > Suggestions?
> >   

Re: [Kicad-developers] [FEATURE] Component table viewer

[Oliver Walters]

Wayne,

I tend to agree actually, as I have been developing this the less I think
having a BoM export is appropriate:

1. Separation of tasks - it's simpler and cleaner just as an editing table
2. Python (etc) is way better at data manipulation
3. External scripts are by design much more flexible.

I have some ideas for improving BOM output but I am now thinking they would
be best served not integrated here.

I will remove the buttons and leave those thoughts for another conversation.

Oliver

On 24 Apr 2017 01:47, "Wayne Stambaugh"  wrote:

Oliver,

I finally got a chance to test your patch set and was a bit surprised
what I saw after following the conversation on the mailing list.  I was
under the impression that this was a generic component properties
editing grid not a BOM tool which is what it really is.  I like the idea
of being able to edit component fields in table form.  I'm less thrilled
about the BOM export options.  For those of you who haven't been around
very long, Eeschema used to have a BOM dialog.  It didn't allow for
editing field values but it contained options for various BOM output
types.  Initially this dialog was simple and contained only a few BOM
output types and options.  Of course everyone has their own idea of how
a BOM should be formatted so gradually over time, the BOM dialog and the
underlying BOM output code became a huge mess.  It was finally decided
that the design was no longer maintainable and removed.  It was replaced
by the current system along with samples that provided all of the same
BOM output options from the old BOM dialog.  Except for the field
editing grid, your dialog and BOM code looks a lot like the original BOM
dialog.  I can see the same thing happening all over again.  Why no use
the existing BOM generation code in your dialog rather than re-implement
code that does the exact same thing?  I'm not opposed to field editing
part of the dialog, but I see the BOM output part heading the same
direction as the old BOM dialog.

On 4/20/2017 1:59 AM, Oliver Walters wrote:
> Wayne,
>
> Is the behaviour I have implemented acceptable?
>
> Regards,
> Oliver
>
> On Wed, Apr 19, 2017 at 12:13 AM, Oliver Walters
> mailto:oliver.henry.walt...@gmail.com>>
> wrote:
>
> Wayne,
>
> I have now fixed this such that UNDO actions are pushed to the UNDO
> stack for the associated sheet. All UNDO actions for a given sheet
> are grouped so a single Ctrl-Z will undo all components changed in
> the table (for the given sheet).
>
> Please find patch _007 attached (must be appli ed atop all previous
> patches).
>
> Let me know if you see any other pressing issues.
>
> Regards,
> Oliver
>
> On Tue, Apr 18, 2017 at 6:30 AM, Wayne Stambaugh
> mailto:stambau...@gmail.com>> wrote:
>
> On 4/17/2017 4:18 PM, Oliver Walters wrote:
> > So how do we proceed here? Is there a 'global' undo stack? If
not:
>
> Unfortunately there is no global undo stack.  Undo stacks are
> maintained
> for each unique SCH_SCREEN (schematic file) object.
>
> >
> > A) don't allow changes made in the component table viewer to be
undone
> > B) Make an undo entry for each sheet that has changed symbols
> >
> > A) is easier but the user would need to quit-without-save to
undo changes
>
> This is less than desirable
>
> >
> > B) is more difficult and doesn't solve the undo operations
getting out
> > of order either, as the user could inject another operation on
a given
> > sheet.
>
> This would be my preference.  Out of order operations are already
an
> issue so this solution doesn't make that issue any worse.
> Undo/redo is
> only available for the current sheet so the user would have to
> change
> sheets in order to undo anything changed in the component
> properties table.
>
> >
> > Suggestions?
> >
> > On 18 Apr 2017 01:26, "Wayne Stambaugh" mailto:stambau...@gmail.com>
> > >>
wrote:
> >
> > On 4/17/2017 10:21 AM, jp charras wrote:
> > > Le 17/04/2017 à 04:11, Oliver Walters a écrit :
> > >> JP, others,
> > >>
> > >> After further investigation, I have worked out why the
components
> > with duplicated references were
> > >> displaying incorrectly.
> > >>
> > >> Patch_004 is attached, Thomas can you confirm that it
fixes the
> > display for you?
> > >>
> > >> Kind Regards,
> > >> Oliver
> > >>
> > >> On Mon, Apr 17, 2017 at 7:53 AM, Oliver Walters
> >  
>  >
> >

Re: [Kicad-developers] [FEATURE] Component table viewer

[Wayne Stambaugh]

Oliver,

I finally got a chance to test your patch set and was a bit surprised
what I saw after following the conversation on the mailing list.  I was
under the impression that this was a generic component properties
editing grid not a BOM tool which is what it really is.  I like the idea
of being able to edit component fields in table form.  I'm less thrilled
about the BOM export options.  For those of you who haven't been around
very long, Eeschema used to have a BOM dialog.  It didn't allow for
editing field values but it contained options for various BOM output
types.  Initially this dialog was simple and contained only a few BOM
output types and options.  Of course everyone has their own idea of how
a BOM should be formatted so gradually over time, the BOM dialog and the
underlying BOM output code became a huge mess.  It was finally decided
that the design was no longer maintainable and removed.  It was replaced
by the current system along with samples that provided all of the same
BOM output options from the old BOM dialog.  Except for the field
editing grid, your dialog and BOM code looks a lot like the original BOM
dialog.  I can see the same thing happening all over again.  Why no use
the existing BOM generation code in your dialog rather than re-implement
code that does the exact same thing?  I'm not opposed to field editing
part of the dialog, but I see the BOM output part heading the same
direction as the old BOM dialog.

On 4/20/2017 1:59 AM, Oliver Walters wrote:
> Wayne,
> 
> Is the behaviour I have implemented acceptable?
> 
> Regards,
> Oliver
> 
> On Wed, Apr 19, 2017 at 12:13 AM, Oliver Walters
> mailto:oliver.henry.walt...@gmail.com>>
> wrote:
> 
> Wayne,
> 
> I have now fixed this such that UNDO actions are pushed to the UNDO
> stack for the associated sheet. All UNDO actions for a given sheet
> are grouped so a single Ctrl-Z will undo all components changed in
> the table (for the given sheet).
> 
> Please find patch _007 attached (must be appli ed atop all previous
> patches).
> 
> Let me know if you see any other pressing issues.
> 
> Regards,
> Oliver
> 
> On Tue, Apr 18, 2017 at 6:30 AM, Wayne Stambaugh
> mailto:stambau...@gmail.com>> wrote:
> 
> On 4/17/2017 4:18 PM, Oliver Walters wrote:
> > So how do we proceed here? Is there a 'global' undo stack? If not:
> 
> Unfortunately there is no global undo stack.  Undo stacks are
> maintained
> for each unique SCH_SCREEN (schematic file) object.
> 
> >
> > A) don't allow changes made in the component table viewer to be 
> undone
> > B) Make an undo entry for each sheet that has changed symbols
> >
> > A) is easier but the user would need to quit-without-save to undo 
> changes
> 
> This is less than desirable
> 
> >
> > B) is more difficult and doesn't solve the undo operations getting 
> out
> > of order either, as the user could inject another operation on a 
> given
> > sheet.
> 
> This would be my preference.  Out of order operations are already an
> issue so this solution doesn't make that issue any worse. 
> Undo/redo is
> only available for the current sheet so the user would have to
> change
> sheets in order to undo anything changed in the component
> properties table.
> 
> >
> > Suggestions?
> >
> > On 18 Apr 2017 01:26, "Wayne Stambaugh"  
> > >> wrote:
> >
> > On 4/17/2017 10:21 AM, jp charras wrote:
> > > Le 17/04/2017 à 04:11, Oliver Walters a écrit :
> > >> JP, others,
> > >>
> > >> After further investigation, I have worked out why the 
> components
> > with duplicated references were
> > >> displaying incorrectly.
> > >>
> > >> Patch_004 is attached, Thomas can you confirm that it fixes 
> the
> > display for you?
> > >>
> > >> Kind Regards,
> > >> Oliver
> > >>
> > >> On Mon, Apr 17, 2017 at 7:53 AM, Oliver Walters
> >  
>  >
> > >
> > > Good work, Oliver!
> > >
> > > I found 2 issues (tested on W7)
> > >
> > > 1 - m_reloadTableButton is not correctly enabled/disabled.
> > > This is due to the way events are managed, and this is
> OS dependent.
> > > To avoid this issue, enable/disable it inside a
> wxUpdateUIEvent
> > attached to this button.
> > >
> > > 2 - ESC key and ENTER keys do not dism

Re: [Kicad-developers] [FEATURE] Component table viewer

[jp charras]

Le 20/04/2017 à 07:59, Oliver Walters a écrit :
> Wayne,
> 
> Is the behaviour I have implemented acceptable?
> 
> Regards,
> Oliver

Hi Oliver,

I tested your latest patches.

I found 3 issues: a minor one a 2 more annoying.

The minor:
After clicking on OK button the DisplayExitDialog() function is still called.
This is useless, because the user has already chosen the OK button. (The cancel 
button does not call
TransferDataFromWindow)

The annoying:
1 - in complex hierarchies, for instance 4 times the same sheet, if a component 
is modified, the
undo command is stored 4 times (one by sheet instance) for the same basic sheet 
(or SCH_SCREEN)
instead of only one time,
certainly because it appears 4 times (one by sheet instance) in the grid table 
(but there is only
one component in schematic and only one basic sheet)
2 - After click OK, the transfer of changes to the schematic can be very time 
consuming (8 s in my
design)
This is due to the fact ApplyFieldChanges() called after OK calls ItemChanged().
ItemChanged() Is very time consuming, and this call is useless because the 
dialog is just closed.


> 
> On Wed, Apr 19, 2017 at 12:13 AM, Oliver Walters 
>  > wrote:
> 
> Wayne,
> 
> I have now fixed this such that UNDO actions are pushed to the UNDO stack 
> for the associated
> sheet. All UNDO actions for a given sheet are grouped so a single Ctrl-Z 
> will undo all
> components changed in the table (for the given sheet).
> 
> Please find patch _007 attached (must be appli ed atop all previous 
> patches).
> 
> Let me know if you see any other pressing issues.
> 
> Regards,
> Oliver
> 
> On Tue, Apr 18, 2017 at 6:30 AM, Wayne Stambaugh  > wrote:
> 
> On 4/17/2017 4:18 PM, Oliver Walters wrote:
> > So how do we proceed here? Is there a 'global' undo stack? If not:
> 
> Unfortunately there is no global undo stack.  Undo stacks are 
> maintained
> for each unique SCH_SCREEN (schematic file) object.
> 
> >
> > A) don't allow changes made in the component table viewer to be 
> undone
> > B) Make an undo entry for each sheet that has changed symbols
> >
> > A) is easier but the user would need to quit-without-save to undo 
> changes
> 
> This is less than desirable
> 
> >
> > B) is more difficult and doesn't solve the undo operations getting 
> out
> > of order either, as the user could inject another operation on a 
> given
> > sheet.
> 
> This would be my preference.  Out of order operations are already an
> issue so this solution doesn't make that issue any worse.  Undo/redo 
> is
> only available for the current sheet so the user would have to change
> sheets in order to undo anything changed in the component properties 
> table.
> 
> >
> > Suggestions?
> >
> > On 18 Apr 2017 01:26, "Wayne Stambaugh"  
> > >> wrote:
> >
> > On 4/17/2017 10:21 AM, jp charras wrote:
> > > Le 17/04/2017 à 04:11, Oliver Walters a écrit :
> > >> JP, others,
> > >>
> > >> After further investigation, I have worked out why the 
> components
> > with duplicated references were
> > >> displaying incorrectly.
> > >>
> > >> Patch_004 is attached, Thomas can you confirm that it fixes 
> the
> > display for you?
> > >>
> > >> Kind Regards,
> > >> Oliver
> > >>
> > >> On Mon, Apr 17, 2017 at 7:53 AM, Oliver Walters
> >  
>  >
> > >
> > > Good work, Oliver!
> > >
> > > I found 2 issues (tested on W7)
> > >
> > > 1 - m_reloadTableButton is not correctly enabled/disabled.
> > > This is due to the way events are managed, and this is OS 
> dependent.
> > > To avoid this issue, enable/disable it inside a 
> wxUpdateUIEvent
> > attached to this button.
> > >
> > > 2 - ESC key and ENTER keys do not dismiss the dialog.
> > > This is due to the fact you do not have a 
> wxStdDialogButtonSizer,
> > and no OK and Cancel button.
> > > Please, add it and use the OK button (as usual in a dialog) to
> > transfer changes to schematic (do not
> > > use a wxCloseEvent to manage that), and obviously Cancel just
> > closes the dialog.
> > > To do this transfer, just  override TransferDataFromWindow(), 
> that
> > is called by wxWidgets when

Re: [Kicad-developers] [FEATURE] Component table viewer

[Oliver Walters]

Wayne,

Is the behaviour I have implemented acceptable?

Regards,
Oliver

On Wed, Apr 19, 2017 at 12:13 AM, Oliver Walters <
oliver.henry.walt...@gmail.com> wrote:

> Wayne,
>
> I have now fixed this such that UNDO actions are pushed to the UNDO stack
> for the associated sheet. All UNDO actions for a given sheet are grouped so
> a single Ctrl-Z will undo all components changed in the table (for the
> given sheet).
>
> Please find patch _007 attached (must be appli ed atop all previous
> patches).
>
> Let me know if you see any other pressing issues.
>
> Regards,
> Oliver
>
> On Tue, Apr 18, 2017 at 6:30 AM, Wayne Stambaugh 
> wrote:
>
>> On 4/17/2017 4:18 PM, Oliver Walters wrote:
>> > So how do we proceed here? Is there a 'global' undo stack? If not:
>>
>> Unfortunately there is no global undo stack.  Undo stacks are maintained
>> for each unique SCH_SCREEN (schematic file) object.
>>
>> >
>> > A) don't allow changes made in the component table viewer to be undone
>> > B) Make an undo entry for each sheet that has changed symbols
>> >
>> > A) is easier but the user would need to quit-without-save to undo
>> changes
>>
>> This is less than desirable
>>
>> >
>> > B) is more difficult and doesn't solve the undo operations getting out
>> > of order either, as the user could inject another operation on a given
>> > sheet.
>>
>> This would be my preference.  Out of order operations are already an
>> issue so this solution doesn't make that issue any worse.  Undo/redo is
>> only available for the current sheet so the user would have to change
>> sheets in order to undo anything changed in the component properties
>> table.
>>
>> >
>> > Suggestions?
>> >
>> > On 18 Apr 2017 01:26, "Wayne Stambaugh" > > > wrote:
>> >
>> > On 4/17/2017 10:21 AM, jp charras wrote:
>> > > Le 17/04/2017 à 04:11, Oliver Walters a écrit :
>> > >> JP, others,
>> > >>
>> > >> After further investigation, I have worked out why the components
>> > with duplicated references were
>> > >> displaying incorrectly.
>> > >>
>> > >> Patch_004 is attached, Thomas can you confirm that it fixes the
>> > display for you?
>> > >>
>> > >> Kind Regards,
>> > >> Oliver
>> > >>
>> > >> On Mon, Apr 17, 2017 at 7:53 AM, Oliver Walters
>> > mailto:oliver.henry.walters@g
>> mail.com>
>> > >
>> > > Good work, Oliver!
>> > >
>> > > I found 2 issues (tested on W7)
>> > >
>> > > 1 - m_reloadTableButton is not correctly enabled/disabled.
>> > > This is due to the way events are managed, and this is OS
>> dependent.
>> > > To avoid this issue, enable/disable it inside a wxUpdateUIEvent
>> > attached to this button.
>> > >
>> > > 2 - ESC key and ENTER keys do not dismiss the dialog.
>> > > This is due to the fact you do not have a wxStdDialogButtonSizer,
>> > and no OK and Cancel button.
>> > > Please, add it and use the OK button (as usual in a dialog) to
>> > transfer changes to schematic (do not
>> > > use a wxCloseEvent to manage that), and obviously Cancel just
>> > closes the dialog.
>> > > To do this transfer, just  override TransferDataFromWindow(), that
>> > is called by wxWidgets when
>> > > closing a dialog by the OK button.
>> > >
>> > > About other things, undo/redo lists should manage only changes
>> > made inside the corresponding sheet,
>> > > not in other sheets, to avoid inconsistencies and therefore
>> crashes.
>> > >
>> >
>> > This is one of the reasons I've been reluctant to accept code that
>> > attempts to change the state of a SCH_SCREEN object other than the
>> > current SCH_SCREEN object.  It exposes a known flaw in our schematic
>> > undo/redo design and I have yet to see anyone update the undo/redo
>> > SCH_SCREEN stacks correctly.  I see the potential for serious
>> issues if
>> > you do not keep the undo/redo stacks properly synced.  Once you
>> allow
>> > the modification of information in the SCH_SCREEN object other than
>> the
>> > current one, you need to update the undo/redo stack for the
>> appropriate
>> > SCH_SCREEN object.  Otherwise, you wont be able to undo all of the
>> > changes correctly.
>> >
>> > ___
>> > Mailing list: https://launchpad.net/~kicad-developers
>> > 
>> > Post to : kicad-developers@lists.launchpad.net
>> > 
>> > Unsubscribe : https://launchpad.net/~kicad-developers
>> > 
>> > More help   : https://help.launchpad.net/ListHelp
>> > 
>> >
>>
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-

Re: [Kicad-developers] [FEATURE] Component table viewer

[Oliver Walters]

Wayne,

I have now fixed this such that UNDO actions are pushed to the UNDO stack
for the associated sheet. All UNDO actions for a given sheet are grouped so
a single Ctrl-Z will undo all components changed in the table (for the
given sheet).

Please find patch _007 attached (must be appli ed atop all previous
patches).

Let me know if you see any other pressing issues.

Regards,
Oliver

On Tue, Apr 18, 2017 at 6:30 AM, Wayne Stambaugh 
wrote:

> On 4/17/2017 4:18 PM, Oliver Walters wrote:
> > So how do we proceed here? Is there a 'global' undo stack? If not:
>
> Unfortunately there is no global undo stack.  Undo stacks are maintained
> for each unique SCH_SCREEN (schematic file) object.
>
> >
> > A) don't allow changes made in the component table viewer to be undone
> > B) Make an undo entry for each sheet that has changed symbols
> >
> > A) is easier but the user would need to quit-without-save to undo changes
>
> This is less than desirable
>
> >
> > B) is more difficult and doesn't solve the undo operations getting out
> > of order either, as the user could inject another operation on a given
> > sheet.
>
> This would be my preference.  Out of order operations are already an
> issue so this solution doesn't make that issue any worse.  Undo/redo is
> only available for the current sheet so the user would have to change
> sheets in order to undo anything changed in the component properties table.
>
> >
> > Suggestions?
> >
> > On 18 Apr 2017 01:26, "Wayne Stambaugh"  > > wrote:
> >
> > On 4/17/2017 10:21 AM, jp charras wrote:
> > > Le 17/04/2017 à 04:11, Oliver Walters a écrit :
> > >> JP, others,
> > >>
> > >> After further investigation, I have worked out why the components
> > with duplicated references were
> > >> displaying incorrectly.
> > >>
> > >> Patch_004 is attached, Thomas can you confirm that it fixes the
> > display for you?
> > >>
> > >> Kind Regards,
> > >> Oliver
> > >>
> > >> On Mon, Apr 17, 2017 at 7:53 AM, Oliver Walters
> > mailto:oliver.henry.walters@
> gmail.com>
> > >
> > > Good work, Oliver!
> > >
> > > I found 2 issues (tested on W7)
> > >
> > > 1 - m_reloadTableButton is not correctly enabled/disabled.
> > > This is due to the way events are managed, and this is OS
> dependent.
> > > To avoid this issue, enable/disable it inside a wxUpdateUIEvent
> > attached to this button.
> > >
> > > 2 - ESC key and ENTER keys do not dismiss the dialog.
> > > This is due to the fact you do not have a wxStdDialogButtonSizer,
> > and no OK and Cancel button.
> > > Please, add it and use the OK button (as usual in a dialog) to
> > transfer changes to schematic (do not
> > > use a wxCloseEvent to manage that), and obviously Cancel just
> > closes the dialog.
> > > To do this transfer, just  override TransferDataFromWindow(), that
> > is called by wxWidgets when
> > > closing a dialog by the OK button.
> > >
> > > About other things, undo/redo lists should manage only changes
> > made inside the corresponding sheet,
> > > not in other sheets, to avoid inconsistencies and therefore
> crashes.
> > >
> >
> > This is one of the reasons I've been reluctant to accept code that
> > attempts to change the state of a SCH_SCREEN object other than the
> > current SCH_SCREEN object.  It exposes a known flaw in our schematic
> > undo/redo design and I have yet to see anyone update the undo/redo
> > SCH_SCREEN stacks correctly.  I see the potential for serious issues
> if
> > you do not keep the undo/redo stacks properly synced.  Once you allow
> > the modification of information in the SCH_SCREEN object other than
> the
> > current one, you need to update the undo/redo stack for the
> appropriate
> > SCH_SCREEN object.  Otherwise, you wont be able to undo all of the
> > changes correctly.
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > 
> > Post to : kicad-developers@lists.launchpad.net
> > 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > 
> > More help   : https://help.launchpad.net/ListHelp
> > 
> >
>
From 124055f368d77d51d45c4ab21331d670749d1d8a Mon Sep 17 00:00:00 2001
From: Oliver Walters 
Date: Wed, 19 Apr 2017 00:10:17 +1000
Subject: [PATCH] Fixed UNDO behaviour

- Undo actions are pushed to the appropriate sheet(s)
- Each sheet's actions are grouped together
---
 eeschema/bom_table_model.cpp   | 11 ++---
 eeschema/bom_table_model.h |  2 +-
 eeschema/dialogs/dialog_bom_editor.cpp | 78 +-
 3 files changed, 71 insertions(+), 20 deletions(-)

Re: [Kicad-developers] [FEATURE] Component table viewer

[Oliver Walters]

I have attached two more patches that address issues raised by Tom and JP:

_005:
- Adds OK/CANCEL dialog
- Removes onClose event
- Moves UI updates into onUpdateUI event

_006:
- Fixes editing of "duplicate" components (e.g. components on sheets that
are referenced multiple times)
- Editing one of these components will edit ALL instances of that component
in the table

I will next try to work out a sensible way of grouping the UNDO actions
per-sheet. In the mean time if anyone wants to provide feedback on the
latest patches, I would appreciate that.

Regards,
Oliver

On Tue, Apr 18, 2017 at 11:05 PM, Wayne Stambaugh 
wrote:

> On 4/18/2017 5:01 AM, Oliver Walters wrote:
> > Wayne,
> >
> > With this in mind, I am unsure how to determine (given a list of
> > components) which sheet they originate in.
>
> All of this information is in the SCH_REFERENCE object.  You will have
> to cross reference the SCH_SHEET_PATH to find the appropriate
> SCH_SCREEN for each object.  SCH_SCREEN (derived from BASE_SCREEN) is
> where the undo/redo stacks reside.
>
> >
> > I need a SCH_EDIT_FRAME* for each component, to work out where to push
> > each undo operation.
>
> You shouldn't need the SCH_EDIT_FRAME to find the undo/redo stack
> objects if you have the SCH_REFERENCE objects.  See above.
>
> >
> > I have a list of SCH_REFERENCE objects, is there a way of determining
> > where each object originates? Could you point me in the right direction?
> >
> > Regards,
> > Oliver
> >
> > On Tue, Apr 18, 2017 at 6:30 AM, Wayne Stambaugh  > > wrote:
> >
> > On 4/17/2017 4:18 PM, Oliver Walters wrote:
> > > So how do we proceed here? Is there a 'global' undo stack? If not:
> >
> > Unfortunately there is no global undo stack.  Undo stacks are
> maintained
> > for each unique SCH_SCREEN (schematic file) object.
> >
> > >
> > > A) don't allow changes made in the component table viewer to be
> undone
> > > B) Make an undo entry for each sheet that has changed symbols
> > >
> > > A) is easier but the user would need to quit-without-save to undo
> changes
> >
> > This is less than desirable
> >
> > >
> > > B) is more difficult and doesn't solve the undo operations getting
> out
> > > of order either, as the user could inject another operation on a
> given
> > > sheet.
> >
> > This would be my preference.  Out of order operations are already an
> > issue so this solution doesn't make that issue any worse.  Undo/redo
> is
> > only available for the current sheet so the user would have to change
> > sheets in order to undo anything changed in the component properties
> > table.
> >
> > >
> > > Suggestions?
> > >
> > > On 18 Apr 2017 01:26, "Wayne Stambaugh"  
> > > >>
> wrote:
> > >
> > > On 4/17/2017 10:21 AM, jp charras wrote:
> > > > Le 17/04/2017 à 04:11, Oliver Walters a écrit :
> > > >> JP, others,
> > > >>
> > > >> After further investigation, I have worked out why the
> components
> > > with duplicated references were
> > > >> displaying incorrectly.
> > > >>
> > > >> Patch_004 is attached, Thomas can you confirm that it fixes
> the
> > > display for you?
> > > >>
> > > >> Kind Regards,
> > > >> Oliver
> > > >>
> > > >> On Mon, Apr 17, 2017 at 7:53 AM, Oliver Walters
> > >  > 
> >  > >
> > > >
> > > > Good work, Oliver!
> > > >
> > > > I found 2 issues (tested on W7)
> > > >
> > > > 1 - m_reloadTableButton is not correctly enabled/disabled.
> > > > This is due to the way events are managed, and this is OS
> > dependent.
> > > > To avoid this issue, enable/disable it inside a
> wxUpdateUIEvent
> > > attached to this button.
> > > >
> > > > 2 - ESC key and ENTER keys do not dismiss the dialog.
> > > > This is due to the fact you do not have a
> > wxStdDialogButtonSizer,
> > > and no OK and Cancel button.
> > > > Please, add it and use the OK button (as usual in a dialog)
> to
> > > transfer changes to schematic (do not
> > > > use a wxCloseEvent to manage that), and obviously Cancel just
> > > closes the dialog.
> > > > To do this transfer, just  override
> > TransferDataFromWindow(), that
> > > is called by wxWidgets when
> > > > closing a dialog by the OK button.
> > > >
> > > > About other things, undo/redo lists should manage only
> changes
> > > made inside the corresponding sheet,
> > > > not in other sheets, to avoid inconsistencies and therefore
> > crashes.

Re: [Kicad-developers] [FEATURE] Component table viewer

[Wayne Stambaugh]

On 4/18/2017 5:01 AM, Oliver Walters wrote:
> Wayne,
> 
> With this in mind, I am unsure how to determine (given a list of
> components) which sheet they originate in.

All of this information is in the SCH_REFERENCE object.  You will have
to cross reference the SCH_SHEET_PATH to find the appropriate
SCH_SCREEN for each object.  SCH_SCREEN (derived from BASE_SCREEN) is
where the undo/redo stacks reside.

> 
> I need a SCH_EDIT_FRAME* for each component, to work out where to push
> each undo operation. 

You shouldn't need the SCH_EDIT_FRAME to find the undo/redo stack
objects if you have the SCH_REFERENCE objects.  See above.

> 
> I have a list of SCH_REFERENCE objects, is there a way of determining
> where each object originates? Could you point me in the right direction? 
> 
> Regards,
> Oliver
> 
> On Tue, Apr 18, 2017 at 6:30 AM, Wayne Stambaugh  > wrote:
> 
> On 4/17/2017 4:18 PM, Oliver Walters wrote:
> > So how do we proceed here? Is there a 'global' undo stack? If not:
> 
> Unfortunately there is no global undo stack.  Undo stacks are maintained
> for each unique SCH_SCREEN (schematic file) object.
> 
> >
> > A) don't allow changes made in the component table viewer to be undone
> > B) Make an undo entry for each sheet that has changed symbols
> >
> > A) is easier but the user would need to quit-without-save to undo 
> changes
> 
> This is less than desirable
> 
> >
> > B) is more difficult and doesn't solve the undo operations getting out
> > of order either, as the user could inject another operation on a given
> > sheet.
> 
> This would be my preference.  Out of order operations are already an
> issue so this solution doesn't make that issue any worse.  Undo/redo is
> only available for the current sheet so the user would have to change
> sheets in order to undo anything changed in the component properties
> table.
> 
> >
> > Suggestions?
> >
> > On 18 Apr 2017 01:26, "Wayne Stambaugh"  
> > >> wrote:
> >
> > On 4/17/2017 10:21 AM, jp charras wrote:
> > > Le 17/04/2017 à 04:11, Oliver Walters a écrit :
> > >> JP, others,
> > >>
> > >> After further investigation, I have worked out why the components
> > with duplicated references were
> > >> displaying incorrectly.
> > >>
> > >> Patch_004 is attached, Thomas can you confirm that it fixes the
> > display for you?
> > >>
> > >> Kind Regards,
> > >> Oliver
> > >>
> > >> On Mon, Apr 17, 2017 at 7:53 AM, Oliver Walters
> >  
>  >
> > >
> > > Good work, Oliver!
> > >
> > > I found 2 issues (tested on W7)
> > >
> > > 1 - m_reloadTableButton is not correctly enabled/disabled.
> > > This is due to the way events are managed, and this is OS
> dependent.
> > > To avoid this issue, enable/disable it inside a wxUpdateUIEvent
> > attached to this button.
> > >
> > > 2 - ESC key and ENTER keys do not dismiss the dialog.
> > > This is due to the fact you do not have a
> wxStdDialogButtonSizer,
> > and no OK and Cancel button.
> > > Please, add it and use the OK button (as usual in a dialog) to
> > transfer changes to schematic (do not
> > > use a wxCloseEvent to manage that), and obviously Cancel just
> > closes the dialog.
> > > To do this transfer, just  override
> TransferDataFromWindow(), that
> > is called by wxWidgets when
> > > closing a dialog by the OK button.
> > >
> > > About other things, undo/redo lists should manage only changes
> > made inside the corresponding sheet,
> > > not in other sheets, to avoid inconsistencies and therefore
> crashes.
> > >
> >
> > This is one of the reasons I've been reluctant to accept code that
> > attempts to change the state of a SCH_SCREEN object other than the
> > current SCH_SCREEN object.  It exposes a known flaw in our
> schematic
> > undo/redo design and I have yet to see anyone update the undo/redo
> > SCH_SCREEN stacks correctly.  I see the potential for serious
> issues if
> > you do not keep the undo/redo stacks properly synced.  Once
> you allow
> > the modification of information in the SCH_SCREEN object other
> than the
> > current one, you need to update the undo/redo stack for the
> appropriate
> > SCH_SCREEN object.  Otherwise, you wont be able to undo all of the
> > changes correctly.
> >
> > ___

Re: [Kicad-developers] [FEATURE] Component table viewer

[Wayne Stambaugh]

On 4/18/2017 3:12 AM, jp charras wrote:
> Le 17/04/2017 à 22:51, Nox a écrit :
>> I know that I already suggested that in another context but what about 
>> changing the undo/redo
>> semantic to the more common approach to maintain an global undo/redo stack 
>> and switch the view
>> accordingly? I know that the "per screen" is the established way in kicad 
>> and that it is very
>> dangerous to break existing workflows. But the undo/redo behaviour is 
>> currently hardly
>> "understandable" for beginners. E.g. why does the undo not follow my actions 
>> but stays on one view?
>> Why does exporting the netlist break the undo? Why can automatic annotation 
>> not be reverted? The
>> undo list wiped on a frequently basis that personally i hardly trust into 
>> the undo functionality at
>> all.
>>
>> Would it be an option to introduce a "test version" of a global undo/redo to 
>> get some feedback from
>> the crowed which way would be preferred?
>>
> 
> For me, the problem is not to have a global or per screen undo/redo list, but 
> what an user is
> expecting when undoing/redoing a change.
> 
> We *always* expect to undo the last change.
> Any undo/redo system has this behavior.
> 
> Now consider an editor (the schematic editor with 3 sheets for instance, but 
> this is also the case
> of text editors with 3 files opened and currently edited).
> 
> 1 - in sheet1 you call a tool (component table editor, automatic annotation) 
> which modify all sheets.
> 
> 2 - after  that you enter sheet2 and make new changes then sheet3 and also 
> make new changes.
> 
> 3 - back to sheet1 and try to undelete the latest change in this sheet: this 
> is the global change
> (i.e. annotation). This is possible in sheet1.
> But how can you undo this annotation in others sheets: this is not the latest 
> change and cannot be
> undone safely (you can have deleted/replaced/edited a symbol in other sheets, 
> or deleted a sheet):
> what is the actual meaning of "undo the annotation" in other sheets).
> 
> And ultimately:
> What a undo (and therefore redo) command must undo:
> 1 - the latest change in the full schematic (global undo/redo)
>  or
> 2 - the latest change in the currently edited (active) sheet (local undo/redo)
> 
> This is a choice, and the answer is for me not trivial.

I agree.  This answer is not obvious.  Global undo may seem like the
obvious choice but I'm not sure users will expect undo to undo changes
in a sheet other than the one they are currently working on.  Using per
sheet undo to undo a global change such as an full annotation might be
confusing as well.

The other issue is that any global undo feature has to be very carefully
designed because any component and/or sheet edited by a global command
such as annotate could be deleted in subsequent editing which could
cause the pointers in the undo buffer to be broken.

> 
> It could be worth to know what is the option for global/local changes in a 
> schematic hierarchy in
> other schematic editors.

If someone has the time to test some other schematic editors to see if
they support global change undo, it would be helpful.  I'm guessing
annotation would be the easiest thing to test.

> 
> Multi-file text editors can undo the latest change only in the active file, 
> not in all opened files.
> 

I'm not sure if this is a good analogy.  Text files are completely stand
alone and do not have any pointers to objects in other text files being
edited so there is no possibility of invalid object pointers during undo.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Nox]

I agree with you about the multi file editor behaviour. There it is 
natural that the undo/redo works per file. But is this behaviour also 
reasonable for a schematic? I just checked the behaviour of visual 
studio. There global replacement will be reverted if the stack is in 
sync. Else only the active document is affected. So I guess you are 
right. We have to first agree which way redo/undo should work. 
Personally I would perfere to move to a "mixed" or global redo/undo.


What do you think: how hard will it be to implement a "container" 
undo/redo item which batchs multiple changes (e.g. for component 
changes, annotation, etc) and has an ID to check with all open sheets if 
the top most change matches. Of course it is questionable if a "silent" 
partial undo/redo is the best way to handle desynced stacks. Or might a 
global redo/undo will be easier to maintain? Or should global operations 
simply always "break" the local undo/redo stacks (so our "state of the 
art"-handling)?


P.S: should we branch the discussion here maybe?


Am 18.04.2017 um 09:12 schrieb jp charras:

Le 17/04/2017 à 22:51, Nox a écrit :

I know that I already suggested that in another context but what about changing 
the undo/redo
semantic to the more common approach to maintain an global undo/redo stack and 
switch the view
accordingly? I know that the "per screen" is the established way in kicad and 
that it is very
dangerous to break existing workflows. But the undo/redo behaviour is currently 
hardly
"understandable" for beginners. E.g. why does the undo not follow my actions 
but stays on one view?
Why does exporting the netlist break the undo? Why can automatic annotation not 
be reverted? The
undo list wiped on a frequently basis that personally i hardly trust into the 
undo functionality at
all.

Would it be an option to introduce a "test version" of a global undo/redo to 
get some feedback from
the crowed which way would be preferred?


For me, the problem is not to have a global or per screen undo/redo list, but 
what an user is
expecting when undoing/redoing a change.

We *always* expect to undo the last change.
Any undo/redo system has this behavior.

Now consider an editor (the schematic editor with 3 sheets for instance, but 
this is also the case
of text editors with 3 files opened and currently edited).

1 - in sheet1 you call a tool (component table editor, automatic annotation) 
which modify all sheets.

2 - after  that you enter sheet2 and make new changes then sheet3 and also make 
new changes.

3 - back to sheet1 and try to undelete the latest change in this sheet: this is 
the global change
(i.e. annotation). This is possible in sheet1.
But how can you undo this annotation in others sheets: this is not the latest 
change and cannot be
undone safely (you can have deleted/replaced/edited a symbol in other sheets, 
or deleted a sheet):
what is the actual meaning of "undo the annotation" in other sheets).

And ultimately:
What a undo (and therefore redo) command must undo:
1 - the latest change in the full schematic (global undo/redo)
  or
2 - the latest change in the currently edited (active) sheet (local undo/redo)

This is a choice, and the answer is for me not trivial.

It could be worth to know what is the option for global/local changes in a 
schematic hierarchy in
other schematic editors.

Multi-file text editors can undo the latest change only in the active file, not 
in all opened files.




___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Oliver Walters]

Wayne,

With this in mind, I am unsure how to determine (given a list of
components) which sheet they originate in.

I need a SCH_EDIT_FRAME* for each component, to work out where to push each
undo operation.

I have a list of SCH_REFERENCE objects, is there a way of determining where
each object originates? Could you point me in the right direction?

Regards,
Oliver

On Tue, Apr 18, 2017 at 6:30 AM, Wayne Stambaugh 
wrote:

> On 4/17/2017 4:18 PM, Oliver Walters wrote:
> > So how do we proceed here? Is there a 'global' undo stack? If not:
>
> Unfortunately there is no global undo stack.  Undo stacks are maintained
> for each unique SCH_SCREEN (schematic file) object.
>
> >
> > A) don't allow changes made in the component table viewer to be undone
> > B) Make an undo entry for each sheet that has changed symbols
> >
> > A) is easier but the user would need to quit-without-save to undo changes
>
> This is less than desirable
>
> >
> > B) is more difficult and doesn't solve the undo operations getting out
> > of order either, as the user could inject another operation on a given
> > sheet.
>
> This would be my preference.  Out of order operations are already an
> issue so this solution doesn't make that issue any worse.  Undo/redo is
> only available for the current sheet so the user would have to change
> sheets in order to undo anything changed in the component properties table.
>
> >
> > Suggestions?
> >
> > On 18 Apr 2017 01:26, "Wayne Stambaugh"  > > wrote:
> >
> > On 4/17/2017 10:21 AM, jp charras wrote:
> > > Le 17/04/2017 à 04:11, Oliver Walters a écrit :
> > >> JP, others,
> > >>
> > >> After further investigation, I have worked out why the components
> > with duplicated references were
> > >> displaying incorrectly.
> > >>
> > >> Patch_004 is attached, Thomas can you confirm that it fixes the
> > display for you?
> > >>
> > >> Kind Regards,
> > >> Oliver
> > >>
> > >> On Mon, Apr 17, 2017 at 7:53 AM, Oliver Walters
> > mailto:oliver.henry.walters@
> gmail.com>
> > >
> > > Good work, Oliver!
> > >
> > > I found 2 issues (tested on W7)
> > >
> > > 1 - m_reloadTableButton is not correctly enabled/disabled.
> > > This is due to the way events are managed, and this is OS
> dependent.
> > > To avoid this issue, enable/disable it inside a wxUpdateUIEvent
> > attached to this button.
> > >
> > > 2 - ESC key and ENTER keys do not dismiss the dialog.
> > > This is due to the fact you do not have a wxStdDialogButtonSizer,
> > and no OK and Cancel button.
> > > Please, add it and use the OK button (as usual in a dialog) to
> > transfer changes to schematic (do not
> > > use a wxCloseEvent to manage that), and obviously Cancel just
> > closes the dialog.
> > > To do this transfer, just  override TransferDataFromWindow(), that
> > is called by wxWidgets when
> > > closing a dialog by the OK button.
> > >
> > > About other things, undo/redo lists should manage only changes
> > made inside the corresponding sheet,
> > > not in other sheets, to avoid inconsistencies and therefore
> crashes.
> > >
> >
> > This is one of the reasons I've been reluctant to accept code that
> > attempts to change the state of a SCH_SCREEN object other than the
> > current SCH_SCREEN object.  It exposes a known flaw in our schematic
> > undo/redo design and I have yet to see anyone update the undo/redo
> > SCH_SCREEN stacks correctly.  I see the potential for serious issues
> if
> > you do not keep the undo/redo stacks properly synced.  Once you allow
> > the modification of information in the SCH_SCREEN object other than
> the
> > current one, you need to update the undo/redo stack for the
> appropriate
> > SCH_SCREEN object.  Otherwise, you wont be able to undo all of the
> > changes correctly.
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > 
> > Post to : kicad-developers@lists.launchpad.net
> > 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > 
> > More help   : https://help.launchpad.net/ListHelp
> > 
> >
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[jp charras]

Le 17/04/2017 à 22:51, Nox a écrit :
> I know that I already suggested that in another context but what about 
> changing the undo/redo
> semantic to the more common approach to maintain an global undo/redo stack 
> and switch the view
> accordingly? I know that the "per screen" is the established way in kicad and 
> that it is very
> dangerous to break existing workflows. But the undo/redo behaviour is 
> currently hardly
> "understandable" for beginners. E.g. why does the undo not follow my actions 
> but stays on one view?
> Why does exporting the netlist break the undo? Why can automatic annotation 
> not be reverted? The
> undo list wiped on a frequently basis that personally i hardly trust into the 
> undo functionality at
> all.
> 
> Would it be an option to introduce a "test version" of a global undo/redo to 
> get some feedback from
> the crowed which way would be preferred?
> 

For me, the problem is not to have a global or per screen undo/redo list, but 
what an user is
expecting when undoing/redoing a change.

We *always* expect to undo the last change.
Any undo/redo system has this behavior.

Now consider an editor (the schematic editor with 3 sheets for instance, but 
this is also the case
of text editors with 3 files opened and currently edited).

1 - in sheet1 you call a tool (component table editor, automatic annotation) 
which modify all sheets.

2 - after  that you enter sheet2 and make new changes then sheet3 and also make 
new changes.

3 - back to sheet1 and try to undelete the latest change in this sheet: this is 
the global change
(i.e. annotation). This is possible in sheet1.
But how can you undo this annotation in others sheets: this is not the latest 
change and cannot be
undone safely (you can have deleted/replaced/edited a symbol in other sheets, 
or deleted a sheet):
what is the actual meaning of "undo the annotation" in other sheets).

And ultimately:
What a undo (and therefore redo) command must undo:
1 - the latest change in the full schematic (global undo/redo)
 or
2 - the latest change in the currently edited (active) sheet (local undo/redo)

This is a choice, and the answer is for me not trivial.

It could be worth to know what is the option for global/local changes in a 
schematic hierarchy in
other schematic editors.

Multi-file text editors can undo the latest change only in the active file, not 
in all opened files.

-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Cirilo Bernardo]

The platform shouldn't matter; it's a question of making sure that strings are
handled correctly. What seems to have happened is that a UTF8 string was
handled as if it were an ASCII Latin-1 string; changing the default character
set will change the results. The challenge is working out what went wrong
and where and to ensure that as much as possible the results are consistent
regardless of the user's language encodings.  Consistency is possible in this
specific instance but not always since there is no 1:1 mapping of UTF8 to
extended ASCII.

- Cirilo

On Tue, Apr 18, 2017 at 3:16 AM, Oliver Walters
 wrote:
> Cirilo,
>
> Does this mean that the rendering is going to be platform dependent? Is
> there a way to enforce consistent rendering?
>
> On Tue, Apr 18, 2017 at 12:05 PM, Cirilo Bernardo
>  wrote:
>>
>> This is a UTF8 vs extended ASCII problem. In UTF8, micro is C2 B5;
>> in extended ASCII Latin-1, C2 is the circumflex capital A and B5 is micro.
>>
>> - Cirilo
>>
>>
>> On Fri, Apr 14, 2017 at 7:51 PM, Nick Østergaard 
>> wrote:
>> > Hmm, another small issue.
>> >
>> > When I have a part with a value of 10µ  in kicad it will render as
>> > 10µ in the html output (Big a-circumflex) It looks right in the csv.
>> >
>> > 2017-04-14 11:07 GMT+02:00 Nick Østergaard :
>> >> I can confirmthat the assert I reported is fixed with the second patch.
>> >>
>> >> 2017-04-13 23:40 GMT+02:00 Oliver Walters
>> >> :
>> >>> Just a friendly reminder about this, I haven't heard anything since
>> >>> attaching the correct patches.
>> >>>
>> >>> Cheers
>> >>>
>> >>> On 7 Apr 2017 19:27, "Oliver Walters" 
>> >>> wrote:
>> 
>>  I am very sorry about this, three mistakes in a row!
>> 
>>  It has been pointed out that I have attached the patches in the
>>  incorrect
>>  order.
>> 
>>  To prevent this I have attached a single patch for each commit. They
>>  are
>>  attached to this email (ignore previous patches) and should be
>>  applied in
>>  order _001 , _002.
>> 
>>  Sorry! :)
>> 
>>  On Sat, Apr 1, 2017 at 11:53 PM, Oliver Walters
>>   wrote:
>> >
>> > After a long break on this project I have finally rounded the edges
>> > off
>> > the component table viewer I have been working on.
>> >
>> > This is a table/spreadsheet view of all the components in the
>> > schematic,
>> > which allows bulk editing, grouping components, and exporting to
>> > CSV/TSV/HTML BOM.
>> >
>> > Here's some screenshots of it in action:
>> >
>> > http://imgur.com/gallery/WUwek
>> >
>> > I have tried to limit the complexity as far as possible, so that
>> > it's not
>> > too cumbersome for users.
>> >
>> > Any changes you make in the table are highlighted and can be
>> > reverted
>> > (back to the values in the schematic).
>> >
>> > When you close the view, all changes are pushed back to the
>> > schematic,
>> > and the bulk-edit is pushed to the undo-stack as a single item
>> > (meaning that
>> > you can easily undo all the changes you just made).
>> >
>> > Please let me know of any errors or edge cases!
>> >
>> > Patch has been rebased to latest master at time of this email.
>> >
>> > Cheers,
>> > Oliver
>> 
>> 
>> >>>
>> >>> ___
>> >>> Mailing list: https://launchpad.net/~kicad-developers
>> >>> Post to : kicad-developers@lists.launchpad.net
>> >>> Unsubscribe : https://launchpad.net/~kicad-developers
>> >>> More help   : https://help.launchpad.net/ListHelp
>> >>>
>> >
>> > ___
>> > Mailing list: https://launchpad.net/~kicad-developers
>> > Post to : kicad-developers@lists.launchpad.net
>> > Unsubscribe : https://launchpad.net/~kicad-developers
>> > More help   : https://help.launchpad.net/ListHelp
>
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Oliver Walters]

Cirilo,

Does this mean that the rendering is going to be platform dependent? Is
there a way to enforce consistent rendering?

On Tue, Apr 18, 2017 at 12:05 PM, Cirilo Bernardo  wrote:

> This is a UTF8 vs extended ASCII problem. In UTF8, micro is C2 B5;
> in extended ASCII Latin-1, C2 is the circumflex capital A and B5 is micro.
>
> - Cirilo
>
>
> On Fri, Apr 14, 2017 at 7:51 PM, Nick Østergaard 
> wrote:
> > Hmm, another small issue.
> >
> > When I have a part with a value of 10µ  in kicad it will render as
> > 10µ in the html output (Big a-circumflex) It looks right in the csv.
> >
> > 2017-04-14 11:07 GMT+02:00 Nick Østergaard :
> >> I can confirmthat the assert I reported is fixed with the second patch.
> >>
> >> 2017-04-13 23:40 GMT+02:00 Oliver Walters  com>:
> >>> Just a friendly reminder about this, I haven't heard anything since
> >>> attaching the correct patches.
> >>>
> >>> Cheers
> >>>
> >>> On 7 Apr 2017 19:27, "Oliver Walters" 
> >>> wrote:
> 
>  I am very sorry about this, three mistakes in a row!
> 
>  It has been pointed out that I have attached the patches in the
> incorrect
>  order.
> 
>  To prevent this I have attached a single patch for each commit. They
> are
>  attached to this email (ignore previous patches) and should be
> applied in
>  order _001 , _002.
> 
>  Sorry! :)
> 
>  On Sat, Apr 1, 2017 at 11:53 PM, Oliver Walters
>   wrote:
> >
> > After a long break on this project I have finally rounded the edges
> off
> > the component table viewer I have been working on.
> >
> > This is a table/spreadsheet view of all the components in the
> schematic,
> > which allows bulk editing, grouping components, and exporting to
> > CSV/TSV/HTML BOM.
> >
> > Here's some screenshots of it in action:
> >
> > http://imgur.com/gallery/WUwek
> >
> > I have tried to limit the complexity as far as possible, so that
> it's not
> > too cumbersome for users.
> >
> > Any changes you make in the table are highlighted and can be reverted
> > (back to the values in the schematic).
> >
> > When you close the view, all changes are pushed back to the
> schematic,
> > and the bulk-edit is pushed to the undo-stack as a single item
> (meaning that
> > you can easily undo all the changes you just made).
> >
> > Please let me know of any errors or edge cases!
> >
> > Patch has been rebased to latest master at time of this email.
> >
> > Cheers,
> > Oliver
> 
> 
> >>>
> >>> ___
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to : kicad-developers@lists.launchpad.net
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
> >>>
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Cirilo Bernardo]

This is a UTF8 vs extended ASCII problem. In UTF8, micro is C2 B5;
in extended ASCII Latin-1, C2 is the circumflex capital A and B5 is micro.

- Cirilo


On Fri, Apr 14, 2017 at 7:51 PM, Nick Østergaard  wrote:
> Hmm, another small issue.
>
> When I have a part with a value of 10µ  in kicad it will render as
> 10µ in the html output (Big a-circumflex) It looks right in the csv.
>
> 2017-04-14 11:07 GMT+02:00 Nick Østergaard :
>> I can confirmthat the assert I reported is fixed with the second patch.
>>
>> 2017-04-13 23:40 GMT+02:00 Oliver Walters :
>>> Just a friendly reminder about this, I haven't heard anything since
>>> attaching the correct patches.
>>>
>>> Cheers
>>>
>>> On 7 Apr 2017 19:27, "Oliver Walters" 
>>> wrote:

 I am very sorry about this, three mistakes in a row!

 It has been pointed out that I have attached the patches in the incorrect
 order.

 To prevent this I have attached a single patch for each commit. They are
 attached to this email (ignore previous patches) and should be applied in
 order _001 , _002.

 Sorry! :)

 On Sat, Apr 1, 2017 at 11:53 PM, Oliver Walters
  wrote:
>
> After a long break on this project I have finally rounded the edges off
> the component table viewer I have been working on.
>
> This is a table/spreadsheet view of all the components in the schematic,
> which allows bulk editing, grouping components, and exporting to
> CSV/TSV/HTML BOM.
>
> Here's some screenshots of it in action:
>
> http://imgur.com/gallery/WUwek
>
> I have tried to limit the complexity as far as possible, so that it's not
> too cumbersome for users.
>
> Any changes you make in the table are highlighted and can be reverted
> (back to the values in the schematic).
>
> When you close the view, all changes are pushed back to the schematic,
> and the bulk-edit is pushed to the undo-stack as a single item (meaning 
> that
> you can easily undo all the changes you just made).
>
> Please let me know of any errors or edge cases!
>
> Patch has been rebased to latest master at time of this email.
>
> Cheers,
> Oliver


>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Nox]

I know that I already suggested that in another context but what about 
changing the undo/redo semantic to the more common approach to maintain 
an global undo/redo stack and switch the view accordingly? I know that 
the "per screen" is the established way in kicad and that it is very 
dangerous to break existing workflows. But the undo/redo behaviour is 
currently hardly "understandable" for beginners. E.g. why does the undo 
not follow my actions but stays on one view? Why does exporting the 
netlist break the undo? Why can automatic annotation not be reverted? 
The undo list wiped on a frequently basis that personally i hardly trust 
into the undo functionality at all.


Would it be an option to introduce a "test version" of a global 
undo/redo to get some feedback from the crowed which way would be preferred?



Am 17.04.2017 um 22:30 schrieb Wayne Stambaugh:

On 4/17/2017 4:18 PM, Oliver Walters wrote:

So how do we proceed here? Is there a 'global' undo stack? If not:

Unfortunately there is no global undo stack.  Undo stacks are maintained
for each unique SCH_SCREEN (schematic file) object.


A) don't allow changes made in the component table viewer to be undone
B) Make an undo entry for each sheet that has changed symbols

A) is easier but the user would need to quit-without-save to undo changes

This is less than desirable


B) is more difficult and doesn't solve the undo operations getting out
of order either, as the user could inject another operation on a given
sheet.

This would be my preference.  Out of order operations are already an
issue so this solution doesn't make that issue any worse.  Undo/redo is
only available for the current sheet so the user would have to change
sheets in order to undo anything changed in the component properties table.


Suggestions?

On 18 Apr 2017 01:26, "Wayne Stambaugh" mailto:stambau...@gmail.com>> wrote:

 On 4/17/2017 10:21 AM, jp charras wrote:
 > Le 17/04/2017 à 04:11, Oliver Walters a écrit :
 >> JP, others,
 >>
 >> After further investigation, I have worked out why the components
 with duplicated references were
 >> displaying incorrectly.
 >>
 >> Patch_004 is attached, Thomas can you confirm that it fixes the
 display for you?
 >>
 >> Kind Regards,
 >> Oliver
 >>
 >> On Mon, Apr 17, 2017 at 7:53 AM, Oliver Walters
 mailto:oliver.henry.walt...@gmail.com>
 >
 > Good work, Oliver!
 >
 > I found 2 issues (tested on W7)
 >
 > 1 - m_reloadTableButton is not correctly enabled/disabled.
 > This is due to the way events are managed, and this is OS dependent.
 > To avoid this issue, enable/disable it inside a wxUpdateUIEvent
 attached to this button.
 >
 > 2 - ESC key and ENTER keys do not dismiss the dialog.
 > This is due to the fact you do not have a wxStdDialogButtonSizer,
 and no OK and Cancel button.
 > Please, add it and use the OK button (as usual in a dialog) to
 transfer changes to schematic (do not
 > use a wxCloseEvent to manage that), and obviously Cancel just
 closes the dialog.
 > To do this transfer, just  override TransferDataFromWindow(), that
 is called by wxWidgets when
 > closing a dialog by the OK button.
 >
 > About other things, undo/redo lists should manage only changes
 made inside the corresponding sheet,
 > not in other sheets, to avoid inconsistencies and therefore crashes.
 >

 This is one of the reasons I've been reluctant to accept code that
 attempts to change the state of a SCH_SCREEN object other than the
 current SCH_SCREEN object.  It exposes a known flaw in our schematic
 undo/redo design and I have yet to see anyone update the undo/redo
 SCH_SCREEN stacks correctly.  I see the potential for serious issues if
 you do not keep the undo/redo stacks properly synced.  Once you allow
 the modification of information in the SCH_SCREEN object other than the
 current one, you need to update the undo/redo stack for the appropriate
 SCH_SCREEN object.  Otherwise, you wont be able to undo all of the
 changes correctly.

 ___
 Mailing list: https://launchpad.net/~kicad-developers
 
 Post to : kicad-developers@lists.launchpad.net
 
 Unsubscribe : https://launchpad.net/~kicad-developers
 
 More help   : https://help.launchpad.net/ListHelp
 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



___
Mailing list: https://launchpad.net/~kicad-develop

Re: [Kicad-developers] [FEATURE] Component table viewer

[Wayne Stambaugh]

On 4/17/2017 4:18 PM, Oliver Walters wrote:
> So how do we proceed here? Is there a 'global' undo stack? If not:

Unfortunately there is no global undo stack.  Undo stacks are maintained
for each unique SCH_SCREEN (schematic file) object.

> 
> A) don't allow changes made in the component table viewer to be undone
> B) Make an undo entry for each sheet that has changed symbols
> 
> A) is easier but the user would need to quit-without-save to undo changes

This is less than desirable

> 
> B) is more difficult and doesn't solve the undo operations getting out
> of order either, as the user could inject another operation on a given
> sheet.

This would be my preference.  Out of order operations are already an
issue so this solution doesn't make that issue any worse.  Undo/redo is
only available for the current sheet so the user would have to change
sheets in order to undo anything changed in the component properties table.

> 
> Suggestions?
> 
> On 18 Apr 2017 01:26, "Wayne Stambaugh"  > wrote:
> 
> On 4/17/2017 10:21 AM, jp charras wrote:
> > Le 17/04/2017 à 04:11, Oliver Walters a écrit :
> >> JP, others,
> >>
> >> After further investigation, I have worked out why the components
> with duplicated references were
> >> displaying incorrectly.
> >>
> >> Patch_004 is attached, Thomas can you confirm that it fixes the
> display for you?
> >>
> >> Kind Regards,
> >> Oliver
> >>
> >> On Mon, Apr 17, 2017 at 7:53 AM, Oliver Walters
> mailto:oliver.henry.walt...@gmail.com>
> >
> > Good work, Oliver!
> >
> > I found 2 issues (tested on W7)
> >
> > 1 - m_reloadTableButton is not correctly enabled/disabled.
> > This is due to the way events are managed, and this is OS dependent.
> > To avoid this issue, enable/disable it inside a wxUpdateUIEvent
> attached to this button.
> >
> > 2 - ESC key and ENTER keys do not dismiss the dialog.
> > This is due to the fact you do not have a wxStdDialogButtonSizer,
> and no OK and Cancel button.
> > Please, add it and use the OK button (as usual in a dialog) to
> transfer changes to schematic (do not
> > use a wxCloseEvent to manage that), and obviously Cancel just
> closes the dialog.
> > To do this transfer, just  override TransferDataFromWindow(), that
> is called by wxWidgets when
> > closing a dialog by the OK button.
> >
> > About other things, undo/redo lists should manage only changes
> made inside the corresponding sheet,
> > not in other sheets, to avoid inconsistencies and therefore crashes.
> >
> 
> This is one of the reasons I've been reluctant to accept code that
> attempts to change the state of a SCH_SCREEN object other than the
> current SCH_SCREEN object.  It exposes a known flaw in our schematic
> undo/redo design and I have yet to see anyone update the undo/redo
> SCH_SCREEN stacks correctly.  I see the potential for serious issues if
> you do not keep the undo/redo stacks properly synced.  Once you allow
> the modification of information in the SCH_SCREEN object other than the
> current one, you need to update the undo/redo stack for the appropriate
> SCH_SCREEN object.  Otherwise, you wont be able to undo all of the
> changes correctly.
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Oliver Walters]

So how do we proceed here? Is there a 'global' undo stack? If not:

A) don't allow changes made in the component table viewer to be undone
B) Make an undo entry for each sheet that has changed symbols

A) is easier but the user would need to quit-without-save to undo changes

B) is more difficult and doesn't solve the undo operations getting out of
order either, as the user could inject another operation on a given sheet.

Suggestions?

On 18 Apr 2017 01:26, "Wayne Stambaugh"  wrote:

> On 4/17/2017 10:21 AM, jp charras wrote:
> > Le 17/04/2017 à 04:11, Oliver Walters a écrit :
> >> JP, others,
> >>
> >> After further investigation, I have worked out why the components with
> duplicated references were
> >> displaying incorrectly.
> >>
> >> Patch_004 is attached, Thomas can you confirm that it fixes the display
> for you?
> >>
> >> Kind Regards,
> >> Oliver
> >>
> >> On Mon, Apr 17, 2017 at 7:53 AM, Oliver Walters <
> oliver.henry.walt...@gmail.com
> >
> > Good work, Oliver!
> >
> > I found 2 issues (tested on W7)
> >
> > 1 - m_reloadTableButton is not correctly enabled/disabled.
> > This is due to the way events are managed, and this is OS dependent.
> > To avoid this issue, enable/disable it inside a wxUpdateUIEvent attached
> to this button.
> >
> > 2 - ESC key and ENTER keys do not dismiss the dialog.
> > This is due to the fact you do not have a wxStdDialogButtonSizer, and no
> OK and Cancel button.
> > Please, add it and use the OK button (as usual in a dialog) to transfer
> changes to schematic (do not
> > use a wxCloseEvent to manage that), and obviously Cancel just closes the
> dialog.
> > To do this transfer, just  override TransferDataFromWindow(), that is
> called by wxWidgets when
> > closing a dialog by the OK button.
> >
> > About other things, undo/redo lists should manage only changes made
> inside the corresponding sheet,
> > not in other sheets, to avoid inconsistencies and therefore crashes.
> >
>
> This is one of the reasons I've been reluctant to accept code that
> attempts to change the state of a SCH_SCREEN object other than the
> current SCH_SCREEN object.  It exposes a known flaw in our schematic
> undo/redo design and I have yet to see anyone update the undo/redo
> SCH_SCREEN stacks correctly.  I see the potential for serious issues if
> you do not keep the undo/redo stacks properly synced.  Once you allow
> the modification of information in the SCH_SCREEN object other than the
> current one, you need to update the undo/redo stack for the appropriate
> SCH_SCREEN object.  Otherwise, you wont be able to undo all of the
> changes correctly.
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Wayne Stambaugh]

On 4/17/2017 10:21 AM, jp charras wrote:
> Le 17/04/2017 à 04:11, Oliver Walters a écrit :
>> JP, others,
>>
>> After further investigation, I have worked out why the components with 
>> duplicated references were
>> displaying incorrectly.
>>
>> Patch_004 is attached, Thomas can you confirm that it fixes the display for 
>> you?
>>
>> Kind Regards,
>> Oliver
>>
>> On Mon, Apr 17, 2017 at 7:53 AM, Oliver Walters 
>>  
> Good work, Oliver!
> 
> I found 2 issues (tested on W7)
> 
> 1 - m_reloadTableButton is not correctly enabled/disabled.
> This is due to the way events are managed, and this is OS dependent.
> To avoid this issue, enable/disable it inside a wxUpdateUIEvent attached to 
> this button.
> 
> 2 - ESC key and ENTER keys do not dismiss the dialog.
> This is due to the fact you do not have a wxStdDialogButtonSizer, and no OK 
> and Cancel button.
> Please, add it and use the OK button (as usual in a dialog) to transfer 
> changes to schematic (do not
> use a wxCloseEvent to manage that), and obviously Cancel just closes the 
> dialog.
> To do this transfer, just  override TransferDataFromWindow(), that is called 
> by wxWidgets when
> closing a dialog by the OK button.
> 
> About other things, undo/redo lists should manage only changes made inside 
> the corresponding sheet,
> not in other sheets, to avoid inconsistencies and therefore crashes.
> 

This is one of the reasons I've been reluctant to accept code that
attempts to change the state of a SCH_SCREEN object other than the
current SCH_SCREEN object.  It exposes a known flaw in our schematic
undo/redo design and I have yet to see anyone update the undo/redo
SCH_SCREEN stacks correctly.  I see the potential for serious issues if
you do not keep the undo/redo stacks properly synced.  Once you allow
the modification of information in the SCH_SCREEN object other than the
current one, you need to update the undo/redo stack for the appropriate
SCH_SCREEN object.  Otherwise, you wont be able to undo all of the
changes correctly.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[jp charras]

Le 17/04/2017 à 04:11, Oliver Walters a écrit :
> JP, others,
> 
> After further investigation, I have worked out why the components with 
> duplicated references were
> displaying incorrectly.
> 
> Patch_004 is attached, Thomas can you confirm that it fixes the display for 
> you?
> 
> Kind Regards,
> Oliver
> 
> On Mon, Apr 17, 2017 at 7:53 AM, Oliver Walters 
> https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Thomas Pointhuber]

Hi Oliver,

I can confirm the issue is now fixed.


Some other issues found:

* Please update all duplicated references when someone changes a value,
to show that more than one reference was updated by this edit (as
already done for group edit).

* undo/redo operation of symbols update by your tool only works on the
sheet you started the component table view, and only for changed
components which were placed on that sheet.


From my side, I don't see any merge blocker. All remaining issues I
found could be addressed later.

Regards, Thomas


Am 2017-04-17 um 04:11 schrieb Oliver Walters:
> JP, others,
>
> After further investigation, I have worked out why the components with
> duplicated references were displaying incorrectly.
>
> Patch_004 is attached, Thomas can you confirm that it fixes the
> display for you?
>
> Kind Regards,
> Oliver
>
> On Mon, Apr 17, 2017 at 7:53 AM, Oliver Walters
>  > wrote:
>
> JP,
>
> Thanks for the feedback.
>
> In the component table, multi-unit symbols are "compressed" into a
> single entry. Change a field value for one and it will change for
> all units of that symbol. 
>
> For "duplicate" references, perhaps the best approach is to only
> allow a certain reference to be added once to the table?
>
> However this does not represent the true state of the schematic -
> component count would be incorrect, for one.
>
> Any suggestions?
>
> On 17 Apr 2017 00:31, "jp charras"  > wrote:
>
> Le 16/04/2017 à 15:12, Oliver Walters a écrit :
> > It's not KiCad that "knows" to exclude testing points, etc -
> my Python BOM script has a series of
> > regex filters that remove a whole swathe of virtual components.
> >
> > Sometimes you actually want test points to be in the BoM
> e.g. for loading probe hooks onto the board.
> >
> > Eventually I want to add such filtering to this tool but I'd
> rather have the first round merged
> > first before the feature set becomes too complicated.
> >
> > Can someone with intimate knowledge provide some info on how
> components in sheets that are
> > referenced multiple times should be annotated in the BOM? I
> feel that sending a BOM with duplicate
> > references is wrong...
> >
>
> See const wxString GetRef( const SCH_SHEET_PATH* sheet ) in
> sch_component.h
>
> The field F0 is not really the reference. It is the reference
> current displayed on the screen.
> It is the reference only for simple hierarchies, because there
> is only one reference by symbol.
>
> Complex hierarchies (i.e. having more than one instance of a
> given sheet) are always tricky to handle.
> Especially, because the same component is shared by all
> instances, only the reference is specific to
> each instance.
> By definition, all other fields are shared.
> Therefore you cannot set for instance the value field (or the
> footprint name field) of shared
> components with different texts.
> If a field is modified, it must be also modified in all rows
> linked to this shared component in your
> Component table viewer, which shows components as a flattened
> schematic (like in a netlist).
> (Perhaps all references of this shared component should be
> displayed in the same row)
>
> Components with multiple unites by package are also a bit
> tricky to manage.
>
> Complex hierarchies having components with multiple unites by
> package are *especially* tricky.
>
> --
> Jean-Pierre CHARRAS
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 
>
>
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Oliver Walters]

JP, others,

After further investigation, I have worked out why the components with
duplicated references were displaying incorrectly.

Patch_004 is attached, Thomas can you confirm that it fixes the display for
you?

Kind Regards,
Oliver

On Mon, Apr 17, 2017 at 7:53 AM, Oliver Walters <
oliver.henry.walt...@gmail.com> wrote:

> JP,
>
> Thanks for the feedback.
>
> In the component table, multi-unit symbols are "compressed" into a single
> entry. Change a field value for one and it will change for all units of
> that symbol.
>
> For "duplicate" references, perhaps the best approach is to only allow a
> certain reference to be added once to the table?
>
> However this does not represent the true state of the schematic -
> component count would be incorrect, for one.
>
> Any suggestions?
>
> On 17 Apr 2017 00:31, "jp charras"  wrote:
>
> Le 16/04/2017 à 15:12, Oliver Walters a écrit :
> > It's not KiCad that "knows" to exclude testing points, etc - my Python
> BOM script has a series of
> > regex filters that remove a whole swathe of virtual components.
> >
> > Sometimes you actually want test points to be in the BoM e.g. for
> loading probe hooks onto the board.
> >
> > Eventually I want to add such filtering to this tool but I'd rather have
> the first round merged
> > first before the feature set becomes too complicated.
> >
> > Can someone with intimate knowledge provide some info on how components
> in sheets that are
> > referenced multiple times should be annotated in the BOM? I feel that
> sending a BOM with duplicate
> > references is wrong...
> >
>
> See const wxString GetRef( const SCH_SHEET_PATH* sheet ) in sch_component.h
>
> The field F0 is not really the reference. It is the reference current
> displayed on the screen.
> It is the reference only for simple hierarchies, because there is only one
> reference by symbol.
>
> Complex hierarchies (i.e. having more than one instance of a given sheet)
> are always tricky to handle.
> Especially, because the same component is shared by all instances, only
> the reference is specific to
> each instance.
> By definition, all other fields are shared.
> Therefore you cannot set for instance the value field (or the footprint
> name field) of shared
> components with different texts.
> If a field is modified, it must be also modified in all rows linked to
> this shared component in your
> Component table viewer, which shows components as a flattened schematic
> (like in a netlist).
> (Perhaps all references of this shared component should be displayed in
> the same row)
>
> Components with multiple unites by package are also a bit tricky to manage.
>
> Complex hierarchies having components with multiple unites by package are
> *especially* tricky.
>
> --
> Jean-Pierre CHARRAS
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
>
From f1f954cc80992bc095849a2ddc6cc3bffad4f417 Mon Sep 17 00:00:00 2001
From: Oliver Walters 
Date: Mon, 17 Apr 2017 12:08:21 +1000
Subject: [PATCH] Fixed display of references for duplicate sheets

Display part reference rather than REFERENCE field value
---
 eeschema/bom_table_model.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eeschema/bom_table_model.cpp b/eeschema/bom_table_model.cpp
index a43d749..5301e95 100644
--- a/eeschema/bom_table_model.cpp
+++ b/eeschema/bom_table_model.cpp
@@ -456,7 +456,7 @@ bool BOM_TABLE_COMPONENT::AddUnit( SCH_REFERENCE aUnit )
 }
 break;
 case BOM_COL_ID_REFERENCE:
-value = cmp->GetField( REFERENCE )->GetText();
+value = aUnit.GetRef();
 break;
 case BOM_COL_ID_VALUE:
 value = cmp->GetField( VALUE )->GetText();
-- 
2.7.4

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Oliver Walters]

JP,

Thanks for the feedback.

In the component table, multi-unit symbols are "compressed" into a single
entry. Change a field value for one and it will change for all units of
that symbol.

For "duplicate" references, perhaps the best approach is to only allow a
certain reference to be added once to the table?

However this does not represent the true state of the schematic - component
count would be incorrect, for one.

Any suggestions?

On 17 Apr 2017 00:31, "jp charras"  wrote:

Le 16/04/2017 à 15:12, Oliver Walters a écrit :
> It's not KiCad that "knows" to exclude testing points, etc - my Python
BOM script has a series of
> regex filters that remove a whole swathe of virtual components.
>
> Sometimes you actually want test points to be in the BoM e.g. for loading
probe hooks onto the board.
>
> Eventually I want to add such filtering to this tool but I'd rather have
the first round merged
> first before the feature set becomes too complicated.
>
> Can someone with intimate knowledge provide some info on how components
in sheets that are
> referenced multiple times should be annotated in the BOM? I feel that
sending a BOM with duplicate
> references is wrong...
>

See const wxString GetRef( const SCH_SHEET_PATH* sheet ) in sch_component.h

The field F0 is not really the reference. It is the reference current
displayed on the screen.
It is the reference only for simple hierarchies, because there is only one
reference by symbol.

Complex hierarchies (i.e. having more than one instance of a given sheet)
are always tricky to handle.
Especially, because the same component is shared by all instances, only the
reference is specific to
each instance.
By definition, all other fields are shared.
Therefore you cannot set for instance the value field (or the footprint
name field) of shared
components with different texts.
If a field is modified, it must be also modified in all rows linked to this
shared component in your
Component table viewer, which shows components as a flattened schematic
(like in a netlist).
(Perhaps all references of this shared component should be displayed in the
same row)

Components with multiple unites by package are also a bit tricky to manage.

Complex hierarchies having components with multiple unites by package are
*especially* tricky.

--
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[jp charras]

Le 16/04/2017 à 15:12, Oliver Walters a écrit :
> It's not KiCad that "knows" to exclude testing points, etc - my Python BOM 
> script has a series of
> regex filters that remove a whole swathe of virtual components.
> 
> Sometimes you actually want test points to be in the BoM e.g. for loading 
> probe hooks onto the board.
> 
> Eventually I want to add such filtering to this tool but I'd rather have the 
> first round merged
> first before the feature set becomes too complicated. 
> 
> Can someone with intimate knowledge provide some info on how components in 
> sheets that are
> referenced multiple times should be annotated in the BOM? I feel that sending 
> a BOM with duplicate
> references is wrong...
> 

See const wxString GetRef( const SCH_SHEET_PATH* sheet ) in sch_component.h

The field F0 is not really the reference. It is the reference current displayed 
on the screen.
It is the reference only for simple hierarchies, because there is only one 
reference by symbol.

Complex hierarchies (i.e. having more than one instance of a given sheet) are 
always tricky to handle.
Especially, because the same component is shared by all instances, only the 
reference is specific to
each instance.
By definition, all other fields are shared.
Therefore you cannot set for instance the value field (or the footprint name 
field) of shared
components with different texts.
If a field is modified, it must be also modified in all rows linked to this 
shared component in your
Component table viewer, which shows components as a flattened schematic (like 
in a netlist).
(Perhaps all references of this shared component should be displayed in the 
same row)

Components with multiple unites by package are also a bit tricky to manage.

Complex hierarchies having components with multiple unites by package are 
*especially* tricky.

-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Oliver Walters]

Thomas, et al,

I have attached _003 patch which now ensures that the "Save" button is
activated when you make changes in the table.

Please apply this on top of the other two and let me know if it fixes that
issue.

Thanks,
Oliver

On Sat, Apr 15, 2017 at 9:33 PM, Thomas Pointhuber  wrote:

> Hi Oliver,
>
> nice work, and I hope it get merged into master soon.
>
> Some issues I found so far (using your github branch):
>
> * References are not displayed correctly when using duplicated
> subschematics.
> * Search functionality (using Ctrl+F) does not work with collapsed
> grouped references
> * Even when the dialog says "Save and Close", it actually only writes
> the changes to the schematic. When you close the schematic you don't get
> a notification to save your work, as well as you are not able to click
> the save button when your only change was adjusting names of footprints
> using the component table viewer.
>
> Regards, Thomas
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
From 6cef9ed2702e12b9aadbbdfc7228155f1befb875 Mon Sep 17 00:00:00 2001
From: Oliver Walters 
Date: Sun, 16 Apr 2017 16:43:59 +1000
Subject: [PATCH] Mark schematic as dirty

Notify schematic of changes when window is closed
---
 eeschema/dialogs/dialog_bom_editor.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/eeschema/dialogs/dialog_bom_editor.cpp b/eeschema/dialogs/dialog_bom_editor.cpp
index 12f77c6..f4b73b4 100644
--- a/eeschema/dialogs/dialog_bom_editor.cpp
+++ b/eeschema/dialogs/dialog_bom_editor.cpp
@@ -153,6 +153,8 @@ void DIALOG_BOM_EDITOR::OnBomEditorClosed( wxCloseEvent& event )
 m_bom->ApplyFieldChanges();
 m_parent->Refresh();
 }
+
+m_parent->OnModify();
 }
 
 Destroy();
-- 
2.7.4

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Oliver Walters]

On Fri, Apr 14, 2017 at 7:51 PM, Nick Østergaard  wrote:

> Hmm, another small issue.
>
> When I have a part with a value of 10µ  in kicad it will render as
> 10µ in the html output (Big a-circumflex) It looks right in the csv.
>

I do not see this - http://i.imgur.com/iQ6jKBB.png

What OS are you running?


>
> 2017-04-14 11:07 GMT+02:00 Nick Østergaard :
> > I can confirmthat the assert I reported is fixed with the second patch.
> >
> > 2017-04-13 23:40 GMT+02:00 Oliver Walters  com>:
> >> Just a friendly reminder about this, I haven't heard anything since
> >> attaching the correct patches.
> >>
> >> Cheers
> >>
> >> On 7 Apr 2017 19:27, "Oliver Walters" 
> >> wrote:
> >>>
> >>> I am very sorry about this, three mistakes in a row!
> >>>
> >>> It has been pointed out that I have attached the patches in the
> incorrect
> >>> order.
> >>>
> >>> To prevent this I have attached a single patch for each commit. They
> are
> >>> attached to this email (ignore previous patches) and should be applied
> in
> >>> order _001 , _002.
> >>>
> >>> Sorry! :)
> >>>
> >>> On Sat, Apr 1, 2017 at 11:53 PM, Oliver Walters
> >>>  wrote:
> 
>  After a long break on this project I have finally rounded the edges
> off
>  the component table viewer I have been working on.
> 
>  This is a table/spreadsheet view of all the components in the
> schematic,
>  which allows bulk editing, grouping components, and exporting to
>  CSV/TSV/HTML BOM.
> 
>  Here's some screenshots of it in action:
> 
>  http://imgur.com/gallery/WUwek
> 
>  I have tried to limit the complexity as far as possible, so that it's
> not
>  too cumbersome for users.
> 
>  Any changes you make in the table are highlighted and can be reverted
>  (back to the values in the schematic).
> 
>  When you close the view, all changes are pushed back to the schematic,
>  and the bulk-edit is pushed to the undo-stack as a single item
> (meaning that
>  you can easily undo all the changes you just made).
> 
>  Please let me know of any errors or edge cases!
> 
>  Patch has been rebased to latest master at time of this email.
> 
>  Cheers,
>  Oliver
> >>>
> >>>
> >>
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to : kicad-developers@lists.launchpad.net
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> >>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Oliver Walters]

Thomas,

References are not displayed correctly when using duplicated
> subschematics.


Can you provide some more information? What is a duplicated subschematic?
What does an incorrectly displayed reference look like?

 Search functionality (using Ctrl+F) does not work with collapsed
> grouped references


I didn't even know there was a search function.


>  Even when the dialog says "Save and Close", it actually only writes
> the changes to the schematic. When you close the schematic you don't get
> a notification to save your work, as well as you are not able to click
> the save button when your only change was adjusting names of footprints
> using the component table viewer.


It sounds like the changes are not marking the schematic as "dirty". Can
someone with more knowledge than me in this area please point me to how I
would dirtify the schematic?

Cheers,
Oliver

On Sat, Apr 15, 2017 at 9:33 PM, Thomas Pointhuber  wrote:

> Hi Oliver,
>
> nice work, and I hope it get merged into master soon.
>
> Some issues I found so far (using your github branch):
>
> * References are not displayed correctly when using duplicated
> subschematics.
> * Search functionality (using Ctrl+F) does not work with collapsed
> grouped references
> * Even when the dialog says "Save and Close", it actually only writes
> the changes to the schematic. When you close the schematic you don't get
> a notification to save your work, as well as you are not able to click
> the save button when your only change was adjusting names of footprints
> using the component table viewer.
>
> Regards, Thomas
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Thomas Pointhuber]

Hi Oliver,

nice work, and I hope it get merged into master soon.

Some issues I found so far (using your github branch):

* References are not displayed correctly when using duplicated
subschematics.
* Search functionality (using Ctrl+F) does not work with collapsed
grouped references
* Even when the dialog says "Save and Close", it actually only writes
the changes to the schematic. When you close the schematic you don't get
a notification to save your work, as well as you are not able to click
the save button when your only change was adjusting names of footprints
using the component table viewer.

Regards, Thomas



signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Nick Østergaard]

Hmm, another small issue.

When I have a part with a value of 10µ  in kicad it will render as
10µ in the html output (Big a-circumflex) It looks right in the csv.

2017-04-14 11:07 GMT+02:00 Nick Østergaard :
> I can confirmthat the assert I reported is fixed with the second patch.
>
> 2017-04-13 23:40 GMT+02:00 Oliver Walters :
>> Just a friendly reminder about this, I haven't heard anything since
>> attaching the correct patches.
>>
>> Cheers
>>
>> On 7 Apr 2017 19:27, "Oliver Walters" 
>> wrote:
>>>
>>> I am very sorry about this, three mistakes in a row!
>>>
>>> It has been pointed out that I have attached the patches in the incorrect
>>> order.
>>>
>>> To prevent this I have attached a single patch for each commit. They are
>>> attached to this email (ignore previous patches) and should be applied in
>>> order _001 , _002.
>>>
>>> Sorry! :)
>>>
>>> On Sat, Apr 1, 2017 at 11:53 PM, Oliver Walters
>>>  wrote:

 After a long break on this project I have finally rounded the edges off
 the component table viewer I have been working on.

 This is a table/spreadsheet view of all the components in the schematic,
 which allows bulk editing, grouping components, and exporting to
 CSV/TSV/HTML BOM.

 Here's some screenshots of it in action:

 http://imgur.com/gallery/WUwek

 I have tried to limit the complexity as far as possible, so that it's not
 too cumbersome for users.

 Any changes you make in the table are highlighted and can be reverted
 (back to the values in the schematic).

 When you close the view, all changes are pushed back to the schematic,
 and the bulk-edit is pushed to the undo-stack as a single item (meaning 
 that
 you can easily undo all the changes you just made).

 Please let me know of any errors or edge cases!

 Patch has been rebased to latest master at time of this email.

 Cheers,
 Oliver
>>>
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Nick Østergaard]

I can confirmthat the assert I reported is fixed with the second patch.

2017-04-13 23:40 GMT+02:00 Oliver Walters :
> Just a friendly reminder about this, I haven't heard anything since
> attaching the correct patches.
>
> Cheers
>
> On 7 Apr 2017 19:27, "Oliver Walters" 
> wrote:
>>
>> I am very sorry about this, three mistakes in a row!
>>
>> It has been pointed out that I have attached the patches in the incorrect
>> order.
>>
>> To prevent this I have attached a single patch for each commit. They are
>> attached to this email (ignore previous patches) and should be applied in
>> order _001 , _002.
>>
>> Sorry! :)
>>
>> On Sat, Apr 1, 2017 at 11:53 PM, Oliver Walters
>>  wrote:
>>>
>>> After a long break on this project I have finally rounded the edges off
>>> the component table viewer I have been working on.
>>>
>>> This is a table/spreadsheet view of all the components in the schematic,
>>> which allows bulk editing, grouping components, and exporting to
>>> CSV/TSV/HTML BOM.
>>>
>>> Here's some screenshots of it in action:
>>>
>>> http://imgur.com/gallery/WUwek
>>>
>>> I have tried to limit the complexity as far as possible, so that it's not
>>> too cumbersome for users.
>>>
>>> Any changes you make in the table are highlighted and can be reverted
>>> (back to the values in the schematic).
>>>
>>> When you close the view, all changes are pushed back to the schematic,
>>> and the bulk-edit is pushed to the undo-stack as a single item (meaning that
>>> you can easily undo all the changes you just made).
>>>
>>> Please let me know of any errors or edge cases!
>>>
>>> Patch has been rebased to latest master at time of this email.
>>>
>>> Cheers,
>>> Oliver
>>
>>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Oliver Walters]

Just a friendly reminder about this, I haven't heard anything since
attaching the correct patches.

Cheers

On 7 Apr 2017 19:27, "Oliver Walters" 
wrote:

> I am very sorry about this, three mistakes in a row!
>
> It has been pointed out that I have attached the patches in the incorrect
> order.
>
> To prevent this I have attached a single patch for each commit. They are
> attached to this email (ignore previous patches) and should be applied in
> order _001 , _002.
>
> Sorry! :)
>
> On Sat, Apr 1, 2017 at 11:53 PM, Oliver Walters <
> oliver.henry.walt...@gmail.com> wrote:
>
>> After a long break on this project I have finally rounded the edges off
>> the component table viewer I have been working on.
>>
>> This is a table/spreadsheet view of all the components in the schematic,
>> which allows bulk editing, grouping components, and exporting to
>> CSV/TSV/HTML BOM.
>>
>> Here's some screenshots of it in action:
>>
>> http://imgur.com/gallery/WUwek
>>
>> I have tried to limit the complexity as far as possible, so that it's not
>> too cumbersome for users.
>>
>> Any changes you make in the table are highlighted and can be reverted
>> (back to the values in the schematic).
>>
>> When you close the view, all changes are pushed back to the schematic,
>> and the bulk-edit is pushed to the undo-stack as a single item (meaning
>> that you can easily undo all the changes you just made).
>>
>> Please let me know of any errors or edge cases!
>>
>> Patch has been rebased to latest master at time of this email.
>>
>> Cheers,
>> Oliver
>>
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Nick Østergaard]

I get the attached assert on linux in a debug build.

/usr/include/wx-3.0/wx/strvararg.h(456): assert "(argtype &
(wxFormatStringSpecifier::value)) == argtype" failed in
wxArgNormalizer(): format specifier doesn't match argument type

It seems to work quite good, but I wonder who one is actually supposed
to apply the changes.

If I try to close the component table dialog it asks me to save and
exit, exit without save or cancel.

2017-04-02 15:38 GMT+02:00 Oliver Walters :
> Please find attached a fixed patch. I have just applied this exact match to
> master and built on Windows.
>
> Hopefully better luck this time :)
>
> On Sun, Apr 2, 2017 at 6:15 AM, Oliver Walters
>  wrote:
>>
>> Oh, that's embarrassing, it appear that I have attached the inverse of the
>> patch!
>>
>> I'll send a new patch later today - sorry!
>>
>>
>>
>> On Sun, Apr 2, 2017 at 1:15 AM, jp charras  wrote:
>>>
>>> Le 01/04/2017 à 14:53, Oliver Walters a écrit :
>>> > After a long break on this project I have finally rounded the edges off
>>> > the component table viewer I
>>> > have been working on.
>>> >
>>> > This is a table/spreadsheet view of all the components in the
>>> > schematic, which allows bulk editing,
>>> > grouping components, and exporting to CSV/TSV/HTML BOM.
>>> >
>>> > Here's some screenshots of it in action:
>>> >
>>> > http://imgur.com/gallery/WUwek
>>> >
>>> > I have tried to limit the complexity as far as possible, so that it's
>>> > not too cumbersome for users.
>>> >
>>> > Any changes you make in the table are highlighted and can be reverted
>>> > (back to the values in the
>>> > schematic).
>>> >
>>> > When you close the view, all changes are pushed back to the schematic,
>>> > and the bulk-edit is pushed
>>> > to the undo-stack as a single item (meaning that you can easily undo
>>> > all the changes you just made).
>>> >
>>> > Please let me know of any errors or edge cases!
>>> >
>>> > Patch has been rebased to latest master at time of this email.
>>> >
>>> > Cheers,
>>> > Oliver
>>> >
>>>
>>> Thanks Oliver.
>>>
>>> But are you sure this is the right patch?
>>> It looks like it remove many code, but does not add something.
>>>
>>>
>>> --
>>> Jean-Pierre CHARRAS
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
ASSERT INFO:
/usr/include/wx-3.0/wx/strvararg.h(456): assert "(argtype & 
(wxFormatStringSpecifier::value)) == argtype" failed in wxArgNormalizer(): 
format specifier doesn't match argument type

BACKTRACE:
[1] wxString wxString::Format(wxFormatString 
const&, wxString, unsigned long, wxString)
[2] wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, 
wxEvent&) const
[3] wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, 
wxEvtHandler*, wxEvent&)
[4] wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*)
[5] wxEvtHandler::TryHereOnly(wxEvent&)
[6] wxEvtHandler::DoTryChain(wxEvent&)
[7] wxEvtHandler::ProcessEvent(wxEvent&)
[8] wxWindowBase::TryAfter(wxEvent&)
[9] wxAuiToolBar::OnLeftUp(wxMouseEvent&)
[10] wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, 
wxEvent&) const
[11] wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, 
wxEvtHandler*, wxEvent&)
[12] wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*)
[13] wxEvtHandler::TryHereOnly(wxEvent&)
[14] wxEvtHandler::ProcessEventLocally(wxEvent&)
[15] wxEvtHandler::ProcessEvent(wxEvent&)
[16] wxEvtHandler::SafelyProcessEvent(wxEvent&)
[17] g_closure_invoke
[18] g_signal_emit_valist
[19] g_signal_emit
[20] gtk_propagate_event
[21] gtk_main_do_event
[22] g_main_context_dispatch
[23] g_main_loop_run
[24] gtk_main
[25] wxGUIEventLoop::DoRun()
[26] wxEventLoopBase::Run()
[27] wxAppConsoleBase::MainLoop()
[28] APP_KICAD::OnRun() /home/nickoe/kicad-git/kicad/kicad.cpp:256
[29] wxEntry(int&, wchar_t**)
[30] main /home/nickoe/kicad-git/kicad/kicad.cpp:288
[31] __libc_start_main
[32] _start
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Oliver Walters]

Oh, that's embarrassing, it appear that I have attached the inverse of the
patch!

I'll send a new patch later today - sorry!


On Sun, Apr 2, 2017 at 1:15 AM, jp charras  wrote:

> Le 01/04/2017 à 14:53, Oliver Walters a écrit :
> > After a long break on this project I have finally rounded the edges off
> the component table viewer I
> > have been working on.
> >
> > This is a table/spreadsheet view of all the components in the schematic,
> which allows bulk editing,
> > grouping components, and exporting to CSV/TSV/HTML BOM.
> >
> > Here's some screenshots of it in action:
> >
> > http://imgur.com/gallery/WUwek
> >
> > I have tried to limit the complexity as far as possible, so that it's
> not too cumbersome for users.
> >
> > Any changes you make in the table are highlighted and can be reverted
> (back to the values in the
> > schematic).
> >
> > When you close the view, all changes are pushed back to the schematic,
> and the bulk-edit is pushed
> > to the undo-stack as a single item (meaning that you can easily undo all
> the changes you just made).
> >
> > Please let me know of any errors or edge cases!
> >
> > Patch has been rebased to latest master at time of this email.
> >
> > Cheers,
> > Oliver
> >
>
> Thanks Oliver.
>
> But are you sure this is the right patch?
> It looks like it remove many code, but does not add something.
>
>
> --
> Jean-Pierre CHARRAS
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[jp charras]

Le 01/04/2017 à 14:53, Oliver Walters a écrit :
> After a long break on this project I have finally rounded the edges off the 
> component table viewer I
> have been working on.
> 
> This is a table/spreadsheet view of all the components in the schematic, 
> which allows bulk editing,
> grouping components, and exporting to CSV/TSV/HTML BOM.
> 
> Here's some screenshots of it in action:
> 
> http://imgur.com/gallery/WUwek
> 
> I have tried to limit the complexity as far as possible, so that it's not too 
> cumbersome for users.
> 
> Any changes you make in the table are highlighted and can be reverted (back 
> to the values in the
> schematic).
> 
> When you close the view, all changes are pushed back to the schematic, and 
> the bulk-edit is pushed
> to the undo-stack as a single item (meaning that you can easily undo all the 
> changes you just made).
> 
> Please let me know of any errors or edge cases!
> 
> Patch has been rebased to latest master at time of this email.
> 
> Cheers,
> Oliver
> 

Thanks Oliver.

But are you sure this is the right patch?
It looks like it remove many code, but does not add something.


-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Eldar Khayrullin]

Yes. It is convenient thing

В Суббота, 1 апр. 2017 в 3:53 , Oliver Walters 
 написал:
After a long break on this project I have finally rounded the edges 
off the component table viewer I have been working on.


This is a table/spreadsheet view of all the components in the 
schematic, which allows bulk editing, grouping components, and 
exporting to CSV/TSV/HTML BOM.


Here's some screenshots of it in action:

http://imgur.com/gallery/WUwek

I have tried to limit the complexity as far as possible, so that it's 
not too cumbersome for users.


Any changes you make in the table are highlighted and can be reverted 
(back to the values in the schematic).


When you close the view, all changes are pushed back to the 
schematic, and the bulk-edit is pushed to the undo-stack as a single 
item (meaning that you can easily undo all the changes you just made).


Please let me know of any errors or edge cases!

Patch has been rebased to latest master at time of this email.

Cheers,
Oliver
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Chris Pavlina]

OMG YES.

I won't get to test this for a while, but...YES :)

On Apr 1, 2017 08:53, "Oliver Walters" 
wrote:

> After a long break on this project I have finally rounded the edges off
> the component table viewer I have been working on.
>
> This is a table/spreadsheet view of all the components in the schematic,
> which allows bulk editing, grouping components, and exporting to
> CSV/TSV/HTML BOM.
>
> Here's some screenshots of it in action:
>
> http://imgur.com/gallery/WUwek
>
> I have tried to limit the complexity as far as possible, so that it's not
> too cumbersome for users.
>
> Any changes you make in the table are highlighted and can be reverted
> (back to the values in the schematic).
>
> When you close the view, all changes are pushed back to the schematic, and
> the bulk-edit is pushed to the undo-stack as a single item (meaning that
> you can easily undo all the changes you just made).
>
> Please let me know of any errors or edge cases!
>
> Patch has been rebased to latest master at time of this email.
>
> Cheers,
> Oliver
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp