Re: [Kicad-developers] [PATCH] Add KICAD_INSTALL_DEMOS CMake option

[Wayne Stambaugh]

@Nick, good catch!

@Jose: please update the Documentation/development/compiling.md document
with your proposed option and resubmit your patch.

On 9/8/2016 1:28 PM, Nick Østergaard wrote:
> The proposed patch does not document the option in the devdocs.
> 
> 2016-09-08 19:15 GMT+02:00 Wayne Stambaugh :
>> Anyone object to this?  I don't really have an opinion one way or the
>> other since it defaults to the current behavior.  I guess there is a
>> reason not to install the demos.  What's one more option at this point. ;)
>>
>> On 9/8/2016 3:04 AM, José Ignacio Romero wrote:
>>>
>>> It is ON by default, determines wether to install the bundled demos
>>> and examples.
>>> ---
>>>  CMakeLists.txt | 6 ++
>>>  1 file changed, 6 insertions(+)
>>>
>>>
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Add KICAD_INSTALL_DEMOS CMake option

[Simon Wells]

As this doesn't affect the program at all, and on some platforms it
will be installed seperately anyway i don't think there is any point
not having this option

On Fri, Sep 9, 2016 at 5:15 AM, Wayne Stambaugh  wrote:
> Anyone object to this?  I don't really have an opinion one way or the
> other since it defaults to the current behavior.  I guess there is a
> reason not to install the demos.  What's one more option at this point. ;)
>
> On 9/8/2016 3:04 AM, José Ignacio Romero wrote:
>>
>> It is ON by default, determines wether to install the bundled demos
>> and examples.
>> ---
>>  CMakeLists.txt | 6 ++
>>  1 file changed, 6 insertions(+)
>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Add KICAD_INSTALL_DEMOS CMake option

[Nick Østergaard]

The proposed patch does not document the option in the devdocs.

2016-09-08 19:15 GMT+02:00 Wayne Stambaugh :
> Anyone object to this?  I don't really have an opinion one way or the
> other since it defaults to the current behavior.  I guess there is a
> reason not to install the demos.  What's one more option at this point. ;)
>
> On 9/8/2016 3:04 AM, José Ignacio Romero wrote:
>>
>> It is ON by default, determines wether to install the bundled demos
>> and examples.
>> ---
>>  CMakeLists.txt | 6 ++
>>  1 file changed, 6 insertions(+)
>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Add KICAD_INSTALL_DEMOS CMake option

[Wayne Stambaugh]

Anyone object to this?  I don't really have an opinion one way or the
other since it defaults to the current behavior.  I guess there is a
reason not to install the demos.  What's one more option at this point. ;)

On 9/8/2016 3:04 AM, José Ignacio Romero wrote:
> 
> It is ON by default, determines wether to install the bundled demos
> and examples.
> ---
>  CMakeLists.txt | 6 ++
>  1 file changed, 6 insertions(+)
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Add KICAD_INSTALL_DEMOS CMake option

[Nick Østergaard]

What is the reasoning for doing this?

2016-09-08 9:04 GMT+02:00 José Ignacio Romero :
>
> It is ON by default, determines wether to install the bundled demos
> and examples.
> ---
>  CMakeLists.txt | 6 ++
>  1 file changed, 6 insertions(+)
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH] Add KICAD_INSTALL_DEMOS CMake option

[José Ignacio Romero]

It is ON by default, determines wether to install the bundled demos
and examples.
---
 CMakeLists.txt | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index bfeaac5..9fba017 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -49,6 +49,10 @@ option( KICAD_USE_OCE
 "Build tools and plugins related to OpenCascade Community Edition (default OFF)"
 )
 
+option( KICAD_INSTALL_DEMOS
+"Install kicad demos and examples (default ON)"
+ON )
+
 # when option KICAD_SCRIPTING OR KICAD_SCRIPTING_MODULES is enabled:
 # PYTHON_EXECUTABLE can be defined when invoking cmake
 # ( use -DPYTHON_EXECUTABLE=/python.exe or python2 )
@@ -806,5 +810,7 @@ add_subdirectory( utils )
 add_subdirectory( qa )
 
 # Resources
+if ( KICAD_INSTALL_DEMOS )
 add_subdirectory( demos )
+endif ( KICAD_INSTALL_DEMOS )
 add_subdirectory( template )
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp