Re: [Kicad-developers] [PATCH] Add a menu item to save a project under a new name.

2018-02-13 Thread Wayne Stambaugh
Russell,

I going to defer this patch to v6 since we are currently in feature
freeze.  I would ask that you please change the source naming to match
the feature name "save project as" and resubmit it when you get a
chance.  You are using "save as project" for source names but the
feature and UI string are "save project as".

Thanks,

Wayne

On 2/11/2018 9:04 AM, Russell Oliver wrote:
> I have updated the patch to copy across the library tables and any
> library files. At the moment instead of renaming footprint and schematic
> libraries and updating the tables they are merely copied across without
> renaming except for the symbol cache library. The tables are just copied
> across also. It's probably sub optimal at this stage but it works since
> renaming the libraries would also require remapping symbols and
> footprint to the new library nicknames also. 
> 
> Kind Regards
> Russell
> 
>  
> 
> On Tue, Feb 6, 2018 at 3:23 AM Russell Oliver  > wrote:
> 
> Yeah, I realized this after a sent the patch in, though I think it
> also calls into question the logic behind the archive project
> function. Though I am surprised about the sub directory files problem. 
> 
> I do think it's an important feature to have though, so any help
> from anyone would be appreciated. 
> 
> Kind Regards 
> Russell 
> 
> 
> On 6 Feb 2018 03:18, "jp charras"  > wrote:
> 
> Le 05/02/2018 à 06:07, Russell Oliver a écrit :
> > Copies project files into a new directory with the project
> name replaced in each file name if
> > preset. Uses the same set of extensions as the archive project
> feature to filter the files. 
> >
> 
> Hi Russel,
> 
> I tested your patch, but it does not work very well:
> - subdirectories are not duplicated. Instead of, the files
> inside subdirs are copied to the new root
> dir.
> - lib tables are not copied.
> 
> There is also a problem with libraries inside the project (like
> a rescue lib)
> They are renamed, but lib tables should be modified, according
> to the renaming.
> 
> This is a tricky problem.
> 
> --
> Jean-Pierre CHARRAS
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Add a menu item to save a project under a new name.

2018-02-05 Thread Russell Oliver
Yeah, I realized this after a sent the patch in, though I think it also
calls into question the logic behind the archive project function. Though I
am surprised about the sub directory files problem.

I do think it's an important feature to have though, so any help from
anyone would be appreciated.

Kind Regards
Russell


On 6 Feb 2018 03:18, "jp charras"  wrote:

Le 05/02/2018 à 06:07, Russell Oliver a écrit :
> Copies project files into a new directory with the project name replaced
in each file name if
> preset. Uses the same set of extensions as the archive project feature to
filter the files.
>

Hi Russel,

I tested your patch, but it does not work very well:
- subdirectories are not duplicated. Instead of, the files inside subdirs
are copied to the new root
dir.
- lib tables are not copied.

There is also a problem with libraries inside the project (like a rescue
lib)
They are renamed, but lib tables should be modified, according to the
renaming.

This is a tricky problem.

--
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Add a menu item to save a project under a new name.

2018-02-05 Thread jp charras
Le 05/02/2018 à 06:07, Russell Oliver a écrit :
> Copies project files into a new directory with the project name replaced in 
> each file name if
> preset. Uses the same set of extensions as the archive project feature to 
> filter the files. 
> 

Hi Russel,

I tested your patch, but it does not work very well:
- subdirectories are not duplicated. Instead of, the files inside subdirs are 
copied to the new root
dir.
- lib tables are not copied.

There is also a problem with libraries inside the project (like a rescue lib)
They are renamed, but lib tables should be modified, according to the renaming.

This is a tricky problem.

-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


[Kicad-developers] [PATCH] Add a menu item to save a project under a new name.

2018-02-04 Thread Russell Oliver
Copies project files into a new directory with the project name replaced in
each file name if preset. Uses the same set of extensions as the archive
project feature to filter the files.


0001-Add-a-menu-item-to-save-a-project-under-a-new-name.patch
Description: Binary data
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp