[Kicad-developers] [PATCH] Fix build error from 5803
Found the problem in the rescue update - left a couple unused variable declarations behind, which were no longer valid. Not sure why clang was okay with them, it shouldn't have been. -- Chris ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Fix build error from 5803
Uh, oops. Apparently I can't export a patch. On Mon, Jun 22, 2015 at 02:13:40PM -0400, Chris Pavlina wrote: > Found the problem in the rescue update - left a couple unused variable > declarations behind, which were no longer valid. Not sure why clang was > okay with them, it shouldn't have been. > > -- > Chris commit 1fdae20da0b75c5e5a96e181bc24748b7ad577e9 Merge: 3fa3c4b 1ffd93a Author: Chris Pavlina Date: Mon Jun 22 14:14:16 2015 -0400 Merge branch 'master' into field_autoplace ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Fix build error from 5803
Oh, wow. God, I'm a bloody idiot.
Third time's the charm?
On Mon, Jun 22, 2015 at 02:13:40PM -0400, Chris Pavlina wrote:
> Found the problem in the rescue update - left a couple unused variable
> declarations behind, which were no longer valid. Not sure why clang was
> okay with them, it shouldn't have been.
>
> --
> Chris
commit 1ffd93a238adcec2ae485ab1eaf4fe0ffddf8d17
Author: Chris Pavlina
Date: Mon Jun 22 14:12:18 2015 -0400
Remove unused variables which caused build error
diff --git a/eeschema/project_rescue.cpp b/eeschema/project_rescue.cpp
index 7150928..fe5dbfd 100644
--- a/eeschema/project_rescue.cpp
+++ b/eeschema/project_rescue.cpp
@@ -487,10 +487,6 @@ void RESCUER::UndoRescues()
bool SCH_EDIT_FRAME::RescueProject( bool aRunningOnDemand )
{
-// Data that will be used throughout the operation
-std::vector candidates;
-wxStringpart_name_suffix;
-
RESCUER rescuer( *this, Prj() );
rescuer.FindCandidates();
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Fix build error from 5803
Le 22/06/2015 20:17, Chris Pavlina a écrit : > Oh, wow. God, I'm a bloody idiot. > > Third time's the charm? > > > On Mon, Jun 22, 2015 at 02:13:40PM -0400, Chris Pavlina wrote: >> Found the problem in the rescue update - left a couple unused variable >> declarations behind, which were no longer valid. Not sure why clang was >> okay with them, it shouldn't have been. >> >> -- >> Chris I committed your fix. Thanks. To avoid a compil warning I also added a virtual destructor (which do nothing) in class RESCUE_CANDIDATE. -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Fix build error from 5803
Nice, I was just about to submit a second patch to fix that destructor. :) On Mon, Jun 22, 2015 at 08:36:12PM +0200, jp charras wrote: > Le 22/06/2015 20:17, Chris Pavlina a écrit : > > Oh, wow. God, I'm a bloody idiot. > > > > Third time's the charm? > > > > > > On Mon, Jun 22, 2015 at 02:13:40PM -0400, Chris Pavlina wrote: > >> Found the problem in the rescue update - left a couple unused variable > >> declarations behind, which were no longer valid. Not sure why clang was > >> okay with them, it shouldn't have been. > >> > >> -- > >> Chris > > I committed your fix. Thanks. > > To avoid a compil warning I also added a virtual destructor (which do > nothing) in class RESCUE_CANDIDATE. > > > -- > Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
