Re: [Kicad-developers] [PATCH] Fix depency bug introduced in RPATH patch

[Wayne Stambaugh]

I merged your patch.  Thanks!


Wayne

On 3/5/2018 7:52 PM, hauptmech wrote:
> The attached patch may fix the build error seen after the RPATH patch.
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Fix depency bug introduced in RPATH patch

[Steven A. Falco]

On 03/05/2018 07:52 PM, hauptmech wrote:
> The attached patch may fix the build error seen after the RPATH patch.

I was able to build the latest source on my machine with this patch included.  
While one run is hardly conclusive, I think this patch has merit.

I'll do some additional runs, and hopefully Nick can also re-test.

Thanks for the rapid response.

Steve


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH] Fix depency bug introduced in RPATH patch

[hauptmech]

The attached patch may fix the build error seen after the RPATH patch.

>From 4bdf9c309ae7a794014d5c3240ad8599b1273dc9 Mon Sep 17 00:00:00 2001
From: hauptmech 
Date: Tue, 6 Mar 2018 13:46:05 +1300
Subject: [PATCH] Fix dependency bug introduced in RPATH patch e0b33ee8
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="2.16.2"

This is a multi-part message in MIME format.
--2.16.2
Content-Type: text/plain; charset=UTF-8; format=fixed
Content-Transfer-Encoding: 8bit

---
 pcbnew/CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


--2.16.2
Content-Type: text/x-patch; name="0001-Fix-dependency-bug-introduced-in-RPATH-patch-e0b33ee.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment; filename="0001-Fix-dependency-bug-introduced-in-RPATH-patch-e0b33ee.patch"

diff --git a/pcbnew/CMakeLists.txt b/pcbnew/CMakeLists.txt
index 3ec6bbc23..dfe8e7113 100644
--- a/pcbnew/CMakeLists.txt
+++ b/pcbnew/CMakeLists.txt
@@ -685,7 +685,7 @@ add_dependencies( pcbnew pcbnew_kiface )
 
 # add dependency to specctra_lexer_source_files, to force
 # generation of autogenerated file
-add_dependencies( pcbnew_kiface specctra_lexer_source_files )
+add_dependencies( pcbnew_kiface_objects specctra_lexer_source_files )
 
 # these 2 binaries are a matched set, keep them together:
 if( APPLE )

--2.16.2--


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp