Re: [Kicad-developers] [PATCH] Legacy: delete and force middle button pan for GAL consistency
2016-06-09 20:52 GMT+02:00 Timofonic : > I'm just a bad user but... > > Why isn't Legacy canvas ditched in the development branch and focus efforts > in the GAL one exclusively? I think you follow the list enough to know why this is. :) > What about OpenGL and slow in certain platforms? What OpenGL version is KiCad > using currently? I fail to see it. Damn, even MESA is getting OpenGL 4.3+ > too. Can newer OpenGL features provide performance improvements too? > > Windows Intel graphics are known to have an awful OpenGL implementation. > Would using a OGL->D3D wrapper be an issue? > > Would using a library like BGFX be an issue? Can the switch traits lots of > coding and rewriting? > > What are the issues to massively remove all the cruft in KiCad code and > develop by thinking in the future? > > What's going to happen with KiCad 5.0? Personally, I would prefer a new one > with massive usability, performance and feature improvements than another > small one if that slows the progress to make KiCad a lot better EDA tool for > the future. > Things takes time. > On June 7, 2016 5:31:32 PM CEST, "Nick Østergaard" wrote: >>I am looking forward to "better" things :) >> >>2016-06-07 17:12 GMT+02:00 Chris Pavlina : >>> Heh :) >>> >>> I'm working on the replacement feature. There is definitely a strong >>argument >>> in favor of writing the replacement before removing the original, so >>I'm going >>> to do that. Could be a couple days, I have to spread it out with Real >>Work now. >>> I promise it'll be better than what we had :) >>> >>> On Tue, Jun 07, 2016 at 05:08:29PM +0200, Marco Ciampa wrote: On Tue, Jun 07, 2016 at 10:20:56AM -0400, Chris Pavlina wrote: > Also, I really feel like I should point out - it's not feasible to >>gather user > input for _every change_. That's how we got to the point we're at, >>really - > lots of "this would be useful for _me_", so it gets thrown in, and >>then we have > a hodgepodge of incoherent "features" each used by one person too >>fond of it to > remove it. > Sorry, couldn't resist: https://xkcd.com/1172/ -- Marco Ciampa I know a joke about UDP, but you might not get it. GNU/Linux User #78271 FSFE fellow #364 ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp >>> >>> ___ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : kicad-developers@lists.launchpad.net >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >> >>___ >>Mailing list: https://launchpad.net/~kicad-developers >>Post to : kicad-developers@lists.launchpad.net >>Unsubscribe : https://launchpad.net/~kicad-developers >>More help : https://help.launchpad.net/ListHelp > > -- > Enviado desde mi dispositivo Android con K-9 Mail. Por favor disculpa mi > brevedad. > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Legacy: delete and force middle button pan for GAL consistency
Legacy isn't ditched yet because it's not ready to be ditched yet. You're welcome to help contribute to all the work that needs to be done before that can happen. Don't know about the Windows graphics stuff, but I'm sure the people who do have considered this. You'd rather we wait a long time and then release a ton of changes at once, rather than release often? You're probably the only one who'd say that. "Release infrequently with massive changes" is a terrible release plan. See [1], [2], etc. [1] http://www.catb.org/esr/writings/homesteading/cathedral-bazaar/ar01s04.html [2] https://en.wikipedia.org/wiki/Release_early,_release_often On Thu, Jun 09, 2016 at 08:52:19PM +0200, Timofonic wrote: > I'm just a bad user but... > > Why isn't Legacy canvas ditched in the development branch and focus efforts > in the GAL one exclusively? > > What about OpenGL and slow in certain platforms? What OpenGL version is KiCad > using currently? I fail to see it. Damn, even MESA is getting OpenGL 4.3+ > too. Can newer OpenGL features provide performance improvements too? > > Windows Intel graphics are known to have an awful OpenGL implementation. > Would using a OGL->D3D wrapper be an issue? > > Would using a library like BGFX be an issue? Can the switch traits lots of > coding and rewriting? > > What are the issues to massively remove all the cruft in KiCad code and > develop by thinking in the future? > > What's going to happen with KiCad 5.0? Personally, I would prefer a new one > with massive usability, performance and feature improvements than another > small one if that slows the progress to make KiCad a lot better EDA tool for > the future. > > On June 7, 2016 5:31:32 PM CEST, "Nick Østergaard" wrote: > >I am looking forward to "better" things :) > > > >2016-06-07 17:12 GMT+02:00 Chris Pavlina : > >> Heh :) > >> > >> I'm working on the replacement feature. There is definitely a strong > >argument > >> in favor of writing the replacement before removing the original, so > >I'm going > >> to do that. Could be a couple days, I have to spread it out with Real > >Work now. > >> I promise it'll be better than what we had :) > >> > >> On Tue, Jun 07, 2016 at 05:08:29PM +0200, Marco Ciampa wrote: > >>> On Tue, Jun 07, 2016 at 10:20:56AM -0400, Chris Pavlina wrote: > >>> > Also, I really feel like I should point out - it's not feasible to > >gather user > >>> > input for _every change_. That's how we got to the point we're at, > >really - > >>> > lots of "this would be useful for _me_", so it gets thrown in, and > >then we have > >>> > a hodgepodge of incoherent "features" each used by one person too > >fond of it to > >>> > remove it. > >>> > > >>> > >>> Sorry, couldn't resist: https://xkcd.com/1172/ > >>> > >>> -- > >>> > >>> > >>> Marco Ciampa > >>> > >>> I know a joke about UDP, but you might not get it. > >>> > >>> > >>> > >>> GNU/Linux User #78271 > >>> FSFE fellow #364 > >>> > >>> > >>> > >>> > >>> ___ > >>> Mailing list: https://launchpad.net/~kicad-developers > >>> Post to : kicad-developers@lists.launchpad.net > >>> Unsubscribe : https://launchpad.net/~kicad-developers > >>> More help : https://help.launchpad.net/ListHelp > >> > >> ___ > >> Mailing list: https://launchpad.net/~kicad-developers > >> Post to : kicad-developers@lists.launchpad.net > >> Unsubscribe : https://launchpad.net/~kicad-developers > >> More help : https://help.launchpad.net/ListHelp > > > >___ > >Mailing list: https://launchpad.net/~kicad-developers > >Post to : kicad-developers@lists.launchpad.net > >Unsubscribe : https://launchpad.net/~kicad-developers > >More help : https://help.launchpad.net/ListHelp > > -- > Enviado desde mi dispositivo Android con K-9 Mail. Por favor disculpa mi > brevedad. > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Legacy: delete and force middle button pan for GAL consistency
Hi Timofonic, I may help answer some points. > What OpenGL version is KiCad using currently? I fail to see it 2.1 is required https://github.com/KiCad/kicad-source-mirror/blob/2928cb741961d5529cb2e57a9917922d80366c93/common/gal/opengl/opengl_gal.cpp#L1529 > Can newer OpenGL features provide performance improvements too? > Would using a OGL->D3D wrapper be an issue? As far as I understand from the GAL implementation, on relation to performance, I believe it is already very well optimized, special with the latest bitmap text optimization. I believe if there are speed optimization may be on a more hi level layer, not on the low openGL implementation. What are the performance issues you experience? I worked with kicad for some time without a GPU, so the openGL (shaders) were implemented by MESA on CPU. It was workable if the CPU is good. On relation to the GPU and drivers, I believe the most problematic will be on Linux (for old GPUs that dont have driver support, eg: ATI) But on Windows, GPU manufacturers usually have a basic support of the driver for each GPU product. On other case, if there is any situation that doing the same thing with D3D will have a great improve over OGL, that may be too specific for some GPU and that situation should be a wast of time for kicad development IMO. Cheers, Mario Luzeiro From: Kicad-developers [kicad-developers-bounces+mrluzeiro=ua...@lists.launchpad.net] on behalf of Timofonic [timofo...@gmail.com] Sent: 09 June 2016 19:52 To: kicad-developers@lists.launchpad.net Subject: Re: [Kicad-developers] [PATCH] Legacy: delete and force middle button pan for GAL consistency I'm just a bad user but... Why isn't Legacy canvas ditched in the development branch and focus efforts in the GAL one exclusively? What about OpenGL and slow in certain platforms? What OpenGL version is KiCad using currently? I fail to see it. Damn, even MESA is getting OpenGL 4.3+ too. Can newer OpenGL features provide performance improvements too? Windows Intel graphics are known to have an awful OpenGL implementation. Would using a OGL->D3D wrapper be an issue? Would using a library like BGFX be an issue? Can the switch traits lots of coding and rewriting? What are the issues to massively remove all the cruft in KiCad code and develop by thinking in the future? What's going to happen with KiCad 5.0? Personally, I would prefer a new one with massive usability, performance and feature improvements than another small one if that slows the progress to make KiCad a lot better EDA tool for the future. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Legacy: delete and force middle button pan for GAL consistency
I'm just a bad user but... Why isn't Legacy canvas ditched in the development branch and focus efforts in the GAL one exclusively? What about OpenGL and slow in certain platforms? What OpenGL version is KiCad using currently? I fail to see it. Damn, even MESA is getting OpenGL 4.3+ too. Can newer OpenGL features provide performance improvements too? Windows Intel graphics are known to have an awful OpenGL implementation. Would using a OGL->D3D wrapper be an issue? Would using a library like BGFX be an issue? Can the switch traits lots of coding and rewriting? What are the issues to massively remove all the cruft in KiCad code and develop by thinking in the future? What's going to happen with KiCad 5.0? Personally, I would prefer a new one with massive usability, performance and feature improvements than another small one if that slows the progress to make KiCad a lot better EDA tool for the future. On June 7, 2016 5:31:32 PM CEST, "Nick Østergaard" wrote: >I am looking forward to "better" things :) > >2016-06-07 17:12 GMT+02:00 Chris Pavlina : >> Heh :) >> >> I'm working on the replacement feature. There is definitely a strong >argument >> in favor of writing the replacement before removing the original, so >I'm going >> to do that. Could be a couple days, I have to spread it out with Real >Work now. >> I promise it'll be better than what we had :) >> >> On Tue, Jun 07, 2016 at 05:08:29PM +0200, Marco Ciampa wrote: >>> On Tue, Jun 07, 2016 at 10:20:56AM -0400, Chris Pavlina wrote: >>> > Also, I really feel like I should point out - it's not feasible to >gather user >>> > input for _every change_. That's how we got to the point we're at, >really - >>> > lots of "this would be useful for _me_", so it gets thrown in, and >then we have >>> > a hodgepodge of incoherent "features" each used by one person too >fond of it to >>> > remove it. >>> > >>> >>> Sorry, couldn't resist: https://xkcd.com/1172/ >>> >>> -- >>> >>> >>> Marco Ciampa >>> >>> I know a joke about UDP, but you might not get it. >>> >>> >>> >>> GNU/Linux User #78271 >>> FSFE fellow #364 >>> >>> >>> >>> >>> ___ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : kicad-developers@lists.launchpad.net >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >> >> ___ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp > >___ >Mailing list: https://launchpad.net/~kicad-developers >Post to : kicad-developers@lists.launchpad.net >Unsubscribe : https://launchpad.net/~kicad-developers >More help : https://help.launchpad.net/ListHelp -- Enviado desde mi dispositivo Android con K-9 Mail. Por favor disculpa mi brevedad. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Legacy: delete and force middle button pan for GAL consistency
I am looking forward to "better" things :) 2016-06-07 17:12 GMT+02:00 Chris Pavlina : > Heh :) > > I'm working on the replacement feature. There is definitely a strong argument > in favor of writing the replacement before removing the original, so I'm going > to do that. Could be a couple days, I have to spread it out with Real Work > now. > I promise it'll be better than what we had :) > > On Tue, Jun 07, 2016 at 05:08:29PM +0200, Marco Ciampa wrote: >> On Tue, Jun 07, 2016 at 10:20:56AM -0400, Chris Pavlina wrote: >> > Also, I really feel like I should point out - it's not feasible to gather >> > user >> > input for _every change_. That's how we got to the point we're at, really - >> > lots of "this would be useful for _me_", so it gets thrown in, and then we >> > have >> > a hodgepodge of incoherent "features" each used by one person too fond of >> > it to >> > remove it. >> > >> >> Sorry, couldn't resist: https://xkcd.com/1172/ >> >> -- >> >> >> Marco Ciampa >> >> I know a joke about UDP, but you might not get it. >> >> >> >> GNU/Linux User #78271 >> FSFE fellow #364 >> >> >> >> >> ___ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Legacy: delete and force middle button pan for GAL consistency
Heh :) I'm working on the replacement feature. There is definitely a strong argument in favor of writing the replacement before removing the original, so I'm going to do that. Could be a couple days, I have to spread it out with Real Work now. I promise it'll be better than what we had :) On Tue, Jun 07, 2016 at 05:08:29PM +0200, Marco Ciampa wrote: > On Tue, Jun 07, 2016 at 10:20:56AM -0400, Chris Pavlina wrote: > > Also, I really feel like I should point out - it's not feasible to gather > > user > > input for _every change_. That's how we got to the point we're at, really - > > lots of "this would be useful for _me_", so it gets thrown in, and then we > > have > > a hodgepodge of incoherent "features" each used by one person too fond of > > it to > > remove it. > > > > Sorry, couldn't resist: https://xkcd.com/1172/ > > -- > > > Marco Ciampa > > I know a joke about UDP, but you might not get it. > > > > GNU/Linux User #78271 > FSFE fellow #364 > > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Legacy: delete and force middle button pan for GAL consistency
On Tue, Jun 07, 2016 at 10:20:56AM -0400, Chris Pavlina wrote: > Also, I really feel like I should point out - it's not feasible to gather user > input for _every change_. That's how we got to the point we're at, really - > lots of "this would be useful for _me_", so it gets thrown in, and then we > have > a hodgepodge of incoherent "features" each used by one person too fond of it > to > remove it. > Sorry, couldn't resist: https://xkcd.com/1172/ -- Marco Ciampa I know a joke about UDP, but you might not get it. GNU/Linux User #78271 FSFE fellow #364 ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Legacy: delete and force middle button pan for GAL consistency
Also, I really feel like I should point out - it's not feasible to gather user input for _every change_. That's how we got to the point we're at, really - lots of "this would be useful for _me_", so it gets thrown in, and then we have a hodgepodge of incoherent "features" each used by one person too fond of it to remove it. In case you haven't been following along, my master plan here is to pare down the incoherent bits between legacy and GAL, and then do some serious UI reworking to fit it all back together nicely. I plan on getting significant user involvement with the latter bit - that's part of why I got us that Balsamiq account recently, it's a good way to share and get feedback on UI mockups. I really don't want each individual piece to become a battle ground by itself, though. Trust me, I have no plans on removing all of KiCad's features and making it useless ;) On Tue, Jun 07, 2016 at 08:56:35AM -0500, Moses McKnight wrote: > I'm not sure removing features like this is wise without at least asking the > /users/ (not just developers) first - and give them a little time to notice > and respond as well. I personally use nothing but middle button pan, but I > know what it is like to be quite used to a feature and then the next stable > release (of whatever software it is) has removed that feature (especially > when there is no suitable replacement for it!). > > On 06/07/2016 08:33 AM, Chris Pavlina wrote: > >Yeah, this is the last call for disagreement, I'm going to push this tomorrow > >if nobody speaks up. > > > >On Tue, Jun 07, 2016 at 03:23:45PM +0200, Maciej Sumiński wrote: > >>I, for one, support the patch. I see it is not a hot topic with an > >>endless discussion, so perhaps it is safe to commit. I hope this message > >>is a gentle reminder to people who would vote against, if there are any. > >> > >>Regards, > >>Orson > >> > >>On 06/04/2016 09:30 PM, Chris Pavlina wrote: > >>>This is one of the legacy/GAL consistency bits that we discussed a while > >>>ago. > >>>Legacy allows middle button pan to be disabled in favor of a middle button > >>>zoom. GAL doesn't. This patch removes "Use middle button to pan" (forcing > >>>it > >>>True for existing configs), and removes "Limit panning to scroll size" > >>>(forcing > >>>it False for existing configs). > >>> > >>>I don't want to commit this without giving a chance for discussion, but I > >>>really do think we should commit this. Perhaps there are a few users who > >>>like > >>>the feature, but I doubt there are many. So far nobody has complained > >>>about it > >>>being missing in GAL, and it's a win for both maintainability and interface > >>>simplicity. > >>> > >>>I'm not averse to having this feature, but I don't think it should be > >>>implemented this way. Other tools provide "zoom into selection" as a > >>>separate > >>>tool, for example GIMP [1]. I'd support implementing it this way instead, > >>>and > >>>can probably do that next if we want. Thoughts? > >>> > >>>[1] https://en.wikibooks.org/wiki/GIMP/Zoom_Tool > >>> > >>> > >>> > >>>___ > >>>Mailing list: https://launchpad.net/~kicad-developers > >>>Post to : kicad-developers@lists.launchpad.net > >>>Unsubscribe : https://launchpad.net/~kicad-developers > >>>More help : https://help.launchpad.net/ListHelp > >>> > >> > >> > > > > > >___ > >Mailing list: https://launchpad.net/~kicad-developers > >Post to : kicad-developers@lists.launchpad.net > >Unsubscribe : https://launchpad.net/~kicad-developers > >More help : https://help.launchpad.net/ListHelp > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Legacy: delete and force middle button pan for GAL consistency
Sure, but I did propose a replacement for it, and even volunteered to implement it. Any opinions on my proposed replacement? Perhaps I'll implement the replacement *first*, that should keep people happy. On Tue, Jun 07, 2016 at 08:56:35AM -0500, Moses McKnight wrote: > I'm not sure removing features like this is wise without at least > asking the /users/ (not just developers) first - and give them a > little time to notice and respond as well. I personally use > nothing but middle button pan, but I know what it is like to be > quite used to a feature and then the next stable release (of > whatever software it is) has removed that feature (especially > when there is no suitable replacement for it!). > > On 06/07/2016 08:33 AM, Chris Pavlina wrote: > >Yeah, this is the last call for disagreement, I'm going to push this tomorrow > >if nobody speaks up. > > > >On Tue, Jun 07, 2016 at 03:23:45PM +0200, Maciej Sumiński wrote: > >>I, for one, support the patch. I see it is not a hot topic with an > >>endless discussion, so perhaps it is safe to commit. I hope this message > >>is a gentle reminder to people who would vote against, if there are any. > >> > >>Regards, > >>Orson > >> > >>On 06/04/2016 09:30 PM, Chris Pavlina wrote: > >>>This is one of the legacy/GAL consistency bits that we discussed a while > >>>ago. > >>>Legacy allows middle button pan to be disabled in favor of a middle button > >>>zoom. GAL doesn't. This patch removes "Use middle button to pan" (forcing > >>>it > >>>True for existing configs), and removes "Limit panning to scroll size" > >>>(forcing > >>>it False for existing configs). > >>> > >>>I don't want to commit this without giving a chance for discussion, but I > >>>really do think we should commit this. Perhaps there are a few users who > >>>like > >>>the feature, but I doubt there are many. So far nobody has complained > >>>about it > >>>being missing in GAL, and it's a win for both maintainability and interface > >>>simplicity. > >>> > >>>I'm not averse to having this feature, but I don't think it should be > >>>implemented this way. Other tools provide "zoom into selection" as a > >>>separate > >>>tool, for example GIMP [1]. I'd support implementing it this way instead, > >>>and > >>>can probably do that next if we want. Thoughts? > >>> > >>>[1] https://en.wikibooks.org/wiki/GIMP/Zoom_Tool > >>> > >>> > >>> > >>>___ > >>>Mailing list: https://launchpad.net/~kicad-developers > >>>Post to : kicad-developers@lists.launchpad.net > >>>Unsubscribe : https://launchpad.net/~kicad-developers > >>>More help : https://help.launchpad.net/ListHelp > >>> > >> > >> > > > > > >___ > >Mailing list: https://launchpad.net/~kicad-developers > >Post to : kicad-developers@lists.launchpad.net > >Unsubscribe : https://launchpad.net/~kicad-developers > >More help : https://help.launchpad.net/ListHelp > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Legacy: delete and force middle button pan for GAL consistency
I'm not sure removing features like this is wise without at least asking the /users/ (not just developers) first - and give them a little time to notice and respond as well. I personally use nothing but middle button pan, but I know what it is like to be quite used to a feature and then the next stable release (of whatever software it is) has removed that feature (especially when there is no suitable replacement for it!). On 06/07/2016 08:33 AM, Chris Pavlina wrote: Yeah, this is the last call for disagreement, I'm going to push this tomorrow if nobody speaks up. On Tue, Jun 07, 2016 at 03:23:45PM +0200, Maciej Sumiński wrote: I, for one, support the patch. I see it is not a hot topic with an endless discussion, so perhaps it is safe to commit. I hope this message is a gentle reminder to people who would vote against, if there are any. Regards, Orson On 06/04/2016 09:30 PM, Chris Pavlina wrote: This is one of the legacy/GAL consistency bits that we discussed a while ago. Legacy allows middle button pan to be disabled in favor of a middle button zoom. GAL doesn't. This patch removes "Use middle button to pan" (forcing it True for existing configs), and removes "Limit panning to scroll size" (forcing it False for existing configs). I don't want to commit this without giving a chance for discussion, but I really do think we should commit this. Perhaps there are a few users who like the feature, but I doubt there are many. So far nobody has complained about it being missing in GAL, and it's a win for both maintainability and interface simplicity. I'm not averse to having this feature, but I don't think it should be implemented this way. Other tools provide "zoom into selection" as a separate tool, for example GIMP [1]. I'd support implementing it this way instead, and can probably do that next if we want. Thoughts? [1] https://en.wikibooks.org/wiki/GIMP/Zoom_Tool ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Legacy: delete and force middle button pan for GAL consistency
Yeah, this is the last call for disagreement, I'm going to push this tomorrow if nobody speaks up. On Tue, Jun 07, 2016 at 03:23:45PM +0200, Maciej Sumiński wrote: > I, for one, support the patch. I see it is not a hot topic with an > endless discussion, so perhaps it is safe to commit. I hope this message > is a gentle reminder to people who would vote against, if there are any. > > Regards, > Orson > > On 06/04/2016 09:30 PM, Chris Pavlina wrote: > > This is one of the legacy/GAL consistency bits that we discussed a while > > ago. > > Legacy allows middle button pan to be disabled in favor of a middle button > > zoom. GAL doesn't. This patch removes "Use middle button to pan" (forcing it > > True for existing configs), and removes "Limit panning to scroll size" > > (forcing > > it False for existing configs). > > > > I don't want to commit this without giving a chance for discussion, but I > > really do think we should commit this. Perhaps there are a few users who > > like > > the feature, but I doubt there are many. So far nobody has complained about > > it > > being missing in GAL, and it's a win for both maintainability and interface > > simplicity. > > > > I'm not averse to having this feature, but I don't think it should be > > implemented this way. Other tools provide "zoom into selection" as a > > separate > > tool, for example GIMP [1]. I'd support implementing it this way instead, > > and > > can probably do that next if we want. Thoughts? > > > > [1] https://en.wikibooks.org/wiki/GIMP/Zoom_Tool > > > > > > > > ___ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : kicad-developers@lists.launchpad.net > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > > > > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Legacy: delete and force middle button pan for GAL consistency
I, for one, support the patch. I see it is not a hot topic with an endless discussion, so perhaps it is safe to commit. I hope this message is a gentle reminder to people who would vote against, if there are any. Regards, Orson On 06/04/2016 09:30 PM, Chris Pavlina wrote: > This is one of the legacy/GAL consistency bits that we discussed a while ago. > Legacy allows middle button pan to be disabled in favor of a middle button > zoom. GAL doesn't. This patch removes "Use middle button to pan" (forcing it > True for existing configs), and removes "Limit panning to scroll size" > (forcing > it False for existing configs). > > I don't want to commit this without giving a chance for discussion, but I > really do think we should commit this. Perhaps there are a few users who like > the feature, but I doubt there are many. So far nobody has complained about it > being missing in GAL, and it's a win for both maintainability and interface > simplicity. > > I'm not averse to having this feature, but I don't think it should be > implemented this way. Other tools provide "zoom into selection" as a separate > tool, for example GIMP [1]. I'd support implementing it this way instead, and > can probably do that next if we want. Thoughts? > > [1] https://en.wikibooks.org/wiki/GIMP/Zoom_Tool > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] [PATCH] Legacy: delete and force middle button pan for GAL consistency
This is one of the legacy/GAL consistency bits that we discussed a while ago.
Legacy allows middle button pan to be disabled in favor of a middle button
zoom. GAL doesn't. This patch removes "Use middle button to pan" (forcing it
True for existing configs), and removes "Limit panning to scroll size" (forcing
it False for existing configs).
I don't want to commit this without giving a chance for discussion, but I
really do think we should commit this. Perhaps there are a few users who like
the feature, but I doubt there are many. So far nobody has complained about it
being missing in GAL, and it's a win for both maintainability and interface
simplicity.
I'm not averse to having this feature, but I don't think it should be
implemented this way. Other tools provide "zoom into selection" as a separate
tool, for example GIMP [1]. I'd support implementing it this way instead, and
can probably do that next if we want. Thoughts?
[1] https://en.wikibooks.org/wiki/GIMP/Zoom_Tool
--
Chris
>From c35030b69c9017b206245b74fa47fcfd4fb2219e Mon Sep 17 00:00:00 2001
From: Chris Pavlina
Date: Sat, 4 Jun 2016 15:22:37 -0400
Subject: [PATCH] Legacy: delete and force middle button pan for GAL
consistency
---
common/draw_frame.cpp | 2 -
common/draw_panel.cpp | 126 ++-
cvpcb/dialogs/dialog_display_options.cpp | 15 +-
cvpcb/dialogs/dialog_display_options.h | 20 +--
cvpcb/dialogs/dialog_display_options_base.cpp | 20 +--
cvpcb/dialogs/dialog_display_options_base.fbp | 180 +
cvpcb/dialogs/dialog_display_options_base.h| 7 +-
eeschema/dialogs/dialog_eeschema_options.h | 47 --
eeschema/dialogs/dialog_eeschema_options_base.cpp | 15 +-
eeschema/dialogs/dialog_eeschema_options_base.fbp | 180 +
eeschema/dialogs/dialog_eeschema_options_base.h| 4 -
eeschema/eeschema_config.cpp | 4 -
.../gerbview_dialog_display_options_frame.cpp | 9 --
.../gerbview_dialog_display_options_frame_base.cpp | 82 +-
.../gerbview_dialog_display_options_frame_base.fbp | 177 +---
.../gerbview_dialog_display_options_frame_base.h | 19 +--
include/class_drawpanel.h | 12 --
pcbnew/dialogs/dialog_general_options.cpp | 5 -
pcbnew/dialogs/dialog_general_options.h| 8 +-
.../dialog_general_options_BoardEditor_base.cpp| 12 --
.../dialog_general_options_BoardEditor_base.fbp| 176
.../dialog_general_options_BoardEditor_base.h | 4 -
22 files changed, 88 insertions(+), 1036 deletions(-)
diff --git a/common/draw_frame.cpp b/common/draw_frame.cpp
index b28e63d..5017da5 100644
--- a/common/draw_frame.cpp
+++ b/common/draw_frame.cpp
@@ -783,8 +783,6 @@ void EDA_DRAW_FRAME::UpdateMsgPanel()
void EDA_DRAW_FRAME::PushPreferences( const EDA_DRAW_PANEL* aParentCanvas )
{
m_canvas->SetEnableZoomNoCenter( aParentCanvas->GetEnableZoomNoCenter() );
-m_canvas->SetEnableMiddleButtonPan( aParentCanvas->GetEnableMiddleButtonPan() );
-m_canvas->SetMiddleButtonPanLimited( aParentCanvas->GetMiddleButtonPanLimited() );
m_canvas->SetEnableAutoPan( aParentCanvas->GetEnableAutoPan() );
}
diff --git a/common/draw_panel.cpp b/common/draw_panel.cpp
index 1455ca5..bac5012 100644
--- a/common/draw_panel.cpp
+++ b/common/draw_panel.cpp
@@ -121,9 +121,7 @@ EDA_DRAW_PANEL::EDA_DRAW_PANEL( EDA_DRAW_FRAME* parent, int id,
m_canStartBlock = -1; // Command block can start if >= 0
m_abortRequest = false;
m_enableMousewheelPan = false;
-m_enableMiddleButtonPan = true;
m_enableZoomNoCenter = false;
-m_panScrollbarLimits = false;
m_enableAutoPan = true;
m_ignoreMouseEvents = false;
m_ignoreNextLeftButtonRelease = false;
@@ -136,9 +134,7 @@ EDA_DRAW_PANEL::EDA_DRAW_PANEL( EDA_DRAW_FRAME* parent, int id,
if( cfg )
{
cfg->Read( ENBL_MOUSEWHEEL_PAN_KEY, &m_enableMousewheelPan, false );
-cfg->Read( ENBL_MIDDLE_BUTT_PAN_KEY, &m_enableMiddleButtonPan, true );
cfg->Read( ENBL_ZOOM_NO_CENTER_KEY, &m_enableZoomNoCenter, false );
-cfg->Read( MIDDLE_BUTT_PAN_LIMITED_KEY, &m_panScrollbarLimits, false );
cfg->Read( ENBL_AUTO_PAN_KEY, &m_enableAutoPan, true );
}
@@ -166,9 +162,7 @@ EDA_DRAW_PANEL::~EDA_DRAW_PANEL()
if( cfg )
{
cfg->Write( ENBL_MOUSEWHEEL_PAN_KEY, m_enableMousewheelPan );
-cfg->Write( ENBL_MIDDLE_BUTT_PAN_KEY, m_enableMiddleButtonPan );
cfg->Write( ENBL_ZOOM_NO_CENTER_KEY, m_enableZoomNoCenter );
-cfg->Write( MIDDLE_BUTT_PAN_LIMITED_KEY, m_panScrollbarLimits );
cfg->Write( ENBL_AUTO_PAN_KEY, m_enableAutoPan );
}
}
@@ -1135,120 +1129,32 @@ void EDA_DRAW_PANEL::OnMouseEvent( wxMouseEvent& event )
m_ignoreNextLeftButtonRelease = false;
}
-if( event.ButtonDown( wxMOUS
