Re: [Kicad-developers] [PATCH] Print layer names in pcbnew

[Chris Pavlina]

Pushed.

On Sat, Sep 10, 2016 at 02:16:23PM -0400, Ian Roth wrote:
> The change looks good. I think it is ready to be pushed.
> 
> On Sat, Sep 10, 2016 at 2:10 PM, Chris Pavlina 
> wrote:
> 
> > Only one more comment, but a small one so I fixed it for you. I've
> > attached a fixup diff against yours, please let me know that you are
> > okay with the changes made to your patch and I'll push it.
> >
> > 1. The phrase "Multiple Layers" must be translateable so that it will
> > display in the language of the current locale.
> >
> > 2. I bumped the copyright year to 2016 on the files you edited.
> >
> > Thank you for your contribution!
> >
> >
> > On Sat, Sep 10, 2016 at 01:51:13PM -0400, Ian Roth wrote:
> > > Attached is an updated patch. The need for this is that at the place
> > that I
> > > work, we are to document all board layouts. I use the print function in
> > > pcbnew, and select 1 layer per page since the documentation is to be in
> > > black and white. This works great, except that there is no way to flip
> > to a
> > > page and know what layer you are looking at unless you are already
> > familiar
> > > with the board. This patch makes looking over the documentation easier
> > > since the layer name, ie. F.Cu, B.Cu et cetera is printed in the
> > worksheet.
> > >
> > > Please feel free to ask any additional questions.
> > >
> > > Ian
> > >
> > > On Sat, Sep 10, 2016 at 8:15 AM, Chris Pavlina 
> > > wrote:
> > >
> > > > What it says on the tin. It adds a %L format string to labels in the
> > > > worksheet (title block) that will contain the layer name when printed.
> > > >
> > > > I like this, but I agree with Wayne - having to edit so many files
> > > > because of how the layer name is being passed in is just not good.
> > > > Having that many function parameters in general can get irritating and
> > > > confusing.
> > > >
> > > > On Sat, Sep 10, 2016 at 02:02:01PM +0200, Nick Østergaard wrote:
> > > > > I have not tried this patch, but could you be a bit more descriptive
> > of
> > > > > what this patch do for the user and why?
> > > > >
> > > > > Den 08/09/2016 17.09 skrev "Ian Roth" :
> > > > >
> > > > > > This patch allows for printing layer names in pcbnew using a %L
> > > > formater.
> > > > > > This is helpful when printing 1 layer per page.
> > > > > >
> > > > > > Ian
> > > > > >
> > > > > > ___
> > > > > > Mailing list: https://launchpad.net/~kicad-developers
> > > > > > Post to : kicad-developers@lists.launchpad.net
> > > > > > Unsubscribe : https://launchpad.net/~kicad-developers
> > > > > > More help   : https://help.launchpad.net/ListHelp
> > > > > >
> > > > > >
> > > >
> > > >
> >
> >

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Print layer names in pcbnew

[Ian Roth]

The change looks good. I think it is ready to be pushed.

On Sat, Sep 10, 2016 at 2:10 PM, Chris Pavlina 
wrote:

> Only one more comment, but a small one so I fixed it for you. I've
> attached a fixup diff against yours, please let me know that you are
> okay with the changes made to your patch and I'll push it.
>
> 1. The phrase "Multiple Layers" must be translateable so that it will
> display in the language of the current locale.
>
> 2. I bumped the copyright year to 2016 on the files you edited.
>
> Thank you for your contribution!
>
>
> On Sat, Sep 10, 2016 at 01:51:13PM -0400, Ian Roth wrote:
> > Attached is an updated patch. The need for this is that at the place
> that I
> > work, we are to document all board layouts. I use the print function in
> > pcbnew, and select 1 layer per page since the documentation is to be in
> > black and white. This works great, except that there is no way to flip
> to a
> > page and know what layer you are looking at unless you are already
> familiar
> > with the board. This patch makes looking over the documentation easier
> > since the layer name, ie. F.Cu, B.Cu et cetera is printed in the
> worksheet.
> >
> > Please feel free to ask any additional questions.
> >
> > Ian
> >
> > On Sat, Sep 10, 2016 at 8:15 AM, Chris Pavlina 
> > wrote:
> >
> > > What it says on the tin. It adds a %L format string to labels in the
> > > worksheet (title block) that will contain the layer name when printed.
> > >
> > > I like this, but I agree with Wayne - having to edit so many files
> > > because of how the layer name is being passed in is just not good.
> > > Having that many function parameters in general can get irritating and
> > > confusing.
> > >
> > > On Sat, Sep 10, 2016 at 02:02:01PM +0200, Nick Østergaard wrote:
> > > > I have not tried this patch, but could you be a bit more descriptive
> of
> > > > what this patch do for the user and why?
> > > >
> > > > Den 08/09/2016 17.09 skrev "Ian Roth" :
> > > >
> > > > > This patch allows for printing layer names in pcbnew using a %L
> > > formater.
> > > > > This is helpful when printing 1 layer per page.
> > > > >
> > > > > Ian
> > > > >
> > > > > ___
> > > > > Mailing list: https://launchpad.net/~kicad-developers
> > > > > Post to : kicad-developers@lists.launchpad.net
> > > > > Unsubscribe : https://launchpad.net/~kicad-developers
> > > > > More help   : https://help.launchpad.net/ListHelp
> > > > >
> > > > >
> > >
> > >
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Print layer names in pcbnew

[Chris Pavlina]

Only one more comment, but a small one so I fixed it for you. I've
attached a fixup diff against yours, please let me know that you are
okay with the changes made to your patch and I'll push it.

1. The phrase "Multiple Layers" must be translateable so that it will
display in the language of the current locale.

2. I bumped the copyright year to 2016 on the files you edited.

Thank you for your contribution!


On Sat, Sep 10, 2016 at 01:51:13PM -0400, Ian Roth wrote:
> Attached is an updated patch. The need for this is that at the place that I
> work, we are to document all board layouts. I use the print function in
> pcbnew, and select 1 layer per page since the documentation is to be in
> black and white. This works great, except that there is no way to flip to a
> page and know what layer you are looking at unless you are already familiar
> with the board. This patch makes looking over the documentation easier
> since the layer name, ie. F.Cu, B.Cu et cetera is printed in the worksheet.
> 
> Please feel free to ask any additional questions.
> 
> Ian
> 
> On Sat, Sep 10, 2016 at 8:15 AM, Chris Pavlina 
> wrote:
> 
> > What it says on the tin. It adds a %L format string to labels in the
> > worksheet (title block) that will contain the layer name when printed.
> >
> > I like this, but I agree with Wayne - having to edit so many files
> > because of how the layer name is being passed in is just not good.
> > Having that many function parameters in general can get irritating and
> > confusing.
> >
> > On Sat, Sep 10, 2016 at 02:02:01PM +0200, Nick Østergaard wrote:
> > > I have not tried this patch, but could you be a bit more descriptive of
> > > what this patch do for the user and why?
> > >
> > > Den 08/09/2016 17.09 skrev "Ian Roth" :
> > >
> > > > This patch allows for printing layer names in pcbnew using a %L
> > formater.
> > > > This is helpful when printing 1 layer per page.
> > > >
> > > > Ian
> > > >
> > > > ___
> > > > Mailing list: https://launchpad.net/~kicad-developers
> > > > Post to : kicad-developers@lists.launchpad.net
> > > > Unsubscribe : https://launchpad.net/~kicad-developers
> > > > More help   : https://help.launchpad.net/ListHelp
> > > >
> > > >
> >
> >

>From 5aefbf74dc39946d37cdd60527dfe6ba264ba790 Mon Sep 17 00:00:00 2001
From: Chris Pavlina 
Date: Sat, 10 Sep 2016 14:08:33 -0400
Subject: [PATCH] fixup! Add %L formatter to worksheets to print layer name.

---
 common/worksheet.cpp  | 2 +-
 gerbview/printout_control.cpp | 2 +-
 include/worksheet.h   | 2 +-
 include/worksheet_shape_builder.h | 2 +-
 pcbnew/printout_controler.cpp | 4 ++--
 pcbnew/printout_controler.h   | 2 +-
 6 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/common/worksheet.cpp b/common/worksheet.cpp
index 45fcac2..367fa98 100644
--- a/common/worksheet.cpp
+++ b/common/worksheet.cpp
@@ -8,7 +8,7 @@
 /*
  * This program source code file is part of KiCad, a free EDA CAD application.
  *
- * Copyright (C) 1992-2013 KiCad Developers, see change_log.txt for contributors.
+ * Copyright (C) 1992-2016 KiCad Developers, see AUTHORS.txt for contributors.
  *
  *
  * This program is free software; you can redistribute it and/or
diff --git a/gerbview/printout_control.cpp b/gerbview/printout_control.cpp
index 74f35aa..cc0da57 100644
--- a/gerbview/printout_control.cpp
+++ b/gerbview/printout_control.cpp
@@ -2,7 +2,7 @@
  * This program source code file is part of KiCad, a free EDA CAD application.
  *
  * Copyright (C) 2014 Jean-Pierre Charras, jp.charras at wanadoo.fr
- * Copyright (C) 1992-2014 KiCad Developers, see AUTHORS.txt for contributors.
+ * Copyright (C) 1992-2016 KiCad Developers, see AUTHORS.txt for contributors.
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License
diff --git a/include/worksheet.h b/include/worksheet.h
index fbd53cb..cb2a667 100644
--- a/include/worksheet.h
+++ b/include/worksheet.h
@@ -1,7 +1,7 @@
 /*
  * This program source code file is part of KiCad, a free EDA CAD application.
  *
- * Copyright (C) 1992-2014 KiCad Developers, see CHANGELOG.TXT for contributors.
+ * Copyright (C) 1992-2016 KiCad Developers, see AUTHORS.txt for contributors.
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License
diff --git a/include/worksheet_shape_builder.h b/include/worksheet_shape_builder.h
index bd9af9a..69b2000 100644
--- a/include/worksheet_shape_builder.h
+++ b/include/worksheet_shape_builder.h
@@ -2,7 +2,7 @@
  * This program source code file is part of KiCad, a free EDA CAD application.
  *
  * Copyright (C) 2013-2014 Jean-Pierre Charras, jp.charras at wanadoo.fr
- * Copyright (C) 1992-2014 KiCad Developers, see CHANGELOG.TXT for contributors.
+ * Copyright (C) 1992-2016 KiCad 

Re: [Kicad-developers] [PATCH] Print layer names in pcbnew

[Ian Roth]

Attached is an updated patch. The need for this is that at the place that I
work, we are to document all board layouts. I use the print function in
pcbnew, and select 1 layer per page since the documentation is to be in
black and white. This works great, except that there is no way to flip to a
page and know what layer you are looking at unless you are already familiar
with the board. This patch makes looking over the documentation easier
since the layer name, ie. F.Cu, B.Cu et cetera is printed in the worksheet.

Please feel free to ask any additional questions.

Ian

On Sat, Sep 10, 2016 at 8:15 AM, Chris Pavlina 
wrote:

> What it says on the tin. It adds a %L format string to labels in the
> worksheet (title block) that will contain the layer name when printed.
>
> I like this, but I agree with Wayne - having to edit so many files
> because of how the layer name is being passed in is just not good.
> Having that many function parameters in general can get irritating and
> confusing.
>
> On Sat, Sep 10, 2016 at 02:02:01PM +0200, Nick Østergaard wrote:
> > I have not tried this patch, but could you be a bit more descriptive of
> > what this patch do for the user and why?
> >
> > Den 08/09/2016 17.09 skrev "Ian Roth" :
> >
> > > This patch allows for printing layer names in pcbnew using a %L
> formater.
> > > This is helpful when printing 1 layer per page.
> > >
> > > Ian
> > >
> > > ___
> > > Mailing list: https://launchpad.net/~kicad-developers
> > > Post to : kicad-developers@lists.launchpad.net
> > > Unsubscribe : https://launchpad.net/~kicad-developers
> > > More help   : https://help.launchpad.net/ListHelp
> > >
> > >
>
>


printing.patch
Description: Binary data
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Print layer names in pcbnew

[Chris Pavlina]

What it says on the tin. It adds a %L format string to labels in the
worksheet (title block) that will contain the layer name when printed.

I like this, but I agree with Wayne - having to edit so many files
because of how the layer name is being passed in is just not good.
Having that many function parameters in general can get irritating and
confusing.

On Sat, Sep 10, 2016 at 02:02:01PM +0200, Nick Østergaard wrote:
> I have not tried this patch, but could you be a bit more descriptive of
> what this patch do for the user and why?
> 
> Den 08/09/2016 17.09 skrev "Ian Roth" :
> 
> > This patch allows for printing layer names in pcbnew using a %L formater.
> > This is helpful when printing 1 layer per page.
> >
> > Ian
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
> >


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Print layer names in pcbnew

[Nick Østergaard]

I have not tried this patch, but could you be a bit more descriptive of
what this patch do for the user and why?

Den 08/09/2016 17.09 skrev "Ian Roth" :

> This patch allows for printing layer names in pcbnew using a %L formater.
> This is helpful when printing 1 layer per page.
>
> Ian
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Print layer names in pcbnew

[Wayne Stambaugh]

I'm OK with this feature.  Anyone object to this?

Ian,

Please change your patch to pass wxEmptyString as the default value for
aSheetLayer.  That way you wont have to add wxEmptyString to all of the
DrawWorkSheet calls that don't need it.  This should make your patch
touch fewer files.

Thanks,

Wayne

On 9/8/2016 11:09 AM, Ian Roth wrote:
> This patch allows for printing layer names in pcbnew using a %L
> formater. This is helpful when printing 1 layer per page.
> 
> Ian
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH] Print layer names in pcbnew

[Ian Roth]

This patch allows for printing layer names in pcbnew using a %L formater.
This is helpful when printing 1 layer per page.

Ian


Print-layer-name-in-pcbnew.patch
Description: Binary data
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp