Re: [Kicad-developers] [PATCH] Remove dangling ends when switching sheets

2017-12-14 Thread Wayne Stambaugh 
Seth,

I'm still not convinced that this was necessary but since it only gets
called on find when entering a different sheet, it's low overhead so I
committed your patch.

Thanks,

Wayne

On 12/10/2017 10:02 PM, Seth Hillbrand wrote:
> Find
> ​can
>  warp you to a new sheet
> ​ if the string matches a component that isn't on the current sheet​
> . If that sheet hasn't
> ​yet ​
> been shown
> ​ during the session
> , the dangling ends
> ​have
>  not
> ​ been​
> calculated
> ​, so we force it here.​
> ​
> ​Best-
> Seth​
> 
> 
> On Dec 10, 2017 5:44 PM, "Wayne Stambaugh"  > wrote:
> 
> Seth,
> 
> Why is it necessary to test for dangling end on a find?  Find only
> searches for string matches so I'm having a hard time understanding why
> the dangling ends need to be cleaned up.
> 
> Cheers,
> 
> Wayne
> 
> On 12/09/2017 11:45 PM, Seth Hillbrand wrote:
> > ​This patch fixes https://bugs.launchpad.net/kicad/+bug/1672381
> 
> >  >
> >
> > When warping to a new sheet from either a "Find" command or
> receiving a
> > cross-probe request, Eeschema needs to check for dangling ends on
> the sheet.
> >
> > -S​
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> 
> > Post to     : kicad-developers@lists.launchpad.net
> 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> 
> > More help   : https://help.launchpad.net/ListHelp
> 
> >
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Remove dangling ends when switching sheets

2017-12-10 Thread Seth Hillbrand 
Find
​can
 warp you to a new sheet
​ if the string matches a component that isn't on the current sheet​
. If that sheet hasn't
​yet ​
been shown
​ during the session
, the dangling ends
​have
 not
​ been​
calculated
​, so we force it here.​
​
​Best-
Seth​


On Dec 10, 2017 5:44 PM, "Wayne Stambaugh"  wrote:

Seth,

Why is it necessary to test for dangling end on a find?  Find only
searches for string matches so I'm having a hard time understanding why
the dangling ends need to be cleaned up.

Cheers,

Wayne

On 12/09/2017 11:45 PM, Seth Hillbrand wrote:
> ​This patch fixes https://bugs.launchpad.net/kicad/+bug/1672381
> 
>
> When warping to a new sheet from either a "Find" command or receiving a
> cross-probe request, Eeschema needs to check for dangling ends on the
sheet.
>
> -S​
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Remove dangling ends when switching sheets

2017-12-10 Thread Wayne Stambaugh 
Seth,

Why is it necessary to test for dangling end on a find?  Find only
searches for string matches so I'm having a hard time understanding why
the dangling ends need to be cleaned up.

Cheers,

Wayne

On 12/09/2017 11:45 PM, Seth Hillbrand wrote:
> ​This patch fixes https://bugs.launchpad.net/kicad/+bug/1672381
> 
> 
> When warping to a new sheet from either a "Find" command or receiving a
> cross-probe request, Eeschema needs to check for dangling ends on the sheet.
> 
> -S​
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH] Remove dangling ends when switching sheets

2017-12-09 Thread Seth Hillbrand 
​This patch fixes https://bugs.launchpad.net/kicad/+bug/1672381

When warping to a new sheet from either a "Find" command or receiving a
cross-probe request, Eeschema needs to check for dangling ends on the sheet.

-S​


0001-Eeschema-TestDanglingEnds-on-Cross-probe.patch
Description: Binary data
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp