Re: [Kicad-developers] [PATCH] Small string formatting annoyance

2015-08-05 Thread Wayne Stambaugh
Your patch has been committed in the product branch r6052.  Thank you
for your contribution to KiCad.

Cheers,

Wayne

On 8/1/2015 9:50 PM, Jon Neal wrote:
 Hi,
 
 I noticed a long time ago that in the pcbnew plot dialog there is an
 extra space in the text for selecting the gerber version. I'm not sure
 if this is intentional, but this patch removes the extra space.
 
 If this gets submitted are there any changes needed for translating the
 string?
 
 Thanks,
 Jon Neal
 
 
 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp
 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


[Kicad-developers] [PATCH] Small string formatting annoyance

2015-08-01 Thread Jon Neal
Hi,

I noticed a long time ago that in the pcbnew plot dialog there is an extra
space in the text for selecting the gerber version. I'm not sure if this is
intentional, but this patch removes the extra space.

If this gets submitted are there any changes needed for translating the
string?

Thanks,
Jon Neal
diff --git a/pcbnew/dialogs/dialog_plot_base.cpp b/pcbnew/dialogs/dialog_plot_base.cpp
index 6031ac3..0f6d01e 100644
--- a/pcbnew/dialogs/dialog_plot_base.cpp
+++ b/pcbnew/dialogs/dialog_plot_base.cpp
@@ -245,7 +245,7 @@ DIALOG_PLOT_BASE::DIALOG_PLOT_BASE( wxWindow* parent, wxWindowID id, const wxStr
 	
 	m_GerberOptionsSizer-Add( bSizerGbrOpt, 0, wxALIGN_CENTER_VERTICAL, 5 );
 	
-	wxString m_rbGerberFormatChoices[] = { _(4.5 (unit  mm)), _(4.6 (unit mm)) };
+	wxString m_rbGerberFormatChoices[] = { _(4.5 (unit mm)), _(4.6 (unit mm)) };
 	int m_rbGerberFormatNChoices = sizeof( m_rbGerberFormatChoices ) / sizeof( wxString );
 	m_rbGerberFormat = new wxRadioBox( this, wxID_ANY, _(Format), wxDefaultPosition, wxDefaultSize, m_rbGerberFormatNChoices, m_rbGerberFormatChoices, 1, wxRA_SPECIFY_COLS );
 	m_rbGerberFormat-SetSelection( 0 );
diff --git a/pcbnew/dialogs/dialog_plot_base.fbp b/pcbnew/dialogs/dialog_plot_base.fbp
index bf86d06..8ca49b6 100644
--- a/pcbnew/dialogs/dialog_plot_base.fbp
+++ b/pcbnew/dialogs/dialog_plot_base.fbp
@@ -2983,7 +2983,7 @@
 property name=caption/property
 property name=caption_visible1/property
 property name=center_pane0/property
-property name=choicesquot;4.5 (unit  mm)quot; quot;4.6 (unit mm)quot;/property
+property name=choicesquot;4.5 (unit mm)quot; quot;4.6 (unit mm)quot;/property
 property name=close_button1/property
 property name=context_help/property
 property name=context_menu1/property
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp