[Kicad-developers] [PATCH 2/3] Include iso646.h for not, and and or keywords
These are not actually keywords in the C++ standard, but macros. Unless iso646.h is included, these are not guaranteed to be present. --- include/common.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/common.h b/include/common.h index b881444..8be1e25 100644 --- a/include/common.h +++ b/include/common.h @@ -41,6 +41,8 @@ #include richio.h #include colors.h +#include iso646.h + class wxAboutDialogInfo; class SEARCH_STACK; ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH 2/3] Include iso646.h for not, and and or keywords
Hi, On 28.07.2015 06:32, Mark Roszko wrote: What? Those keywords are part of the C++ standard from 2003(at least). Its only MSVC that is backwards and broken in this regard. Ah okay, then I misremembered that. Well, I've only used them once in '99, and back then I needed the header. Simon signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH 2/3] Include iso646.h for not, and and or keywords
What? Those keywords are part of the C++ standard from 2003(at least). Its only MSVC that is backwards and broken in this regard. They are not part of the C standards and thats why iso646.h exists for those hipsters with non-qwerty keyboards (I joke) https://en.wikipedia.org/wiki/C_alternative_tokens The above mentioned identifiers are operator keywords in the ISO C++ programming language and do not require the inclusion of a header file. In fact, here's the standard (C++11 doc at least): http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2012/n3337.pdf Go to page 22 (pdf page 37). It defines the operators as part of C++. This is the header on the linux libstdc++ https://gcc.gnu.org/onlinedocs/gcc-4.8.5/libstdc++/api/a00786_source.html But yea the include ~should~ be harmless for gcc since the file is blank anyway and it'll fix Microsoft's brokenness. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
