Re: [Kicad-developers] [RFC] Eeschema dialog tweaks
>Thanks for your work, I've not had a chance to look at the merge request. No problem. >I'm currently working on the eeschema options dialog to improve the template >field names editor so please don't change that at the moment, Ok, personally I haven't found much issue with the Options dialog. only thing bothering me about the options dialog is the visually broken wxSpinCtrls which for some reason have their buttons at only 60% of the height of the textfield on Linux Mint. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [RFC] Eeschema dialog tweaks
On 10/8/2014 12:34 AM, Mark Roszko wrote: > I was thinking it could be "Total issues", "Warnings", "Errors", > having the word "count" repeat 3 times seems...redundant. Total errors > is also wrong since its warnings + errors. > Using "Total" would be just as clear and would line up nicer with "Warnings" and "Errors". Just my 2 cents. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [RFC] Eeschema dialog tweaks
Hi Mark, Thanks for your work, I've not had a chance to look at the merge request. Generally discussion is always a great idea because it's hard to glean from a diff what the intended changes are and what the impact is going to be. I'm at work at the moment so still can't review the diff. I'm currently working on the eeschema options dialog to improve the template field names editor so please don't change that at the moment, otherwise you'll get conflicts in the .fbp file and they are a complete pain to sort out manually!! Best Regards, Brian. On 8 October 2014 05:39, Blair Bonnett wrote: > On 8 October 2014 17:34, Mark Roszko wrote: >> I was thinking it could be "Total issues", "Warnings", "Errors", >> having the word "count" repeat 3 times seems...redundant. Total errors >> is also wrong since its warnings + errors. > > Sounds even better. > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [RFC] Eeschema dialog tweaks
On 8 October 2014 17:34, Mark Roszko wrote: > I was thinking it could be "Total issues", "Warnings", "Errors", > having the word "count" repeat 3 times seems...redundant. Total errors > is also wrong since its warnings + errors. Sounds even better. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [RFC] Eeschema dialog tweaks
I was thinking it could be "Total issues", "Warnings", "Errors", having the word "count" repeat 3 times seems...redundant. Total errors is also wrong since its warnings + errors. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [RFC] Eeschema dialog tweaks
On 8 October 2014 16:43, Mark Roszko wrote: > > I submitted this as a merge request but it may be best to discuss it > on the mailing list. > > I started to hit up the other Eeschema dialogs while I was working on > the hotkey editor. > > https://code.launchpad.net/~mark-roszko/kicad/eeschema-dialog-tweaks > > Changes: > = > -Use the verb "Generate" rather than the noun "Netlist" on the button > in the Netlist Dialog. Netlist isn't a real verb. > -Use the verb "Annotate" instead of the noun "Annotation" in the > Annotate Schematic dialog. > > -ERC Dialog: > --***Add tooltips to ERC options matrix buttons to indicate what their > current state is, for newb friendliness.*** > --Cleanup ERC options code that for some reason decided to delete the > button and recreate it instead of just updating it's bitmap directly. > --Fix dialog title to be "Electrical Rules Checker" to match everywhere else. > --Fix all usages of "Erc" to "ERC" consistently. > --Move action buttons to bottom of dialog, make Del Markers actually > say Delete Markers. > --Make the "Test Erc" button into "Run" because you are running the > electrical rules checker and not testing it. > > Before: http://i.imgur.com/J4hP7Gl.png > After: http://i.imgur.com/DbEWX1o.png , http://i.imgur.com/WJeRUJ7.png > > > Only real changes of contention are the buttons in ERC dialog moving > and the Netlist vs Generate word usage. Just from looking at the screenshots: in the ERC report section, another fix would be to have "Total error count", "Warning count", and "Error count" rather than the pluralised versions at the moment. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [RFC] Eeschema dialog tweaks
Also fixes ERC Dialog not counting errors at all. For some reason SetLabel was used on wxTextCtrl isntead of SetValue. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] [RFC] Eeschema dialog tweaks
I submitted this as a merge request but it may be best to discuss it on the mailing list. I started to hit up the other Eeschema dialogs while I was working on the hotkey editor. https://code.launchpad.net/~mark-roszko/kicad/eeschema-dialog-tweaks Changes: = -Use the verb "Generate" rather than the noun "Netlist" on the button in the Netlist Dialog. Netlist isn't a real verb. -Use the verb "Annotate" instead of the noun "Annotation" in the Annotate Schematic dialog. -ERC Dialog: --***Add tooltips to ERC options matrix buttons to indicate what their current state is, for newb friendliness.*** --Cleanup ERC options code that for some reason decided to delete the button and recreate it instead of just updating it's bitmap directly. --Fix dialog title to be "Electrical Rules Checker" to match everywhere else. --Fix all usages of "Erc" to "ERC" consistently. --Move action buttons to bottom of dialog, make Del Markers actually say Delete Markers. --Make the "Test Erc" button into "Run" because you are running the electrical rules checker and not testing it. Before: http://i.imgur.com/J4hP7Gl.png After: http://i.imgur.com/DbEWX1o.png , http://i.imgur.com/WJeRUJ7.png Only real changes of contention are the buttons in ERC dialog moving and the Netlist vs Generate word usage. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
