Re: [Kicad-developers] Build error.

[Jeff Young]

Ditto!

> On 27 Feb 2021, at 13:55, Wayne Stambaugh  wrote:
> 
> Thanks!
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build error.

[Wayne Stambaugh]

Thanks!

On 2/27/21 8:54 AM, Jon Evans wrote:
> Should be fixed now.
> 
> On Sat, Feb 27, 2021 at 7:48 AM Wayne Stambaugh  > wrote:
> 
> Looks like a commit in the last 24 hours broke KiCad builds with Python
> enabled.  Here is the build error on Linux using gcc 9.3.0.
> 
> In file included from
> /usr/include/x86_64-linux-gnu/c++/9/bits/c++allocator.h:33,
>                  from /usr/include/c++/9/bits/allocator.h:46,
>                  from /usr/include/c++/9/string:41,
>                  from /usr/include/c++/9/stdexcept:39,
>                  from
> 
> /home/wayne/build/kicad/trunk-debug-gtk3-phoenix-occt/pcbnew/pcbnew_wrap.cxx:3006:
> /usr/include/c++/9/ext/new_allocator.h: In instantiation of ‘void
> __gnu_cxx::new_allocator<_Tp>::construct(_Up*, _Args&& ...) [with _Up =
> std::pair >; _Args = {const
> std::pair std::default_delete > >&}; _Tp =
> std::_Rb_tree_node
> > >]’:
> /usr/include/c++/9/bits/alloc_traits.h:482:2:   required from ‘static
> void std::allocator_traits
> >::construct(std::allocator_traits
> >::allocator_type&, _Up*, _Args&& ...) [with _Up = std::pair const, std::unique_ptr >; _Args = {const std::pair const, std::unique_ptr > >&};
> _Tp = std::_Rb_tree_node std::unique_ptr > >;
> std::allocator_traits >::allocator_type =
> std::allocator std::unique_ptr > > >]’
> /usr/include/c++/9/bits/stl_tree.h:614:32:   required from ‘void
> std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare,
> _Alloc>::_M_construct_node(std::_Rb_tree<_Key, _Val, _KeyOfValue,
> _Compare, _Alloc>::_Link_type, _Args&& ...) [with _Args = {const
> std::pair std::default_delete > >&}; _Key = ZONE*; _Val =
> std::pair >; _KeyOfValue =
> std::_Select1st > >;
> _Compare = std::less; _Alloc = std::allocator const, std::unique_ptr > >; std::_Rb_tree<_Key, _Val,
> _KeyOfValue, _Compare, _Alloc>::_Link_type =
> std::_Rb_tree_node
> > >*]’
> /usr/include/c++/9/bits/stl_tree.h:487:3:   required from
> ‘std::_Rb_tree_node<_Val>* std::_Rb_tree<_Key, _Val, _KeyOfValue,
> _Compare, _Alloc>::_Reuse_or_alloc_node::operator()(_Arg&&) [with _Arg =
> const std::pair >&; _Key =
> ZONE*; _Val = std::pair >;
> _KeyOfValue = std::_Select1st std::unique_ptr > >; _Compare = std::less; _Alloc =
> std::allocator > >;
> std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::_Link_type =
> std::_Rb_tree_node
> > >*]’
> /usr/include/c++/9/bits/stl_tree.h:658:33:   required from
> ‘std::_Rb_tree_node<_Val>* std::_Rb_tree<_Key, _Val, _KeyOfValue,
> _Compare, _Alloc>::_M_clone_node(std::_Rb_tree<_Key, _Val, _KeyOfValue,
> _Compare, _Alloc>::_Const_Link_type, _NodeGen&) [with _NodeGen =
> std::_Rb_tree
> >, std::_Select1st >
> >, std::less, std::allocator std::unique_ptr > > >::_Reuse_or_alloc_node; _Key = ZONE*;
> _Val = std::pair >; _KeyOfValue
> = std::_Select1st > >;
> _Compare = std::less; _Alloc = std::allocator const, std::unique_ptr > >; std::_Rb_tree<_Key, _Val,
> _KeyOfValue, _Compare, _Alloc>::_Link_type =
> std::_Rb_tree_node >
> >*; std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare,
> _Alloc>::_Const_Link_type = const std::_Rb_tree_node const, std::unique_ptr > >*]’
> /usr/include/c++/9/bits/stl_tree.h:1875:13:   required from
> ‘std::_Rb_tree_node<_Val>* std::_Rb_tree<_Key, _Val, _KeyOfValue,
> _Compare, _Alloc>::_M_copy(std::_Rb_tree<_Key, _Val, _KeyOfValue,
> _Compare, _Alloc>::_Const_Link_type, std::_Rb_tree<_Key, _Val,
> _KeyOfValue, _Compare, _Alloc>::_Base_ptr, _NodeGen&) [with _NodeGen =
> std::_Rb_tree
> >, std::_Select1st >
> >, std::less, std::allocator std::unique_ptr > > >::_Reuse_or_alloc_node; _Key = ZONE*;
> _Val = std::pair >; _KeyOfValue
> = std::_Select1st > >;
> _Compare = std::less; _Alloc = std::allocator const, std::unique_ptr > >; std::_Rb_tree<_Key, _Val,
> _KeyOfValue, _Compare, _Alloc>::_Link_type =
> std::_Rb_tree_node >
> >*; std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare,
> _Alloc>::_Const_Link_type = const std::_Rb_tree_node const, std::unique_ptr > >*; std::_Rb_tree<_Key, _Val,
> _KeyOfValue, _Compare, _Alloc>::_Base_ptr = std::_Rb_tree_node_base*]’
> /usr/include/c++/9/bits/stl_tree.h:901:15:   required from
> ‘std::_Rb_tree_node<_Val>* std::_Rb_tree<_Key, _Val, _KeyOfValue,
> _Compare, _Alloc>::_M_copy(const std::_Rb_tree<_Key, _Val, _KeyOfValue,
> _Compare, _Alloc>&, _NodeGen&) [with _NodeGen = std::_Rb_tree std::pair >,
> std::_Select1st > >,
> std::less, std::allocator std::unique_ptr > > >::_Reuse_or_alloc_node; _Key = ZONE*;
> _Val = std::pair >; _KeyOfValue
> = std::_Select1st > >;
> _Compare = std::less; _Alloc = std::allocator const, std::unique_ptr > >; std::_Rb_tree<_Key, 

Re: [Kicad-developers] Build error.

[Jon Evans]

Should be fixed now.

On Sat, Feb 27, 2021 at 7:48 AM Wayne Stambaugh 
wrote:

> Looks like a commit in the last 24 hours broke KiCad builds with Python
> enabled.  Here is the build error on Linux using gcc 9.3.0.
>
> In file included from
> /usr/include/x86_64-linux-gnu/c++/9/bits/c++allocator.h:33,
>  from /usr/include/c++/9/bits/allocator.h:46,
>  from /usr/include/c++/9/string:41,
>  from /usr/include/c++/9/stdexcept:39,
>  from
>
> /home/wayne/build/kicad/trunk-debug-gtk3-phoenix-occt/pcbnew/pcbnew_wrap.cxx:3006:
> /usr/include/c++/9/ext/new_allocator.h: In instantiation of ‘void
> __gnu_cxx::new_allocator<_Tp>::construct(_Up*, _Args&& ...) [with _Up =
> std::pair >; _Args = {const
> std::pair std::default_delete > >&}; _Tp =
> std::_Rb_tree_node > >]’:
> /usr/include/c++/9/bits/alloc_traits.h:482:2:   required from ‘static
> void std::allocator_traits
> >::construct(std::allocator_traits
> >::allocator_type&, _Up*, _Args&& ...) [with _Up = std::pair const, std::unique_ptr >; _Args = {const std::pair const, std::unique_ptr > >&};
> _Tp = std::_Rb_tree_node std::unique_ptr > >;
> std::allocator_traits >::allocator_type =
> std::allocator std::unique_ptr > > >]’
> /usr/include/c++/9/bits/stl_tree.h:614:32:   required from ‘void
> std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare,
> _Alloc>::_M_construct_node(std::_Rb_tree<_Key, _Val, _KeyOfValue,
> _Compare, _Alloc>::_Link_type, _Args&& ...) [with _Args = {const
> std::pair std::default_delete > >&}; _Key = ZONE*; _Val =
> std::pair >; _KeyOfValue =
> std::_Select1st > >;
> _Compare = std::less; _Alloc = std::allocator const, std::unique_ptr > >; std::_Rb_tree<_Key, _Val,
> _KeyOfValue, _Compare, _Alloc>::_Link_type =
> std::_Rb_tree_node > >*]’
> /usr/include/c++/9/bits/stl_tree.h:487:3:   required from
> ‘std::_Rb_tree_node<_Val>* std::_Rb_tree<_Key, _Val, _KeyOfValue,
> _Compare, _Alloc>::_Reuse_or_alloc_node::operator()(_Arg&&) [with _Arg =
> const std::pair >&; _Key =
> ZONE*; _Val = std::pair >;
> _KeyOfValue = std::_Select1st std::unique_ptr > >; _Compare = std::less; _Alloc =
> std::allocator > >;
> std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::_Link_type =
> std::_Rb_tree_node > >*]’
> /usr/include/c++/9/bits/stl_tree.h:658:33:   required from
> ‘std::_Rb_tree_node<_Val>* std::_Rb_tree<_Key, _Val, _KeyOfValue,
> _Compare, _Alloc>::_M_clone_node(std::_Rb_tree<_Key, _Val, _KeyOfValue,
> _Compare, _Alloc>::_Const_Link_type, _NodeGen&) [with _NodeGen =
> std::_Rb_tree
> >, std::_Select1st >
> >, std::less, std::allocator std::unique_ptr > > >::_Reuse_or_alloc_node; _Key = ZONE*;
> _Val = std::pair >; _KeyOfValue
> = std::_Select1st > >;
> _Compare = std::less; _Alloc = std::allocator const, std::unique_ptr > >; std::_Rb_tree<_Key, _Val,
> _KeyOfValue, _Compare, _Alloc>::_Link_type =
> std::_Rb_tree_node >
> >*; std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare,
> _Alloc>::_Const_Link_type = const std::_Rb_tree_node const, std::unique_ptr > >*]’
> /usr/include/c++/9/bits/stl_tree.h:1875:13:   required from
> ‘std::_Rb_tree_node<_Val>* std::_Rb_tree<_Key, _Val, _KeyOfValue,
> _Compare, _Alloc>::_M_copy(std::_Rb_tree<_Key, _Val, _KeyOfValue,
> _Compare, _Alloc>::_Const_Link_type, std::_Rb_tree<_Key, _Val,
> _KeyOfValue, _Compare, _Alloc>::_Base_ptr, _NodeGen&) [with _NodeGen =
> std::_Rb_tree
> >, std::_Select1st >
> >, std::less, std::allocator std::unique_ptr > > >::_Reuse_or_alloc_node; _Key = ZONE*;
> _Val = std::pair >; _KeyOfValue
> = std::_Select1st > >;
> _Compare = std::less; _Alloc = std::allocator const, std::unique_ptr > >; std::_Rb_tree<_Key, _Val,
> _KeyOfValue, _Compare, _Alloc>::_Link_type =
> std::_Rb_tree_node >
> >*; std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare,
> _Alloc>::_Const_Link_type = const std::_Rb_tree_node const, std::unique_ptr > >*; std::_Rb_tree<_Key, _Val,
> _KeyOfValue, _Compare, _Alloc>::_Base_ptr = std::_Rb_tree_node_base*]’
> /usr/include/c++/9/bits/stl_tree.h:901:15:   required from
> ‘std::_Rb_tree_node<_Val>* std::_Rb_tree<_Key, _Val, _KeyOfValue,
> _Compare, _Alloc>::_M_copy(const std::_Rb_tree<_Key, _Val, _KeyOfValue,
> _Compare, _Alloc>&, _NodeGen&) [with _NodeGen = std::_Rb_tree std::pair >,
> std::_Select1st > >,
> std::less, std::allocator std::unique_ptr > > >::_Reuse_or_alloc_node; _Key = ZONE*;
> _Val = std::pair >; _KeyOfValue
> = std::_Select1st > >;
> _Compare = std::less; _Alloc = std::allocator const, std::unique_ptr > >; std::_Rb_tree<_Key, _Val,
> _KeyOfValue, _Compare, _Alloc>::_Link_type =
> std::_Rb_tree_node > >*]’
> /usr/include/c++/9/bits/stl_tree.h:1783:16:   required from
> ‘std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>&
> std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare,
> _Alloc>::operator=(const std::_Rb_tree<_Key, _Val, _KeyOfValue,
> _Compare, _Alloc>&) [with _Key = ZONE*; _Val = std::pair std::unique_ptr >; _KeyOfValue =
> std::_Select1st > >;
> _Compare = std::less; _Alloc = std::allocator const, 

[Kicad-developers] Build error.

[Wayne Stambaugh]

Looks like a commit in the last 24 hours broke KiCad builds with Python
enabled.  Here is the build error on Linux using gcc 9.3.0.

In file included from
/usr/include/x86_64-linux-gnu/c++/9/bits/c++allocator.h:33,
 from /usr/include/c++/9/bits/allocator.h:46,
 from /usr/include/c++/9/string:41,
 from /usr/include/c++/9/stdexcept:39,
 from
/home/wayne/build/kicad/trunk-debug-gtk3-phoenix-occt/pcbnew/pcbnew_wrap.cxx:3006:
/usr/include/c++/9/ext/new_allocator.h: In instantiation of ‘void
__gnu_cxx::new_allocator<_Tp>::construct(_Up*, _Args&& ...) [with _Up =
std::pair >; _Args = {const
std::pair > >&}; _Tp =
std::_Rb_tree_node > >]’:
/usr/include/c++/9/bits/alloc_traits.h:482:2:   required from ‘static
void std::allocator_traits
>::construct(std::allocator_traits
>::allocator_type&, _Up*, _Args&& ...) [with _Up = std::pair >; _Args = {const std::pair > >&};
_Tp = std::_Rb_tree_node > >;
std::allocator_traits >::allocator_type =
std::allocator > > >]’
/usr/include/c++/9/bits/stl_tree.h:614:32:   required from ‘void
std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare,
_Alloc>::_M_construct_node(std::_Rb_tree<_Key, _Val, _KeyOfValue,
_Compare, _Alloc>::_Link_type, _Args&& ...) [with _Args = {const
std::pair > >&}; _Key = ZONE*; _Val =
std::pair >; _KeyOfValue =
std::_Select1st > >;
_Compare = std::less; _Alloc = std::allocator > >; std::_Rb_tree<_Key, _Val,
_KeyOfValue, _Compare, _Alloc>::_Link_type =
std::_Rb_tree_node > >*]’
/usr/include/c++/9/bits/stl_tree.h:487:3:   required from
‘std::_Rb_tree_node<_Val>* std::_Rb_tree<_Key, _Val, _KeyOfValue,
_Compare, _Alloc>::_Reuse_or_alloc_node::operator()(_Arg&&) [with _Arg =
const std::pair >&; _Key =
ZONE*; _Val = std::pair >;
_KeyOfValue = std::_Select1st > >; _Compare = std::less; _Alloc =
std::allocator > >;
std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::_Link_type =
std::_Rb_tree_node > >*]’
/usr/include/c++/9/bits/stl_tree.h:658:33:   required from
‘std::_Rb_tree_node<_Val>* std::_Rb_tree<_Key, _Val, _KeyOfValue,
_Compare, _Alloc>::_M_clone_node(std::_Rb_tree<_Key, _Val, _KeyOfValue,
_Compare, _Alloc>::_Const_Link_type, _NodeGen&) [with _NodeGen =
std::_Rb_tree
>, std::_Select1st >
>, std::less, std::allocator > > >::_Reuse_or_alloc_node; _Key = ZONE*;
_Val = std::pair >; _KeyOfValue
= std::_Select1st > >;
_Compare = std::less; _Alloc = std::allocator > >; std::_Rb_tree<_Key, _Val,
_KeyOfValue, _Compare, _Alloc>::_Link_type =
std::_Rb_tree_node >
>*; std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare,
_Alloc>::_Const_Link_type = const std::_Rb_tree_node > >*]’
/usr/include/c++/9/bits/stl_tree.h:1875:13:   required from
‘std::_Rb_tree_node<_Val>* std::_Rb_tree<_Key, _Val, _KeyOfValue,
_Compare, _Alloc>::_M_copy(std::_Rb_tree<_Key, _Val, _KeyOfValue,
_Compare, _Alloc>::_Const_Link_type, std::_Rb_tree<_Key, _Val,
_KeyOfValue, _Compare, _Alloc>::_Base_ptr, _NodeGen&) [with _NodeGen =
std::_Rb_tree
>, std::_Select1st >
>, std::less, std::allocator > > >::_Reuse_or_alloc_node; _Key = ZONE*;
_Val = std::pair >; _KeyOfValue
= std::_Select1st > >;
_Compare = std::less; _Alloc = std::allocator > >; std::_Rb_tree<_Key, _Val,
_KeyOfValue, _Compare, _Alloc>::_Link_type =
std::_Rb_tree_node >
>*; std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare,
_Alloc>::_Const_Link_type = const std::_Rb_tree_node > >*; std::_Rb_tree<_Key, _Val,
_KeyOfValue, _Compare, _Alloc>::_Base_ptr = std::_Rb_tree_node_base*]’
/usr/include/c++/9/bits/stl_tree.h:901:15:   required from
‘std::_Rb_tree_node<_Val>* std::_Rb_tree<_Key, _Val, _KeyOfValue,
_Compare, _Alloc>::_M_copy(const std::_Rb_tree<_Key, _Val, _KeyOfValue,
_Compare, _Alloc>&, _NodeGen&) [with _NodeGen = std::_Rb_tree >,
std::_Select1st > >,
std::less, std::allocator > > >::_Reuse_or_alloc_node; _Key = ZONE*;
_Val = std::pair >; _KeyOfValue
= std::_Select1st > >;
_Compare = std::less; _Alloc = std::allocator > >; std::_Rb_tree<_Key, _Val,
_KeyOfValue, _Compare, _Alloc>::_Link_type =
std::_Rb_tree_node > >*]’
/usr/include/c++/9/bits/stl_tree.h:1783:16:   required from
‘std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>&
std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare,
_Alloc>::operator=(const std::_Rb_tree<_Key, _Val, _KeyOfValue,
_Compare, _Alloc>&) [with _Key = ZONE*; _Val = std::pair >; _KeyOfValue =
std::_Select1st > >;
_Compare = std::less; _Alloc = std::allocator > >]’
/usr/include/c++/9/bits/stl_map.h:100:11:   required from here
/usr/include/c++/9/ext/new_allocator.h:145:20: error: use of deleted
function ‘constexpr std::pair<_T1, _T2>::pair(const std::pair<_T1,
_T2>&) [with _T1 = ZONE* const; _T2 = std::unique_ptr]’
  145 |  noexcept(noexcept(::new((void *)__p)
  |^~
  146 |_Up(std::forward<_Args>(__args)...)))
  |~~~
In file included from /usr/include/c++/9/bits/stl_algobase.h:64,
 from /usr/include/c++/9/bits/char_traits.h:39,
 from 

Re: [Kicad-developers] Build error

[Wayne Stambaugh]

All good here.  Thanks.

On 6/10/20 8:52 AM, Jeff Young wrote:
> I’ve merged an attempted fix.  (Of course the previous one compiled fine on 
> CLang too, so I’m not 100% confident in it -- but it seem to fit the error 
> GCC was generating.)
> 
>> On 10 Jun 2020, at 12:59, Wayne Stambaugh  wrote:
>>
>> I forgot to mention, lead devs please do not commit any new code until
>> this gets fixed.
>>
>> On 6/10/20 7:14 AM, Wayne Stambaugh wrote:
>>> As of commit 4138c8554 I'm getting the following build error on linux.
>>>
>>> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp: In
>>> constructor ‘DRC_RULES_PARSER::DRC_RULES_PARSER(BOARD*, const wxString&,
>>> const wxString&)’:
>>> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:36:26: error:
>>> invalid user-defined conversion from ‘const wxString’ to ‘FILE*’ {aka
>>> ‘_IO_FILE*’} [-fpermissive]
>>>   36 | DRC_RULES_LEXER( aSource, aSourceDescr ),
>>>  |  ^~~
>>> In file included from /usr/include/wx-3.0/wx/memory.h:15,
>>> from /usr/include/wx-3.0/wx/object.h:19,
>>> from /usr/include/wx-3.0/wx/wx.h:15,
>>> from /home/wayne/src/kicad-trunk/include/fctsys.h:28,
>>> from
>>> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:25:
>>> /usr/include/wx-3.0/wx/string.h:1629:5: note: candidate is:
>>> ‘wxString::operator const void*() const’ 
>>> 1629 | operator const void*() const { return c_str(); }
>>>  | ^~~~
>>> /usr/include/wx-3.0/wx/string.h:1629:5: note:   no known conversion from
>>> ‘const void*’ to ‘FILE*’ {aka ‘_IO_FILE*’}
>>> In file included from
>>> /home/wayne/src/kicad-trunk/pcbnew/./drc/drc_rule_parser.h:31,
>>> from
>>> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:26:
>>> /home/wayne/build/kicad/trunk-debug-gtk3-python/common/drc_rules_lexer.h:108:28:
>>> note:   initializing argument 1 of
>>> ‘DRC_RULES_LEXER::DRC_RULES_LEXER(FILE*, const wxString&)’
>>>  108 | DRC_RULES_LEXER( FILE* aFile, const wxString& aFilename ) :
>>>  |  ~~^
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build error: Now compiles for me.

[Drew Fustini]

On Wed, Jun 10, 2020 at 3:18 PM Dino Ghilardi  wrote:
>
> No more build error on my machine (gcc 6.3.0)
>
>
> Cheers,
> Dino.
>

I've been able to build master ( d7d877241 ) ok with GCC 9.3.0:

Application: Pcbnew
Version: (5.99.0-1936-gd7d877241), debug build
Libraries:
wxWidgets 3.0.4
libcurl/7.68.0 GnuTLS/3.6.13 zlib/1.2.11 brotli/1.0.7
libidn2/2.2.0 libpsl/0.21.0 (+libidn2/2.2.0) libssh/0.9.3/openssl/zlib
nghttp2/1.40.0 librtmp/2.3
Platform: Linux 5.7.0+ x86_64, 64 bit, Little endian, wxGTK
Build Info:
Build date: Jun 10 2020 15:35:24
wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
Boost: 1.71.0
OCE: 6.9.1
Curl: 7.68.0
Compiler: GCC 9.3.0 with C++ ABI 1013
Build settings:
KICAD_SCRIPTING=ON
KICAD_SCRIPTING_MODULES=ON
KICAD_SCRIPTING_PYTHON3=OFF
KICAD_SCRIPTING_WXPYTHON=ON
KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
KICAD_SCRIPTING_ACTION_MENU=ON
BUILD_GITHUB_PLUGIN=ON
KICAD_USE_OCE=ON
KICAD_SPICE=ON
KICAD_STDLIB_DEBUG=OFF
KICAD_STDLIB_LIGHT_DEBUG=OFF
KICAD_SANITIZE=OFF

-drew

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build error: Now compiles for me.

[Jeff Young]

Thanks, Dino!

> On 10 Jun 2020, at 14:18, Dino Ghilardi  wrote:
> 
> No more build error on my machine (gcc 6.3.0)
> 
> 
> Cheers,
> Dino.
> 
> On 10/06/20 14:52, Jeff Young wrote:
>> I’ve merged an attempted fix.  (Of course the previous one compiled fine on 
>> CLang too, so I’m not 100% confident in it -- but it seem to fit the error 
>> GCC was generating.)
>>> On 10 Jun 2020, at 12:59, Wayne Stambaugh  wrote:
>>> 
>>> I forgot to mention, lead devs please do not commit any new code until
>>> this gets fixed.
>>> 
>>> On 6/10/20 7:14 AM, Wayne Stambaugh wrote:
 As of commit 4138c8554 I'm getting the following build error on linux.
 
 /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp: In
 constructor ‘DRC_RULES_PARSER::DRC_RULES_PARSER(BOARD*, const wxString&,
 const wxString&)’:
 /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:36:26: error:
 invalid user-defined conversion from ‘const wxString’ to ‘FILE*’ {aka
 ‘_IO_FILE*’} [-fpermissive]
   36 | DRC_RULES_LEXER( aSource, aSourceDescr ),
  |  ^~~
 In file included from /usr/include/wx-3.0/wx/memory.h:15,
 from /usr/include/wx-3.0/wx/object.h:19,
 from /usr/include/wx-3.0/wx/wx.h:15,
 from /home/wayne/src/kicad-trunk/include/fctsys.h:28,
 from
 /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:25:
 /usr/include/wx-3.0/wx/string.h:1629:5: note: candidate is:
 ‘wxString::operator const void*() const’ 
 1629 | operator const void*() const { return c_str(); }
  | ^~~~
 /usr/include/wx-3.0/wx/string.h:1629:5: note:   no known conversion from
 ‘const void*’ to ‘FILE*’ {aka ‘_IO_FILE*’}
 In file included from
 /home/wayne/src/kicad-trunk/pcbnew/./drc/drc_rule_parser.h:31,
 from
 /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:26:
 /home/wayne/build/kicad/trunk-debug-gtk3-python/common/drc_rules_lexer.h:108:28:
 note:   initializing argument 1 of
 ‘DRC_RULES_LEXER::DRC_RULES_LEXER(FILE*, const wxString&)’
  108 | DRC_RULES_LEXER( FILE* aFile, const wxString& aFilename ) :
  |  ~~^
 
>>> 
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build error: Now compiles for me.

[Dino Ghilardi]

No more build error on my machine (gcc 6.3.0)


Cheers,
Dino.

On 10/06/20 14:52, Jeff Young wrote:

I’ve merged an attempted fix.  (Of course the previous one compiled fine on 
CLang too, so I’m not 100% confident in it -- but it seem to fit the error GCC 
was generating.)


On 10 Jun 2020, at 12:59, Wayne Stambaugh  wrote:

I forgot to mention, lead devs please do not commit any new code until
this gets fixed.

On 6/10/20 7:14 AM, Wayne Stambaugh wrote:

As of commit 4138c8554 I'm getting the following build error on linux.

/home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp: In
constructor ‘DRC_RULES_PARSER::DRC_RULES_PARSER(BOARD*, const wxString&,
const wxString&)’:
/home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:36:26: error:
invalid user-defined conversion from ‘const wxString’ to ‘FILE*’ {aka
‘_IO_FILE*’} [-fpermissive]
   36 | DRC_RULES_LEXER( aSource, aSourceDescr ),
  |  ^~~
In file included from /usr/include/wx-3.0/wx/memory.h:15,
 from /usr/include/wx-3.0/wx/object.h:19,
 from /usr/include/wx-3.0/wx/wx.h:15,
 from /home/wayne/src/kicad-trunk/include/fctsys.h:28,
 from
/home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:25:
/usr/include/wx-3.0/wx/string.h:1629:5: note: candidate is:
‘wxString::operator const void*() const’ 
1629 | operator const void*() const { return c_str(); }
  | ^~~~
/usr/include/wx-3.0/wx/string.h:1629:5: note:   no known conversion from
‘const void*’ to ‘FILE*’ {aka ‘_IO_FILE*’}
In file included from
/home/wayne/src/kicad-trunk/pcbnew/./drc/drc_rule_parser.h:31,
 from
/home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:26:
/home/wayne/build/kicad/trunk-debug-gtk3-python/common/drc_rules_lexer.h:108:28:
note:   initializing argument 1 of
‘DRC_RULES_LEXER::DRC_RULES_LEXER(FILE*, const wxString&)’
  108 | DRC_RULES_LEXER( FILE* aFile, const wxString& aFilename ) :
  |  ~~^



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp




___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build error

[Jeff Young]

I’ve merged an attempted fix.  (Of course the previous one compiled fine on 
CLang too, so I’m not 100% confident in it -- but it seem to fit the error GCC 
was generating.)

> On 10 Jun 2020, at 12:59, Wayne Stambaugh  wrote:
> 
> I forgot to mention, lead devs please do not commit any new code until
> this gets fixed.
> 
> On 6/10/20 7:14 AM, Wayne Stambaugh wrote:
>> As of commit 4138c8554 I'm getting the following build error on linux.
>> 
>> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp: In
>> constructor ‘DRC_RULES_PARSER::DRC_RULES_PARSER(BOARD*, const wxString&,
>> const wxString&)’:
>> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:36:26: error:
>> invalid user-defined conversion from ‘const wxString’ to ‘FILE*’ {aka
>> ‘_IO_FILE*’} [-fpermissive]
>>   36 | DRC_RULES_LEXER( aSource, aSourceDescr ),
>>  |  ^~~
>> In file included from /usr/include/wx-3.0/wx/memory.h:15,
>> from /usr/include/wx-3.0/wx/object.h:19,
>> from /usr/include/wx-3.0/wx/wx.h:15,
>> from /home/wayne/src/kicad-trunk/include/fctsys.h:28,
>> from
>> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:25:
>> /usr/include/wx-3.0/wx/string.h:1629:5: note: candidate is:
>> ‘wxString::operator const void*() const’ 
>> 1629 | operator const void*() const { return c_str(); }
>>  | ^~~~
>> /usr/include/wx-3.0/wx/string.h:1629:5: note:   no known conversion from
>> ‘const void*’ to ‘FILE*’ {aka ‘_IO_FILE*’}
>> In file included from
>> /home/wayne/src/kicad-trunk/pcbnew/./drc/drc_rule_parser.h:31,
>> from
>> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:26:
>> /home/wayne/build/kicad/trunk-debug-gtk3-python/common/drc_rules_lexer.h:108:28:
>> note:   initializing argument 1 of
>> ‘DRC_RULES_LEXER::DRC_RULES_LEXER(FILE*, const wxString&)’
>>  108 | DRC_RULES_LEXER( FILE* aFile, const wxString& aFilename ) :
>>  |  ~~^
>> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build error

[Wayne Stambaugh]

I forgot to mention, lead devs please do not commit any new code until
this gets fixed.

On 6/10/20 7:14 AM, Wayne Stambaugh wrote:
> As of commit 4138c8554 I'm getting the following build error on linux.
> 
> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp: In
> constructor ‘DRC_RULES_PARSER::DRC_RULES_PARSER(BOARD*, const wxString&,
> const wxString&)’:
> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:36:26: error:
> invalid user-defined conversion from ‘const wxString’ to ‘FILE*’ {aka
> ‘_IO_FILE*’} [-fpermissive]
>36 | DRC_RULES_LEXER( aSource, aSourceDescr ),
>   |  ^~~
> In file included from /usr/include/wx-3.0/wx/memory.h:15,
>  from /usr/include/wx-3.0/wx/object.h:19,
>  from /usr/include/wx-3.0/wx/wx.h:15,
>  from /home/wayne/src/kicad-trunk/include/fctsys.h:28,
>  from
> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:25:
> /usr/include/wx-3.0/wx/string.h:1629:5: note: candidate is:
> ‘wxString::operator const void*() const’ 
>  1629 | operator const void*() const { return c_str(); }
>   | ^~~~
> /usr/include/wx-3.0/wx/string.h:1629:5: note:   no known conversion from
> ‘const void*’ to ‘FILE*’ {aka ‘_IO_FILE*’}
> In file included from
> /home/wayne/src/kicad-trunk/pcbnew/./drc/drc_rule_parser.h:31,
>  from
> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:26:
> /home/wayne/build/kicad/trunk-debug-gtk3-python/common/drc_rules_lexer.h:108:28:
> note:   initializing argument 1 of
> ‘DRC_RULES_LEXER::DRC_RULES_LEXER(FILE*, const wxString&)’
>   108 | DRC_RULES_LEXER( FILE* aFile, const wxString& aFilename ) :
>   |  ~~^
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Build error

[Wayne Stambaugh]

As of commit 4138c8554 I'm getting the following build error on linux.

/home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp: In
constructor ‘DRC_RULES_PARSER::DRC_RULES_PARSER(BOARD*, const wxString&,
const wxString&)’:
/home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:36:26: error:
invalid user-defined conversion from ‘const wxString’ to ‘FILE*’ {aka
‘_IO_FILE*’} [-fpermissive]
   36 | DRC_RULES_LEXER( aSource, aSourceDescr ),
  |  ^~~
In file included from /usr/include/wx-3.0/wx/memory.h:15,
 from /usr/include/wx-3.0/wx/object.h:19,
 from /usr/include/wx-3.0/wx/wx.h:15,
 from /home/wayne/src/kicad-trunk/include/fctsys.h:28,
 from
/home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:25:
/usr/include/wx-3.0/wx/string.h:1629:5: note: candidate is:
‘wxString::operator const void*() const’ 
 1629 | operator const void*() const { return c_str(); }
  | ^~~~
/usr/include/wx-3.0/wx/string.h:1629:5: note:   no known conversion from
‘const void*’ to ‘FILE*’ {aka ‘_IO_FILE*’}
In file included from
/home/wayne/src/kicad-trunk/pcbnew/./drc/drc_rule_parser.h:31,
 from
/home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:26:
/home/wayne/build/kicad/trunk-debug-gtk3-python/common/drc_rules_lexer.h:108:28:
note:   initializing argument 1 of
‘DRC_RULES_LEXER::DRC_RULES_LEXER(FILE*, const wxString&)’
  108 | DRC_RULES_LEXER( FILE* aFile, const wxString& aFilename ) :
  |  ~~^

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] build error on macos on 5.1 branch

[Adam Wolf]

It's all fixed.  Thanks!

On Thu, Jul 11, 2019 at 5:32 PM Adam Wolf  wrote:
>
> Thanks!
>
> On Thu, Jul 11, 2019, 2:36 PM Seth Hillbrand  wrote:
>>
>> Ah, I see Jeff fixed up my commit for OSX in the master branch.  I've
>> cherry-picked his fix for 5.1.  Let me know if it doesn't fix it.
>>
>> Best-
>> Seth
>>
>> On 2019-07-11 13:59, Adam Wolf wrote:
>> > Builds at at 044b4a6d4 on master went through fine.
>> >
>> > Adam
>> >
>> > On Thu, Jul 11, 2019 at 11:04 AM Seth Hillbrand 
>> > wrote:
>> >>
>> >> Hi Adam-
>> >>
>> >> This looks like the result of a cherry-pick I did the other day.  Do
>> >> you
>> >> get this error in the master branch as well?
>> >>
>> >> -S
>> >>
>> >> On 2019-07-11 11:55, Adam Wolf wrote:
>> >> > Hi folks!
>> >> >
>> >> > Running into a build error on my macOS jobs for 5.1:
>> >> >
>> >> > I'm adding what I think is the appropriate message...
>> >> >
>> >> >
>> >> > 05:46:01 default: [ 69%] Building CXX object
>> >> > pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/import_gfx/graphics_import_mgr.cpp.o
>> >> > 05:46:04 default: In file included from
>> >> > /vagrant/build/kicad/src/kicad/pcbnew/import_gfx/graphics_import_mgr.cpp:27:
>> >> > 05:46:04 default:
>> >> > /vagrant/build/kicad/src/kicad/pcbnew/import_gfx/dxf_import_plugin.h:
>> >> > 05:46:04 default: 151:16:
>> >> > 05:46:04 default: error: no matching constructor for
>> >> > initialization of 'wxArrayString'
>> >> > 05:46:04 default: return wxArrayString( 1,
>> >> > formatWildcardExt( "dxf" ) );
>> >> > 05:46:04 default:^
>> >> > ~
>> >> > 05:46:04 default:
>> >> > /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:54:
>> >> > 05:46:04 default: 5: note: candidate constructor not viable: no
>> >> > known conversion from 'wxString' to 'const char **' for 2nd argument
>> >> > 05:46:04 default:
>> >> > 05:46:04 default: wxArrayString(size_t sz, const char** a);
>> >> > 05:46:04 default: ^
>> >> > 05:46:04 default:
>> >> > /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:55:5:
>> >> > 05:46:04 default: note: candidate constructor not viable: no known
>> >> > conversion from 'wxString' to 'const wchar_t **' for 2nd argument
>> >> > 05:46:04 default: wxArrayString(size_t sz, const wchar_t** a);
>> >> > 05:46:04 default: ^
>> >> > 05:46:04 default:
>> >> > /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:56
>> >> > 05:46:04 default: :
>> >> > 05:46:04 default: 5: note: candidate constructor not viable: no
>> >> > known conversion from 'wxString' to 'const wxString *' for 2nd
>> >> > argument
>> >> > 05:46:04 default: wxArrayString(size_t sz, const wxString* a);
>> >> > 05:46:04 default: ^
>> >> > 05:46:04 default:
>> >> > /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:53:5:
>> >> > 05:46:04 default: note: candidate constructor not viable: requires
>> >> > single argument 'a', but 2 arguments were provided
>> >> > 05:46:04 default: wxArrayString(const wxArrayString& a) :
>> >> > wxArrayStringBase(a) { }
>> >> > 05:46:04 default: ^
>> >> > 05:46:04 default:
>> >> > /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:52:5: note
>> >> > 05:46:04 default: : candidate constructor not viable: requires 0
>> >> > arguments, but 2 were provided
>> >> > 05:46:04 default: wxArrayString() { }
>> >> > 05:46:04 default: ^
>> >> > 05:46:04 default: In file included from
>> >> > /vagrant/build/kicad/src/kicad/pcbnew/import_gfx/graphics_import_mgr.cpp:28:
>> >> > 05:46:04 default:
>> >> > /vagrant/build/kicad/src/kicad/pcbnew/import_gfx/svg_import_plugin.h:49:16:
>> >> > error: no matching constructor for initialization of 'wxArrayString'
>> >> > 05:46:04 default: return wxArrayString( 1,
>> >> > formatWildcardExt( "svg" ) );
>> >> > 05:46:04 default:^
>> >> > ~
>> >> > 05:46:04 default:
>> >> > /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:54:5: note:
>> >> > candidate constructor not viable: no known conversion from 'wxString'
>> >> > to 'const char **' for 2nd argument
>> >> > 05:46:04 default: wxArrayString(size_t sz, const char** a);
>> >> > 05:46:04 default:
>> >> > 05:46:04 default: ^
>> >> > 05:46:04 default:
>> >> > /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:55:5:
>> >> > 05:46:04 default: note: candidate constructor not viable: no known
>> >> > conversion from 'wxString' to 'const wchar_t **' for 2nd argument
>> >> > 05:46:04 default: wxArrayString(size_t sz, const wchar_t** a);
>> >> > 05:46:04 default: ^
>> >> > 05:46:04 default:
>> >> > /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:56:
>> >> > 05:46:04 default: 5: note:
>> >> > 05:46:04 default: candidate constructor not viable: no known
>> >> > conversion from 'wxString' to 'const 

Re: [Kicad-developers] build error on macos on 5.1 branch

[Adam Wolf]

Thanks!

On Thu, Jul 11, 2019, 2:36 PM Seth Hillbrand  wrote:

> Ah, I see Jeff fixed up my commit for OSX in the master branch.  I've
> cherry-picked his fix for 5.1.  Let me know if it doesn't fix it.
>
> Best-
> Seth
>
> On 2019-07-11 13:59, Adam Wolf wrote:
> > Builds at at 044b4a6d4 on master went through fine.
> >
> > Adam
> >
> > On Thu, Jul 11, 2019 at 11:04 AM Seth Hillbrand 
> > wrote:
> >>
> >> Hi Adam-
> >>
> >> This looks like the result of a cherry-pick I did the other day.  Do
> >> you
> >> get this error in the master branch as well?
> >>
> >> -S
> >>
> >> On 2019-07-11 11:55, Adam Wolf wrote:
> >> > Hi folks!
> >> >
> >> > Running into a build error on my macOS jobs for 5.1:
> >> >
> >> > I'm adding what I think is the appropriate message...
> >> >
> >> >
> >> > 05:46:01 default: [ 69%] Building CXX object
> >> >
> pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/import_gfx/graphics_import_mgr.cpp.o
> >> > 05:46:04 default: In file included from
> >> >
> /vagrant/build/kicad/src/kicad/pcbnew/import_gfx/graphics_import_mgr.cpp:27:
> >> > 05:46:04 default:
> >> > /vagrant/build/kicad/src/kicad/pcbnew/import_gfx/dxf_import_plugin.h:
> >> > 05:46:04 default: 151:16:
> >> > 05:46:04 default: error: no matching constructor for
> >> > initialization of 'wxArrayString'
> >> > 05:46:04 default: return wxArrayString( 1,
> >> > formatWildcardExt( "dxf" ) );
> >> > 05:46:04 default:^
> >> > ~
> >> > 05:46:04 default:
> >> > /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:54:
> >> > 05:46:04 default: 5: note: candidate constructor not viable: no
> >> > known conversion from 'wxString' to 'const char **' for 2nd argument
> >> > 05:46:04 default:
> >> > 05:46:04 default: wxArrayString(size_t sz, const char** a);
> >> > 05:46:04 default: ^
> >> > 05:46:04 default:
> >> > /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:55:5:
> >> > 05:46:04 default: note: candidate constructor not viable: no known
> >> > conversion from 'wxString' to 'const wchar_t **' for 2nd argument
> >> > 05:46:04 default: wxArrayString(size_t sz, const wchar_t** a);
> >> > 05:46:04 default: ^
> >> > 05:46:04 default:
> >> > /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:56
> >> > 05:46:04 default: :
> >> > 05:46:04 default: 5: note: candidate constructor not viable: no
> >> > known conversion from 'wxString' to 'const wxString *' for 2nd
> >> > argument
> >> > 05:46:04 default: wxArrayString(size_t sz, const wxString* a);
> >> > 05:46:04 default: ^
> >> > 05:46:04 default:
> >> > /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:53:5:
> >> > 05:46:04 default: note: candidate constructor not viable: requires
> >> > single argument 'a', but 2 arguments were provided
> >> > 05:46:04 default: wxArrayString(const wxArrayString& a) :
> >> > wxArrayStringBase(a) { }
> >> > 05:46:04 default: ^
> >> > 05:46:04 default:
> >> > /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:52:5: note
> >> > 05:46:04 default: : candidate constructor not viable: requires 0
> >> > arguments, but 2 were provided
> >> > 05:46:04 default: wxArrayString() { }
> >> > 05:46:04 default: ^
> >> > 05:46:04 default: In file included from
> >> >
> /vagrant/build/kicad/src/kicad/pcbnew/import_gfx/graphics_import_mgr.cpp:28:
> >> > 05:46:04 default:
> >> >
> /vagrant/build/kicad/src/kicad/pcbnew/import_gfx/svg_import_plugin.h:49:16:
> >> > error: no matching constructor for initialization of 'wxArrayString'
> >> > 05:46:04 default: return wxArrayString( 1,
> >> > formatWildcardExt( "svg" ) );
> >> > 05:46:04 default:^
> >> > ~
> >> > 05:46:04 default:
> >> > /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:54:5: note:
> >> > candidate constructor not viable: no known conversion from 'wxString'
> >> > to 'const char **' for 2nd argument
> >> > 05:46:04 default: wxArrayString(size_t sz, const char** a);
> >> > 05:46:04 default:
> >> > 05:46:04 default: ^
> >> > 05:46:04 default:
> >> > /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:55:5:
> >> > 05:46:04 default: note: candidate constructor not viable: no known
> >> > conversion from 'wxString' to 'const wchar_t **' for 2nd argument
> >> > 05:46:04 default: wxArrayString(size_t sz, const wchar_t** a);
> >> > 05:46:04 default: ^
> >> > 05:46:04 default:
> >> > /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:56:
> >> > 05:46:04 default: 5: note:
> >> > 05:46:04 default: candidate constructor not viable: no known
> >> > conversion from 'wxString' to 'const wxString *' for 2nd argument
> >> > 05:46:04 default: wxArrayString(size_t sz, const wxString* a);
> >> > 05:46:04 default:
> >> > 05:46:04 default: ^
> >> > 

Re: [Kicad-developers] build error on macos on 5.1 branch

[Seth Hillbrand]

Ah, I see Jeff fixed up my commit for OSX in the master branch.  I've 
cherry-picked his fix for 5.1.  Let me know if it doesn't fix it.


Best-
Seth

On 2019-07-11 13:59, Adam Wolf wrote:

Builds at at 044b4a6d4 on master went through fine.

Adam

On Thu, Jul 11, 2019 at 11:04 AM Seth Hillbrand  
wrote:


Hi Adam-

This looks like the result of a cherry-pick I did the other day.  Do 
you

get this error in the master branch as well?

-S

On 2019-07-11 11:55, Adam Wolf wrote:
> Hi folks!
>
> Running into a build error on my macOS jobs for 5.1:
>
> I'm adding what I think is the appropriate message...
>
>
> 05:46:01 default: [ 69%] Building CXX object
> 
pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/import_gfx/graphics_import_mgr.cpp.o
> 05:46:04 default: In file included from
> /vagrant/build/kicad/src/kicad/pcbnew/import_gfx/graphics_import_mgr.cpp:27:
> 05:46:04 default:
> /vagrant/build/kicad/src/kicad/pcbnew/import_gfx/dxf_import_plugin.h:
> 05:46:04 default: 151:16:
> 05:46:04 default: error: no matching constructor for
> initialization of 'wxArrayString'
> 05:46:04 default: return wxArrayString( 1,
> formatWildcardExt( "dxf" ) );
> 05:46:04 default:^
> ~
> 05:46:04 default:
> /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:54:
> 05:46:04 default: 5: note: candidate constructor not viable: no
> known conversion from 'wxString' to 'const char **' for 2nd argument
> 05:46:04 default:
> 05:46:04 default: wxArrayString(size_t sz, const char** a);
> 05:46:04 default: ^
> 05:46:04 default:
> /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:55:5:
> 05:46:04 default: note: candidate constructor not viable: no known
> conversion from 'wxString' to 'const wchar_t **' for 2nd argument
> 05:46:04 default: wxArrayString(size_t sz, const wchar_t** a);
> 05:46:04 default: ^
> 05:46:04 default:
> /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:56
> 05:46:04 default: :
> 05:46:04 default: 5: note: candidate constructor not viable: no
> known conversion from 'wxString' to 'const wxString *' for 2nd
> argument
> 05:46:04 default: wxArrayString(size_t sz, const wxString* a);
> 05:46:04 default: ^
> 05:46:04 default:
> /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:53:5:
> 05:46:04 default: note: candidate constructor not viable: requires
> single argument 'a', but 2 arguments were provided
> 05:46:04 default: wxArrayString(const wxArrayString& a) :
> wxArrayStringBase(a) { }
> 05:46:04 default: ^
> 05:46:04 default:
> /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:52:5: note
> 05:46:04 default: : candidate constructor not viable: requires 0
> arguments, but 2 were provided
> 05:46:04 default: wxArrayString() { }
> 05:46:04 default: ^
> 05:46:04 default: In file included from
> /vagrant/build/kicad/src/kicad/pcbnew/import_gfx/graphics_import_mgr.cpp:28:
> 05:46:04 default:
> /vagrant/build/kicad/src/kicad/pcbnew/import_gfx/svg_import_plugin.h:49:16:
> error: no matching constructor for initialization of 'wxArrayString'
> 05:46:04 default: return wxArrayString( 1,
> formatWildcardExt( "svg" ) );
> 05:46:04 default:^
> ~
> 05:46:04 default:
> /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:54:5: note:
> candidate constructor not viable: no known conversion from 'wxString'
> to 'const char **' for 2nd argument
> 05:46:04 default: wxArrayString(size_t sz, const char** a);
> 05:46:04 default:
> 05:46:04 default: ^
> 05:46:04 default:
> /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:55:5:
> 05:46:04 default: note: candidate constructor not viable: no known
> conversion from 'wxString' to 'const wchar_t **' for 2nd argument
> 05:46:04 default: wxArrayString(size_t sz, const wchar_t** a);
> 05:46:04 default: ^
> 05:46:04 default:
> /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:56:
> 05:46:04 default: 5: note:
> 05:46:04 default: candidate constructor not viable: no known
> conversion from 'wxString' to 'const wxString *' for 2nd argument
> 05:46:04 default: wxArrayString(size_t sz, const wxString* a);
> 05:46:04 default:
> 05:46:04 default: ^
> 05:46:04 default:
> /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h
> 05:46:04 default: :53:5:
> 05:46:04 default:  note: candidate constructor not viable:
> requires single argument 'a', but 2 arguments were provided
> 05:46:04 default: wxArrayString(const wxArrayString& a) :
> wxArrayStringBase(a) { }
> 05:46:04 default: ^
> 05:46:04 default:
> /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:
> 05:46:04 default: 52:5
> 05:46:04 default: : note
> 05:46:04 default: : candidate constructor not viable: 

Re: [Kicad-developers] build error on macos on 5.1 branch

[Seth Hillbrand]

Hi Adam-

This looks like the result of a cherry-pick I did the other day.  Do you 
get this error in the master branch as well?


-S

On 2019-07-11 11:55, Adam Wolf wrote:

Hi folks!

Running into a build error on my macOS jobs for 5.1:

I'm adding what I think is the appropriate message...


05:46:01 default: [ 69%] Building CXX object
pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/import_gfx/graphics_import_mgr.cpp.o
05:46:04 default: In file included from
/vagrant/build/kicad/src/kicad/pcbnew/import_gfx/graphics_import_mgr.cpp:27:
05:46:04 default:
/vagrant/build/kicad/src/kicad/pcbnew/import_gfx/dxf_import_plugin.h:
05:46:04 default: 151:16:
05:46:04 default: error: no matching constructor for
initialization of 'wxArrayString'
05:46:04 default: return wxArrayString( 1,
formatWildcardExt( "dxf" ) );
05:46:04 default:^
~
05:46:04 default:
/vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:54:
05:46:04 default: 5: note: candidate constructor not viable: no
known conversion from 'wxString' to 'const char **' for 2nd argument
05:46:04 default:
05:46:04 default: wxArrayString(size_t sz, const char** a);
05:46:04 default: ^
05:46:04 default:
/vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:55:5:
05:46:04 default: note: candidate constructor not viable: no known
conversion from 'wxString' to 'const wchar_t **' for 2nd argument
05:46:04 default: wxArrayString(size_t sz, const wchar_t** a);
05:46:04 default: ^
05:46:04 default:
/vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:56
05:46:04 default: :
05:46:04 default: 5: note: candidate constructor not viable: no
known conversion from 'wxString' to 'const wxString *' for 2nd
argument
05:46:04 default: wxArrayString(size_t sz, const wxString* a);
05:46:04 default: ^
05:46:04 default:
/vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:53:5:
05:46:04 default: note: candidate constructor not viable: requires
single argument 'a', but 2 arguments were provided
05:46:04 default: wxArrayString(const wxArrayString& a) :
wxArrayStringBase(a) { }
05:46:04 default: ^
05:46:04 default:
/vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:52:5: note
05:46:04 default: : candidate constructor not viable: requires 0
arguments, but 2 were provided
05:46:04 default: wxArrayString() { }
05:46:04 default: ^
05:46:04 default: In file included from
/vagrant/build/kicad/src/kicad/pcbnew/import_gfx/graphics_import_mgr.cpp:28:
05:46:04 default:
/vagrant/build/kicad/src/kicad/pcbnew/import_gfx/svg_import_plugin.h:49:16:
error: no matching constructor for initialization of 'wxArrayString'
05:46:04 default: return wxArrayString( 1,
formatWildcardExt( "svg" ) );
05:46:04 default:^
~
05:46:04 default:
/vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:54:5: note:
candidate constructor not viable: no known conversion from 'wxString'
to 'const char **' for 2nd argument
05:46:04 default: wxArrayString(size_t sz, const char** a);
05:46:04 default:
05:46:04 default: ^
05:46:04 default:
/vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:55:5:
05:46:04 default: note: candidate constructor not viable: no known
conversion from 'wxString' to 'const wchar_t **' for 2nd argument
05:46:04 default: wxArrayString(size_t sz, const wchar_t** a);
05:46:04 default: ^
05:46:04 default:
/vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:56:
05:46:04 default: 5: note:
05:46:04 default: candidate constructor not viable: no known
conversion from 'wxString' to 'const wxString *' for 2nd argument
05:46:04 default: wxArrayString(size_t sz, const wxString* a);
05:46:04 default:
05:46:04 default: ^
05:46:04 default: 
/vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h

05:46:04 default: :53:5:
05:46:04 default:  note: candidate constructor not viable:
requires single argument 'a', but 2 arguments were provided
05:46:04 default: wxArrayString(const wxArrayString& a) :
wxArrayStringBase(a) { }
05:46:04 default: ^
05:46:04 default: 
/vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:

05:46:04 default: 52:5
05:46:04 default: : note
05:46:04 default: : candidate constructor not viable: requires 0
arguments, but 2 were provided
05:46:04 default: wxArrayString() { }
05:46:04 default: ^
05:46:05 default: 2 errors generated.
05:46:05 default: make[6]: ***
[pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/import_gfx/graphics_import_mgr.cpp.o]
Error 1
05:46:05 default: make[5]: ***
[pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/all] Error 2
05:46:05 default: make[4]: *** [all] Error 2

Thanks folks!

___
Mailing 

[Kicad-developers] build error on macos on 5.1 branch

[Adam Wolf]

Hi folks!

Running into a build error on my macOS jobs for 5.1:

I'm adding what I think is the appropriate message...


05:46:01 default: [ 69%] Building CXX object
pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/import_gfx/graphics_import_mgr.cpp.o
05:46:04 default: In file included from
/vagrant/build/kicad/src/kicad/pcbnew/import_gfx/graphics_import_mgr.cpp:27:
05:46:04 default:
/vagrant/build/kicad/src/kicad/pcbnew/import_gfx/dxf_import_plugin.h:
05:46:04 default: 151:16:
05:46:04 default: error: no matching constructor for
initialization of 'wxArrayString'
05:46:04 default: return wxArrayString( 1,
formatWildcardExt( "dxf" ) );
05:46:04 default:^
~
05:46:04 default:
/vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:54:
05:46:04 default: 5: note: candidate constructor not viable: no
known conversion from 'wxString' to 'const char **' for 2nd argument
05:46:04 default:
05:46:04 default: wxArrayString(size_t sz, const char** a);
05:46:04 default: ^
05:46:04 default:
/vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:55:5:
05:46:04 default: note: candidate constructor not viable: no known
conversion from 'wxString' to 'const wchar_t **' for 2nd argument
05:46:04 default: wxArrayString(size_t sz, const wchar_t** a);
05:46:04 default: ^
05:46:04 default:
/vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:56
05:46:04 default: :
05:46:04 default: 5: note: candidate constructor not viable: no
known conversion from 'wxString' to 'const wxString *' for 2nd
argument
05:46:04 default: wxArrayString(size_t sz, const wxString* a);
05:46:04 default: ^
05:46:04 default:
/vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:53:5:
05:46:04 default: note: candidate constructor not viable: requires
single argument 'a', but 2 arguments were provided
05:46:04 default: wxArrayString(const wxArrayString& a) :
wxArrayStringBase(a) { }
05:46:04 default: ^
05:46:04 default:
/vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:52:5: note
05:46:04 default: : candidate constructor not viable: requires 0
arguments, but 2 were provided
05:46:04 default: wxArrayString() { }
05:46:04 default: ^
05:46:04 default: In file included from
/vagrant/build/kicad/src/kicad/pcbnew/import_gfx/graphics_import_mgr.cpp:28:
05:46:04 default:
/vagrant/build/kicad/src/kicad/pcbnew/import_gfx/svg_import_plugin.h:49:16:
error: no matching constructor for initialization of 'wxArrayString'
05:46:04 default: return wxArrayString( 1,
formatWildcardExt( "svg" ) );
05:46:04 default:^
~
05:46:04 default:
/vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:54:5: note:
candidate constructor not viable: no known conversion from 'wxString'
to 'const char **' for 2nd argument
05:46:04 default: wxArrayString(size_t sz, const char** a);
05:46:04 default:
05:46:04 default: ^
05:46:04 default:
/vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:55:5:
05:46:04 default: note: candidate constructor not viable: no known
conversion from 'wxString' to 'const wchar_t **' for 2nd argument
05:46:04 default: wxArrayString(size_t sz, const wchar_t** a);
05:46:04 default: ^
05:46:04 default:
/vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:56:
05:46:04 default: 5: note:
05:46:04 default: candidate constructor not viable: no known
conversion from 'wxString' to 'const wxString *' for 2nd argument
05:46:04 default: wxArrayString(size_t sz, const wxString* a);
05:46:04 default:
05:46:04 default: ^
05:46:04 default: /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h
05:46:04 default: :53:5:
05:46:04 default:  note: candidate constructor not viable:
requires single argument 'a', but 2 arguments were provided
05:46:04 default: wxArrayString(const wxArrayString& a) :
wxArrayStringBase(a) { }
05:46:04 default: ^
05:46:04 default: /vagrant/build/wxwidgets-dest/include/wx-3.0/wx/arrstr.h:
05:46:04 default: 52:5
05:46:04 default: : note
05:46:04 default: : candidate constructor not viable: requires 0
arguments, but 2 were provided
05:46:04 default: wxArrayString() { }
05:46:04 default: ^
05:46:05 default: 2 errors generated.
05:46:05 default: make[6]: ***
[pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/import_gfx/graphics_import_mgr.cpp.o]
Error 1
05:46:05 default: make[5]: ***
[pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/all] Error 2
05:46:05 default: make[4]: *** [all] Error 2

Thanks folks!

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : 

Re: [Kicad-developers] Build error.

[John Beard]

Hi Wayne,

On 29 March 2019 22:30:27 GMT, Wayne Stambaugh  wrote:
>
> I don't know if I want to force this even though I think it's a good
> idea.  So few of the source files in KiCad adhere to this that it would
> confuse new developers.  However, devs should be aware of the issue.

Sure, it's more of an note than a requirement: "any header that comes
first must implicitly satisfy all its dependencies (in the context of
that compilation unit)". It wasn't intended as a policy requirement.
Indeed, as it's possible to include headers with different
combinations of include paths and defines depending on where you make
the include, it is no guarantee that the header is unbreakable in all
places.

I agree we should not make requirements that do not match the majority
practice in KiCad.

Cheers,

John

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build error.

[Wayne Stambaugh]

Hey John,

On 3/29/2019 9:44 AM, John Beard wrote:
> Hi Wayne,
> 
> Duh, it's a Boost version thing, and I ran it though different
> platforms *except* the old-Boost one. Face, meet palm.
> 
> Funnily enough, as this header is often included first, this one
> *should* be immune to ordering issues.
> 
> Also, I sent a proposal for a modification to the Coding Policy
> document this week, which expands on that header deps point: it notes
> that by making implementations include their "own" headers first in
> the list, all headers that are in a .cpp/.h pair are forced to be
> immune to ordering problems.

I don't know if I want to force this even though I think it's a good
idea.  So few of the source files in KiCad adhere to this that it would
confuse new developers.  However, devs should be aware of the issue.

> 
> It doesn't help for standalone utils headers though, unless, like this
> one, they just happen to also come first in the list.
> 
> Cheers,
> 
> John
> 
> On Fri, Mar 29, 2019 at 1:01 PM Wayne Stambaugh  wrote:
>>
>> Hey John,
>>
>> Thanks for the quick fix.  It could be due to header ordering in the
>> source files.  I generally try to compile the headers separately to
>> catch issues like this.  There is helpful instructions in the coding
>> policy on how to do this.  Given the number of headers included in the
>> KiCad source files, it's easy to overlook this.
>>
>> Cheers,
>>
>> Wayne
>>
>> On 3/29/19 8:53 AM, John Beard wrote:
>>> Hi Wayne,
>>>
>>> Thanks for the heads up. I've pushed a fix to both branches. I'm not
>>> sure why that ever worked silently on Linux GCC/Msys2 GCC/MSVC, but
>>> using std:: is certainly correct. Perhaps a header has a sneaky type
>>> alias somewhere.
>>>
>>> Cheers,
>>>
>>> John
>>>
>>> On Fri, Mar 29, 2019 at 12:30 PM Wayne Stambaugh  
>>> wrote:

 Commit ad76ebd8 broke builds when compiling with clang.

 home/wayne/src/kicad-trunk/qa/unit_test_utils/include/unit_test_utils/unit_test_utils.h:121:24:
 error:
   unknown type name 'nullptr_t'; did you mean 'std::nullptr_t'?
 struct print_log_value
^
std::nullptr_t
 /usr/bin/../lib/gcc/x86_64-linux-gnu/8/../../../../include/x86_64-linux-gnu/c++/8/bits/c++config.h:242:29:
 note:
   'std::nullptr_t' declared here
   typedef decltype(nullptr) nullptr_t;
 ^
 In file included from
 /home/wayne/src/kicad-trunk/qa/common/test_array_options.cpp:29:
 In file included from
 /home/wayne/src/kicad-trunk/qa/unit_test_utils/include/unit_test_utils/geometry.h:28:

 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build error.

[John Beard]

Hi Wayne,

Duh, it's a Boost version thing, and I ran it though different
platforms *except* the old-Boost one. Face, meet palm.

Funnily enough, as this header is often included first, this one
*should* be immune to ordering issues.

Also, I sent a proposal for a modification to the Coding Policy
document this week, which expands on that header deps point: it notes
that by making implementations include their "own" headers first in
the list, all headers that are in a .cpp/.h pair are forced to be
immune to ordering problems.

It doesn't help for standalone utils headers though, unless, like this
one, they just happen to also come first in the list.

Cheers,

John

On Fri, Mar 29, 2019 at 1:01 PM Wayne Stambaugh  wrote:
>
> Hey John,
>
> Thanks for the quick fix.  It could be due to header ordering in the
> source files.  I generally try to compile the headers separately to
> catch issues like this.  There is helpful instructions in the coding
> policy on how to do this.  Given the number of headers included in the
> KiCad source files, it's easy to overlook this.
>
> Cheers,
>
> Wayne
>
> On 3/29/19 8:53 AM, John Beard wrote:
> > Hi Wayne,
> >
> > Thanks for the heads up. I've pushed a fix to both branches. I'm not
> > sure why that ever worked silently on Linux GCC/Msys2 GCC/MSVC, but
> > using std:: is certainly correct. Perhaps a header has a sneaky type
> > alias somewhere.
> >
> > Cheers,
> >
> > John
> >
> > On Fri, Mar 29, 2019 at 12:30 PM Wayne Stambaugh  
> > wrote:
> >>
> >> Commit ad76ebd8 broke builds when compiling with clang.
> >>
> >> home/wayne/src/kicad-trunk/qa/unit_test_utils/include/unit_test_utils/unit_test_utils.h:121:24:
> >> error:
> >>   unknown type name 'nullptr_t'; did you mean 'std::nullptr_t'?
> >> struct print_log_value
> >>^
> >>std::nullptr_t
> >> /usr/bin/../lib/gcc/x86_64-linux-gnu/8/../../../../include/x86_64-linux-gnu/c++/8/bits/c++config.h:242:29:
> >> note:
> >>   'std::nullptr_t' declared here
> >>   typedef decltype(nullptr) nullptr_t;
> >> ^
> >> In file included from
> >> /home/wayne/src/kicad-trunk/qa/common/test_array_options.cpp:29:
> >> In file included from
> >> /home/wayne/src/kicad-trunk/qa/unit_test_utils/include/unit_test_utils/geometry.h:28:
> >>
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to : kicad-developers@lists.launchpad.net
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build error.

[Wayne Stambaugh]

Hey John,

Thanks for the quick fix.  It could be due to header ordering in the
source files.  I generally try to compile the headers separately to
catch issues like this.  There is helpful instructions in the coding
policy on how to do this.  Given the number of headers included in the
KiCad source files, it's easy to overlook this.

Cheers,

Wayne

On 3/29/19 8:53 AM, John Beard wrote:
> Hi Wayne,
> 
> Thanks for the heads up. I've pushed a fix to both branches. I'm not
> sure why that ever worked silently on Linux GCC/Msys2 GCC/MSVC, but
> using std:: is certainly correct. Perhaps a header has a sneaky type
> alias somewhere.
> 
> Cheers,
> 
> John
> 
> On Fri, Mar 29, 2019 at 12:30 PM Wayne Stambaugh  wrote:
>>
>> Commit ad76ebd8 broke builds when compiling with clang.
>>
>> home/wayne/src/kicad-trunk/qa/unit_test_utils/include/unit_test_utils/unit_test_utils.h:121:24:
>> error:
>>   unknown type name 'nullptr_t'; did you mean 'std::nullptr_t'?
>> struct print_log_value
>>^
>>std::nullptr_t
>> /usr/bin/../lib/gcc/x86_64-linux-gnu/8/../../../../include/x86_64-linux-gnu/c++/8/bits/c++config.h:242:29:
>> note:
>>   'std::nullptr_t' declared here
>>   typedef decltype(nullptr) nullptr_t;
>> ^
>> In file included from
>> /home/wayne/src/kicad-trunk/qa/common/test_array_options.cpp:29:
>> In file included from
>> /home/wayne/src/kicad-trunk/qa/unit_test_utils/include/unit_test_utils/geometry.h:28:
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build error.

[John Beard]

Hi Wayne,

Thanks for the heads up. I've pushed a fix to both branches. I'm not
sure why that ever worked silently on Linux GCC/Msys2 GCC/MSVC, but
using std:: is certainly correct. Perhaps a header has a sneaky type
alias somewhere.

Cheers,

John

On Fri, Mar 29, 2019 at 12:30 PM Wayne Stambaugh  wrote:
>
> Commit ad76ebd8 broke builds when compiling with clang.
>
> home/wayne/src/kicad-trunk/qa/unit_test_utils/include/unit_test_utils/unit_test_utils.h:121:24:
> error:
>   unknown type name 'nullptr_t'; did you mean 'std::nullptr_t'?
> struct print_log_value
>^
>std::nullptr_t
> /usr/bin/../lib/gcc/x86_64-linux-gnu/8/../../../../include/x86_64-linux-gnu/c++/8/bits/c++config.h:242:29:
> note:
>   'std::nullptr_t' declared here
>   typedef decltype(nullptr) nullptr_t;
> ^
> In file included from
> /home/wayne/src/kicad-trunk/qa/common/test_array_options.cpp:29:
> In file included from
> /home/wayne/src/kicad-trunk/qa/unit_test_utils/include/unit_test_utils/geometry.h:28:
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Build error.

[Wayne Stambaugh]

Commit ad76ebd8 broke builds when compiling with clang.

home/wayne/src/kicad-trunk/qa/unit_test_utils/include/unit_test_utils/unit_test_utils.h:121:24:
error:
  unknown type name 'nullptr_t'; did you mean 'std::nullptr_t'?
struct print_log_value
   ^
   std::nullptr_t
/usr/bin/../lib/gcc/x86_64-linux-gnu/8/../../../../include/x86_64-linux-gnu/c++/8/bits/c++config.h:242:29:
note:
  'std::nullptr_t' declared here
  typedef decltype(nullptr) nullptr_t;
^
In file included from
/home/wayne/src/kicad-trunk/qa/common/test_array_options.cpp:29:
In file included from
/home/wayne/src/kicad-trunk/qa/unit_test_utils/include/unit_test_utils/geometry.h:28:

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build error on Fedora KiCad copr

[Nick Østergaard]

Thank you, I can confirm that this was the last change that made the
fedora build happy. :)
On Mon, 5 Nov 2018 at 20:33, Wayne Stambaugh  wrote:
>
> John,
>
> I merged your patch.
>
> Thanks,
>
> Wayne
>
> On 11/5/2018 9:49 AM, John Beard wrote:
> > Gah! Wrong patch! Try this.
> > On Mon, Nov 5, 2018 at 2:43 PM Steven A. Falco  
> > wrote:
> >>
> >> On 11/5/18 5:24 AM, John Beard wrote:
> >>> Hi,
> >>>
> >>> This appears to be because something in the build is setting the CMake
> >>> BUILD_SHARED_LIBS option to ON (the default is not set at all). See
> >>> build log line 124.
> >>>
> >>> qa_utils is not explicitly declared STATIC like the rest of KiCad
> >>> internal libs, but it depends on common, which is. This causes Bad
> >>> Things, like being unable to link qa_utils.
> >>>
> >>> Attached is a patch to make qa_utils STATIC, since making KiCad
> >>> internals shareable is not (currently??) possible, so it should
> >>> override the build environment setting if given.
> >>>
> >>> Patch is not Jenkins'ed but it does build for me.
> >>
> >> Interesting.  I get the following:
> >>
> >> [ 73%] Linking CXX shared library libqa_utils.so
> >> cd /builddir/build/BUILD/kicad-r14377-4ad37bc9/qa/qa_utils && 
> >> /usr/bin/cmake -E cmake_link_script CMakeFiles/qa_utils.dir/link.txt 
> >> --verbose=1
> >> /usr/bin/c++ -fPIC -Wall -O2 -g -pipe -Wall -Werror=format-security 
> >> -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions 
> >> -fstack-protector-strong -grecord-gcc-switches 
> >> -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 
> >> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic 
> >> -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection 
> >> -Wsuggest-override -Werror=vla -Wno-unused-local-typedefs 
> >> -Wno-strict-aliasing -pthread -g3 -ggdb3 -DDEBUG 
> >> -Wno-deprecated-declarations -Wl,--no-undefined -Wl,-Bsymbolic -shared 
> >> -Wl,-soname,libqa_utils.so -o libqa_utils.so 
> >> CMakeFiles/qa_utils.dir/stdstream_line_reader.cpp.o -lSTATIC 
> >> ../../common/libcommon.a -pthread -lwx_gtk2u_gl-3.0 -lwx_gtk2u_aui-3.0 
> >> -lwx_gtk2u_adv-3.0 -lwx_gtk2u_html-3.0 -lwx_gtk2u_core-3.0 
> >> -lwx_baseu_net-3.0 -lwx_baseu-3.0 -lwx_baseu_xml-3.0 -lwx_gtk2u_stc-3.0 
> >> ../../common/libgal.a -lGLEW -lcairo -lpixman-1 -lGL -lGLU -lcurl -lssl 
> >> -lcrypto
> >> BUILDSTDERR: /usr/bin/ld: cannot find -lSTATIC
> >> BUILDSTDERR: collect2: error: ld returned 1 exit status
> >> BUILDSTDERR: make[2]: *** 
> >> [qa/qa_utils/CMakeFiles/qa_utils.dir/build.make:97: 
> >> qa/qa_utils/libqa_utils.so] Error 1
> >> make[2]: Leaving directory '/builddir/build/BUILD/kicad-r14377-4ad37bc9'
> >> BUILDSTDERR: make[1]: *** [CMakeFiles/Makefile2:3342: 
> >> qa/qa_utils/CMakeFiles/qa_utils.dir/all] Error 2
> >> BUILDSTDERR: make[1]: *** Waiting for unfinished jobs
> >>
> >> It seems that the makefiles think STATIC is a library.
> >>
> >> Steve
> >>
> >>>
> >>> Cheers,
> >>>
> >>> John
> >>> On Sun, Nov 4, 2018 at 2:16 PM Steven A. Falco  
> >>> wrote:
> 
>  The following discussion is from [KiCad/fedora-packaging] Handle 
>  ambiguous Python shebang (#20).  I'm cross-posting to kicad-developers 
>  since I'm not sure who sees the fedora-packaging emails.  Please don't 
>  hate me. :-)
> 
>  On 11/4/18 6:05 AM, nickoe wrote:
> > The patch was merged upstream, I consider this the replacement for this 
> > pull request. I know the fedora packaging scripts will still warn, but 
> > the error is gone.
> >
> > Next up are some linking issues, if anyone cares to look at the latest 
> > copr build logs.
> 
>  According to the log, we have errors in io_benchmark.cpp:
> 
>  undefined reference to 
>  `IFSTREAM_LINE_READER::IFSTREAM_LINE_READER(wxFileName const&)'
>  undefined reference to `STDISTREAM_LINE_READER::ReadLine()'
>  undefined reference to `IFSTREAM_LINE_READER::Rewind()'
>  undefined reference to 
>  `STDISTREAM_LINE_READER::~STDISTREAM_LINE_READER()'
> 
>  This _might_ be due to b88121e377b7244519715b604bd50026b2af440e (Add an 
>  in-memory STREAM_LINE_READER benchmark), which is the only commit I see 
>  in 2018 that touches io_benchmark.cpp.  Or it could be something that 
>  changed in a Makefile.  I am not knowledgeable enough to determine that.
> 
>  For reference, here is the full text of the error log.  It also mentions 
>  qa_utils/stdstream_line_reader.h, which appears to be part of the same 
>  issue:
> 
>  BUILDSTDERR: /usr/bin/ld: 
>  CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: in function `void 
>  bench_line_reader_reuse(wxFileName const&, int, 
>  BENCH_REPORT&)':
>  BUILDSTDERR: /usr/bin/ld: 
>  CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: in function `void 
>  bench_line_reader_reuse(wxFileName const&, int, 
>  BENCH_REPORT&)':
>  BUILDSTDERR: 
>  

Re: [Kicad-developers] Build error on Fedora KiCad copr

[Wayne Stambaugh]

John,

I merged your patch.

Thanks,

Wayne

On 11/5/2018 9:49 AM, John Beard wrote:
> Gah! Wrong patch! Try this.
> On Mon, Nov 5, 2018 at 2:43 PM Steven A. Falco  wrote:
>>
>> On 11/5/18 5:24 AM, John Beard wrote:
>>> Hi,
>>>
>>> This appears to be because something in the build is setting the CMake
>>> BUILD_SHARED_LIBS option to ON (the default is not set at all). See
>>> build log line 124.
>>>
>>> qa_utils is not explicitly declared STATIC like the rest of KiCad
>>> internal libs, but it depends on common, which is. This causes Bad
>>> Things, like being unable to link qa_utils.
>>>
>>> Attached is a patch to make qa_utils STATIC, since making KiCad
>>> internals shareable is not (currently??) possible, so it should
>>> override the build environment setting if given.
>>>
>>> Patch is not Jenkins'ed but it does build for me.
>>
>> Interesting.  I get the following:
>>
>> [ 73%] Linking CXX shared library libqa_utils.so
>> cd /builddir/build/BUILD/kicad-r14377-4ad37bc9/qa/qa_utils && /usr/bin/cmake 
>> -E cmake_link_script CMakeFiles/qa_utils.dir/link.txt --verbose=1
>> /usr/bin/c++ -fPIC -Wall -O2 -g -pipe -Wall -Werror=format-security 
>> -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions 
>> -fstack-protector-strong -grecord-gcc-switches 
>> -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 
>> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic 
>> -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection 
>> -Wsuggest-override -Werror=vla -Wno-unused-local-typedefs 
>> -Wno-strict-aliasing -pthread -g3 -ggdb3 -DDEBUG 
>> -Wno-deprecated-declarations -Wl,--no-undefined -Wl,-Bsymbolic -shared 
>> -Wl,-soname,libqa_utils.so -o libqa_utils.so 
>> CMakeFiles/qa_utils.dir/stdstream_line_reader.cpp.o -lSTATIC 
>> ../../common/libcommon.a -pthread -lwx_gtk2u_gl-3.0 -lwx_gtk2u_aui-3.0 
>> -lwx_gtk2u_adv-3.0 -lwx_gtk2u_html-3.0 -lwx_gtk2u_core-3.0 
>> -lwx_baseu_net-3.0 -lwx_baseu-3.0 -lwx_baseu_xml-3.0 -lwx_gtk2u_stc-3.0 
>> ../../common/libgal.a -lGLEW -lcairo -lpixman-1 -lGL -lGLU -lcurl -lssl 
>> -lcrypto
>> BUILDSTDERR: /usr/bin/ld: cannot find -lSTATIC
>> BUILDSTDERR: collect2: error: ld returned 1 exit status
>> BUILDSTDERR: make[2]: *** 
>> [qa/qa_utils/CMakeFiles/qa_utils.dir/build.make:97: 
>> qa/qa_utils/libqa_utils.so] Error 1
>> make[2]: Leaving directory '/builddir/build/BUILD/kicad-r14377-4ad37bc9'
>> BUILDSTDERR: make[1]: *** [CMakeFiles/Makefile2:3342: 
>> qa/qa_utils/CMakeFiles/qa_utils.dir/all] Error 2
>> BUILDSTDERR: make[1]: *** Waiting for unfinished jobs
>>
>> It seems that the makefiles think STATIC is a library.
>>
>> Steve
>>
>>>
>>> Cheers,
>>>
>>> John
>>> On Sun, Nov 4, 2018 at 2:16 PM Steven A. Falco  
>>> wrote:

 The following discussion is from [KiCad/fedora-packaging] Handle ambiguous 
 Python shebang (#20).  I'm cross-posting to kicad-developers since I'm not 
 sure who sees the fedora-packaging emails.  Please don't hate me. :-)

 On 11/4/18 6:05 AM, nickoe wrote:
> The patch was merged upstream, I consider this the replacement for this 
> pull request. I know the fedora packaging scripts will still warn, but 
> the error is gone.
>
> Next up are some linking issues, if anyone cares to look at the latest 
> copr build logs.

 According to the log, we have errors in io_benchmark.cpp:

 undefined reference to 
 `IFSTREAM_LINE_READER::IFSTREAM_LINE_READER(wxFileName const&)'
 undefined reference to `STDISTREAM_LINE_READER::ReadLine()'
 undefined reference to `IFSTREAM_LINE_READER::Rewind()'
 undefined reference to `STDISTREAM_LINE_READER::~STDISTREAM_LINE_READER()'

 This _might_ be due to b88121e377b7244519715b604bd50026b2af440e (Add an 
 in-memory STREAM_LINE_READER benchmark), which is the only commit I see in 
 2018 that touches io_benchmark.cpp.  Or it could be something that changed 
 in a Makefile.  I am not knowledgeable enough to determine that.

 For reference, here is the full text of the error log.  It also mentions 
 qa_utils/stdstream_line_reader.h, which appears to be part of the same 
 issue:

 BUILDSTDERR: /usr/bin/ld: CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: 
 in function `void bench_line_reader_reuse(wxFileName 
 const&, int, BENCH_REPORT&)':
 BUILDSTDERR: /usr/bin/ld: CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: 
 in function `void bench_line_reader_reuse(wxFileName 
 const&, int, BENCH_REPORT&)':
 BUILDSTDERR: 
 /builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:143:
  undefined reference to 
 `IFSTREAM_LINE_READER::IFSTREAM_LINE_READER(wxFileName const&)'
 BUILDSTDERR: 
 /builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:143:
  undefined reference to 
 `IFSTREAM_LINE_READER::IFSTREAM_LINE_READER(wxFileName const&)'
 BUILDSTDERR: /usr/bin/ld: 
 

Re: [Kicad-developers] Build error on Fedora KiCad copr

[Steven A. Falco]

On 11/5/18 9:49 AM, John Beard wrote:
> Gah! Wrong patch! Try this.

That's better!  I got a clean build with your new patch.  Please commit it, and 
thanks!

Steve

> On Mon, Nov 5, 2018 at 2:43 PM Steven A. Falco  wrote:
>>
>> On 11/5/18 5:24 AM, John Beard wrote:
>>> Hi,
>>>
>>> This appears to be because something in the build is setting the CMake
>>> BUILD_SHARED_LIBS option to ON (the default is not set at all). See
>>> build log line 124.
>>>
>>> qa_utils is not explicitly declared STATIC like the rest of KiCad
>>> internal libs, but it depends on common, which is. This causes Bad
>>> Things, like being unable to link qa_utils.
>>>
>>> Attached is a patch to make qa_utils STATIC, since making KiCad
>>> internals shareable is not (currently??) possible, so it should
>>> override the build environment setting if given.
>>>
>>> Patch is not Jenkins'ed but it does build for me.
>>
>> Interesting.  I get the following:
>>
>> [ 73%] Linking CXX shared library libqa_utils.so
>> cd /builddir/build/BUILD/kicad-r14377-4ad37bc9/qa/qa_utils && /usr/bin/cmake 
>> -E cmake_link_script CMakeFiles/qa_utils.dir/link.txt --verbose=1
>> /usr/bin/c++ -fPIC -Wall -O2 -g -pipe -Wall -Werror=format-security 
>> -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions 
>> -fstack-protector-strong -grecord-gcc-switches 
>> -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 
>> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic 
>> -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection 
>> -Wsuggest-override -Werror=vla -Wno-unused-local-typedefs 
>> -Wno-strict-aliasing -pthread -g3 -ggdb3 -DDEBUG 
>> -Wno-deprecated-declarations -Wl,--no-undefined -Wl,-Bsymbolic -shared 
>> -Wl,-soname,libqa_utils.so -o libqa_utils.so 
>> CMakeFiles/qa_utils.dir/stdstream_line_reader.cpp.o -lSTATIC 
>> ../../common/libcommon.a -pthread -lwx_gtk2u_gl-3.0 -lwx_gtk2u_aui-3.0 
>> -lwx_gtk2u_adv-3.0 -lwx_gtk2u_html-3.0 -lwx_gtk2u_core-3.0 
>> -lwx_baseu_net-3.0 -lwx_baseu-3.0 -lwx_baseu_xml-3.0 -lwx_gtk2u_stc-3.0 
>> ../../common/libgal.a -lGLEW -lcairo -lpixman-1 -lGL -lGLU -lcurl -lssl 
>> -lcrypto
>> BUILDSTDERR: /usr/bin/ld: cannot find -lSTATIC
>> BUILDSTDERR: collect2: error: ld returned 1 exit status
>> BUILDSTDERR: make[2]: *** 
>> [qa/qa_utils/CMakeFiles/qa_utils.dir/build.make:97: 
>> qa/qa_utils/libqa_utils.so] Error 1
>> make[2]: Leaving directory '/builddir/build/BUILD/kicad-r14377-4ad37bc9'
>> BUILDSTDERR: make[1]: *** [CMakeFiles/Makefile2:3342: 
>> qa/qa_utils/CMakeFiles/qa_utils.dir/all] Error 2
>> BUILDSTDERR: make[1]: *** Waiting for unfinished jobs
>>
>> It seems that the makefiles think STATIC is a library.
>>
>> Steve
>>
>>>
>>> Cheers,
>>>
>>> John
>>> On Sun, Nov 4, 2018 at 2:16 PM Steven A. Falco  
>>> wrote:

 The following discussion is from [KiCad/fedora-packaging] Handle ambiguous 
 Python shebang (#20).  I'm cross-posting to kicad-developers since I'm not 
 sure who sees the fedora-packaging emails.  Please don't hate me. :-)

 On 11/4/18 6:05 AM, nickoe wrote:
> The patch was merged upstream, I consider this the replacement for this 
> pull request. I know the fedora packaging scripts will still warn, but 
> the error is gone.
>
> Next up are some linking issues, if anyone cares to look at the latest 
> copr build logs.

 According to the log, we have errors in io_benchmark.cpp:

 undefined reference to 
 `IFSTREAM_LINE_READER::IFSTREAM_LINE_READER(wxFileName const&)'
 undefined reference to `STDISTREAM_LINE_READER::ReadLine()'
 undefined reference to `IFSTREAM_LINE_READER::Rewind()'
 undefined reference to `STDISTREAM_LINE_READER::~STDISTREAM_LINE_READER()'

 This _might_ be due to b88121e377b7244519715b604bd50026b2af440e (Add an 
 in-memory STREAM_LINE_READER benchmark), which is the only commit I see in 
 2018 that touches io_benchmark.cpp.  Or it could be something that changed 
 in a Makefile.  I am not knowledgeable enough to determine that.

 For reference, here is the full text of the error log.  It also mentions 
 qa_utils/stdstream_line_reader.h, which appears to be part of the same 
 issue:

 BUILDSTDERR: /usr/bin/ld: CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: 
 in function `void bench_line_reader_reuse(wxFileName 
 const&, int, BENCH_REPORT&)':
 BUILDSTDERR: /usr/bin/ld: CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: 
 in function `void bench_line_reader_reuse(wxFileName 
 const&, int, BENCH_REPORT&)':
 BUILDSTDERR: 
 /builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:143:
  undefined reference to 
 `IFSTREAM_LINE_READER::IFSTREAM_LINE_READER(wxFileName const&)'
 BUILDSTDERR: 
 /builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:143:
  undefined reference to 
 `IFSTREAM_LINE_READER::IFSTREAM_LINE_READER(wxFileName 

Re: [Kicad-developers] Build error on Fedora KiCad copr

[John Beard]

Gah! Wrong patch! Try this.
On Mon, Nov 5, 2018 at 2:43 PM Steven A. Falco  wrote:
>
> On 11/5/18 5:24 AM, John Beard wrote:
> > Hi,
> >
> > This appears to be because something in the build is setting the CMake
> > BUILD_SHARED_LIBS option to ON (the default is not set at all). See
> > build log line 124.
> >
> > qa_utils is not explicitly declared STATIC like the rest of KiCad
> > internal libs, but it depends on common, which is. This causes Bad
> > Things, like being unable to link qa_utils.
> >
> > Attached is a patch to make qa_utils STATIC, since making KiCad
> > internals shareable is not (currently??) possible, so it should
> > override the build environment setting if given.
> >
> > Patch is not Jenkins'ed but it does build for me.
>
> Interesting.  I get the following:
>
> [ 73%] Linking CXX shared library libqa_utils.so
> cd /builddir/build/BUILD/kicad-r14377-4ad37bc9/qa/qa_utils && /usr/bin/cmake 
> -E cmake_link_script CMakeFiles/qa_utils.dir/link.txt --verbose=1
> /usr/bin/c++ -fPIC -Wall -O2 -g -pipe -Wall -Werror=format-security 
> -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions 
> -fstack-protector-strong -grecord-gcc-switches 
> -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 
> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic 
> -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection 
> -Wsuggest-override -Werror=vla -Wno-unused-local-typedefs 
> -Wno-strict-aliasing -pthread -g3 -ggdb3 -DDEBUG -Wno-deprecated-declarations 
> -Wl,--no-undefined -Wl,-Bsymbolic -shared -Wl,-soname,libqa_utils.so -o 
> libqa_utils.so CMakeFiles/qa_utils.dir/stdstream_line_reader.cpp.o -lSTATIC 
> ../../common/libcommon.a -pthread -lwx_gtk2u_gl-3.0 -lwx_gtk2u_aui-3.0 
> -lwx_gtk2u_adv-3.0 -lwx_gtk2u_html-3.0 -lwx_gtk2u_core-3.0 -lwx_baseu_net-3.0 
> -lwx_baseu-3.0 -lwx_baseu_xml-3.0 -lwx_gtk2u_stc-3.0 ../../common/libgal.a 
> -lGLEW -lcairo -lpixman-1 -lGL -lGLU -lcurl -lssl -lcrypto
> BUILDSTDERR: /usr/bin/ld: cannot find -lSTATIC
> BUILDSTDERR: collect2: error: ld returned 1 exit status
> BUILDSTDERR: make[2]: *** [qa/qa_utils/CMakeFiles/qa_utils.dir/build.make:97: 
> qa/qa_utils/libqa_utils.so] Error 1
> make[2]: Leaving directory '/builddir/build/BUILD/kicad-r14377-4ad37bc9'
> BUILDSTDERR: make[1]: *** [CMakeFiles/Makefile2:3342: 
> qa/qa_utils/CMakeFiles/qa_utils.dir/all] Error 2
> BUILDSTDERR: make[1]: *** Waiting for unfinished jobs
>
> It seems that the makefiles think STATIC is a library.
>
> Steve
>
> >
> > Cheers,
> >
> > John
> > On Sun, Nov 4, 2018 at 2:16 PM Steven A. Falco  
> > wrote:
> >>
> >> The following discussion is from [KiCad/fedora-packaging] Handle ambiguous 
> >> Python shebang (#20).  I'm cross-posting to kicad-developers since I'm not 
> >> sure who sees the fedora-packaging emails.  Please don't hate me. :-)
> >>
> >> On 11/4/18 6:05 AM, nickoe wrote:
> >>> The patch was merged upstream, I consider this the replacement for this 
> >>> pull request. I know the fedora packaging scripts will still warn, but 
> >>> the error is gone.
> >>>
> >>> Next up are some linking issues, if anyone cares to look at the latest 
> >>> copr build logs.
> >>
> >> According to the log, we have errors in io_benchmark.cpp:
> >>
> >> undefined reference to 
> >> `IFSTREAM_LINE_READER::IFSTREAM_LINE_READER(wxFileName const&)'
> >> undefined reference to `STDISTREAM_LINE_READER::ReadLine()'
> >> undefined reference to `IFSTREAM_LINE_READER::Rewind()'
> >> undefined reference to `STDISTREAM_LINE_READER::~STDISTREAM_LINE_READER()'
> >>
> >> This _might_ be due to b88121e377b7244519715b604bd50026b2af440e (Add an 
> >> in-memory STREAM_LINE_READER benchmark), which is the only commit I see in 
> >> 2018 that touches io_benchmark.cpp.  Or it could be something that changed 
> >> in a Makefile.  I am not knowledgeable enough to determine that.
> >>
> >> For reference, here is the full text of the error log.  It also mentions 
> >> qa_utils/stdstream_line_reader.h, which appears to be part of the same 
> >> issue:
> >>
> >> BUILDSTDERR: /usr/bin/ld: CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: 
> >> in function `void bench_line_reader_reuse(wxFileName 
> >> const&, int, BENCH_REPORT&)':
> >> BUILDSTDERR: /usr/bin/ld: CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: 
> >> in function `void bench_line_reader_reuse(wxFileName 
> >> const&, int, BENCH_REPORT&)':
> >> BUILDSTDERR: 
> >> /builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:143:
> >>  undefined reference to 
> >> `IFSTREAM_LINE_READER::IFSTREAM_LINE_READER(wxFileName const&)'
> >> BUILDSTDERR: 
> >> /builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:143:
> >>  undefined reference to 
> >> `IFSTREAM_LINE_READER::IFSTREAM_LINE_READER(wxFileName const&)'
> >> BUILDSTDERR: /usr/bin/ld: 
> >> /builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:147:
> >>  undefined reference to `STDISTREAM_LINE_READER::ReadLine()'

Re: [Kicad-developers] Build error on Fedora KiCad copr

[Steven A. Falco]

On 11/5/18 5:24 AM, John Beard wrote:
> Hi,
> 
> This appears to be because something in the build is setting the CMake
> BUILD_SHARED_LIBS option to ON (the default is not set at all). See
> build log line 124.
> 
> qa_utils is not explicitly declared STATIC like the rest of KiCad
> internal libs, but it depends on common, which is. This causes Bad
> Things, like being unable to link qa_utils.
> 
> Attached is a patch to make qa_utils STATIC, since making KiCad
> internals shareable is not (currently??) possible, so it should
> override the build environment setting if given.
> 
> Patch is not Jenkins'ed but it does build for me.

Interesting.  I get the following:

[ 73%] Linking CXX shared library libqa_utils.so
cd /builddir/build/BUILD/kicad-r14377-4ad37bc9/qa/qa_utils && /usr/bin/cmake -E 
cmake_link_script CMakeFiles/qa_utils.dir/link.txt --verbose=1
/usr/bin/c++ -fPIC -Wall -O2 -g -pipe -Wall -Werror=format-security 
-Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions 
-fstack-protector-strong -grecord-gcc-switches 
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic 
-fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection 
-Wsuggest-override -Werror=vla -Wno-unused-local-typedefs -Wno-strict-aliasing 
-pthread -g3 -ggdb3 -DDEBUG -Wno-deprecated-declarations -Wl,--no-undefined 
-Wl,-Bsymbolic -shared -Wl,-soname,libqa_utils.so -o libqa_utils.so 
CMakeFiles/qa_utils.dir/stdstream_line_reader.cpp.o -lSTATIC 
../../common/libcommon.a -pthread -lwx_gtk2u_gl-3.0 -lwx_gtk2u_aui-3.0 
-lwx_gtk2u_adv-3.0 -lwx_gtk2u_html-3.0 -lwx_gtk2u_core-3.0 -lwx_baseu_net-3.0 
-lwx_baseu-3.0 -lwx_baseu_xml-3.0 -lwx_gtk2u_stc-3.0 ../../common/libgal.a 
-lGLEW -lcairo -lpixman-1 -lGL -lGLU -lcurl -lssl -lcrypto 
BUILDSTDERR: /usr/bin/ld: cannot find -lSTATIC
BUILDSTDERR: collect2: error: ld returned 1 exit status
BUILDSTDERR: make[2]: *** [qa/qa_utils/CMakeFiles/qa_utils.dir/build.make:97: 
qa/qa_utils/libqa_utils.so] Error 1
make[2]: Leaving directory '/builddir/build/BUILD/kicad-r14377-4ad37bc9'
BUILDSTDERR: make[1]: *** [CMakeFiles/Makefile2:3342: 
qa/qa_utils/CMakeFiles/qa_utils.dir/all] Error 2
BUILDSTDERR: make[1]: *** Waiting for unfinished jobs

It seems that the makefiles think STATIC is a library.

Steve

> 
> Cheers,
> 
> John
> On Sun, Nov 4, 2018 at 2:16 PM Steven A. Falco  wrote:
>>
>> The following discussion is from [KiCad/fedora-packaging] Handle ambiguous 
>> Python shebang (#20).  I'm cross-posting to kicad-developers since I'm not 
>> sure who sees the fedora-packaging emails.  Please don't hate me. :-)
>>
>> On 11/4/18 6:05 AM, nickoe wrote:
>>> The patch was merged upstream, I consider this the replacement for this 
>>> pull request. I know the fedora packaging scripts will still warn, but the 
>>> error is gone.
>>>
>>> Next up are some linking issues, if anyone cares to look at the latest copr 
>>> build logs.
>>
>> According to the log, we have errors in io_benchmark.cpp:
>>
>> undefined reference to 
>> `IFSTREAM_LINE_READER::IFSTREAM_LINE_READER(wxFileName const&)'
>> undefined reference to `STDISTREAM_LINE_READER::ReadLine()'
>> undefined reference to `IFSTREAM_LINE_READER::Rewind()'
>> undefined reference to `STDISTREAM_LINE_READER::~STDISTREAM_LINE_READER()'
>>
>> This _might_ be due to b88121e377b7244519715b604bd50026b2af440e (Add an 
>> in-memory STREAM_LINE_READER benchmark), which is the only commit I see in 
>> 2018 that touches io_benchmark.cpp.  Or it could be something that changed 
>> in a Makefile.  I am not knowledgeable enough to determine that.
>>
>> For reference, here is the full text of the error log.  It also mentions 
>> qa_utils/stdstream_line_reader.h, which appears to be part of the same issue:
>>
>> BUILDSTDERR: /usr/bin/ld: CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: in 
>> function `void bench_line_reader_reuse(wxFileName 
>> const&, int, BENCH_REPORT&)':
>> BUILDSTDERR: /usr/bin/ld: CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: in 
>> function `void bench_line_reader_reuse(wxFileName 
>> const&, int, BENCH_REPORT&)':
>> BUILDSTDERR: 
>> /builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:143:
>>  undefined reference to 
>> `IFSTREAM_LINE_READER::IFSTREAM_LINE_READER(wxFileName const&)'
>> BUILDSTDERR: 
>> /builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:143:
>>  undefined reference to 
>> `IFSTREAM_LINE_READER::IFSTREAM_LINE_READER(wxFileName const&)'
>> BUILDSTDERR: /usr/bin/ld: 
>> /builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:147:
>>  undefined reference to `STDISTREAM_LINE_READER::ReadLine()'
>> BUILDSTDERR: /usr/bin/ld: 
>> /builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:147:
>>  undefined reference to `STDISTREAM_LINE_READER::ReadLine()'
>> BUILDSTDERR: /usr/bin/ld: 
>> 

Re: [Kicad-developers] Build error on Fedora KiCad copr

[John Beard]

Hi,

This appears to be because something in the build is setting the CMake
BUILD_SHARED_LIBS option to ON (the default is not set at all). See
build log line 124.

qa_utils is not explicitly declared STATIC like the rest of KiCad
internal libs, but it depends on common, which is. This causes Bad
Things, like being unable to link qa_utils.

Attached is a patch to make qa_utils STATIC, since making KiCad
internals shareable is not (currently??) possible, so it should
override the build environment setting if given.

Patch is not Jenkins'ed but it does build for me.

Cheers,

John
On Sun, Nov 4, 2018 at 2:16 PM Steven A. Falco  wrote:
>
> The following discussion is from [KiCad/fedora-packaging] Handle ambiguous 
> Python shebang (#20).  I'm cross-posting to kicad-developers since I'm not 
> sure who sees the fedora-packaging emails.  Please don't hate me. :-)
>
> On 11/4/18 6:05 AM, nickoe wrote:
> > The patch was merged upstream, I consider this the replacement for this 
> > pull request. I know the fedora packaging scripts will still warn, but the 
> > error is gone.
> >
> > Next up are some linking issues, if anyone cares to look at the latest copr 
> > build logs.
>
> According to the log, we have errors in io_benchmark.cpp:
>
> undefined reference to `IFSTREAM_LINE_READER::IFSTREAM_LINE_READER(wxFileName 
> const&)'
> undefined reference to `STDISTREAM_LINE_READER::ReadLine()'
> undefined reference to `IFSTREAM_LINE_READER::Rewind()'
> undefined reference to `STDISTREAM_LINE_READER::~STDISTREAM_LINE_READER()'
>
> This _might_ be due to b88121e377b7244519715b604bd50026b2af440e (Add an 
> in-memory STREAM_LINE_READER benchmark), which is the only commit I see in 
> 2018 that touches io_benchmark.cpp.  Or it could be something that changed in 
> a Makefile.  I am not knowledgeable enough to determine that.
>
> For reference, here is the full text of the error log.  It also mentions 
> qa_utils/stdstream_line_reader.h, which appears to be part of the same issue:
>
> BUILDSTDERR: /usr/bin/ld: CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: in 
> function `void bench_line_reader_reuse(wxFileName 
> const&, int, BENCH_REPORT&)':
> BUILDSTDERR: /usr/bin/ld: CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: in 
> function `void bench_line_reader_reuse(wxFileName 
> const&, int, BENCH_REPORT&)':
> BUILDSTDERR: 
> /builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:143:
>  undefined reference to 
> `IFSTREAM_LINE_READER::IFSTREAM_LINE_READER(wxFileName const&)'
> BUILDSTDERR: 
> /builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:143:
>  undefined reference to 
> `IFSTREAM_LINE_READER::IFSTREAM_LINE_READER(wxFileName const&)'
> BUILDSTDERR: /usr/bin/ld: 
> /builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:147:
>  undefined reference to `STDISTREAM_LINE_READER::ReadLine()'
> BUILDSTDERR: /usr/bin/ld: 
> /builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:147:
>  undefined reference to `STDISTREAM_LINE_READER::ReadLine()'
> BUILDSTDERR: /usr/bin/ld: 
> /builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:153:
>  undefined reference to `IFSTREAM_LINE_READER::Rewind()'
> BUILDSTDERR: /usr/bin/ld: 
> /builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:153:
>  undefined reference to `IFSTREAM_LINE_READER::Rewind()'
> BUILDSTDERR: /usr/bin/ld: CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: in 
> function `void bench_line_reader_reuse(wxFileName 
> const&, int, BENCH_REPORT&)':
> BUILDSTDERR: /usr/bin/ld: CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: in 
> function `void bench_line_reader_reuse(wxFileName 
> const&, int, BENCH_REPORT&)':
> BUILDSTDERR: 
> /builddir/build/BUILD/kicad-r14365-75896d76/qa/qa_utils/stdstream_line_reader.h:62:
>  undefined reference to `STDISTREAM_LINE_READER::~STDISTREAM_LINE_READER()'
> BUILDSTDERR: 
> /builddir/build/BUILD/kicad-r14365-75896d76/qa/qa_utils/stdstream_line_reader.h:62:
>  undefined reference to `STDISTREAM_LINE_READER::~STDISTREAM_LINE_READER()'
> BUILDSTDERR: /usr/bin/ld: CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: in 
> function `void bench_line_reader(wxFileName const&, 
> int, BENCH_REPORT&)':
> BUILDSTDERR: /usr/bin/ld: CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: in 
> function `void bench_line_reader(wxFileName const&, 
> int, BENCH_REPORT&)':
> BUILDSTDERR: 
> /builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:126:
>  undefined reference to 
> `IFSTREAM_LINE_READER::IFSTREAM_LINE_READER(wxFileName const&)'
> BUILDSTDERR: 
> /builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:126:
>  undefined reference to 
> `IFSTREAM_LINE_READER::IFSTREAM_LINE_READER(wxFileName const&)'
> BUILDSTDERR: /usr/bin/ld: 
> /builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:127:
>  undefined reference to 

[Kicad-developers] Build error on Fedora KiCad copr

[Steven A. Falco]

The following discussion is from [KiCad/fedora-packaging] Handle ambiguous 
Python shebang (#20).  I'm cross-posting to kicad-developers since I'm not sure 
who sees the fedora-packaging emails.  Please don't hate me. :-)

On 11/4/18 6:05 AM, nickoe wrote:
> The patch was merged upstream, I consider this the replacement for this pull 
> request. I know the fedora packaging scripts will still warn, but the error 
> is gone.
>
> Next up are some linking issues, if anyone cares to look at the latest copr 
> build logs.

According to the log, we have errors in io_benchmark.cpp:

undefined reference to `IFSTREAM_LINE_READER::IFSTREAM_LINE_READER(wxFileName 
const&)'
undefined reference to `STDISTREAM_LINE_READER::ReadLine()'
undefined reference to `IFSTREAM_LINE_READER::Rewind()'
undefined reference to `STDISTREAM_LINE_READER::~STDISTREAM_LINE_READER()'

This _might_ be due to b88121e377b7244519715b604bd50026b2af440e (Add an 
in-memory STREAM_LINE_READER benchmark), which is the only commit I see in 2018 
that touches io_benchmark.cpp.  Or it could be something that changed in a 
Makefile.  I am not knowledgeable enough to determine that.

For reference, here is the full text of the error log.  It also mentions 
qa_utils/stdstream_line_reader.h, which appears to be part of the same issue:

BUILDSTDERR: /usr/bin/ld: CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: in 
function `void bench_line_reader_reuse(wxFileName const&, 
int, BENCH_REPORT&)':
BUILDSTDERR: /usr/bin/ld: CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: in 
function `void bench_line_reader_reuse(wxFileName const&, 
int, BENCH_REPORT&)':
BUILDSTDERR: 
/builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:143:
 undefined reference to `IFSTREAM_LINE_READER::IFSTREAM_LINE_READER(wxFileName 
const&)'
BUILDSTDERR: 
/builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:143:
 undefined reference to `IFSTREAM_LINE_READER::IFSTREAM_LINE_READER(wxFileName 
const&)'
BUILDSTDERR: /usr/bin/ld: 
/builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:147:
 undefined reference to `STDISTREAM_LINE_READER::ReadLine()'
BUILDSTDERR: /usr/bin/ld: 
/builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:147:
 undefined reference to `STDISTREAM_LINE_READER::ReadLine()'
BUILDSTDERR: /usr/bin/ld: 
/builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:153:
 undefined reference to `IFSTREAM_LINE_READER::Rewind()'
BUILDSTDERR: /usr/bin/ld: 
/builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:153:
 undefined reference to `IFSTREAM_LINE_READER::Rewind()'
BUILDSTDERR: /usr/bin/ld: CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: in 
function `void bench_line_reader_reuse(wxFileName const&, 
int, BENCH_REPORT&)':
BUILDSTDERR: /usr/bin/ld: CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: in 
function `void bench_line_reader_reuse(wxFileName const&, 
int, BENCH_REPORT&)':
BUILDSTDERR: 
/builddir/build/BUILD/kicad-r14365-75896d76/qa/qa_utils/stdstream_line_reader.h:62:
 undefined reference to `STDISTREAM_LINE_READER::~STDISTREAM_LINE_READER()'
BUILDSTDERR: 
/builddir/build/BUILD/kicad-r14365-75896d76/qa/qa_utils/stdstream_line_reader.h:62:
 undefined reference to `STDISTREAM_LINE_READER::~STDISTREAM_LINE_READER()'
BUILDSTDERR: /usr/bin/ld: CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: in 
function `void bench_line_reader(wxFileName const&, int, 
BENCH_REPORT&)':
BUILDSTDERR: /usr/bin/ld: CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: in 
function `void bench_line_reader(wxFileName const&, int, 
BENCH_REPORT&)':
BUILDSTDERR: 
/builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:126:
 undefined reference to `IFSTREAM_LINE_READER::IFSTREAM_LINE_READER(wxFileName 
const&)'
BUILDSTDERR: 
/builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:126:
 undefined reference to `IFSTREAM_LINE_READER::IFSTREAM_LINE_READER(wxFileName 
const&)'
BUILDSTDERR: /usr/bin/ld: 
/builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:127:
 undefined reference to `STDISTREAM_LINE_READER::ReadLine()'
BUILDSTDERR: /usr/bin/ld: 
/builddir/build/BUILD/kicad-r14365-75896d76/tools/io_benchmark/io_benchmark.cpp:127:
 undefined reference to `STDISTREAM_LINE_READER::ReadLine()'
BUILDSTDERR: /usr/bin/ld: CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: in 
function `void bench_line_reader(wxFileName const&, int, 
BENCH_REPORT&)':
BUILDSTDERR: /usr/bin/ld: CMakeFiles/io_benchmark.dir/io_benchmark.cpp.o: in 
function `void bench_line_reader(wxFileName const&, int, 
BENCH_REPORT&)':
BUILDSTDERR: 
/builddir/build/BUILD/kicad-r14365-75896d76/qa/qa_utils/stdstream_line_reader.h:62:
 undefined reference to `STDISTREAM_LINE_READER::~STDISTREAM_LINE_READER()'
BUILDSTDERR: 
/builddir/build/BUILD/kicad-r14365-75896d76/qa/qa_utils/stdstream_line_reader.h:62:
 undefined reference to 

Re: [Kicad-developers] Build error

[Eeli Kaikkonen]

Jeff fixed it with d62145fba9c35916631b3d.

ma 15. lokak. 2018 klo 23.11 Eeli Kaikkonen (eeli.kaikko...@gmail.com)
kirjoitti:

>
>
> ma 15. lokak. 2018 klo 22.59 Wayne Stambaugh (stambau...@gmail.com)
> kirjoitti:
>
>> The latest round of commits causes the following build error (at least
>> on windows).
>>
>> error: 'else' without a previous 'if'
>>
>
> In Linux, too.
>
> -Eeli Kaikkonen
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build error

[Eeli Kaikkonen]

ma 15. lokak. 2018 klo 22.59 Wayne Stambaugh (stambau...@gmail.com)
kirjoitti:

> The latest round of commits causes the following build error (at least
> on windows).
>
> error: 'else' without a previous 'if'
>

In Linux, too.

-Eeli Kaikkonen
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Build error

[Wayne Stambaugh]

The latest round of commits causes the following build error (at least
on windows).

C:/msys64/home/wstambaugh/src/kicad-trunk/pcbnew/pcb_edit_frame.cpp: In
member function 'void
PCB_EDIT_FRAME::InstallFootprintPropertiesDialog(MODULE*, wxDC*)':
C:/msys64/home/wstambaugh/src/kicad-trunk/pcbnew/pcb_edit_frame.cpp:1281:5:
error: 'else' without a previous 'if'
 else if( retvalue ==
DIALOG_FOOTPRINT_BOARD_EDITOR::PRM_EDITOR_EDIT_BOARD_FOOTPRINT )

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build error

[hauptmech]

Sorry, you did and I missed it.

A dependency was missed. I think the following might fix it.

in pcbnew/CMakeLists.txt
-add_dependencies( pcbnew_kiface specctra_lexer_source_files )
+add_dependencies( pcbnew_kiface_objects specctra_lexer_source_files )


On 06/03/18 13:10, Nick Østergaard wrote:
I just gave you hints on how to reproduce this. I suspect the most 
important part is the high number of make jobs. I use cmake version 
3.10.2 on archlinux.


2018-03-06 1:03 GMT+01:00 hauptmech >:


If you have any hints on how to reproduce the failure I can try to
help. The cmake version being used might help.


On 06/03/18 12:55, Nick Østergaard wrote:

I reproduce in a clean workspace like this:
git clone https://github.com/KiCad/kicad-source-mirror.git
 kicad_steven
cd kicad_steven/
mkdir build
cd build/
cmake .. -DKICAD_SCRIPTING=OFF -DKICAD_SCRIPTING_MODULES=OFF
-DKICAD_SCRIPTING_WXPYTHON=OFF
make -j40


On 5.0.0-rc2-dev-101-gf7ef010fe

2018-03-06  0:37 GMT+01:00 Nick Østergaard
>:

Ok, now I also see that issue. It could very easily be that
RPATH commit making the build system unstable. It is a
problem that the generated files are not in the build dir,
but in the source dir.


2018-03-05 23:22 GMT+01:00 Nick Østergaard >:

It also seem to build correctly on jenkins.

2018-03-05 23:16 GMT+01:00 Steven A. Falco
>:

I'm going to retract this report.  It builds
correctly on copr, so the problem must be something
in my local setup.

Sorry for the noise.

        Steve

___
Mailing list: https://launchpad.net/~kicad-developers

Post to     : kicad-developers@lists.launchpad.net

Unsubscribe : https://launchpad.net/~kicad-developers

More help   : https://help.launchpad.net/ListHelp







___
Mailing list:https://launchpad.net/~kicad-developers

Post to :kicad-developers@lists.launchpad.net

Unsubscribe :https://launchpad.net/~kicad-developers

More help   :https://help.launchpad.net/ListHelp





___
Mailing list: https://launchpad.net/~kicad-developers

Post to     : kicad-developers@lists.launchpad.net

Unsubscribe : https://launchpad.net/~kicad-developers

More help   : https://help.launchpad.net/ListHelp





___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build error

[Steven A. Falco]

On 03/05/2018 06:55 PM, Nick Østergaard wrote:
> I reproduce in a clean workspace like this:
> git clone https://github.com/KiCad/kicad-source-mirror.git kicad_steven
> cd kicad_steven/
> mkdir build
> cd build/
> cmake .. -DKICAD_SCRIPTING=OFF -DKICAD_SCRIPTING_MODULES=OFF 
> -DKICAD_SCRIPTING_WXPYTHON=OFF
> make -j40

Thank you, thank you, thank you!

I thought I was going crazy there for a minute - sometimes it would work and 
other times it would fail.  So it looks like a race somewhere.  The contents of 
the generated file suggest that, too.  Here is part of specctra_lexer.h, which 
looks like two iterations of the generator are running simultaneously into the 
same file:

T_LEFT  = DSN_LEFT, // left bracket:  '('
T_STRING= DSN_STRING,   // a quoted string, stripped of the 
quotes
T_EOF   = DSN_EOF,  // special case for end of file

,
T_add_pinsT_absolute = 0,
,
T_add_groupT_added,
T_add_pins,
,
T_allow_antennaT_added,
,
T_allow_antenna,
T_allow_redundant_wiringT_allow_redundant_wiring,
,
T_ampT_amp,

Later on in the generated file there is:


#endif   // SPECCTRA_LEXER_H_
,
T_use_via,
T_value,
T_vertical,

so it looks like one incarnation has ended, and emitted its #endif, but the 
second is still running, and pushes out more values.

The clincher is that I have two copies of DSN::T NextTok() in the generated 
file.

Again for reference I've attached the generated specctra_lexer.h.

So I guess my first report was not noise after all!

Steve


> 
> 
> On 5.0.0-rc2-dev-101-gf7ef010fe
> 
> 2018-03-06 0:37 GMT+01:00 Nick Østergaard  >:
> 
> Ok, now I also see that issue. It could very easily be that RPATH commit 
> making the build system unstable. It is a problem that the generated files 
> are not in the build dir, but in the source dir.
> 
> 
> 2018-03-05 23:22 GMT+01:00 Nick Østergaard  >:
> 
> It also seem to build correctly on jenkins.
> 
> 2018-03-05 23:16 GMT+01:00 Steven A. Falco  >:
> 
> I'm going to retract this report.  It builds correctly on copr, 
> so the problem must be something in my local setup.
> 
> Sorry for the noise.
> 
>         Steve
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers 
> 
> Post to     : kicad-developers@lists.launchpad.net 
> 
> Unsubscribe : https://launchpad.net/~kicad-developers 
> 
> More help   : https://help.launchpad.net/ListHelp 
> 
> 
> 
> 
> 


/* Do not modify this file it was automatically generated by the
 * TokenList2DsnLexer CMake script.
 */

#ifndef SPECCTRA_LEXER_H_
#define SPECCTRA_LEXER_H_

#include 

/**
 * C++ does not put enum _values_ in separate namespaces unless the enum itself
 * is in a separate namespace.  All the token enums must be in separate namespaces
 * otherwise the C++ compiler will eventually complain if it sees more than one
 * DSNLEXER in the same compilation unit, say by mutliple header file inclusion.
 * Plus this also enables re-use of the same enum name T.  A typedef can always be used
 * to clarify which enum T is in play should that ever be a problem.  This is
 * unlikely since Parse() functions will usually only be exposed to one header
 * file like this one.  But if there is a problem, then use:
 *   typedef DSN::T T;
 * within that problem area.
 */
namespace DSN
{
/// enum T contains all this lexer's tokens.
enum T
{
// these first few are negative special ones for syntax, and are
// inherited from DSNLEXER.
T_NONE  = DSN_NONE,
T_COMMENT   = DSN_COMMENT,
T_STRING_QUOTE  = DSN_STRING_QUOTE,
T_QUOTE_DEF = DSN_QUOTE_DEF,
T_DASH  = DSN_DASH,
T_SYMBOL= DSN_SYMBOL,
T_NUMBER= DSN_NUMBER,
T_RIGHT = DSN_RIGHT,// right bracket: ')'
T_LEFT  = DSN_LEFT, // left bracket:  '('
T_STRING= DSN_STRING,   // a quoted string, stripped of the quotes
T_EOF   = DSN_EOF,  // special case for end of file

,
T_add_pinsT_absolute = 0,
,
T_add_groupT_added,
T_add_pins,
,
T_allow_antennaT_added,
,
T_allow_antenna,
T_allow_redundant_wiringT_allow_redundant_wiring,
,
T_ampT_amp,
,
T_ancestor,
T_ancestorT_antipad,
,
T_aperture_type   

Re: [Kicad-developers] Build error

[Nick Østergaard]

I just gave you hints on how to reproduce this. I suspect the most
important part is the high number of make jobs. I use cmake version 3.10.2
on archlinux.

2018-03-06 1:03 GMT+01:00 hauptmech :

> If you have any hints on how to reproduce the failure I can try to help.
> The cmake version being used might help.
>
>
> On 06/03/18 12:55, Nick Østergaard wrote:
>
> I reproduce in a clean workspace like this:
> git clone https://github.com/KiCad/kicad-source-mirror.git kicad_steven
> cd kicad_steven/
> mkdir build
> cd build/
> cmake .. -DKICAD_SCRIPTING=OFF -DKICAD_SCRIPTING_MODULES=OFF
> -DKICAD_SCRIPTING_WXPYTHON=OFF
> make -j40
>
>
> On 5.0.0-rc2-dev-101-gf7ef010fe
>
> 2018-03-06 <20%2018%2003%2006> 0:37 GMT+01:00 Nick Østergaard <
> oe.n...@gmail.com>:
>
>> Ok, now I also see that issue. It could very easily be that RPATH commit
>> making the build system unstable. It is a problem that the generated files
>> are not in the build dir, but in the source dir.
>>
>>
>> 2018-03-05 23:22 GMT+01:00 Nick Østergaard :
>>
>>> It also seem to build correctly on jenkins.
>>>
>>> 2018-03-05 23:16 GMT+01:00 Steven A. Falco :
>>>
 I'm going to retract this report.  It builds correctly on copr, so the
 problem must be something in my local setup.

 Sorry for the noise.

 Steve

 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp

>>>
>>>
>>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build error

[hauptmech]

If you have any hints on how to reproduce the failure I can try to help. 
The cmake version being used might help.


On 06/03/18 12:55, Nick Østergaard wrote:

I reproduce in a clean workspace like this:
git clone https://github.com/KiCad/kicad-source-mirror.git kicad_steven
cd kicad_steven/
mkdir build
cd build/
cmake .. -DKICAD_SCRIPTING=OFF -DKICAD_SCRIPTING_MODULES=OFF 
-DKICAD_SCRIPTING_WXPYTHON=OFF

make -j40


On 5.0.0-rc2-dev-101-gf7ef010fe

2018-03-06 0:37 GMT+01:00 Nick Østergaard >:


Ok, now I also see that issue. It could very easily be that RPATH
commit making the build system unstable. It is a problem that the
generated files are not in the build dir, but in the source dir.


2018-03-05 23:22 GMT+01:00 Nick Østergaard >:

It also seem to build correctly on jenkins.

2018-03-05 23:16 GMT+01:00 Steven A. Falco
>:

I'm going to retract this report.  It builds correctly on
copr, so the problem must be something in my local setup.

Sorry for the noise.

        Steve

___
Mailing list: https://launchpad.net/~kicad-developers

Post to     : kicad-developers@lists.launchpad.net

Unsubscribe : https://launchpad.net/~kicad-developers

More help   : https://help.launchpad.net/ListHelp







___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build error

[Nick Østergaard]

I reproduce in a clean workspace like this:
git clone https://github.com/KiCad/kicad-source-mirror.git kicad_steven
cd kicad_steven/
mkdir build
cd build/
cmake .. -DKICAD_SCRIPTING=OFF -DKICAD_SCRIPTING_MODULES=OFF
-DKICAD_SCRIPTING_WXPYTHON=OFF
make -j40


On 5.0.0-rc2-dev-101-gf7ef010fe

2018-03-06 0:37 GMT+01:00 Nick Østergaard :

> Ok, now I also see that issue. It could very easily be that RPATH commit
> making the build system unstable. It is a problem that the generated files
> are not in the build dir, but in the source dir.
>
>
> 2018-03-05 23:22 GMT+01:00 Nick Østergaard :
>
>> It also seem to build correctly on jenkins.
>>
>> 2018-03-05 23:16 GMT+01:00 Steven A. Falco :
>>
>>> I'm going to retract this report.  It builds correctly on copr, so the
>>> problem must be something in my local setup.
>>>
>>> Sorry for the noise.
>>>
>>> Steve
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build error

[Nick Østergaard]

Ok, now I also see that issue. It could very easily be that RPATH commit
making the build system unstable. It is a problem that the generated files
are not in the build dir, but in the source dir.

2018-03-05 23:22 GMT+01:00 Nick Østergaard :

> It also seem to build correctly on jenkins.
>
> 2018-03-05 23:16 GMT+01:00 Steven A. Falco :
>
>> I'm going to retract this report.  It builds correctly on copr, so the
>> problem must be something in my local setup.
>>
>> Sorry for the noise.
>>
>> Steve
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build error

[Nick Østergaard]

It also seem to build correctly on jenkins.

2018-03-05 23:16 GMT+01:00 Steven A. Falco :

> I'm going to retract this report.  It builds correctly on copr, so the
> problem must be something in my local setup.
>
> Sorry for the noise.
>
> Steve
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build error

[Steven A. Falco]

I'm going to retract this report.  It builds correctly on copr, so the problem 
must be something in my local setup.

Sorry for the noise.

Steve

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build error

[Steven A. Falco]

I ran a bisection, and it looks like the first bad commit is:

e0b33ee8a Fix RPATH not removed in shared object file for python

I can build its predecessor, 62bcf4fde41, without any problems.  I attached the 
bisect log, showing which commits I tried to build, and the results.

Steve


On 03/05/2018 02:13 PM, Steven A. Falco wrote:
> Yes it does.  I'm building on Fedora via the "mock" tool, which always starts 
> from an empty directory.  Just to be sure, I removed the entire "mock" 
> working area, and I even re-downloaded the source repositories.  I'll try 
> pushing the build up to the Copr build-system, and I'll report back with my 
> findings.
> 
>   Steve
> 
> On 03/05/2018 01:43 PM, Seth Hillbrand wrote:
>> Does the compile error exist after you make clean and re-make?
>>
>> 2018-03-05 10:20 GMT-08:00 Steven A. Falco > >:
>>
>> I just got a build error on Linux, at git commit 218f66a08, which 
>> appears to be the latest commit.
>>
>> In file included from 
>> /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra.h:36:0,
>>                  from 
>> /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_import.cpp:50:
>> 
>> /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:1075:2:
>>  error: #endif without #if
>>  #endif   // SPECCTRA_LEXER_H_
>>   ^
>> 
>> /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:308:25:
>>  error: expected '}' before 'T_absolute'
>>          T_routes        T_absolute = 0,
>>                          ^~
>> 
>> /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:308:38:
>>  error: invalid conversion from 'int' to 'DSN::T' [-fpermissive]
>>          T_routes        T_absolute = 0,
>>                                       ^
>> 
>> /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:309:1:
>>  error: expected unqualified-id before ',' token
>>  ,
>>  ^
>> 
>> /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:310:33:
>>  error: expected initializer before 'T_add_group'
>>          T_routes_include        T_add_group,
>>                                  ^~~
>> 
>> /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:511:1:
>>  error: expected declaration before '}' token
>>  }   // namespace DSN
>>  ^
>> make[2]: *** 
>> [pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/build.make:4979: 
>> pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/specctra_import_export/specctra_import.cpp.o]
>>  Error 1
>>
>>
>> I looked at specctra_lexer.h (attached) and sure enough it has an 
>> unbalanced #ifndef / #endif.  This file is apparently auto-generated by 
>> cmake - I have no knowledge of the details.
>>
>>         Steve
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers 
>> 
>> Post to     : kicad-developers@lists.launchpad.net 
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers 
>> 
>> More help   : https://help.launchpad.net/ListHelp 
>> 
>>
>>
> 
> 

bad 218f66a08b36bba9f2f4ab32753a97ca116f863a Fix sign comparison warning
5bbb4489b3ab7f36fccd8822ee03ae5f92234fc3 Fixed out of bounds access to 
m_shaderBuffer array in 3D viewer raytracer
bad e0b33ee8a605c5366e0b2e26e8d30192d9b742f7 Fix RPATH not removed in 
shared object file for python
good62bcf4fde41e68dc2bb5435270155efa689dd300 pcbnew: reorder "Fabrication 
Outputs" in menu
good3e54e16bdceedd2d96bafd7728cdb223df8a6876 Update ratsnest after a 
footprint change
0521b63503c2b70864e22e28a9e9a6408c4fcd33 Remove negation from 
PCB_BASE_FRAME::PlaceModule() parameter
4be12292a0555f4127003ba54b3131797c759703 Fixed duplicate misbehaviour 
when duplicating single track/via
fabbc48b40445ff2b7ec30d025dcc808920046df macOS: standardise 
CFBundleName to application names.
good9c44d67f3b3162d7abf9ce5eb689975229348eed Eeschema: Simplify 
transformation representation
f4eb63f8716ec3ce5e37bcf556523c6e6bf0bf3c Size fields list correctly in 
symbol edit.
90e2c8dd7f2aa31b74fb24fce0a4b96b6e93d581 Get rid of first-scroll 
jerkiness in eeschema.
cd2224b94d14ab6ffd43f4a7f684aed324c143b0 Add missing hotkey support to 
GerbView
d2c86f859456589a71ff93ccdc04c7a6090fea5b GerbView: Disable legacy-only 
event handlers when GAL is active
01ef0bd2e9237ce5d6109616ee94294a1501c161 pcbnew: Add graphic polygon on 
drawing layer

Re: [Kicad-developers] Build error

[Steven A. Falco]

Yes it does.  I'm building on Fedora via the "mock" tool, which always starts 
from an empty directory.  Just to be sure, I removed the entire "mock" working 
area, and I even re-downloaded the source repositories.  I'll try pushing the 
build up to the Copr build-system, and I'll report back with my findings.

Steve

On 03/05/2018 01:43 PM, Seth Hillbrand wrote:
> Does the compile error exist after you make clean and re-make?
> 
> 2018-03-05 10:20 GMT-08:00 Steven A. Falco  >:
> 
> I just got a build error on Linux, at git commit 218f66a08, which appears 
> to be the latest commit.
> 
> In file included from 
> /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra.h:36:0,
>                  from 
> /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_import.cpp:50:
> 
> /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:1075:2:
>  error: #endif without #if
>  #endif   // SPECCTRA_LEXER_H_
>   ^
> 
> /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:308:25:
>  error: expected '}' before 'T_absolute'
>          T_routes        T_absolute = 0,
>                          ^~
> 
> /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:308:38:
>  error: invalid conversion from 'int' to 'DSN::T' [-fpermissive]
>          T_routes        T_absolute = 0,
>                                       ^
> 
> /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:309:1:
>  error: expected unqualified-id before ',' token
>  ,
>  ^
> 
> /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:310:33:
>  error: expected initializer before 'T_add_group'
>          T_routes_include        T_add_group,
>                                  ^~~
> 
> /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:511:1:
>  error: expected declaration before '}' token
>  }   // namespace DSN
>  ^
> make[2]: *** 
> [pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/build.make:4979: 
> pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/specctra_import_export/specctra_import.cpp.o]
>  Error 1
> 
> 
> I looked at specctra_lexer.h (attached) and sure enough it has an 
> unbalanced #ifndef / #endif.  This file is apparently auto-generated by cmake 
> - I have no knowledge of the details.
> 
>         Steve
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers 
> 
> Post to     : kicad-developers@lists.launchpad.net 
> 
> Unsubscribe : https://launchpad.net/~kicad-developers 
> 
> More help   : https://help.launchpad.net/ListHelp 
> 
> 
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build error

[Seth Hillbrand]

Does the compile error exist after you make clean and re-make?

2018-03-05 10:20 GMT-08:00 Steven A. Falco :

> I just got a build error on Linux, at git commit 218f66a08, which appears
> to be the latest commit.
>
> In file included from /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/
> specctra_import_export/specctra.h:36:0,
>  from /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/
> specctra_import_export/specctra_import.cpp:50:
> /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:1075:2:
> error: #endif without #if
>  #endif   // SPECCTRA_LEXER_H_
>   ^
> /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:308:25:
> error: expected '}' before 'T_absolute'
>  T_routesT_absolute = 0,
>  ^~
> /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:308:38:
> error: invalid conversion from 'int' to 'DSN::T' [-fpermissive]
>  T_routesT_absolute = 0,
>   ^
> /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:309:1:
> error: expected unqualified-id before ',' token
>  ,
>  ^
> /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:310:33:
> error: expected initializer before 'T_add_group'
>  T_routes_includeT_add_group,
>  ^~~
> /builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:511:1:
> error: expected declaration before '}' token
>  }   // namespace DSN
>  ^
> make[2]: *** [pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/build.make:4979:
> pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/specctra_
> import_export/specctra_import.cpp.o] Error 1
>
>
> I looked at specctra_lexer.h (attached) and sure enough it has an
> unbalanced #ifndef / #endif.  This file is apparently auto-generated by
> cmake - I have no knowledge of the details.
>
> Steve
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Build error

[Steven A. Falco]

I just got a build error on Linux, at git commit 218f66a08, which appears to be 
the latest commit.

In file included from 
/builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra.h:36:0,
 from 
/builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_import.cpp:50:
/builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:1075:2:
 error: #endif without #if
 #endif   // SPECCTRA_LEXER_H_
  ^
/builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:308:25:
 error: expected '}' before 'T_absolute'
 T_routesT_absolute = 0,
 ^~
/builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:308:38:
 error: invalid conversion from 'int' to 'DSN::T' [-fpermissive]
 T_routesT_absolute = 0,
  ^
/builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:309:1:
 error: expected unqualified-id before ',' token
 ,
 ^
/builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:310:33:
 error: expected initializer before 'T_add_group'
 T_routes_includeT_add_group,
 ^~~
/builddir/build/BUILD/kicad-r12311-218f66a0/pcbnew/specctra_import_export/specctra_lexer.h:511:1:
 error: expected declaration before '}' token
 }   // namespace DSN
 ^
make[2]: *** [pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/build.make:4979: 
pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/specctra_import_export/specctra_import.cpp.o]
 Error 1


I looked at specctra_lexer.h (attached) and sure enough it has an unbalanced 
#ifndef / #endif.  This file is apparently auto-generated by cmake - I have no 
knowledge of the details.

Steve

/* Do not modify this file it was automatically generated by the
 * TokenList2DsnLexer CMake script.
 */

#ifndef SPECCTRA_LEXER_H_
#define SPECCTRA_LEXER_H_

#include 

/**
 * C++ does not put enum _values_ in separate namespaces unless the enum itself
 * is in a separate namespace.  All the token enums must be in separate namespaces
 * otherwise the C++ compiler will eventually complain if it sees more than one
 * DSNLEXER in the same compilation unit, say by mutliple header file inclusion.
 * Plus this also enables re-use of the same enum name T.  A typedef can always be used
 * to clarify which enum T is in play should that ever be a problem.  This is
 * unlikely since Parse() functions will usually only be exposed to one header
 * file like this one.  But if there is a problem, then use:
 *   typedef DSN::T T;
 * within that problem area.
 */
namespace DSN
{
/// enum T contains all this lexer's tokens.
enum T
{
// these first few are negative special ones for syntax, and are
// inherited from DSNLEXER.
T_NONE  = DSN_NONE,
T_COMMENT   = DSN_COMMENT,
T_STRING_QUOTE  = DSN_STRING_QUOTE,
T_QUOTE_DEF = DSN_QUOTE_DEF,
T_DASH  = DSN_DASH,
T_SYMBOL= DSN_SYMBOL,
T_NUMBER= DSN_NUMBER,
T_RIGHT = DSN_RIGHT,// right bracket: ')'
T_LEFT  = DSN_LEFT, // left bracket:  '('
T_STRING= DSN_STRING,   // a quoted string, stripped of the quotes
T_EOF   = DSN_EOF,  // special case for end of file

T_back,
T_base_design,
T_bbv_ctr2ctr,
T_bend_keepout,
T_bond,
T_both,
T_bottom,
T_bottom_layer_sel,
T_boundary,
T_brickpat,
T_bundle,
T_bus,
T_bypass,
T_capacitance_resolution,
T_capacitor,
T_case_sensitive,
T_cct1,
T_cct1a,
T_center_center,
T_checking_trim_by_pin,
T_circ,
T_circle,
T_circuit,
T_class,
T_class_class,
T_classes,
T_clear,
T_clearance,
T_cluster,
T_cm,
T_color,
T_colors,
T_comment,
T_comp,
T_comp_edge_center,
T_comp_order,
T_component,
T_composite,
T_conductance_resolution,
T_conductor,
T_conflict,
T_connect,
T_constant,
T_contact,
T_control,
T_corner,
T_corners,
T_cost,
T_created_time,
T_cross,
T_crosstalk_model,
T_current_resolution,
T_deleted,
T_deleted_keepout,
T_delta,
T_diagonal,
T_direction,
T_directory,
T_discrete,
T_effective_via_length,
T_elongate_keepout,
T_exclude,
T_expose,
T_extra_image_directory,
T_family,
T_family_family,
T_family_family_spacing,
T_fanout,
T_farad,
T_file,
  

Re: [Kicad-developers] Build error on MSVC

[Maciej Sumiński]

Merged, thank you Simon!

Regards,
Orson

On 09/19/2017 09:14 PM, Simon Richter wrote:
> Hi,
> 
> I'm getting a compile error on MSVC:
> 
> eeschema\lib_pin.cpp(588): error C2228: left of '.utf8_str' must have
> class/struct/union
> 
> I can't prove easily whether this code is legal or illegal according to
> the C++ specification, which is probably a good reason to change it.
> 
>Simon
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 




signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Build error on MSVC

[Simon Richter]

Hi,

I'm getting a compile error on MSVC:

eeschema\lib_pin.cpp(588): error C2228: left of '.utf8_str' must have
class/struct/union

I can't prove easily whether this code is legal or illegal according to
the C++ specification, which is probably a good reason to change it.

   Simon
From ce1b884ac0d357963dd496662444669c355f1c5e Mon Sep 17 00:00:00 2001
From: Simon Richter 
Date: Tue, 19 Sep 2017 21:00:06 +0200
Subject: [PATCH] Avoid converting fixed string to UTF-8

This fixes a build error on MSVC. The code may actually be legal, but a
proof of that would require a lengthy dissertation on argument promotion
rules for the ternary operator, and the simplest rule of promoting both
cases to a wxString rvalue is not likely to be what is intended here.

Fortunately, this expression can be simplified.
---
 eeschema/lib_pin.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eeschema/lib_pin.cpp b/eeschema/lib_pin.cpp
index f3213cc7a..786181f82 100644
--- a/eeschema/lib_pin.cpp
+++ b/eeschema/lib_pin.cpp
@@ -585,7 +585,7 @@ bool LIB_PIN::Save( OUTPUTFORMATTER& aFormatter )
 }
 
 if( aFormatter.Print( 0, " %s %d %d %d %c %d %d %d %d %c",
-  TO_UTF8( m_number.IsEmpty() ? wxT( "~" ) : m_number ),
+  m_number.IsEmpty() ? "~" : TO_UTF8( m_number ),
   m_position.x, m_position.y,
   (int) m_length, (int) m_orientation, m_numTextSize, m_nameTextSize,
   m_Unit, m_Convert, Etype ) < 0 )
-- 
2.11.0



signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build Error with wxWidgets >3.1.0

[Bernhard Stegmaier]

Sure…
  https://bugs.launchpad.net/kicad/+bug/1678623 



Regards,
Bernhard

> On 2. Apr 2017, at 16:12, Chris Pavlina  wrote:
> 
> Looks like it should cause breakage, please don't merge. I'll have a
> look at this later - wx 3.1 is unsupported, but it should be relatively
> easy to resolve this and reduce future breakage if we ever upgrade.
> 
> Could you please file a bug report?
> 
> On Sun, Apr 02, 2017 at 04:08:32PM +0200, Bernhard Stegmaier wrote:
>> Hi,
>> 
>> KiCad doesn’t build (at least for me on OSX) with a current wxWidgets 
>> master, I guess it won’t since wxWidgets change [1] and new component 
>> selector.
>> 
>> Attached is a patch for a workaround/fix which makes compiler happy again 
>> and doesn’t seem to brake anything obvious in the new component selector.
>> It probably won’t handle all versions of wxWidgets master correctly, because 
>> [1] was done ~4 weeks after 3.1.0 was released.
>> 
>> The ugly version check could be avoided if just always using the default 
>> constructor, but I don’t know the impact…
>> 
>> 
>> Regards,
>> Bernhard
>> 
>> [1]
>> https://github.com/wxWidgets/wxWidgets/commit/98294467553fe4dd766419c4e5aa6bc9502d65c7
>>  
>> >  
>> >

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build Error with wxWidgets >3.1.0

[Chris Pavlina]

Looks like it should cause breakage, please don't merge. I'll have a
look at this later - wx 3.1 is unsupported, but it should be relatively
easy to resolve this and reduce future breakage if we ever upgrade.

Could you please file a bug report?

On Sun, Apr 02, 2017 at 04:08:32PM +0200, Bernhard Stegmaier wrote:
> Hi,
> 
> KiCad doesn’t build (at least for me on OSX) with a current wxWidgets master, 
> I guess it won’t since wxWidgets change [1] and new component selector.
> 
> Attached is a patch for a workaround/fix which makes compiler happy again and 
> doesn’t seem to brake anything obvious in the new component selector.
> It probably won’t handle all versions of wxWidgets master correctly, because 
> [1] was done ~4 weeks after 3.1.0 was released.
> 
> The ugly version check could be avoided if just always using the default 
> constructor, but I don’t know the impact…
> 
> 
> Regards,
> Bernhard
> 
> [1]
> https://github.com/wxWidgets/wxWidgets/commit/98294467553fe4dd766419c4e5aa6bc9502d65c7
>  
> 
> 
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Build Error with wxWidgets >3.1.0

[Bernhard Stegmaier]

Hi,KiCad doesn’t build (at least for me on OSX) with a current wxWidgets master, I guess it won’t since wxWidgets change [1] and new component selector.Attached is a patch for a workaround/fix which makes compiler happy again and doesn’t seem to brake anything obvious in the new component selector.It probably won’t handle all versions of wxWidgets master correctly, because [1] was done ~4 weeks after 3.1.0 was released.The ugly version check could be avoided if just always using the default constructor, but I don’t know the impact…Regards,Bernhard[1]https://github.com/wxWidgets/wxWidgets/commit/98294467553fe4dd766419c4e5aa6bc9502d65c7

wx-master.patch
Description: Binary data
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp