Re: [Kicad-developers] Build failed in Jenkins: KiCad (Linux, all options, Debug) #1251

2016-05-11 Thread Wayne Stambaugh 
Nick,

Many thanks for getting this back up and running!

Cheers,

Wayne

On 5/11/2016 2:29 PM, Nick Østergaard wrote:
> Jenkins operations should now be back to normal. The main build is
> green, time will show if it will trigger on new commits properly.
> 
> 2016-05-11 18:46 GMT+02:00 Nick Østergaard :
>> Ahh yeah, we were messing about with that some time ago. :)
>>
>> 2016-05-11 17:38 GMT+02:00 Jon Neal :
>>> The issue is because the master jenkins node doesn't support c++11. I'm
>>> wondering if we should lay out a plan to upgrade the jenkins server since it
>>> is so out of date (some of our other scripts can't run on it due to things
>>> like git being 5 or 6 years out of date).
>>>
>>> We've also started getting lots of gateway timeout errors lately which makes
>>> things difficult. I can't actually update the jenkins main config any more
>>> due to this.
>>>
>>> On Wed, May 11, 2016 at 11:31 AM Nick Østergaard  wrote:

 Something is wonky with the jenkins master. I will give it a look when i
 get home. It seems to not have built for a month on the lp:kicad branch.

> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build failed in Jenkins: KiCad (Linux, all options, Debug) #1251

2016-05-11 Thread Nick Østergaard 
Jenkins operations should now be back to normal. The main build is
green, time will show if it will trigger on new commits properly.

2016-05-11 18:46 GMT+02:00 Nick Østergaard :
> Ahh yeah, we were messing about with that some time ago. :)
>
> 2016-05-11 17:38 GMT+02:00 Jon Neal :
>> The issue is because the master jenkins node doesn't support c++11. I'm
>> wondering if we should lay out a plan to upgrade the jenkins server since it
>> is so out of date (some of our other scripts can't run on it due to things
>> like git being 5 or 6 years out of date).
>>
>> We've also started getting lots of gateway timeout errors lately which makes
>> things difficult. I can't actually update the jenkins main config any more
>> due to this.
>>
>> On Wed, May 11, 2016 at 11:31 AM Nick Østergaard  wrote:
>>>
>>> Something is wonky with the jenkins master. I will give it a look when i
>>> get home. It seems to not have built for a month on the lp:kicad branch.
>>>


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build failed in Jenkins: KiCad (Linux, all options, Debug) #1251

2016-05-11 Thread Nick Østergaard 
Ahh yeah, we were messing about with that some time ago. :)

2016-05-11 17:38 GMT+02:00 Jon Neal :
> The issue is because the master jenkins node doesn't support c++11. I'm
> wondering if we should lay out a plan to upgrade the jenkins server since it
> is so out of date (some of our other scripts can't run on it due to things
> like git being 5 or 6 years out of date).
>
> We've also started getting lots of gateway timeout errors lately which makes
> things difficult. I can't actually update the jenkins main config any more
> due to this.
>
> On Wed, May 11, 2016 at 11:31 AM Nick Østergaard  wrote:
>>
>> Something is wonky with the jenkins master. I will give it a look when i
>> get home. It seems to not have built for a month on the lp:kicad branch.
>>
>> Den 11/05/2016 17.28 skrev "Miguel Angel Ajo" :
>>>
>>> See 
>>>
>>> Changes:
>>>
>>> [jean-pierre charras] Pcbnew: Fix a very minor bug ( The "Move
>>> exactly..."  sometimes truncates the saved parameter floating point values
>>> during a session)
>>>
>>> [jean-pierre charras] Fix minor bug in Modedit: Adding a new rounded rect
>>> pad to a footprint doesn't clone rectangle rounding
>>>
>>> [jean-pierre charras] Fix a few deprecated compil warnings in dialogs
>>> generated by wxformbuilder
>>>
>>> [Chris Pavlina] OS X: Disable full-screen cursor
>>>
>>> This feature cannot work reliably for reasons explained in lp:1463505.
>>> Remove
>>> the option on OS X builds and force cursor to the small one.
>>>
>>> https://bugs.launchpad.net/kicad/+bug/1463505
>>>
>>> > Bernhard Stegmaier (stegmaier) wrote on 2016-01-14:
>>> >
>>> > As far as I see from the code this is no bug but done on intention.
>>> >
>>> > The reason probably is that on OSX in the legacy canvas you don't have
>>> > the
>>> > XOR-drawing as on other platforms. To the best of my knowledge, this
>>> > would
>>> > mean that on every mouse move you would have to repaint the whole
>>> > window just
>>> > to get rid of the "old" cross.
>>> >
>>> > So, I would say this is a clear "won't fix".
>>> > We could think of just removing/disabling the button in the legacy
>>> > canvas.
>>>
>>> [Chris Pavlina] Correct handling of unused parameter
>>>
>>> Coverity: CID 143742
>>>
>>> [Chris Pavlina] Clean up dodgy array dimension
>>>
>>> Array is in pairs but has a single sentinel, trips up Coverity (CID
>>> 147346) and
>>> does allow an out-of-bounds write if WX_GL_SAMPLES were ever removed from
>>> the
>>> array.
>>>
>>> [Chris Pavlina] Remove unneeded 'new' and NULL check
>>>
>>> Coverity CID: 143743
>>>
>>> [Chris Pavlina] Fix null dereference for certain bad PCB files
>>>
>>> Coverity: CID 147344 Unchecked dynamic_cast
>>>
>>> If a file that parses validly in Parse() but does not return a BOARD is
>>> loaded,
>>> no exception will be thrown but the dynamic_cast will return NULL. This
>>> NULL
>>> is tested by wxASSERT(), which does not actually halt anything
>>> (especially in
>>> release builds), and then we proceed to board->SetFileName().
>>>
>>> This can be demonstrated quickly by renaming a .kicad_mod to .kicad_pcb
>>> and
>>> trying to load it. pcbnew will crash.
>>>
>>> [Chris Pavlina] Fix uninitialized fields
>>>
>>> Coverity: CIDs 102698, 147347, 147349, 147350
>>>
>>> [Chris Pavlina] Fix build error on some platforms from r6788
>>>
>>> r6788 = git f9386fc
>>>
>>> [Chris Pavlina] Remove "Dump zone geometry to files when filling"
>>>
>>> The code to perform the dump has not been removed, but the GUI option and
>>> global flag (ugh) have been.
>>>
>>> [Chris Pavlina] pcbnew legacy: remove option to hide via drill
>>>
>>> Via drills are now shown in all cases, matching GAL behavior, and the
>>> option no
>>> longer exists in the preferences dialog.
>>>
>>> [Chris Pavlina] Add support for PCB and footprint format versioning
>>>
>>> Currently, kicad_pcb files have a (version ...) tag, but it is ignored.
>>> This
>>> commit does the following:
>>>
>>> 1. Parse the version. If it's later than the last supported version,
>>> present an
>>> alternative error message suggesting an upgrade if the file does not load
>>> correctly. The version will be interpreted as an integer MMDD to
>>> suggest
>>> a KiCad release date.
>>>
>>> 2. Accept a (version ...) tag also in kicad_mod files, but do not write
>>> them
>>> yet. If no version tag is present in these files, assume the version to
>>> be that
>>> of the current format version at the time of this commit.
>>>
>>> This is meant to be merged to the 4.x stable series, and preps for KiCad
>>> 5
>>> which will start emitting version tags also in footprints - users with
>>> what
>>> will then be 'old stable' will not get a parse error when we introduce
>>> this for
>>> footprints, and we can safely increment the format version later.
>>>
>>> [Maciej Suminski] Commented out 'override' keyword due to problems with
>>> older swig versions (see

Re: [Kicad-developers] Build failed in Jenkins: KiCad (Linux, all options, Debug) #1251

2016-05-11 Thread Adam Wolf 
Jenkins 2 recently came out as well, and I'm thinking about redoing how I
do the OS X builds in my Jenkins.

On Wed, May 11, 2016 at 10:38 AM, Jon Neal  wrote:

> The issue is because the master jenkins node doesn't support c++11. I'm
> wondering if we should lay out a plan to upgrade the jenkins server since
> it is so out of date (some of our other scripts can't run on it due to
> things like git being 5 or 6 years out of date).
>
> We've also started getting lots of gateway timeout errors lately which
> makes things difficult. I can't actually update the jenkins main config any
> more due to this.
>
> On Wed, May 11, 2016 at 11:31 AM Nick Østergaard 
> wrote:
>
>> Something is wonky with the jenkins master. I will give it a look when i
>> get home. It seems to not have built for a month on the lp:kicad branch.
>> Den 11/05/2016 17.28 skrev "Miguel Angel Ajo" :
>>
>>> See 
>>>
>>> Changes:
>>>
>>> [jean-pierre charras] Pcbnew: Fix a very minor bug ( The "Move
>>> exactly..."  sometimes truncates the saved parameter floating point values
>>> during a session)
>>>
>>> [jean-pierre charras] Fix minor bug in Modedit: Adding a new rounded
>>> rect pad to a footprint doesn't clone rectangle rounding
>>>
>>> [jean-pierre charras] Fix a few deprecated compil warnings in dialogs
>>> generated by wxformbuilder
>>>
>>> [Chris Pavlina] OS X: Disable full-screen cursor
>>>
>>> This feature cannot work reliably for reasons explained in lp:1463505.
>>> Remove
>>> the option on OS X builds and force cursor to the small one.
>>>
>>> https://bugs.launchpad.net/kicad/+bug/1463505
>>>
>>> > Bernhard Stegmaier (stegmaier) wrote on 2016-01-14:
>>> >
>>> > As far as I see from the code this is no bug but done on intention.
>>> >
>>> > The reason probably is that on OSX in the legacy canvas you don't have
>>> the
>>> > XOR-drawing as on other platforms. To the best of my knowledge, this
>>> would
>>> > mean that on every mouse move you would have to repaint the whole
>>> window just
>>> > to get rid of the "old" cross.
>>> >
>>> > So, I would say this is a clear "won't fix".
>>> > We could think of just removing/disabling the button in the legacy
>>> canvas.
>>>
>>> [Chris Pavlina] Correct handling of unused parameter
>>>
>>> Coverity: CID 143742
>>>
>>> [Chris Pavlina] Clean up dodgy array dimension
>>>
>>> Array is in pairs but has a single sentinel, trips up Coverity (CID
>>> 147346) and
>>> does allow an out-of-bounds write if WX_GL_SAMPLES were ever removed
>>> from the
>>> array.
>>>
>>> [Chris Pavlina] Remove unneeded 'new' and NULL check
>>>
>>> Coverity CID: 143743
>>>
>>> [Chris Pavlina] Fix null dereference for certain bad PCB files
>>>
>>> Coverity: CID 147344 Unchecked dynamic_cast
>>>
>>> If a file that parses validly in Parse() but does not return a BOARD is
>>> loaded,
>>> no exception will be thrown but the dynamic_cast will return NULL. This
>>> NULL
>>> is tested by wxASSERT(), which does not actually halt anything
>>> (especially in
>>> release builds), and then we proceed to board->SetFileName().
>>>
>>> This can be demonstrated quickly by renaming a .kicad_mod to .kicad_pcb
>>> and
>>> trying to load it. pcbnew will crash.
>>>
>>> [Chris Pavlina] Fix uninitialized fields
>>>
>>> Coverity: CIDs 102698, 147347, 147349, 147350
>>>
>>> [Chris Pavlina] Fix build error on some platforms from r6788
>>>
>>> r6788 = git f9386fc
>>>
>>> [Chris Pavlina] Remove "Dump zone geometry to files when filling"
>>>
>>> The code to perform the dump has not been removed, but the GUI option and
>>> global flag (ugh) have been.
>>>
>>> [Chris Pavlina] pcbnew legacy: remove option to hide via drill
>>>
>>> Via drills are now shown in all cases, matching GAL behavior, and the
>>> option no
>>> longer exists in the preferences dialog.
>>>
>>> [Chris Pavlina] Add support for PCB and footprint format versioning
>>>
>>> Currently, kicad_pcb files have a (version ...) tag, but it is ignored.
>>> This
>>> commit does the following:
>>>
>>> 1. Parse the version. If it's later than the last supported version,
>>> present an
>>> alternative error message suggesting an upgrade if the file does not load
>>> correctly. The version will be interpreted as an integer MMDD to
>>> suggest
>>> a KiCad release date.
>>>
>>> 2. Accept a (version ...) tag also in kicad_mod files, but do not write
>>> them
>>> yet. If no version tag is present in these files, assume the version to
>>> be that
>>> of the current format version at the time of this commit.
>>>
>>> This is meant to be merged to the 4.x stable series, and preps for KiCad
>>> 5
>>> which will start emitting version tags also in footprints - users with
>>> what
>>> will then be 'old stable' will not get a parse error when we introduce
>>> this for
>>> footprints, and we can safely increment the format version later.
>>>
>>> [Maciej Suminski] Commented out 'override' keyword

Re: [Kicad-developers] Build failed in Jenkins: KiCad (Linux, all options, Debug) #1251

2016-05-11 Thread Jon Neal 
The issue is because the master jenkins node doesn't support c++11. I'm
wondering if we should lay out a plan to upgrade the jenkins server since
it is so out of date (some of our other scripts can't run on it due to
things like git being 5 or 6 years out of date).

We've also started getting lots of gateway timeout errors lately which
makes things difficult. I can't actually update the jenkins main config any
more due to this.

On Wed, May 11, 2016 at 11:31 AM Nick Østergaard  wrote:

> Something is wonky with the jenkins master. I will give it a look when i
> get home. It seems to not have built for a month on the lp:kicad branch.
> Den 11/05/2016 17.28 skrev "Miguel Angel Ajo" :
>
>> See 
>>
>> Changes:
>>
>> [jean-pierre charras] Pcbnew: Fix a very minor bug ( The "Move
>> exactly..."  sometimes truncates the saved parameter floating point values
>> during a session)
>>
>> [jean-pierre charras] Fix minor bug in Modedit: Adding a new rounded rect
>> pad to a footprint doesn't clone rectangle rounding
>>
>> [jean-pierre charras] Fix a few deprecated compil warnings in dialogs
>> generated by wxformbuilder
>>
>> [Chris Pavlina] OS X: Disable full-screen cursor
>>
>> This feature cannot work reliably for reasons explained in lp:1463505.
>> Remove
>> the option on OS X builds and force cursor to the small one.
>>
>> https://bugs.launchpad.net/kicad/+bug/1463505
>>
>> > Bernhard Stegmaier (stegmaier) wrote on 2016-01-14:
>> >
>> > As far as I see from the code this is no bug but done on intention.
>> >
>> > The reason probably is that on OSX in the legacy canvas you don't have
>> the
>> > XOR-drawing as on other platforms. To the best of my knowledge, this
>> would
>> > mean that on every mouse move you would have to repaint the whole
>> window just
>> > to get rid of the "old" cross.
>> >
>> > So, I would say this is a clear "won't fix".
>> > We could think of just removing/disabling the button in the legacy
>> canvas.
>>
>> [Chris Pavlina] Correct handling of unused parameter
>>
>> Coverity: CID 143742
>>
>> [Chris Pavlina] Clean up dodgy array dimension
>>
>> Array is in pairs but has a single sentinel, trips up Coverity (CID
>> 147346) and
>> does allow an out-of-bounds write if WX_GL_SAMPLES were ever removed from
>> the
>> array.
>>
>> [Chris Pavlina] Remove unneeded 'new' and NULL check
>>
>> Coverity CID: 143743
>>
>> [Chris Pavlina] Fix null dereference for certain bad PCB files
>>
>> Coverity: CID 147344 Unchecked dynamic_cast
>>
>> If a file that parses validly in Parse() but does not return a BOARD is
>> loaded,
>> no exception will be thrown but the dynamic_cast will return NULL. This
>> NULL
>> is tested by wxASSERT(), which does not actually halt anything
>> (especially in
>> release builds), and then we proceed to board->SetFileName().
>>
>> This can be demonstrated quickly by renaming a .kicad_mod to .kicad_pcb
>> and
>> trying to load it. pcbnew will crash.
>>
>> [Chris Pavlina] Fix uninitialized fields
>>
>> Coverity: CIDs 102698, 147347, 147349, 147350
>>
>> [Chris Pavlina] Fix build error on some platforms from r6788
>>
>> r6788 = git f9386fc
>>
>> [Chris Pavlina] Remove "Dump zone geometry to files when filling"
>>
>> The code to perform the dump has not been removed, but the GUI option and
>> global flag (ugh) have been.
>>
>> [Chris Pavlina] pcbnew legacy: remove option to hide via drill
>>
>> Via drills are now shown in all cases, matching GAL behavior, and the
>> option no
>> longer exists in the preferences dialog.
>>
>> [Chris Pavlina] Add support for PCB and footprint format versioning
>>
>> Currently, kicad_pcb files have a (version ...) tag, but it is ignored.
>> This
>> commit does the following:
>>
>> 1. Parse the version. If it's later than the last supported version,
>> present an
>> alternative error message suggesting an upgrade if the file does not load
>> correctly. The version will be interpreted as an integer MMDD to
>> suggest
>> a KiCad release date.
>>
>> 2. Accept a (version ...) tag also in kicad_mod files, but do not write
>> them
>> yet. If no version tag is present in these files, assume the version to
>> be that
>> of the current format version at the time of this commit.
>>
>> This is meant to be merged to the 4.x stable series, and preps for KiCad 5
>> which will start emitting version tags also in footprints - users with
>> what
>> will then be 'old stable' will not get a parse error when we introduce
>> this for
>> footprints, and we can safely increment the format version later.
>>
>> [Maciej Suminski] Commented out 'override' keyword due to problems with
>> older swig versions (see bug lp:1579042).
>>
>> [Maciej Suminski] Removed remaining traces of KICAD_SKIP_BOOST parameter.
>>
>> [jean-pierre charras] Fix an issue in LOCALE_IO class, used to switch
>> to/back locale "C" when reading/writing files: the back to locale was
>> broken, and created issues in

[Kicad-developers] Build failed in Jenkins: KiCad (Linux, all options, Debug) #1251

2016-05-11 Thread Miguel Angel Ajo 
See 

Changes:

[jean-pierre charras] Pcbnew: Fix a very minor bug ( The "Move exactly..."  
sometimes truncates the saved parameter floating point values during a session)

[jean-pierre charras] Fix minor bug in Modedit: Adding a new rounded rect pad 
to a footprint doesn't clone rectangle rounding

[jean-pierre charras] Fix a few deprecated compil warnings in dialogs generated 
by wxformbuilder

[Chris Pavlina] OS X: Disable full-screen cursor

This feature cannot work reliably for reasons explained in lp:1463505. Remove
the option on OS X builds and force cursor to the small one.

https://bugs.launchpad.net/kicad/+bug/1463505

> Bernhard Stegmaier (stegmaier) wrote on 2016-01-14:
>
> As far as I see from the code this is no bug but done on intention.
>
> The reason probably is that on OSX in the legacy canvas you don't have the
> XOR-drawing as on other platforms. To the best of my knowledge, this would
> mean that on every mouse move you would have to repaint the whole window just
> to get rid of the "old" cross.
>
> So, I would say this is a clear "won't fix".
> We could think of just removing/disabling the button in the legacy canvas.

[Chris Pavlina] Correct handling of unused parameter

Coverity: CID 143742

[Chris Pavlina] Clean up dodgy array dimension

Array is in pairs but has a single sentinel, trips up Coverity (CID 147346) and
does allow an out-of-bounds write if WX_GL_SAMPLES were ever removed from the
array.

[Chris Pavlina] Remove unneeded 'new' and NULL check

Coverity CID: 143743

[Chris Pavlina] Fix null dereference for certain bad PCB files

Coverity: CID 147344 Unchecked dynamic_cast

If a file that parses validly in Parse() but does not return a BOARD is loaded,
no exception will be thrown but the dynamic_cast will return NULL. This NULL
is tested by wxASSERT(), which does not actually halt anything (especially in
release builds), and then we proceed to board->SetFileName().

This can be demonstrated quickly by renaming a .kicad_mod to .kicad_pcb and
trying to load it. pcbnew will crash.

[Chris Pavlina] Fix uninitialized fields

Coverity: CIDs 102698, 147347, 147349, 147350

[Chris Pavlina] Fix build error on some platforms from r6788

r6788 = git f9386fc

[Chris Pavlina] Remove "Dump zone geometry to files when filling"

The code to perform the dump has not been removed, but the GUI option and
global flag (ugh) have been.

[Chris Pavlina] pcbnew legacy: remove option to hide via drill

Via drills are now shown in all cases, matching GAL behavior, and the option no
longer exists in the preferences dialog.

[Chris Pavlina] Add support for PCB and footprint format versioning

Currently, kicad_pcb files have a (version ...) tag, but it is ignored. This
commit does the following:

1. Parse the version. If it's later than the last supported version, present an
alternative error message suggesting an upgrade if the file does not load
correctly. The version will be interpreted as an integer MMDD to suggest
a KiCad release date.

2. Accept a (version ...) tag also in kicad_mod files, but do not write them
yet. If no version tag is present in these files, assume the version to be that
of the current format version at the time of this commit.

This is meant to be merged to the 4.x stable series, and preps for KiCad 5
which will start emitting version tags also in footprints - users with what
will then be 'old stable' will not get a parse error when we introduce this for
footprints, and we can safely increment the format version later.

[Maciej Suminski] Commented out 'override' keyword due to problems with older 
swig versions (see bug lp:1579042).

[Maciej Suminski] Removed remaining traces of KICAD_SKIP_BOOST parameter.

[jean-pierre charras] Fix an issue in LOCALE_IO class, used to switch to/back 
locale "C" when reading/writing files: the back to locale was broken, and 
created issues in countries using the ',' as fp separator, especially when the 
non default language was used.
It was reported in many bugs.

[jean-pierre charras] Fix a few shadowed local variables and deprecated 
warnings in dialogs (using a very recent wxformbuilder version).

[Maciej Suminski] OpenGL GAL: Set context in destructor when possible (under 
Linux the window has to be visible).

[Maciej Suminski] 3D viewer: set right OpenGL context before freeing memory.

[Maciej Suminski] Fixed a crash when starting pcbnew with OpenGL GAL.

[Maciej Suminski] Highlight an item when context menu is displayed (GAL).

[Maciej Suminski] Added menu for locking tracks & vias (GAL).

[Maciej Suminski] Added SELECTION_CONDITIONS::OnlyTypes() variant that takes 
KICAD_T[]4

[Maciej Suminski] Mark locked tracks with 'L' letter in status field.

[jean-pierre charras] Minor fixes: Fix a few shadowed local variables, and 
deprecated warnings is a few dialogs generated by wxFormbuilder (using a very 
recent wxFormbuilder version, after apr 25, 2016)

[Chris Pavlina] Fix beep on