[Kicad-developers] Consistency in messages
Hi, we don't seem to have a consistent convention on quoting in messages shown to the user, and thus we have all three of '%s' "%s" <%s> in format strings when referring to names (files, nets, netclasses, …). For the untranslated strings, I'd prefer either double or single quotes, while translated messages should probably use the locale appropriate quoting format. Which should it be? Simon signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Consistency in messages
I typically use '%s' mainly because it's easier than escaping the double quote but I'm not opposed to "%s". <%s> should be avoided because some text controls interpret the <> as html tags. I thought we got ride of most if not all of the <%s> occurrences but apparently not. On 11/29/2017 3:26 PM, Simon Richter wrote: > Hi, > > we don't seem to have a consistent convention on quoting in messages > shown to the user, and thus we have all three of > > '%s' > "%s" > <%s> > > in format strings when referring to names (files, nets, netclasses, …). > > For the untranslated strings, I'd prefer either double or single quotes, > while translated messages should probably use the locale appropriate > quoting format. > > Which should it be? > >Simon > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Consistency in messages
On Wed, Nov 29, 2017 at 03:56:20PM -0500, Wayne Stambaugh wrote: > I typically use '%s' mainly because it's easier than escaping the double > quote but I'm not opposed to "%s". <%s> should be avoided because some > text controls interpret the <> as html tags. I thought we got ride of > most if not all of the <%s> occurrences but apparently not. Frankly if you're putting arbitrary strings into something that interprets the input as HTML, you should be running through an escape function first _anyway_, and that should automatically replace < and > with < and > ... > > On 11/29/2017 3:26 PM, Simon Richter wrote: > > Hi, > > > > we don't seem to have a consistent convention on quoting in messages > > shown to the user, and thus we have all three of > > > > '%s' > > "%s" > > <%s> > > > > in format strings when referring to names (files, nets, netclasses, …). > > > > For the untranslated strings, I'd prefer either double or single quotes, > > while translated messages should probably use the locale appropriate > > quoting format. > > > > Which should it be? > > > >Simon > > > > > > > > ___ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : kicad-developers@lists.launchpad.net > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Consistency in messages
On 11/29/2017 05:04 PM, Chris Pavlina wrote: > On Wed, Nov 29, 2017 at 03:56:20PM -0500, Wayne Stambaugh wrote: >> I typically use '%s' mainly because it's easier than escaping the double >> quote but I'm not opposed to "%s". <%s> should be avoided because some >> text controls interpret the <> as html tags. I thought we got ride of >> most if not all of the <%s> occurrences but apparently not. > > Frankly if you're putting arbitrary strings into something that > interprets the input as HTML, you should be running through an escape > function first _anyway_, and that should automatically replace < and > > with < and > ... I agree in principal but if memory serves, there are control differences between platforms which would make implementing this less than trivial. > >> >> On 11/29/2017 3:26 PM, Simon Richter wrote: >>> Hi, >>> >>> we don't seem to have a consistent convention on quoting in messages >>> shown to the user, and thus we have all three of >>> >>> '%s' >>> "%s" >>> <%s> >>> >>> in format strings when referring to names (files, nets, netclasses, …). >>> >>> For the untranslated strings, I'd prefer either double or single quotes, >>> while translated messages should probably use the locale appropriate >>> quoting format. >>> >>> Which should it be? >>> >>>Simon >>> >>> >>> >>> ___ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : kicad-developers@lists.launchpad.net >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> >> >> ___ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Consistency in messages
On Wed, Nov 29, 2017 at 09:26:57PM +0100, Simon Richter wrote: > Hi, > > we don't seem to have a consistent convention on quoting in messages > shown to the user, and thus we have all three of > > '%s' > "%s" > <%s> > > in format strings when referring to names (files, nets, netclasses, …). > > For the untranslated strings, I'd prefer either double or single quotes, > while translated messages should probably use the locale appropriate > quoting format. > > Which should it be? > >Simon > I tend to avoid single quotes in translated strings replacing them with double quotes whenever possible (means always, when I remember to do it) since in my language (Italian) quotes are always done with double quotes characters as single quote characters are relegated to elision or replacing accented chars when these are not present in the keyboard or not easlily accessible (as for Windows and uppercase accented chars...). Guess what? Linux has not these problems, nationalized keyboards are always complete ... So I vote for using always "%s" ... Regards, -- Marco Ciampa I know a joke about UDP, but you might not get it. GNU/Linux User #78271 FSFE fellow #364 ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Consistency in messages
On Wed, Nov 29, 2017 at 08:26:57PM +, Simon Richter wrote: > Hi, > > we don't seem to have a consistent convention on quoting in messages > shown to the user, and thus we have all three of > > '%s' > "%s" > <%s> > > in format strings when referring to names (files, nets, netclasses, …). > > For the untranslated strings, I'd prefer either double or single quotes, > while translated messages should probably use the locale appropriate > quoting format. > > Which should it be? My vote is for "%s" for the simple reason that "untranslated" strings in KiCad are effectively in en_US, and the quotation convention in American English is to use "" for outer quotes and '' for nested inner quotes. I've only seen <> as a convention for quoting email addresses (if we're using them somewhere I wonder if that derives from «»). > >Simon > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
