[Kicad-developers] Keep text upright
The keep text upright feature works poorly with left- or right-justified text (it flips around the anchor point). This is difficult to fix because it’s done at display time (so if the code is changed it will change the layout of existing boards). We could insert a second “keep upright” algorithm that’s done at edit time, and would essentially disable the display-time one for edited text (since it would already be adjusted to upright). The downside to this is that if you rotate some text with keep-upright on, and then turn it off, the text won’t “un-flip”. But maybe that’s not so bad? The “keep” verb nearly already suggests that it’s an edit-time function. Thoughts? ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Keep text upright
Am 2019-04-06 19:06, schrieb Jeff Young: The keep text upright feature works poorly with left- or right-justified text (it flips around the anchor point). This is difficult to fix because it’s done at display time (so if the code is changed it will change the layout of existing boards). We could insert a second “keep upright” algorithm that’s done at edit time, and would essentially disable the display-time one for edited text (since it would already be adjusted to upright). The downside to this is that if you rotate some text with keep-upright on, and then turn it off, the text won’t “un-flip”. But maybe that’s not so bad? The “keep” verb nearly already suggests that it’s an edit-time function. Hi Jeff- If we do this at edit-time, won't that effectively negate the "keep upright" part? As it, when does the text change? When the item's orientation on the board is changed? Or earlier? I don't think the lack of an "un-flip" is bad. As long as the user is editing the text, they are looking for changes, I think. -S ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Keep text upright
Below: > On 7 Apr 2019, at 04:09, Seth Hillbrand wrote: > > Am 2019-04-06 19:06, schrieb Jeff Young: >> The keep text upright feature works poorly with left- or >> right-justified text (it flips around the anchor point). >> This is difficult to fix because it’s done at display time (so if the >> code is changed it will change the layout of existing boards). >> We could insert a second “keep upright” algorithm that’s done at edit >> time, and would essentially disable the display-time one for edited >> text (since it would already be adjusted to upright). The downside to >> this is that if you rotate some text with keep-upright on, and then >> turn it off, the text won’t “un-flip”. But maybe that’s not so bad? >> The “keep” verb nearly already suggests that it’s an edit-time >> function. > > Hi Jeff- > > If we do this at edit-time, won't that effectively negate the "keep upright" > part? As it, when does the text change? When the item's orientation on the > board is changed? Yes, it would re-adjust when you rotated, flipped or mirrored the text (or its parent). > Or earlier? > > I don't think the lack of an "un-flip" is bad. As long as the user is > editing the text, they are looking for changes, I think. > > -S ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Keep text upright
On 2019-04-06 7:06 p.m., Jeff Young wrote: The keep text upright feature works poorly with left- or right-justified text (it flips around the anchor point). [snip]> if you rotate some text with keep-upright on, and then turn it off, the text won’t “un-flipâ€. But maybe that’s not so bad? The “keep†verb nearly already suggests that it’s an edit-time function. I've had a problem with the keep upright feature since it was introduced. It has been causing me more problems than it is supposed to solve. I have a custom patch in my copy of the source tree that disables the feature. The problem with keep upright is that it doesn't know which board edges are the "up" side. For one of my PCB's it is using the wrong edges for "up". -- Cheers! Kevin. http://www.ve3syb.ca/ | "Nerds make the shiny things that https://www.patreon.com/KevinCozens | distract the mouth-breathers, and | that's why we're powerful" Owner of Elecraft K2 #2172 | #include | --Chris Hardwick ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Keep text upright
Hi Kevin, It would be reasonably straight-forward to fix that. Log a wishlist bug for Board setup setting to indicate which edges of board are “up” for “keep upright”. Cheers, Jeff. > On 8 Apr 2019, at 15:32, Kevin Cozens wrote: > > On 2019-04-06 7:06 p.m., Jeff Young wrote: >> The keep text upright feature works poorly with left- or right-justified >> text (it flips around the anchor point). > [snip]> if you rotate some text with keep-upright on, and then turn it off, > the text won’t “un-flipâ€. But maybe that’s not so bad? The > “keep†verb nearly already suggests that it’s an edit-time function. > > I've had a problem with the keep upright feature since it was introduced. It > has been causing me more problems than it is supposed to solve. I have a > custom patch in my copy of the source tree that disables the feature. > > The problem with keep upright is that it doesn't know which board edges are > the "up" side. For one of my PCB's it is using the wrong edges for "up". > > -- > Cheers! > > Kevin. > > http://www.ve3syb.ca/ | "Nerds make the shiny things that > https://www.patreon.com/KevinCozens | distract the mouth-breathers, and >| that's why we're powerful" > Owner of Elecraft K2 #2172 | > #include | --Chris Hardwick > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
