Re: [Kicad-developers] Patch: In eeschema: use unused hotkey 'Backspace' to be equivalent to 'Delete'

2014-02-05 Thread Brian Sidebotham
On 5 February 2014 15:54, Nick Østergaard  wrote:
>> However, I notice that changing the Delete function hotkey doesn't
>> work. This in fact should be filed as a bug; So please file a bug
>> report on Launchpad so it can be fixed, or else feel free to apply a
>> patch that fixes this bug instead. The best method is to file a bug
>> report on launchpad and issue a patch to fix it at the same time, but
>> at least if there's a bug report someone else can maybe fix it before
>> you get around to it.
>
>
> There is already similar stuff already reported. This could be related,
> without looking too much into it.
> https://bugs.launchpad.net/kicad/+bug/706361
>

Hi Nick,

That's different, two functions for one hotkey. That would require
macro support - because you'll need to control the order of functions.

Best Regards,

Brian.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Patch: In eeschema: use unused hotkey 'Backspace' to be equivalent to 'Delete'

2014-02-05 Thread Brian Sidebotham
On 5 February 2014 15:54, Henner Zeller  wrote:
> On 5 February 2014 06:11, Brian Sidebotham 
> wrote:
>>
>> Hi Henner,
>>
>> In EESCHEMA, under Preferences->Hotkeys->Edit Hotkeys, you can edit
>> the hotkeys and set Backspace as the Delete function.
>
>
> Uh, life can be so simple at times :)
>
>>
>>
>> However, I notice that changing the Delete function hotkey doesn't
>> work.
>
>
> mmh, I just tried it, and it actually worked: went to hotkeys, selected the
> field with 'Del' in it and pressed Backspace. That worked for me.
>
> This was compiled from head. Only difference could be the wxWidgets version
> ?
> I am using it with 2.8; I shall try with a newer version to see if that is
> working.

Excellent, then it's already fixed. I'm on a laptop with BZR4016
installed, so I could only test in that version.

Best Regards,

Brian.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Patch: In eeschema: use unused hotkey 'Backspace' to be equivalent to 'Delete'

2014-02-05 Thread Nick Østergaard
>
> However, I notice that changing the Delete function hotkey doesn't
> work. This in fact should be filed as a bug; So please file a bug
> report on Launchpad so it can be fixed, or else feel free to apply a
> patch that fixes this bug instead. The best method is to file a bug
> report on launchpad and issue a patch to fix it at the same time, but
> at least if there's a bug report someone else can maybe fix it before
> you get around to it.
>

There is already similar stuff already reported. This could be related,
without looking too much into it.
https://bugs.launchpad.net/kicad/+bug/706361
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Patch: In eeschema: use unused hotkey 'Backspace' to be equivalent to 'Delete'

2014-02-05 Thread Henner Zeller
On 5 February 2014 06:11, Brian Sidebotham wrote:

> Hi Henner,
>
> In EESCHEMA, under Preferences->Hotkeys->Edit Hotkeys, you can edit
> the hotkeys and set Backspace as the Delete function.
>

Uh, life can be so simple at times :)


>
> However, I notice that changing the Delete function hotkey doesn't
> work.


mmh, I just tried it, and it actually worked: went to hotkeys, selected the
field with 'Del' in it and pressed Backspace. That worked for me.

This was compiled from head. Only difference could be the wxWidgets version
?
I am using it with 2.8; I shall try with a newer version to see if that is
working.


> This in fact should be filed as a bug; So please file a bug
> report on Launchpad so it can be fixed, or else feel free to apply a
> patch that fixes this bug instead.

The best method is to file a bug
> report on launchpad and issue a patch to fix it at the same time, but
> at least if there's a bug report someone else can maybe fix it before
> you get around to it.
>
> Thank-you for highlighting the issue.
>
> Best Regards,
>
> Brian.
>
> On 5 February 2014 05:02, Henner Zeller  wrote:
> > Hi,
> > My notebook has a keyboard that doesn't have a 'Delete' key, only
> > 'Backspace'. This makes deleting objects in eeschema quite cumbersome as
> > this always requires to use the right-mouse button menu.
> >
> > Since 'Backspace' is not bound to anything in eeschema, this patch adds
> the
> > Backspace key to be equivalent to the Delete key: removing the object
> under
> > the cursor.
> >
> > View patch here:
> >
> https://github.com/hzeller/kicad/compare/master...delete-and-backspace-equiv
> >
> > Download patch here:
> >
> https://github.com/hzeller/kicad/compare/master...delete-and-backspace-equiv.patch
> >
> > Since I am new to this codebase, I am not sure if this is the right way
> to
> > add another hotkey or if there is better way to get this same
> functionality.
> > If everything is ok, then I'd be happy to see this added to upstream.
> >
> > Thanks,
> >   -henner
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Patch: In eeschema: use unused hotkey 'Backspace' to be equivalent to 'Delete'

2014-02-05 Thread Brian Sidebotham
On 5 February 2014 14:39, Brian Sidebotham  wrote:

> I've also not tested how two keys bound to the same function perform
> in the Hotkeys Editor - but I suspect not well.

Sorry, scrap that last comment, of course it would be absolutely fine.

Best Regards, Brian.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Patch: In eeschema: use unused hotkey 'Backspace' to be equivalent to 'Delete'

2014-02-05 Thread Brian Sidebotham
On 5 February 2014 14:15, Chris Morgan  wrote:
>
> If there isn't a binding for the backspace key might it also make
> sense to have the default binding for 'delete item' be both backspace
> and delete by default? In addition of course to fixing whatever bug
> there is in the hotkey assignment.
>
> Chris

I don't think so, because for example in PCBNEW for example the
Backspace key and the Delete key have different functions. In PCBNEW
when you press the Delete key, you delete an entire net and when you
press the Backspace key you delete the current track segment only.

This is really useful funcionality and I would rather reserve a future
implementation of those separate functions associated to those two
keys in EESCHEMA rather than apply two keys to the same function now.

I've also not tested how two keys bound to the same function perform
in the Hotkeys Editor - but I suspect not well.

Best Regards,

Brian.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Patch: In eeschema: use unused hotkey 'Backspace' to be equivalent to 'Delete'

2014-02-05 Thread Chris Morgan
On Wed, Feb 5, 2014 at 9:11 AM, Brian Sidebotham
 wrote:
> Hi Henner,
>
> In EESCHEMA, under Preferences->Hotkeys->Edit Hotkeys, you can edit
> the hotkeys and set Backspace as the Delete function.
>
> However, I notice that changing the Delete function hotkey doesn't
> work. This in fact should be filed as a bug; So please file a bug
> report on Launchpad so it can be fixed, or else feel free to apply a
> patch that fixes this bug instead. The best method is to file a bug
> report on launchpad and issue a patch to fix it at the same time, but
> at least if there's a bug report someone else can maybe fix it before
> you get around to it.
>
> Thank-you for highlighting the issue.
>
> Best Regards,
>
> Brian.
>
> On 5 February 2014 05:02, Henner Zeller  wrote:
>> Hi,
>> My notebook has a keyboard that doesn't have a 'Delete' key, only
>> 'Backspace'. This makes deleting objects in eeschema quite cumbersome as
>> this always requires to use the right-mouse button menu.
>>
>> Since 'Backspace' is not bound to anything in eeschema, this patch adds the
>> Backspace key to be equivalent to the Delete key: removing the object under
>> the cursor.
>>
>> View patch here:
>> https://github.com/hzeller/kicad/compare/master...delete-and-backspace-equiv
>>
>> Download patch here:
>> https://github.com/hzeller/kicad/compare/master...delete-and-backspace-equiv.patch
>>
>> Since I am new to this codebase, I am not sure if this is the right way to
>> add another hotkey or if there is better way to get this same functionality.
>> If everything is ok, then I'd be happy to see this added to upstream.
>>
>> Thanks,
>>   -henner
>>

If there isn't a binding for the backspace key might it also make
sense to have the default binding for 'delete item' be both backspace
and delete by default? In addition of course to fixing whatever bug
there is in the hotkey assignment.

Chris

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Patch: In eeschema: use unused hotkey 'Backspace' to be equivalent to 'Delete'

2014-02-05 Thread Brian Sidebotham
Hi Henner,

In EESCHEMA, under Preferences->Hotkeys->Edit Hotkeys, you can edit
the hotkeys and set Backspace as the Delete function.

However, I notice that changing the Delete function hotkey doesn't
work. This in fact should be filed as a bug; So please file a bug
report on Launchpad so it can be fixed, or else feel free to apply a
patch that fixes this bug instead. The best method is to file a bug
report on launchpad and issue a patch to fix it at the same time, but
at least if there's a bug report someone else can maybe fix it before
you get around to it.

Thank-you for highlighting the issue.

Best Regards,

Brian.

On 5 February 2014 05:02, Henner Zeller  wrote:
> Hi,
> My notebook has a keyboard that doesn't have a 'Delete' key, only
> 'Backspace'. This makes deleting objects in eeschema quite cumbersome as
> this always requires to use the right-mouse button menu.
>
> Since 'Backspace' is not bound to anything in eeschema, this patch adds the
> Backspace key to be equivalent to the Delete key: removing the object under
> the cursor.
>
> View patch here:
> https://github.com/hzeller/kicad/compare/master...delete-and-backspace-equiv
>
> Download patch here:
> https://github.com/hzeller/kicad/compare/master...delete-and-backspace-equiv.patch
>
> Since I am new to this codebase, I am not sure if this is the right way to
> add another hotkey or if there is better way to get this same functionality.
> If everything is ok, then I'd be happy to see this added to upstream.
>
> Thanks,
>   -henner
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


[Kicad-developers] Patch: In eeschema: use unused hotkey 'Backspace' to be equivalent to 'Delete'

2014-02-04 Thread Henner Zeller
Hi,
My notebook has a keyboard that doesn't have a 'Delete' key, only
'Backspace'. This makes deleting objects in eeschema quite cumbersome as
this always requires to use the right-mouse button menu.

Since 'Backspace' is not bound to anything in eeschema, this patch adds the
Backspace key to be equivalent to the Delete key: removing the object under
the cursor.

View patch here:
https://github.com/hzeller/kicad/compare/master...delete-and-backspace-equiv

Download patch here:
https://github.com/hzeller/kicad/compare/master...delete-and-backspace-equiv.patch

Since I am new to this codebase, I am not sure if this is the right way to
add another hotkey or if there is better way to get this same
functionality. If everything is ok, then I'd be happy to see this added to
upstream.

Thanks,
  -henner
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp