Re: [Kicad-developers] Proposal to update eeSchema annotation?

[Alexander Shuklin]

Ok, I will do at tomorrow morning. I'm away from computer just now.

February 24, 2020 11:54:37 AM UTC, Eeli Kaikkonen  
пишет:
>Alexander, I filed a bug report
>https://gitlab.com/kicad/code/kicad/issues/3933 "No Undo for Annotate
>dialog annotation". Could you copy your text there as a comment?
>
>Eeli Kaikkonen
>
>On Mon, Feb 24, 2020 at 10:43 AM Alexander Shuklin
>
>wrote:
>
>> Hi anybody!
>> Sorry if there too much mistakes, I write from phone. When I looked
>into
>> undo stuff in schematic editor last time, it worked that way:
>> Every schematic sheet has its own undo/redo history and when you
>apply
>> undo, only components in the opened sheet are affected.
>> From my point of view just remind people that they cannot undone
>> annotation and back annotation is less evil. Otherwise somebody will
>face
>> up situation when he undone some annotation in one sheet but some
>annotated
>> components are still in other sheets.
>> I would say, that eeschema undo behaviour has to be changed. I
>thought
>> about 2 ways:
>> - make undo changes with all sheets, not the currently opened
>> - Prompt warning when you want to undo the action which was done with
>all
>> sheets in the project (such as annotations)
>> Just for information: that will be pretty easy to add undo feature in
>the
>> backannotation because it generates changelist which can be pushed to
>undo
>> stack. But it is useless with current schematic undo algorithm.
>>
>>

-- 
Простите за краткость, создано в Либрем Почта.___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Proposal to update eeSchema annotation?

[Eeli Kaikkonen]

Alexander, I filed a bug report
https://gitlab.com/kicad/code/kicad/issues/3933 "No Undo for Annotate
dialog annotation". Could you copy your text there as a comment?

Eeli Kaikkonen

On Mon, Feb 24, 2020 at 10:43 AM Alexander Shuklin 
wrote:

> Hi anybody!
> Sorry if there too much mistakes, I write from phone. When I looked into
> undo stuff in schematic editor last time, it worked that way:
> Every schematic sheet has its own undo/redo history and when you apply
> undo, only components in the opened sheet are affected.
> From my point of view just remind people that they cannot undone
> annotation and back annotation is less evil. Otherwise somebody will face
> up situation when he undone some annotation in one sheet but some annotated
> components are still in other sheets.
> I would say, that eeschema undo behaviour has to be changed. I thought
> about 2 ways:
> - make undo changes with all sheets, not the currently opened
> - Prompt warning when you want to undo the action which was done with all
> sheets in the project (such as annotations)
> Just for information: that will be pretty easy to add undo feature in the
> backannotation because it generates changelist which can be pushed to undo
> stack. But it is useless with current schematic undo algorithm.
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Proposal to update eeSchema annotation?

[Alexander Shuklin]

Hi anybody!
Sorry if there too much mistakes, I write from phone. When I looked into undo 
stuff in schematic editor last time, it worked that way:
Every schematic sheet has its own undo/redo history and when you apply undo, 
only components in the opened sheet are affected. 
From my point of view just remind people that they cannot undone annotation and 
back annotation is less evil. Otherwise somebody will face up situation when he 
undone some annotation in one sheet but some annotated components are still in 
other sheets.
I would say, that eeschema undo behaviour has to be changed. I thought about 2 
ways:
- make undo changes with all sheets, not the currently opened
- Prompt warning when you want to undo the action which was done with all 
sheets in the project (such as annotations)
Just for information: that will be pretty easy to add undo feature in the 
backannotation because it generates changelist which can be pushed to undo 
stack. But it is useless with current schematic undo algorithm.

February 23, 2020 4:35:07 PM UTC, Eeli Kaikkonen  
пишет:
>On Sat, Feb 22, 2020 at 4:48 PM Brian Piccioni
>
>wrote:
>
>> Hello
>>
>> Now that Geographic Reannotation is a WIP I was thinking it might
>make
>> sense to update eeSchema's Annotate dialog.
>>
>
>I created an epic for annotation related issues. You should probably
>file
>each proposition as a report if there's no report already.
>
>https://gitlab.com/groups/kicad/code/-/epics/19
>
>
>> Incorporate undo
>>
>
>There's an existing issue for "Back annotation changes unable to be
>undone in schematic", but there are more problems with Annotation.
>
>With one simple component open the annotation dialog, annotate and
>close.
>The component is annotated, but:
>
>1) "Save" is not activated in the toolbar. It's activated in the File
>menu.
>But when I click on the canvas, the button is activated.
>
>2) There's no undo. If I annotate manually by editing the refdes, Undo
>works. IIRC Undo has worked previously.
>
>These must be reported separately, right? (I'm asking from the senior
>developers.)
>
>Eeli Kaikkonen

-- 
Простите за краткость, создано в Либрем Почта.___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Proposal to update eeSchema annotation?

[Brian Piccioni]

Cool! A great idea.

I'd never heard of "epics" before this.


On 2020-02-23 11:35 a.m., Eeli Kaikkonen wrote:



On Sat, Feb 22, 2020 at 4:48 PM Brian Piccioni 
mailto:br...@documenteddesigns.com>> wrote:


Hello

Now that Geographic Reannotation is a WIP I was thinking it might
make sense to update eeSchema's Annotate dialog.


I created an epic for annotation related issues. You should probably 
file each proposition as a report if there's no report already.


https://gitlab.com/groups/kicad/code/-/epics/19


Incorporate undo


There's an existing issue for "Back annotation changes unable to be 
undone in schematic", but there are more problems with Annotation.


With one simple component open the annotation dialog, annotate and 
close. The component is annotated, but:


1) "Save" is not activated in the toolbar. It's activated in the File 
menu. But when I click on the canvas, the button is activated.


2) There's no undo. If I annotate manually by editing the refdes, Undo 
works. IIRC Undo has worked previously.


These must be reported separately, right? (I'm asking from the senior 
developers.)


Eeli Kaikkonen
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Proposal to update eeSchema annotation?

[Ian McInerney]

> 1) "Save" is not activated in the toolbar. It's activated in the File
menu. But when I click on the canvas, the button is activated.

This is going to be due to how the toolbar and menu states are updated. The
menus are CONDITIONAL_MENUS which rebuild whenever they are opened, but the
toolbars are synced by the tool framework explicitly on some actions. This
will get cleaned up when I switch over to the EVT_UPDATE_UI system and
remove the SyncToolbars function. In the meantime, please file this as an
issue with v6 milestone and I can assign myself and link it to the
appropriate epics. This will be a good testcase to ensure the switchover
worked fully.

-Ian

On Sun, Feb 23, 2020 at 4:36 PM Eeli Kaikkonen 
wrote:

>
>
> On Sat, Feb 22, 2020 at 4:48 PM Brian Piccioni <
> br...@documenteddesigns.com> wrote:
>
>> Hello
>>
>> Now that Geographic Reannotation is a WIP I was thinking it might make
>> sense to update eeSchema's Annotate dialog.
>>
>
> I created an epic for annotation related issues. You should probably file
> each proposition as a report if there's no report already.
>
> https://gitlab.com/groups/kicad/code/-/epics/19
>
>
>> Incorporate undo
>>
>
> There's an existing issue for "Back annotation changes unable to be
> undone in schematic", but there are more problems with Annotation.
>
> With one simple component open the annotation dialog, annotate and close.
> The component is annotated, but:
>
> 1) "Save" is not activated in the toolbar. It's activated in the File
> menu. But when I click on the canvas, the button is activated.
>
> 2) There's no undo. If I annotate manually by editing the refdes, Undo
> works. IIRC Undo has worked previously.
>
> These must be reported separately, right? (I'm asking from the senior
> developers.)
>
> Eeli Kaikkonen
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Proposal to update eeSchema annotation?

[Jon Evans]

Without looking at the code, those two *may* be linked (creating a new undo
step should cause the save button to be enabled)

On Sun, Feb 23, 2020 at 11:35 AM Eeli Kaikkonen 
wrote:

>
>
> On Sat, Feb 22, 2020 at 4:48 PM Brian Piccioni <
> br...@documenteddesigns.com> wrote:
>
>> Hello
>>
>> Now that Geographic Reannotation is a WIP I was thinking it might make
>> sense to update eeSchema's Annotate dialog.
>>
>
> I created an epic for annotation related issues. You should probably file
> each proposition as a report if there's no report already.
>
> https://gitlab.com/groups/kicad/code/-/epics/19
>
>
>> Incorporate undo
>>
>
> There's an existing issue for "Back annotation changes unable to be
> undone in schematic", but there are more problems with Annotation.
>
> With one simple component open the annotation dialog, annotate and close.
> The component is annotated, but:
>
> 1) "Save" is not activated in the toolbar. It's activated in the File
> menu. But when I click on the canvas, the button is activated.
>
> 2) There's no undo. If I annotate manually by editing the refdes, Undo
> works. IIRC Undo has worked previously.
>
> These must be reported separately, right? (I'm asking from the senior
> developers.)
>
> Eeli Kaikkonen
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Proposal to update eeSchema annotation?

[Eeli Kaikkonen]

On Sat, Feb 22, 2020 at 4:48 PM Brian Piccioni 
wrote:

> Hello
>
> Now that Geographic Reannotation is a WIP I was thinking it might make
> sense to update eeSchema's Annotate dialog.
>

I created an epic for annotation related issues. You should probably file
each proposition as a report if there's no report already.

https://gitlab.com/groups/kicad/code/-/epics/19


> Incorporate undo
>

There's an existing issue for "Back annotation changes unable to be
undone in schematic", but there are more problems with Annotation.

With one simple component open the annotation dialog, annotate and close.
The component is annotated, but:

1) "Save" is not activated in the toolbar. It's activated in the File menu.
But when I click on the canvas, the button is activated.

2) There's no undo. If I annotate manually by editing the refdes, Undo
works. IIRC Undo has worked previously.

These must be reported separately, right? (I'm asking from the senior
developers.)

Eeli Kaikkonen
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Proposal to update eeSchema annotation?

[Wayne Stambaugh]

On 2/22/20 10:40 AM, Jeff Young wrote:
> “Real” sheet numbering would be nice (ie: instead of page number times
> X, have a way to prefix by sheet start ref, and have a way to define
> that in the sheet).

Real sheet numbering is coming in the new schematic file format.

> 
>> On 22 Feb 2020, at 14:47, Brian Piccioni > > wrote:
>>
>> Hello
>>
>> Now that Geographic Reannotation is a WIP I was thinking it might make
>> sense to update eeSchema's Annotate dialog.
>>
>> I propose the following:
>>
>> *Change to dialog:*
>>
>> **Add to Scope:             Selection
>>
>> Add to Numbering:    Add/Remove prefixes (allows conformance to ASME
>> Y14.44 and IEEE 315)
>>                                       Replace "page number times 100,
>> 1000" with "page number times X"
>>
>> Add optional push to PCB
>>
>> Place Advanced options on a tab.
>>
>> *General:
>> *Incorporate undo
>> Perform a "sanity check" on new annotation to check for redundant
>> references before committing it.   
>>
>> *Other:
>> *Additional suggestions?
>>
>>
>> Compared to Geographic Reannotation this should be straightforward. I
>> do not see any need to modify PCBNew code.
>>
>> Also I have a better understanding of the code and process and should
>> require less hand holding.
>>
>> Any thoughts?
>>
>> Brian
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Proposal to update eeSchema annotation?

[Jeff Young]

“Real” sheet numbering would be nice (ie: instead of page number times X, have 
a way to prefix by sheet start ref, and have a way to define that in the sheet).

> On 22 Feb 2020, at 14:47, Brian Piccioni  wrote:
> 
> Hello
> Now that Geographic Reannotation is a WIP I was thinking it might make sense 
> to update eeSchema's Annotate dialog.
> I propose the following:
> Change to dialog:
> Add to Scope: Selection
> Add to Numbering:Add/Remove prefixes (allows conformance to ASME Y14.44 
> and IEEE 315)
>   Replace "page number times 100, 1000" 
> with "page number times X" 
> Add optional push to PCB 
> Place Advanced options on a tab.
> General:
> Incorporate undo
> Perform a "sanity check" on new annotation to check for redundant references 
> before committing it.
> Other:
> Additional suggestions?
> 
> Compared to Geographic Reannotation this should be straightforward. I do not 
> see any need to modify PCBNew code.
> Also I have a better understanding of the code and process and should require 
> less hand holding.
> Any thoughts?
> Brian
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Proposal to update eeSchema annotation?

[Brian Piccioni]

Hello

Now that Geographic Reannotation is a WIP I was thinking it might make 
sense to update eeSchema's Annotate dialog.


I propose the following:

*Change to dialog:*

**Add to Scope:             Selection

Add to Numbering:    Add/Remove prefixes (allows conformance to ASME 
Y14.44 and IEEE 315)
                                      Replace "page number times 100, 
1000" with "page number times X"


Add optional push to PCB

Place Advanced options on a tab.

*General:
*Incorporate undo
Perform a "sanity check" on new annotation to check for redundant 
references before committing it.


*Other:
*Additional suggestions?


Compared to Geographic Reannotation this should be straightforward. I do 
not see any need to modify PCBNew code.


Also I have a better understanding of the code and process and should 
require less hand holding.


Any thoughts?

Brian

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp