Re: [Kicad-developers] Removal of some globals

[Oleg Endo]

On Sun, 2020-04-05 at 20:48 +0200, jp charras wrote:
> Le 05/04/2020 à 17:20, Jeff Young a écrit :
> > I had to remove some globals from Eeschema that were causing problems 
> > (default line width, text size, wire thickness, bus thickness etc.).
> > 
> > It was a large change (as these things always are), so let me know if you 
> > see anything odd.
> > 
> > Cheers,
> > Jeff.
> 
> Hi Jeff:
> a typo in function:
> int LIB_CIRCLE::GetPenSize() const
> is missing the return statement.
> 

This should not even compile.  On GCC there is "-Werror=return-type"
for that.  Any particular reason why not to use this diagnostic?

Cheers,
Oleg


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Removal of some globals

[Wayne Stambaugh]

The goal has always been to get the number of globals to zero if
possible.  It's just been a slow arduous process.

On 4/5/20 11:53 AM, Ian McInerney wrote:
> We should try to limit our use of globals/statics in the code from now
> on. We have definitely had quite a few bugs related to their use in the
> past.
> 
> -Ian
> 
> On Sun, Apr 5, 2020 at 4:20 PM Jeff Young  > wrote:
> 
> I had to remove some globals from Eeschema that were causing
> problems (default line width, text size, wire thickness, bus
> thickness etc.).
> 
> It was a large change (as these things always are), so let me know
> if you see anything odd.
> 
> Cheers,
> Jeff.
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Removal of some globals

[jp charras]

Le 05/04/2020 à 17:20, Jeff Young a écrit :
> I had to remove some globals from Eeschema that were causing problems 
> (default line width, text size, wire thickness, bus thickness etc.).
> 
> It was a large change (as these things always are), so let me know if you see 
> anything odd.
> 
> Cheers,
> Jeff.

Hi Jeff:
a typo in function:
int LIB_CIRCLE::GetPenSize() const
is missing the return statement.


-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Removal of some globals

[Ian McInerney]

We should try to limit our use of globals/statics in the code from now on.
We have definitely had quite a few bugs related to their use in the past.

-Ian

On Sun, Apr 5, 2020 at 4:20 PM Jeff Young  wrote:

> I had to remove some globals from Eeschema that were causing problems
> (default line width, text size, wire thickness, bus thickness etc.).
>
> It was a large change (as these things always are), so let me know if you
> see anything odd.
>
> Cheers,
> Jeff.
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Removal of some globals

[Jeff Young]

I had to remove some globals from Eeschema that were causing problems (default 
line width, text size, wire thickness, bus thickness etc.).

It was a large change (as these things always are), so let me know if you see 
anything odd.

Cheers,
Jeff.
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp