Re: [Kicad-developers] Return value from SHAPE_POLY_SET::pointInPolygon

2015-08-03 Thread Maciej SumiƄski
Hi Simon,

Thank you for noticing, now it is corrected.

Regards,
Orson

On 07/28/2015 12:40 AM, Simon Richter wrote:
 Hi,
 
 that function returns a bool, but common/geometry/shape_poly_set.cpp
 line 704-705 has
 
 if( !d )
 return -1;
 
 That smells fishy and gives a compiler warning.
 
Simon
 
 
 
 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp
 




signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


[Kicad-developers] Return value from SHAPE_POLY_SET::pointInPolygon

2015-07-27 Thread Simon Richter
Hi,

that function returns a bool, but common/geometry/shape_poly_set.cpp
line 704-705 has

if( !d )
return -1;

That smells fishy and gives a compiler warning.

   Simon



signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp