Re: [Kicad-developers] boost & gcc 4.8.1

[Maciej Sumiński]

On 11/11/2013 04:00 PM, Dick Hollenbeck wrote:

Hi Orson,



On 11/11/2013 11:47 AM, Brian Sidebotham wrote:

On 11 November 2013 10:32, Maciej Sumiński mailto:maciej.sumin...@cern.ch>> wrote:

 Boost downloaded by KiCad does not build with gcc 4.8.1 - it is
 already resolved in boost-trunk. I do not know what is the policy
 for applying patches that are going to be included in the
 mainstream, but just in case - the attached patched removes the problem.


CMake's ExternalProject_Add() can apply multiple patches, using the COMMAND 
continuation.
(BTW all *_COMMANDs can be continued with COMMAND.  I used to use && for command
continuation, but this requires a shell, not there on Windows.)

Since each patch applied via CMake's ExternalProject_Add() is a separate wish 
for
upstream, and some of those battles will be won and some lost, we are probably 
best served
by keeping our patches separate rather than combining them.  This way on the 
next release
of say, boost, the patches they did not take can easily persist if need be on 
our end,
rather than us having to doctor our combined patch file.

This is what I committed.  Hopefully it will work for you on linux gcc 4.8.1.


It works, the problem is gone now. Thank you.

Regards,
Orson


Thanks for digging this out.

Dick




 Regards,
 Orson


By the looks of it this is a 32-bit OS problem only? I certainly don't
have a problem with Boost compiling on Windows 7 x64 and
KiCad-Winbuilder is also using mingw32-w64 4.8.1 and compiles okay.

I don't have a 32-bit system to test on. It's certainly not *just* gcc
4.8.1 and Boost anyway.

Best Regards,

Brian.



Then it may be related to Linux exclusively, as I use 64 bit too and the
error occurs. More details can be found at:
https://svn.boost.org/trac/boost/ticket/8973

Regards,
Orson



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp




___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] boost & gcc 4.8.1

[Dick Hollenbeck]

Hi Orson,


> On 11/11/2013 11:47 AM, Brian Sidebotham wrote:
>> On 11 November 2013 10:32, Maciej Sumiński > > wrote:
>>
>> Boost downloaded by KiCad does not build with gcc 4.8.1 - it is
>> already resolved in boost-trunk. I do not know what is the policy
>> for applying patches that are going to be included in the
>> mainstream, but just in case - the attached patched removes the problem.

CMake's ExternalProject_Add() can apply multiple patches, using the COMMAND 
continuation.
(BTW all *_COMMANDs can be continued with COMMAND.  I used to use && for command
continuation, but this requires a shell, not there on Windows.)

Since each patch applied via CMake's ExternalProject_Add() is a separate wish 
for
upstream, and some of those battles will be won and some lost, we are probably 
best served
by keeping our patches separate rather than combining them.  This way on the 
next release
of say, boost, the patches they did not take can easily persist if need be on 
our end,
rather than us having to doctor our combined patch file.

This is what I committed.  Hopefully it will work for you on linux gcc 4.8.1.

Thanks for digging this out.

Dick


>>
>> Regards,
>> Orson
>>
>>
>> By the looks of it this is a 32-bit OS problem only? I certainly don't
>> have a problem with Boost compiling on Windows 7 x64 and
>> KiCad-Winbuilder is also using mingw32-w64 4.8.1 and compiles okay.
>>
>> I don't have a 32-bit system to test on. It's certainly not *just* gcc
>> 4.8.1 and Boost anyway.
>>
>> Best Regards,
>>
>> Brian.
>>
> 
> Then it may be related to Linux exclusively, as I use 64 bit too and the 
> error occurs. More details can be found at: 
> https://svn.boost.org/trac/boost/ticket/8973
> 
> Regards,
> Orson


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] boost & gcc 4.8.1

[Brian Sidebotham]

On 11 November 2013 10:49, Maciej Sumiński  wrote:

>
> Then it may be related to Linux exclusively, as I use 64 bit too and the
> error occurs. More details can be found at: https://svn.boost.org/trac/
> boost/ticket/8973
>
> Regards,
> Orson
>

Hi Orson,

It may be. I just looked at the mingw32-w64 stdint.h and it unconditionally
defines int64_t and uint64_t so there's going to be no problem with it
being defined using that compiler.

The problem seems specific to some stdint implementations.

Best Regards,

Brian.
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] boost & gcc 4.8.1

[Maciej Sumiński]

On 11/11/2013 11:47 AM, Brian Sidebotham wrote:

On 11 November 2013 10:32, Maciej Sumiński mailto:maciej.sumin...@cern.ch>> wrote:

Boost downloaded by KiCad does not build with gcc 4.8.1 - it is
already resolved in boost-trunk. I do not know what is the policy
for applying patches that are going to be included in the
mainstream, but just in case - the attached patched removes the problem.

Regards,
Orson


By the looks of it this is a 32-bit OS problem only? I certainly don't
have a problem with Boost compiling on Windows 7 x64 and
KiCad-Winbuilder is also using mingw32-w64 4.8.1 and compiles okay.

I don't have a 32-bit system to test on. It's certainly not *just* gcc
4.8.1 and Boost anyway.

Best Regards,

Brian.



Then it may be related to Linux exclusively, as I use 64 bit too and the 
error occurs. More details can be found at: 
https://svn.boost.org/trac/boost/ticket/8973


Regards,
Orson

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] boost & gcc 4.8.1

[Brian Sidebotham]

On 11 November 2013 10:32, Maciej Sumiński  wrote:

> Boost downloaded by KiCad does not build with gcc 4.8.1 - it is already
> resolved in boost-trunk. I do not know what is the policy for applying
> patches that are going to be included in the mainstream, but just in case -
> the attached patched removes the problem.
>
> Regards,
> Orson
>
>
By the looks of it this is a 32-bit OS problem only? I certainly don't have
a problem with Boost compiling on Windows 7 x64 and KiCad-Winbuilder is
also using mingw32-w64 4.8.1 and compiles okay.

I don't have a 32-bit system to test on. It's certainly not *just* gcc
4.8.1 and Boost anyway.

Best Regards,

Brian.
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] boost & gcc 4.8.1

[Maciej Sumiński]

Boost downloaded by KiCad does not build with gcc 4.8.1 - it is already 
resolved in boost-trunk. I do not know what is the policy for applying 
patches that are going to be included in the mainstream, but just in 
case - the attached patched removes the problem.


Regards,
Orson
=== modified file 'patches/boost.patch'
--- patches/boost.patch	2013-05-31 04:46:02 +
+++ patches/boost.patch	2013-11-11 10:27:18 +
@@ -18,3 +18,16 @@
itrT2 tmpb = bb;
++tmpb;
 
+=== modified file 'boost/cstdint.hpp'
+--- boost/cstdint.hpp
 boost/cstdint.hpp
+@@ -42,5 +42,8 @@
+ // See https://svn.boost.org/trac/boost/ticket/3548 and http://sources.redhat.com/bugzilla/show_bug.cgi?id=10990
+ //
+-#if defined(BOOST_HAS_STDINT_H) && (!defined(__GLIBC__) || defined(__GLIBC_HAVE_LONG_LONG))
++#if defined(BOOST_HAS_STDINT_H) \
++  && (!defined(__GLIBC__)   \
++  || defined(__GLIBC_HAVE_LONG_LONG)\
++  || (defined(__GLIBC__) && ((__GLIBC__ > 2) || ((__GLIBC__ == 2) && (__GLIBC_MINOR__ >= 17)
+ 
+ // The following #include is an implementation artifact; not part of interface.
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp