Re: [Kicad-developers] [PATCH] Assertion failure and can't close Hotkeys List
Le 23/03/2015 08:51, Marco Ciampa a écrit : On Sun, Mar 22, 2015 at 03:11:30PM +0100, jp charras wrote: These hotkey strings info are now translated in dialogs in rev 5530. Many thanks! Starting translating right now! PS: #: pcbnew/hotkeys.cpp:96 msgid Save Module is this right or you meant a Save footprint? -- Marco Ciampa I mean Save Footprint Modified in rev 5531. -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Assertion failure and can't close Hotkeys List
On Mon, Mar 23, 2015 at 09:29:37AM +0100, jp charras wrote: I mean Save Footprint Modified in rev 5531. Thanks! During translation you encounter many small typo and such, it is like an involuntary revision. Perhaps here there is another: #: pcbnew/pad_edition_functions.cpp:217 #, c-format msgid Delete Pad (module %s %s) apart from the module again, perhaps there is a question mark missing? -- Marco Ciampa I know a joke about UDP, but you might not get it. ++ | GNU/Linux User #78271 | | FSFE fellow #364 | ++ ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Assertion failure and can't close Hotkeys List
On Sun, Mar 22, 2015 at 03:11:30PM +0100, jp charras wrote: These hotkey strings info are now translated in dialogs in rev 5530. Many thanks! Starting translating right now! PS: #: pcbnew/hotkeys.cpp:96 msgid Save Module is this right or you meant a Save footprint? -- Marco Ciampa I know a joke about UDP, but you might not get it. ++ | GNU/Linux User #78271 | | FSFE fellow #364 | ++ ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Assertion failure and can't close Hotkeys List
Le 21/03/2015 14:47, Marco Ciampa a écrit : On Sat, Mar 21, 2015 at 02:38:36PM +0100, jp charras wrote: Le 21/03/2015 14:05, Marco Ciampa a écrit : On Fri, Mar 20, 2015 at 08:12:36PM +0100, jp charras wrote: Le 20/03/2015 19:15, Chris Pavlina a écrit : When the Hotkeys List was changed to non-modal, its OnCloseButtonClick() was not changed to reflect the fact that modal and modeless dialogs have to be closed differently in wx. Here's a patch to fix that, which should work for all HTML_MESSAGE_BOXes whether or not they're modal. Chris Damn! you are right. I committed your patch. thanks. And, BTW, why the hotkey list is not i18n? Using a HELP Window that do not help you in your tongue, meanwhile all the program dialogs are translated, is bizarre at least... Well: - Most of hotkeys are the first letter of the command name (in English) That is _not_ a problem, especially when translating a tutorial, having the same keys. - These strings are also used as keywords in hotkey config file. Keep them in English is not so bad. No, believe me. Either use the program in English or traslate _all_. In this case IMHO a compromise is not accettable (this is also the case for .kicad_pcb files which are using English layers names for non copper layer.) And I agree here. A document format/content is _not_ a help window. I espect it to be read by different kind of people, not beginners anyway... -- Marco Ciampa These hotkey strings info are now translated in dialogs in rev 5530. However, because I need both the translated and the English version of these strings, they are prefixed by _HKI (instead of _ for usual translatable strings, which are always translated). This prefix can be used by translation tools to extract them. (Just add this prefix to the list of other prefixes, which is currently only one prefix: _) -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Assertion failure and can't close Hotkeys List
On Sat, Mar 21, 2015 at 02:38:36PM +0100, jp charras wrote: Le 21/03/2015 14:05, Marco Ciampa a écrit : On Fri, Mar 20, 2015 at 08:12:36PM +0100, jp charras wrote: Le 20/03/2015 19:15, Chris Pavlina a écrit : When the Hotkeys List was changed to non-modal, its OnCloseButtonClick() was not changed to reflect the fact that modal and modeless dialogs have to be closed differently in wx. Here's a patch to fix that, which should work for all HTML_MESSAGE_BOXes whether or not they're modal. Chris Damn! you are right. I committed your patch. thanks. And, BTW, why the hotkey list is not i18n? Using a HELP Window that do not help you in your tongue, meanwhile all the program dialogs are translated, is bizarre at least... Well: - Most of hotkeys are the first letter of the command name (in English) That is _not_ a problem, especially when translating a tutorial, having the same keys. - These strings are also used as keywords in hotkey config file. Keep them in English is not so bad. No, believe me. Either use the program in English or traslate _all_. In this case IMHO a compromise is not accettable (this is also the case for .kicad_pcb files which are using English layers names for non copper layer.) And I agree here. A document format/content is _not_ a help window. I espect it to be read by different kind of people, not beginners anyway... -- Marco Ciampa I know a joke about UDP, but you might not get it. ++ | GNU/Linux User #78271 | | FSFE fellow #364 | ++ ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Assertion failure and can't close Hotkeys List
...and IMHO the list is a little too big. With a small screen it goes out of the screen border. Why not: 1) use a smaller default font 2) make it in two columns I am afraid to be boring you all with my usability/i18n feedback, hope someone will appreciate it. -- Marco Ciampa I know a joke about UDP, but you might not get it. ++ | GNU/Linux User #78271 | | FSFE fellow #364 | ++ ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Assertion failure and can't close Hotkeys List
On Fri, Mar 20, 2015 at 08:12:36PM +0100, jp charras wrote: Le 20/03/2015 19:15, Chris Pavlina a écrit : When the Hotkeys List was changed to non-modal, its OnCloseButtonClick() was not changed to reflect the fact that modal and modeless dialogs have to be closed differently in wx. Here's a patch to fix that, which should work for all HTML_MESSAGE_BOXes whether or not they're modal. Chris Damn! you are right. I committed your patch. thanks. And, BTW, why the hotkey list is not i18n? Using a HELP Window that do not help you in your tongue, meanwhile all the program dialogs are translated, is bizarre at least... -- Marco Ciampa I know a joke about UDP, but you might not get it. ++ | GNU/Linux User #78271 | | FSFE fellow #364 | ++ ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Assertion failure and can't close Hotkeys List
Le 21/03/2015 14:05, Marco Ciampa a écrit : On Fri, Mar 20, 2015 at 08:12:36PM +0100, jp charras wrote: Le 20/03/2015 19:15, Chris Pavlina a écrit : When the Hotkeys List was changed to non-modal, its OnCloseButtonClick() was not changed to reflect the fact that modal and modeless dialogs have to be closed differently in wx. Here's a patch to fix that, which should work for all HTML_MESSAGE_BOXes whether or not they're modal. Chris Damn! you are right. I committed your patch. thanks. And, BTW, why the hotkey list is not i18n? Using a HELP Window that do not help you in your tongue, meanwhile all the program dialogs are translated, is bizarre at least... Well: - Most of hotkeys are the first letter of the command name (in English) - These strings are also used as keywords in hotkey config file. Keep them in English is not so bad. (this is also the case for .kicad_pcb files which are using English layers names for non copper layer.) -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
