Re: [Kicad-developers] [PATCH] Enable C++11

[Chris Pavlina]

Patch committed in rev 6635. Thank you.

;)


On Wed, Apr 06, 2016 at 05:31:37AM +0200, Simon Richter wrote:
> Hi,
> 
> On 06.04.2016 05:19, Simon Richter wrote:
> 
> > This enables C++11 support, if either CMake is sufficiently new to have
> > this feature built in, or the compiler is supported by the workaround code
> > (gcc or clang).
> 
> Meh, that patch was still in the temp dir where I stage mails before
> sending. As C++11 support is already there, please ignore :/
> 
>Simon
> 
> 



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Simon Richter]

Hi,

On 06.04.2016 05:19, Simon Richter wrote:

> This enables C++11 support, if either CMake is sufficiently new to have
> this feature built in, or the compiler is supported by the workaround code
> (gcc or clang).

Meh, that patch was still in the temp dir where I stage mails before
sending. As C++11 support is already there, please ignore :/

   Simon




signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Wayne Stambaugh]

While I agree with you in principal, I have a feeling that we will loose
some dev branch testers by doing this.  How many is hard to say but
development branch testers are a valuable resource.  They tend to find
things that developers miss.

On 3/21/2016 3:38 PM, Chris Pavlina wrote:
> 16.04 LTS will be released in April. Personally I think we should be free to
> stop supporting 14.04 Geriatric Giraffe already in the development branch - 
> why
> should a devel branch of kicad support non-devel branches of Ubuntu? KiCad
> stable runs on Ubuntu "stable" (LTS). But I seem to be in the minority. At 
> this
> point though, I really don't see a problem with breaking free of 14.04 and
> targeting the upcoming 16.04. It's a devel branch for chrissakes ;)
> 
> 
> On Mon, Mar 21, 2016 at 08:33:00PM +0100, jp charras wrote:
>> Le 21/03/2016 20:13, Nick Østergaard a écrit :
>>> 2016-03-21 20:10 GMT+01:00 jp charras :
 Le 21/03/2016 19:54, Nick Østergaard a écrit :
> 2016-03-21 19:52 GMT+01:00 jp charras :
>> Le 21/03/2016 16:13, Wayne Stambaugh a écrit :
>>> Going, going, gone!  Since I haven't gotten any objections, I committed
>>> the patch to enable C++11.  Thanks Simon for the patch but be prepared
>>> for the grumbling. :)
>>>
>>
>> On Ubuntu 14.04 LTS - 64 bits (with latest update) I have an issue when
>> compiling pcbnewPYTHON_wrap.cxx.
>
> I guess this is because wxpython is missing on 14.04.

 No.
 I am able to build Kicad with option -DKICAD_SCRIPTING_WXPYTHON=ON.
 The issue is not related to wxpython.
 I also have this issue when I use only the option -DKICAD_SCRIPTING=ON.
 This issue exists *only* when option -std=c++11 or -std=gnu++11 is used.
>>>
>>> Lets just ignore this since 14.04 is end of life in august 2016 and
>>> use our effort on kicad moving forward.
>>>
>>
>> AFAIK, in august 2016, Ubuntu 16.xx LTS will be available.
>> It is not yet available.
>> Ubuntu 14.04 LTS is the latest LTS version.
>>
>> However, as I said, Kicad without python support is build-able.
>>
>>
>> -- 
>> Jean-Pierre CHARRAS
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[jp charras]

Le 21/03/2016 20:38, Chris Pavlina a écrit :

16.04 LTS will be released in April. Personally I think we should be free to
stop supporting 14.04 Geriatric Giraffe already in the development branch - why
should a devel branch of kicad support non-devel branches of Ubuntu? KiCad
stable runs on Ubuntu "stable" (LTS). But I seem to be in the minority. At this
point though, I really don't see a problem with breaking free of 14.04 and
targeting the upcoming 16.04. It's a devel branch for chrissakes ;)




I have no problem to target the upcoming 16.04.
I'll switch to 16.04 as soon as it is available.

And I previously said, I fully agree with c11 option support.

Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Chris Pavlina]

16.04 LTS will be released in April. Personally I think we should be free to
stop supporting 14.04 Geriatric Giraffe already in the development branch - why
should a devel branch of kicad support non-devel branches of Ubuntu? KiCad
stable runs on Ubuntu "stable" (LTS). But I seem to be in the minority. At this
point though, I really don't see a problem with breaking free of 14.04 and
targeting the upcoming 16.04. It's a devel branch for chrissakes ;)


On Mon, Mar 21, 2016 at 08:33:00PM +0100, jp charras wrote:
> Le 21/03/2016 20:13, Nick Østergaard a écrit :
> > 2016-03-21 20:10 GMT+01:00 jp charras :
> >> Le 21/03/2016 19:54, Nick Østergaard a écrit :
> >>> 2016-03-21 19:52 GMT+01:00 jp charras :
>  Le 21/03/2016 16:13, Wayne Stambaugh a écrit :
> > Going, going, gone!  Since I haven't gotten any objections, I committed
> > the patch to enable C++11.  Thanks Simon for the patch but be prepared
> > for the grumbling. :)
> >
> 
>  On Ubuntu 14.04 LTS - 64 bits (with latest update) I have an issue when
>  compiling pcbnewPYTHON_wrap.cxx.
> >>>
> >>> I guess this is because wxpython is missing on 14.04.
> >>
> >> No.
> >> I am able to build Kicad with option -DKICAD_SCRIPTING_WXPYTHON=ON.
> >> The issue is not related to wxpython.
> >> I also have this issue when I use only the option -DKICAD_SCRIPTING=ON.
> >> This issue exists *only* when option -std=c++11 or -std=gnu++11 is used.
> > 
> > Lets just ignore this since 14.04 is end of life in august 2016 and
> > use our effort on kicad moving forward.
> > 
> 
> AFAIK, in august 2016, Ubuntu 16.xx LTS will be available.
> It is not yet available.
> Ubuntu 14.04 LTS is the latest LTS version.
> 
> However, as I said, Kicad without python support is build-able.
> 
> 
> -- 
> Jean-Pierre CHARRAS
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[jp charras]

Le 21/03/2016 20:28, Chris Pavlina a écrit :
> Are we sure this isn't the issue where cmake forgets to rebuild
> pcbnewPYTHON_wrap.cxx? I've been having that issue about once every couple
> weeks for a while, just delete it and rebuild :P
> 

Yes, I used a fresh build folder, and tried more than once, from scratch.


-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[jp charras]

Le 21/03/2016 20:13, Nick Østergaard a écrit :
> 2016-03-21 20:10 GMT+01:00 jp charras :
>> Le 21/03/2016 19:54, Nick Østergaard a écrit :
>>> 2016-03-21 19:52 GMT+01:00 jp charras :
 Le 21/03/2016 16:13, Wayne Stambaugh a écrit :
> Going, going, gone!  Since I haven't gotten any objections, I committed
> the patch to enable C++11.  Thanks Simon for the patch but be prepared
> for the grumbling. :)
>

 On Ubuntu 14.04 LTS - 64 bits (with latest update) I have an issue when
 compiling pcbnewPYTHON_wrap.cxx.
>>>
>>> I guess this is because wxpython is missing on 14.04.
>>
>> No.
>> I am able to build Kicad with option -DKICAD_SCRIPTING_WXPYTHON=ON.
>> The issue is not related to wxpython.
>> I also have this issue when I use only the option -DKICAD_SCRIPTING=ON.
>> This issue exists *only* when option -std=c++11 or -std=gnu++11 is used.
> 
> Lets just ignore this since 14.04 is end of life in august 2016 and
> use our effort on kicad moving forward.
> 

AFAIK, in august 2016, Ubuntu 16.xx LTS will be available.
It is not yet available.
Ubuntu 14.04 LTS is the latest LTS version.

However, as I said, Kicad without python support is build-able.


-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[jp charras]

Le 21/03/2016 20:11, Wayne Stambaugh a écrit :
> On 3/21/2016 3:10 PM, jp charras wrote:
>> Le 21/03/2016 19:54, Nick Østergaard a écrit :
>>> 2016-03-21 19:52 GMT+01:00 jp charras :
 Le 21/03/2016 16:13, Wayne Stambaugh a écrit :
> Going, going, gone!  Since I haven't gotten any objections, I committed
> the patch to enable C++11.  Thanks Simon for the patch but be prepared
> for the grumbling. :)
>

 On Ubuntu 14.04 LTS - 64 bits (with latest update) I have an issue when
 compiling pcbnewPYTHON_wrap.cxx.
>>>
>>> I guess this is because wxpython is missing on 14.04.
>>
>> No.
>> I am able to build Kicad with option -DKICAD_SCRIPTING_WXPYTHON=ON.
>> The issue is not related to wxpython.
>> I also have this issue when I use only the option -DKICAD_SCRIPTING=ON.
>> This issue exists *only* when option -std=c++11 or -std=gnu++11 is used.
> 
> It looks like swig is creating some code that C++11 doesn't like.  What
> version of swig are you using?  I'm using 3.0.6 on windows msys2 builds.

I have no problem on msys2 32bits.
Moreover, I believe gnu++11 is the default option on msys2.
The issue is only on Ubuntu.

I am also thinking to a swig issue.
On Ubuntu, swig is 2.0.11.


-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Chris Pavlina]

Are we sure this isn't the issue where cmake forgets to rebuild
pcbnewPYTHON_wrap.cxx? I've been having that issue about once every couple
weeks for a while, just delete it and rebuild :P

On Mon, Mar 21, 2016 at 08:13:48PM +0100, Nick Østergaard wrote:
> 2016-03-21 20:10 GMT+01:00 jp charras :
> > Le 21/03/2016 19:54, Nick Østergaard a écrit :
> >> 2016-03-21 19:52 GMT+01:00 jp charras :
> >>> Le 21/03/2016 16:13, Wayne Stambaugh a écrit :
>  Going, going, gone!  Since I haven't gotten any objections, I committed
>  the patch to enable C++11.  Thanks Simon for the patch but be prepared
>  for the grumbling. :)
> 
> >>>
> >>> On Ubuntu 14.04 LTS - 64 bits (with latest update) I have an issue when
> >>> compiling pcbnewPYTHON_wrap.cxx.
> >>
> >> I guess this is because wxpython is missing on 14.04.
> >
> > No.
> > I am able to build Kicad with option -DKICAD_SCRIPTING_WXPYTHON=ON.
> > The issue is not related to wxpython.
> > I also have this issue when I use only the option -DKICAD_SCRIPTING=ON.
> > This issue exists *only* when option -std=c++11 or -std=gnu++11 is used.
> 
> Lets just ignore this since 14.04 is end of life in august 2016 and
> use our effort on kicad moving forward.
> 
> >>
> >>> With no python support, Kicad itself compiles without any problem.
> >>> but with python support, I have the attached error.
> >>>
> >>> I am not especially motivated to fix it, and I do not have a lot of
> >>> experience about swig. Each test takes *a bunch of* time.
> >>>
> >>> If someone has an idea about a fix and can help, he is welcome!
> >>>
> >>> Despite of this issue, I am thinking using C++11 features is a good idea.
> >>>
> >>> --
> >>> Jean-Pierre CHARRAS
> >>>
> >>> ___
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to : kicad-developers@lists.launchpad.net
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
> >>>
> >>
> >
> >
> > --
> > Jean-Pierre CHARRAS
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Nick Østergaard]

2016-03-21 20:10 GMT+01:00 jp charras :
> Le 21/03/2016 19:54, Nick Østergaard a écrit :
>> 2016-03-21 19:52 GMT+01:00 jp charras :
>>> Le 21/03/2016 16:13, Wayne Stambaugh a écrit :
 Going, going, gone!  Since I haven't gotten any objections, I committed
 the patch to enable C++11.  Thanks Simon for the patch but be prepared
 for the grumbling. :)

>>>
>>> On Ubuntu 14.04 LTS - 64 bits (with latest update) I have an issue when
>>> compiling pcbnewPYTHON_wrap.cxx.
>>
>> I guess this is because wxpython is missing on 14.04.
>
> No.
> I am able to build Kicad with option -DKICAD_SCRIPTING_WXPYTHON=ON.
> The issue is not related to wxpython.
> I also have this issue when I use only the option -DKICAD_SCRIPTING=ON.
> This issue exists *only* when option -std=c++11 or -std=gnu++11 is used.

Lets just ignore this since 14.04 is end of life in august 2016 and
use our effort on kicad moving forward.

>>
>>> With no python support, Kicad itself compiles without any problem.
>>> but with python support, I have the attached error.
>>>
>>> I am not especially motivated to fix it, and I do not have a lot of
>>> experience about swig. Each test takes *a bunch of* time.
>>>
>>> If someone has an idea about a fix and can help, he is welcome!
>>>
>>> Despite of this issue, I am thinking using C++11 features is a good idea.
>>>
>>> --
>>> Jean-Pierre CHARRAS
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>
>
> --
> Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Wayne Stambaugh]

On 3/21/2016 3:10 PM, jp charras wrote:
> Le 21/03/2016 19:54, Nick Østergaard a écrit :
>> 2016-03-21 19:52 GMT+01:00 jp charras :
>>> Le 21/03/2016 16:13, Wayne Stambaugh a écrit :
 Going, going, gone!  Since I haven't gotten any objections, I committed
 the patch to enable C++11.  Thanks Simon for the patch but be prepared
 for the grumbling. :)

>>>
>>> On Ubuntu 14.04 LTS - 64 bits (with latest update) I have an issue when
>>> compiling pcbnewPYTHON_wrap.cxx.
>>
>> I guess this is because wxpython is missing on 14.04.
> 
> No.
> I am able to build Kicad with option -DKICAD_SCRIPTING_WXPYTHON=ON.
> The issue is not related to wxpython.
> I also have this issue when I use only the option -DKICAD_SCRIPTING=ON.
> This issue exists *only* when option -std=c++11 or -std=gnu++11 is used.

It looks like swig is creating some code that C++11 doesn't like.  What
version of swig are you using?  I'm using 3.0.6 on windows msys2 builds.

> 
>>
>>> With no python support, Kicad itself compiles without any problem.
>>> but with python support, I have the attached error.
>>>
>>> I am not especially motivated to fix it, and I do not have a lot of
>>> experience about swig. Each test takes *a bunch of* time.
>>>
>>> If someone has an idea about a fix and can help, he is welcome!
>>>
>>> Despite of this issue, I am thinking using C++11 features is a good idea.
>>>
>>> --
>>> Jean-Pierre CHARRAS
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
> 
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Nick Østergaard]

2016-03-21 19:54 GMT+01:00 Nick Østergaard :
> 2016-03-21 19:52 GMT+01:00 jp charras :
>> Le 21/03/2016 16:13, Wayne Stambaugh a écrit :
>>> Going, going, gone!  Since I haven't gotten any objections, I committed
>>> the patch to enable C++11.  Thanks Simon for the patch but be prepared
>>> for the grumbling. :)
>>>
>>
>> On Ubuntu 14.04 LTS - 64 bits (with latest update) I have an issue when
>> compiling pcbnewPYTHON_wrap.cxx.
>
> I guess this is because wxpython is missing on 14.04.
>
>> With no python support, Kicad itself compiles without any problem.
>> but with python support, I have the attached error.
>>
>> I am not especially motivated to fix it, and I do not have a lot of
>> experience about swig. Each test takes *a bunch of* time.
>>
>> If someone has an idea about a fix and can help, he is welcome!

You can probably use the PPA at
https://launchpad.net/~adamwolf/+archive/ubuntu/kicad-trusty-backports

>> Despite of this issue, I am thinking using C++11 features is a good idea.
>>
>> --
>> Jean-Pierre CHARRAS
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[jp charras]

Le 21/03/2016 19:54, Nick Østergaard a écrit :
> 2016-03-21 19:52 GMT+01:00 jp charras :
>> Le 21/03/2016 16:13, Wayne Stambaugh a écrit :
>>> Going, going, gone!  Since I haven't gotten any objections, I committed
>>> the patch to enable C++11.  Thanks Simon for the patch but be prepared
>>> for the grumbling. :)
>>>
>>
>> On Ubuntu 14.04 LTS - 64 bits (with latest update) I have an issue when
>> compiling pcbnewPYTHON_wrap.cxx.
> 
> I guess this is because wxpython is missing on 14.04.

No.
I am able to build Kicad with option -DKICAD_SCRIPTING_WXPYTHON=ON.
The issue is not related to wxpython.
I also have this issue when I use only the option -DKICAD_SCRIPTING=ON.
This issue exists *only* when option -std=c++11 or -std=gnu++11 is used.

> 
>> With no python support, Kicad itself compiles without any problem.
>> but with python support, I have the attached error.
>>
>> I am not especially motivated to fix it, and I do not have a lot of
>> experience about swig. Each test takes *a bunch of* time.
>>
>> If someone has an idea about a fix and can help, he is welcome!
>>
>> Despite of this issue, I am thinking using C++11 features is a good idea.
>>
>> --
>> Jean-Pierre CHARRAS
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 


-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[jp charras]

Le 21/03/2016 16:13, Wayne Stambaugh a écrit :
> Going, going, gone!  Since I haven't gotten any objections, I committed
> the patch to enable C++11.  Thanks Simon for the patch but be prepared
> for the grumbling. :)
> 

On Ubuntu 14.04 LTS - 64 bits (with latest update) I have an issue when
compiling pcbnewPYTHON_wrap.cxx.

With no python support, Kicad itself compiles without any problem.
but with python support, I have the attached error.

I am not especially motivated to fix it, and I do not have a lot of
experience about swig. Each test takes *a bunch of* time.

If someone has an idea about a fix and can help, he is welcome!

Despite of this issue, I am thinking using C++11 features is a good idea.

-- 
Jean-Pierre CHARRAS
Scanning dependencies of target pcbnew_kiface
/home/jpc/kicad-launchpad/testing/Build/Release_gtk2/pcbnew/scripting/pcbnewPYTHON_wrap.cxx:
 In function 'PyObject* _wrap_str_utf8_Map_erase__SWIG_2(PyObject*, PyObject*)':
/home/jpc/kicad-launchpad/testing/Build/Release_gtk2/pcbnew/scripting/pcbnewPYTHON_wrap.cxx:29887:26:
 error: no matching function for call to 'std::map, std::allocator > 
>::erase(SwigValueWrapper > >&, 
SwigValueWrapper > >&)'
   (arg1)->erase(arg2,arg3);
  ^
/home/jpc/kicad-launchpad/testing/Build/Release_gtk2/pcbnew/scripting/pcbnewPYTHON_wrap.cxx:29887:26:
 note: candidates are:
In file included from /usr/include/c++/4.8/map:61:0,
 from 
/home/jpc/kicad-launchpad/testing/Build/Release_gtk2/pcbnew/scripting/pcbnewPYTHON_wrap.cxx:4981:
/usr/include/c++/4.8/bits/stl_map.h:690:7: note: std::map<_Key, _Tp, _Compare, 
_Alloc>::iterator std::map<_Key, _Tp, _Compare, _Alloc>::erase(std::map<_Key, 
_Tp, _Compare, _Alloc>::const_iterator) [with _Key = std::basic_string; 
_Tp = UTF8; _Compare = std::less; _Alloc = 
std::allocator >; std::map<_Key, 
_Tp, _Compare, _Alloc>::iterator = std::_Rb_tree_iterator >; std::map<_Key, _Tp, _Compare, 
_Alloc>::const_iterator = std::_Rb_tree_const_iterator >]
   erase(const_iterator __position)
   ^
/usr/include/c++/4.8/bits/stl_map.h:690:7: note:   candidate expects 1 
argument, 2 provided
/usr/include/c++/4.8/bits/stl_map.h:696:7: note: std::map<_Key, _Tp, _Compare, 
_Alloc>::iterator std::map<_Key, _Tp, _Compare, _Alloc>::erase(std::map<_Key, 
_Tp, _Compare, _Alloc>::iterator) [with _Key = std::basic_string; _Tp = 
UTF8; _Compare = std::less; _Alloc = 
std::allocator >; std::map<_Key, 
_Tp, _Compare, _Alloc>::iterator = std::_Rb_tree_iterator >]
   erase(iterator __position)
   ^
/usr/include/c++/4.8/bits/stl_map.h:696:7: note:   candidate expects 1 
argument, 2 provided
/usr/include/c++/4.8/bits/stl_map.h:726:7: note: std::map<_Key, _Tp, _Compare, 
_Alloc>::size_type std::map<_Key, _Tp, _Compare, _Alloc>::erase(const 
key_type&) [with _Key = std::basic_string; _Tp = UTF8; _Compare = 
std::less; _Alloc = std::allocator >; std::map<_Key, _Tp, _Compare, 
_Alloc>::size_type = long unsigned int; std::map<_Key, _Tp, _Compare, 
_Alloc>::key_type = std::basic_string]
   erase(const key_type& __x)
   ^
/usr/include/c++/4.8/bits/stl_map.h:726:7: note:   candidate expects 1 
argument, 2 provided
/usr/include/c++/4.8/bits/stl_map.h:746:7: note: std::map<_Key, _Tp, _Compare, 
_Alloc>::iterator std::map<_Key, _Tp, _Compare, _Alloc>::erase(std::map<_Key, 
_Tp, _Compare, _Alloc>::const_iterator, std::map<_Key, _Tp, _Compare, 
_Alloc>::const_iterator) [with _Key = std::basic_string; _Tp = UTF8; 
_Compare = std::less; _Alloc = 
std::allocator >; std::map<_Key, 
_Tp, _Compare, _Alloc>::iterator = std::_Rb_tree_iterator >; std::map<_Key, _Tp, _Compare, 
_Alloc>::const_iterator = std::_Rb_tree_const_iterator >]
   erase(const_iterator __first, const_iterator __last)
   ^
/usr/include/c++/4.8/bits/stl_map.h:746:7: note:   no known conversion for 
argument 1 from 'SwigValueWrapper > >' to 'std::map, std::allocator > >::const_iterator {aka 
std::_Rb_tree_const_iterator >}'
Application: kicad
Version: (2016-03-21 BZR 6636)-product, release build
Libraries: wxWidgets 3.0.2
   libcurl/7.35.0 GnuTLS/2.12.23 zlib/1.2.8 libidn/1.28 librtmp/2.3
Platform: Linux 3.13.0-83-generic x86_64, 64 bit, Little endian, wxGTK
- Build Info -
wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8)
Boost: 1.54.0
Curl: 7.35.0
KiCad - Compiler: GCC 4.8.4 with C++ ABI 1002
Settings: USE_WX_GRAPHICS_CONTEXT=OFF
  USE_WX_OVERLAY=OFF
  

Re: [Kicad-developers] [PATCH] Enable C++11

[Wayne Stambaugh]

We should hold off on using any c++11 specific code for a while just in
case we have to remove this patch.  If we make it a month without having
to pull the patch, then we can start using c++11 stuff.

On 3/21/2016 11:27 AM, Chris Pavlina wrote:
> Someone should probably ask - apologies if someone already did: Do you have a
> policy in mind for using C++11 features in new patches? It may be prudent to
> let the patch settle for a few days just to make sure nobody else has build
> trouble before we start making it harder to back out.
> 
> On Mon, Mar 21, 2016 at 11:13:26AM -0400, Wayne Stambaugh wrote:
>> Going, going, gone!  Since I haven't gotten any objections, I committed
>> the patch to enable C++11.  Thanks Simon for the patch but be prepared
>> for the grumbling. :)
>>
>> On 3/18/2016 3:42 PM, Wayne Stambaugh wrote:
>>> I tested this on my Debian testing and it seemed fine.  It is 2016 after
>>> all so I guess it's time to jump into the C++11 waters if there are no
>>> objections.  I figure we'll be good to roll out C++14 in 2019 or 2020. :).
>>>
>>> On 3/18/2016 12:08 AM, Simon Richter wrote:
 Hi Wayne,

 On 17.03.2016 20:35, Wayne Stambaugh wrote:

> @Simon, when cmake is < 3.1 you set the -std-c++11 flag for gcc and
> clang instead of the -gnu-c++11.  This seems to be an issue that should
> be addressed.  Maybe this is what is breaking @Mark's builds.  I would
> feel more comfortable if we figure this out before I commit the patch.

 It works for me on Debian jessie, with cmake 3.0.2 and gcc 4.9.2, and on
 Ubunty trusty with cmake 2.8.12.2 and gcc 4.8.2.

 On Ubuntu trusty, wxPython 3.0 is not available as far as I can see, so
 that build was without scripting support.

Simon



 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp

>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Chris Pavlina]

Someone should probably ask - apologies if someone already did: Do you have a
policy in mind for using C++11 features in new patches? It may be prudent to
let the patch settle for a few days just to make sure nobody else has build
trouble before we start making it harder to back out.

On Mon, Mar 21, 2016 at 11:13:26AM -0400, Wayne Stambaugh wrote:
> Going, going, gone!  Since I haven't gotten any objections, I committed
> the patch to enable C++11.  Thanks Simon for the patch but be prepared
> for the grumbling. :)
> 
> On 3/18/2016 3:42 PM, Wayne Stambaugh wrote:
> > I tested this on my Debian testing and it seemed fine.  It is 2016 after
> > all so I guess it's time to jump into the C++11 waters if there are no
> > objections.  I figure we'll be good to roll out C++14 in 2019 or 2020. :).
> > 
> > On 3/18/2016 12:08 AM, Simon Richter wrote:
> >> Hi Wayne,
> >>
> >> On 17.03.2016 20:35, Wayne Stambaugh wrote:
> >>
> >>> @Simon, when cmake is < 3.1 you set the -std-c++11 flag for gcc and
> >>> clang instead of the -gnu-c++11.  This seems to be an issue that should
> >>> be addressed.  Maybe this is what is breaking @Mark's builds.  I would
> >>> feel more comfortable if we figure this out before I commit the patch.
> >>
> >> It works for me on Debian jessie, with cmake 3.0.2 and gcc 4.9.2, and on
> >> Ubunty trusty with cmake 2.8.12.2 and gcc 4.8.2.
> >>
> >> On Ubuntu trusty, wxPython 3.0 is not available as far as I can see, so
> >> that build was without scripting support.
> >>
> >>Simon
> >>
> >>
> >>
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to : kicad-developers@lists.launchpad.net
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> >>
> > 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Wayne Stambaugh]

Going, going, gone!  Since I haven't gotten any objections, I committed
the patch to enable C++11.  Thanks Simon for the patch but be prepared
for the grumbling. :)

On 3/18/2016 3:42 PM, Wayne Stambaugh wrote:
> I tested this on my Debian testing and it seemed fine.  It is 2016 after
> all so I guess it's time to jump into the C++11 waters if there are no
> objections.  I figure we'll be good to roll out C++14 in 2019 or 2020. :).
> 
> On 3/18/2016 12:08 AM, Simon Richter wrote:
>> Hi Wayne,
>>
>> On 17.03.2016 20:35, Wayne Stambaugh wrote:
>>
>>> @Simon, when cmake is < 3.1 you set the -std-c++11 flag for gcc and
>>> clang instead of the -gnu-c++11.  This seems to be an issue that should
>>> be addressed.  Maybe this is what is breaking @Mark's builds.  I would
>>> feel more comfortable if we figure this out before I commit the patch.
>>
>> It works for me on Debian jessie, with cmake 3.0.2 and gcc 4.9.2, and on
>> Ubunty trusty with cmake 2.8.12.2 and gcc 4.8.2.
>>
>> On Ubuntu trusty, wxPython 3.0 is not available as far as I can see, so
>> that build was without scripting support.
>>
>>Simon
>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Wayne Stambaugh]

I tested this on my Debian testing and it seemed fine.  It is 2016 after
all so I guess it's time to jump into the C++11 waters if there are no
objections.  I figure we'll be good to roll out C++14 in 2019 or 2020. :).

On 3/18/2016 12:08 AM, Simon Richter wrote:
> Hi Wayne,
> 
> On 17.03.2016 20:35, Wayne Stambaugh wrote:
> 
>> @Simon, when cmake is < 3.1 you set the -std-c++11 flag for gcc and
>> clang instead of the -gnu-c++11.  This seems to be an issue that should
>> be addressed.  Maybe this is what is breaking @Mark's builds.  I would
>> feel more comfortable if we figure this out before I commit the patch.
> 
> It works for me on Debian jessie, with cmake 3.0.2 and gcc 4.9.2, and on
> Ubunty trusty with cmake 2.8.12.2 and gcc 4.8.2.
> 
> On Ubuntu trusty, wxPython 3.0 is not available as far as I can see, so
> that build was without scripting support.
> 
>Simon
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Wayne Stambaugh]

I tested this patch on msys1/mingw32 (gcc 4.7.2), msys2/mingw32 (gcc
5.3.0), and msys2/mingw64 (gcc 5.3.0) and kicad compiles and runs
without any issues other than a few new compiler warnings.  I'm using
cmake 3.4.1 on all three platforms.

@Simon, when cmake is < 3.1 you set the -std-c++11 flag for gcc and
clang instead of the -gnu-c++11.  This seems to be an issue that should
be addressed.  Maybe this is what is breaking @Mark's builds.  I would
feel more comfortable if we figure this out before I commit the patch.

On 3/17/2016 7:45 AM, jp charras wrote:
> Le 17/03/2016 10:23, Nick Østergaard a écrit :
>> 2016-03-17 10:15 GMT+01:00 jp charras :
>>> Le 10/03/2016 08:30, Simon Richter a écrit :

 This enables C++11 support, if either CMake is sufficiently new to have
 this feature built in, or the compiler is supported by the workaround code
 (gcc or clang).
 ---
  CMakeLists.txt | 23 +++
  1 file changed, 23 insertions(+)
>>>
>>> After a few tests:
>>>
>>> I can compile Kicad on W7 32 bits + msys2 and Kubuntu 14.04 LTS with option
>>> -std=gnu++11
>>> and on W7 32 bits (on Kubuntu the compiler version is too old)
>>> -std=gnu++14
>>
>> Is that kubuntu machine updated?
> 
> Of course, yes.
> But it uses the gcc 4.9 version, which does not support gnu++14.
> 
>  Did it build with -std=c++11 on
>> kubuntu 14.04 LTS?
>>
>>>
>>> but on W7 32 bits the option
>>> -std=c++11
>>> does not work (compil errors)
>>
>> I think I tested Simon's original patch on msys2 on 64 and it seemed
>> to work. What errors do you see?
>>
>>>
>>> Therefore, with gcc:
>>> -std=gnu++11 is OK
>>> -std=c++11 is not acceptable
>>>
>>> (This is not the first time i have issues with option -std=c++11 or
>>> -std=c++14 and no issue with -std=gnu++11 or -std=gnu++14)
>>>
>>>
>>> --
>>> Jean-Pierre CHARRAS
> 
> After more tests:
> 
> - During my first test, I did not applied the patch. I just forced the
> option -std=c++11 when calling cmake.
> 
> I had some issues (like M_PI dot defined, although math.h was included,
> and more other issues)
> 
> - After your response, I applied the patch. and I was able to build Kicad.
> 
> - Because this is a bit strange, I had a look at this issue:
> Although there is in this patch the line:
> "set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")"
> when make is run the actual option (try make VERBOSE=1) is "-std=gnu++11"
> 
> So no more mystery, as I wrote:
> -std=gnu++11 works, -std=c++11 does not work.
> 
> I am saying "no more mystery", but this is not fully true:
> the option
> "set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")" becomes actually:
> "set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=gnu++11")"
> 
> And this change is a mystery, at least for me (but I have a poor
> knowledge of cmake).
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Eldar Khayrullin]

Hi.

To jp, look at cmake properties CXX_STANDARD, CXX_STANDARD_REQUIRED,
CXX_EXTENSIONS.

[https://cmake.org/cmake/help/v3.4/manual/cmake-properties.7.html](https://lin
k.nylas.com/link/ac7n0u7eu8cj6vjow9ajimqdr/4174df36c5bf4561b73f89e228f5d608/0?
redirect=https%3A%2F%2Fcmake.org%2Fcmake%2Fhelp%2Fv3.4%2Fmanual%2Fcmake-
properties.7.html)

But I don't know is that exist in old cmake version.

  
![](https://link.nylas.com/open/ac7n0u7eu8cj6vjow9ajimqdr/549b31b49a594b0f97f3
4c0d6c1308c1)

> On март 17 2016, at 2:46 дня, jp charras jp.char...@wanadoo.fr
wrote:  

>

> Le 17/03/2016 10:23, Nick Østergaard a écrit :  
 2016-03-17 10:15 GMT+01:00 jp charras jp.char...@wanadoo.fr:  
 Le 10/03/2016 08:30, Simon Richter a écrit :  
  
 This enables C++11 support, if either CMake is sufficiently new
to have  
 this feature built in, or the compiler is supported by the
workaround code  
 (gcc or clang).  
 \---  
 CMakeLists.txt | 23 +++  
 1 file changed, 23 insertions(+)  
  
 After a few tests:  
  
 I can compile Kicad on W7 32 bits + msys2 and Kubuntu 14.04 LTS with
option  
 -std=gnu++11  
 and on W7 32 bits (on Kubuntu the compiler version is too old)  
 -std=gnu++14  
  
 Is that kubuntu machine updated?

>

> Of course, yes.  
But it uses the gcc 4.9 version, which does not support gnu++14.

>

>  Did it build with -std=c++11 on  
 kubuntu 14.04 LTS?  
  
  
 but on W7 32 bits the option  
 -std=c++11  
 does not work (compil errors)  
  
 I think I tested Simon's original patch on msys2 on 64 and it seemed  
 to work. What errors do you see?  
  
  
 Therefore, with gcc:  
 -std=gnu++11 is OK  
 -std=c++11 is not acceptable  
  
 (This is not the first time i have issues with option -std=c++11 or  
 -std=c++14 and no issue with -std=gnu++11 or -std=gnu++14)  
  
  
 \--  
 Jean-Pierre CHARRAS

>

> After more tests:

>

> \- During my first test, I did not applied the patch. I just forced the  
option -std=c++11 when calling cmake.

>

> I had some issues (like M_PI dot defined, although math.h was included,  
and more other issues)

>

> \- After your response, I applied the patch. and I was able to build Kicad.

>

> \- Because this is a bit strange, I had a look at this issue:  
Although there is in this patch the line:  
"set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")"  
when make is run the actual option (try make VERBOSE=1) is "-std=gnu++11"

>

> So no more mystery, as I wrote:  
-std=gnu++11 works, -std=c++11 does not work.
>

> I am saying "no more mystery", but this is not fully true:  
the option  
"set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")" becomes actually:  
"set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=gnu++11")"

>

> And this change is a mystery, at least for me (but I have a poor  
knowledge of cmake).

>

> \--  
Jean-Pierre CHARRAS

>

> ___  
Mailing list: https://launchpad.net/~kicad-developers  
Post to : kicad-developers@lists.launchpad.net  
Unsubscribe : https://launchpad.net/~kicad-developers  
More help : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Simon Richter]

Hi Wayne,

On 17.03.2016 20:35, Wayne Stambaugh wrote:

> @Simon, when cmake is < 3.1 you set the -std-c++11 flag for gcc and
> clang instead of the -gnu-c++11.  This seems to be an issue that should
> be addressed.  Maybe this is what is breaking @Mark's builds.  I would
> feel more comfortable if we figure this out before I commit the patch.

It works for me on Debian jessie, with cmake 3.0.2 and gcc 4.9.2, and on
Ubunty trusty with cmake 2.8.12.2 and gcc 4.8.2.

On Ubuntu trusty, wxPython 3.0 is not available as far as I can see, so
that build was without scripting support.

   Simon



signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[jp charras]

Le 10/03/2016 08:30, Simon Richter a écrit :
> 
> This enables C++11 support, if either CMake is sufficiently new to have
> this feature built in, or the compiler is supported by the workaround code
> (gcc or clang).
> ---
>  CMakeLists.txt | 23 +++
>  1 file changed, 23 insertions(+)

After a few tests:

I can compile Kicad on W7 32 bits + msys2 and Kubuntu 14.04 LTS with option
-std=gnu++11
and on W7 32 bits (on Kubuntu the compiler version is too old)
-std=gnu++14

but on W7 32 bits the option
-std=c++11
does not work (compil errors)

Therefore, with gcc:
-std=gnu++11 is OK
-std=c++11 is not acceptable

(This is not the first time i have issues with option -std=c++11 or
-std=c++14 and no issue with -std=gnu++11 or -std=gnu++14)


-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Nick Østergaard]

2016-03-17 10:15 GMT+01:00 jp charras :
> Le 10/03/2016 08:30, Simon Richter a écrit :
>>
>> This enables C++11 support, if either CMake is sufficiently new to have
>> this feature built in, or the compiler is supported by the workaround code
>> (gcc or clang).
>> ---
>>  CMakeLists.txt | 23 +++
>>  1 file changed, 23 insertions(+)
>
> After a few tests:
>
> I can compile Kicad on W7 32 bits + msys2 and Kubuntu 14.04 LTS with option
> -std=gnu++11
> and on W7 32 bits (on Kubuntu the compiler version is too old)
> -std=gnu++14

Is that kubuntu machine updated? Did it build with -std=c++11 on
kubuntu 14.04 LTS?

>
> but on W7 32 bits the option
> -std=c++11
> does not work (compil errors)

I think I tested Simon's original patch on msys2 on 64 and it seemed
to work. What errors do you see?

>
> Therefore, with gcc:
> -std=gnu++11 is OK
> -std=c++11 is not acceptable
>
> (This is not the first time i have issues with option -std=c++11 or
> -std=c++14 and no issue with -std=gnu++11 or -std=gnu++14)
>
>
> --
> Jean-Pierre CHARRAS
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[jp charras]

Le 17/03/2016 10:23, Nick Østergaard a écrit :
> 2016-03-17 10:15 GMT+01:00 jp charras :
>> Le 10/03/2016 08:30, Simon Richter a écrit :
>>>
>>> This enables C++11 support, if either CMake is sufficiently new to have
>>> this feature built in, or the compiler is supported by the workaround code
>>> (gcc or clang).
>>> ---
>>>  CMakeLists.txt | 23 +++
>>>  1 file changed, 23 insertions(+)
>>
>> After a few tests:
>>
>> I can compile Kicad on W7 32 bits + msys2 and Kubuntu 14.04 LTS with option
>> -std=gnu++11
>> and on W7 32 bits (on Kubuntu the compiler version is too old)
>> -std=gnu++14
> 
> Is that kubuntu machine updated?

Of course, yes.
But it uses the gcc 4.9 version, which does not support gnu++14.

 Did it build with -std=c++11 on
> kubuntu 14.04 LTS?
> 
>>
>> but on W7 32 bits the option
>> -std=c++11
>> does not work (compil errors)
> 
> I think I tested Simon's original patch on msys2 on 64 and it seemed
> to work. What errors do you see?
> 
>>
>> Therefore, with gcc:
>> -std=gnu++11 is OK
>> -std=c++11 is not acceptable
>>
>> (This is not the first time i have issues with option -std=c++11 or
>> -std=c++14 and no issue with -std=gnu++11 or -std=gnu++14)
>>
>>
>> --
>> Jean-Pierre CHARRAS

After more tests:

- During my first test, I did not applied the patch. I just forced the
option -std=c++11 when calling cmake.

I had some issues (like M_PI dot defined, although math.h was included,
and more other issues)

- After your response, I applied the patch. and I was able to build Kicad.

- Because this is a bit strange, I had a look at this issue:
Although there is in this patch the line:
"set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")"
when make is run the actual option (try make VERBOSE=1) is "-std=gnu++11"

So no more mystery, as I wrote:
-std=gnu++11 works, -std=c++11 does not work.

I am saying "no more mystery", but this is not fully true:
the option
"set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")" becomes actually:
"set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=gnu++11")"

And this change is a mystery, at least for me (but I have a poor
knowledge of cmake).

-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Simon Richter]

Hi,

On 12.03.2016 18:04, Mark Roszko wrote:

> But o well, screw it, undoubtedly someone will get the issue
> eventually later but screw wasting time finding what it was.

Agreed. One thing we should look into though is actually getting Ubuntu
bug reports.

I know that there are several people experiencing crashes, with all
different kinds of Ubuntu releases, there are entries in the Ubuntu
crash tracker, and I can reproduce these crashes (weird interaction
between kiface startup calling wxUninitialize, some proxy object being
freed after a callback because the callback registration was the last
remaining reference, and Unity using a hacked theme pack that actually
cares about the proxy object) -- but I have never gotten any report from
anyone about this, and the only way I know was experiencing it myself.

   Simon




signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Mark Roszko]

They are VMs they spawn on the fly and apt-get from ubuntu upstream. I
literally have to tell it to apt-get gcc.

But o well, screw it, undoubtedly someone will get the issue
eventually later but screw wasting time finding what it was.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Nick Østergaard]

Maybe that VM was not up to date?
Den 12/03/2016 17.39 skrev "Mark Roszko" :

> The problems for me occurred when I made TravisCI build KiCadsigh
> probably some sort of difference I am forgeting but they use Ubuntu 14
> build VMs.
>
> On Fri, Mar 11, 2016 at 4:09 PM, Nick Østergaard 
> wrote:
> > I just tried to build on ubuntu 14.04 with the first patch from Simon
> > and it built without any problems. And that is with boost 1.54 and not
> > python scripting enabled. This was tested in a docker container.
> >
> > 2016-03-11 21:52 GMT+01:00 Wayne Stambaugh :
> >> I would prefer a solution to fix this before I commit the patch.
> >>
> >> On 3/11/2016 1:01 PM, Mark Roszko wrote:
> >>> The issue is with gcc 4.8 which has C++11 but funny #defines. Boost
> >>> 1.55 only adds flags that have to be enabled manually to work around
> it.
> >>> Ubuntu 14 has gcc4.8. Debian Jessie has gcc4.9.
> >>>
> >>> ___
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to : kicad-developers@lists.launchpad.net
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
> >>>
> >>
> >>
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to : kicad-developers@lists.launchpad.net
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
>
>
>
> --
> Mark
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Nick Østergaard]

I just tried to build on ubuntu 14.04 with the first patch from Simon
and it built without any problems. And that is with boost 1.54 and not
python scripting enabled. This was tested in a docker container.

2016-03-11 21:52 GMT+01:00 Wayne Stambaugh :
> I would prefer a solution to fix this before I commit the patch.
>
> On 3/11/2016 1:01 PM, Mark Roszko wrote:
>> The issue is with gcc 4.8 which has C++11 but funny #defines. Boost
>> 1.55 only adds flags that have to be enabled manually to work around it.
>> Ubuntu 14 has gcc4.8. Debian Jessie has gcc4.9.
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Wayne Stambaugh]

I would prefer a solution to fix this before I commit the patch.

On 3/11/2016 1:01 PM, Mark Roszko wrote:
> The issue is with gcc 4.8 which has C++11 but funny #defines. Boost
> 1.55 only adds flags that have to be enabled manually to work around it.
> Ubuntu 14 has gcc4.8. Debian Jessie has gcc4.9.
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Mark Roszko]

The issue is with gcc 4.8 which has C++11 but funny #defines. Boost
1.55 only adds flags that have to be enabled manually to work around it.
Ubuntu 14 has gcc4.8. Debian Jessie has gcc4.9.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Simon Richter]

Hi,

On 11.03.2016 17:48, Wayne Stambaugh wrote:

> It still sounds to me that boost needs to be bumped to 1.55 and possibly
> some definitions need to added to the build configuration for Boost to
> build properly.

Hm, compiling worked for me with Boost 1.55 on Debian with no further
changes.

   Simon



signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Wayne Stambaugh]

It still sounds to me that boost needs to be bumped to 1.55 and possibly
some definitions need to added to the build configuration for Boost to
build properly.  If someone can include those changes along with Simon's
original patch.  I'll give it go and commit it if I don't have any
issues.  If there is a big backlash, I can always roll it out.

On 3/10/2016 11:15 AM, Chris Pavlina wrote:
> It doesn't seem to me that enabling a config macro as well is really all that
> much.
> 
> Since we're still in the heavy development phase of the cycle, I personally
> think that this is the absolute _best_ time to do things like enabling C++11.
> We're not making any major releases now, so we have plenty of time to make
> tweaks if small things break, or back out the changes entirely if large things
> break.  It's really not a big deal, from my perspective. That's what this part
> of the devel cycle is _for_. :)
> 
> On Thu, Mar 10, 2016 at 10:56:32AM -0500, Wayne Stambaugh wrote:
>> This is why I have been reluctant to make C++11 the default.  There are
>> just too many legacy systems around where it would cause issues.  I'm OK
>> with bumping the boost version to 1.55 because I think the impact of
>> that would be minimal but if we have to do much more that that, we may
>> want to hold off until the rest of the world catches up.
>>
>> On 3/10/2016 9:40 AM, Mark Roszko wrote:
>>> boost 1.55 only adds the the flag you now have to set to workaround.
>>>
 Fixed in Git develop: I've added and documented two config macros:
 BOOST_MATH_USE_FLOAT128 and BOOST_MATH_DISABLE_FLOAT128 which explicitly 
 enable/disable this feature.
 Defining the latter macro should fix things for your use case.
>>>
>>>
>>> I think much much newer boost might fix it entirely but its also a
>>> older gcc issue as I don't believe I ran into it on my Windows setup
>>> which is way way more bleeding edge than Ubuntu.
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Chris Pavlina]

It doesn't seem to me that enabling a config macro as well is really all that
much.

Since we're still in the heavy development phase of the cycle, I personally
think that this is the absolute _best_ time to do things like enabling C++11.
We're not making any major releases now, so we have plenty of time to make
tweaks if small things break, or back out the changes entirely if large things
break.  It's really not a big deal, from my perspective. That's what this part
of the devel cycle is _for_. :)

On Thu, Mar 10, 2016 at 10:56:32AM -0500, Wayne Stambaugh wrote:
> This is why I have been reluctant to make C++11 the default.  There are
> just too many legacy systems around where it would cause issues.  I'm OK
> with bumping the boost version to 1.55 because I think the impact of
> that would be minimal but if we have to do much more that that, we may
> want to hold off until the rest of the world catches up.
> 
> On 3/10/2016 9:40 AM, Mark Roszko wrote:
> > boost 1.55 only adds the the flag you now have to set to workaround.
> > 
> >> Fixed in Git develop: I've added and documented two config macros:
> >> BOOST_MATH_USE_FLOAT128 and BOOST_MATH_DISABLE_FLOAT128 which explicitly 
> >> enable/disable this feature.
> >> Defining the latter macro should fix things for your use case.
> > 
> > 
> > I think much much newer boost might fix it entirely but its also a
> > older gcc issue as I don't believe I ran into it on my Windows setup
> > which is way way more bleeding edge than Ubuntu.
> > 
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> > 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Wayne Stambaugh]

This is why I have been reluctant to make C++11 the default.  There are
just too many legacy systems around where it would cause issues.  I'm OK
with bumping the boost version to 1.55 because I think the impact of
that would be minimal but if we have to do much more that that, we may
want to hold off until the rest of the world catches up.

On 3/10/2016 9:40 AM, Mark Roszko wrote:
> boost 1.55 only adds the the flag you now have to set to workaround.
> 
>> Fixed in Git develop: I've added and documented two config macros:
>> BOOST_MATH_USE_FLOAT128 and BOOST_MATH_DISABLE_FLOAT128 which explicitly 
>> enable/disable this feature.
>> Defining the latter macro should fix things for your use case.
> 
> 
> I think much much newer boost might fix it entirely but its also a
> older gcc issue as I don't believe I ran into it on my Windows setup
> which is way way more bleeding edge than Ubuntu.
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Nick Østergaard]

Well, I guess it the patch is modified to use gnu++11 for gcc it
should be fine then.

2016-03-10 15:40 GMT+01:00 Mark Roszko :
> boost 1.55 only adds the the flag you now have to set to workaround.
>
>>Fixed in Git develop: I've added and documented two config macros:
>> BOOST_MATH_USE_FLOAT128 and BOOST_MATH_DISABLE_FLOAT128 which explicitly 
>> enable/disable this feature.
>> Defining the latter macro should fix things for your use case.
>
>
> I think much much newer boost might fix it entirely but its also a
> older gcc issue as I don't believe I ran into it on my Windows setup
> which is way way more bleeding edge than Ubuntu.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Mark Roszko]

boost 1.55 only adds the the flag you now have to set to workaround.

>Fixed in Git develop: I've added and documented two config macros:
> BOOST_MATH_USE_FLOAT128 and BOOST_MATH_DISABLE_FLOAT128 which explicitly 
> enable/disable this feature.
> Defining the latter macro should fix things for your use case.


I think much much newer boost might fix it entirely but its also a
older gcc issue as I don't believe I ran into it on my Windows setup
which is way way more bleeding edge than Ubuntu.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Enable C++11

[Nick Østergaard]

What about bumping the boost version requirement to 1.55?

Debain stable jessie has 1.55 [1] and it seems that ubuntu 14.04
trusty also has 1.55 [2].

Given that the issue is only with boost 1.54.

[1] 
https://packages.debian.org/search?keywords=libboost=names=stable=all
[2] 
http://packages.ubuntu.com/search?keywords=libboost=names=trusty=all

2016-03-10 15:11 GMT+01:00 Mark Roszko :
> Just setting C++11 will break some builds on some setups thanks to
> boost and GCC (making its own decision on 128-bit float support)
>
> See:
> https://svn.boost.org/trac/boost/ticket/9240
>
> The workaround is to start defining boost flags or define gnu++11 for gcc
>
> Ubuntu 14 is affected by that.
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp