Re: [Kicad-developers] [PATCH] Rework OpenSSL mutex workaround

[Wayne Stambaugh]

Hey Simon,

I cannot apply your patch against the tip of the product branch.  No
hurry but when you get a chance please revise your patch against the tip
of the product branch. I would like to test it to see how much of a
performance hit there is on windows.  I suspect it will be unacceptably
slow.  I seem to remember doing some testing with the multi-threaded
footprint loading disabled and the performance hit was just too severe
to be usable.

I just checked and unfortunately msys/mingw builds libcurl with openssl
instead of gnutls by default.  There is an option to build libcurl with
gnutls in the PKGBUILD file and there is gnutls package.  I did manage
to successfully build the curl packages (i686 and x86_64) against gnutls
without any issues (except skipping the gpg check of the curl archive).
However, KiCad does not build against curl built with gnutls so I'm not
sure what needs to be changes to make this build.  If someone else has
time to look at this, I would appreciate it.  As it stands right now, we
will have to build kicad with the openssl build of curl on windows.

Thanks,

Wayne

On 5/5/2016 5:56 PM, Simon Richter wrote:
> Hi Wayne,
> 
> On 05.05.2016 22:51, Wayne Stambaugh wrote:
> 
>> Is this patch for the stable branch, the product branch, or both?
> 
> Currently, for the product branch, and ideally it should be trivial to
> backport to the stable branch afterwards (it removes a lot of code that
> doesn't exist in the stable branch).
> 
> I'd probably wait pushing the avhttp -> curl changes to the stable
> branch until this has gotten sufficient eyeballs so we can introduce it
> without a regression on old Macs.
> 
>Simon
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Rework OpenSSL mutex workaround

[Simon Richter]

Hi Wayne,

On 05.05.2016 22:51, Wayne Stambaugh wrote:

> Is this patch for the stable branch, the product branch, or both?

Currently, for the product branch, and ideally it should be trivial to
backport to the stable branch afterwards (it removes a lot of code that
doesn't exist in the stable branch).

I'd probably wait pushing the avhttp -> curl changes to the stable
branch until this has gotten sufficient eyeballs so we can introduce it
without a regression on old Macs.

   Simon



signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Rework OpenSSL mutex workaround

[Wayne Stambaugh]

Is this patch for the stable branch, the product branch, or both?

On 5/5/2016 3:25 PM, Simon Richter wrote:
> 
> This allows compiling KiCad without OpenSSL. If CURL uses OpenSSL in the
> background, we serialize requests to avoid a bug there, which degrades
> performance. Given that no one should link KiCad against OpenSSL really
> because of licence conflicts, this is not so bad.
> ---
>  common/CMakeLists.txt |   5 --
>  common/kicad_curl/kicad_curl.cpp  | 161 
> --
>  common/kicad_curl/kicad_curl_easy.cpp |  23 +++--
>  include/kicad_curl/kicad_curl.h   |  17 
>  include/kicad_curl/kicad_curl_easy.h  |   5 ++
>  5 files changed, 22 insertions(+), 189 deletions(-)
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp