Re: [Kicad-developers] [PATCH] Schematic Cleanup: Split lines at junctions

[Thor-Arne]

Then I think that the delete wire needs to be fixed before splitting the 
wires at junctions.
I use the delete wire a lot, and I hate seeing it gone. But I'd like to se a 
delete that deletes wverything on the same wire.


-Original Message- 
From: Simon Richter

Sent: Friday, May 20, 2016 3:00 AM
To: kicad-developers@lists.launchpad.net
Subject: Re: [Kicad-developers] [PATCH] Schematic Cleanup: Split lines at 
junctions


Hi,

On 20.05.2016 00:25, Thor-Arne wrote:


Delete wire is on the delete button. and delete segment is on the
backspace key.


Ah, that makes (some) sense. To me, the behaviour of the delete key
looks fairly nonsensical, because it will stop at corners, but not at
junctions, while I'd expect "delete wire" to do the opposite.

This leaves me with a difficult problem though -- I need net ties to
actually generate different nets on both sides, so I need different
wires that aren't combined in order to get different netlist items, but
this makes the delete key behave differently for net ties.


Please do NOT change the behavior of the delete buton, it is used all
the time.


Hm, as said I don't find it that useful, because most of the time it
deletes a connection I still need, but leaves dangling segments. Would
it make sense to replace it with a "delete connection" functionality
that would never leave dangling ends?

This still means I'm going to redo this patch stack -- the structural
changes in the cleanup function still make sense IMO, but the logic is
obviously wrong then.

  Simon


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp 



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Schematic Cleanup: Split lines at junctions

[José Ignacio]

The current behavior is fairly annoying, you can't really know
beforehand how much the command is gonna delete, since collinear wires
are not always merged (only when drawing more traces, not when
dragging points), so sometimes it might delete just a single little
chunk of the line, or the whole thing. I guess you could say it makes
working with eeschema more exciting ;).

On Thu, May 19, 2016 at 8:00 PM, Simon Richter  wrote:
> Hi,
>
> On 20.05.2016 00:25, Thor-Arne wrote:
>
>> Delete wire is on the delete button. and delete segment is on the
>> backspace key.
>
> Ah, that makes (some) sense. To me, the behaviour of the delete key
> looks fairly nonsensical, because it will stop at corners, but not at
> junctions, while I'd expect "delete wire" to do the opposite.
>
> This leaves me with a difficult problem though -- I need net ties to
> actually generate different nets on both sides, so I need different
> wires that aren't combined in order to get different netlist items, but
> this makes the delete key behave differently for net ties.
>
>> Please do NOT change the behavior of the delete buton, it is used all
>> the time.
>
> Hm, as said I don't find it that useful, because most of the time it
> deletes a connection I still need, but leaves dangling segments. Would
> it make sense to replace it with a "delete connection" functionality
> that would never leave dangling ends?
>
> This still means I'm going to redo this patch stack -- the structural
> changes in the cleanup function still make sense IMO, but the logic is
> obviously wrong then.
>
>Simon
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Schematic Cleanup: Split lines at junctions

[Simon Richter]

Hi,

On 20.05.2016 00:25, Thor-Arne wrote:

> Delete wire is on the delete button. and delete segment is on the
> backspace key.

Ah, that makes (some) sense. To me, the behaviour of the delete key
looks fairly nonsensical, because it will stop at corners, but not at
junctions, while I'd expect "delete wire" to do the opposite.

This leaves me with a difficult problem though -- I need net ties to
actually generate different nets on both sides, so I need different
wires that aren't combined in order to get different netlist items, but
this makes the delete key behave differently for net ties.

> Please do NOT change the behavior of the delete buton, it is used all
> the time.

Hm, as said I don't find it that useful, because most of the time it
deletes a connection I still need, but leaves dangling segments. Would
it make sense to replace it with a "delete connection" functionality
that would never leave dangling ends?

This still means I'm going to redo this patch stack -- the structural
changes in the cleanup function still make sense IMO, but the logic is
obviously wrong then.

   Simon




signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Schematic Cleanup: Split lines at junctions

[Duane Johnson]

I use fn-delete, but regular delete does nothing. So is it that "backspace"
works on Mac, but delete does not?
On May 19, 2016 6:22 PM, "Simon Wells" <swel...@gmail.com> wrote:

> fn-delete
>
> On Fri, May 20, 2016 at 10:47 AM, Thor-Arne <l...@thor-arne.net> wrote:
> > It should be listed on the hot-key list.
> > Perhaps some other key is used.
> >
> > From: Duane Johnson
> > Sent: Friday, May 20, 2016 12:36 AM
> > To: Thor-Arne
> > Subject: Re: [Kicad-developers] [PATCH] Schematic Cleanup: Split lines at
> > junctions
> >
> >
> > I didn't know about this behavior. On the Mac, there is no backspace key.
> >
> > On May 19, 2016 4:25 PM, "Thor-Arne" <l...@thor-arne.net> wrote:
> >>
> >> This delete-wire behavior has been available in KiCad for as long as
> I've
> >> been using it, which is some time before the 2013-stable release.
> >>
> >> Delete wire is on the delete button. and delete segment is on the
> >> backspace key.
> >>
> >> Please do NOT change the behavior of the delete buton, it is used all
> the
> >> time.
> >>
> >> -----Original Message- From: Chris Pavlina
> >> Sent: Friday, May 20, 2016 12:10 AM
> >> To: Simon Richter
> >> Cc: kicad-developers@lists.launchpad.net
> >> Subject: Re: [Kicad-developers] [PATCH] Schematic Cleanup: Split lines
> at
> >> junctions
> >>
> >> I like the behavior of this patch, it seems a lot closer to how I'd
> expect
> >> deleting wires to work. :)
> >>
> >> On Thu, May 19, 2016 at 08:49:09PM +0200, Simon Richter wrote:
> >>>
> >>> Hi jp,
> >>>
> >>> On 19.05.2016 19:44, jp charras wrote:
> >>>
> >>> > It could be worth to *clearly* explain in your patches what bug you
> >>> > want > to fix, or what enhancement
> >>> > you are adding.
> >>>
> >>> Good point.
> >>>
> >>> The last batch has two goals:
> >>>
> >>> 1. fix a long-standing annoyance that deleting a line segment will
> >>> delete the entire length of wire, even when I want to delete only a
> >>> short piece. http://psi5.com/~geier/wires.ogv shows what I mean.
> >>>
> >>> 2. prepare for net ties -- these need to split nets, so having code in
> >>> place to split wires at certain points will have nice synergy effects.
> >>>
> >>> For the most part, I've been posting these as a heads-up and RFC; if
> the
> >>> benefit is obvious, it's fine to apply them, but I'm not unhappy if
> they
> >>> aren't applied immediately, because I'm more interested in things that
> >>> are obviously wrong or that I've overlooked, and my patch stack is
> >>> rebased on top of the current state every time I update anyway.
> >>>
> >>> "Serious" patch submissions start with a [PATCH 00/nn] mail that
> doesn't
> >>> contain a patch and explains the rationale fully, and have longer
> >>> descriptions in each separate patch (and incidentally, it'd be nice to
> >>> keep those somehow).
> >>>
> >>>Simon
> >>>
> >>
> >>
> >>
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to : kicad-developers@lists.launchpad.net
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> >>
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to : kicad-developers@lists.launchpad.net
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Schematic Cleanup: Split lines at junctions

[Simon Wells]

fn-delete

On Fri, May 20, 2016 at 10:47 AM, Thor-Arne <l...@thor-arne.net> wrote:
> It should be listed on the hot-key list.
> Perhaps some other key is used.
>
> From: Duane Johnson
> Sent: Friday, May 20, 2016 12:36 AM
> To: Thor-Arne
> Subject: Re: [Kicad-developers] [PATCH] Schematic Cleanup: Split lines at
> junctions
>
>
> I didn't know about this behavior. On the Mac, there is no backspace key.
>
> On May 19, 2016 4:25 PM, "Thor-Arne" <l...@thor-arne.net> wrote:
>>
>> This delete-wire behavior has been available in KiCad for as long as I've
>> been using it, which is some time before the 2013-stable release.
>>
>> Delete wire is on the delete button. and delete segment is on the
>> backspace key.
>>
>> Please do NOT change the behavior of the delete buton, it is used all the
>> time.
>>
>> -Original Message- From: Chris Pavlina
>> Sent: Friday, May 20, 2016 12:10 AM
>> To: Simon Richter
>> Cc: kicad-developers@lists.launchpad.net
>> Subject: Re: [Kicad-developers] [PATCH] Schematic Cleanup: Split lines at
>> junctions
>>
>> I like the behavior of this patch, it seems a lot closer to how I'd expect
>> deleting wires to work. :)
>>
>> On Thu, May 19, 2016 at 08:49:09PM +0200, Simon Richter wrote:
>>>
>>> Hi jp,
>>>
>>> On 19.05.2016 19:44, jp charras wrote:
>>>
>>> > It could be worth to *clearly* explain in your patches what bug you
>>> > want > to fix, or what enhancement
>>> > you are adding.
>>>
>>> Good point.
>>>
>>> The last batch has two goals:
>>>
>>> 1. fix a long-standing annoyance that deleting a line segment will
>>> delete the entire length of wire, even when I want to delete only a
>>> short piece. http://psi5.com/~geier/wires.ogv shows what I mean.
>>>
>>> 2. prepare for net ties -- these need to split nets, so having code in
>>> place to split wires at certain points will have nice synergy effects.
>>>
>>> For the most part, I've been posting these as a heads-up and RFC; if the
>>> benefit is obvious, it's fine to apply them, but I'm not unhappy if they
>>> aren't applied immediately, because I'm more interested in things that
>>> are obviously wrong or that I've overlooked, and my patch stack is
>>> rebased on top of the current state every time I update anyway.
>>>
>>> "Serious" patch submissions start with a [PATCH 00/nn] mail that doesn't
>>> contain a patch and explains the rationale fully, and have longer
>>> descriptions in each separate patch (and incidentally, it'd be nice to
>>> keep those somehow).
>>>
>>>Simon
>>>
>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Schematic Cleanup: Split lines at junctions

[Thor-Arne]

It should be listed on the hot-key list.
Perhaps some other key is used.

From: Duane Johnson 
Sent: Friday, May 20, 2016 12:36 AM
To: Thor-Arne 
Subject: Re: [Kicad-developers] [PATCH] Schematic Cleanup: Split lines at 
junctions

I didn't know about this behavior. On the Mac, there is no backspace key.

On May 19, 2016 4:25 PM, "Thor-Arne" <l...@thor-arne.net> wrote:

  This delete-wire behavior has been available in KiCad for as long as I've 
been using it, which is some time before the 2013-stable release.

  Delete wire is on the delete button. and delete segment is on the backspace 
key.

  Please do NOT change the behavior of the delete buton, it is used all the 
time.

  -Original Message- From: Chris Pavlina
  Sent: Friday, May 20, 2016 12:10 AM
  To: Simon Richter
  Cc: kicad-developers@lists.launchpad.net
  Subject: Re: [Kicad-developers] [PATCH] Schematic Cleanup: Split lines at 
junctions

  I like the behavior of this patch, it seems a lot closer to how I'd expect
  deleting wires to work. :)

  On Thu, May 19, 2016 at 08:49:09PM +0200, Simon Richter wrote:

Hi jp,

On 19.05.2016 19:44, jp charras wrote:

> It could be worth to *clearly* explain in your patches what bug you want 
> to fix, or what enhancement
> you are adding.

Good point.

The last batch has two goals:

1. fix a long-standing annoyance that deleting a line segment will
delete the entire length of wire, even when I want to delete only a
short piece. http://psi5.com/~geier/wires.ogv shows what I mean.

2. prepare for net ties -- these need to split nets, so having code in
place to split wires at certain points will have nice synergy effects.

For the most part, I've been posting these as a heads-up and RFC; if the
benefit is obvious, it's fine to apply them, but I'm not unhappy if they
aren't applied immediately, because I'm more interested in things that
are obviously wrong or that I've overlooked, and my patch stack is
rebased on top of the current state every time I update anyway.

"Serious" patch submissions start with a [PATCH 00/nn] mail that doesn't
contain a patch and explains the rationale fully, and have longer
descriptions in each separate patch (and incidentally, it'd be nice to
keep those somehow).

   Simon





  ___
  Mailing list: https://launchpad.net/~kicad-developers
  Post to : kicad-developers@lists.launchpad.net
  Unsubscribe : https://launchpad.net/~kicad-developers
  More help   : https://help.launchpad.net/ListHelp 

  ___
  Mailing list: https://launchpad.net/~kicad-developers
  Post to : kicad-developers@lists.launchpad.net
  Unsubscribe : https://launchpad.net/~kicad-developers
  More help   : https://help.launchpad.net/ListHelp
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Schematic Cleanup: Split lines at junctions

[Thor-Arne]

This delete-wire behavior has been available in KiCad for as long as I've 
been using it, which is some time before the 2013-stable release.


Delete wire is on the delete button. and delete segment is on the backspace 
key.


Please do NOT change the behavior of the delete buton, it is used all the 
time.


-Original Message- 
From: Chris Pavlina

Sent: Friday, May 20, 2016 12:10 AM
To: Simon Richter
Cc: kicad-developers@lists.launchpad.net
Subject: Re: [Kicad-developers] [PATCH] Schematic Cleanup: Split lines at 
junctions


I like the behavior of this patch, it seems a lot closer to how I'd expect
deleting wires to work. :)

On Thu, May 19, 2016 at 08:49:09PM +0200, Simon Richter wrote:

Hi jp,

On 19.05.2016 19:44, jp charras wrote:

> It could be worth to *clearly* explain in your patches what bug you want 
> to fix, or what enhancement

> you are adding.

Good point.

The last batch has two goals:

1. fix a long-standing annoyance that deleting a line segment will
delete the entire length of wire, even when I want to delete only a
short piece. http://psi5.com/~geier/wires.ogv shows what I mean.

2. prepare for net ties -- these need to split nets, so having code in
place to split wires at certain points will have nice synergy effects.

For the most part, I've been posting these as a heads-up and RFC; if the
benefit is obvious, it's fine to apply them, but I'm not unhappy if they
aren't applied immediately, because I'm more interested in things that
are obviously wrong or that I've overlooked, and my patch stack is
rebased on top of the current state every time I update anyway.

"Serious" patch submissions start with a [PATCH 00/nn] mail that doesn't
contain a patch and explains the rationale fully, and have longer
descriptions in each separate patch (and incidentally, it'd be nice to
keep those somehow).

   Simon





___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp 



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Schematic Cleanup: Split lines at junctions

[Chris Pavlina]

I like the behavior of this patch, it seems a lot closer to how I'd expect
deleting wires to work. :)

On Thu, May 19, 2016 at 08:49:09PM +0200, Simon Richter wrote:
> Hi jp,
> 
> On 19.05.2016 19:44, jp charras wrote:
> 
> > It could be worth to *clearly* explain in your patches what bug you want to 
> > fix, or what enhancement
> > you are adding.
> 
> Good point.
> 
> The last batch has two goals:
> 
> 1. fix a long-standing annoyance that deleting a line segment will
> delete the entire length of wire, even when I want to delete only a
> short piece. http://psi5.com/~geier/wires.ogv shows what I mean.
> 
> 2. prepare for net ties -- these need to split nets, so having code in
> place to split wires at certain points will have nice synergy effects.
> 
> For the most part, I've been posting these as a heads-up and RFC; if the
> benefit is obvious, it's fine to apply them, but I'm not unhappy if they
> aren't applied immediately, because I'm more interested in things that
> are obviously wrong or that I've overlooked, and my patch stack is
> rebased on top of the current state every time I update anyway.
> 
> "Serious" patch submissions start with a [PATCH 00/nn] mail that doesn't
> contain a patch and explains the rationale fully, and have longer
> descriptions in each separate patch (and incidentally, it'd be nice to
> keep those somehow).
> 
>Simon
> 



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Schematic Cleanup: Split lines at junctions

[Simon Richter]

Hi jp,

On 19.05.2016 19:44, jp charras wrote:

> It could be worth to *clearly* explain in your patches what bug you want to 
> fix, or what enhancement
> you are adding.

Good point.

The last batch has two goals:

1. fix a long-standing annoyance that deleting a line segment will
delete the entire length of wire, even when I want to delete only a
short piece. http://psi5.com/~geier/wires.ogv shows what I mean.

2. prepare for net ties -- these need to split nets, so having code in
place to split wires at certain points will have nice synergy effects.

For the most part, I've been posting these as a heads-up and RFC; if the
benefit is obvious, it's fine to apply them, but I'm not unhappy if they
aren't applied immediately, because I'm more interested in things that
are obviously wrong or that I've overlooked, and my patch stack is
rebased on top of the current state every time I update anyway.

"Serious" patch submissions start with a [PATCH 00/nn] mail that doesn't
contain a patch and explains the rationale fully, and have longer
descriptions in each separate patch (and incidentally, it'd be nice to
keep those somehow).

   Simon



signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Schematic Cleanup: Split lines at junctions

[jp charras]

Le 19/05/2016 à 18:03, Simon Richter a écrit :
> ---
>  eeschema/bus-wire-junction.cpp |  3 +++
>  eeschema/sch_screen.cpp| 18 ++
>  2 files changed, 21 insertions(+)

Simon,

It could be worth to *clearly* explain in your patches what bug you want to 
fix, or what enhancement
you are adding.

Currently, I am unable to understand the justification or the interest of more 
than 50% of the
patches you are submitting.
4 or 5 words in a title is certainly no enough: a *clear and detailed 
explanation* is needed.
Otherwise, your patches will be just ignored and not even read.

Thanks.

-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp