subject:"Re\: \[Kicad\-developers\] \[PATCH\] mousewheelpan \+ ctrl = zooming"

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2017-01-23 Thread Константин Барановский

Hi Brano and Orson!

Code of the zooming was not modified in this patch. But I noticed, that
there is present MAC-specific block:

common/view/wx_view_controls.cpp (+147):
>
> #ifdef __WXMAC__
> // The following is to support Apple pointer devices (MagicMouse &
> // Macbook touchpad), which send events more frequently, but with
> smaller
> // wheel rotation.
> //
> // It should not break other platforms, but I prefer to be safe
> than
> // sorry. If you find a device that behaves in the same way on
> another
> // platform, feel free to remove #ifdef directives.
> if( timeDiff > 0 && timeDiff < 100 && std::abs( rotation ) < 20 )
> {
> aEvent.Skip();
> return;
> }
> #endif
>

Maybe is problem in it?

--
Regards, Konstantin.

2017-01-23 11:38 GMT+02:00 Brano Panak :

> Hi Orson,
>
> this occurs when touchpad panning enabled. When TP panning disabled wheel
> works ok (withou need to push ctrl).
>
> When TP panning enabled it zoom in work ok. When zooming out it look to me
> that sw zooms out and immediately zooms in again.
>
> I am using wireless apple mouse which has  both (vertical and horizontal)
> "wheels".
>
> When trying to zoom in/out with ctrl+ horizontal "wheel" all works ok.
>
> If i remember correctly this was working ok, befor latest "wheel" patch.
>
> regards
>
> Brano
>
> On 20/01/17 08:52, Maciej Sumiński wrote:
>
> Hi Brano,
>
> Are the problems occurring when touchpad panning is enabled? Is
> everything fine once you disable it?
>
> Would you give more details about zoom out being problematic? Does it
> zoom out too quickly, is it choppy?
>
> Regards,
> Orson
>
> On 01/19/2017 10:52 PM, Brano Panak wrote:
>
> Today i checked behavior on osx with version: (2017-01-18 revision
> 2eb840b)-master
> and behavior in pcbnew during zooming with wheel+ctrl(cmd on mac) on
> apple mouse  is very erratic.
>
> Zoom in works ok, zoom out is very problematic.
>
> Eeschema looks ok, pcbnew with zooming and scrolling on touchpad with 2
> fingers looks good.
>
> regards
>
> Brano
>
>
> On 17/01/17 18:17, Константин Барановский wrote:
>
> In attachment placed new patch, that contains both previous patches
> and in mousewheelpan mode, with pressed Shift key, does horizontal
> scrolling.
>
> So, in common, we will get:
>
> * mousewheelpan disabled:
> - mousewheel = zooming;
> - mousewheel + ctrl = horizontal scrolling;
> - mousewheel + shift = vertical scrolling;
>
> * mousewheelpan enabled:
> - touchpad two finger scrolling = pan;
> - mousewheel = vertical scrolling;
> -> mousewheel (touchpad two finger scrolling) + ctrl = zooming;
> -> mousewheel (touchpad two finger scrolling)  + shift = horizontal
> scrolling.
>
> This patch adds two last options and decreases the pan step in
> 3d-viewer to be more comfortable.
> It works in eeschema, pcbnew (legacy, openGL, cairo), 3d-viewer,
> gerbview.
>
> 2017-01-17 11:27 GMT+02:00 Maciej Sumiński 
>  
> >:
>
> Hi Konstantin,
>
> Your patches were not ignored, the problem was neither me nor Wayne
> could fully apply the patches in their original version. Thank you
> for
> correcting this.
>
> I still hold my previous remark about wheel scroll and shift+wheel
> scroll doing the same thing when touchpad panning is enabled.
> Instead,
> shift+wheel scroll could perform horizontal scrolling in touchpad
> panning mode.
>
> Regards,
> Orson
>
> On 01/16/2017 07:38 PM, Константин Барановский wrote:
> > Thank you, Wayne, for your response. I'm attached the checked
> patches.
> >
> > 2017-01-16 20:07 GMT+02:00 Wayne Stambaugh   >:
> >
> >> You are not being ignored.  I can't speak for all of the lead
> developers
> >> but I've been really busy so pretty much everyone has been getting
> >> ignored by me.  It's not intentional, it's just the reality of my
> >> current work load.
> >>
> >> Patch is giving me an unexpected eof with
> 3d_viewer-pan_step.patch.
> >>
> >> Did you address Bernhard's concern about the behavior of the GAL
> >> canvases as well as the legacy canvas?  I don't remember seeing
> anything
> >> but I may have missed it.
> >>
> >> On 1/16/2017 11:29 AM, Константин Барановский wrote:
> >>> Hello. I'm sorry for disturbing you, but I'm not understand
> why my
> >>> messages are ignored. Proposed feature not needed for no one,
> except me?
> >>> Or I'm made something wrong? Please, give any comment.
> >>>
> >>> 2017-01-06 12:03 GMT+02:00 Константин Барановский
> >>>   
>

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2017-01-23 Thread Brano Panak

Hi Orson,

this occurs when touchpad panning enabled. When TP panning disabled 
wheel works ok (withou need to push ctrl).

When TP panning enabled it zoom in work ok. When zooming out it look to 
me that sw zooms out and immediately zooms in again.

I am using wireless apple mouse which has  both (vertical and 
horizontal) "wheels".

When trying to zoom in/out with ctrl+ horizontal "wheel" all works ok.

If i remember correctly this was working ok, befor latest "wheel" patch.

regards

Brano

On 20/01/17 08:52, Maciej Sumiński wrote:

Hi Brano,

Are the problems occurring when touchpad panning is enabled? Is
everything fine once you disable it?

Would you give more details about zoom out being problematic? Does it
zoom out too quickly, is it choppy?

Regards,
Orson

On 01/19/2017 10:52 PM, Brano Panak wrote:

Today i checked behavior on osx with version: (2017-01-18 revision
2eb840b)-master
and behavior in pcbnew during zooming with wheel+ctrl(cmd on mac) on
apple mouse  is very erratic.

Zoom in works ok, zoom out is very problematic.

Eeschema looks ok, pcbnew with zooming and scrolling on touchpad with 2
fingers looks good.

regards

Brano

On 17/01/17 18:17, Константин Барановский wrote:

In attachment placed new patch, that contains both previous patches
and in mousewheelpan mode, with pressed Shift key, does horizontal
scrolling.

So, in common, we will get:

* mousewheelpan disabled:
- mousewheel = zooming;
- mousewheel + ctrl = horizontal scrolling;
- mousewheel + shift = vertical scrolling;

* mousewheelpan enabled:
- touchpad two finger scrolling = pan;
- mousewheel = vertical scrolling;
-> mousewheel (touchpad two finger scrolling) + ctrl = zooming;
-> mousewheel (touchpad two finger scrolling)  + shift = horizontal
scrolling.

This patch adds two last options and decreases the pan step in
3d-viewer to be more comfortable.
It works in eeschema, pcbnew (legacy, openGL, cairo), 3d-viewer,
gerbview.

2017-01-17 11:27 GMT+02:00 Maciej Sumiński >:

 Hi Konstantin,

 Your patches were not ignored, the problem was neither me nor Wayne
 could fully apply the patches in their original version. Thank you
for
 correcting this.

 I still hold my previous remark about wheel scroll and shift+wheel
 scroll doing the same thing when touchpad panning is enabled.
Instead,
 shift+wheel scroll could perform horizontal scrolling in touchpad
 panning mode.

 Regards,
 Orson

 On 01/16/2017 07:38 PM, Константин Барановский wrote:
 > Thank you, Wayne, for your response. I'm attached the checked
 patches.
 >
 > 2017-01-16 20:07 GMT+02:00 Wayne Stambaugh >:
 >
 >> You are not being ignored.  I can't speak for all of the lead
 developers
 >> but I've been really busy so pretty much everyone has been getting
 >> ignored by me.  It's not intentional, it's just the reality of my
 >> current work load.
 >>
 >> Patch is giving me an unexpected eof with
3d_viewer-pan_step.patch.
 >>
 >> Did you address Bernhard's concern about the behavior of the GAL
 >> canvases as well as the legacy canvas?  I don't remember seeing
 anything
 >> but I may have missed it.
 >>
 >> On 1/16/2017 11:29 AM, Константин Барановский wrote:
 >>> Hello. I'm sorry for disturbing you, but I'm not understand
why my
 >>> messages are ignored. Proposed feature not needed for no one,
 except me?
 >>> Or I'm made something wrong? Please, give any comment.
 >>>
 >>> 2017-01-06 12:03 GMT+02:00 Константин Барановский
 >>> 

  :
 >>>
 >>> 2016-11-23 0:22 GMT+02:00 Maciej Sumiński

 >>> >>:
 >>>
 >>> I could not apply the second patch, it gives me
 "unexpected end
 >>> of file
 >>> in patch" error. Would you verify the file?
 >>>
 >>>
 >>>  I downloaded both patches and checked them, they looks
 good for me.
 >>> I do not got any problems or errors.
 >>>
 >>>
 >>
 >
 >
 >
 > ___
 > Mailing list: https://launchpad.net/~kicad-developers

 > Post to : kicad-developers@lists.launchpad.net

 > Unsubscribe : https://launchpad.net/~kicad-developers

 > More help   : https://help.launchpad.net/ListHelp

 >

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2017-01-19 Thread Maciej Sumiński

Hi Brano,

Are the problems occurring when touchpad panning is enabled? Is
everything fine once you disable it?

Would you give more details about zoom out being problematic? Does it
zoom out too quickly, is it choppy?

Regards,
Orson

On 01/19/2017 10:52 PM, Brano Panak wrote:
> Today i checked behavior on osx with version: (2017-01-18 revision
> 2eb840b)-master
> and behavior in pcbnew during zooming with wheel+ctrl(cmd on mac) on
> apple mouse  is very erratic.
> 
> Zoom in works ok, zoom out is very problematic.
> 
> Eeschema looks ok, pcbnew with zooming and scrolling on touchpad with 2
> fingers looks good.
> 
> regards
> 
> Brano
> 
> 
> On 17/01/17 18:17, Константин Барановский wrote:
>> In attachment placed new patch, that contains both previous patches
>> and in mousewheelpan mode, with pressed Shift key, does horizontal
>> scrolling.
>>
>> So, in common, we will get:
>>
>> * mousewheelpan disabled:
>> - mousewheel = zooming;
>> - mousewheel + ctrl = horizontal scrolling;
>> - mousewheel + shift = vertical scrolling;
>>
>> * mousewheelpan enabled:
>> - touchpad two finger scrolling = pan;
>> - mousewheel = vertical scrolling;
>> -> mousewheel (touchpad two finger scrolling) + ctrl = zooming;
>> -> mousewheel (touchpad two finger scrolling)  + shift = horizontal
>> scrolling.
>>
>> This patch adds two last options and decreases the pan step in
>> 3d-viewer to be more comfortable.
>> It works in eeschema, pcbnew (legacy, openGL, cairo), 3d-viewer,
>> gerbview.
>>
>> 2017-01-17 11:27 GMT+02:00 Maciej Sumiński > >:
>>
>> Hi Konstantin,
>>
>> Your patches were not ignored, the problem was neither me nor Wayne
>> could fully apply the patches in their original version. Thank you
>> for
>> correcting this.
>>
>> I still hold my previous remark about wheel scroll and shift+wheel
>> scroll doing the same thing when touchpad panning is enabled.
>> Instead,
>> shift+wheel scroll could perform horizontal scrolling in touchpad
>> panning mode.
>>
>> Regards,
>> Orson
>>
>> On 01/16/2017 07:38 PM, Константин Барановский wrote:
>> > Thank you, Wayne, for your response. I'm attached the checked
>> patches.
>> >
>> > 2017-01-16 20:07 GMT+02:00 Wayne Stambaugh > >:
>> >
>> >> You are not being ignored.  I can't speak for all of the lead
>> developers
>> >> but I've been really busy so pretty much everyone has been getting
>> >> ignored by me.  It's not intentional, it's just the reality of my
>> >> current work load.
>> >>
>> >> Patch is giving me an unexpected eof with
>> 3d_viewer-pan_step.patch.
>> >>
>> >> Did you address Bernhard's concern about the behavior of the GAL
>> >> canvases as well as the legacy canvas?  I don't remember seeing
>> anything
>> >> but I may have missed it.
>> >>
>> >> On 1/16/2017 11:29 AM, Константин Барановский wrote:
>> >>> Hello. I'm sorry for disturbing you, but I'm not understand
>> why my
>> >>> messages are ignored. Proposed feature not needed for no one,
>> except me?
>> >>> Or I'm made something wrong? Please, give any comment.
>> >>>
>> >>> 2017-01-06 12:03 GMT+02:00 Константин Барановский
>> >>> > 
>> > 
>>  :
>> >>>
>> >>> 2016-11-23 0:22 GMT+02:00 Maciej Sumiński
>> 
>> >>> > >>:
>> >>>
>> >>> I could not apply the second patch, it gives me
>> "unexpected end
>> >>> of file
>> >>> in patch" error. Would you verify the file?
>> >>>
>> >>>
>> >>>  I downloaded both patches and checked them, they looks
>> good for me.
>> >>> I do not got any problems or errors.
>> >>>
>> >>>
>> >>
>> >
>> >
>> >
>> > ___
>> > Mailing list: https://launchpad.net/~kicad-developers
>> 
>> > Post to : kicad-developers@lists.launchpad.net
>> 
>> > Unsubscribe : https://launchpad.net/~kicad-developers
>> 
>> > More help   : https://help.launchpad.net/ListHelp
>> 
>> >
>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> 
>> Post to : kicad-developers@lists.launchpad.net
>> 
>> Unsubscribe :

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2017-01-19 Thread Brano Panak


Today i checked behavior on osx with version: (2017-01-18 revision 
2eb840b)-master
and behavior in pcbnew during zooming with wheel+ctrl(cmd on mac) on
apple mouse  is very erratic.

Zoom in works ok, zoom out is very problematic.

Eeschema looks ok, pcbnew with zooming and scrolling on touchpad with 2
fingers looks good.

regards

Brano


On 17/01/17 18:17, Константин Барановский wrote:
In attachment placed new patch, that contains both previous patches 
and in mousewheelpan mode, with pressed Shift key, does horizontal 
scrolling.


So, in common, we will get:

* mousewheelpan disabled:
- mousewheel = zooming;
- mousewheel + ctrl = horizontal scrolling;
- mousewheel + shift = vertical scrolling;

* mousewheelpan enabled:
- touchpad two finger scrolling = pan;
- mousewheel = vertical scrolling;
-> mousewheel (touchpad two finger scrolling) + ctrl = zooming;
-> mousewheel (touchpad two finger scrolling)  + shift = horizontal 
scrolling.


This patch adds two last options and decreases the pan step in 
3d-viewer to be more comfortable.

It works in eeschema, pcbnew (legacy, openGL, cairo), 3d-viewer, gerbview.

2017-01-17 11:27 GMT+02:00 Maciej Sumiński >:


Hi Konstantin,

Your patches were not ignored, the problem was neither me nor Wayne
could fully apply the patches in their original version. Thank you for
correcting this.

I still hold my previous remark about wheel scroll and shift+wheel
scroll doing the same thing when touchpad panning is enabled. Instead,
shift+wheel scroll could perform horizontal scrolling in touchpad
panning mode.

Regards,
Orson

On 01/16/2017 07:38 PM, Константин Барановский wrote:
> Thank you, Wayne, for your response. I'm attached the checked
patches.
>
> 2017-01-16 20:07 GMT+02:00 Wayne Stambaugh >:
>
>> You are not being ignored.  I can't speak for all of the lead
developers
>> but I've been really busy so pretty much everyone has been getting
>> ignored by me.  It's not intentional, it's just the reality of my
>> current work load.
>>
>> Patch is giving me an unexpected eof with 3d_viewer-pan_step.patch.
>>
>> Did you address Bernhard's concern about the behavior of the GAL
>> canvases as well as the legacy canvas?  I don't remember seeing
anything
>> but I may have missed it.
>>
>> On 1/16/2017 11:29 AM, Константин Барановский wrote:
>>> Hello. I'm sorry for disturbing you, but I'm not understand why my
>>> messages are ignored. Proposed feature not needed for no one,
except me?
>>> Or I'm made something wrong? Please, give any comment.
>>>
>>> 2017-01-06 12:03 GMT+02:00 Константин Барановский
>>> 

 :
>>>
>>> 2016-11-23 0:22 GMT+02:00 Maciej Sumiński

>>> >>:
>>>
>>> I could not apply the second patch, it gives me
"unexpected end
>>> of file
>>> in patch" error. Would you verify the file?
>>>
>>>
>>>  I downloaded both patches and checked them, they looks
good for me.
>>> I do not got any problems or errors.
>>>
>>>
>>
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers

> Post to : kicad-developers@lists.launchpad.net

> Unsubscribe : https://launchpad.net/~kicad-developers

> More help   : https://help.launchpad.net/ListHelp

>



___
Mailing list: https://launchpad.net/~kicad-developers

Post to : kicad-developers@lists.launchpad.net

Unsubscribe : https://launchpad.net/~kicad-developers

More help   : https://help.launchpad.net/ListHelp





___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe :

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2017-01-17 Thread Wayne Stambaugh

Hi Konstantin,

I committed your patch.  Thank you for making the changes Orson
suggested and the patch.  In the future, please update the copyright
date when you make changes to source files.

Cheers,

Wayne

On 1/17/2017 12:17 PM, Константин Барановский wrote:
> In attachment placed new patch, that contains both previous patches and
> in mousewheelpan mode, with pressed Shift key, does horizontal scrolling.
> 
> So, in common, we will get:
> 
> * mousewheelpan disabled:
> - mousewheel = zooming;
> - mousewheel + ctrl = horizontal scrolling;
> - mousewheel + shift = vertical scrolling;
> 
> * mousewheelpan enabled:
> - touchpad two finger scrolling = pan;
> - mousewheel = vertical scrolling;
> -> mousewheel (touchpad two finger scrolling) + ctrl = zooming;
> -> mousewheel (touchpad two finger scrolling)  + shift = horizontal
> scrolling.
> 
> This patch adds two last options and decreases the pan step in 3d-viewer
> to be more comfortable.
> It works in eeschema, pcbnew (legacy, openGL, cairo), 3d-viewer, gerbview.
> 
> 2017-01-17 11:27 GMT+02:00 Maciej Sumiński  >:
> 
> Hi Konstantin,
> 
> Your patches were not ignored, the problem was neither me nor Wayne
> could fully apply the patches in their original version. Thank you for
> correcting this.
> 
> I still hold my previous remark about wheel scroll and shift+wheel
> scroll doing the same thing when touchpad panning is enabled. Instead,
> shift+wheel scroll could perform horizontal scrolling in touchpad
> panning mode.
> 
> Regards,
> Orson
> 
> On 01/16/2017 07:38 PM, Константин Барановский wrote:
> > Thank you, Wayne, for your response. I'm attached the checked patches.
> >
> > 2017-01-16 20:07 GMT+02:00 Wayne Stambaugh  >:
> >
> >> You are not being ignored.  I can't speak for all of the lead
> developers
> >> but I've been really busy so pretty much everyone has been getting
> >> ignored by me.  It's not intentional, it's just the reality of my
> >> current work load.
> >>
> >> Patch is giving me an unexpected eof with 3d_viewer-pan_step.patch.
> >>
> >> Did you address Bernhard's concern about the behavior of the GAL
> >> canvases as well as the legacy canvas?  I don't remember seeing
> anything
> >> but I may have missed it.
> >>
> >> On 1/16/2017 11:29 AM, Константин Барановский wrote:
> >>> Hello. I'm sorry for disturbing you, but I'm not understand why my
> >>> messages are ignored. Proposed feature not needed for no one,
> except me?
> >>> Or I'm made something wrong? Please, give any comment.
> >>>
> >>> 2017-01-06 12:03 GMT+02:00 Константин Барановский
> >>>  
>  
>  :
> >>>
> >>> 2016-11-23 0:22 GMT+02:00 Maciej Sumiński
> 
> >>>  >>:
> >>>
> >>> I could not apply the second patch, it gives me
> "unexpected end
> >>> of file
> >>> in patch" error. Would you verify the file?
> >>>
> >>>
> >>>  I downloaded both patches and checked them, they looks good
> for me.
> >>> I do not got any problems or errors.
> >>>
> >>>
> >>
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> 
> > Post to : kicad-developers@lists.launchpad.net
> 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> 
> > More help   : https://help.launchpad.net/ListHelp
> 
> >
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list:

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2017-01-17 Thread Константин Барановский

In attachment placed new patch, that contains both previous patches and in
mousewheelpan mode, with pressed Shift key, does horizontal scrolling.

So, in common, we will get:

* mousewheelpan disabled:
- mousewheel = zooming;
- mousewheel + ctrl = horizontal scrolling;
- mousewheel + shift = vertical scrolling;

* mousewheelpan enabled:
- touchpad two finger scrolling = pan;
- mousewheel = vertical scrolling;
-> mousewheel (touchpad two finger scrolling) + ctrl = zooming;
-> mousewheel (touchpad two finger scrolling)  + shift = horizontal
scrolling.

This patch adds two last options and decreases the pan step in 3d-viewer to
be more comfortable.
It works in eeschema, pcbnew (legacy, openGL, cairo), 3d-viewer, gerbview.

2017-01-17 11:27 GMT+02:00 Maciej Sumiński :

> Hi Konstantin,
>
> Your patches were not ignored, the problem was neither me nor Wayne
> could fully apply the patches in their original version. Thank you for
> correcting this.
>
> I still hold my previous remark about wheel scroll and shift+wheel
> scroll doing the same thing when touchpad panning is enabled. Instead,
> shift+wheel scroll could perform horizontal scrolling in touchpad
> panning mode.
>
> Regards,
> Orson
>
> On 01/16/2017 07:38 PM, Константин Барановский wrote:
> > Thank you, Wayne, for your response. I'm attached the checked patches.
> >
> > 2017-01-16 20:07 GMT+02:00 Wayne Stambaugh :
> >
> >> You are not being ignored.  I can't speak for all of the lead developers
> >> but I've been really busy so pretty much everyone has been getting
> >> ignored by me.  It's not intentional, it's just the reality of my
> >> current work load.
> >>
> >> Patch is giving me an unexpected eof with 3d_viewer-pan_step.patch.
> >>
> >> Did you address Bernhard's concern about the behavior of the GAL
> >> canvases as well as the legacy canvas?  I don't remember seeing anything
> >> but I may have missed it.
> >>
> >> On 1/16/2017 11:29 AM, Константин Барановский wrote:
> >>> Hello. I'm sorry for disturbing you, but I'm not understand why my
> >>> messages are ignored. Proposed feature not needed for no one, except
> me?
> >>> Or I'm made something wrong? Please, give any comment.
> >>>
> >>> 2017-01-06 12:03 GMT+02:00 Константин Барановский
> >>>  gmail.com
>  :
> >>>
> >>> 2016-11-23 0:22 GMT+02:00 Maciej Sumiński  >>> >:
> >>>
> >>> I could not apply the second patch, it gives me "unexpected end
> >>> of file
> >>> in patch" error. Would you verify the file?
> >>>
> >>>
> >>>  I downloaded both patches and checked them, they looks good for
> me.
> >>> I do not got any problems or errors.
> >>>
> >>>
> >>
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
From 028e2790af92389d8449765d0ff95fc0ce498c3b Mon Sep 17 00:00:00 2001
From: Baranovskiy Konstantin 
Date: Tue, 17 Jan 2017 17:36:31 +0200
Subject: [PATCH] Improved MousewheelPAN mode.

---
 3d-viewer/3d_canvas/eda_3d_canvas.cpp | 19 +-
 common/draw_panel.cpp | 36 +++
 common/view/wx_view_controls.cpp  | 14 --
 3 files changed, 54 insertions(+), 15 deletions(-)

diff --git a/3d-viewer/3d_canvas/eda_3d_canvas.cpp b/3d-viewer/3d_canvas/eda_3d_canvas.cpp
index 8fa4e083d..212f951bd 100644
--- a/3d-viewer/3d_canvas/eda_3d_canvas.cpp
+++ b/3d-viewer/3d_canvas/eda_3d_canvas.cpp
@@ -439,26 +439,35 @@ void EDA_3D_CANVAS::OnMouseWheel( wxMouseEvent  )
 float delta_move = m_delta_move_step_factor * m_settings.CameraGet().ZoomGet();
 
 if( m_settings.GetFlag( FL_MOUSEWHEEL_PANNING ) )
-delta_move *= (0.05f * event.GetWheelRotation());
+delta_move *= (0.01f * event.GetWheelRotation());
 else
 if( event.GetWheelRotation() < 0 )
 delta_move = -delta_move;
 
-if( m_settings.GetFlag( FL_MOUSEWHEEL_PANNING ) )
+// mousewheel_panning enabled:
+//  wheel   -> pan;
+//  wheel + shift   -> horizontal scrolling;
+//  wheel + ctrl-> zooming;
+// mousewheel_panning disabled:
+//  wheel + shift   -> vertical scrolling;
+//  wheel + ctrl-> horizontal scrolling;
+//  wheel   -> zooming.
+
+if( m_settings.GetFlag( FL_MOUSEWHEEL_PANNING ) &&

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2017-01-17 Thread Maciej Sumiński

Hi Konstantin,

Your patches were not ignored, the problem was neither me nor Wayne
could fully apply the patches in their original version. Thank you for
correcting this.

I still hold my previous remark about wheel scroll and shift+wheel
scroll doing the same thing when touchpad panning is enabled. Instead,
shift+wheel scroll could perform horizontal scrolling in touchpad
panning mode.

Regards,
Orson

On 01/16/2017 07:38 PM, Константин Барановский wrote:
> Thank you, Wayne, for your response. I'm attached the checked patches.
> 
> 2017-01-16 20:07 GMT+02:00 Wayne Stambaugh :
> 
>> You are not being ignored.  I can't speak for all of the lead developers
>> but I've been really busy so pretty much everyone has been getting
>> ignored by me.  It's not intentional, it's just the reality of my
>> current work load.
>>
>> Patch is giving me an unexpected eof with 3d_viewer-pan_step.patch.
>>
>> Did you address Bernhard's concern about the behavior of the GAL
>> canvases as well as the legacy canvas?  I don't remember seeing anything
>> but I may have missed it.
>>
>> On 1/16/2017 11:29 AM, Константин Барановский wrote:
>>> Hello. I'm sorry for disturbing you, but I'm not understand why my
>>> messages are ignored. Proposed feature not needed for no one, except me?
>>> Or I'm made something wrong? Please, give any comment.
>>>
>>> 2017-01-06 12:03 GMT+02:00 Константин Барановский
>>> >>
>>> 2016-11-23 0:22 GMT+02:00 Maciej Sumiński >> >:
>>>
>>> I could not apply the second patch, it gives me "unexpected end
>>> of file
>>> in patch" error. Would you verify the file?
>>>
>>>
>>>  I downloaded both patches and checked them, they looks good for me.
>>> I do not got any problems or errors.
>>>
>>>
>>
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 




signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2017-01-16 Thread Wayne Stambaugh

I tested the patches and both the legacy and GAL canvases appear to
behave the same way so if no one objects, I'm going to commit the changes.

In the future, please commit your changes and use git format-patch to
generate patches.  It makes my life easier.

On 1/16/2017 1:38 PM, Константин Барановский wrote:
> Thank you, Wayne, for your response. I'm attached the checked patches.
> 
> 2017-01-16 20:07 GMT+02:00 Wayne Stambaugh  >:
> 
> You are not being ignored.  I can't speak for all of the lead developers
> but I've been really busy so pretty much everyone has been getting
> ignored by me.  It's not intentional, it's just the reality of my
> current work load.
> 
> Patch is giving me an unexpected eof with 3d_viewer-pan_step.patch.
> 
> Did you address Bernhard's concern about the behavior of the GAL
> canvases as well as the legacy canvas?  I don't remember seeing anything
> but I may have missed it.
> 
> On 1/16/2017 11:29 AM, Константин Барановский wrote:
> > Hello. I'm sorry for disturbing you, but I'm not understand why my
> > messages are ignored. Proposed feature not needed for no one, except me?
> > Or I'm made something wrong? Please, give any comment.
> >
> > 2017-01-06 12:03 GMT+02:00 Константин Барановский
> >  
>  >>:
> >
> > 2016-11-23 0:22 GMT+02:00 Maciej Sumiński  
> >  >>:
> >
> > I could not apply the second patch, it gives me
> "unexpected end
> > of file
> > in patch" error. Would you verify the file?
> >
> >
> >  I downloaded both patches and checked them, they looks good
> for me.
> > I do not got any problems or errors.
> >
> >
> 
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2017-01-16 Thread Константин Барановский

Thank you, Wayne, for your response. I'm attached the checked patches.

2017-01-16 20:07 GMT+02:00 Wayne Stambaugh :

> You are not being ignored.  I can't speak for all of the lead developers
> but I've been really busy so pretty much everyone has been getting
> ignored by me.  It's not intentional, it's just the reality of my
> current work load.
>
> Patch is giving me an unexpected eof with 3d_viewer-pan_step.patch.
>
> Did you address Bernhard's concern about the behavior of the GAL
> canvases as well as the legacy canvas?  I don't remember seeing anything
> but I may have missed it.
>
> On 1/16/2017 11:29 AM, Константин Барановский wrote:
> > Hello. I'm sorry for disturbing you, but I'm not understand why my
> > messages are ignored. Proposed feature not needed for no one, except me?
> > Or I'm made something wrong? Please, give any comment.
> >
> > 2017-01-06 12:03 GMT+02:00 Константин Барановский
> >  >>:
> >
> > 2016-11-23 0:22 GMT+02:00 Maciej Sumiński  > >:
> >
> > I could not apply the second patch, it gives me "unexpected end
> > of file
> > in patch" error. Would you verify the file?
> >
> >
> >  I downloaded both patches and checked them, they looks good for me.
> > I do not got any problems or errors.
> >
> >
>
diff --git a/3d-viewer/3d_canvas/eda_3d_canvas.cpp b/3d-viewer/3d_canvas/eda_3d_canvas.cpp
index 2688125..c5fb5cf 100644
--- a/3d-viewer/3d_canvas/eda_3d_canvas.cpp
+++ b/3d-viewer/3d_canvas/eda_3d_canvas.cpp
@@ -443,7 +443,15 @@ void EDA_3D_CANVAS::OnMouseWheel( wxMouseEvent  )
 if( event.GetWheelRotation() < 0 )
 delta_move = -delta_move;
 
-if( m_settings.GetFlag( FL_MOUSEWHEEL_PANNING ) )
+// mousewheel_panning enabled:
+//  wheel   -> pan;
+//  wheel + ctrl-> zooming.
+// mousewheel_panning disabled:
+//  wheel + shift   -> vertical scrolling;
+//  wheel + ctrl-> horizontal scrolling;
+//  wheel   -> zooming;
+
+if( m_settings.GetFlag( FL_MOUSEWHEEL_PANNING ) && !event.ControlDown() )
 {
 if( event.GetWheelAxis() == wxMOUSE_WHEEL_HORIZONTAL )
 m_settings.CameraGet().Pan( SFVEC3F( -delta_move, 0.0f, 0.0f ) );
@@ -452,12 +460,12 @@ void EDA_3D_CANVAS::OnMouseWheel( wxMouseEvent  )
 
 mouseActivity = true;
 }
-else if( event.ShiftDown() )
+else if( event.ShiftDown() &&  !m_settings.GetFlag( FL_MOUSEWHEEL_PANNING ) )
 {
 m_settings.CameraGet().Pan( SFVEC3F( 0.0f, -delta_move, 0.0f ) );
 mouseActivity = true;
 }
-else if( event.ControlDown() )
+else if( event.ControlDown() && !m_settings.GetFlag( FL_MOUSEWHEEL_PANNING ) )
 {
 m_settings.CameraGet().Pan( SFVEC3F( delta_move, 0.0f, 0.0f ) );
 mouseActivity = true;
diff --git a/common/draw_panel.cpp b/common/draw_panel.cpp
index a705791..72cf624 100644
--- a/common/draw_panel.cpp
+++ b/common/draw_panel.cpp
@@ -981,15 +981,26 @@ void EDA_DRAW_PANEL::OnMouseWheel( wxMouseEvent& event )
 
 if( m_enableMousewheelPan )
 {
-wxPoint newStart = GetViewStart();
-if( axis == wxMOUSE_WHEEL_HORIZONTAL )
-newStart.x += wheelRotation;
+// MousewheelPAN + Ctrl = zooming
+if( event.ControlDown() )
+{
+if( wheelRotation > 0 )
+cmd.SetId( ID_POPUP_ZOOM_IN );
+else if( wheelRotation < 0)
+cmd.SetId( ID_POPUP_ZOOM_OUT );
+}
 else
-newStart.y -= wheelRotation;
-
-wxPoint center = GetScreenCenterLogicalPosition();
-GetParent()->SetScrollCenterPosition( center );
-Scroll( newStart );
+{
+wxPoint newStart = GetViewStart();
+if( axis == wxMOUSE_WHEEL_HORIZONTAL )
+newStart.x += wheelRotation;
+else
+newStart.y -= wheelRotation;
+
+wxPoint center = GetScreenCenterLogicalPosition();
+GetParent()->SetScrollCenterPosition( center );
+Scroll( newStart );
+}
 }
 else if( wheelRotation > 0 )
 {
diff --git a/common/view/wx_view_controls.cpp b/common/view/wx_view_controls.cpp
index 845d2af..3f80f62 100644
--- a/common/view/wx_view_controls.cpp
+++ b/common/view/wx_view_controls.cpp
@@ -98,7 +98,16 @@ void WX_VIEW_CONTROLS::onWheel( wxMouseEvent& aEvent )
 {
 const double wheelPanSpeed = 0.001;
 
-if( aEvent.ControlDown() || aEvent.ShiftDown() || m_enableMousewheelPan )
+// mousewheelpan disabled:
+//  wheel + ctrl-> horizontal scrolling;
+//  wheel + shift   -> vertical scrolling;
+//  wheel   -> zooming;
+// mousewheelpan enabled:
+//  wheel   -> pan;
+//  wheel + ctrl-> zooming.
+
+if( (

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2017-01-16 Thread Wayne Stambaugh

You are not being ignored.  I can't speak for all of the lead developers
but I've been really busy so pretty much everyone has been getting
ignored by me.  It's not intentional, it's just the reality of my
current work load.

Patch is giving me an unexpected eof with 3d_viewer-pan_step.patch.

Did you address Bernhard's concern about the behavior of the GAL
canvases as well as the legacy canvas?  I don't remember seeing anything
but I may have missed it.

On 1/16/2017 11:29 AM, Константин Барановский wrote:
> Hello. I'm sorry for disturbing you, but I'm not understand why my
> messages are ignored. Proposed feature not needed for no one, except me?
> Or I'm made something wrong? Please, give any comment.
> 
> 2017-01-06 12:03 GMT+02:00 Константин Барановский
> >:
> 
> 2016-11-23 0:22 GMT+02:00 Maciej Sumiński  >:
> 
> I could not apply the second patch, it gives me "unexpected end
> of file
> in patch" error. Would you verify the file?
> 
> 
>  I downloaded both patches and checked them, they looks good for me.
> I do not got any problems or errors.
> 
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2017-01-16 Thread Константин Барановский

Hello. I'm sorry for disturbing you, but I'm not understand why my messages
are ignored. Proposed feature not needed for no one, except me? Or I'm made
something wrong? Please, give any comment.

2017-01-06 12:03 GMT+02:00 Константин Барановский <
baranovskiykonstan...@gmail.com>:

> 2016-11-23 0:22 GMT+02:00 Maciej Sumiński :
>
>> I could not apply the second patch, it gives me "unexpected end of file
>> in patch" error. Would you verify the file?
>>
>>
>  I downloaded both patches and checked them, they looks good for me. I do
> not got any problems or errors.
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2017-01-06 Thread Константин Барановский

2016-11-23 0:22 GMT+02:00 Maciej Sumiński :

> I could not apply the second patch, it gives me "unexpected end of file
> in patch" error. Would you verify the file?
>
>
 I downloaded both patches and checked them, they looks good for me. I do
not got any problems or errors.
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2016-11-22 Thread Maciej Sumiński

The patch seems reasonable to me. Currently with touchpad panning
enabled there is no way to zoom with the scroll motion. With the patch
applied zoom both are enabled. I do not have a two-wheel mouse or a
touchpad to test if everything works well for the second axis, but the
patch seems correct.

I could not apply the second patch, it gives me "unexpected end of file
in patch" error. Would you verify the file?

There is one thing that could be improved. Currently wheel scroll and
shift+scroll behave identically. Perhaps pressing shift could select the
axis for panning. Just an idea.

Regards,
Orson

On 11/12/2016 09:35 PM, Константин Барановский wrote:
> New version of the patch that works in legacy/opengl/cairo/3d_viewer.
> 
> Also I noticed that in 3d_viewer pan step is to big, so I propose decrease
> it.
> 
> 2016-11-12 9:33 GMT+02:00 Константин Барановский <
> baranovskiykonstan...@gmail.com>:
> 
>> Hmm. This patch really works only in legacy mode and doesn't work in GAL
>> mode, but I don't understand why. It looks like both modes legacy and GAL
>> used the same event  handler for mouse wheel event, but still does not
>> work. Can anyone to point me to right direction for searching, please?
>>
>> 2016-11-11 21:46 GMT+02:00 Wayne Stambaugh :
>>
>>> Thanks Bernhard.  The behavior should be the same for the gal canvas and
>>> the 3d-viewer.
>>>
>>> On 11/11/2016 2:26 PM, Bernhard Stegmaier wrote:
 I’ll try to test ASAP, but I can’t promise when.

 At least on first glance it seems to be somewhat incomplete.
 It only seems to change legacy canvas, but not GAL canvas or 3d-viewer,
>>> which
 should probably behave the same then?


 Regards,
 Bernhard

> On 11 Nov 2016, at 16:04, Wayne Stambaugh 
>>> wrote:
>
> This doesn't break anything on osx does it?  That is what I need to
>>> know
> before I commit the patch.  Would one of the osx devs please confirm
> this form me when you get a chance?
>
> Thanks,
>
> Wayne
>
> On 11/11/2016 10:01 AM, Константин Барановский wrote:
>> I'm using archlinux x86_64 on thinkpad t420 (that allows two-finger
>> scrolling) and all modifier keys (ctrl, shift, alt) does nothing.
>>
>> 2016-11-11 16:31 GMT+02:00 Brano Panak > >:
>>
>>in osx even without this patch this functionality works (cmd+ mouse
>>wheel is zooming).
>>
>>
>>On 10/11/16 11:41, Константин Барановский wrote:
>>>That patch allows to use mouse wheel + ctrl for zooming, when
>>>option "Use touchpad to pan" is enabled.
>>>
>>>
>>>
>>>___
>>>Mailing list: https://launchpad.net/~kicad-developers
>>>
>>>Post to : kicad-developers@lists.launchpad.net
>>>
>>>Unsubscribe : https://launchpad.net/~kicad-developers
>>>
>>>More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>>___
>>Mailing list: https://launchpad.net/~kicad-developers
>>
>>Post to : kicad-developers@lists.launchpad.net
>>
>>Unsubscribe : https://launchpad.net/~kicad-developers
>>
>>More help   : https://help.launchpad.net/ListHelp
>>
>>
>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

>>>
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 



signature.asc

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2016-11-21 Thread Константин Барановский

Please, pay attention to these patches.

2016-11-12 22:35 GMT+02:00 Константин Барановский <
baranovskiykonstan...@gmail.com>:

> New version of the patch that works in legacy/opengl/cairo/3d_viewer.
>
> Also I noticed that in 3d_viewer pan step is to big, so I propose decrease
> it.
>
> 2016-11-12 9:33 GMT+02:00 Константин Барановский <
> baranovskiykonstan...@gmail.com>:
>
>> Hmm. This patch really works only in legacy mode and doesn't work in GAL
>> mode, but I don't understand why. It looks like both modes legacy and GAL
>> used the same event  handler for mouse wheel event, but still does not
>> work. Can anyone to point me to right direction for searching, please?
>>
>> 2016-11-11 21:46 GMT+02:00 Wayne Stambaugh :
>>
>>> Thanks Bernhard.  The behavior should be the same for the gal canvas and
>>> the 3d-viewer.
>>>
>>> On 11/11/2016 2:26 PM, Bernhard Stegmaier wrote:
>>> > I’ll try to test ASAP, but I can’t promise when.
>>> >
>>> > At least on first glance it seems to be somewhat incomplete.
>>> > It only seems to change legacy canvas, but not GAL canvas or
>>> 3d-viewer, which
>>> > should probably behave the same then?
>>> >
>>> >
>>> > Regards,
>>> > Bernhard
>>> >
>>> >> On 11 Nov 2016, at 16:04, Wayne Stambaugh 
>>> wrote:
>>> >>
>>> >> This doesn't break anything on osx does it?  That is what I need to
>>> know
>>> >> before I commit the patch.  Would one of the osx devs please confirm
>>> >> this form me when you get a chance?
>>> >>
>>> >> Thanks,
>>> >>
>>> >> Wayne
>>> >>
>>> >> On 11/11/2016 10:01 AM, Константин Барановский wrote:
>>> >>> I'm using archlinux x86_64 on thinkpad t420 (that allows two-finger
>>> >>> scrolling) and all modifier keys (ctrl, shift, alt) does nothing.
>>> >>>
>>> >>> 2016-11-11 16:31 GMT+02:00 Brano Panak >> >>> >:
>>> >>>
>>> >>>in osx even without this patch this functionality works (cmd+
>>> mouse
>>> >>>wheel is zooming).
>>> >>>
>>> >>>
>>> >>>On 10/11/16 11:41, Константин Барановский wrote:
>>> That patch allows to use mouse wheel + ctrl for zooming, when
>>> option "Use touchpad to pan" is enabled.
>>> 
>>> 
>>> 
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> 
>>> Post to : kicad-developers@lists.launchpad.net
>>> 
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> 
>>> More help   : https://help.launchpad.net/ListHelp
>>> 
>>> >>>
>>> >>>
>>> >>>___
>>> >>>Mailing list: https://launchpad.net/~kicad-developers
>>> >>>
>>> >>>Post to : kicad-developers@lists.launchpad.net
>>> >>>
>>> >>>Unsubscribe : https://launchpad.net/~kicad-developers
>>> >>>
>>> >>>More help   : https://help.launchpad.net/ListHelp
>>> >>>
>>> >>>
>>> >>>
>>> >>>
>>> >>>
>>> >>> ___
>>> >>> Mailing list: https://launchpad.net/~kicad-developers
>>> >>> Post to : kicad-developers@lists.launchpad.net
>>> >>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> >>> More help   : https://help.launchpad.net/ListHelp
>>> >>>
>>> >>
>>> >>
>>> >> ___
>>> >> Mailing list: https://launchpad.net/~kicad-developers
>>> >> Post to : kicad-developers@lists.launchpad.net
>>> >> Unsubscribe : https://launchpad.net/~kicad-developers
>>> >> More help   : https://help.launchpad.net/ListHelp
>>> >
>>>
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2016-11-12 Thread Константин Барановский

New version of the patch that works in legacy/opengl/cairo/3d_viewer.

Also I noticed that in 3d_viewer pan step is to big, so I propose decrease
it.

2016-11-12 9:33 GMT+02:00 Константин Барановский <
baranovskiykonstan...@gmail.com>:

> Hmm. This patch really works only in legacy mode and doesn't work in GAL
> mode, but I don't understand why. It looks like both modes legacy and GAL
> used the same event  handler for mouse wheel event, but still does not
> work. Can anyone to point me to right direction for searching, please?
>
> 2016-11-11 21:46 GMT+02:00 Wayne Stambaugh :
>
>> Thanks Bernhard.  The behavior should be the same for the gal canvas and
>> the 3d-viewer.
>>
>> On 11/11/2016 2:26 PM, Bernhard Stegmaier wrote:
>> > I’ll try to test ASAP, but I can’t promise when.
>> >
>> > At least on first glance it seems to be somewhat incomplete.
>> > It only seems to change legacy canvas, but not GAL canvas or 3d-viewer,
>> which
>> > should probably behave the same then?
>> >
>> >
>> > Regards,
>> > Bernhard
>> >
>> >> On 11 Nov 2016, at 16:04, Wayne Stambaugh 
>> wrote:
>> >>
>> >> This doesn't break anything on osx does it?  That is what I need to
>> know
>> >> before I commit the patch.  Would one of the osx devs please confirm
>> >> this form me when you get a chance?
>> >>
>> >> Thanks,
>> >>
>> >> Wayne
>> >>
>> >> On 11/11/2016 10:01 AM, Константин Барановский wrote:
>> >>> I'm using archlinux x86_64 on thinkpad t420 (that allows two-finger
>> >>> scrolling) and all modifier keys (ctrl, shift, alt) does nothing.
>> >>>
>> >>> 2016-11-11 16:31 GMT+02:00 Brano Panak > >>> >:
>> >>>
>> >>>in osx even without this patch this functionality works (cmd+ mouse
>> >>>wheel is zooming).
>> >>>
>> >>>
>> >>>On 10/11/16 11:41, Константин Барановский wrote:
>> That patch allows to use mouse wheel + ctrl for zooming, when
>> option "Use touchpad to pan" is enabled.
>> 
>> 
>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> 
>> Post to : kicad-developers@lists.launchpad.net
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> 
>> More help   : https://help.launchpad.net/ListHelp
>> 
>> >>>
>> >>>
>> >>>___
>> >>>Mailing list: https://launchpad.net/~kicad-developers
>> >>>
>> >>>Post to : kicad-developers@lists.launchpad.net
>> >>>
>> >>>Unsubscribe : https://launchpad.net/~kicad-developers
>> >>>
>> >>>More help   : https://help.launchpad.net/ListHelp
>> >>>
>> >>>
>> >>>
>> >>>
>> >>>
>> >>> ___
>> >>> Mailing list: https://launchpad.net/~kicad-developers
>> >>> Post to : kicad-developers@lists.launchpad.net
>> >>> Unsubscribe : https://launchpad.net/~kicad-developers
>> >>> More help   : https://help.launchpad.net/ListHelp
>> >>>
>> >>
>> >>
>> >> ___
>> >> Mailing list: https://launchpad.net/~kicad-developers
>> >> Post to : kicad-developers@lists.launchpad.net
>> >> Unsubscribe : https://launchpad.net/~kicad-developers
>> >> More help   : https://help.launchpad.net/ListHelp
>> >
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
diff --git a/3d-viewer/3d_canvas/eda_3d_canvas.cpp b/3d-viewer/3d_canvas/eda_3d_canvas.cpp
index 2688125..c5fb5cf 100644
--- a/3d-viewer/3d_canvas/eda_3d_canvas.cpp
+++ b/3d-viewer/3d_canvas/eda_3d_canvas.cpp
@@ -443,7 +443,15 @@ void EDA_3D_CANVAS::OnMouseWheel( wxMouseEvent  )
 if( event.GetWheelRotation() < 0 )
 delta_move = -delta_move;
 
-if( m_settings.GetFlag( FL_MOUSEWHEEL_PANNING ) )
+// mousewheel_panning enabled:
+//  wheel   -> pan;
+//  wheel + ctrl-> zooming.
+// mousewheel_panning disabled:
+//  wheel + shift   -> vertical scrolling;
+//  wheel + ctrl-> horizontal scrolling;
+//  wheel   -> zooming;
+
+if( m_settings.GetFlag( FL_MOUSEWHEEL_PANNING ) && !event.ControlDown() )
 {
 if( event.GetWheelAxis() == wxMOUSE_WHEEL_HORIZONTAL )
 m_settings.CameraGet().Pan( SFVEC3F( -delta_move, 0.0f, 0.0f ) );
@@ -452,12 +460,12 @@ void

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2016-11-11 Thread Константин Барановский

Hmm. This patch really works only in legacy mode and doesn't work in GAL
mode, but I don't understand why. It looks like both modes legacy and GAL
used the same event  handler for mouse wheel event, but still does not
work. Can anyone to point me to right direction for searching, please?

2016-11-11 21:46 GMT+02:00 Wayne Stambaugh :

> Thanks Bernhard.  The behavior should be the same for the gal canvas and
> the 3d-viewer.
>
> On 11/11/2016 2:26 PM, Bernhard Stegmaier wrote:
> > I’ll try to test ASAP, but I can’t promise when.
> >
> > At least on first glance it seems to be somewhat incomplete.
> > It only seems to change legacy canvas, but not GAL canvas or 3d-viewer,
> which
> > should probably behave the same then?
> >
> >
> > Regards,
> > Bernhard
> >
> >> On 11 Nov 2016, at 16:04, Wayne Stambaugh  wrote:
> >>
> >> This doesn't break anything on osx does it?  That is what I need to know
> >> before I commit the patch.  Would one of the osx devs please confirm
> >> this form me when you get a chance?
> >>
> >> Thanks,
> >>
> >> Wayne
> >>
> >> On 11/11/2016 10:01 AM, Константин Барановский wrote:
> >>> I'm using archlinux x86_64 on thinkpad t420 (that allows two-finger
> >>> scrolling) and all modifier keys (ctrl, shift, alt) does nothing.
> >>>
> >>> 2016-11-11 16:31 GMT+02:00 Brano Panak  >>> >:
> >>>
> >>>in osx even without this patch this functionality works (cmd+ mouse
> >>>wheel is zooming).
> >>>
> >>>
> >>>On 10/11/16 11:41, Константин Барановский wrote:
> That patch allows to use mouse wheel + ctrl for zooming, when
> option "Use touchpad to pan" is enabled.
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 
> >>>
> >>>
> >>>___
> >>>Mailing list: https://launchpad.net/~kicad-developers
> >>>
> >>>Post to : kicad-developers@lists.launchpad.net
> >>>
> >>>Unsubscribe : https://launchpad.net/~kicad-developers
> >>>
> >>>More help   : https://help.launchpad.net/ListHelp
> >>>
> >>>
> >>>
> >>>
> >>>
> >>> ___
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to : kicad-developers@lists.launchpad.net
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
> >>>
> >>
> >>
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to : kicad-developers@lists.launchpad.net
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> >
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2016-11-11 Thread Wayne Stambaugh

Thanks Bernhard.  The behavior should be the same for the gal canvas and
the 3d-viewer.

On 11/11/2016 2:26 PM, Bernhard Stegmaier wrote:
> I’ll try to test ASAP, but I can’t promise when.
> 
> At least on first glance it seems to be somewhat incomplete.
> It only seems to change legacy canvas, but not GAL canvas or 3d-viewer, which
> should probably behave the same then?
> 
> 
> Regards,
> Bernhard
> 
>> On 11 Nov 2016, at 16:04, Wayne Stambaugh  wrote:
>>
>> This doesn't break anything on osx does it?  That is what I need to know
>> before I commit the patch.  Would one of the osx devs please confirm
>> this form me when you get a chance?
>>
>> Thanks,
>>
>> Wayne
>>
>> On 11/11/2016 10:01 AM, Константин Барановский wrote:
>>> I'm using archlinux x86_64 on thinkpad t420 (that allows two-finger
>>> scrolling) and all modifier keys (ctrl, shift, alt) does nothing.
>>>
>>> 2016-11-11 16:31 GMT+02:00 Brano Panak >> >:
>>>
>>>in osx even without this patch this functionality works (cmd+ mouse
>>>wheel is zooming).
>>>
>>>
>>>On 10/11/16 11:41, Константин Барановский wrote:
That patch allows to use mouse wheel + ctrl for zooming, when
option "Use touchpad to pan" is enabled.



___
Mailing list: https://launchpad.net/~kicad-developers

Post to : kicad-developers@lists.launchpad.net

Unsubscribe : https://launchpad.net/~kicad-developers

More help   : https://help.launchpad.net/ListHelp

>>>
>>>
>>>___
>>>Mailing list: https://launchpad.net/~kicad-developers
>>>
>>>Post to : kicad-developers@lists.launchpad.net
>>>
>>>Unsubscribe : https://launchpad.net/~kicad-developers
>>>
>>>More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>>>
>>>
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2016-11-11 Thread Bernhard Stegmaier

I’ll try to test ASAP, but I can’t promise when.

At least on first glance it seems to be somewhat incomplete.
It only seems to change legacy canvas, but not GAL canvas or 3d-viewer, which
should probably behave the same then?


Regards,
Bernhard

> On 11 Nov 2016, at 16:04, Wayne Stambaugh  wrote:
> 
> This doesn't break anything on osx does it?  That is what I need to know
> before I commit the patch.  Would one of the osx devs please confirm
> this form me when you get a chance?
> 
> Thanks,
> 
> Wayne
> 
> On 11/11/2016 10:01 AM, Константин Барановский wrote:
>> I'm using archlinux x86_64 on thinkpad t420 (that allows two-finger
>> scrolling) and all modifier keys (ctrl, shift, alt) does nothing.
>> 
>> 2016-11-11 16:31 GMT+02:00 Brano Panak > >:
>> 
>>in osx even without this patch this functionality works (cmd+ mouse
>>wheel is zooming).
>> 
>> 
>>On 10/11/16 11:41, Константин Барановский wrote:
>>>That patch allows to use mouse wheel + ctrl for zooming, when
>>>option "Use touchpad to pan" is enabled.
>>> 
>>> 
>>> 
>>>___
>>>Mailing list: https://launchpad.net/~kicad-developers
>>>
>>>Post to : kicad-developers@lists.launchpad.net
>>>
>>>Unsubscribe : https://launchpad.net/~kicad-developers
>>>
>>>More help   : https://help.launchpad.net/ListHelp
>>>
>> 
>> 
>>___
>>Mailing list: https://launchpad.net/~kicad-developers
>>
>>Post to : kicad-developers@lists.launchpad.net
>>
>>Unsubscribe : https://launchpad.net/~kicad-developers
>>
>>More help   : https://help.launchpad.net/ListHelp
>>
>> 
>> 
>> 
>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2016-11-11 Thread Wayne Stambaugh

This doesn't break anything on osx does it?  That is what I need to know
before I commit the patch.  Would one of the osx devs please confirm
this form me when you get a chance?

Thanks,

Wayne

On 11/11/2016 10:01 AM, Константин Барановский wrote:
> I'm using archlinux x86_64 on thinkpad t420 (that allows two-finger
> scrolling) and all modifier keys (ctrl, shift, alt) does nothing.
> 
> 2016-11-11 16:31 GMT+02:00 Brano Panak  >:
> 
> in osx even without this patch this functionality works (cmd+ mouse
> wheel is zooming).
> 
> 
> On 10/11/16 11:41, Константин Барановский wrote:
>> That patch allows to use mouse wheel + ctrl for zooming, when
>> option "Use touchpad to pan" is enabled.
>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> 
>> Post to : kicad-developers@lists.launchpad.net
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> 
>> More help   : https://help.launchpad.net/ListHelp
>> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2016-11-11 Thread Константин Барановский

I'm using archlinux x86_64 on thinkpad t420 (that allows two-finger
scrolling) and all modifier keys (ctrl, shift, alt) does nothing.

2016-11-11 16:31 GMT+02:00 Brano Panak :

> in osx even without this patch this functionality works (cmd+ mouse wheel
> is zooming).
>
> On 10/11/16 11:41, Константин Барановский wrote:
>
> That patch allows to use mouse wheel + ctrl for zooming, when option "Use
> touchpad to pan" is enabled.
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2016-11-11 Thread Brano Panak

in osx even without this patch this functionality works (cmd+ mouse 
wheel is zooming).



On 10/11/16 11:41, Константин Барановский wrote:
That patch allows to use mouse wheel + ctrl for zooming, when option 
"Use touchpad to pan" is enabled.




___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

21 matches

Site Navigation

Mail list logo

Footer information