Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

[Wayne Stambaugh]

Hi Metacollin,

Sorry about that.  I thought this was already merged.  I merged you
patch.  Thank you for your contribution to KiCad.

Cheers,

Wayne

On 4/26/2018 3:25 AM, metacollin wrote:
> Yes, it causes cmake to recursively consume all free disk space unless killed 
> if the user happens to set their install path to the current working 
> directory.  This is actually required for integration with certain package 
> managers (well, ok, one package manager, homebrew).  
> 
> I should have mate an atomic pull request, sorry.  Anyway, if you're still 
> interested in merging this fix in isolation, here is the patch.  
> 
> 
> 
> Thanks!
> 
> 
> 
>> On Mar 23, 2018, at 6:37 AM, Adam Wolf  wrote:
>>
>> Please note, one of the pull requests, the packages3d one I think, has
>> an unrelated change bundled with it that I think should definitely be
>> merged in.
>>
>> Adam
>>
>> On Fri, Mar 23, 2018 at 7:29 AM, Wayne Stambaugh  
>> wrote:
>>> On 03/22/2018 04:51 PM, Mathias Grimmberger wrote:

 Hi everybody,

 Wayne Stambaugh  writes:

> If someone would pin down the exact version of cmake where this
> available, I would appreciated it.  My benchmark (Debian stable) is
> currently shipping with 3.7.2 although that seems like a pretty current
> version.  I don't want to bump the cmake version too high and drop a
> bunch of linux distros that are using an older version of cmake


 According to cmakes online docs this was added in version 3.7.

 As a distro data point: OpenSUSE 42.3 (the current version) ships with
 cmake 3.5.2.


 MGri

>>>
>>> Mathias,
>>>
>>> Thanks for the information.  We will have to hold off on the cmake
>>> install path changes for a while.
>>>
>>> Cheers,
>>>
>>> Wayne
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

[metacollin]

Yes, it causes cmake to recursively consume all free disk space unless killed 
if the user happens to set their install path to the current working directory. 
 This is actually required for integration with certain package managers (well, 
ok, one package manager, homebrew).  

I should have mate an atomic pull request, sorry.  Anyway, if you're still 
interested in merging this fix in isolation, here is the patch.  



recursion_fix.patch
Description: Binary data
Thanks!



> On Mar 23, 2018, at 6:37 AM, Adam Wolf  wrote:
> 
> Please note, one of the pull requests, the packages3d one I think, has
> an unrelated change bundled with it that I think should definitely be
> merged in.
> 
> Adam
> 
> On Fri, Mar 23, 2018 at 7:29 AM, Wayne Stambaugh  wrote:
>> On 03/22/2018 04:51 PM, Mathias Grimmberger wrote:
>>> 
>>> Hi everybody,
>>> 
>>> Wayne Stambaugh  writes:
>>> 
 If someone would pin down the exact version of cmake where this
 available, I would appreciated it.  My benchmark (Debian stable) is
 currently shipping with 3.7.2 although that seems like a pretty current
 version.  I don't want to bump the cmake version too high and drop a
 bunch of linux distros that are using an older version of cmake
>>> 
>>> 
>>> According to cmakes online docs this was added in version 3.7.
>>> 
>>> As a distro data point: OpenSUSE 42.3 (the current version) ships with
>>> cmake 3.5.2.
>>> 
>>> 
>>> MGri
>>> 
>> 
>> Mathias,
>> 
>> Thanks for the information.  We will have to hold off on the cmake
>> install path changes for a while.
>> 
>> Cheers,
>> 
>> Wayne
>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp



smime.p7s
Description: S/MIME cryptographic signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

[Wayne Stambaugh]

Yes, that one should be merged.

Wayne

On 03/23/2018 08:37 AM, Adam Wolf wrote:
> Please note, one of the pull requests, the packages3d one I think, has
> an unrelated change bundled with it that I think should definitely be
> merged in.
> 
> Adam
> 
> On Fri, Mar 23, 2018 at 7:29 AM, Wayne Stambaugh  wrote:
>> On 03/22/2018 04:51 PM, Mathias Grimmberger wrote:
>>>
>>> Hi everybody,
>>>
>>> Wayne Stambaugh  writes:
>>>
 If someone would pin down the exact version of cmake where this
 available, I would appreciated it.  My benchmark (Debian stable) is
 currently shipping with 3.7.2 although that seems like a pretty current
 version.  I don't want to bump the cmake version too high and drop a
 bunch of linux distros that are using an older version of cmake
>>>
>>>
>>> According to cmakes online docs this was added in version 3.7.
>>>
>>> As a distro data point: OpenSUSE 42.3 (the current version) ships with
>>> cmake 3.5.2.
>>>
>>>
>>> MGri
>>>
>>
>> Mathias,
>>
>> Thanks for the information.  We will have to hold off on the cmake
>> install path changes for a while.
>>
>> Cheers,
>>
>> Wayne
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

[Adam Wolf]

Please note, one of the pull requests, the packages3d one I think, has
an unrelated change bundled with it that I think should definitely be
merged in.

Adam

On Fri, Mar 23, 2018 at 7:29 AM, Wayne Stambaugh  wrote:
> On 03/22/2018 04:51 PM, Mathias Grimmberger wrote:
>>
>> Hi everybody,
>>
>> Wayne Stambaugh  writes:
>>
>>> If someone would pin down the exact version of cmake where this
>>> available, I would appreciated it.  My benchmark (Debian stable) is
>>> currently shipping with 3.7.2 although that seems like a pretty current
>>> version.  I don't want to bump the cmake version too high and drop a
>>> bunch of linux distros that are using an older version of cmake
>>
>>
>> According to cmakes online docs this was added in version 3.7.
>>
>> As a distro data point: OpenSUSE 42.3 (the current version) ships with
>> cmake 3.5.2.
>>
>>
>> MGri
>>
>
> Mathias,
>
> Thanks for the information.  We will have to hold off on the cmake
> install path changes for a while.
>
> Cheers,
>
> Wayne
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

[Wayne Stambaugh]

On 03/22/2018 04:51 PM, Mathias Grimmberger wrote:
> 
> Hi everybody,
> 
> Wayne Stambaugh  writes:
> 
>> If someone would pin down the exact version of cmake where this
>> available, I would appreciated it.  My benchmark (Debian stable) is
>> currently shipping with 3.7.2 although that seems like a pretty current
>> version.  I don't want to bump the cmake version too high and drop a
>> bunch of linux distros that are using an older version of cmake
> 
> 
> According to cmakes online docs this was added in version 3.7.
> 
> As a distro data point: OpenSUSE 42.3 (the current version) ships with
> cmake 3.5.2.
> 
> 
> MGri
> 

Mathias,

Thanks for the information.  We will have to hold off on the cmake
install path changes for a while.

Cheers,

Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

[Mathias Grimmberger]

Hi everybody,

Wayne Stambaugh  writes:

> If someone would pin down the exact version of cmake where this
> available, I would appreciated it.  My benchmark (Debian stable) is
> currently shipping with 3.7.2 although that seems like a pretty current
> version.  I don't want to bump the cmake version too high and drop a
> bunch of linux distros that are using an older version of cmake


According to cmakes online docs this was added in version 3.7.

As a distro data point: OpenSUSE 42.3 (the current version) ships with
cmake 3.5.2.


MGri
-- 
Mathias Grimmberger 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

[Carsten Schoenert]

Hello Rene,

Am 22.03.18 um 15:13 schrieb Rene Pöschl:
> Dear developers,
> 
> we lib maintainers might be good at checking symbols and footprints 
> against datasheets, the KLC and industry standards but we are a bit lost 
> with the requirements of installation scripts.
> 
> Could one of you take a look at the changes in the following pull requests?
> 
> 
> - https://github.com/KiCad/kicad-packages3D/pull/284

the last part of the issue in the PR I already mentioned by

https://github.com/KiCad/kicad-packages3D/issues/270

The PR from metacollin is trying to solve two different problems and
isn't a atomic PR by this.

-- 
Regards
Carsten Schoenert

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

[Bernhard Stegmaier]

What do you mean with “Xcode to build KiCad” (or, what do you want to do)?
Usually KiCad is built with clang from Xcode, so yes.

Xcode itself is only an IDE.
You definitely can use Xcode to edit source files or to debug KiCad built with 
usual cmake command line (just create an “empty" project which points to the 
binary).

I guess there is some way to tell Xcode to call an external builder (cmake) 
instead of managing building itself, but I never tried that.
You also could try to generate a Xcode project with cmake, but I also never 
tried that.

If you just want a free IDE the easy way, try QTCreator (due to its cmake 
support)...


Regards,
Bernhard

> On 22. Mar 2018, at 16:59, Jean-Paul Louis  wrote:
> 
> I Have a question for the OS X developers here.
> Are you using Xcode to build KiCAD? 
> I would like to get started on building KiCAD with Xcode, 
> so I am looking for some clues or advice if this is not
> possible/practical.
> 
> Thanks to all of you for a great product.
> 
> Jean-Paul
> N1JPL
> 
> 
>> On Mar 22, 2018, at 11:46 AM, Adam Wolf  
>> wrote:
>> 
>> This will break the nightlies for macOS, as the packaging scripts
>> currently work around the fact that they didn't previously work on
>> macOS with modifications.
>> 
>> Is this something Nick or I can adjust the current nightlies to over
>> the weekend, and then we make the cutover in the middle of next week?
>> 
>> Another option is that we just make the cutover now, and a few nights
>> of nightlies break.
>> 
>> Normally I'd be able to just make the change right away but I'm
>> spending all of my KiCad time trying to get the new macOS packaging
>> ready so I don't hold up V5.
>> 
>> Adam
>> 
>> On Thu, Mar 22, 2018 at 10:39 AM, Seth Hillbrand
>>  wrote:
>>> CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT is a relatively recent addition
>>> to cmake.  Maybe 3.7 or so?  I'd hesitate using that in the install script
>>> yet but maybe that's overly cautious.  If you do use it, we need to bump the
>>> minimum version at the top as well.
>>> 
>>> -S
>>> 
>>> 
>>> 2018-03-22 7:20 GMT-07:00 Wayne Stambaugh :
 
 Looks fine to me but I would like one of our macos packagers to confirm
 the install path changes that are specific to macos before we merge them.
 
 On 3/22/2018 10:13 AM, Rene Pöschl wrote:
> Dear developers,
> 
> we lib maintainers might be good at checking symbols and footprints
> against datasheets, the KLC and industry standards but we are a bit lost
> with the requirements of installation scripts.
> 
> Could one of you take a look at the changes in the following pull
> requests?
> 
> 
> - https://github.com/KiCad/kicad-packages3D/pull/284
> 
> - https://github.com/KiCad/kicad-symbols/pull/409
> 
> - https://github.com/KiCad/kicad-footprints/pull/450
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
 
 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp
>>> 
>>> 
>>> 
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>> 
>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

[Jean-Paul Louis]

I Have a question for the OS X developers here.
Are you using Xcode to build KiCAD? 
I would like to get started on building KiCAD with Xcode, 
so I am looking for some clues or advice if this is not
possible/practical.

Thanks to all of you for a great product.

Jean-Paul
N1JPL


> On Mar 22, 2018, at 11:46 AM, Adam Wolf  wrote:
> 
> This will break the nightlies for macOS, as the packaging scripts
> currently work around the fact that they didn't previously work on
> macOS with modifications.
> 
> Is this something Nick or I can adjust the current nightlies to over
> the weekend, and then we make the cutover in the middle of next week?
> 
> Another option is that we just make the cutover now, and a few nights
> of nightlies break.
> 
> Normally I'd be able to just make the change right away but I'm
> spending all of my KiCad time trying to get the new macOS packaging
> ready so I don't hold up V5.
> 
> Adam
> 
> On Thu, Mar 22, 2018 at 10:39 AM, Seth Hillbrand
>  wrote:
>> CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT is a relatively recent addition
>> to cmake.  Maybe 3.7 or so?  I'd hesitate using that in the install script
>> yet but maybe that's overly cautious.  If you do use it, we need to bump the
>> minimum version at the top as well.
>> 
>> -S
>> 
>> 
>> 2018-03-22 7:20 GMT-07:00 Wayne Stambaugh :
>>> 
>>> Looks fine to me but I would like one of our macos packagers to confirm
>>> the install path changes that are specific to macos before we merge them.
>>> 
>>> On 3/22/2018 10:13 AM, Rene Pöschl wrote:
 Dear developers,
 
 we lib maintainers might be good at checking symbols and footprints
 against datasheets, the KLC and industry standards but we are a bit lost
 with the requirements of installation scripts.
 
 Could one of you take a look at the changes in the following pull
 requests?
 
 
 - https://github.com/KiCad/kicad-packages3D/pull/284
 
 - https://github.com/KiCad/kicad-symbols/pull/409
 
 - https://github.com/KiCad/kicad-footprints/pull/450
 
 
 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp
>>> 
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>> 
>> 
>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

[Wayne Stambaugh]

If someone would pin down the exact version of cmake where this
available, I would appreciated it.  My benchmark (Debian stable) is
currently shipping with 3.7.2 although that seems like a pretty current
version.  I don't want to bump the cmake version too high and drop a
bunch of linux distros that are using an older version of cmake

On 3/22/2018 11:39 AM, Seth Hillbrand wrote:
> ​CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT​ is a relatively recent
> addition to cmake.  Maybe 3.7 or so?  I'd hesitate using that in the
> install script yet but maybe that's overly cautious.  If you do use it,
> we need to bump the minimum version at the top as well.
> 
> -S
> 
> 
> 2018-03-22 7:20 GMT-07:00 Wayne Stambaugh  >:
> 
> Looks fine to me but I would like one of our macos packagers to confirm
> the install path changes that are specific to macos before we merge
> them.
> 
> On 3/22/2018 10:13 AM, Rene Pöschl wrote:
> > Dear developers,
> >
> > we lib maintainers might be good at checking symbols and footprints
> > against datasheets, the KLC and industry standards but we are a
> bit lost
> > with the requirements of installation scripts.
> >
> > Could one of you take a look at the changes in the following pull
> requests?
> >
> >
> > - https://github.com/KiCad/kicad-packages3D/pull/284
> 
> >
> > - https://github.com/KiCad/kicad-symbols/pull/409
> 
> >
> > - https://github.com/KiCad/kicad-footprints/pull/450
> 
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> 
> > Post to : kicad-developers@lists.launchpad.net
> 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> 
> > More help   : https://help.launchpad.net/ListHelp
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

[Adam Wolf]

This will break the nightlies for macOS, as the packaging scripts
currently work around the fact that they didn't previously work on
macOS with modifications.

Is this something Nick or I can adjust the current nightlies to over
the weekend, and then we make the cutover in the middle of next week?

Another option is that we just make the cutover now, and a few nights
of nightlies break.

Normally I'd be able to just make the change right away but I'm
spending all of my KiCad time trying to get the new macOS packaging
ready so I don't hold up V5.

Adam

On Thu, Mar 22, 2018 at 10:39 AM, Seth Hillbrand
 wrote:
> CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT is a relatively recent addition
> to cmake.  Maybe 3.7 or so?  I'd hesitate using that in the install script
> yet but maybe that's overly cautious.  If you do use it, we need to bump the
> minimum version at the top as well.
>
> -S
>
>
> 2018-03-22 7:20 GMT-07:00 Wayne Stambaugh :
>>
>> Looks fine to me but I would like one of our macos packagers to confirm
>> the install path changes that are specific to macos before we merge them.
>>
>> On 3/22/2018 10:13 AM, Rene Pöschl wrote:
>> > Dear developers,
>> >
>> > we lib maintainers might be good at checking symbols and footprints
>> > against datasheets, the KLC and industry standards but we are a bit lost
>> > with the requirements of installation scripts.
>> >
>> > Could one of you take a look at the changes in the following pull
>> > requests?
>> >
>> >
>> > - https://github.com/KiCad/kicad-packages3D/pull/284
>> >
>> > - https://github.com/KiCad/kicad-symbols/pull/409
>> >
>> > - https://github.com/KiCad/kicad-footprints/pull/450
>> >
>> >
>> > ___
>> > Mailing list: https://launchpad.net/~kicad-developers
>> > Post to : kicad-developers@lists.launchpad.net
>> > Unsubscribe : https://launchpad.net/~kicad-developers
>> > More help   : https://help.launchpad.net/ListHelp
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

[Seth Hillbrand]

​CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT​ is a relatively recent
addition to cmake.  Maybe 3.7 or so?  I'd hesitate using that in the
install script yet but maybe that's overly cautious.  If you do use it, we
need to bump the minimum version at the top as well.

-S


2018-03-22 7:20 GMT-07:00 Wayne Stambaugh :

> Looks fine to me but I would like one of our macos packagers to confirm
> the install path changes that are specific to macos before we merge them.
>
> On 3/22/2018 10:13 AM, Rene Pöschl wrote:
> > Dear developers,
> >
> > we lib maintainers might be good at checking symbols and footprints
> > against datasheets, the KLC and industry standards but we are a bit lost
> > with the requirements of installation scripts.
> >
> > Could one of you take a look at the changes in the following pull
> requests?
> >
> >
> > - https://github.com/KiCad/kicad-packages3D/pull/284
> >
> > - https://github.com/KiCad/kicad-symbols/pull/409
> >
> > - https://github.com/KiCad/kicad-footprints/pull/450
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

[Wayne Stambaugh]

Looks fine to me but I would like one of our macos packagers to confirm
the install path changes that are specific to macos before we merge them.

On 3/22/2018 10:13 AM, Rene Pöschl wrote:
> Dear developers,
> 
> we lib maintainers might be good at checking symbols and footprints
> against datasheets, the KLC and industry standards but we are a bit lost
> with the requirements of installation scripts.
> 
> Could one of you take a look at the changes in the following pull requests?
> 
> 
> - https://github.com/KiCad/kicad-packages3D/pull/284
> 
> - https://github.com/KiCad/kicad-symbols/pull/409
> 
> - https://github.com/KiCad/kicad-footprints/pull/450
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp