Re: [Kicad-developers] Merge schedule
Jeff, I can't think of any reason not to clean up the SCH_ and LIB_ Draw() routines unless I'm missing something. It might be useful to merge this to the 5.1 branch once it is proven to be stable. This will help keep merge conflicts to a minimum. Wayne On 4/5/19 6:09 AM, Jeff Young wrote: > I’ve got a changelist which cleans up the various SCH_ and LIB_ Draw() > routines to remove the interactivity features (since they’re now print-only). > > Should I merge it now? > > Cheers, > Jeff. > > https://git.launchpad.net/~jeyjey/kicad/commit/?id=ef6b71b3335080a5e3c4cd98e70d42f2f8f1132f > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Merge schedule
On 05/04/2019 12:09, Jeff Young wrote: > I’ve got a changelist which cleans up the various SCH_ and LIB_ Draw() > routines to remove the interactivity features (since they’re now print-only). > Hi all, Since we're discussing merging again, may I push my Crash Reporter patch (touches mostly kiface/single_top stuff, that I guess no one is working at for the moment)? Cheers, Tom ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Merge schedule
Hi Tomasz I was wondering about this yesterday. Has it even been merged on master? I think I would prefer not to merge it on stable if it has not even been tested on master, but if you think it is low risk I guess it is ok. As I have not tested it I don't know what it looks like, but if you think it makes sense, maybe we should write a small note about users to include the output of it if they see crashes? Nick On Mon, 8 Apr 2019 at 13:35, Tomasz Wlostowski wrote: > On 05/04/2019 12:09, Jeff Young wrote: > > I’ve got a changelist which cleans up the various SCH_ and LIB_ Draw() > routines to remove the interactivity features (since they’re now > print-only). > > > > Hi all, > > Since we're discussing merging again, may I push my Crash Reporter patch > (touches mostly kiface/single_top stuff, that I guess no one is working > at for the moment)? > > Cheers, > Tom > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Merge schedule
Tom, On 4/8/2019 7:34 AM, Tomasz Wlostowski wrote: > On 05/04/2019 12:09, Jeff Young wrote: >> I’ve got a changelist which cleans up the various SCH_ and LIB_ Draw() >> routines to remove the interactivity features (since they’re now print-only). >> > > Hi all, > > Since we're discussing merging again, may I push my Crash Reporter patch > (touches mostly kiface/single_top stuff, that I guess no one is working > at for the moment)? AFAIK, no one is doing any work on kiface/single_top at the moment so you should be safe merging this into the master branch. If this is going to be an issue for anyone else, please speak up so we can make a decision on how best to minimize merge conflicts. Let's hold off merging it into 5.1 until we get some testing to see how reliable it's going to be. Once it's stable, I would like to get this into 5.1 for some future 5.1 bug release. Even though we typically don't add new features to stable branches, it may be worth violating that policy to get bug reporting feature to as many users as possible. Wayne > > Cheers, > Tom > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Merge schedule
On 08/04/2019 13:58, Nick Østergaard wrote: > Hi Tomasz > > I was wondering about this yesterday. Has it even been merged on master? > > I think I would prefer not to merge it on stable Hi Nick, I don't plan to merge it to any stable release anytime soon. I meant the nightlies... Cheers, Tom ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Merge schedule
Ok, cool. I guess we all agree to merge it on master :) man. 8. apr. 2019 16.45 skrev Tomasz Wlostowski : > On 08/04/2019 13:58, Nick Østergaard wrote: > > Hi Tomasz > > > > I was wondering about this yesterday. Has it even been merged on master? > > > > I think I would prefer not to merge it on stable > > Hi Nick, > > I don't plan to merge it to any stable release anytime soon. I meant the > nightlies... > > Cheers, > Tom > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
