Re: [Kicad-developers] Zones 45 degree

2019-06-24 Thread Jeff Young
It will also need a bit of a tweak.  If the zone boundary covers an odd number 
of grid points the center point will be inter-grid.  Dragging it needs to leave 
it there, not snap to one or the other grid points to either side.


> On 24 Jun 2019, at 14:07, Tomasz Wlostowski  wrote:
> 
> On 24/06/2019 15:05, Wayne Stambaugh wrote:
> 
>> The geometric constraint solver will be the solution for v6 but this
>> still leaves us with the issue of what to do for the 5.1 branch. 
> 
> Hi Wayne,
> 
> I didn't notice it's for v5.1.x branch. In this case, Seth solution is
> perfectly OK.
> 
> Tom
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Zones 45 degree

2019-06-24 Thread Tomasz Wlostowski
On 24/06/2019 15:05, Wayne Stambaugh wrote:

> The geometric constraint solver will be the solution for v6 but this
> still leaves us with the issue of what to do for the 5.1 branch. 

Hi Wayne,

I didn't notice it's for v5.1.x branch. In this case, Seth solution is
perfectly OK.

Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Zones 45 degree

2019-06-24 Thread Wayne Stambaugh
Tom,

On 6/24/19 5:57 AM, Tomasz Wlostowski wrote:
> On 24/06/2019 11:50, Simon Richter wrote:
>> Hi,
>>
>> On Mon, Jun 24, 2019 at 12:43:47AM -0400, Seth Hillbrand wrote:
>>
>>> 1) a double-joint in the final connection
>>
>> Hm, that might be an interesting creation mode: draw the outline as if it
>> were a trace.
>>
>> I'm not entirely convinced that there are many use cases for that though.
> 
> Hi,
> 
> This is coming in the geometric constraint solver work package...
> 
> Tom

The geometric constraint solver will be the solution for v6 but this
still leaves us with the issue of what to do for the 5.1 branch.  I
believe that this bug has indeed been around since this was implemented.
 I guess the question is what to do about it?  Since the constraint
solver hasn't been merged into the master branch, I'm guessing that
fixing this in the master branch should be fairly easily cherry-picked
into the 5.1 branch.

I like Seth's "disabling end-point dragging in the outline - only
center-point dragging and with the Alternate constraint fixed on"
proposal as a fix.  It been a while but I'm pretty sure the intent of
the 45 degree zone setting was to always maintain the constraint not
just when the zone was created.

Cheers,

Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Zones 45 degree

2019-06-24 Thread Tomasz Wlostowski
On 24/06/2019 11:50, Simon Richter wrote:
> Hi,
> 
> On Mon, Jun 24, 2019 at 12:43:47AM -0400, Seth Hillbrand wrote:
> 
>> 1) a double-joint in the final connection
> 
> Hm, that might be an interesting creation mode: draw the outline as if it
> were a trace.
> 
> I'm not entirely convinced that there are many use cases for that though.

Hi,

This is coming in the geometric constraint solver work package...

Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Zones 45 degree

2019-06-24 Thread Simon Richter
Hi,

On Mon, Jun 24, 2019 at 12:43:47AM -0400, Seth Hillbrand wrote:

> 1) a double-joint in the final connection

Hm, that might be an interesting creation mode: draw the outline as if it
were a trace.

I'm not entirely convinced that there are many use cases for that though.

   Simon

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Zones 45 degree

2019-06-24 Thread Jeff Young
I think the final segment issue has always been a bug.

There’s a bunch of constraint code in the POINT_EDITOR, so I think it’s *meant* 
to work while editing a zone.  (The code includes both single-point constraints 
and two-point constraints, but I haven’t ever dug into it to see what they do.)

Cheers,
Jeff.


> On 24 Jun 2019, at 05:43, Seth Hillbrand  wrote:
> 
> Hi All-
> 
> This bug report [1] notes that the "Constrain zone to 90/45" option only 
> works during zone creation.  The option also doesn't constrain the final 
> angle.
> 
> I note that this option is stored in the file format, so it seems the 
> intention was for it to be persistent.  Anyone have some more background on 
> this option?  Did it work in the legacy canvas?
> 
> I'm thinking that fixing the bug requires two things:
> 
> 1) a double-joint in the final connection
> 2) disabling end-point dragging in the outline - only center-point dragging 
> and with the Alternate constraint fixed on.
> 
> What do folks think?
> 
> -Seth
> 
> [1] https://bugs.launchpad.net/kicad/+bug/1833673
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp