Re: [Kicad-developers] version info does not get updated
Le 02/09/2014 18:24, Wayne Stambaugh a écrit : I have this on my list of things to look at. It should be possible to get CMake to generate make files that compare the source repo version against the version.h file and recreate it as required every time make is run. Currently, the only time version.h gets updated is when the CMake files are modified or make rebuild_cache is run. I checked it right now : I added make rebuild-dep to beginning of the build process in kicad-install.sh. Running it with a kicad install witj not up to date version info results in rebuilding only build_version.cpp and relinking all parts that have a user interface. And then I runt the install script again with the version I've just updated : Cmake regenerated the files (pretty fast), and then all steps completed and nothing was compiled. So I think there is no need to check for current version number before calling make rebuild-dep as it does not takes more times if not needed. Well in fact I think nothing was re-compiled because the date was the same and so files are identical. But as it is *very* unlikely that if the date as changed the version has not, I still think there is no need for version checking. regards, yann ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] version info does not get updated
On 9/3/2014 8:08 AM, yann jautard wrote: Le 03/09/2014 12:32, yann jautard a écrit : Le 02/09/2014 18:24, Wayne Stambaugh a écrit : I have this on my list of things to look at. It should be possible to get CMake to generate make files that compare the source repo version against the version.h file and recreate it as required every time make is run. Currently, the only time version.h gets updated is when the CMake files are modified or make rebuild_cache is run. I checked it right now : I added make rebuild-dep to beginning of the build process in kicad-install.sh. Running it with a kicad install witj not up to date version info results in rebuilding only build_version.cpp and relinking all parts that have a user interface. Rebuilding the dependencies is not what you want to do if all you are trying to do is update the version string. This will not only rebuild the dependency libraries but all of kicad as well. Use `make rebuild_cache` to refresh the version string. This way only version.cpp will get recompiled and the only the binaries which depend on it will get relinked. And then I runt the install script again with the version I've just updated : Cmake regenerated the files (pretty fast), and then all steps completed and nothing was compiled. So I think there is no need to check for current version number before calling make rebuild-dep as it does not takes more times if not needed. Well in fact I think nothing was re-compiled because the date was the same and so files are identical. But as it is *very* unlikely that if the date as changed the version has not, I still think there is no need for version checking. I noticed also that the build step is done twice : the first time when compiling, then it is done again before installing. Without compiling anything more of course because it was already done, but that take a lot of time. This should not happen. Once make is called and kicad is completely build, calling make install will check to make sure everything is built before installing. I have never seen `make install` rebuild the entire source tree after calling `make`. I checked : calling directly make install on source tree with compilation not done will build then install and the resulting installation works ok, without unneeded extra steps. So I wonder why calling build steps twice ? If that is because it is not ok to build as root (and make install should be run as root), then why the install target first check if everything is built ? To make sure not trying to install something incomplete ? I modified my kicad-install.sh to add make rebuild-dep and remove the first make, everything still works OK, and the version info in built kicad is up to date. It can sound stupid, but the only computer I have now is a netbook. So as it's really slow, I'm trying to avoid any unneeded step :P I've never used use the install script so maybe someone else who uses it can help you out. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] version info does not get updated
Le 03/09/2014 20:08, Wayne Stambaugh a écrit : On 9/3/2014 8:08 AM, yann jautard wrote: Le 03/09/2014 12:32, yann jautard a écrit : Le 02/09/2014 18:24, Wayne Stambaugh a écrit : I have this on my list of things to look at. It should be possible to get CMake to generate make files that compare the source repo version against the version.h file and recreate it as required every time make is run. Currently, the only time version.h gets updated is when the CMake files are modified or make rebuild_cache is run. I checked it right now : I added make rebuild-dep to beginning of the build process in kicad-install.sh. Running it with a kicad install witj not up to date version info results in rebuilding only build_version.cpp and relinking all parts that have a user interface. Rebuilding the dependencies is not what you want to do if all you are trying to do is update the version string. (...) yes of course that was rebuild_cache, I made a mistake writing the mail. So as you said you want to get Cmake to compare the version with the one in the file, I'm pretty sure it is not necessary. Just calling make rebuild_cache before make do the job pretty well. I think the kicad-install.sh script could be updated to add this make rebuild_cache step before compilation. That way you will be sure version is updated each time, and bug reports by guys like me will be accurate. (...) I noticed also that the build step is done twice : the first time when compiling, then it is done again before installing. Without compiling anything more of course because it was already done, but that take a lot of time. This should not happen. Once make is called and kicad is completely build, calling make install will check to make sure everything is built before installing. Yes maybe this is what happens, just checking. But just checking is quite long. When calling make install directly, it checks, and as it is not already built, it build and then install, all in one single step. Faster on little systems. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] version info does not get updated
On 3 September 2014 20:04, yann jautard brico...@free.fr wrote: Le 03/09/2014 20:08, Wayne Stambaugh a écrit : On 9/3/2014 8:08 AM, yann jautard wrote: Le 03/09/2014 12:32, yann jautard a écrit : Le 02/09/2014 18:24, Wayne Stambaugh a écrit : I have this on my list of things to look at. It should be possible to get CMake to generate make files that compare the source repo version against the version.h file and recreate it as required every time make is run. Currently, the only time version.h gets updated is when the CMake files are modified or make rebuild_cache is run. I checked it right now : I added make rebuild-dep to beginning of the build process in kicad-install.sh. Running it with a kicad install witj not up to date version info results in rebuilding only build_version.cpp and relinking all parts that have a user interface. Rebuilding the dependencies is not what you want to do if all you are trying to do is update the version string. (...) yes of course that was rebuild_cache, I made a mistake writing the mail. So as you said you want to get Cmake to compare the version with the one in the file, I'm pretty sure it is not necessary. Just calling make rebuild_cache before make do the job pretty well. I think the kicad-install.sh script could be updated to add this make rebuild_cache step before compilation. That way you will be sure version is updated each time, and bug reports by guys like me will be accurate. This is where the problem lies if you install with this script and it doesn't rebuild_cache on an existing source tree. Winbuilder does this at the start of each run to keep the version information up-to-date. IMO the versioning we're using is fine just the way it is. Best Regards, Brian. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] version info does not get updated
On 9/3/2014 3:04 PM, yann jautard wrote: Le 03/09/2014 20:08, Wayne Stambaugh a écrit : On 9/3/2014 8:08 AM, yann jautard wrote: Le 03/09/2014 12:32, yann jautard a écrit : Le 02/09/2014 18:24, Wayne Stambaugh a écrit : I have this on my list of things to look at. It should be possible to get CMake to generate make files that compare the source repo version against the version.h file and recreate it as required every time make is run. Currently, the only time version.h gets updated is when the CMake files are modified or make rebuild_cache is run. I checked it right now : I added make rebuild-dep to beginning of the build process in kicad-install.sh. Running it with a kicad install witj not up to date version info results in rebuilding only build_version.cpp and relinking all parts that have a user interface. Rebuilding the dependencies is not what you want to do if all you are trying to do is update the version string. (...) yes of course that was rebuild_cache, I made a mistake writing the mail. So as you said you want to get Cmake to compare the version with the one in the file, I'm pretty sure it is not necessary. Just calling make rebuild_cache before make do the job pretty well. This is not the optimal solution. Using rebuild_cache will update version.h even if the repo has not changed and cause unnecessary build and link steps. It's fine as a quick fix but the correct solution is to have CMake generate the appropriate make file steps to test if there is any change to the version string and regenerate version.h accordingly. I think the kicad-install.sh script could be updated to add this make rebuild_cache step before compilation. That way you will be sure version is updated each time, and bug reports by guys like me will be accurate. (...) I noticed also that the build step is done twice : the first time when compiling, then it is done again before installing. Without compiling anything more of course because it was already done, but that take a lot of time. This should not happen. Once make is called and kicad is completely build, calling make install will check to make sure everything is built before installing. Yes maybe this is what happens, just checking. But just checking is quite long. When calling make install directly, it checks, and as it is not already built, it build and then install, all in one single step. Faster on little systems. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] version info does not get updated
Le 03/09/2014 22:27, Brian Sidebotham a écrit : On 3 September 2014 20:04, yann jautard brico...@free.fr wrote: Le 03/09/2014 20:08, Wayne Stambaugh a écrit : On 9/3/2014 8:08 AM, yann jautard wrote: Le 03/09/2014 12:32, yann jautard a écrit : Le 02/09/2014 18:24, Wayne Stambaugh a écrit : I have this on my list of things to look at. It should be possible to get CMake to generate make files that compare the source repo version against the version.h file and recreate it as required every time make is run. Currently, the only time version.h gets updated is when the CMake files are modified or make rebuild_cache is run. I checked it right now : I added make rebuild-dep to beginning of the build process in kicad-install.sh. Running it with a kicad install witj not up to date version info results in rebuilding only build_version.cpp and relinking all parts that have a user interface. Rebuilding the dependencies is not what you want to do if all you are trying to do is update the version string. (...) yes of course that was rebuild_cache, I made a mistake writing the mail. So as you said you want to get Cmake to compare the version with the one in the file, I'm pretty sure it is not necessary. Just calling make rebuild_cache before make do the job pretty well. I think the kicad-install.sh script could be updated to add this make rebuild_cache step before compilation. That way you will be sure version is updated each time, and bug reports by guys like me will be accurate. This is where the problem lies if you install with this script and it doesn't rebuild_cache on an existing source tree. Yes, exactly, so I think pretty much kicads around installed by the way of the script have not a version info that reflects the real code version, as the script don't do that. Winbuilder does this at the start of each run to keep the version information up-to-date. IMO the versioning we're using is fine just the way it is. Best Regards, Brian. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] version info does not get updated
Le 03/09/2014 22:48, Wayne Stambaugh a écrit : On 9/3/2014 3:04 PM, yann jautard wrote: Le 03/09/2014 20:08, Wayne Stambaugh a écrit : On 9/3/2014 8:08 AM, yann jautard wrote: Le 03/09/2014 12:32, yann jautard a écrit : Le 02/09/2014 18:24, Wayne Stambaugh a écrit : I have this on my list of things to look at. It should be possible to get CMake to generate make files that compare the source repo version against the version.h file and recreate it as required every time make is run. Currently, the only time version.h gets updated is when the CMake files are modified or make rebuild_cache is run. I checked it right now : I added make rebuild-dep to beginning of the build process in kicad-install.sh. Running it with a kicad install witj not up to date version info results in rebuilding only build_version.cpp and relinking all parts that have a user interface. Rebuilding the dependencies is not what you want to do if all you are trying to do is update the version string. (...) yes of course that was rebuild_cache, I made a mistake writing the mail. So as you said you want to get Cmake to compare the version with the one in the file, I'm pretty sure it is not necessary. Just calling make rebuild_cache before make do the job pretty well. This is not the optimal solution. Using rebuild_cache will update version.h even if the repo has not changed and cause unnecessary build and link steps. It's fine as a quick fix but the correct solution is to have CMake generate the appropriate make file steps to test if there is any change to the version string and regenerate version.h accordingly. Sure it is not optimal. But considering the fact that there usually are several commits each day, I'm pretty confident it will not introduce unnecessary builds too often. And even if it does, the only recompiled file is build_version.cpp, and linking steps are almost as fast as just checking if there is something to build. So it is not a real problem. At east for me, even on my netbook I can live with that :) What about some shell magic inside the build script that compares the version number in version.h with the output of bzr revno ? Will not it be easier to do than some similar Cmake stuff ? ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] version info does not get updated
On 9/3/2014 5:37 PM, yann jautard wrote: Le 03/09/2014 22:48, Wayne Stambaugh a écrit : On 9/3/2014 3:04 PM, yann jautard wrote: Le 03/09/2014 20:08, Wayne Stambaugh a écrit : On 9/3/2014 8:08 AM, yann jautard wrote: Le 03/09/2014 12:32, yann jautard a écrit : Le 02/09/2014 18:24, Wayne Stambaugh a écrit : I have this on my list of things to look at. It should be possible to get CMake to generate make files that compare the source repo version against the version.h file and recreate it as required every time make is run. Currently, the only time version.h gets updated is when the CMake files are modified or make rebuild_cache is run. I checked it right now : I added make rebuild-dep to beginning of the build process in kicad-install.sh. Running it with a kicad install witj not up to date version info results in rebuilding only build_version.cpp and relinking all parts that have a user interface. Rebuilding the dependencies is not what you want to do if all you are trying to do is update the version string. (...) yes of course that was rebuild_cache, I made a mistake writing the mail. So as you said you want to get Cmake to compare the version with the one in the file, I'm pretty sure it is not necessary. Just calling make rebuild_cache before make do the job pretty well. This is not the optimal solution. Using rebuild_cache will update version.h even if the repo has not changed and cause unnecessary build and link steps. It's fine as a quick fix but the correct solution is to have CMake generate the appropriate make file steps to test if there is any change to the version string and regenerate version.h accordingly. Sure it is not optimal. But considering the fact that there usually are several commits each day, I'm pretty confident it will not introduce unnecessary builds too often. And even if it does, the only recompiled file is build_version.cpp, and linking steps are almost as fast as just checking if there is something to build. So it is not a real problem. At east for me, even on my netbook I can live with that :) What about some shell magic inside the build script that compares the version number in version.h with the output of bzr revno ? Will not it be easier to do than some similar Cmake stuff ? The magic is inside the build scripts generated by CMake not the external kicad-install.sh which is primarily for users. I would not consider adding the version string check to kicad-install.sh an acceptable solution. Developers should be using CMake to generate the make files and calling make to build KiCad. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] version info does not get updated
On 8/31/2014 6:09 PM, Brian Sidebotham wrote: On 31 August 2014 22:52, Andrew Zonenberg azonenb...@drawersteak.com wrote: What I did in my previous build systems is to regenerate the file in a temporary directory then check if the files had the same hash. If they didn't I'd update the file. This way, if you don't change the file's contents it doesn't get touched and nothign else gets rebuilt. Yeah, everything's possible, but when you're doing local commits you're still going to get needless compilation and relinking because the bzr rev number has changed. Generally the bzr revno is a bit of a pain for developers if you commit often but useful for everyone else. I guess someone could improve the situation if they had the time, but re-compilation and re-linking everytime would be a bit of a step backwards. Best Regards, Brian. I have this on my list of things to look at. It should be possible to get CMake to generate make files that compare the source repo version against the version.h file and recreate it as required every time make is run. Currently, the only time version.h gets updated is when the CMake files are modified or make rebuild_cache is run. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] version info does not get updated
That just looks like it did not update. What is the REVISION variable set to in the sript? It should be $TESTING, where that is last:1. 2014-08-31 18:12 GMT+02:00 yann jautard brico...@free.fr: Hi all, I don't know if this is important, but I just updated my kicad install this afternoon, and I noticed the kicad version information is not up to date : yann@yann-netbook:~/kicad_sources$ ./kicad-install.sh --install-or-update (...) step 3) checking out the source code from launchpad repo... Tree is up to date at revision *5106* of branch http://bazaar.launchpad.net/~kicad-product-committers/kicad/product local source working tree updated. (...) All KiCad --install-or-update steps completed, you are up to date. and then, the kicad windows says this : Application: kicad Version: (*2014-08-26 BZR 5099*)-product Release build wxWidgets: Version 3.0.0 (debug,wchar_t,compiler with C++ ABI 1002,GCC 4.8.2,wx containers,compatible with 2.8) Platform: Linux 3.13.0-35-generic i686, 32 bit, Little endian, wxGTK Boost version: 1.54.0 USE_WX_GRAPHICS_CONTEXT=OFF USE_WX_OVERLAY=OFF KICAD_SCRIPTING=OFF KICAD_SCRIPTING_MODULES=OFF KICAD_SCRIPTING_WXPYTHON=OFF USE_FP_LIB_TABLE=HARD_CODED_ON BUILD_GITHUB_PLUGIN=ON you can see the compilation date is wrong (we are the 14 08 31) and the version number is wrong. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] version info does not get updated
Hi Yann Does 'bzr revno --tree' result in the same? 2014-08-31 20:21 GMT+02:00 yann jautard brico...@free.fr: REVISION is set to TESTING, I use the script daily, it's the first time I notice something like that. the result of bzr log in my kicad source tree starts by : revno: 5106 fixes bug: https://launchpad.net/bugs/1035151 committer: Wayne Stambaugh stambau...@verizon.net branch nick: kicad timestamp: Fri 2014-08-29 16:23:40 -0400 so it updated the source correctly. And considering the number of files that has be recompiled, it updated something in the bin files. Le 31/08/2014 19:38, Nick Østergaard a écrit : That just looks like it did not update. What is the REVISION variable set to in the sript? It should be $TESTING, where that is last:1. 2014-08-31 18:12 GMT+02:00 yann jautard brico...@free.fr: Hi all, I don't know if this is important, but I just updated my kicad install this afternoon, and I noticed the kicad version information is not up to date : yann@yann-netbook:~/kicad_sources$ ./kicad-install.sh --install-or-update (...) step 3) checking out the source code from launchpad repo... Tree is up to date at revision *5106* of branch http://bazaar.launchpad.net/~kicad-product-committers/kicad/product local source working tree updated. (...) All KiCad --install-or-update steps completed, you are up to date. and then, the kicad windows says this : Application: kicad Version: (*2014-08-26 BZR 5099*)-product Release build wxWidgets: Version 3.0.0 (debug,wchar_t,compiler with C++ ABI 1002,GCC 4.8.2,wx containers,compatible with 2.8) Platform: Linux 3.13.0-35-generic i686, 32 bit, Little endian, wxGTK Boost version: 1.54.0 USE_WX_GRAPHICS_CONTEXT=OFF USE_WX_OVERLAY=OFF KICAD_SCRIPTING=OFF KICAD_SCRIPTING_MODULES=OFF KICAD_SCRIPTING_WXPYTHON=OFF USE_FP_LIB_TABLE=HARD_CODED_ON BUILD_GITHUB_PLUGIN=ON you can see the compilation date is wrong (we are the 14 08 31) and the version number is wrong. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] version info does not get updated
I've observed the same issue with my builds. The only workaround I've found to date is to delete the build directory and do a full rebuild. On Sun, 2014-08-31 at 20:56 +0200, Nick Østergaard wrote: Hi Yann Does 'bzr revno --tree' result in the same? 2014-08-31 20:21 GMT+02:00 yann jautard brico...@free.fr: REVISION is set to TESTING, I use the script daily, it's the first time I notice something like that. the result of bzr log in my kicad source tree starts by : revno: 5106 fixes bug: https://launchpad.net/bugs/1035151 committer: Wayne Stambaugh stambau...@verizon.net branch nick: kicad timestamp: Fri 2014-08-29 16:23:40 -0400 so it updated the source correctly. And considering the number of files that has be recompiled, it updated something in the bin files. Le 31/08/2014 19:38, Nick Østergaard a écrit : That just looks like it did not update. What is the REVISION variable set to in the sript? It should be $TESTING, where that is last:1. 2014-08-31 18:12 GMT+02:00 yann jautard brico...@free.fr: Hi all, I don't know if this is important, but I just updated my kicad install this afternoon, and I noticed the kicad version information is not up to date : yann@yann-netbook:~/kicad_sources$ ./kicad-install.sh --install-or-update (...) step 3) checking out the source code from launchpad repo... Tree is up to date at revision *5106* of branch http://bazaar.launchpad.net/~kicad-product-committers/kicad/product local source working tree updated. (...) All KiCad --install-or-update steps completed, you are up to date. and then, the kicad windows says this : Application: kicad Version: (*2014-08-26 BZR 5099*)-product Release build wxWidgets: Version 3.0.0 (debug,wchar_t,compiler with C++ ABI 1002,GCC 4.8.2,wx containers,compatible with 2.8) Platform: Linux 3.13.0-35-generic i686, 32 bit, Little endian, wxGTK Boost version: 1.54.0 USE_WX_GRAPHICS_CONTEXT=OFF USE_WX_OVERLAY=OFF KICAD_SCRIPTING=OFF KICAD_SCRIPTING_MODULES=OFF KICAD_SCRIPTING_WXPYTHON=OFF USE_FP_LIB_TABLE=HARD_CODED_ON BUILD_GITHUB_PLUGIN=ON you can see the compilation date is wrong (we are the 14 08 31) and the version number is wrong. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp -- Andrew Zonenberg PhD student, security group Computer Science Department Rensselaer Polytechnic Institute http://colossus.cs.rpi.edu/~azonenberg/ signature.asc Description: This is a digitally signed message part ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] version info does not get updated
The version is essentially created during the CMake configure step - when CMake generates its cache of variables. You need to re-create this cache to update the value: make rebuild_cache That should update to the same as bzr revno. Best Regards, Brian. On 31 August 2014 21:47, Andrew Zonenberg azonenb...@drawersteak.com wrote: I've observed the same issue with my builds. The only workaround I've found to date is to delete the build directory and do a full rebuild. On Sun, 2014-08-31 at 20:56 +0200, Nick Østergaard wrote: Hi Yann Does 'bzr revno --tree' result in the same? 2014-08-31 20:21 GMT+02:00 yann jautard brico...@free.fr: REVISION is set to TESTING, I use the script daily, it's the first time I notice something like that. the result of bzr log in my kicad source tree starts by : revno: 5106 fixes bug: https://launchpad.net/bugs/1035151 committer: Wayne Stambaugh stambau...@verizon.net branch nick: kicad timestamp: Fri 2014-08-29 16:23:40 -0400 so it updated the source correctly. And considering the number of files that has be recompiled, it updated something in the bin files. Le 31/08/2014 19:38, Nick Østergaard a écrit : That just looks like it did not update. What is the REVISION variable set to in the sript? It should be $TESTING, where that is last:1. 2014-08-31 18:12 GMT+02:00 yann jautard brico...@free.fr: Hi all, I don't know if this is important, but I just updated my kicad install this afternoon, and I noticed the kicad version information is not up to date : yann@yann-netbook:~/kicad_sources$ ./kicad-install.sh --install-or-update (...) step 3) checking out the source code from launchpad repo... Tree is up to date at revision *5106* of branch http://bazaar.launchpad.net/~kicad-product-committers/kicad/product local source working tree updated. (...) All KiCad --install-or-update steps completed, you are up to date. and then, the kicad windows says this : Application: kicad Version: (*2014-08-26 BZR 5099*)-product Release build wxWidgets: Version 3.0.0 (debug,wchar_t,compiler with C++ ABI 1002,GCC 4.8.2,wx containers,compatible with 2.8) Platform: Linux 3.13.0-35-generic i686, 32 bit, Little endian, wxGTK Boost version: 1.54.0 USE_WX_GRAPHICS_CONTEXT=OFF USE_WX_OVERLAY=OFF KICAD_SCRIPTING=OFF KICAD_SCRIPTING_MODULES=OFF KICAD_SCRIPTING_WXPYTHON=OFF USE_FP_LIB_TABLE=HARD_CODED_ON BUILD_GITHUB_PLUGIN=ON you can see the compilation date is wrong (we are the 14 08 31) and the version number is wrong. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp -- Andrew Zonenberg PhD student, security group Computer Science Department Rensselaer Polytechnic Institute http://colossus.cs.rpi.edu/~azonenberg/ ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] version info does not get updated
Why does CMake not recompute this particular value during the pre-compile configuration step? It runs checks for changed stuff every time you make anyway and only caches certain things. Is it really that hard to not cache this particular value? On Sun, 2014-08-31 at 22:24 +0100, Brian Sidebotham wrote: The version is essentially created during the CMake configure step - when CMake generates its cache of variables. You need to re-create this cache to update the value: make rebuild_cache That should update to the same as bzr revno. Best Regards, Brian. On 31 August 2014 21:47, Andrew Zonenberg azonenb...@drawersteak.com wrote: I've observed the same issue with my builds. The only workaround I've found to date is to delete the build directory and do a full rebuild. On Sun, 2014-08-31 at 20:56 +0200, Nick Østergaard wrote: Hi Yann Does 'bzr revno --tree' result in the same? 2014-08-31 20:21 GMT+02:00 yann jautard brico...@free.fr: REVISION is set to TESTING, I use the script daily, it's the first time I notice something like that. the result of bzr log in my kicad source tree starts by : revno: 5106 fixes bug: https://launchpad.net/bugs/1035151 committer: Wayne Stambaugh stambau...@verizon.net branch nick: kicad timestamp: Fri 2014-08-29 16:23:40 -0400 so it updated the source correctly. And considering the number of files that has be recompiled, it updated something in the bin files. Le 31/08/2014 19:38, Nick Østergaard a écrit : That just looks like it did not update. What is the REVISION variable set to in the sript? It should be $TESTING, where that is last:1. 2014-08-31 18:12 GMT+02:00 yann jautard brico...@free.fr: Hi all, I don't know if this is important, but I just updated my kicad install this afternoon, and I noticed the kicad version information is not up to date : yann@yann-netbook:~/kicad_sources$ ./kicad-install.sh --install-or-update (...) step 3) checking out the source code from launchpad repo... Tree is up to date at revision *5106* of branch http://bazaar.launchpad.net/~kicad-product-committers/kicad/product local source working tree updated. (...) All KiCad --install-or-update steps completed, you are up to date. and then, the kicad windows says this : Application: kicad Version: (*2014-08-26 BZR 5099*)-product Release build wxWidgets: Version 3.0.0 (debug,wchar_t,compiler with C++ ABI 1002,GCC 4.8.2,wx containers,compatible with 2.8) Platform: Linux 3.13.0-35-generic i686, 32 bit, Little endian, wxGTK Boost version: 1.54.0 USE_WX_GRAPHICS_CONTEXT=OFF USE_WX_OVERLAY=OFF KICAD_SCRIPTING=OFF KICAD_SCRIPTING_MODULES=OFF KICAD_SCRIPTING_WXPYTHON=OFF USE_FP_LIB_TABLE=HARD_CODED_ON BUILD_GITHUB_PLUGIN=ON you can see the compilation date is wrong (we are the 14 08 31) and the version number is wrong. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp -- Andrew Zonenberg PhD student, security group Computer Science Department Rensselaer Polytechnic Institute http://colossus.cs.rpi.edu/~azonenberg/ ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp -- Andrew Zonenberg PhD student, security group Computer Science Department Rensselaer Polytechnic Institute http://colossus.cs.rpi.edu/~azonenberg/ signature.asc Description: This is a digitally signed message part ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] version info does not get updated
On 31 August 2014 22:27, Andrew Zonenberg azonenb...@drawersteak.com wrote: Why does CMake not recompute this particular value during the pre-compile configuration step? It runs checks for changed stuff every time you make anyway and only caches certain things. Is it really that hard to not cache this particular value? Currently KiCad uses a configure file mechanism for the version.h file and it's not normal to regenerate these each time you make otherwise you end up re-compiling everything that uses the file and then re-linking everything that links to that target if the target's a library (which in this case it is). Therefore, when you bzr up - make rebuild_cache too in order to update the version number. Caching this value makes subsequent repetitive builds quicker. If you can suffer the time, just do a simple cheat: bk.sh #!/bin/bash make rebuild_cache make just use bk.sh instead of make... The following is from CMakeModules/version.h.cmake : /* * Define the current source code Subversion commit number. The version * string defined below does not update automatically when building the * source with make. Run make rebuild_cache to update version strings. */ Best Regards, Brian. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] version info does not get updated
What I did in my previous build systems is to regenerate the file in a temporary directory then check if the files had the same hash. If they didn't I'd update the file. This way, if you don't change the file's contents it doesn't get touched and nothign else gets rebuilt. On Sun, 2014-08-31 at 22:50 +0100, Brian Sidebotham wrote: On 31 August 2014 22:27, Andrew Zonenberg azonenb...@drawersteak.com wrote: Why does CMake not recompute this particular value during the pre-compile configuration step? It runs checks for changed stuff every time you make anyway and only caches certain things. Is it really that hard to not cache this particular value? Currently KiCad uses a configure file mechanism for the version.h file and it's not normal to regenerate these each time you make otherwise you end up re-compiling everything that uses the file and then re-linking everything that links to that target if the target's a library (which in this case it is). Therefore, when you bzr up - make rebuild_cache too in order to update the version number. Caching this value makes subsequent repetitive builds quicker. If you can suffer the time, just do a simple cheat: bk.sh #!/bin/bash make rebuild_cache make just use bk.sh instead of make... The following is from CMakeModules/version.h.cmake : /* * Define the current source code Subversion commit number. The version * string defined below does not update automatically when building the * source with make. Run make rebuild_cache to update version strings. */ Best Regards, Brian. -- Andrew Zonenberg PhD student, security group Computer Science Department Rensselaer Polytechnic Institute http://colossus.cs.rpi.edu/~azonenberg/ signature.asc Description: This is a digitally signed message part ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] version info does not get updated
On 31 August 2014 22:52, Andrew Zonenberg azonenb...@drawersteak.com wrote: What I did in my previous build systems is to regenerate the file in a temporary directory then check if the files had the same hash. If they didn't I'd update the file. This way, if you don't change the file's contents it doesn't get touched and nothign else gets rebuilt. Yeah, everything's possible, but when you're doing local commits you're still going to get needless compilation and relinking because the bzr rev number has changed. Generally the bzr revno is a bit of a pain for developers if you commit often but useful for everyone else. I guess someone could improve the situation if they had the time, but re-compilation and re-linking everytime would be a bit of a step backwards. Best Regards, Brian. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
