[Kmymoney-devel] [kmymoney4] [Bug 315865] Import ignores Payees when starting with digit
https://bugs.kde.org/show_bug.cgi?id=315865 Cristian Oneț onet.crist...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||onet.crist...@gmail.com Resolution|--- |WORKSFORME --- Comment #9 from Cristian Oneț onet.crist...@gmail.com --- Closing this since the reported issue was resolved. -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 322892] freeeze when importing a QIF file
https://bugs.kde.org/show_bug.cgi?id=322892 Cristian Oneț onet.crist...@gmail.com changed: What|Removed |Added CC||onet.crist...@gmail.com --- Comment #22 from Cristian Oneț onet.crist...@gmail.com --- (In reply to comment #10) In installed it along whith KDE. The environment is a little different. But It's worse : - KMM is very, very slow (takes several seconds after clicking in th Browse button in the import box - Chosing Settings/Kmm settings causes KMM to crash - Regional settings of KDE like number formats are still not taken into account - I still freeze when trying to import my QIF file These were known issues of the previous KDE on windows releases. If you only use KMyMoney on Windows from the KDE package please use the standalone installers is https://sourceforge.net/projects/kmymoney2/files/KMyMoney-Windows/ because they are better suited to run only KMyMoney. When installing KDE I chose MinGW4 64 bits because my computer is a 64bits engine. Maybe I should have kept the default setting MSCV 2010 32 bit ? -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 322892] freeeze when importing a QIF file
https://bugs.kde.org/show_bug.cgi?id=322892 Cristian Oneț onet.crist...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO Resolution|--- |WAITINGFORINFO --- Comment #23 from Cristian Oneț onet.crist...@gmail.com --- Does the application freeze (does not respond) or only the import fails without a message? If the import fails without a message it could be fixed by this commit https://projects.kde.org/projects/extragear/office/kmymoney/repository/revisions/66a09c2516879642c9bf67860fe15c815286fb3a which will be available in the next release scheduled on 06.10.2013. -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.
On Sept. 10, 2013, 7:20 a.m., Cristian Oneț wrote: kmymoney/dialogs/transactioneditor.h, line 155 http://git.reviewboard.kde.org/r/112364/diff/1/?file=185613#file185613line155 Is making this public a good idea? I had already reverted it here to protected. On Sept. 10, 2013, 7:20 a.m., Cristian Oneț wrote: kmymoney/dialogs/investactivities.cpp, line 219 http://git.reviewboard.kde.org/r/112364/diff/1/?file=185610#file185610line219 Is there a reason why the show of shares and price was move out from the for loop? Within the loop, they were handled as QWidgets and were misbehaving. I needed them to be kMyMoneyEdit, to access its children. On Sept. 10, 2013, 7:20 a.m., Cristian Oneț wrote: kmymoney/dialogs/investactivities.cpp, line 318 http://git.reviewboard.kde.org/r/112364/diff/1/?file=185610#file185610line318 Same questions as Buy::showWidgets() Same answer. On Sept. 10, 2013, 7:20 a.m., Allan Anderson wrote: Another nice thing would be to have a separate patch for each individual functionality. Right now we have two things here 1 - ledger resizing and 2 - investment editor fix for widgets that are visible when they should not be. For me it's not that easy to make a review this way. Allan Anderson wrote: The two came along together. I can do this for these changes in the investment editor, but most of the trouble was in the new code, even though the methods were identical or near-identical. So, for these, there is no patch fixing something, as there was no code there before. Anyway, I'll see if I can do some separation. Allan Anderson wrote: Incidentally, this problem with the edit widgets disappearing/appearing when wanted/unwanted is present in an unpatched git HEAD, and has been there for a long while. Opening any investment transaction, then resizing the window, will produce it with one or more widgets. From some fresh experiments, if a hide() (or show()) does not do the necessary, then often replacing with setCalculatorButtonVisible(false) and lineedit()-hide() does the trick. Sadly though, that does not work in every case, and it looks like the only sure-fire fix is the one I came up with, setting the widget height to zero instead of hiding. What I'm working on and proposing is, for now, to concentrate on the column width issues. It is almost exclusively in the Register class, with revised versions of Register::adjustColumn(int col) and Register::resize(int col, bool force), which are much the same as in the original submission. This will ensure each column is wide enough for its data, so no need (or ability) for the user to resize any individual columns. Also, at the moment, while entering or editing a transaction, the width of all the edit edit boxes is considerably hidden by calculator or date entry buttons. This is improved, and the number column width can expand while editing, so the user can actually see all of his entry, instead of it scrolling out of sight. The whole window may be resized, as now, but I'm abandoning the long-standing issue of investment edit widgets appearing/disappearing illogically. The overall size of the patch is much reduced. I hope you agree for me to proceed with this. - Allan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/#review39691 --- On Aug. 29, 2013, 5:12 p.m., Allan Anderson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/ --- (Updated Aug. 29, 2013, 5:12 p.m.) Review request for KMymoney. Description --- If I choose to use a complex system for check numbers, such that the whole number is not visible, the only way I have available is to stretch the whole window. However, even that doesn't help, as the whole of the increase is grabbed by the Details column. I accept that it is likely that that column is going to need to be the widest. Then, why are the Payment and Deposit columns twice the width of the Balance column, when that column may be likely to have the greatest value? Ditto for the Date. This fix allows modification of column widths, but also resizes the individual columns to more suitable widths. I found that Thomas had started to implement something similar some while ago, so I have built upon and expanded that. I found that the edit widgets were particularly troublesome, in failing to appear/disappear with the show() and hide() methods, which I'd previously found when last in this area. Then, when the screen was being resized, they flickered more than acceptable. Eventually, where necessary, I resorted to
Re: [Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.
On Sept. 10, 2013, 7:20 a.m., Allan Anderson wrote: Another nice thing would be to have a separate patch for each individual functionality. Right now we have two things here 1 - ledger resizing and 2 - investment editor fix for widgets that are visible when they should not be. For me it's not that easy to make a review this way. Allan Anderson wrote: The two came along together. I can do this for these changes in the investment editor, but most of the trouble was in the new code, even though the methods were identical or near-identical. So, for these, there is no patch fixing something, as there was no code there before. Anyway, I'll see if I can do some separation. Allan Anderson wrote: Incidentally, this problem with the edit widgets disappearing/appearing when wanted/unwanted is present in an unpatched git HEAD, and has been there for a long while. Opening any investment transaction, then resizing the window, will produce it with one or more widgets. From some fresh experiments, if a hide() (or show()) does not do the necessary, then often replacing with setCalculatorButtonVisible(false) and lineedit()-hide() does the trick. Sadly though, that does not work in every case, and it looks like the only sure-fire fix is the one I came up with, setting the widget height to zero instead of hiding. Allan Anderson wrote: What I'm working on and proposing is, for now, to concentrate on the column width issues. It is almost exclusively in the Register class, with revised versions of Register::adjustColumn(int col) and Register::resize(int col, bool force), which are much the same as in the original submission. This will ensure each column is wide enough for its data, so no need (or ability) for the user to resize any individual columns. Also, at the moment, while entering or editing a transaction, the width of all the edit edit boxes is considerably hidden by calculator or date entry buttons. This is improved, and the number column width can expand while editing, so the user can actually see all of his entry, instead of it scrolling out of sight. The whole window may be resized, as now, but I'm abandoning the long-standing issue of investment edit widgets appearing/disappearing illogically. The overall size of the patch is much reduced. I hope you agree for me to proceed with this. Sure, go on, I'm happy with the solution you've described. I'll take a look at the investment edit widgets issue when I can. - Cristian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/#review39691 --- On Aug. 29, 2013, 5:12 p.m., Allan Anderson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/ --- (Updated Aug. 29, 2013, 5:12 p.m.) Review request for KMymoney. Description --- If I choose to use a complex system for check numbers, such that the whole number is not visible, the only way I have available is to stretch the whole window. However, even that doesn't help, as the whole of the increase is grabbed by the Details column. I accept that it is likely that that column is going to need to be the widest. Then, why are the Payment and Deposit columns twice the width of the Balance column, when that column may be likely to have the greatest value? Ditto for the Date. This fix allows modification of column widths, but also resizes the individual columns to more suitable widths. I found that Thomas had started to implement something similar some while ago, so I have built upon and expanded that. I found that the edit widgets were particularly troublesome, in failing to appear/disappear with the show() and hide() methods, which I'd previously found when last in this area. Then, when the screen was being resized, they flickered more than acceptable. Eventually, where necessary, I resorted to zeroing/resetting the height instead, which resolved the issue, although with some complication. This addresses bugs 312816 and 322768. http://bugs.kde.org/show_bug.cgi?id=312816 http://bugs.kde.org/show_bug.cgi?id=322768 Diffs - kmymoney/dialogs/investactivities.cpp 50f33ed kmymoney/dialogs/investtransactioneditor.h 3e62c2a kmymoney/dialogs/investtransactioneditor.cpp e9f87fb kmymoney/dialogs/transactioneditor.h f07dafb kmymoney/dialogs/transactioneditor.cpp 39049cf kmymoney/views/kgloballedgerview.h 04a6303 kmymoney/views/kgloballedgerview.cpp 78d98b2 kmymoney/widgets/register.h eebe78d kmymoney/widgets/register.cpp 1bdf5bd
Re: [Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.
On Fri, 13 Sep 2013 10:50:53 - Cristian Oneț onet.crist...@gmail.com wrote: On Sept. 10, 2013, 7:20 a.m., Allan Anderson wrote: Another nice thing would be to have a separate patch for each individual functionality. Right now we have two things here 1 - ledger resizing and 2 - investment editor fix for widgets that are visible when they should not be. For me it's not that easy to make a review this way. Allan Anderson wrote: The two came along together. I can do this for these changes in the investment editor, but most of the trouble was in the new code, even though the methods were identical or near-identical. So, for these, there is no patch fixing something, as there was no code there before. Anyway, I'll see if I can do some separation. Allan Anderson wrote: Incidentally, this problem with the edit widgets disappearing/appearing when wanted/unwanted is present in an unpatched git HEAD, and has been there for a long while. Opening any investment transaction, then resizing the window, will produce it with one or more widgets. From some fresh experiments, if a hide() (or show()) does not do the necessary, then often replacing with setCalculatorButtonVisible(false) and lineedit()-hide() does the trick. Sadly though, that does not work in every case, and it looks like the only sure-fire fix is the one I came up with, setting the widget height to zero instead of hiding. Allan Anderson wrote: What I'm working on and proposing is, for now, to concentrate on the column width issues. It is almost exclusively in the Register class, with revised versions of Register::adjustColumn(int col) and Register::resize(int col, bool force), which are much the same as in the original submission. This will ensure each column is wide enough for its data, so no need (or ability) for the user to resize any individual columns. Also, at the moment, while entering or editing a transaction, the width of all the edit edit boxes is considerably hidden by calculator or date entry buttons. This is improved, and the number column width can expand while editing, so the user can actually see all of his entry, instead of it scrolling out of sight. The whole window may be resized, as now, but I'm abandoning the long-standing issue of investment edit widgets appearing/disappearing illogically. The overall size of the patch is much reduced. I hope you agree for me to proceed with this. Sure, go on, I'm happy with the solution you've described. I'll take a look at the investment edit widgets issue when I can. Yes, I noticed you've been a bit busy! Allan ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] Unit tests started failing
I have run the tests recently, but today they are all failing. Has anyone updated from git recently, and can run the tests please? Thanks Allan ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Unit tests started failing
According to [1] all tests are passed on git master. Which test are failing on your build? Regards. Cristian [1] http://build.kde.org/job/kmymoney_master/ 2013/9/13 aga agande...@gmail.com: I have run the tests recently, but today they are all failing. Has anyone updated from git recently, and can run the tests please? Thanks Allan ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Unit tests started failing
On Fri, 13 Sep 2013 23:24:24 +0300 Cristian Oneț onet.crist...@gmail.com wrote: According to [1] all tests are passed on git master. Which test are failing on your build? Regards. Cristian [1] http://build.kde.org/job/kmymoney_master/ 2013/9/13 aga agande...@gmail.com: I have run the tests recently, but today they are all failing. Has anyone updated from git recently, and can run the tests please? Thanks Allan They are all failing with (BAD_COMMAND). I ran them several times prior to submitting to the reviewboard two weeks ago, with no problem. I have more than one sandbox, and the two that I tried are both failing. I've re-installed cmake, but no difference. Allan ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Unit tests started failing
On Fri, 13 Sep 2013 23:24:24 +0300 Cristian Oneț onet.crist...@gmail.com wrote: According to [1] all tests are passed on git master. Which test are failing on your build? Regards. Cristian [1] http://build.kde.org/job/kmymoney_master/ 2013/9/13 aga agande...@gmail.com: I have run the tests recently, but today they are all failing. Has anyone updated from git recently, and can run the tests please? Thanks Allan They are all failing with (BAD_COMMAND). I ran them several times prior to submitting to the reviewboard two weeks ago, with no problem. I have more than one sandbox, and the two that I tried are both failing. I've re-installed cmake, but no difference. Allan I don't know why, but I found the test shell was root:root. Running test as root and all is Ok Allan ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
