Re: [Kmymoney-devel] Review Request 112924: Add a configuration option for reusing the memos of a previous transaction

2013-09-25 Thread Brendan Coupe 
I compiled from git with this diff today and tested it and it worked as
expected. This is a nice new option.

Thanks,

*

Brendan*


On Tue, Sep 24, 2013 at 9:23 PM, Cristian Oneț wrote:

>This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112924/
>   Review request for KMymoney.
> By Cristian Oneț.
>
> *Updated Sept. 25, 2013, 4:23 a.m.*
> Changes
>
> Update the comment when clearing the memos of the splits.
>
>   Description
>
> This patch introduces the possibility to ignore the memos when a transaction 
> is being autofilled. I often was is the situation of reusing an older 
> transaction with the autofill feature and needing to clear the old memo.
>
>   Testing
>
> With the option enabled (default value) - the current behavior is kept.
> With the option disabled - the desired behavior is obtained.
>
>   *Bugs: * 319807 
> Diffs (updated)
>
>- kmymoney/dialogs/settings/ksettingsregisterdecl.ui (7bf1eaa)
>- kmymoney/dialogs/transactioneditor.cpp (39049cf)
>- kmymoney/kmymoney.kcfg (04bfabf)
>
> View Diff 
>
> ___
> KMyMoney-devel mailing list
> KMyMoney-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kmymoney-devel
>
>
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] Review Request 112947: BUG:322768 - Interest category and amount disappear when new fee entered in Dividend. Also, fixes for KEditWidget visibility issues.

2013-09-25 Thread Allan Anderson 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112947/
---

Review request for KMymoney.


Description
---

- Interest category disappears -
Steps to Reproduce:
1.Open a new Dividend transaction.
2.Enter an interest category and amount.
3.Enter a new fee category.
4.On accepting the new category, the interest category and amount have been 
cleared.
One line fix in kmymoney/dialogs/transactioneditor.cpp.

- Fixes for KEditWidget visibility issues.
 When editing an investment transaction, interest or fee edit widgets show or 
hide incorrectly.  This is a fairly long-standing issue, and there have been 
attempts to fix by delaying the show() or hide() instructions.  This became 
more pronounced during work to allow column resizing, and Cristian produced a 
fix for the root cause.  This fix is included here.
With the above fix in place, it became necessary to revert the delayed show() 
and hide() calls, and this has been done.
Of course, nothing is ever as simple as that, and another couple of issues 
emerged.  Whether or not an interest or fee amount widget is shown depends on 
the presence or absence of the associated category's text.  It transpired that 
if, say, an existing Reinvest transaction was edited to be, say a Buy 
transaction,  the text from the Reinvest interest category was seen by the new 
Buy entry and resulted in the interest-amount widget being visible when none 
should appear.  Similarly, if a transaction with a fee set is edited to be a 
type with no fee expected, for instance, an Add or RemoveShares, then the 
fee-amount widget became visible when not needed.
It was necessary to rework the slotUpdateFeeVisibility() and 
slotUpdateInterestVisibility() functions to take account of the new transaction 
type.


This addresses bug 322768.
http://bugs.kde.org/show_bug.cgi?id=322768


Diffs
-

  kmymoney/dialogs/investactivities.cpp 50f33ed 
  kmymoney/dialogs/investtransactioneditor.h 3e62c2a 
  kmymoney/dialogs/investtransactioneditor.cpp e9f87fb 
  kmymoney/dialogs/transactioneditor.cpp 39049cf 
  kmymoney/widgets/transactioneditorcontainer.h f77b195 

Diff: http://git.reviewboard.kde.org/r/112947/diff/


Testing
---

Entering and editing various transaction types to ensure only the appropriate 
widgets became visible or hidden when required.


Thanks,

Allan Anderson

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 325312] New: Particular icons are either missing or only visible on mouseover

2013-09-25 Thread Florian 
https://bugs.kde.org/show_bug.cgi?id=325312

Bug ID: 325312
   Summary: Particular icons are either missing or only visible on
mouseover
Classification: Unclassified
   Product: kmymoney4
   Version: 4.6.3
  Platform: Gentoo Packages
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: florian0...@googlemail.com

Visible Icons on mouseover:
-new institution
-Edit (in the account's menue)
Never visible at all icons:
-Transfers (in scheduled transactions)
-all income (in the categories' menue)
-Budgets (in the left row)
-create / delete budgets
-File->backup
-tools->update stock and currency prices (in the menue bar)
-account->edit account/Reconcile/Transaction report/update account/update all
accounts
-view->Hide reconsiled transactions/Hide unused categories

All other icons are visible... that is very courious

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 325307] decimal places truncated when (1) entering amount in split, (2) reconciliation ending balance

2013-09-25 Thread David Nelson 
https://bugs.kde.org/show_bug.cgi?id=325307

--- Comment #4 from David Nelson  ---
after adding locale info to kdeglobals, it now works fine.
thanks for the help.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 325307] decimal places truncated when (1) entering amount in split, (2) reconciliation ending balance

2013-09-25 Thread Cristian Oneț 
https://bugs.kde.org/show_bug.cgi?id=325307

--- Comment #3 from Cristian Oneț  ---
I marked this as WORKSFORME since it's definitely a caused by a KDE locale
missconfiguration.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 325307] decimal places truncated when (1) entering amount in split, (2) reconciliation ending balance

2013-09-25 Thread Cristian Oneț 
https://bugs.kde.org/show_bug.cgi?id=325307

Cristian Oneț  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||onet.crist...@gmail.com
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 325307] decimal places truncated when (1) entering amount in split, (2) reconciliation ending balance

2013-09-25 Thread David Nelson 
https://bugs.kde.org/show_bug.cgi?id=325307

--- Comment #2 from David Nelson  ---
Just recompiled from git - same result.

No decimal separator displayed in both cases.

As you suggested, the locale is not properly set. Country and currency are both
missing in KDE.  The error message says I'm missing localization files for
en_US, so I'll check hw to fix that. 
Thanks for the quick response and tip.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 325307] decimal places truncated when (1) entering amount in split, (2) reconciliation ending balance

2013-09-25 Thread Jack 
https://bugs.kde.org/show_bug.cgi?id=325307

--- Comment #1 from Jack  ---
If you compiled yourself, please specify whether the source was a tarball
(which version) or git (master?).  What is your locale setting, and the KDE
currency setting?  (probably not an issue, but just in case)

In the reconciliation dialog, is the decimal separator displayed?  If you
expect the starting balance to be "123.45" does it display "1234"  "1234." or
"1234.00" ?  Similar for the split amount.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 325307] New: decimal places truncated when (1) entering amount in split, (2) reconciliation ending balance

2013-09-25 Thread David Nelson 
https://bugs.kde.org/show_bug.cgi?id=325307

Bug ID: 325307
   Summary: decimal places truncated when (1) entering amount in
split, (2) reconciliation ending balance
Classification: Unclassified
   Product: kmymoney4
   Version: unspecified
  Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
  Severity: major
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: davidnel...@telus.net

(1) amount entered in split edit loses its decimal places when clicking on tick
icon.  existing unchanged amounts display correctly afterwards.

(2) reconciliation starting and ending balances displayed without decimals, so
cannot reconcile precisely.

using libalkimia-4.3.2,  kde-4.11.1,  ubuntu saucy (development release)

Reproducible: Always

Steps to Reproduce:
1. enter/change amount in split view
2. try to reconcile account
3.
Actual Results:  
1) decimal places lost
2) decimal places don't display for starting and ending balances

Expected Results:  
not truncated decimal places

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 322768] Interest category and amount disappear when new fee entered in Dividend.

2013-09-25 Thread Cristian Oneț 
https://bugs.kde.org/show_bug.cgi?id=322768

--- Comment #2 from Cristian Oneț  ---
Created attachment 82487
  --> https://bugs.kde.org/attachment.cgi?id=82487&action=edit
A patch that make fixes the visibility issue

Note that the patch is incomplete since delayed calls to show()/hide() must be
replaced with synchronous calls to show()/hide() to avoid flickering on window
resize. Allan is working on this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 312816] Resize ledger No. column

2013-09-25 Thread Cristian Oneț 
https://bugs.kde.org/show_bug.cgi?id=312816

Cristian Oneț  changed:

   What|Removed |Added

 CC||onet.crist...@gmail.com

--- Comment #8 from Cristian Oneț  ---
Please leave the "widgets are missing and some are showing unnecessarily, and
the flickering on window resize" issues for BUG 322768.
The fact that "When editing an investment, the Quantity column is now too
narrow because of the calculator button" is related and relevant to this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 322768] Interest category and amount disappear when new fee entered in Dividend.

2013-09-25 Thread Cristian Oneț 
https://bugs.kde.org/show_bug.cgi?id=322768

Cristian Oneț  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 CC||onet.crist...@gmail.com
 Ever confirmed|0   |1

--- Comment #1 from Cristian Oneț  ---
Allan, please post all widget disappearing related patches and review request
for this bug report.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.

2013-09-25 Thread Cristian Oneț 


> On Sept. 25, 2013, 3:21 a.m., Cristian Oneț wrote:
> > I would not ship this patch. I'll elaborate a bit more my comments at 
> > https://bugs.kde.org/show_bug.cgi?id=312816#c6 and I'll base my arguments 
> > on this recording I made 
> > http://kmymoney2.sourceforge.net/screencasts/112364.ogv about how this 
> > patch behaves.
> > 
> > 1. It breaks with the current behavior of the application (auto resizing 
> > columns after data has been entered to fit the entered data)
> > 2. It introduces bugs, I mean, setting a maxWidth of "9,999,999.00 " for 
> > the amount fields!? This is exactly what was hurting the number column and 
> > the fix should be all about removing a limitation not adding new ones
> 
> Allan Anderson wrote:
> You've concentrated on forms mode, where there is not much wrong.
> 
> 1. Depending on content, there was some clipping.
> 2. There already was in Thomas's implementation a width restriction for 
> the number column, so I eased it substantially.
> 
> The existing excessive width of some columns can result in clipping 
> elsewhere.  There are still problems with non/unnecessary appearance of 
> investment widgets.
>

I know that the problem with unnecessary widgets is still there, I thought you 
are working on that (see the discussion with me, the patch I sent you, your 
discussion with David). We should still fix that issue. I thought that this 
review request (patch) only handles the number column issue (BUG 312816) at 
least the latest version of the patch.

I just tried to show that the patch does more damage than good, I agree that 
there are some issues now but they should be fixed in a proper way so that we 
don't break current behavior. I'm sure that all those issues that you've 
observed with the investment editor without the transaction form can be fixed 
while keeping the current behavior of the transaction form.

With the patch I attached to BUG 312816 I agree that the first time a long 
check number is entered the user will not see it entirely, but, after the 
transaction is entered the width of that column is adjusted to fit the entered 
data, thus next time the user will not have this issue when entering a similar 
check number. I prefer this, you could say, sloppy implementation because of 
it's very small incidence to the one which makes the column size change at each 
key press (with a big incidence).


- Cristian


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112364/#review40732
---


On Sept. 25, 2013, 10:48 a.m., Allan Anderson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112364/
> ---
> 
> (Updated Sept. 25, 2013, 10:48 a.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> ---
> 
> If I choose to use a complex system for check numbers, such that the whole 
> number is not visible,
> the only way I have available is to stretch the whole window. However, even 
> that doesn't help,
> as the whole of the increase is grabbed by the Details column.  I accept that 
> it is likely that that
> column is going to need to be the widest.  Then, why are the Payment and 
> Deposit columns twice the
> width of the Balance column, when that column may be likely to have the 
> greatest value?  Ditto for
> the Date.
> 
> This fix allows modification of column widths, but also resizes the 
> individual columns to more suitable widths.
> 
> I found that Thomas had started to implement something similar some while 
> ago, so I have built upon and expanded that.
> 
> I found that the edit widgets were particularly troublesome, in failing to 
> appear/disappear with the show() and hide()
> methods, which I'd previously found when last in this area. Then, when the 
> screen was being resized, they flickered
> more than acceptable. Eventually, where necessary, I resorted to 
> zeroing/resetting the height instead, which resolved
> the issue, although with some complication.
> 
> 
> This addresses bugs 312816 and 322768.
> http://bugs.kde.org/show_bug.cgi?id=312816
> http://bugs.kde.org/show_bug.cgi?id=322768
> 
> 
> Diffs
> -
> 
>   kmymoney/dialogs/transactioneditor.h f07dafb 
>   kmymoney/dialogs/transactioneditor.cpp 39049cf 
>   kmymoney/views/kgloballedgerview.cpp 2057b47 
>   kmymoney/widgets/register.h eebe78d 
>   kmymoney/widgets/register.cpp 1bdf5bd 
> 
> Diff: http://git.reviewboard.kde.org/r/112364/diff/
> 
> 
> Testing
> ---
> 
> Extensive editing of sample files, and changing back and forth between 
> different activity types, which tended to show
> problem areas. atype run.
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

___
KMyMoney-deve

Re: [Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.

2013-09-25 Thread Allan Anderson 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112364/
---

(Updated Sept. 25, 2013, 10:48 a.m.)


Status
--

This change has been discarded.


Review request for KMymoney.


Description
---

If I choose to use a complex system for check numbers, such that the whole 
number is not visible,
the only way I have available is to stretch the whole window. However, even 
that doesn't help,
as the whole of the increase is grabbed by the Details column.  I accept that 
it is likely that that
column is going to need to be the widest.  Then, why are the Payment and 
Deposit columns twice the
width of the Balance column, when that column may be likely to have the 
greatest value?  Ditto for
the Date.

This fix allows modification of column widths, but also resizes the individual 
columns to more suitable widths.

I found that Thomas had started to implement something similar some while ago, 
so I have built upon and expanded that.

I found that the edit widgets were particularly troublesome, in failing to 
appear/disappear with the show() and hide()
methods, which I'd previously found when last in this area. Then, when the 
screen was being resized, they flickered
more than acceptable. Eventually, where necessary, I resorted to 
zeroing/resetting the height instead, which resolved
the issue, although with some complication.


This addresses bugs 312816 and 322768.
http://bugs.kde.org/show_bug.cgi?id=312816
http://bugs.kde.org/show_bug.cgi?id=322768


Diffs
-

  kmymoney/dialogs/transactioneditor.h f07dafb 
  kmymoney/dialogs/transactioneditor.cpp 39049cf 
  kmymoney/views/kgloballedgerview.cpp 2057b47 
  kmymoney/widgets/register.h eebe78d 
  kmymoney/widgets/register.cpp 1bdf5bd 

Diff: http://git.reviewboard.kde.org/r/112364/diff/


Testing
---

Extensive editing of sample files, and changing back and forth between 
different activity types, which tended to show
problem areas. atype run.


Thanks,

Allan Anderson

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.

2013-09-25 Thread Allan Anderson 


> On Sept. 25, 2013, 3:21 a.m., Cristian Oneț wrote:
> > I would not ship this patch. I'll elaborate a bit more my comments at 
> > https://bugs.kde.org/show_bug.cgi?id=312816#c6 and I'll base my arguments 
> > on this recording I made 
> > http://kmymoney2.sourceforge.net/screencasts/112364.ogv about how this 
> > patch behaves.
> > 
> > 1. It breaks with the current behavior of the application (auto resizing 
> > columns after data has been entered to fit the entered data)
> > 2. It introduces bugs, I mean, setting a maxWidth of "9,999,999.00 " for 
> > the amount fields!? This is exactly what was hurting the number column and 
> > the fix should be all about removing a limitation not adding new ones

You've concentrated on forms mode, where there is not much wrong.

1. Depending on content, there was some clipping.
2. There already was in Thomas's implementation a width restriction for the 
number column, so I eased it substantially.

The existing excessive width of some columns can result in clipping elsewhere.  
There are still problems with non/unnecessary appearance of investment widgets.


- Allan


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112364/#review40732
---


On Sept. 15, 2013, 4:26 p.m., Allan Anderson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112364/
> ---
> 
> (Updated Sept. 15, 2013, 4:26 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> ---
> 
> If I choose to use a complex system for check numbers, such that the whole 
> number is not visible,
> the only way I have available is to stretch the whole window. However, even 
> that doesn't help,
> as the whole of the increase is grabbed by the Details column.  I accept that 
> it is likely that that
> column is going to need to be the widest.  Then, why are the Payment and 
> Deposit columns twice the
> width of the Balance column, when that column may be likely to have the 
> greatest value?  Ditto for
> the Date.
> 
> This fix allows modification of column widths, but also resizes the 
> individual columns to more suitable widths.
> 
> I found that Thomas had started to implement something similar some while 
> ago, so I have built upon and expanded that.
> 
> I found that the edit widgets were particularly troublesome, in failing to 
> appear/disappear with the show() and hide()
> methods, which I'd previously found when last in this area. Then, when the 
> screen was being resized, they flickered
> more than acceptable. Eventually, where necessary, I resorted to 
> zeroing/resetting the height instead, which resolved
> the issue, although with some complication.
> 
> 
> This addresses bugs 312816 and 322768.
> http://bugs.kde.org/show_bug.cgi?id=312816
> http://bugs.kde.org/show_bug.cgi?id=322768
> 
> 
> Diffs
> -
> 
>   kmymoney/dialogs/transactioneditor.h f07dafb 
>   kmymoney/dialogs/transactioneditor.cpp 39049cf 
>   kmymoney/views/kgloballedgerview.cpp 2057b47 
>   kmymoney/widgets/register.h eebe78d 
>   kmymoney/widgets/register.cpp 1bdf5bd 
> 
> Diff: http://git.reviewboard.kde.org/r/112364/diff/
> 
> 
> Testing
> ---
> 
> Extensive editing of sample files, and changing back and forth between 
> different activity types, which tended to show
> problem areas. atype run.
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 312816] Resize ledger No. column

2013-09-25 Thread allan 
https://bugs.kde.org/show_bug.cgi?id=312816

--- Comment #7 from allan  ---
Your patch is certainly simpler.

In forms mode , there is not much wrong, but did you look at the register when
not in forms mode?

With a check account,  it is now possible to enter a long number, but while
entering a new number, the column only displays about three characters.  The
Date, Payment and Deposit columns take up too much space, which can clip the
Details column.  With an investment, the Date, Quantity and Price columns are
too wide.  When editing an investment, the Quantity column is now too narrow
because of the calculator button.  On different activity types, some widgets
are missing and some are showing unnecessarily, and the flickering on window
resize is still there.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel