Re: [Kmymoney-devel] Review Request 112947: BUG:322768 - Interest category and amount disappear when new fee entered in Dividend. Also, fixes for KEditWidget visibility issues.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112947/#review40849
---
Reading
http://kmymoney2.sourceforge.net/kde4/online-manual/details.investments.ledger.html#idp38934400
I didn't manage to get a good idea of which widgets should be visible or not
depending on the investment action so I can't say anything about the
functionality (other then it looks good and is without flickering). Maybe it
would be a good idea to document each action in more detail, but I'm not
requesting you this. The rest of my comments are strictly with my programmer's
hat on.
kmymoney/dialogs/investactivities.cpp
http://git.reviewboard.kde.org/r/112947/#comment30008
does the ending '///' mean anything? if this is a placeholder to search for
maybe a textual comment would be better suited
kmymoney/dialogs/investactivities.cpp
http://git.reviewboard.kde.org/r/112947/#comment30007
Please run astyle-kmymoney.sh before pushing the commit.
kmymoney/dialogs/investtransactioneditor.cpp
http://git.reviewboard.kde.org/r/112947/#comment30012
I would go with something like this to make it more readable.
const bool hideFee = txt.isEmpty() || d-m_activity-type() ==
MyMoneySplit::AddShares || .. the rest of the activities which don't have a fee
if (hideFee) {
l-setText();
feeAmount-hide();
} else {
l-setText(i18n(Fee Amount));
feeAmount-show();
}
kmymoney/dialogs/investtransactioneditor.cpp
http://git.reviewboard.kde.org/r/112947/#comment30011
Could this:
if (cond) {} else if (cond) {}
be written in a more readable manner? I would write something like:
if (cond) {} else {}
since all activity types are either in one or the other codition.
kmymoney/dialogs/transactioneditor.cpp
http://git.reviewboard.kde.org/r/112947/#comment30009
If the category id is cleared here then why shouldn't the category editor
widget be cleared two lines bellow?
kmymoney/dialogs/transactioneditor.cpp
http://git.reviewboard.kde.org/r/112947/#comment30010
Are you sure that this is valid since categoryId.clear() is called
above? This only keeps the data in the widget.
- Cristian Oneț
On Sept. 26, 2013, 12:03 a.m., Allan Anderson wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112947/
---
(Updated Sept. 26, 2013, 12:03 a.m.)
Review request for KMymoney.
Description
---
- Interest category disappears -
Steps to Reproduce:
1.Open a new Dividend transaction.
2.Enter an interest category and amount.
3.Enter a new fee category.
4.On accepting the new category, the interest category and amount have been
cleared.
One line fix in kmymoney/dialogs/transactioneditor.cpp.
- Fixes for KEditWidget visibility issues.
When editing an investment transaction, interest or fee edit widgets show or
hide incorrectly. This is a fairly long-standing issue, and there have been
attempts to fix by delaying the show() or hide() instructions. This became
more pronounced during work to allow column resizing, and Cristian produced a
fix for the root cause. This fix is included here.
With the above fix in place, it became necessary to revert the delayed show()
and hide() calls, and this has been done.
Of course, nothing is ever as simple as that, and another couple of issues
emerged. Whether or not an interest or fee amount widget is shown depends on
the presence or absence of the associated category's text. It transpired
that if, say, an existing Reinvest transaction was edited to be, say a Buy
transaction, the text from the Reinvest interest category was seen by the
new Buy entry and resulted in the interest-amount widget being visible when
none should appear. Similarly, if a transaction with a fee set is edited to
be a type with no fee expected, for instance, an Add or RemoveShares, then
the fee-amount widget became visible when not needed.
It was necessary to rework the slotUpdateFeeVisibility() and
slotUpdateInterestVisibility() functions to take account of the new
transaction type.
This addresses bug 322768.
http://bugs.kde.org/show_bug.cgi?id=322768
Diffs
-
kmymoney/dialogs/investactivities.cpp 50f33ed
kmymoney/dialogs/investtransactioneditor.h 3e62c2a
kmymoney/dialogs/investtransactioneditor.cpp e9f87fb
kmymoney/dialogs/transactioneditor.cpp 39049cf
kmymoney/widgets/transactioneditorcontainer.h f77b195
Diff: http://git.reviewboard.kde.org/r/112947/diff/
Testing
---
Entering and editing various transaction types to ensure only the appropriate
widgets became visible or hidden when required.
Thanks,
Allan
Re: [Kmymoney-devel] Starting w/o loading plugins possible?
I think you can start without plugins by removing the path where the plugins are located from the QT_PLUGIN_PATH environment variable. Regards, Cristian 2013/9/22 mk-li...@email.de: Hi, I am test-building/running KMM on OSX at the moment. And I was wondering whether there is a possibility to let KMM not load any plugins. My problem is that KMM crashes on me, because when I start it from the build directory it somehow cannot locate its plugins properly. See what happens while loading csvexport plugin: --- kmymoney(16230)/kutils (KPluginSelector) KPluginSelector::addPlugins: cfgGroup = 0x7fff5fbfe7f0 kmymoney(16230)/kdecore (KPluginInfo) KPluginInfo::kcmServices: found 0 offers for csvexport kmymoney(16230)/kdecore (KPluginInfo) KPluginInfo::kcmServices: found 1 offers for Print check kmymoney(16230)/kdecore (KPluginInfo) KPluginInfo::kcmServices: found 0 offers for KBanking kmymoney(16230)/kdecore (KPluginInfo) KPluginInfo::kcmServices: found 0 offers for KMyMoney OFX kmymoney(16230)/kdecore (KPluginInfo) KPluginInfo::kcmServices: found 0 offers for csvimport kmymoney(16230)/kdecore (KPluginInfo) KPluginInfo::kcmServices: found 0 offers for Reconciliation report kmymoney(16230)/kdecore (KPluginInfo) KPluginInfo::kcmServices: found 1 offers for iCalendar KMyMoney csvexport plugin loaded KMyMoneyPlugin::PluginLoader:: createInstanceFromService returned 0 for csvexport with error The service 'csvexport' does not provide an interface 'KMyMoneyPlugin::Plugin' with keyword '' KMyMoney printcheck plugin loaded QObject::connect: Cannot connect (null)::plug(KPluginInfo*) to KMMPrintCheckPlugin::slotPlug(KPluginInfo*) QObject::connect: Cannot connect (null)::unplug(KPluginInfo*) to KMMPrintCheckPlugin::slotUnplug(KPluginInfo*) QObject::connect: Cannot connect (null)::configChanged(Plugin*) to KMMPrintCheckPlugin::slotUpdateConfig() KMyMoneyPlugin::PluginLoader:: createInstanceFromService returned 0 for Print check with error The service 'Print check' does not provide an interface 'KMyMoneyPlugin::Plugin' with keyword '' 7:2013/09/22 21-11-24:aqbanking(16230):started KMyMoney kbanking plugin loaded KCrash: crashing... crashRecursionCounter = 2 KCrash: Application Name = kmymoney path = /Users/marko/WC/GIT/kmymoney.online-balance_highlighting_extended/build/kmymoney/kmymoney.app/Contents/MacOS pid = 16230 KCrash: Arguments: /Users/marko/WC/GIT/kmymoney.online-balance_highlighting_extended/build/kmymoney/kmymoney.app/Contents/MacOS/kmymoney --nocrashhandler KCrash: Attempting to start /opt/macports-test/lib/kde4/libexec/drkonqi.app/Contents/MacOS/drkonqi from kdeinit sock_file=/Users/marko/Library/Preferences/KDE/socket-markos-imac/kdeinit4__tmp_launch-bPNaAg_org.x_0 Unable to start Dr. Konqi --- I though disabling loading plugins might help, but perhaps there is another solution?! Greets, Marko ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 325312] Particular icons are either missing or only visible on mouseover
https://bugs.kde.org/show_bug.cgi?id=325312 Cristian Oneț onet.crist...@gmail.com changed: What|Removed |Added CC||onet.crist...@gmail.com --- Comment #1 from Cristian Oneț onet.crist...@gmail.com --- Did you install from portage? This seems to be caused by a wrong installation. I'm running KMyMoney on gentoo without any issues and I don't recall seeing similar reports. -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 112947: BUG:322768 - Interest category and amount disappear when new fee entered in Dividend. Also, fixes for KEditWidget visibility issues.
On Sept. 26, 2013, 10 a.m., Cristian Oneț wrote:
kmymoney/dialogs/investactivities.cpp, line 394
http://git.reviewboard.kde.org/r/112947/diff/1/?file=192722#file192722line394
does the ending '///' mean anything? if this is a placeholder to search
for maybe a textual comment would be better suited
Oops. Yes, it's a placeholder, that I use to search for changes I've made. I
tend not to use it much nowadays. I should have removed it, but it was getting
very late and I slipped up. There may be one or two others as well.
On Sept. 26, 2013, 10 a.m., Cristian Oneț wrote:
kmymoney/dialogs/investactivities.cpp, line 701
http://git.reviewboard.kde.org/r/112947/diff/1/?file=192722#file192722line701
Please run astyle-kmymoney.sh before pushing the commit.
I did have it the 'correct' way at first, but noticed that there was 'if (w)
w-hide()' a few lines above, so changed it because it looked 'wrong' in that
context. I'll change them both. I usually use {} even for a one-liner, but
don't change existing code. There are too many.
On Sept. 26, 2013, 10 a.m., Cristian Oneț wrote:
kmymoney/dialogs/investtransactioneditor.cpp, line 499
http://git.reviewboard.kde.org/r/112947/diff/1/?file=192724#file192724line499
I would go with something like this to make it more readable.
const bool hideFee = txt.isEmpty() || d-m_activity-type() ==
MyMoneySplit::AddShares || .. the rest of the activities which don't have a
fee
if (hideFee) {
l-setText();
feeAmount-hide();
} else {
l-setText(i18n(Fee Amount));
feeAmount-show();
}
I like that. I had to add the declaration for label 'l', and add tests for it
to avoid crashing when not using the form.
Perhaps I should try similar for the interest method.
On Sept. 26, 2013, 10 a.m., Cristian Oneț wrote:
kmymoney/dialogs/investtransactioneditor.cpp, line 528
http://git.reviewboard.kde.org/r/112947/diff/1/?file=192724#file192724line528
Could this:
if (cond) {} else if (cond) {}
be written in a more readable manner? I would write something like:
if (cond) {} else {}
since all activity types are either in one or the other codition.
In general, then that is what I would do. I decided not to do it here because
it provided immediate information on what was dealt with where, with there
being so many different activity types.
However, I could make it a comment instead, but I would like to leave the
information there, for clarity.
Perhaps also remove the existing comment above which doesn't seem to apply any
more?
On Sept. 26, 2013, 10 a.m., Cristian Oneț wrote:
kmymoney/dialogs/transactioneditor.cpp, line 462
http://git.reviewboard.kde.org/r/112947/diff/1/?file=192725#file192725line462
If the category id is cleared here then why shouldn't the category
editor widget be cleared two lines bellow?
Here, I deliberately left in the '///' as I felt a comment was needed, but I'll
reposition them slightly.
This was the cause of the problem. Here, the text was the category name from
the existing interest category, but we are now here because a fee category has
just been added. If cleared here, the name of the interest category gets
removed and has to be reentered.
On Sept. 26, 2013, 10 a.m., Cristian Oneț wrote:
kmymoney/dialogs/transactioneditor.cpp, line 464
http://git.reviewboard.kde.org/r/112947/diff/1/?file=192725#file192725line464
Are you sure that this is valid since categoryId.clear() is
called above? This only keeps the data in the widget.
Yes it is. As explained above, the data in the widget is the name of the
interest category, but we're dealing now with a new fee category. If we clear
this text, the interest category has lost its name and it needs to be added
again once the fee category dialog closes.
It definitely fixes the issue, but whether there is something deeper, I don't
know.
- Allan
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112947/#review40849
---
On Sept. 26, 2013, 12:03 a.m., Allan Anderson wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112947/
---
(Updated Sept. 26, 2013, 12:03 a.m.)
Review request for KMymoney.
Description
---
- Interest category disappears -
Steps to Reproduce:
1.Open a new Dividend transaction.
2.Enter an interest category and amount.
3.Enter a new fee category.
4.On accepting the new category, the interest category and amount have been
cleared.
One line fix in kmymoney/dialogs/transactioneditor.cpp.
- Fixes for KEditWidget visibility issues.
When editing an investment
Re: [Kmymoney-devel] Review Request 112947: BUG:322768 - Interest category and amount disappear when new fee entered in Dividend. Also, fixes for KEditWidget visibility issues.
On Sept. 26, 2013, 10 a.m., Cristian Oneț wrote:
kmymoney/dialogs/investactivities.cpp, line 394
http://git.reviewboard.kde.org/r/112947/diff/1/?file=192722#file192722line394
does the ending '///' mean anything? if this is a placeholder to search
for maybe a textual comment would be better suited
Allan Anderson wrote:
Oops. Yes, it's a placeholder, that I use to search for changes I've
made. I tend not to use it much nowadays. I should have removed it, but it
was getting very late and I slipped up. There may be one or two others as
well.
Yes there are other I only signaled this one, no need to rush with the patch :).
On Sept. 26, 2013, 10 a.m., Cristian Oneț wrote:
kmymoney/dialogs/investtransactioneditor.cpp, line 499
http://git.reviewboard.kde.org/r/112947/diff/1/?file=192724#file192724line499
I would go with something like this to make it more readable.
const bool hideFee = txt.isEmpty() || d-m_activity-type() ==
MyMoneySplit::AddShares || .. the rest of the activities which don't have a
fee
if (hideFee) {
l-setText();
feeAmount-hide();
} else {
l-setText(i18n(Fee Amount));
feeAmount-show();
}
Allan Anderson wrote:
I like that. I had to add the declaration for label 'l', and add tests
for it to avoid crashing when not using the form.
Perhaps I should try similar for the interest method.
Yes, the label must be tested for it's existence.
On Sept. 26, 2013, 10 a.m., Cristian Oneț wrote:
kmymoney/dialogs/investtransactioneditor.cpp, line 528
http://git.reviewboard.kde.org/r/112947/diff/1/?file=192724#file192724line528
Could this:
if (cond) {} else if (cond) {}
be written in a more readable manner? I would write something like:
if (cond) {} else {}
since all activity types are either in one or the other codition.
Allan Anderson wrote:
In general, then that is what I would do. I decided not to do it here
because it provided immediate information on what was dealt with where, with
there being so many different activity types.
However, I could make it a comment instead, but I would like to leave the
information there, for clarity.
Perhaps also remove the existing comment above which doesn't seem to
apply any more?
Please feel free to remove any comments which are not valid anymore (the same
applies for commented code).
On Sept. 26, 2013, 10 a.m., Cristian Oneț wrote:
kmymoney/dialogs/transactioneditor.cpp, line 462
http://git.reviewboard.kde.org/r/112947/diff/1/?file=192725#file192725line462
If the category id is cleared here then why shouldn't the category
editor widget be cleared two lines bellow?
Allan Anderson wrote:
Here, I deliberately left in the '///' as I felt a comment was needed,
but I'll reposition them slightly.
This was the cause of the problem. Here, the text was the category name
from the existing interest category, but we are now here because a fee
category has just been added. If cleared here, the name of the interest
category gets removed and has to be reentered.
OK, I understand that but my dilemma is this: Why is it OK to clear the
'categoryId' and not clear the category name held by the edit widget? I'll look
into this a bit more later.
On Sept. 26, 2013, 10 a.m., Cristian Oneț wrote:
kmymoney/dialogs/transactioneditor.cpp, line 464
http://git.reviewboard.kde.org/r/112947/diff/1/?file=192725#file192725line464
Are you sure that this is valid since categoryId.clear() is
called above? This only keeps the data in the widget.
Allan Anderson wrote:
Yes it is. As explained above, the data in the widget is the name of the
interest category, but we're dealing now with a new fee category. If we
clear this text, the interest category has lost its name and it needs to be
added again once the fee category dialog closes.
It definitely fixes the issue, but whether there is something deeper, I
don't know.
See my question above, when accepting the transaction what will be the value of
'categoryId' if it has been cleared and only the name was kept? Is it being
recomputed based on the name which was kept?
- Cristian
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112947/#review40849
---
On Sept. 26, 2013, 12:03 a.m., Allan Anderson wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112947/
---
(Updated Sept. 26, 2013, 12:03 a.m.)
Review request for KMymoney.
Description
---
- Interest category disappears -
Steps to Reproduce:
1.Open a new Dividend transaction.
Re: [Kmymoney-devel] Review Request 112947: BUG:322768 - Interest category and amount disappear when new fee entered in Dividend. Also, fixes for KEditWidget visibility issues.
On Sept. 26, 2013, 10 a.m., Cristian Oneț wrote: kmymoney/dialogs/transactioneditor.cpp, line 464 http://git.reviewboard.kde.org/r/112947/diff/1/?file=192725#file192725line464 Are you sure that this is valid since categoryId.clear() is called above? This only keeps the data in the widget. Allan Anderson wrote: Yes it is. As explained above, the data in the widget is the name of the interest category, but we're dealing now with a new fee category. If we clear this text, the interest category has lost its name and it needs to be added again once the fee category dialog closes. It definitely fixes the issue, but whether there is something deeper, I don't know. Cristian Oneț wrote: See my question above, when accepting the transaction what will be the value of 'categoryId' if it has been cleared and only the name was kept? Is it being recomputed based on the name which was kept? 'categoryId' is empty on entry, in these circumstances - when adding a new category. Editing an existing one doesn't come here. - Allan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112947/#review40849 --- On Sept. 26, 2013, 12:03 a.m., Allan Anderson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112947/ --- (Updated Sept. 26, 2013, 12:03 a.m.) Review request for KMymoney. Description --- - Interest category disappears - Steps to Reproduce: 1.Open a new Dividend transaction. 2.Enter an interest category and amount. 3.Enter a new fee category. 4.On accepting the new category, the interest category and amount have been cleared. One line fix in kmymoney/dialogs/transactioneditor.cpp. - Fixes for KEditWidget visibility issues. When editing an investment transaction, interest or fee edit widgets show or hide incorrectly. This is a fairly long-standing issue, and there have been attempts to fix by delaying the show() or hide() instructions. This became more pronounced during work to allow column resizing, and Cristian produced a fix for the root cause. This fix is included here. With the above fix in place, it became necessary to revert the delayed show() and hide() calls, and this has been done. Of course, nothing is ever as simple as that, and another couple of issues emerged. Whether or not an interest or fee amount widget is shown depends on the presence or absence of the associated category's text. It transpired that if, say, an existing Reinvest transaction was edited to be, say a Buy transaction, the text from the Reinvest interest category was seen by the new Buy entry and resulted in the interest-amount widget being visible when none should appear. Similarly, if a transaction with a fee set is edited to be a type with no fee expected, for instance, an Add or RemoveShares, then the fee-amount widget became visible when not needed. It was necessary to rework the slotUpdateFeeVisibility() and slotUpdateInterestVisibility() functions to take account of the new transaction type. This addresses bug 322768. http://bugs.kde.org/show_bug.cgi?id=322768 Diffs - kmymoney/dialogs/investactivities.cpp 50f33ed kmymoney/dialogs/investtransactioneditor.h 3e62c2a kmymoney/dialogs/investtransactioneditor.cpp e9f87fb kmymoney/dialogs/transactioneditor.cpp 39049cf kmymoney/widgets/transactioneditorcontainer.h f77b195 Diff: http://git.reviewboard.kde.org/r/112947/diff/ Testing --- Entering and editing various transaction types to ensure only the appropriate widgets became visible or hidden when required. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 112947: BUG:322768 - Interest category and amount disappear when new fee entered in Dividend. Also, fixes for KEditWidget visibility issues.
On Sept. 26, 2013, 10 a.m., Cristian Oneț wrote: kmymoney/dialogs/transactioneditor.cpp, line 464 http://git.reviewboard.kde.org/r/112947/diff/1/?file=192725#file192725line464 Are you sure that this is valid since categoryId.clear() is called above? This only keeps the data in the widget. Allan Anderson wrote: Yes it is. As explained above, the data in the widget is the name of the interest category, but we're dealing now with a new fee category. If we clear this text, the interest category has lost its name and it needs to be added again once the fee category dialog closes. It definitely fixes the issue, but whether there is something deeper, I don't know. Cristian Oneț wrote: See my question above, when accepting the transaction what will be the value of 'categoryId' if it has been cleared and only the name was kept? Is it being recomputed based on the name which was kept? Allan Anderson wrote: 'categoryId' is empty on entry, in these circumstances - when adding a new category. Editing an existing one doesn't come here. OK, then it's safe. - Cristian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112947/#review40849 --- On Sept. 26, 2013, 12:03 a.m., Allan Anderson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112947/ --- (Updated Sept. 26, 2013, 12:03 a.m.) Review request for KMymoney. Description --- - Interest category disappears - Steps to Reproduce: 1.Open a new Dividend transaction. 2.Enter an interest category and amount. 3.Enter a new fee category. 4.On accepting the new category, the interest category and amount have been cleared. One line fix in kmymoney/dialogs/transactioneditor.cpp. - Fixes for KEditWidget visibility issues. When editing an investment transaction, interest or fee edit widgets show or hide incorrectly. This is a fairly long-standing issue, and there have been attempts to fix by delaying the show() or hide() instructions. This became more pronounced during work to allow column resizing, and Cristian produced a fix for the root cause. This fix is included here. With the above fix in place, it became necessary to revert the delayed show() and hide() calls, and this has been done. Of course, nothing is ever as simple as that, and another couple of issues emerged. Whether or not an interest or fee amount widget is shown depends on the presence or absence of the associated category's text. It transpired that if, say, an existing Reinvest transaction was edited to be, say a Buy transaction, the text from the Reinvest interest category was seen by the new Buy entry and resulted in the interest-amount widget being visible when none should appear. Similarly, if a transaction with a fee set is edited to be a type with no fee expected, for instance, an Add or RemoveShares, then the fee-amount widget became visible when not needed. It was necessary to rework the slotUpdateFeeVisibility() and slotUpdateInterestVisibility() functions to take account of the new transaction type. This addresses bug 322768. http://bugs.kde.org/show_bug.cgi?id=322768 Diffs - kmymoney/dialogs/investactivities.cpp 50f33ed kmymoney/dialogs/investtransactioneditor.h 3e62c2a kmymoney/dialogs/investtransactioneditor.cpp e9f87fb kmymoney/dialogs/transactioneditor.cpp 39049cf kmymoney/widgets/transactioneditorcontainer.h f77b195 Diff: http://git.reviewboard.kde.org/r/112947/diff/ Testing --- Entering and editing various transaction types to ensure only the appropriate widgets became visible or hidden when required. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 112947: BUG:322768 - Interest category and amount disappear when new fee entered in Dividend. Also, fixes for KEditWidget visibility issues.
[just to the list, not the review request] On 2013.09.26 06:00, Cristian Oneț wrote: Reading http://kmymoney2.sourceforge.net/kde4/online-manual/details.investments.ledger.html#idp38934400 I didn't manage to get a good idea of which widgets should be visible or not depending on the investment action so I can't say anything about the functionality (other then it looks good and is without flickering). Maybe it would be a good idea to document each action in more detail, but I'm not requesting you this. The rest of my comments are strictly with my programmer's hat on. I'll add this to the list of documentation stuff that needs to be addressed, hopefully before 4.7. However, in this case, the docs should probably state what the program does, rather than expecting the program to do what the docs show. Jack ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 325341] New: Payees view Transactions tab - Column widths not optimum
https://bugs.kde.org/show_bug.cgi?id=325341 Bug ID: 325341 Summary: Payees view Transactions tab - Column widths not optimum Classification: Unclassified Product: kmymoney4 Version: git master Platform: Mint (Ubuntu based) OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: kmymoney-devel@kde.org Reporter: agande...@gmail.com I didn't go looking for this - I encountered it when searching for a payee. My screen width is 1920px. With the Payees view window at full width, the Transactions tab window is about half that. The Date, Payment and Deposit columns are about the same width, but the Deposit column is empty, the Date column is half empty and the Payment column is about 60% empty. No problem at this stage, but I don't operate with this window size. If I reduce the KMM window size to a more typical 1000 - 1100px, the Date, Payee and Deposit columns have retained their previous width and emptyness. The Details column has disappeared, and the Account column shows about five characters. Shrinking now to 800-900px, the Payment and Deposit columns are untouched, the Details and Account columns have disappeared and the Date column is now reducing. Shrinking further, and just before a horizontal scroll bar appears, the Date and Account column are the only shows, both with much empty space. When the scroll-bar appears, the Date and Account columns are showing, clicking in the empty scroll-bar region produces an empty window, and a final click to the right shows the Date and Account columns again for some reason. The other columns are nowhere to be seen. Reproducible: Always Steps to Reproduce: As above. Actual Results: Weird! As above. Expected Results: Allocate column widths according to their content, with spare width going to the details column. Allow all columns to reduce to a minimum, rather that exhibiting flagrant favouritism. Scrolling should give sensible results. -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 312816] Resize ledger No. column
https://bugs.kde.org/show_bug.cgi?id=312816 --- Comment #9 from allan agande...@gmail.com --- (In reply to comment #8) Please leave the widgets are missing and some are showing unnecessarily, and the flickering on window resize issues for BUG 322768. Done. The fact that When editing an investment, the Quantity column is now too narrow because of the calculator button is related and relevant to this issue. Good. With the Number column, I really don't like being able to see just three characters when entering or editing a number. One user has raised a bug, requiring to be able to enter, say, A7XCC-GY9M2MM. You really need to be able to see what you've typed, before you accept it, rather than having to come back in. Also, you're not really correct when you said ...to the one [version] which makes the column size change at each key press During input, when it becomes necessary to increase the column width, I add three character widths, to reduce column resizing. The 'three' was an arbitrary value, and could be increased further. The number column is not actually the only bug. There is also Bug 321947, although that's from me, but quite few other users have referred to resizing columns. If you agree, i'd like to go back to this, although without the maximum width restriction. It's mostly done. -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Starting w/o loading plugins possible?
Hi Cristian, On Sep 26, 2013, at 12:51 PM, Cristian Oneț wrote: I think you can start without plugins by removing the path where the plugins are located from the QT_PLUGIN_PATH environment variable. Hmmm, I do not have such a variable in my environment: --- $ set | grep QT_PLUGIN $ --- I guess there's no other way for me then than to always wait those 15 mins until KMM has been built from scratch… :( Greets, Marko ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
