[Kmymoney-devel] [kmymoney4] [Bug 325953] New: rounding error when creating the transfer between two accounts in different currencies with option to amount

2013-10-13 Thread vy
https://bugs.kde.org/show_bug.cgi?id=325953

Bug ID: 325953
   Summary: rounding error when creating the transfer between two
accounts in different currencies with option to
amount
Classification: Unclassified
   Product: kmymoney4
   Version: 4.6.3
  Platform: unspecified
OS: Linux
Status: UNCONFIRMED
  Severity: major
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: v...@samiznaetekogo.net

the sum of transfer between two accounts in different currencies is being
stored as a number calculated via exchange rate, despite option to amount was
selected. For example when I get cash from my card account in ATM. If I
withdraw 1234 currency1 units from my account  in other country in ATM as 6000
local currency2 units, I will create transfer in KMymoney from my card account
into my cash account. I will  enter amount as 1234 in currency1 and select
option to amount and enter amount as 6000 currency2. But KMymoney stores
amount as 5 999,95 I think because it calculates amount with exchange rate
instead of just storing it. Its obviously a bug because I get exactly 1234
currency1 units less on my account and I get exactly 6000 currency2 units in
cash, but KMymoney refuses to store actual accounts states and this will lead
to some unrecorded amounts which can be hard to trace later.

Reproducible: Always

Steps to Reproduce:
1. create some accounts in different currencies
2. create transfer between accounts with option to amount, so that exact
amount is not equal to that, calculated with exchange rate,

Actual Results:  
wrong amount stored.

Expected Results:  
Amount of transfer stored as entered.

Mark as major because accounting is a major feature of KMymoney. And errors in
accounting is a major feature that is not working as expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel


Re: [Kmymoney-devel] Review Request 112989: Improve the resizing of the register and the transaction form.

2013-10-13 Thread Allan Anderson


 On Oct. 11, 2013, 11:53 a.m., Allan Anderson wrote:
  Can you hold for a little while, please.  I think I've found a problem.
 
 Allan Anderson wrote:
 I think the problem with the column widths is to do with the extra space 
 that is needed when a transaction is opened for editing.  That extra space is 
 being retained, resulting in the column widths being unnecessarily wide when 
 not being edited.
 
 The column width is controlled by 'if (m_usedWithEditor  
 !KMyMoneyGlobalSettings::transactionForm())' at line 1149 in
 void Register::resize(int col, bool force).
 
 m_usedWithEditor is enabled on line 204 in 
 KGlobalLedgerView::KGlobalLedgerView(QWidget *parent, const char *name) and 
 then seems to stay that way.  I've patched it instead to be enabled in 
 TransactionEditor* KGlobalLedgerView::startEdit(const 
 KMyMoneyRegister::SelectedTransactions list) and reset in void 
 KGlobalLedgerView::slotLeaveEditMode(const 
 KMyMoneyRegister::SelectedTransactions list).
 
 This allows the columns to shrink when not editing.  It is how I 
 controlled it in my earlier patches.

Yes, the problem I saw was that initially the column widths were too wide 
because space had been created for the edit buttons before a transaction had 
been opened for editing, because m_usedWithEditor was being enabled in 
KGlobalLedgerView ctor. I've changed this so m_usedWithEditor is enabled in 
KGlobalLedgerView::startEdit() and reset in 
KGlobalLedgerView::slotLeaveEditMode().

After this, there was a further problem as, after a transaction had been opened 
for editing and the column widths increased for the buttons, when the 
transaction was closed, there was no final resizing to shrink the columns to 
normal size.  I've patched this by adding the variable bool m_resizing to allow 
this final resize to take place.

I can't see any way for me to add a new patch to your review so I'll add it to 
the bug.


- Allan


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112989/#review41555
---


On Sept. 29, 2013, 11:37 a.m., Cristian Oneț wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/112989/
 ---
 
 (Updated Sept. 29, 2013, 11:37 a.m.)
 
 
 Review request for KMymoney.
 
 
 Bugs: 312816
 http://bugs.kde.org/show_bug.cgi?id=312816
 
 
 Repository: kmymoney
 
 
 Description
 ---
 
 Improve the resizing of the register and the transaction form.
 
 The transaction form was not correctly resizing the Value2 column
 when the data of the KMyMoneyEdit exceeded the size of the widget.
 The size of the push button (when present) was not considered when
 the width was computed based on the cell text.
 
 The same issues were fixed when for the inline transaction editor.
 
 The register resizing was improved in the following ways:
 - the number fields is no longer limited
 - the details column can no longer be shrinked to a size smaller then
 it's needed to render the data it contains
 
 BUG: 312816
 
 
 Diffs
 -
 
   kmymoney/widgets/kmymoneydateinput.cpp 
 856efaa9ddffcec7440cf3530349568d2c789333 
   kmymoney/widgets/register.h 50ce7598783b49197de6acf4859a0fbd7c5c8962 
   kmymoney/widgets/register.cpp d5dd63951d35b7098c0797fe64f10baf07a77fe1 
   kmymoney/widgets/transactionform.cpp 
 642e98f97eb98a14676186c296c1b27972f195cd 
 
 Diff: http://git.reviewboard.kde.org/r/112989/diff/
 
 
 Testing
 ---
 
 Ledger resize with/without the transaction form with multiple account types.
 
 
 Thanks,
 
 Cristian Oneț
 


___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel


[Kmymoney-devel] [kmymoney4] [Bug 312816] Resize ledger No. column

2013-10-13 Thread allan
https://bugs.kde.org/show_bug.cgi?id=312816

allan agande...@gmail.com changed:

   What|Removed |Added

  Attachment #82484|0   |1
is obsolete||

--- Comment #15 from allan agande...@gmail.com ---
Created attachment 82824
  -- https://bugs.kde.org/attachment.cgi?id=82824action=edit
REVIEW:112989 - Improve the resizing of the register and the transaction form.

This patch updates Cristian's in REVIEW:112989.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel


Re: [Kmymoney-devel] Review Request 112989: Improve the resizing of the register and the transaction form.

2013-10-13 Thread Allan Anderson


 On Oct. 11, 2013, 11:53 a.m., Allan Anderson wrote:
  Can you hold for a little while, please.  I think I've found a problem.
 
 Allan Anderson wrote:
 I think the problem with the column widths is to do with the extra space 
 that is needed when a transaction is opened for editing.  That extra space is 
 being retained, resulting in the column widths being unnecessarily wide when 
 not being edited.
 
 The column width is controlled by 'if (m_usedWithEditor  
 !KMyMoneyGlobalSettings::transactionForm())' at line 1149 in
 void Register::resize(int col, bool force).
 
 m_usedWithEditor is enabled on line 204 in 
 KGlobalLedgerView::KGlobalLedgerView(QWidget *parent, const char *name) and 
 then seems to stay that way.  I've patched it instead to be enabled in 
 TransactionEditor* KGlobalLedgerView::startEdit(const 
 KMyMoneyRegister::SelectedTransactions list) and reset in void 
 KGlobalLedgerView::slotLeaveEditMode(const 
 KMyMoneyRegister::SelectedTransactions list).
 
 This allows the columns to shrink when not editing.  It is how I 
 controlled it in my earlier patches.
 
 Allan Anderson wrote:
 Yes, the problem I saw was that initially the column widths were too wide 
 because space had been created for the edit buttons before a transaction had 
 been opened for editing, because m_usedWithEditor was being enabled in 
 KGlobalLedgerView ctor. I've changed this so m_usedWithEditor is enabled in 
 KGlobalLedgerView::startEdit() and reset in 
 KGlobalLedgerView::slotLeaveEditMode().
 
 After this, there was a further problem as, after a transaction had been 
 opened for editing and the column widths increased for the buttons, when the 
 transaction was closed, there was no final resizing to shrink the columns to 
 normal size.  I've patched this by adding the variable bool m_resizing to 
 allow this final resize to take place.
 
 I can't see any way for me to add a new patch to your review so I'll add 
 it to the bug.
 


I've added my patch to the bug you've quoted, but I think you should actually 
have referred to Bug 325341 - Improve the column sizes auto adjustment of the 
register when the transaction form is disabled and the register is in read only 
mode. This improves register column sizes in the Payee, Tags views and in the 
transaction search and autofill dialogs.


- Allan


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112989/#review41555
---


On Sept. 29, 2013, 11:37 a.m., Cristian Oneț wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/112989/
 ---
 
 (Updated Sept. 29, 2013, 11:37 a.m.)
 
 
 Review request for KMymoney.
 
 
 Bugs: 312816
 http://bugs.kde.org/show_bug.cgi?id=312816
 
 
 Repository: kmymoney
 
 
 Description
 ---
 
 Improve the resizing of the register and the transaction form.
 
 The transaction form was not correctly resizing the Value2 column
 when the data of the KMyMoneyEdit exceeded the size of the widget.
 The size of the push button (when present) was not considered when
 the width was computed based on the cell text.
 
 The same issues were fixed when for the inline transaction editor.
 
 The register resizing was improved in the following ways:
 - the number fields is no longer limited
 - the details column can no longer be shrinked to a size smaller then
 it's needed to render the data it contains
 
 BUG: 312816
 
 
 Diffs
 -
 
   kmymoney/widgets/kmymoneydateinput.cpp 
 856efaa9ddffcec7440cf3530349568d2c789333 
   kmymoney/widgets/register.h 50ce7598783b49197de6acf4859a0fbd7c5c8962 
   kmymoney/widgets/register.cpp d5dd63951d35b7098c0797fe64f10baf07a77fe1 
   kmymoney/widgets/transactionform.cpp 
 642e98f97eb98a14676186c296c1b27972f195cd 
 
 Diff: http://git.reviewboard.kde.org/r/112989/diff/
 
 
 Testing
 ---
 
 Ledger resize with/without the transaction form with multiple account types.
 
 
 Thanks,
 
 Cristian Oneț
 


___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel


[Kmymoney-devel] [kmymoney4] [Bug 325886] Custom report crashes

2013-10-13 Thread George
https://bugs.kde.org/show_bug.cgi?id=325886

George hexd...@fastmail.fm changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from George hexd...@fastmail.fm ---
Well for some reason the reports are working fine now.
I don't know what to say other than to report this as closed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel


[Kmymoney-devel] [kmymoney4] [Bug 325886] Custom report crashes

2013-10-13 Thread George
https://bugs.kde.org/show_bug.cgi?id=325886

George hexd...@fastmail.fm changed:

   What|Removed |Added

  Latest Commit||fixed somehow

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel


[Kmymoney-devel] [kmymoney4] [Bug 325980] New: KMM crashes when editing transaction to make it a split transaction

2013-10-13 Thread Steven
https://bugs.kde.org/show_bug.cgi?id=325980

Bug ID: 325980
   Summary: KMM crashes when editing transaction to make it a
split transaction
Classification: Unclassified
   Product: kmymoney4
   Version: 4.6.3
  Platform: Ubuntu Packages
OS: Linux
Status: UNCONFIRMED
  Keywords: drkonqi
  Severity: crash
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: castletonr...@btinternet.com

Application: kmymoney (4.6.3)
KDE Platform Version: 4.11.2
Qt Version: 4.8.4
Operating System: Linux 3.11.0-11-generic x86_64
Distribution: Ubuntu Saucy Salamander (development branch)

-- Information about the crash:
Editing an existing transaction, to split it into 3 components.

This is the first time KMM has ever crashed on me.

I am using GDM / Gnome 3.9.9 - up until krecently I used KDM.

The crash can be reproduced every time.

-- Backtrace:
Application: KMyMoney (kmymoney), signal: Segmentation fault
Using host libthread_db library /lib/x86_64-linux-gnu/libthread_db.so.1.
[Current thread is 1 (Thread 0x7f0ce43db7c0 (LWP 2617))]

Thread 3 (Thread 0x7f0ccae25700 (LWP 2620)):
#0  0x7f0cdecf0bbd in read () at ../sysdeps/unix/syscall-template.S:81
#1  0x7f0cda378660 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x7f0cda3391bc in g_main_context_check () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x7f0cda33962b in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#4  0x7f0cda339afa in g_main_loop_run () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#5  0x7f0cd1ff49d6 in ?? () from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
#6  0x7f0cda35e0e5 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#7  0x7f0cdaa02f6e in start_thread (arg=0x7f0ccae25700) at
pthread_create.c:311
#8  0x7f0cdecfeecd in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:113

Thread 2 (Thread 0x7f0cc037b700 (LWP 2621)):
#0  0x7f0cda3790d0 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#1  0x7f0cda379389 in g_mutex_lock () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x7f0cda33911c in g_main_context_check () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x7f0cda33962b in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#4  0x7f0cda33979c in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#5  0x7f0ce08bea76 in QEventDispatcherGlib::processEvents
(this=0x7f0cb80008c0, flags=...) at kernel/qeventdispatcher_glib.cpp:426
#6  0x7f0ce08905ef in QEventLoop::processEvents
(this=this@entry=0x7f0cc037ad70, flags=...) at kernel/qeventloop.cpp:149
#7  0x7f0ce08908e5 in QEventLoop::exec (this=this@entry=0x7f0cc037ad70,
flags=...) at kernel/qeventloop.cpp:204
#8  0x7f0ce078f88f in QThread::exec (this=this@entry=0x2650010) at
thread/qthread.cpp:542
#9  0x7f0ce0871d13 in QInotifyFileSystemWatcherEngine::run (this=0x2650010)
at io/qfilesystemwatcher_inotify.cpp:265
#10 0x7f0ce0791f2f in QThreadPrivate::start (arg=0x2650010) at
thread/qthread_unix.cpp:338
#11 0x7f0cdaa02f6e in start_thread (arg=0x7f0cc037b700) at
pthread_create.c:311
#12 0x7f0cdecfeecd in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:113

Thread 1 (Thread 0x7f0ce43db7c0 (LWP 2617)):
[KCrash Handler]
#5  QCoreApplication::notifyInternal (this=0x1f1dbc0,
receiver=receiver@entry=0x3832f40, event=event@entry=0x7fffc778eee0) at
kernel/qcoreapplication.cpp:933
#6  0x7f0cdff4aebd in sendEvent (event=0x7fffc778eee0, receiver=0x3832f40)
at ../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:231
#7  QInputContext::sendEvent (this=optimized out, event=...) at
inputmethod/qinputcontext.cpp:280
#8  0x7f0cdff4ae72 in QInputContext::sendEvent (this=0x26558d0, event=...)
at inputmethod/qinputcontext.cpp:271
#9  0x7f0cc05f38b1 in
IBusInputContext::displayPreeditText(IBus::PointerIBus::Text const, unsigned
int, bool) () from
/usr/lib/x86_64-linux-gnu/qt4/plugins/inputmethods/libqtim-ibus.so
#10 0x7f0ce08a5a58 in QMetaObject::activate (sender=0x2655bf0, m=optimized
out, local_signal_index=optimized out, argv=0x7fffc778f2e0) at
kernel/qobject.cpp:3539
#11 0x7f0cc03b1264 in
IBus::InputContext::updatePreeditText(IBus::PointerIBus::Text const,
unsigned int, bool) () from /usr/lib/libibus-qt.so.1
#12 0x7f0cc03a6a70 in
IBus::InputContext::slotUpdatePreeditText(QDBusVariant const, unsigned int,
bool) () from /usr/lib/libibus-qt.so.1
#13 0x7f0ce08a5a58 in QMetaObject::activate (sender=0x26504b0, m=optimized
out, local_signal_index=optimized out, argv=0x7fffc778f460) at
kernel/qobject.cpp:3539
#14 0x7f0cc03af854 in IBusInputContextProxy::UpdatePreeditText(QDBusVariant
const, unsigned int, bool) () from /usr/lib/libibus-qt.so.1
#15 0x7f0cc03b07d6 in ?? () from /usr/lib/libibus-qt.so.1
#16 0x7f0cc03b1053 in IBusInputContextProxy::qt_metacall(QMetaObject::Call,
int, 

[Kmymoney-devel] [kmymoney4] [Bug 272631] Crash while using IBus and the account selector combo

2013-10-13 Thread Jekyll Wu
https://bugs.kde.org/show_bug.cgi?id=272631

Jekyll Wu adap...@gmail.com changed:

   What|Removed |Added

 CC||castletonr...@btinternet.co
   ||m

--- Comment #34 from Jekyll Wu adap...@gmail.com ---
*** Bug 325980 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel


[Kmymoney-devel] [kmymoney4] [Bug 272631] Crash while using IBus and the account selector combo

2013-10-13 Thread Jekyll Wu
https://bugs.kde.org/show_bug.cgi?id=272631

Jekyll Wu adap...@gmail.com changed:

   What|Removed |Added

   Version Fixed In||4.6.4

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel